[00:16:38] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: *Existing* campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2500734 (Eile... [01:42:59] (PS4) Ejegg: Not using referrer from messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/289887 (https://phabricator.wikimedia.org/T110564) [02:01:57] (CR) Ejegg: [C: 1] "looks good, just one style note" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [02:14:20] (CR) Ejegg: "needs .lock update :P" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301398 (owner: Awight) [02:15:53] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Nonexistent campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2500851 (awi... [02:30:49] (CR) Ejegg: [C: 1] "This patch all looks good so far" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [02:36:30] (CR) Ejegg: "I like that this goes in the direction of rendering forms without an instance, but so much of the form classes still assumes an adapter..." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [02:37:44] (CR) Ejegg: [C: 2] "Anything that de-obfuscates this function is awesome by me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301417 (owner: Awight) [02:41:59] (CR) Ejegg: [C: 1] "Still confusing cos of hooks, but it cuts down on code in that monster function!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 (owner: Awight) [04:20:03] (PS1) Eileen: Revert "Revert "CRM-18744 - Remember quicksearch field selection"" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301539 (https://phabricator.wikimedia.org/T140293) [04:20:05] (PS1) Eileen: CRM-18744 - Add prompt text when search term not found [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301540 (https://phabricator.wikimedia.org/T140293) [05:05:28] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2501115 (Eileen... [05:05:45] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2448458 (Eileen... [05:06:19] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2501117 (Eileenmcnaughton) no :-( [06:24:37] (PS1) Eileen: Update to 4.7.10 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301545 [14:52:15] (PS1) Eileen: Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) [14:55:21] (CR) jenkins-bot: [V: -1] Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [14:58:56] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah Hernandez - https://phabricator.wikimedia.org/T138100#2501965 (Pcoombe) @CCogdill_WMF ecom and the other stats tools don't need any separate rights, just access to lutetium and the database tables via mysql. She will n... [15:24:20] (PS1) Eileen: Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) [15:25:39] (PS2) Eileen: Update to 4.7.10 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301545 [15:25:41] (PS1) Eileen: CRM-19148 Fix for on hold data being lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301620 (https://phabricator.wikimedia.org/T135062) [15:27:31] (CR) jenkins-bot: [V: -1] Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [16:00:55] (PS1) Ejegg: Quit mirroring / deleting pending queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433) [16:08:53] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301634 [16:09:27] i have to run and get fanny from the sitter, will be back for tech talk! [16:41:33] (PS2) Ejegg: Remove a bunch of trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301317 (owner: Eileen) [16:41:41] (CR) Ejegg: [C: 2] Remove a bunch of trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301317 (owner: Eileen) [16:43:32] (Merged) jenkins-bot: Remove a bunch of trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301317 (owner: Eileen) [16:48:52] fr-tech: anyone want to review this white-screen-of-death fix? https://gerrit.wikimedia.org/r/301428 [17:03:15] (CR) Ejegg: [C: -1] "Signature edits are consistent, but the 'source' property access is unsafe" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301318 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [17:04:13] ejegg: Yea, I'll take a look [17:06:25] thanks XenoRyet ! Want to join us in the fr-tech-talk? [17:06:42] Yea, gimme one or two minutes and I'll be in. [17:14:42] hi awight ! fr-tech-talk? [17:15:02] joining! [17:32:06] legoktm: the callback function for extension registration doesn't expect a true return value, correct? [17:32:12] also, hi! [17:38:17] Fundraising-Backlog, FR-ActiveMQ: Spike: Design delay handling - https://phabricator.wikimedia.org/T131282#2502616 (awight) [18:01:49] (PS35) AndyRussG: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [18:11:34] (PS1) Ejegg: Configurable queue mirroring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301656 (https://phabricator.wikimedia.org/T133195) [18:12:17] ^^ oughtta do the mirroring for us. I'll update vagrant DI settings [18:22:17] fr-tech: https://gerrit.wikimedia.org/r/301302 updates vagrant to go with the configurable queue mirroring [18:22:35] sweet [18:22:40] do i just clone this and provision? [18:22:55] cwd needs https://gerrit.wikimedia.org/r/301656 merged as well, but yeah [18:23:14] cool [18:23:59] i'm still thrashing at at newgerrit a little [18:24:34] uff, yep [18:25:01] I can't figure out how to edit the commit message online now [18:25:28] oh wait, i guess you just use the thing that can edit any part of the commit? [18:25:29] i hate the keyboard shortcuts [18:25:38] i guess? [18:25:44] gawd, me too. lessee if you can disable 'em [18:25:53] nothing i could find [18:26:32] Keymap: default / emacs / vim ??? [18:26:54] there is this thing: https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/ [18:26:56] under edit prefs, i guess probably only for when you're in an edit window already [18:27:26] whoa, looks like quite a potential distraction :) [18:27:28] apparently the UI we use is already "legacy" [18:40:49] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ: Migrate banner history queue off ActiveMQ - https://phabricator.wikimedia.org/T141555#2502860 (Ejegg) [18:49:04] (PS1) Ejegg: Move banner history off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) [18:50:55] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ: Migrate banner history queue off ActiveMQ - https://phabricator.wikimedia.org/T141555#2502860 (Ejegg) p:Triage>Normal [19:21:02] AndyRussG: no, no return value [19:26:07] legoktm: cool beans, thx! [19:32:09] this is good stuff: https://www.youtube.com/watch?v=ZYQmNfm9cME [19:33:34] They don't have to pay people to advertise [19:34:13] guy's delivery is excellent [19:34:16] It is a pretty funny new way to call out mobilezombies tho [19:34:17] "did you get one?" [19:38:35] wm-dev spam [19:39:16] wtf [19:39:38] how are they changing the topic, though [19:43:45] fr-tech: does this look familiar to anyone? Unknown column 'form_amount' in 'field list' [19:43:48] i just ran update.php [19:44:05] erm it does look familiar [19:44:13] I think that column is missing in the ContributionTracking schema [19:44:26] cwd: yeah [19:44:38] easiest just to nuke the table and redo [19:44:43] I'll dump a create script [19:44:44] cool [19:44:55] uh weird [19:44:59] we added the columns in 2012 [19:45:57] to prod? [19:46:01] but they never made it to schema? [19:46:14] cwd https://phabricator.wikimedia.org/P3595 [19:46:22] awight: i didn't write a migration tho [19:46:35] Extension:ContributionTracking should create them is the odd part [20:03:33] Turns out we have bigger problems wrt the contribution_tracking schema--we're installing it from a bogus Drupal module during the CRM unit tests, and from the MediaWiki extension in update.php [20:03:37] yipes. [20:03:54] (CR) AndyRussG: "Woops wrong URL, will the real checklist please stand up:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [20:05:24] AndyRussG: meeting? [20:24:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web-Backlog: Measure impact of mobile web link preview on Central Notice interaction - https://phabricator.wikimedia.org/T131373#2503126 (Jdlrobson) Open>Invalid This feature does not exist yet (link previews... [20:25:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web-Backlog: Avoid z-index conflict with mobile web link preview & Central Notice and friends - https://phabricator.wikimedia.org/T131372#2503137 (Jdlrobson) Open>Invalid This feature does not exist yet (link... [20:26:11] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Migrate fredge to new queue - https://phabricator.wikimedia.org/T131273#2503151 (Ejegg) a:Ejegg [20:48:31] cwd: XenoRyet ejegg|afk sorry got a bit waylaid, still here at the library... what time was the vagrant batcave planned at again? 2 PDT? [20:49:25] AndyRussG|bassoo: yep, in 10 min [20:51:24] ejegg|afk: K thx I may still be a bit late :( I'll do my best ;p [20:51:38] (pls don't wait up....) [21:04:37] what link should we use for this chat? [21:05:41] gotta reboot... [21:05:43] Just the standup one maybe? [21:05:50] k [21:09:20] sure [21:09:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2503412 (RLewis) @Eileenmcnaughton and @DStrine thanks, this sounds like a great process. I haven't made the changes on Productio... [21:10:22] cool. I'm in there. [21:10:39] brt [22:07:36] Fundraising-Backlog: Investigate forms in emails prefilling payments wiki fields - https://phabricator.wikimedia.org/T137233#2503608 (DStrine) bumping this @dpatrick do you have any opinions on this? I could set up a meeting if you would like to discuss further. [22:28:41] Damn, hangouts crash [22:28:51] trying to get back in. [22:31:02] (CR) Cdentinger: [C: 2] Configurable queue mirroring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301656 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [22:32:33] (Merged) jenkins-bot: Configurable queue mirroring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301656 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [22:57:16] (CR) Cdentinger: "I get the fail page as expected when I put in a nonsense payment method for GC. Regarding the exception, would it be better to fix what's " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301428 (owner: Ejegg) [23:12:42] (PS1) Ejegg: Update libs with SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/301722 [23:13:04] (CR) Ejegg: [C: 2] Update libs with SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/301722 (owner: Ejegg) [23:14:17] (PS2) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301634 [23:14:35] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301634 (owner: Ejegg) [23:15:10] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301634 (owner: Ejegg) [23:17:09] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301723 [23:17:22] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301723 (owner: Ejegg) [23:20:52] (CR) Cdentinger: [C: 2] "After looking at the code I don't think there's actually a better way to handle this." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301428 (owner: Ejegg) [23:21:00] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301723 (owner: Ejegg) [23:22:23] (Merged) jenkins-bot: Catch exceptions in setClientVariables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301428 (owner: Ejegg) [23:24:49] (CR) Ejegg: [V: 2] Update libs with SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/301722 (owner: Ejegg) [23:29:32] !log updated payments-wiki from 2d9dd79507a42ced0a99bde87b3c45b804610e40 to 3a724bfb1a3e20e17b5886dae0ba7572020abd6b4 [23:29:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:42:54] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 14 others: [Epic] All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2224734 (Ejegg) D... [23:51:48] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2419545 (Ejegg) I think I found it - we're missing rows in the wmf_contribution_extra for some of those donations, wh... [23:56:23] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2504067 (Ejegg) a:Ejegg