[05:56:20] Fundraising-Backlog: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#2510920 (Eileenmcnaughton) @dstrine - sure assign it to me - shall we bring it into this sprint? [10:28:58] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Prevent bad Cyrillic encoding - https://phabricator.wikimedia.org/T140564#2511247 (Aklapper) This task has been "Unbreak now!" priority ([[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | "needs to be fix... [11:43:06] Fundraising Tech Backlog: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2511334 (jcrespo) Resolved>Open 1800 seconds is still not enough, it goes beyond that: ``` PROBLEM - check_mysql on fdb2001 is CRITICAL: SLO... [11:55:32] Fundraising Tech Backlog: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2011008 (fgiunchedi) reopening, looks like this happened again today ``` 12:30 -icinga-wm:#wikimedia-operations- PROBLEM - check_mysql on fdb2001 is CRITICAL: SLO... [12:45:10] Fundraising Tech Backlog: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2511437 (Jgreen) Acknowledged. We enabled some rollback functionality in civicrm a couple months ago which significantly increased the size of the database, which... [15:26:30] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2511772 (dr0ptp4kt) [15:27:06] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2165081 (dr0ptp4kt) [15:59:44] Fundraising Tech Backlog: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2511870 (Jgreen) p:Normal>High I modified the nagios collector to change parameters on the fly for check_mysql if mysqldump is running. Keeping this ticket... [16:40:49] (CR) Ejegg: [C: 1] "Looks good, just wondering if there was a mistake in the existing code." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [17:03:04] (CR) Ejegg: "a few suggestions" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [17:30:16] (CR) Ejegg: [C: -1] "Kind of silly that we're calling all those normalization functions on external_data in the first place - shouldn't we trust messages to al" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [17:41:45] Most importantly, does anyone know of a tool for recording internet radio according to a schedule? [17:42:09] sounds like a job for linux [17:42:45] I wanna run such a thing on a VPS and have it archive my favorite DJs... [17:43:04] i bet there is a cli tool [17:43:32] i don't really know how streams work [17:44:01] hi awight [17:44:15] I'm almost hoping nothing exists, so I can write it... Yeah it would just be plugging a stream recorder into an at-job thing [17:44:17] and cwd [17:44:18] ejegg: hey! [17:45:00] howdy! [17:45:43] I pretty thoroughly reset over the weekend. Blissfully unaware of what I'm doing today [17:46:05] heh, nice [17:46:07] hehe me too [17:46:15] it's coming back into focus now [17:46:23] i just scribbled on a couple of those orphan patches [17:47:00] oh grate, thx! [17:47:20] I got up at 5:00 AM to drive back from Vegas, so I'm unaware, but maybe not so blissful... [17:47:47] damn [17:48:00] urrrgh. Hope you didn't win too much? [17:48:17] It's the only time to get out of there if you don't want to be in traffic from Vegas all the way to the state line. [17:48:29] looking forward to derby tales [17:48:41] There are a few. [17:50:23] (PS2) Ejegg: Do away with redundant YAML quoting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [17:50:36] i finally got around to installing solar in the van: http://i.imgur.com/VahSbTq.jpg [17:50:51] self-tapping sheet metal screws FTP [17:50:52] W [17:51:04] nice flooring! [17:51:21] and put in a vent: http://i.imgur.com/yAGVtUT.jpg [17:51:59] there are little pieces of cork on the self tapping sheet metal screws [17:52:02] nice! [17:52:16] If you're penetrating the roof, you might as well drive out here so we can weld a rack on the top [17:52:16] Good times [17:52:19] (CR) jenkins-bot: [V: -1] Do away with redundant YAML quoting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [17:52:36] that's the plan [17:52:45] this winter, be there around all-hands time [17:54:18] it rained 1/2" in like 15m last night and nothing leaked [17:54:33] well...i'm actually going to verify that [17:54:57] you had to say it out loud. [17:56:16] I would put a ton of bituthene down around those screws... /me has great fear for roof integrity [17:56:44] (PS1) Ejegg: Remove unused module [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/302284 [17:57:23] (CR) Awight: [C: 2] Remove unused module [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/302284 (owner: Ejegg) [17:57:25] (CR) Ejegg: "needs I19909af06a98db89f" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300707 (owner: Awight) [17:57:44] thx! [17:59:30] (CR) Ejegg: "looks like labels with colons still need quotes. also looks like we can get rid of some of those submethods" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [17:59:52] (CR) Ejegg: [V: 2] Remove unused module [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/302284 (owner: Ejegg) [18:00:20] no leaks! [18:00:27] not even the screws that are still submerged [18:00:34] there is a puddle on top [18:00:39] (PS3) Awight: Do away with redundant YAML quoting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 [18:00:57] i just used 100% silicone [18:00:58] awight: matching removal patch for vagrant: https://gerrit.wikimedia.org/r/301899 [18:01:23] I've never had good luck. I tried to re-roof a friend's shipping container recently, to replace badly patched rustholes. no sirve [18:01:30] nice. [18:03:06] (PS2) Ejegg: Remove WorldPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300707 (owner: Awight) [18:03:20] (CR) jenkins-bot: [V: -1] Do away with redundant YAML quoting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [18:04:02] we should just start titling them "improve worldpay" in case they creep on our tickets [18:04:08] still technically true [18:04:37] 8d [18:04:40] hehe [18:06:52] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [18:08:30] (CR) Awight: [C: -2] "(cannot be merged yet)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) (owner: Ejegg) [18:10:18] (CR) jenkins-bot: [V: -1] Remove WorldPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300707 (owner: Awight) [18:10:36] (CR) Ejegg: "oops, I clobbered the commit message warning when I uploaded PS3" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) (owner: Ejegg) [18:11:32] argh: PHP Fatal error: Call to a member function getDriver() on a non-object in /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp/src/Amp/Database/MySQL.php on line 58 [18:11:46] CI is really falling to pieces today. [18:11:58] And the earlier job failed cos it couldn't clone from github [18:12:31] at least we're not hitting sourceforge any more [18:13:02] (CR) Awight: "Looks good, I'll merge after the prerequisites land and I've had a chance to smoke test." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) (owner: Ejegg) [18:16:23] awight / cwd: new script to backfill wmf_contribution_extra, should be less lock-y & more accurate https://phabricator.wikimedia.org/P3602 [18:17:11] also an export fix: https://gerrit.wikimedia.org/r/301857 [18:17:47] We might need to put the queue stuff on a feature branch... [18:18:12] It's sad seeing perfectly good patches getting blocked and backlogged [18:19:16] (CR) Awight: [C: 2] Quit suppressing contacts with no donation record [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/301857 (https://phabricator.wikimedia.org/T139102) (owner: Ejegg) [18:19:22] (Merged) jenkins-bot: Quit suppressing contacts with no donation record [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/301857 (https://phabricator.wikimedia.org/T139102) (owner: Ejegg) [18:19:40] * awight grimaces at noop CI [18:20:48] ejegg: re. the backfill script, wanna drop that into the crm repo? [18:21:02] awight: sure, will do [18:21:52] nice edge cases :) if trxn_id is hella crazy then paypal [18:26:43] (PS1) Ejegg: Backfill wmf_contribution_extra [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302290 [18:27:32] awight: yep, looks like that was all we had with trxn ids at some point [18:28:01] am i crazy or is composer putting DI in extensions/ in crm? [18:28:45] cwd: that is happening. it's not a good thing [18:29:03] We were experimenting with composer installers... [18:29:07] cwd it's that silly installer I added [18:29:12] I think I'll take it back out [18:29:50] I wish there were a way to make the installer conditional [18:30:10] why not just in vendor like everything else? [18:30:14] But it's a declarative "type" field, so we'd have to write a new plugin and stuff [18:30:25] ah yeah i saw that, mediawiki-extension [18:30:37] cwd: The idea is that you can composer require DI in a MediaWiki directory and it'll be magically wonderful [18:31:17] that would be handy [18:31:22] but it might be confusing [18:34:25] i feel like i wouldn't want to encourage people to install something called a mediawiki extension from outside mediawiki [18:35:27] oh wait, maybe there's a simple solution--we fix the mediawiki-extension installer to fall back to normal library behavior in case !mediawiki [18:35:32] ejegg: ^ [18:35:45] but yeah, also what cwd said. [18:36:22] it gives the impression that "mw extensions work in crm" [18:36:58] +1. we have separation issues [18:38:29] awight: ah, yeah, that would be interesting [18:39:43] awight: want me to wait till the backfill script is merged before running it in production? I plan to run it step by step and examine before inserting into the final table [18:40:06] awight: will T109819 need changed in crm? if so i guess it's blocked by that update [18:40:07] T109819: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819 [18:40:50] ejegg: Mostly I just wanted a place to take CR notes, but feel free to run in safe mode. Up to your own comfort level, really [18:41:03] k [18:41:18] cwd: yeah I think the CRM consumer should be made more liberal [18:41:23] what update? [18:41:37] as in we can't update DI in CRM right now [18:41:43] oh. heh hrm [18:41:45] it's on an ancient version [18:41:55] ah I think it's independent of that problem, actually [18:42:07] the queue consumer in CRM doesn't use any DI code [18:42:17] (regrettably!) [18:42:38] i suppose that's true [18:42:45] it's hard to test though [18:42:55] why's that? [18:43:20] hmm well [18:43:48] i guess no messages are produced by that DI [18:43:55] yeah so nm [19:03:38] (CR) Awight: [C: 2] "Nice hack!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301888 (https://phabricator.wikimedia.org/T141485) (owner: Ejegg) [19:06:31] (Merged) jenkins-bot: Configurable queue write mirroring [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301888 (https://phabricator.wikimedia.org/T141485) (owner: Ejegg) [19:15:31] Call to undefined method DonationInterface::createAdapter() in /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/wmf_civicrm/tests/phpunit/DonationInterfaceTest.php on line 24 [19:15:45] is this having something to do with it being in extensions/ ? [19:35:32] cwd class needs renaming, I think [19:35:49] see awight's patch [19:36:23] https://gerrit.wikimedia.org/r/#/c/301521/ [19:38:05] awight: cwd XenoRyet ejegg|food do we have doc somewhere for how our PCI stuff works, what's in scope and what's not, why, and what are the main rules we need to look out for? [19:38:18] Just for the purpose of how to put it in an interaction diagram [19:45:14] there have definitely been a few [19:45:17] let's see... [19:50:14] cwd: thx! [19:57:01] (CR) Awight: [C: -2] "Great! Cannot be deployed as written, yet..." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301671 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [20:37:37] awight: i think i'm up to speed with crm now [20:37:57] (CR) Eileen: Refactor failmail to use the Mailer class. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [20:38:10] as far as getting RequestContext under crm, is there some way besides including mw as a dep? [20:39:12] (PS6) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [20:42:28] (PS4) Eileen: Fix ProcessMessageTest to not fail on exchange rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301325 (https://phabricator.wikimedia.org/T138542) [20:49:26] ejegg: do you know what the plan is? regarding https://gerrit.wikimedia.org/r/#/c/300918/ [20:49:46] how to get RequestContext in crm, or what to use instead? [20:50:40] cwd shouldn't need to use any request or session stuff for the batch mode api calls we do under CRM [20:55:57] ejegg: ah, do we somehow skip DI tests for CRM? [20:56:15] if not, should we? [20:56:52] cwd we should definitely keep the test for constructing a GlobalCollect batch mode adapter [20:57:24] but we shouldn't be running the whole DI test suite as a part of the CRM one [20:59:58] i feel like we're doing something wrong distributing test with DI that won't pass under normal usage [21:00:09] won't we have to block CI somehow? [21:00:42] why would we have to? [21:01:41] I'd consider 'normal usage' to be deploying as a mediawiki extension [21:02:25] if i run phpunit from crm it fails cause it can't find request context [21:02:42] but you are saying it shouldn't run those tests if you aren't on mw? [21:04:07] not that it shouldn't right now...but that it shouldn't generally [21:04:22] we should make it skip them? [21:04:55] cwd: I'm in the middle of fixing that [21:05:14] cwd: See all the dependencies leading up to https://gerrit.wikimedia.org/r/#/c/300173/ [21:05:42] This is the thing ejegg was mentioning, where CRM currently only works with an ancient fork of DonationInterface [21:06:05] The WmfFramework thing is really horrible, but it's just an incremental way to decouple ourselves from MediaWiki [21:06:21] cwd: This is probably the most relevant to what you're looking at, https://gerrit.wikimedia.org/r/#/c/300933/8 [21:07:22] spot checks on missing_extra records look good, I'm about to dump 'em in wmf_contribution_extra [21:08:06] inserting... [21:18:52] * awight rocks the boat for lulz [21:22:47] (CR) Awight: [C: 2] Compare pending db/queue in Adyen RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [21:27:47] awight: I just noticed this task & figure I could write that up if we maybe scheduled say a 45 min group chat on it? https://phabricator.wikimedia.org/T140844 [21:28:11] eileen: sure, thanks! [21:28:34] I have some notes to contribute, based on our meetings with legal [21:28:54] do you have a pref between tomorrow & the next day? ie. after grooming or before planning are probably good slots [21:29:00] (or today) [21:30:50] eileen: Any of those times works for me, including today [21:31:16] we could just talk now? [21:31:24] cool [21:31:43] is there anyone specific we need input from or is it all in your head? [21:32:24] sort of neither ;) [21:33:20] OK - well lets use the autopsy google & if anyone else wants to join they can (cwd XenoRyet ejegg|away AndyRussG ) [21:33:23] https://etherpad.wikimedia.org/p/donor-data [21:33:43] maybe a google doc instead, for non-publicness [21:33:51] ok - good point [22:18:12] Fundraising-Backlog, FR-Adyen, FR-WMF-Audit: Adyen audit parser is choking on new payment type - https://phabricator.wikimedia.org/T141821#2513338 (awight) [22:18:22] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-Adyen, FR-WMF-Audit, Unplanned-Sprint-Work: Adyen audit parser is choking on new payment type - https://phabricator.wikimedia.org/T141821#2513350 (awight) [22:20:05] (CR) Eileen: "Ie this needs merging first https://gerrit.wikimedia.org/r/#/c/301545/2/CRM/Upgrade/Incremental/php/FourSeven.php" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [22:20:58] (CR) Awight: [C: 2] Update to 4.7.10 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301545 (owner: Eileen) [22:21:40] (PS3) Awight: Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [22:21:58] (CR) Awight: Update pending db to match queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [22:27:01] trying an experiment, brb [22:28:24] (CR) Eileen: "@awight - thanks - looks like it won't merge because of 2 others in the dependency chain -basically I removed my hack for the search issue" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301545 (owner: Eileen) [22:33:31] (CR) XenoRyet: [C: 2] Revert "Revert "CRM-18744 - Remember quicksearch field selection"" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301539 (https://phabricator.wikimedia.org/T140293) (owner: Eileen) [22:34:17] (CR) XenoRyet: [C: 2] CRM-18744 - Add prompt text when search term not found [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301540 (https://phabricator.wikimedia.org/T140293) (owner: Eileen) [22:34:44] eileen: Just saw those two ^. They look good, and seems like a solid strategy to me. [22:35:04] XenoRyet: ty! [22:35:13] No worries. Sorry I didn't get to it sooner. [22:35:53] (Merged) jenkins-bot: Revert "Revert "CRM-18744 - Remember quicksearch field selection"" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301539 (https://phabricator.wikimedia.org/T140293) (owner: Eileen) [22:36:23] (Merged) jenkins-bot: CRM-18744 - Add prompt text when search term not found [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301540 (https://phabricator.wikimedia.org/T140293) (owner: Eileen) [22:36:43] XenoRyet: yeah can't give them the nicest fix & take it away for another one :-) [22:36:48] (Merged) jenkins-bot: Update to 4.7.10 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301545 (owner: Eileen) [22:36:51] awight: Queue pending-new is not an AtomicReadBuffer [22:36:54] is this config? [22:44:11] yeah. Is that an error you're getting? [22:44:41] yeah, trying to ConsumePendingQueue.php [22:44:55] Fundraising Tech Backlog: Strine's second spacer task ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- - https://phabricator.wikimedia.org/T141059#2513488 (DStrine) [22:45:12] (PS1) Eileen: Hack out the slow part of the upgrade script. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302362 [22:45:12] Fundraising Tech Backlog: Strine's spacer task ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- - https://phabricator.wikimedia.org/T140944#2513489 (DStrine) [22:47:16] I just put in a very small patch for review - https://gerrit.wikimedia.org/r/#/c/302362/ once that is in I will deploy the pending CiviCRM updates [22:50:02] awight: is there a wrapper for those maintenance scripts or just php? [22:52:46] (CR) XenoRyet: [C: 2] Hack out the slow part of the upgrade script. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302362 (owner: Eileen) [22:53:44] thx XenoRyet [22:53:56] No worries. [22:56:47] pending-new is Predis which i thought was correct but does not implement AtomicReadBuffer [22:58:22] jenkins bot seems slow [22:58:59] (Merged) jenkins-bot: Hack out the slow part of the upgrade script. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302362 (owner: Eileen) [22:59:27] ah that worked - public shaming of jenkins-bot forced it into action [22:59:40] (PS1) Eileen: CiviCRM update - update to 4.7.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302364 [23:00:12] (CR) Eileen: [C: 2] "self-approving as this is a submodule update" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302364 (owner: Eileen) [23:02:11] (Merged) jenkins-bot: CiviCRM update - update to 4.7.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302364 (owner: Eileen) [23:10:14] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/302365 [23:10:17] nm! it was just out of date php-queue [23:12:03] awight: ejegg|awayis this OK to go out https://gerrit.wikimedia.org/r/#/c/296185/ [23:12:12] (it's in my merge-deploy - https://gerrit.wikimedia.org/r/#/c/302365/ ) [23:13:18] (PS2) Eileen: Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) [23:13:31] (PS2) Eileen: Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) [23:13:58] cwd: d'oh! sorry I missed that, got RL jacked [23:15:35] np! got it figured out [23:16:02] (CR) jenkins-bot: [V: -1] Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:16:13] eileen: yep,it's ok [23:16:30] (CR) jenkins-bot: [V: -1] Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:18:46] cool - I'll deploy it now then [23:21:25] awight: do you know if that fix for the missing field in contribution_tracking made it to vagrant? [23:23:56] i guess it would be the drush command where the sql actually lives? [23:24:29] cwd: I don't understand why we didn't have that field, it's not a recent change. [23:24:43] !log Updating civicrm from d657255e1edebeccfc0a03bea70b78eb11375cf8 to d657255e1edebeccfc0a03bea70b78eb11375cf8 [23:24:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:25:01] cwd: It does look like it made it to vagrant though [23:26:02] i again don't have it [23:26:05] or usd_amount [23:29:15] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/302365 (owner: Eileen) [23:29:22] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/302365 (owner: Eileen) [23:29:40] dang I went through all the steps … except the first one - merging the commit [23:31:06] !log Upgrading CiviCRM from d657255e1edebeccfc0a03bea70b78eb11375cf8 to 4904c4aae3565b65d5f37ecb827ea26c930b72d6 [23:31:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:34:16] awight: i'm all turned around, the message T109819 is talking about is the json blob in mysql right? [23:34:16] T109819: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819 [23:34:32] so the orphan rectifier is what will care about the format? [23:35:09] (PS3) Eileen: Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) [23:35:51] (PS3) Eileen: Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) [23:37:53] cwd: Sort of... it's about DonationInterface::DonationQueue, which creates records with e.g. a "fname" field. [23:38:02] We should send in the normalized format instead. [23:38:33] (CR) jenkins-bot: [V: -1] Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:38:43] awight: yep got that part, but wondering what will choke on a bad format [23:38:47] (CR) jenkins-bot: [V: -1] Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:38:56] "bad" meaning the new normalized one [23:40:58] cwd: It's the CRM consumer... [23:41:15] I'm imagining that we need to fix the consumer to accept the normalized message, then fix DQ to send it [23:41:57] awight: isn't this ths DQ part of that? https://gerrit.wikimedia.org/r/#/c/301865/ [23:42:50] the consumer in smashpig doesn't seem to care... [23:43:45] cwd: That's a utility to convert from the fname format to normalized, which is only used by the orphan rectifier. [23:49:43] cwd: ah I see that you see now. [23:49:47] So why didn't the tests fail... [23:49:52] scary stuff [23:50:32] awight: what i was thinking is it'd be the crm consumer that failed right? since DI is just sticking an object from redis into a blob in mysql [23:50:54] but i'm getting even more confused, all the records i see in mysql say e.g. first_name [23:50:59] there are two crm consumers [23:51:00] which is the new, nromalized format right? [23:51:06] it's the activemq one that uses the fname format [23:51:17] the pending database is the normalized format [23:51:23] my fault for writing such a sparse bug... [23:55:35] awight: what is the other consumer? [23:57:53] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2513742 (Eileen... [23:58:31] cwd: queue2civicrm [23:58:38] and wmf_civicrm [23:58:54] want to do a call to cut through my ADHD? [23:59:13] sure if you are not busy, if you're doing other stuff it's fine [23:59:46] (PS1) Eileen: When checking for valid option values include is_active in the check. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302374 (https://phabricator.wikimedia.org/T139969)