[00:01:01] cwd: u not on maybe? [00:01:29] awight: i can't in firefox...long story. can you click the standup link? [00:03:59] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2513769 (awight) [00:08:54] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2513775 (CCogdi... [00:17:29] (CR) Eileen: "The merge tests themselves are passing locally - but I DO experience the $user object issues locally so have not checked them as part of t" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [00:32:47] (PS4) Ejegg: Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) [00:47:47] (CR) Ejegg: Update pending db to match queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [00:52:21] (CR) Ejegg: Refactor failmail to use the Mailer class. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [00:58:47] (CR) Eileen: Refactor failmail to use the Mailer class. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [01:01:09] (PS5) Eileen: Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) [01:03:55] (CR) Eileen: "we lose the 'Error: ' this time but it doesn't fell terrible to do that. Are there exceptions that don't support getMessage() ?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [01:52:18] (PS4) Eileen: Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) [01:54:53] (CR) jenkins-bot: [V: -1] Add test/ handling to treat conflicts on email=on_hold as conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [01:56:12] (PS4) Eileen: Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) [01:58:56] (CR) jenkins-bot: [V: -1] Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [02:14:06] (PS5) Eileen: Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) [02:16:59] (CR) jenkins-bot: [V: -1] Add hook & tests for address handling. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [02:47:18] (PS1) Eileen: Revert "Don't create SQL function at runtime" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302379 [02:47:20] (PS1) Eileen: CRM-19165 Use permission sensitive function to create strip-numeric function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302380 [02:52:19] (CR) Eileen: "I believe this patch will fix the issue in CI" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [03:11:50] (PS6) Eileen: Drush merge command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 [03:17:34] (PS7) Eileen: Drush merge command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 [03:38:26] (CR) Eileen: "I've updated this with some minor tweaks you recommended. In addition the default is now to use the 'IndividualUnsupervised' rule - which " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 (owner: Eileen) [04:32:40] (PS1) Eileen: Create Utm_campaign option if it does not exist. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) [04:34:39] (CR) jenkins-bot: [V: -1] Create Utm_campaign option if it does not exist. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [04:57:30] (PS2) Eileen: Create Utm_campaign option if it does not exist. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) [14:45:58] fundraising-tech-ops: build two queue servers to replace silicon - https://phabricator.wikimedia.org/T137150#2515430 (faidon) [14:54:34] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/302442 [14:54:49] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/302442 (owner: Ejegg) [14:54:55] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/302442 (owner: Ejegg) [14:55:48] !log updated fundraising tools from 28bc2da677caa795c58f906db76a1f8d612ac899 to b3ed7ab3deac94c4e465d3768109bca05b6f0a0c [14:55:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [15:01:22] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2515468 (MBeat3... [15:08:32] (PS1) Ejegg: Add 'visadankort' payment method [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302445 [15:17:41] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: [Epic] Formalize schema for all message types - https://phabricator.wikimedia.org/T131272#2515498 (cwdent) [15:17:46] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2515496 (cwdent) Open>Invalid DonationQu... [16:21:10] cwd / XenoRyet speaking of Adyen, there's another trivial audit patch to review https://gerrit.wikimedia.org/r/302445 [16:21:25] Looking [16:21:27] I asked them for the full list again [16:22:18] Yea, hopefully they'll give it to us this time. [16:22:33] (CR) XenoRyet: [C: 2] Add 'visadankort' payment method [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302445 (owner: Ejegg) [16:23:30] (Merged) jenkins-bot: Add 'visadankort' payment method [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302445 (owner: Ejegg) [16:23:46] (CR) Ejegg: [C: 2] Do away with redundant YAML quoting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [16:25:26] (Merged) jenkins-bot: Do away with redundant YAML quoting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300706 (owner: Awight) [17:10:53] (PS1) Ejegg: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302470 [17:13:37] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2515901 (CCogdill_WMF) @Ejegg woo, thanks for the quick fix here! So should I run that query you sent earlier and pur... [17:22:27] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2515955 (Ejegg) Hi @CCogdill_WMF, I updated the export script this morning and it's running right now. Backfilling t... [17:22:58] (CR) Ejegg: [C: 2] Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302470 (owner: Ejegg) [17:27:43] am i here [17:27:48] oh good [17:27:56] fr-tech: tech talk in a few minutes? [17:28:59] sure [17:29:06] sure be there shortly [17:29:18] sure [17:29:45] main thing on my mind is that I have a nonexistent mental map of what we're all doing at this point. [17:30:03] would everyone please just make sure you have a card on the sprint for whatever it is you're currently on? [17:31:51] i just closed mine as invalid [17:31:55] the message format thing [17:32:21] hehe [17:35:46] Gotta check something real quick, be there in another minute or two. [17:57:33] network exploded [17:58:45] http://i.imgur.com/dPULlRL.png [18:00:39] Jeff_Green: we're in the hangout fyi [18:02:39] Here's one from last time: https://etherpad.wikimedia.org/p/Fundraising_configuration [18:02:44] fr-tech: ^ [18:02:57] Jeff_Green: also ^ [18:19:25] fr-tech... Ooops did I miss stuff? I don't see ayone in the fr-tech-talk call now... :( [18:19:40] AndyRussG: nah, we're on a call about payments config at the moment [18:19:57] Ahh K [18:20:15] Ahh double woops [19:02:11] sorry about dropping from the call, i'm accumulating data to use against comcast [19:06:37] (Merged) jenkins-bot: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302470 (owner: Ejegg) [19:18:35] Fundraising-Backlog, fundraising-tech-ops: Deprecate and remove twig and phpmailer projects - https://phabricator.wikimedia.org/T141914#2516480 (awight) [19:30:04] Jeff_Green: hehe nice hangup style :p [19:47:15] [A[B[B[B[B [19:47:26] :P [19:47:39] [A[B[B[B[B ? [19:48:01] arrow keys maybe? [19:48:03] You forgot the up, up, down, down, left, right, left, right part. [19:48:21] ejegg: oh, that's what came through? [19:48:44] i clicked on the [x] close button at the top right like 10x, and then everything went boom [19:56:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2516558 (AndyRussG) [20:01:25] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617#2516600 (AndyRussG) [20:05:05] hangout keeps kicking me out [20:05:53] ejegg: there are two of you, and three offices [20:11:56] Fundraising-Backlog, FR-ActiveMQ, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Hack the daylights out of legacy PayPal listener to do Redis - https://phabricator.wikimedia.org/T141654#2516643 (awight) [20:14:55] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617#2504968 (awight) Might be more appropriate to focus on just queue message data flow for now? [20:17:49] Fundraising-Backlog, Composer: Use composer-merge-plugin for paymentswiki - https://phabricator.wikimedia.org/T141434#2516677 (awight) [20:22:41] Fundraising-Backlog: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#2516688 (DStrine) [20:37:50] sigh - you guys are frozen now [20:38:09] or else you are just being eerily still [20:38:26] I'm still here [20:38:30] are you still on the call? [20:38:49] trying to get back on [20:46:47] Fundraising Sprint Nitpicking, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1679603 (DStrine) [20:47:25] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2516752 (DStrine) [20:47:50] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2516754 (DStrine) [20:48:20] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Pipeline Report - https://phabricator.wikimedia.org/T128818#2086989 (DStrine) [20:48:47] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2516759 (Eileenmcnaughton) SELECT SQL_CALC_FOUND_ROWS contact_... [20:53:09] Fundraising Sprint Nitpicking, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2516764 (DStrine) Here is a new prototype: https://civicrm.frdev.wikimedia.org/civicrm/report/instance/96?reset=1&force=1 [20:56:54] (PS1) Ejegg: Update SmashPig lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/302602 [20:57:06] (CR) Ejegg: [C: 2 V: 2] Update SmashPig lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/302602 (owner: Ejegg) [20:57:38] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/302604 [20:57:50] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/302604 (owner: Ejegg) [20:58:59] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/302604 (owner: Ejegg) [21:00:14] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2516774 (Eileenmcnaughton) I did fix the query that I was 'thi... [21:00:37] (PS2) Awight: Rename "data" variable to a more specific name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301417 [21:00:39] (PS27) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [21:00:41] (PS3) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [21:00:43] (PS9) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [21:01:19] !log updated civicrm from 4904c4aae3565b65d5f37ecb827ea26c930b72d6 to 9a971ff6d74ae8e14c1c9f854155d9829e6a0278 [21:01:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:02:21] (CR) jenkins-bot: [V: -1] Rename "data" variable to a more specific name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301417 (owner: Awight) [21:03:37] (CR) jenkins-bot: [V: -1] Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 (owner: Awight) [21:03:40] (CR) jenkins-bot: [V: -1] More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [21:04:27] fr-tech: Those patches might not pass CI at the moment, but I'm ready to spin through and at least explain my reasoning... [21:04:31] fr-tech-talk channel, or standup? [21:04:35] hehe /might/hellno [21:04:44] tech talk i guess. headed [21:08:37] cwd / XenoRyet / AndyRussG in the fr-tech-talk channel if you want to join [21:09:44] brt [21:15:50] coming! [22:37:59] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2517329 (Eileenmcnaughton) https://issues.civicrm.org/jira/browse/CRM-19167 [22:54:19] dstrine: we can change the name of 'Donor Report(Summary) at this url civicrm/admin/report/options/report_template?reset=1 - I feel we should change it to Donation Report (summary) - the normal name is 'Contribution Report Summary' [23:07:38] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2517382 (Eileenmcnaughton) @dstrine - I have patched 3 reports to have is_deceased as a filter - notabl... [23:13:27] Fundraising-Backlog: Access to lutetium and MySQL - https://phabricator.wikimedia.org/T141945#2517397 (LeanneS) [23:18:10] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2517446 (DStrine) Thanks! I think this is fine. I also agree with your contribution comments. This se... [23:23:27] eileen: so you want to change "donor report (summary)" and "donor report (detail)" to "Contribution Report (Summary)" and "Contribution Report (detail)"? [23:25:26] dstrine: well it can be donation or contribution [23:25:43] I think donor is wrong - but donation would be fine [23:26:20] Fundraising Sprint Nitpicking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Queue mirroring needs to copy source_* fields into the message body - https://phabricator.wikimedia.org/T141948#2517458 (awight) [23:26:34] (PS1) Eileen: CRM_19167 add is_deceased to contact reports (default 0) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302622 (https://phabricator.wikimedia.org/T140831) [23:26:50] Fundraising Sprint Nitpicking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Queue mirroring needs to copy source_* fields into the message body - https://phabricator.wikimedia.org/T141948#2517470 (awight) [23:28:41] eileen: I'm cool with donation too. [23:29:31] is this something you need to change so it affects prod and staging? [23:29:53] I'm nervous to do these things :) [23:29:58] well it's just a 2 minute UI change [23:30:08] it's only a label [23:31:10] ok I changed it on staging [23:31:15] I gotta run though [23:31:26] ok cool [23:31:40] I've done it on prod too [23:32:41] ok thanks! [23:50:12] !log update paymentswiki config to [23:50:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:50:27] !log update paymentswiki config to 5429797ec902cd3a6fe098d22e12af7a578e80b8 [23:50:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:59:52] !log update paymentswiki config to 9b3ee23d54c481343164c50f172184bb7b99e871 [23:59:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master