[00:09:13] i think i take back my concern about there being business logic in the redis consumers. i was thinking they'd all have a mysql (pending db) step, but since that's not the case i don't see a good way to keep it separated [00:10:02] I wouldn't mind dumping it all into a db to process, but since we're consuming in FIFO style, there isn't much to gain [00:13:28] yeah, agreed [00:13:33] i'm not sure why i thought that [00:13:45] muddled mind [00:17:26] (PS1) Ejegg: QueueConsumer always shunts to damaged [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 [00:20:22] (PS2) Ejegg: QueueConsumer always shunts to damaged [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 [00:21:26] (PS1) Ejegg: Use a yaml reference for Redis queue params [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302636 [00:23:10] cwd: I'm glad you brought it up earlier! Totally a thing to consider... [00:27:41] !log update paymentswiki config to 3a724bfb1a3e20e17b5886dae0ba7572020abd6b [00:27:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:00:54] !log update paymentswiki config to ac5f7a848450f63b4438de926088acd4feacea83 [01:00:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:10:09] Fundraising-Backlog, Spike: Spike: Do we need ParserFunctions on paymentswiki? - https://phabricator.wikimedia.org/T139699#2517755 (awight) I see quite a bit, but can't tell if we're using it. Search the `payments` database `text` table for `{{#`. [01:15:52] !log update paymentswiki config to f89b8d372753fb2f37c50c062e8cca12c6351e19 [01:15:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:17:27] !log revert paymentswiki config change, new commit 4d0090f50d515047c5e4dfbe565cd04bdd31801d [01:17:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:25:15] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2517776 (dpatrick) >>! In T135410#2493042, @CCogdill_WMF wrote: > Confirmed with IBM that the updated key works, and we'v... [01:34:24] (PS4) Awight: Rename "data" variable to a more specific name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301417 [01:34:26] (PS29) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [01:34:28] (PS5) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [01:34:30] (PS11) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [02:12:29] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2517801 (Eileenmcnaughton) https://issues.civicrm.org/jira/bro... [07:08:26] (PS5) Awight: Rename "data" variable to a more specific name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301417 [07:08:30] (PS30) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [07:08:32] (PS9) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [07:08:34] (PS19) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [07:08:36] (PS6) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [07:08:38] (PS12) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [07:46:57] Till_WMDE: Guten Morgen! [07:47:07] hey Seddon [07:47:43] Till_WMDE: I saw you pinged me yesterder. Just wanted to catch you today :) [07:47:51] yesterday* [07:47:55] great [07:48:11] just wanted to check with you first.... [07:49:06] I am preparing a page in the German Wikipedia explaining the fundraiser in Germany [07:49:23] who does what and why. [07:49:51] my understanding was that you are suppose to be the WMF contact person for the communities [07:50:12] I would like to add your name on that page. Ok with you? [07:50:29] Till_WMDE: Yep that's perfectly fine with myself :) [07:50:45] alright, thanks [15:12:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Unable to find a donation form for rtbt_enets - https://phabricator.wikimedia.org/T141989#2519190 (Aklapper) Hi @Pcoombe. For future reference, please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | p... [16:51:36] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Merging Records manually in Civi - WMF Donor information doesn't automatically merge over - https://phabricator.wikimedia.org/T142008#2519640 (RLewis) [17:26:56] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Convert DonationInterface to use extension registration - https://phabricator.wikimedia.org/T108763#2519791 (DStrine) [17:29:40] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 4 others: Move queue2civicrm_generate_message to test support - https://phabricator.wikimedia.org/T133712#2519795 (DStrine) [17:30:46] Fundraising Sprint Muggle Baiting, Patch-For-Review, Unplanned-Sprint-Work: Turn off AmEx for non-US Adyen forms - https://phabricator.wikimedia.org/T139796#2519802 (DStrine) [17:31:12] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Kill staged_vars - https://phabricator.wikimedia.org/T137387#2519804 (DStrine) [17:31:28] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Add autocomplete hints to donation form - https://phabricator.wikimedia.org/T137716#2519805 (DStrine) [17:31:56] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, and 3 others: Adyen staging functions should be rewritten as helpers - https://phabricator.wikimedia.org/T137157#2519806 (DStrine) [17:32:44] fr-tech: Is anyone at the scrum of scrums? [17:33:36] cwd said he was going to do it. [17:34:02] cool, thx [17:34:10] It's surprisingly interesting [17:34:49] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Make RapidHTML work with mediawiki 1.26+ - https://phabricator.wikimedia.org/T139551#2519810 (DStrine) [17:35:21] ah yeah i'm there [17:35:54] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work, WMF-deploy-2016-08-02_(1.28.0-wmf.13): Move payments to MediaWiki 1.27 - https://phabricator.wikimedia.org/T138016#2519811 (DStrine) [17:36:01] or interestingly surprising? [17:37:12] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Log IP addresses when outgoing requests fail - https://phabricator.wikimedia.org/T139698#2519814 (DStrine) [17:37:31] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Adding Gift Source option for Engage users - https://phabricator.wikimedia.org/T137569#2519816 (DStrine) [17:37:32] cwd: ty! [17:37:33] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Gift Source and Financial Type for Endowment Gifts - https://phabricator.wikimedia.org/T139629#2519817 (DStrine) [17:37:38] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt, Unplanned-Sprint-Work: Set up code quality tools for Fundraising repositories - https://phabricator.wikimedia.org/T139686#2519820 (DStrine) [17:38:10] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, and 3 others: Move IDEAL forms to Mustache templates - https://phabricator.wikimedia.org/T128693#2519822 (DStrine) [17:40:06] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2519830 (Jgreen) DNS records have not been removed yet, I haven't heard whether they're done with the A/B tests. [17:41:23] ejegg|afk: cwd: holler if you've already done so, otherwise I'm gonna put some error handling around the DonationInterface queue mirroring code, to handle Redis outages gracefully. [17:42:07] i have not checked it out yet [17:47:54] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 4 others: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData a... - https://phabricator.wikimedia.org/T134310#2519853 [17:47:57] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Stop adding old, empty bannerController modules to HTML - https://phabricator.wikimedia.org/T138875#2519854 (DStrine) [17:49:11] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike, Unplanned-Sprint-Work: [BUG] Spike: Why is Donation form stuck with 0 as donation amount; donors can't modify it. Fix why. - https://phabricator.wikimedia.org/T113530#2519861 (DStrine) [17:52:24] XenoRyet: how many points would you give this task: https://phabricator.wikimedia.org/T139523 [17:52:36] 2 [17:53:33] Want me to put 'em on there? [17:53:55] I got it. Thanks! [17:54:00] No worries [17:54:33] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2519895 (CCogdill_WMF) We can remove the DNS record, the test is done and the tail of email opens should be about done. T... [17:55:02] XenoRyet: how about this one? https://phabricator.wikimedia.org/T137607 [17:55:43] actual fix was a 1, but I think 2 because of communication hastle. [17:55:54] ok cool [17:58:32] awight: i'm trying to find a general "how to test fundraising stuff" article, do you know of one? [17:58:43] ooh [17:58:48] no. [17:58:56] i think i'll make it and link the ones i know about [17:58:59] and add some stuff [17:59:07] cwd: only https://www.mediawiki.org/wiki/Fundraising_tech#Running_PHPUnit_tests_under_vagrant [17:59:24] awight: i also found https://www.mediawiki.org/wiki/Fundraising_tech/Queue_testing which is excellent [17:59:35] There's also a few paragraphs to borrow from the vagrant payments Main_Page.wiki [17:59:52] Cool! [18:00:44] i want to document as much of it as possible because i'm tired of forgetting [18:00:56] yes! the ur-motivation [18:01:05] make forgetting more pleasant [18:01:27] i guess i basically just described why people write things [18:31:43] (PS1) Ejegg: WIP damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 [18:32:30] fr-tech: ^^ was thinking more about 'damaged' and 'delay', and thought it really shouldn't be queues [18:33:13] any feedback on that schema? [18:34:36] agreed, it should be a db [18:34:53] I think we just need one db, even [18:35:07] hehe a table [18:35:22] or yeah, even just one table [18:36:12] lessee what I had in the damaged schema in the CRM... [18:36:38] oh. no schema [18:37:21] So, stuff is either damaged or needs a delay, it gets taken out of whatever queue it was in and put in this table. Then later some process comes back by and retries everything with a retry_date < now? [18:37:44] (CR) Awight: "The schema looks perfect. My only criticism is that we probably don't need so many dates. Do we care about anything other than original " [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (owner: Ejegg) [18:38:26] XenoRyet yep, I figure a regular job picks them all up and drops them in their original queues [18:39:29] Ah, yea. Instead of handling them right out of the table, makes better sense to just requeue them. I like it. [18:39:41] (CR) Ejegg: "With 'retry' we can use this for delays, too. The damaged date might be interesting forensically" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (owner: Ejegg) [18:42:01] (CR) XenoRyet: "I am a fan of keeping forensic data around, just in case. An extra date column is probably worth it in that respect." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (owner: Ejegg) [18:43:51] ejegg: will this push them back onto the queue, or hand them out directly to consumers? [18:44:25] cwd pushing them back onto the queues would be simplest [18:44:58] yeah i think that would be best [18:46:46] use case question [18:46:53] yeah? [18:46:59] we are using a queue up front for speed [18:47:21] mysql in this case is probably ok because the sets should be relatively small [18:47:44] but is that definitely true? or could we face a situation where something breaks and wants to shunt massive stuff to the damaged queue [18:48:00] and mysql would be a burden [18:48:01] in that case we should be shutting down the pipeline, I think [18:49:00] i guess it will be the php consumer that moves stuff to the damaged queue anyway? [18:49:02] so, the only things writing to the damaged datastore would be queue consumers [18:49:03] or..damaged dable [18:49:07] heh, right [18:49:22] yeah so php is defintely a smaller bottleneck than mysql [18:49:40] (i was going to say bigger bottleneck...) [18:50:03] ok i'm on board [18:50:08] schema looks great [18:50:49] cool! Just going to make damaged_date a timestamp column to get the default now() even on older mysql versions [18:53:27] I'd recommend against the default now()... I vaguely remember it causing lots of surprising things to happen [18:54:15] just changing it to timestamp without adding an explicit default should be ok, though, right? [18:54:56] http://jasonbos.co/two-timestamp-columns-in-mysql/ [18:55:08] or you think that should be php-server time rather than db-server time? [18:55:13] It's probably best to set the value from code, IMO [18:55:27] dynamic defaults == sketchy [18:55:43] replication... [18:55:58] I'm mostly handwaving here, though [18:56:17] ehh, that is kinda weird. k, will set it in php [18:56:20] with mysql you're probably right [19:14:28] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ: Store damaged and delayed messages in a database not a queue - https://phabricator.wikimedia.org/T142028#2520228 (Ejegg) [19:16:22] (PS2) Ejegg: Damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (https://phabricator.wikimedia.org/T142028) [19:39:44] (PS3) Ejegg: Damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (https://phabricator.wikimedia.org/T142028) [20:06:48] * cwd got all strapped in for standup [20:42:21] Fundraising-Backlog: SPRNIT O (8-3 to 8/17) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142039#2520563 (DStrine) [20:42:40] Fundraising-Backlog: SPRNIT P (8-3 to 8/17) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142040#2520576 (DStrine) [20:46:36] Fundraising-Backlog: SPRNIT P (8-17 to 8/31) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142040#2520604 (DStrine) [20:55:49] http://imgur.com/gallery/xDHOS [20:57:56] verra nice [20:58:00] indeed [21:07:40] ejegg, awight : i've been writing this page but I notice it has a lot of overlap with the queue testing page (which it links) https://www.mediawiki.org/wiki/Fundraising_tech/Testing [21:07:48] maybe i should just combine them? [21:08:20] Makes sense [21:09:27] great project! you might want to mention where to find the logs, also [21:09:59] isn't it all in syslog? [21:13:18] yeah but that's different than other stuff people are running in vagrant [21:13:25] e.g. it's not under /vagrant/logs [21:15:28] ah gotcha [21:17:27] fr-tech: Here is where I'm working on doc. I know most (all?) of this stuff is documented elsewhere, but it's just helpful for me to write down how I understand it, and see it all together, for the purpose of describing how it works with the message queues... https://collab.wikimedia.org/wiki/Draft:Fundraising_Interaction_and_Activity_Diagrams [21:18:28] Cool. Consolidation of documentation is a very worthwhile thing, I think. [21:18:48] Thx!! [21:18:49] Dunno if there are any components that I'm forgetting, that would be meaningfully mentioned in the interaction diagrams [21:37:04] AndyRussG|bassoo: see also https://www.mediawiki.org/wiki/Fundraising_tech/Components [21:38:50] k. Where was I 4 hours ago [21:41:16] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Merging Records manually in Civi - WMF Donor information doesn't automatically merge over - https://phabricator.wikimedia.org/T142008#2520730 (Eileenmcnaughton) @RLewis at the moment you still need to select the contributions, activities, tags & ma... [21:47:34] hehe. Just in time: Package fusesource/stomp-php is abandoned, you should avoid using it. Use stomp-php/stomp-php instead. [21:50:35] (PS4) Ejegg: Damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (https://phabricator.wikimedia.org/T142028) [22:00:54] (PS1) Awight: [WIP] Protect mirroring from bad queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302837 [22:03:36] (PS1) Ejegg: Requeue delayed messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302839 (https://phabricator.wikimedia.org/T142028) [22:03:40] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2520797 (Danny_B) [22:04:44] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2520802 (Danny_B) [22:15:19] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Merging Records manually in Civi - WMF Donor information doesn't automatically merge over - https://phabricator.wikimedia.org/T142008#2520852 (RLewis) @Eileenmcnaughton yes I expected that was how it worked. I think it makes sense to have this defa... [22:16:25] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2520855 (awight) @Danny_B I'm curious why you removed #technical-debt ? I... [22:16:39] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-Adyen, FR-WMF-Audit, Unplanned-Sprint-Work: Adyen audit parser is choking on new payment type - https://phabricator.wikimedia.org/T141821#2520858 (Ejegg) Open>Resolved [22:17:36] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 8 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2520861 (Ejegg) Open>Resolved [22:18:31] Fundraising Sprint Killing Time, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, and 3 others: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2520863 (Ejegg) Open>Resolved [22:19:16] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Update CRM SmashPig usage for new config format - https://phabricator.wikimedia.org/T140814#2520877 (Ejegg) Open>Resolved [22:28:58] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Unable to find a donation form for rtbt_enets - https://phabricator.wikimedia.org/T141989#2520910 (awight) [22:29:56] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Pipeline Report - https://phabricator.wikimedia.org/T128818#2520914 (Eileenmcnaughton) It's searchable on live too now [22:30:30] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2520916 (Danny_B) You created this as a subtask, so it inherited all tags e... [22:31:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Unable to find a donation form for rtbt_enets - https://phabricator.wikimedia.org/T141989#2519000 (awight) @Pcoombe Ah yep, I removed this method as part of recent work, it had been unused for years, I believe. I only cut it to remove complex... [22:31:36] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reintegrate Ingenico rtbt_enets payment method - https://phabricator.wikimedia.org/T141989#2520920 (awight) [22:36:51] Fundraising-Backlog, FR-Ingenico: Ingenico: remove AmEx from South Africa form? - https://phabricator.wikimedia.org/T142050#2520946 (MBeat33) [22:37:33] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Pipeline Report - https://phabricator.wikimedia.org/T128818#2520960 (Eileenmcnaughton) a:Eileenmcnaughton [22:37:45] Fundraising Sprint Nitpicking, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2520962 (Eileenmcnaughton) a:Eileenmcnaughton [22:39:14] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Agree acceptance criteria & implement the address requirements - https://phabricator.wikimedia.org/T135062#2520965 (Eileenmcnaughton) [22:45:07] Fundraising Sprint Nitpicking, Fundraising-Backlog: SPRINT N (7/20 - 8/3) Queue work and bugs - https://phabricator.wikimedia.org/T136251#2520973 (DStrine) Open>Resolved [22:46:51] (CR) Awight: [C: 2] When checking for valid option values include is_active in the check. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302374 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [22:47:52] Fundraising-Backlog: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2520983 (DStrine) [22:48:50] (Merged) jenkins-bot: When checking for valid option values include is_active in the check. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302374 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [22:49:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216446 (DStrine) [22:49:17] (CR) Awight: "@eileen" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [22:49:38] Fundraising Sprint O 2016, Fundraising-Backlog: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2521002 (DStrine) [22:49:40] Fundraising Sprint O 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: remove AmEx from South Africa form? - https://phabricator.wikimedia.org/T142050#2521003 (DStrine) [22:49:42] Fundraising Sprint O 2016, Fundraising-Backlog: SPRNIT O (8-3 to 8/17) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142039#2521004 (DStrine) [22:49:44] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, FR-ActiveMQ: Store damaged and delayed messages in a database not a queue - https://phabricator.wikimedia.org/T142028#2521005 (DStrine) [22:49:47] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Queue mirroring needs to copy source_* fields into the message body - https://phabricator.wikimedia.org/T141948#2521006 (DStrine) [22:49:49] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, FR-ActiveMQ: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617#2521008 (DStrine) [22:49:51] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, FR-ActiveMQ: Migrate banner history queue off ActiveMQ - https://phabricator.wikimedia.org/T141555#2521009 (DStrine) [22:49:59] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, and 6 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2521012 (DStrine) [22:50:02] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, FR-ActiveMQ, and 2 others: Listeners should mirror outbound queue messages - https://phabricator.wikimedia.org/T141485#2521015 (DStrine) [22:50:05] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, and 4 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2521013 (DStrine) [22:50:09] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, Continuous-Integration-Config, and 2 others: Continuous integration: DonationInterface needs composer variant - https://phabricator.wikimedia.org/T141309#2521016 (DStrine) [22:50:11] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig: SmashPig tasks which read from pending queue should compare to pending db - https://phabricator.wikimedia.org/T140959#2521017 (DStrine) [22:50:13] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2521019 (DStrine) [22:50:14] (CR) Awight: [C: 2] CRM-19165 Use permission sensitive function to create strip-numeric function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302380 (owner: Eileen) [22:50:16] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, and 4 others: Donations message with empty body! - https://phabricator.wikimedia.org/T140515#2521020 (DStrine) [22:50:18] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, and 2 others: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2521023 (DStrine) [22:50:21] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, and 2 others: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and action=edit pag... - https://phabricator.wikimedia.org/T139439#2521025 [22:50:23] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, and 3 others: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2521024 (DStrine) [22:50:25] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2521026 (DStrine) [22:50:27] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, and 3 others: Handle refund mismatch more correctly - https://phabricator.wikimedia.org/T138542#2521029 (DStrine) [22:50:29] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, and 2 others: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2521028 (DStrine) [22:50:40] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 7 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or del... - https://phabricator.wikimedia.org/T132640#2521037 [22:50:43] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 15 others: [Epic] All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2521036 (DStrine) [22:50:45] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2521040 (DStrine) [22:50:48] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, and 4 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#2521041 (DStrine) [22:50:50] Fundraising Sprint Nitpicking, Fundraising Sprint O 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2521039 (DStrine) [22:50:52] Fundraising Sprint O 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#2521042 (DStrine) [23:05:17] awight: can you also +2 https://gerrit.wikimedia.org/r/#/c/302380/ -it's a revert in the chain of the one you just approved [23:05:36] sorry - this one https://gerrit.wikimedia.org/r/#/c/302379/1 [23:06:24] (CR) Awight: "Why only when !is_major_gifts?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:07:44] (CR) Awight: Add test/ handling to treat conflicts on email=on_hold as conflicts. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:08:22] (CR) Eileen: "The discussion we had was that major gifts wanted to be more careful (throw conflicts on conflicting addresses) whereas Donor Services & C" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:10:12] (CR) Eileen: Add test/ handling to treat conflicts on email=on_hold as conflicts. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:10:36] ejegg: is this one good now ? https://gerrit.wikimedia.org/r/#/c/301304/ [23:10:53] no not that one - the one before it [23:11:05] this one https://gerrit.wikimedia.org/r/#/c/301321/4 [23:13:35] eileen: oops, let me take a look [23:14:39] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:15:04] (CR) Awight: [C: 2] Revert "Don't create SQL function at runtime" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302379 (owner: Eileen) [23:15:24] awight: I have to update the submodule before the recheck will work [23:15:39] don't I? [23:16:22] (btw ejegg did you see I got your hhvm fix into core ) [23:16:36] oh, awesome! [23:17:47] (Merged) jenkins-bot: Revert "Don't create SQL function at runtime" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302379 (owner: Eileen) [23:17:49] (Merged) jenkins-bot: CRM-19165 Use permission sensitive function to create strip-numeric function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/302380 (owner: Eileen) [23:18:27] (CR) Awight: "Yes, but what I'm seeing is !is_major_gift && ($mainIsOnHold + $otherIsOnHold === 1), then we treat as a conflict. That seems backwards f" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:19:20] eileen: you might be right--normally zuul-cloner will pull the merged master (or matching branch) of all subprojects, but this one might be set up to actually git submodule update... [23:19:29] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:19:51] (CR) Eileen: "If that recheck doesn't work I'll have to rebase over a submodule commit" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301611 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:20:14] awight: trying again -since the civicrm wasn't merged when it last tried [23:20:24] eileen: ah yeah fwiw it does zuul-clone master [23:20:36] e.g. 00:00:09.358 INFO:zuul.Cloner:Prepared wikimedia/fundraising/crm/civicrm repo with branch master at commit 3aa7bd83d81582f54f173ff1d382dded28076872 [23:20:41] (PS6) Ejegg: Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [23:20:56] (CR) Ejegg: [C: 2] Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [23:23:30] (Merged) jenkins-bot: Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [23:25:41] (CR) Eileen: "recheck" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [23:25:48] awight: you are correct - it passed [23:27:46] (CR) Eileen: "Hmm - so your main concern is the UI select would be a pain" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [23:38:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Create UI for damaged message DB - https://phabricator.wikimedia.org/T142058#2521204 (Ejegg) [23:39:36] (CR) Awight: "select count(distinct utm_campaign) from drupal.contribution_tracking where ts > '20160101000000';" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [23:40:03] (CR) Awight: "I don't think anyone select utm_campaigns manually, on the other hand..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [23:40:28] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, and 4 others: Special:LoadBanners should scream if translation fails - https://phabricator.wikimedia.org/T137247#2521216 (Ejegg) Open>Resolved not seeing... [23:44:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Clicking the credit card button multiple times loads duplicate iframes... - https://phabricator.wikimedia.org/T142059#2521233 (awight) [23:50:47] ejegg: Is there a way to use DonationLoggerFactory statically? [23:50:54] i mean, w/o an adapter? [23:51:16] (PS1) Awight: Adapter parameter can't actually be null [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302853 [23:54:24] (PS7) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [23:55:07] awight: can't you getLoggerForType? [23:55:09] lemme see [23:55:15] hrm [23:55:26] (PS5) Eileen: Fix ProcessMessageTest to not fail on exchange rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301325 (https://phabricator.wikimedia.org/T138542) [23:55:32] Meh it's just cases like DonationQueue, where we're agnostic of the adapter [23:56:34] we still want to log with the appropriate tag, though, right? [23:57:00] So you can follow the path through payments_astropay, for example? [23:57:33] (CR) jenkins-bot: [V: -1] Fix ProcessMessageTest to not fail on exchange rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301325 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [23:57:58] Since we're only single-threaded, it sort of makes sense to be able to get a log singleton from anywhere [23:58:01] i think. [23:58:36] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2521299 (Eileenmcnaughton) a:Eileenmcnaughton [23:59:21] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216446 (Eileenmcnaughton) a:Eileenmcnaughton [23:59:27] right... I guess the prefixing stuff made that a little tricky [23:59:51] (PS2) Awight: Protect mirroring from bad queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302837