[00:00:20] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [00:00:28] We could emit as much prefix as seems safe--like the OID and active gateway [00:00:47] which prefix is difficult? [00:01:40] yeah, just emitting that prior to setting all the unstaged vars on the adapter [00:02:29] oh right cos it's a prefix provider and not setting anything internal to the logger [00:02:48] for this particular case, you could do a heinous workaround by finding gateway and order id in the message, and mapping gateway to type [00:02:51] I'm a bit disturbed about not logging from the mirror function... [00:02:54] urgh! [00:03:07] DonationQueue should be able to log, in general. I'll task it up [00:03:22] the rube goldberg solution is always the first thing that occurs to me [00:04:22] Always more fun! I just want shortcuts to make laziness acceptable [00:06:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface: ability to log without an adapter object - https://phabricator.wikimedia.org/T142062#2521308 (awight) [00:09:22] (CR) Ejegg: "I think it's required, actually, just listed as 'Direct Mail Appeal' for whatever reason" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [00:11:28] ejegg: awight should we go with 'create campaigns as they come in & re-visit if it's a problem' or 'go back to Caitlin with our concerns we might get spam entries? [00:12:04] (also I think this will be a quick review now the failmail changes are merged https://gerrit.wikimedia.org/r/#/c/301304/ ) [00:12:21] I'm leaning towards create as they come in, with maybe a tiny bit of validation [00:12:30] eileen: It's probably fine, +1 [00:15:08] ok - does one of you want to +2 it then ? [00:15:54] https://gerrit.wikimedia.org/r/#/c/302383/ [00:16:03] (CR) Awight: [C: 2] "Great!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302383 (https://phabricator.wikimedia.org/T139969) (owner: Eileen) [00:16:52] !log update payments-wiki config to 793389ac8fa34cfc6a4ba1df67f2f9fac1ca02fe [00:16:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:18:24] well, so much for code review, gerrit's down [00:18:40] oh hey, that was quick! [00:19:39] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, and 2 others: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2448458 (Eileen... [00:19:52] !log revert paymentswiki config to 70b2ff90d9c8f19716f2e9c07a8dc8cfa17991ca [00:19:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:20:16] eileen: just put a comment on your refund mismatch patch [00:21:53] ejegg: yeah good point! [00:24:56] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, and 2 others: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2521341 (CCogdi... [00:30:59] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: remove AmEx from South Africa form? - https://phabricator.wikimedia.org/T142050#2520946 (awight) Interesting--it looks like we already don't offer an amex form in ZA, only visa/mc. This might be a bug in the form... [00:32:24] Fundraising-Backlog, fundraising-tech-ops: Deprecate shoot_banners script - https://phabricator.wikimedia.org/T142064#2521358 (awight) [00:33:20] (PS2) Eileen: CRM-19148 Fix for on hold data being lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301620 (https://phabricator.wikimedia.org/T135062) [00:35:55] see you tomorrow! [00:36:00] see ya! [09:15:37] Fundraising-Backlog: SPRINT P (Aug17 to Aug31) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142040#2521821 (Aklapper) [10:58:13] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: remove AmEx from South Africa form? - https://phabricator.wikimedia.org/T142050#2521944 (Pcoombe) This seems to be a more widespread problem, I'm getting Amex in the other countries which should have only visa/mc.... [10:59:17] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: AmEx card showing up on forms where it shouldn't - https://phabricator.wikimedia.org/T142050#2521945 (Pcoombe) p:Triage>High [12:26:48] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2522057 (Jgreen) @patrick before the test wikipedia.org had no SPF record, and current record tracks wikimedia.org: "v=s... [12:52:00] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2522087 (faidon) >>! In T135410#2522057, @Jgreen wrote: > "v=spf1 include:wikimedia.org ?all" > > We probably want a pol... [13:50:02] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2522187 (Danny_B) [14:28:58] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2522301 (Cmjohnson) @Jgreen cabled to por11 pfw2...do you need anything more? [14:29:22] fundraising-tech-ops: build two queue servers to replace silicon - https://phabricator.wikimedia.org/T137150#2522306 (Cmjohnson) [14:29:24] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup new fundraising queue servers - https://phabricator.wikimedia.org/T136882#2522304 (Cmjohnson) Open>Resolved The data center portion of this has been completed. [15:37:03] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: AmEx card showing up on forms where it shouldn't - https://phabricator.wikimedia.org/T142050#2522570 (MBeat33) 282 ZAR donations have failed from this yesterday and today, and our success rate for ZA campaign is ~... [15:58:34] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: AmEx card showing up on forms where it shouldn't - https://phabricator.wikimedia.org/T142050#2522652 (Pcoombe) p:High>Unbreak! Sounds reasonable to me @MBeat33, I didn't realise it was affecting so many. [16:23:04] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: AmEx card showing up on forms where it shouldn't - https://phabricator.wikimedia.org/T142050#2520946 (DStrine) Thanks @Pcoombe and @MBeat33 We moved this into our current sprint. I'll ask someone too look into... [16:29:47] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, FR-Ingenico: Ingenico: AmEx card showing up on forms where it shouldn't - https://phabricator.wikimedia.org/T142050#2522765 (MBeat33) Thank you @Pcoombe & @DStrine [16:54:04] (PS1) Cdentinger: List countries for Amex so it stops appearing for ZA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302946 [17:01:40] cwd: How'd you work up the list for that? [17:02:16] XenoRyet: just pulled it out of formsettings...but it's not complete [17:02:21] putting the rest in now [17:03:38] Cool [17:03:50] I'm checking that against the master list [17:04:24] (PS2) Cdentinger: List countries for Amex so it stops appearing for ZA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302946 [17:04:41] XenoRyet: thanks! that one should be better [17:04:47] looking [17:18:42] (CR) XenoRyet: "Looks good against what's in Form Settings. Master list is slightly different. To match that we'd need to add:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302946 (owner: Cdentinger) [17:31:14] cwd: Did globalcollect_gateway/config/payment_submethods.yaml help with the amex issue? [17:32:58] awight: whoops, yeah i just forgot to press git review again [17:34:23] or did i [17:34:25] nm [17:34:33] Do you have an authoritative list of countries and currencies where we can accept ingenico_amex? [17:34:35] awight: https://gerrit.wikimedia.org/r/#/c/302946/3/globalcollect_gateway/config/payment_submethods.yaml [17:35:06] Awight: we got a list from PPena [17:35:07] awight: PPena provided the master list. there were a few discrepancies which you can see in XenoRyet [17:35:10] 's comment [17:35:37] New patch looks good to me. Was about to +2 unless anyone has objections. [17:36:40] oops ;) [17:36:50] Why we have no grrrit-wm [17:36:54] grrrit-wm: help [17:36:57] bah [17:37:32] awight: yeah it seems like there is some unfortunate duplication between config and form settings [17:38:49] Open the pod bay doors, grrrit-wm [17:39:30] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Dismantle DonationInterface form settings and port restrictions to gateway method/submethod config - https://phabricator.wikimedia.org/T142111#2523120 (awight) [17:39:43] cwd: I'm afraid I can't do that right now [17:40:11] :) [17:40:22] Daisy, Daaaiissyyy [17:44:24] Please, you're hurting me. [17:44:39] This mission is too important for me to allow you to jeopardize it [17:46:59] awight: gonna deploy that, should i cherry pick or is the latest queue stuff ready? [17:47:37] If you want to grab the mirroring protection... [17:47:49] https://gerrit.wikimedia.org/r/#/c/302837/ [17:47:57] It needs CR though so don't let me slow you down [17:48:09] (not much CR) [17:48:44] this will make it not holler about a missing queue? [17:49:09] how come the log line is commented out? [17:49:29] cwd logger factory is kinda dumb right now [17:49:42] doesn't actually let you get a logger without at least the adapter type name [17:49:57] which we /could/ do at that point by examining the message, but it'd be ugly [17:50:09] oh right [17:50:24] cwd: yeah exactly, the idea is that a failure to mirror should be non-fatal [17:50:29] this will just be totally silent about missing queue. is that what we want? [17:50:34] no, that sucks [17:50:43] but we'll be able to detect that on the consumer side [17:51:17] logging is easier there? [17:51:46] eh, more that it's just another place where we care about both bits of data [17:51:57] word [17:52:20] yeah feel free to block on the silent failure, it disturbs me, too. [17:52:23] As you can see by the commented code [17:52:38] it's always bothered me that the DonationQueue class can't log [17:53:00] yeah i feel like the logging system is overcomplicated [17:53:04] * ejegg commented on awight's https://gerrit.wikimedia.org/r/301424 --grrrt-wm [17:53:29] should just be a static thing available anywhere [17:53:44] cwd probably, yeah. It was my first encounter with monolog's processors etc [17:54:13] i have not looked closely at monolog so i may be oversimplifying [17:54:23] misunderestimating [17:54:49] and we've got a slightly complicated requirement to get the order_id prefix right, from when it's generated in donationData's constructor to when it's assigned in the adapter, through any changes [17:55:50] shouldn't it be available to the calling code somehow? [17:56:14] Conceptually I do like that we pull the order id rather than having the donationdata class etc push the new orderid into the log class. [17:56:59] some kind of global 'get the active adapter' method might make sense [17:58:44] IMO all we need is a short cut yeah [18:00:20] fr-tech: Hi! Have I got this mostly right so far? https://collab.wikimedia.org/wiki/Draft:Fundraising_Interaction_and_Activity_Diagrams [18:00:32] gawd, some fool recruiter just called trying to get adam B. and wouldn't answer when I asked if he was a recruiter. [18:00:38] looking [18:00:48] AndyRussG: didyu see the COmponents page I sent yesterday? Might be a good candidate to merge [18:01:06] https://www.mediawiki.org/wiki/Fundraising_tech/Components [18:01:49] Very nice doc! [18:02:07] AndyRussG: all of that looks accurate and up to date [18:02:14] awight: ah cool thx! No, I guess I hadn't seen it .... [18:02:22] ejegg: thx ;) [18:03:10] Yeah re: merging... I'm just trying to start out explaining only what's necessary for a mid-level description of messaging interactions [18:03:24] cool [18:03:46] fr-tech what would be the best processor to start with for diagramming? [18:04:18] Do you want a nasty one or a simple one? [18:04:29] AndyRussG: legacy paypal might be easiest, ingenico would be most needed [18:04:35] or maybe adyen [18:04:41] +1 all that [18:04:52] there's a spreadsheet for adyen someplace, lemme find it [18:05:07] ah cool sounds great :) [18:05:35] I was thinking, one that's pretty far along in the new Q stuff, so there wouldn't be too much to change, but those sound like better criteria [18:06:34] aww, say what's on your mind grrrit-wm [18:06:37] Adyen flow: https://docs.google.com/a/wikimedia.org/spreadsheets/d/18iCRJvYjefqocfOvRps1IPhpdM_PAqeG9DEURA2ZXE8 [18:06:51] anyway, easy fix for review: https://gerrit.wikimedia.org/r/302953 [18:08:25] ejegg: cool beans, thx! K I'll start with that one [18:08:57] cwd: I have a settings thing to mess with, and the grrrit-wm outage is really messing with my ability to see where you're at in your deployment. Maybe just ping me when you're getting ready to deploy? [18:09:29] awight: everything's merged so i can go any time [18:09:37] but i have not merged into deployment yet [18:09:44] so if you want to get something else in i can wait [18:09:48] nah go ahead [18:09:52] I'm just playing with localsettings.git [18:09:58] I'll be done in 5 min [18:10:05] mmk [18:10:22] ejegg: How up-to-date is that? If it's not, do you know approx. the DI sha that it corresponds to? (that way I could see easily changes since then... rrrr... maybe...) [18:10:27] (CR) XenoRyet: [C: 2] Protect condition in case of undefined variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302953 (owner: Awight) [18:10:38] AndyRussG: that should be up to date [18:10:43] Hey, grrrit-wm came back! [18:10:50] cool! [18:10:57] the queue changes shouldn't affect the logical flow [18:12:28] (Merged) jenkins-bot: Protect condition in case of undefined variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302953 (owner: Awight) [18:12:30] !log update paymentswiki config to 71cc55194f4465600ce4da0ea9f7dfaefdda5479 [18:12:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:14:48] cwd: k, I'm done [18:15:03] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/302956 [18:15:16] fr-tech: btw take a look at LocalSettings.php next time you're on the deployment box... [18:16:26] (PS2) Ejegg: Use a yaml reference for Redis queue params [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302636 [18:17:04] reference is neat, didn't know you could do that [18:18:17] (PS3) Ejegg: QueueConsumer always shunts to damaged [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 [18:19:04] (CR) Ejegg: "PS3: rebased onto damaged DB, have not yet updated QC to use it" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 (owner: Ejegg) [18:19:10] i'm assuming i don't see the blue +2 button on my own patches [18:19:17] that is a little confusing [18:19:22] i don't like that button [18:19:30] i know i'm going to click it by accident at some point [18:19:32] Instant gratifica* [18:19:33] oops [18:23:10] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/302956 (owner: Cdentinger) [18:23:18] nm i just don't see it until V+2 [18:23:23] which is actually helpful [18:24:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/302956 (owner: Cdentinger) [18:25:59] (PS1) Cdentinger: Update DonationInterface submodule. [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/302959 [18:28:04] (CR) Cdentinger: [C: 2] Update DonationInterface submodule. [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/302959 (owner: Cdentinger) [18:28:09] cwd: wow, I have a lot of undefined classes and methods running the CRM tests. Is that what you were seeing? [18:28:39] i haven't deployed to the new servers yet, but i think all the commands should be the same? [18:28:51] awight: lemme remember where i landed with that... [18:29:21] cwd: yep [18:31:44] (Merged) jenkins-bot: Update DonationInterface submodule. [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/302959 (owner: Cdentinger) [18:33:10] deploy code focu [18:33:36] eh [18:36:02] !log updated payments from 3a724bfb1a3e20e17b5886dae0ba7572020abd6b to b737b60c87da82543ab812ece4611c68af01307f [18:36:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:39:37] (PS4) Ejegg: QueueConsumer always shunts to damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 [18:40:51] (PS1) Awight: Trim decimal junk from timestamp [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302962 (https://phabricator.wikimedia.org/T140667) [18:41:27] Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2523412 (awight) [18:42:35] what is status 100 from GC? [18:43:41] brb for fud [18:44:08] cwd not sure, but there are a ton of docs for GC on the fileshare [18:54:43] status 100 is a bank rejection [18:54:50] cwd [18:59:54] (PS5) Ejegg: Damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302758 (https://phabricator.wikimedia.org/T142028) [19:01:50] (PS5) Ejegg: QueueConsumer always shunts to damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 [19:02:13] MBeat: thanks! yeah my credit cards are all like half working cause of moving recently [19:02:20] oh hey, nice rebase detection, grrrt-new [19:03:21] i don't like how the subject of the emails changed to have the repo name in front, cause it makes the summary on my phone useless [19:11:58] (PS6) Ejegg: QueueConsumer always shunts to damaged datastore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302633 [19:24:44] (PS1) Ejegg: WIP WmfQueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302975 (https://phabricator.wikimedia.org/T131277) [19:28:47] (PS4) Ejegg: Move banner history off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) [19:35:34] (PS5) Ejegg: Move banner history off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) [19:42:35] (PS5) Ejegg: Move fredge consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301671 (https://phabricator.wikimedia.org/T131273) [19:43:08] (PS6) Ejegg: Move fredge consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301671 (https://phabricator.wikimedia.org/T131273) [19:46:26] !log enabling paymentswiki queue mirroring [19:46:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:47:29] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Migrate fredge to new queue - https://phabricator.wikimedia.org/T131273#2161859 (Ejegg) p:Triage>Normal [19:51:55] !log paymentswiki config fix [19:52:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:54:05] (CR) Ejegg: [C: 2] "Could add anchors and a test with a non-unix-timestamp format, but the '@' sign is probably good enough." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302962 (https://phabricator.wikimedia.org/T140667) (owner: Awight) [19:55:41] (PS1) Awight: Anchor regex [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302983 [19:56:17] (Merged) jenkins-bot: Trim decimal junk from timestamp [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302962 (https://phabricator.wikimedia.org/T140667) (owner: Awight) [19:57:56] (PS2) Ejegg: Adapter parameter can't actually be null [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302853 (owner: Awight) [19:58:39] (CR) Ejegg: [C: 2] Adapter parameter can't actually be null [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302853 (owner: Awight) [20:05:02] AndyRussG: XenoRyet meeting? [20:05:16] Whoops, time warp. BRT. [20:06:03] oops [20:06:04] comin [20:06:06] coming [20:08:46] (Merged) jenkins-bot: Adapter parameter can't actually be null [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/302853 (owner: Awight) [20:25:21] (PS1) Ejegg: Update libs [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/302991 [20:26:42] (CR) Ejegg: [C: 2] Update libs [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/302991 (owner: Ejegg) [20:29:31] (CR) Ejegg: [V: 2] Update libs [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/302991 (owner: Ejegg) [20:32:40] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/302998 [21:01:46] Ah I was gonna ask... When SmashPig is set up to provide HTTP endpoints, which are the entry point files? Sorry if I'm missing the obvious... [21:02:26] hey sorry guys my wifi gave out [21:03:01] AndyRussG: only smashpig_http_handler.php [21:03:12] damaged queue was looking good to me though [21:03:21] was anything decided? [21:03:53] also we are gonna try to rename the unsub extension? [21:03:55] cwd awight thought it odd that the callback was a constructor argument while the error handling was overridable by subclasses [21:04:08] cwd yeah, awight's going to rename it to match the repo [21:04:33] and I'm going to try to get rid of the constructor arg and make it all subclassy [21:05:11] great [21:07:45] Hi all. Looking for help/instructions to fix my CentralNotice installation. Can anyone help me? [21:08:19] fn_: hi! maybe.... What's your setup/difficulty? [21:09:29] (CR) Eileen: "Note this is second in the dependency chain - this logic is mostly in the more general address handling patch." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301619 (https://phabricator.wikimedia.org/T135062) (owner: Eileen) [21:10:08] awight: I'm happy to talk through those address merge patches on chat if you want [21:11:33] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/302998 (owner: Ejegg) [21:13:36] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/302998 (owner: Ejegg) [21:16:58] When I access CentralNotice admin I get a Database error (installed on localhost) -- any idea what's wrong? [21:17:15] !log updated SmashPig from e6aa6fe6fdcaab8e961a8b0668cc742d4c443c46 to b7f5e449aa62cc5518dea580de96b8ed7a2489d0 [21:17:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:23:29] k, renaming that repo now... [21:24:38] awight: the repo, or the files in it? [21:28:11] ejegg: making all references to the project match the repo name [21:28:20] cool [21:28:57] (PS1) Ejegg: Use call_user_func for popAtomic [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/303062 [21:30:16] fr-tech: old $callable() behavior strikes again ^^ [21:32:12] ejegg: what does that do? is it a php version thing? [21:32:39] it must be [21:32:47] oops, just noticed ws change, will fix [21:33:11] are you seeing that blow up somewhere? [21:33:29] cwd yeah, that was the last failmail [21:33:52] or rather, the last job failure on pending queue consume [21:34:24] is that box still old php? [21:34:29] oooh yeah i think i remember that [21:35:38] now that i think about that i'm surprised it's the only thing that blows up 5.3 [21:36:40] (PS2) Ejegg: Use call_user_func for popAtomic [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/303062 [21:41:48] (CR) Cdentinger: [C: 2] "Let's hope this is the only thing in php-queue that blows up on 5.3" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/303062 (owner: Ejegg) [21:42:27] (Merged) jenkins-bot: Use call_user_func for popAtomic [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/303062 (owner: Ejegg) [21:42:37] thanks cwd [21:43:25] you betcha [21:47:50] Are the SmashPig listener endpoints set up on vagrant? [21:48:01] AndyRussG|sortof: yep! [21:48:16] You can see some urls in the Queue Testing doc [21:49:08] (PS1) Ejegg: Update php-queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303073 [21:49:17] (CR) Ejegg: [C: 2] Update php-queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303073 (owner: Ejegg) [21:50:57] (Merged) jenkins-bot: Update php-queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303073 (owner: Ejegg) [21:51:36] (PS1) Ejegg: Update php-queue [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/303077 [21:51:50] (CR) Ejegg: [C: 2 V: 2] Update php-queue [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/303077 (owner: Ejegg) [21:52:39] ejegg: thx! [21:53:03] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303080 [21:53:22] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303080 (owner: Ejegg) [22:08:37] (PS1) Ejegg: WIP subclass QueueConsumer instead of callbacks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303081 [22:08:39] (PS1) Ejegg: WIP Subclass QueueConsumer instead of passing callback [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303082 [22:08:48] derp [22:10:05] (PS2) Ejegg: WIP subclass QueueConsumer instead of callbacks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303081 [22:10:18] (Abandoned) Ejegg: WIP Subclass QueueConsumer instead of passing callback [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303082 (owner: Ejegg) [22:10:29] oops, offic closing, gotta relocate [22:19:27] ejegg|afk: How are you consuming w/o a database? [22:20:29] is it robust against missing db? [22:21:46] mmm, I hope not ;) [22:22:34] may not have hit the mysql code yet? [22:23:05] awight: I think the pending db is set up, isn't it? [22:23:20] we have credentials for it [22:24:11] maybe I can't see it cos I don't have perms? [22:24:17] looking for credentials... [22:24:30] (CR) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303080 (owner: Ejegg) [22:24:36] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303080 (owner: Ejegg) [22:24:55] Want me to mirror the rest of the pending queues? [22:25:53] (CR) Ejegg: [V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303080 (owner: Ejegg) [22:26:33] awight: oh, only mirroring gc-limbo now? [22:26:50] that and "pending"--which come to think of it might not be a thing [22:26:52] yeah, let's mirror regular pending to pending-new [22:27:03] no, it's 'limbo' that's no longer a thing [22:27:29] I believe I configured that already [22:27:34] ok, cool, that's all we need [22:27:35] it's strange that I don't see any entries tho [22:28:08] really? I thought you said you saw some [22:28:38] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2524395 (CCogdill_WMF) Thanks again, @Ejegg! Pretty exciting to get 315k d... [22:28:53] I do, but they're all ingenico cc-limbo [22:31:13] !log updated SmashPig from b7f5e449aa62cc5518dea580de96b8ed7a2489d0 to 26a475bf5ae03d88ebc4c2fe9707d562d8e3afe3 [22:31:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:31:20] ok, i'll take a look at the config [22:32:36] woot, consumed 157 pending messages [22:33:35] yesss [22:33:50] that worked. [22:34:39] llen pending -> 0 [22:34:52] I'm sure it consumed in about 0.05 seconds, too... [22:35:28] hehe yeah "processed 157 messages in 0 seconds" [22:36:25] awight: i'm seeing some adyen messages in there [22:36:32] at least 1, anyway [22:37:04] 58, even [22:37:19] so, let's see if we're comparing... [22:39:02] hooray! [22:40:15] ejegg: hey, wanna do a preliminary CR of the orphan rectifier patch? [22:40:31] I see you -1'd the predecessor, but that should be independent... [22:40:49] awight: sure, I'll take another look [22:40:50] I'd like to be able to clean those up so you can CR tomorrow [22:41:30] ejegg: ah my bad, sorry to imply you hadn't looked yet, it's just a jumble in my head [22:47:44] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2524455 (CaitVirtue) This is all great news, thanks @Ejegg and @CCogdill_W... [22:57:47] (CR) Ejegg: "Looking really good! Now that we're using this outside of mediawiki, it would be nice to get rid of all the orphan globals and have them p" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:00:45] (CR) Ejegg: [C: 2] Anchor regex [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302983 (owner: Awight) [23:03:01] (PS7) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [23:03:28] (CR) Awight: "Good point. PS 7 should fix that." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 (owner: Awight) [23:03:37] (PS31) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [23:03:52] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:04:02] (Merged) jenkins-bot: Anchor regex [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/302983 (owner: Awight) [23:05:42] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Tech Backlog, Fundraising-Backlog: Major Donors on email suppression list who should be opted in - https://phabricator.wikimedia.org/T139102#2524585 (MBeat33) +1 @CaitVirtue @CCogdill_WMF I will make sure the DS t... [23:08:38] (PS3) Ejegg: WIP subclass QueueConsumer instead of callbacks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303081 [23:09:34] (PS32) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [23:09:48] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:09:54] O_o [23:10:48] (PS33) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [23:10:50] (PS8) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [23:11:49] Fundraising-Backlog: Access to lutetium and MySQL - https://phabricator.wikimedia.org/T141945#2517397 (CaitVirtue) Approved, thanks! [23:21:33] Fundraising Sprint Octopus Untangling, Fundraising-Backlog: SPRINT O (8-3 to 8/17) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142039#2524623 (awight) [23:22:13] sorry to miss the fun, gotta run! [23:22:41] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2524627 (awight) [23:22:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Date parsing error from unknown gateway - https://phabricator.wikimedia.org/T137455#2368813 (awight) [23:22:50] yeah, i should go visit my pops [23:22:56] see yas [23:26:43] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 5 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2524635 (awight) @Danny_B Please add a note... [23:29:29] eileen: hi! Mind if I deploy the utm_campaign and failmail patches? [23:30:18] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303102 [23:31:25] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303102 (owner: Awight) [23:31:53] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303102 (owner: Awight) [23:33:07] !log update civicrm from 9a971ff6d74ae8e14c1c9f854155d9829e6a0278 to 2d68638471aded73d05a796b05cab11809e31c56 [23:33:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:34:56] (PS1) Awight: Remove some tests from the deployment branch [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303104 [23:35:11] (CR) Awight: [C: 2] Remove some tests from the deployment branch [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303104 (owner: Awight) [23:35:39] (Merged) jenkins-bot: Remove some tests from the deployment branch [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303104 (owner: Awight) [23:45:10] (PS4) Ejegg: Subclass BaseQueueConsumer instead of callbacks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303081 [23:50:20] (PS5) Ejegg: Subclass BaseQueueConsumer instead of callbacks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303081 [23:50:48] (PS5) Awight: Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [23:50:54] (PS5) Awight: Compare pending db/queue in Adyen RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [23:55:57] (CR) Awight: [C: 2] Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [23:56:01] (PS6) Ejegg: Subclass BaseQueueConsumer instead of callbacks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303081 [23:57:33] (Merged) jenkins-bot: Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [23:57:35] (Merged) jenkins-bot: Compare pending db/queue in Adyen RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [23:58:34] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ, and 2 others: Listeners should mirror outbound queue messages - https://phabricator.wikimedia.org/T141485#2525332 (awight) There's also the legacy PayPal listener... I'll rename this task to h... [23:58:45] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ, and 2 others: SmashPig Listeners should mirror outbound queue messages - https://phabricator.wikimedia.org/T141485#2525333 (awight)