[00:02:58] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 6 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2538802 (awight) Still have some request stuff to workaround: > Fat... [00:07:29] (CR) Awight: WmfFramework-ize some HTTP request functions (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:08:01] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303948 [00:08:48] (PS10) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [00:10:15] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303948 (owner: Eileen) [00:10:22] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303948 (owner: Eileen) [00:17:46] !log updated Civicrm from af0048c007ddf9e74c6bd15e50c73c3bd0942492 to 024a7ef2badb02743659ffed9856571d96604fd2 [00:17:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:18:24] (PS20) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [00:24:18] (PS1) Awight: Revert "Add installer info to composer.json"; update composer libs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303953 [00:26:36] what is the difference between https://phabricator.wikimedia.org/tag/astropay/ and https://phabricator.wikimedia.org/tag/fr-astropay/ ? [00:40:24] (PS1) Eileen: CRM-19197 fix some more merge links [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303962 (https://phabricator.wikimedia.org/T139964) [01:24:45] (PS2) Eileen: CRM-19197 fix some more merge links [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303962 (https://phabricator.wikimedia.org/T139964) [03:09:29] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 3 others: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2538919 (Eileenmcnaughton) @awight sigh - it turned out I hadn't gotten all t... [03:22:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create a way to view the history of address records - https://phabricator.wikimedia.org/T142549#2538923 (Eileenmcnaughton) [03:22:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create a way to view the history of address records (dedupe follow up task) - https://phabricator.wikimedia.org/T142549#2538936 (Eileenmcnaughton) [03:27:42] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2538944 (RLewis) @Eileenmcnaughton thanks for the update. I'll test it out and let you know... [03:42:41] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2538965 (Eileenmcnaughton) @CaitVirtue @RLewis I created a basic report on live at civicrm/r... [03:53:11] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 2 others: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2538971 (Eileenmcnaughton) I did a PR upstream for changes & ported... [10:04:26] Fundraising-Backlog, Operations, Ops-Access-Requests: Access request: AWight access to iridium - https://phabricator.wikimedia.org/T142446#2535387 (akosiaris) @maxsem is correct. Using the HTTP requests from Hadoop is way better as an alternative. In fact, in previous security related cases, ops did... [10:04:34] Fundraising-Backlog, Operations, Ops-Access-Requests: Access request: AWight access to iridium - https://phabricator.wikimedia.org/T142446#2539358 (akosiaris) p:Triage>Low [15:54:51] (PS4) Cdentinger: Add ActiveMQ headers to Redis messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) [15:56:25] (CR) jenkins-bot: [V: -1] Add ActiveMQ headers to Redis messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) (owner: Cdentinger) [15:57:58] (PS4) Paladox: Fix jslint errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 [16:42:58] (CR) Ejegg: [C: 2] "Thanks for cleaning up that experiment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303953 (owner: Awight) [16:44:42] (Merged) jenkins-bot: Revert "Add installer info to composer.json"; update composer libs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303953 (owner: Awight) [16:57:39] fr-tech: hi!!! I'm putting a CN update on this evenings SWAT deploy at 16:00 PDT... Any thoughts/objections/suggestions/flying tomatoes...? [16:58:09] sounds exciting [16:59:33] cwd: there have been more exciting ones, but deploying tidbits of code to zillions of readers is surely not among our least ticklish tasks, either ;p [16:59:42] How's the house BTW??? [17:00:28] heh, long night vacuuming mouse shit and getting the van stuck in the mud [17:00:40] Hmmm [17:00:56] * AndyRussG tries to picture this [17:01:04] those two things were unrelated [17:01:12] I guess it's better than vacuuming mud and getting the van stuck in mouse shit [17:01:17] haha [17:01:40] it's gonna be great, the land is amazing [17:01:51] but there's gonna be some upfront costs :S [17:01:51] Though also probably any quantity you would find of either substance contains at least a little of the other [17:02:11] The place sounds amazing!!!!! [17:02:16] * AndyRussG is jealous ;p [17:02:47] ...but also very happy for you both!!! [17:02:50] thank you! [17:03:01] it's also got 2 220v outlets which was surprising [17:03:07] Huh [17:03:08] for a little shack [17:03:14] Right [17:03:29] guy probably did some welding [17:03:34] he's an artist [17:03:37] Ah right [17:03:38] cool [17:03:55] http://billmaxonsculptor.com/ [17:04:27] Wow hey... definitely some welding going on then [17:05:09] interesting stuff! [17:05:23] very santa fe [17:05:38] Hmm [17:06:25] Always funny to notice that kind of thing but not quite be able to identify what makes a "vibe" so [17:06:48] Or maybe in this case it's something pretty specific Santa-fe-ian, I guess I dunno [17:07:14] well the city is so full of fine art [17:07:23] i'm probably criminally generalizing [17:07:46] All art commentary is criminal, or not [17:08:12] Neither one nor the other, but rather the complete oposite [17:08:47] hehe dang [17:08:56] something tells me you'd like santa fe [17:09:06] have you ever been? [17:09:21] I don't think so! [17:09:23] https://www.google.ca/search?q="ni+uno+ni+el+otro+sino+todo+lo+contrario" [17:10:00] Not impossible that I might have unwittingly passed through on a Greyhound decades ago [17:11:09] Hmmm looks like here's the source: https://es.wikipedia.org/wiki/Ni_pobre_ni_rico,_sino_todo_lo_contrario [17:12:55] Prob'ly I'd love the place, sounds amazing [17:13:25] * cwd stumbles through spanish [17:14:30] ^ just the expression I pilfered^D^D^Dtranslated [17:14:52] hehe yeah, sounds like a good play [17:15:23] i want to take some spanish classes [17:15:31] it's definitely the majority language around here [17:15:40] Ah cool! [17:16:01] i can fumble around but am not conversational [17:16:08] Heh does sound like an interesting play [17:16:38] Heh, that's not especially clear Spanish in that article.... [17:16:52] cool! [17:17:10] that's always a fantastic place to start :D [17:17:34] just force yourself to converse and it'll come easy :) [17:21:46] AndyRussG: yeah definitely [17:22:19] at wikimania i found that i could do better with 10 words of italian than with rudimentary spanish [17:22:21] cause i had to [17:24:15] Yeah I think real usage is such a different kind of learning that rote vocab assimilation [17:27:57] absolutely [17:29:30] (PS5) Cdentinger: Add ActiveMQ headers to Redis messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) [17:40:52] Fundraising-Backlog: test private fr task - https://phabricator.wikimedia.org/T142604#2540745 (DStrine) [17:42:25] I guess this exception is known? 2016-08-10 17:41:29 mediawiki-vagrant paymentswiki: [488ac5cd0809a4a5e9f22186] /w/load.php?debug=false&lang=en&modules=donationInterface.styles%7Cext.donationinterface.mustache.styles%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.sectionAnchor%7Cmediawiki.skinning.interface%7Cskins.vector.styles&only=styles&skin=vector Less_Exception_Chunk from line 545 [17:42:26] of /vagrant/mediawiki-fr/vendor/oyejorge/less.php/lib/Less/Parser.php: ParseError: Unexpected input in watchstar.less on line 1, column 0 [17:42:49] On pretty recent DI on vagrant for Special:AdyenGateway [17:50:32] What's in that file? [17:50:43] I haven't seen that error FWIW [17:50:53] A file by any other name [17:51:11] I have "@import "mediawiki.mixins.rotation"; [17:51:12] Uhhh haven't even looked [17:51:15] on line 1 [17:51:36] you might want to confirm that skins/Vector is updated to the greatest [17:51:53] Ah that sounds like it could well be it, yeah I have skin problems [17:52:05] The page is working, no error in the UI, only in the log BTW [17:52:12] thx! [18:12:18] I have this nastiness where phpunit only works in vagrant :( [18:12:31] Hmmm dunno if there's a cure for that one [18:12:36] Maybe ointment? [18:12:49] it is only a flesh wound [18:15:11] K avoid spicy hhvm sauce remedy [18:19:29] Aaarg figured out my XDebug issue [18:19:36] Not fixed, but understood, I think [18:19:41] It's a multiwiki issue [18:20:05] Eclipse automatically re-maps server paths when your php entry point is not in your Eclipse workspace [18:20:28] In this case, the real entry point is /var/www/w/index.php [18:20:39] Then it hops along to /vagrant/mediawik-fr/index.php [18:21:07] fr-tech ^ for the XDebug curious [18:24:20] (looks like the watchstart file hasn't changed in a long time fwiw) [18:35:06] Is /var/www/w/ exposed anywhere outside the vagrant vm? [18:35:17] I guess I can easily expose it [18:36:15] that's odd, why is that path being served? Should be /vagrant/mediawiki-fr? [18:36:35] It's some multiwiki thingy [18:37:52] Add error_log( 'foo'); to /var/www/w/index.php in ur vm, and tail /vagrant/logs/apache2.log [18:40:01] * awight tugs hat around eyes [18:48:37] Ah hmm can't symlink from vagrant dir into the vm! [18:49:01] rrrg what's a filesystem? [18:49:20] a nfs share by any other name.... [18:59:24] noo. u can symlink out though, if that helps [19:02:08] ejegg: not sure you witnessed my wobbly, but it turns out I'm gonna need to pull in some of those RequestContext patches after all. [19:02:50] Oh yeah? [19:03:00] let me catch up... [19:03:23] awight: ah right you mean copying the real contents to /vagrant and then symlinking from the original location [19:05:00] woohooo breakpoints workin' :) [19:05:05] nice! [19:05:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change order of Actions available in Advanced Search results - https://phabricator.wikimedia.org/T142619#2541164 (CaitVirtue) [19:05:47] I just had to path map from mediawiki-fr/extensions rather than its parent [19:06:32] 'cause the automatic path mapping thing unstoppably sets mediawiki-fr to map to /var/www/w [19:07:01] Only issue is that I won't be able to break on anything directly in the /mediawiki-fr directory but that won't cause the extinction of any endangered bacteria [19:09:53] (CR) Ejegg: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) (owner: Cdentinger) [19:11:23] (Merged) jenkins-bot: Add ActiveMQ headers to Redis messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) (owner: Cdentinger) [19:12:56] (PS1) Ejegg: PHPDoc cleanup for DonationQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304051 [19:16:41] (CR) Awight: Add ActiveMQ headers to Redis messages (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) (owner: Cdentinger) [19:32:00] awight: does that WmfFrameworkize patch do the trick? It looks like the adapter constructor is still calling RequestContext [19:32:25] I think we need both the patches... about to push a new PS on the second one [19:32:40] (CR) Awight: Some decoupling of GatewayPage from GatewayType (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [19:33:15] ah, i see [19:33:50] (PS21) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [19:36:38] another thing about new gerrit is it's no longer obvious when you have to scroll a diff [19:36:50] cause it's a scrolly div with a fixed height [19:39:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Added new Custom Field on Production - https://phabricator.wikimedia.org/T142624#2541329 (RLewis) [19:46:29] (CR) Ejegg: [C: -1] "ip_velocity and session_velocity still calling adapter->getRequest()" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [20:06:49] ejegg: standup? [20:06:57] oops, brt [20:16:25] (PS2) Ejegg: Use IDENTIFIER constants instead of strings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301311 [20:35:53] (CR) Awight: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304057 (owner: Cdentinger) [20:36:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change order of Actions available in Advanced Search results - https://phabricator.wikimedia.org/T142619#2541546 (DStrine) p:Triage>Normal [20:36:35] (CR) Awight: [C: 2] PHPDoc cleanup for DonationQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304051 (owner: Ejegg) [20:37:15] (Merged) jenkins-bot: Replace question with answer. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304057 (owner: Cdentinger) [20:37:27] eileen: Were you saying you had another limit= patch for review? I don't see it... [20:37:50] ah, https://gerrit.wikimedia.org/r/#/c/303962 [20:38:16] (Merged) jenkins-bot: PHPDoc cleanup for DonationQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304051 (owner: Ejegg) [20:39:10] (CR) Awight: [C: 2] "Smarty wizardry!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303962 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [20:39:49] (CR) Ejegg: [C: -1] "once change needed due to getVal defaults, a couple questions" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [20:42:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Dismantle DonationInterface form chooser and port restrictions to gateway method/submethod config - https://phabricator.wikimedia.org/T142111#2541568 (awight) [20:43:02] (Merged) jenkins-bot: CRM-19197 fix some more merge links [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303962 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [20:43:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: All adapters should implement getAvailableLanguages - https://phabricator.wikimedia.org/T142633#2541570 (awight) [20:55:53] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304109 [20:56:46] (PS1) Ejegg: Fix DedupeFind cache set call [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/304110 [20:57:08] eileen: typo fix (get->set)^^^ [20:58:21] (CR) Eileen: [C: 2] "self-merging as submodule" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304109 (owner: Eileen) [21:00:04] ejegg: how did you find that? The change pre-dates 2013 [21:00:10] the line I mean [21:01:01] IDE magic [21:01:17] :-) [21:01:30] ok - I'll do something about putting that upstream [21:01:41] * awight cautiously jabs femur at obelisk [21:01:48] heh, hopefully the robots won't put us out of work too soon [21:01:50] which IDE - mine doesn't pick that up [21:01:57] PHPStorm [21:05:08] hmm - you must have something configured that I don't then [21:06:24] Editor->inspections->php->code smell->'parameters number mismatch declaration' [21:07:35] oh wow, 14 more extra params in method calls just under CRM/Contact [21:11:28] (PS11) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [21:11:30] (PS22) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [21:11:49] quack [21:12:38] (PS23) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [21:12:48] ejegg: ah you are running the inspects - not just seeing what gets sideline annotations in your view [21:12:49] awight - why not check gateway_adapter->isBatchMode in minfraud? [21:13:15] (PS1) Awight: [WIP] Check whether tests are missing CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304116 [21:13:18] eileen: it's doing the sideline color coding in realtime too, and highlighting the call text in the editor [21:13:29] not sure where i turned that on [21:13:43] ejegg: Great idea! [21:14:54] ah ok - I have some things on - but not that [21:14:59] I'll look [21:15:34] you know that line hasn't worked in so long fixing it might break something :-) [21:15:47] oh man... [21:15:54] (CR) Chad: "This should go into master first imho." [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301905 (owner: Ejegg) [21:16:29] (PS2) Awight: [WIP] Check whether tests are missing CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304116 [21:16:31] (PS12) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [21:16:33] (PS24) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [21:17:03] looks like I have that inspection on but my inspections are just so noisy it didn't stand out - probably all the phpdoc ones [21:17:29] heh, oh man, those are distracting [21:21:48] fr-tech: Hey... suggestions on how to smoke test UserMerge CN hook welcome!! Same for other remaining elements on the list https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Extension_registration [21:22:16] oh, did the UserMerge hooks change? [21:22:42] ejegg: no, it just moved with the extension registration, and I want to watch at least one successful run of each new code path :) [21:22:48] ah cool [21:23:25] we've been live on the beta cluster for a little while... [21:23:26] umm, well, i guess you need to install the usermerge extension and merge a couple users with banner and campaign changes in the logs [21:23:42] then check that all the logs point to the merged user [21:23:53] yeah it seems actually a local smoke will be better than beta cluster [21:24:06] since I likely need special permissions that I dunno if I have on the beta cluster [21:24:11] Hmmm I should check tho [21:25:38] sigh gerrit taking ages to merge [21:26:35] ok found a button that hurried it up [21:27:33] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/304123 [21:27:40] Nope, not enuf permissions on beta clust [21:28:06] (CR) Eileen: [C: 2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/304123 (owner: Eileen) [21:30:23] !log updated civicrm from 024a7ef2badb02743659ffed9856571d96604fd2 to cad2c59081e53b877f51be4c853f307f3c4d4949 [21:30:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:35:10] (CR) Ejegg: WmfFramework-ize some HTTP request functions (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [21:37:37] zuul is dead. Long live zuul! [21:38:06] (CR) Awight: WmfFramework-ize some HTTP request functions (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [21:45:36] (Abandoned) Ejegg: Deal better with missing version stamp file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/155079 (owner: Ejegg) [21:46:15] (Abandoned) Ejegg: Show an invalid amount message on missing currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276017 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [21:47:22] yikes [21:47:27] errybody programming at once [21:47:46] What they need is a good dose of no internet :p [21:48:36] something i actually like about the verizon hotspot [21:48:42] paying for usage [21:48:47] (Abandoned) Ejegg: Add limit to some dedupefind urls [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/298398 (owner: Ejegg) [21:48:49] is a good disincentive to be on the internet [21:54:25] (PS8) Ejegg: Compare pending DB row with queue message (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) [21:54:54] too anxiety-producing to enjoy a movie :) [21:55:03] I'm very down with ressurecting the sneakernet, btw. [21:55:32] You've heard that Ama$on is offering their highest tier of cloudization via van, right? [21:55:52] you snail mail a box of hard drives to your cloud account... [21:56:08] yeah, amazing [21:57:09] https://usesthis.com/interviews/joey.hess/ [21:57:20] Happy to mail usbs or sds of massive troves of legal content any day [21:57:43] (PS9) Ejegg: Compare pending DB row with queue message (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) [21:57:45] oh I love etckeeper! [21:58:03] (CR) Ejegg: Compare pending DB row with queue message (SEE NOTES) (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [21:58:40] (CR) jenkins-bot: [V: -1] [WIP] Check whether tests are missing CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304116 (owner: Awight) [21:58:54] The only other active computer in the house is my home server and internet gateway; a Sheevaplug with a wireless dongle and a dialup modem. [21:58:59] <3 [21:59:20] * awight jumps with excitement that I might successfully cron down a radio show in 40 seconds [21:59:32] (CR) jenkins-bot: [V: -1] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [21:59:49] awesome [22:01:03] https://github.com/adamwight/radioat [22:01:30] show / station / schedule is over-underengineered, help is welcomed [22:02:35] nice man, so you can just http get the stream? [22:02:35] ojala it's working! [22:02:54] chunked encoding? [22:02:56] yah. It needs restart logic, but that right there is a pretty solid chunking read [22:03:22] donno about that, the socket chunks may or may not line up with things in the encoding [22:03:26] prolly not [22:04:14] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2541952 (atgo) a:atgo>None [22:04:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scheduled Reminder sent from donate@ email address? - https://phabricator.wikimedia.org/T95570#2541954 (atgo) a:atgo>None [22:04:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Batch refund recurring donations in Civi - https://phabricator.wikimedia.org/T91695#2541957 (atgo) a:atgo>None [22:04:59] Fundraising-Backlog, Spike: Spike: Do we have data on unsubscribe & abuse rates from Civi TY emails? - https://phabricator.wikimedia.org/T108892#2541960 (atgo) a:atgo>None [22:05:55] Next fun steps are to embellish the curses interface and edit your crontab transparently [22:06:03] what could go wrong... [22:06:16] Fundraising-Backlog: UKFC Payment investigation - https://phabricator.wikimedia.org/T125887#2541963 (atgo) a:atgo>None [22:06:26] Fundraising-Analysis, Analytics: FR tech hadoop onboarding {flea} - https://phabricator.wikimedia.org/T118613#2541966 (atgo) a:atgo>None [22:07:13] * awight scratches head reading own spaghetti. bin/record_now is the business. [22:07:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Please rename me] UI Sillyness: The boxes don't fit in the other boxes the right way - https://phabricator.wikimedia.org/T117614#2541968 (atgo) a:atgo>None [22:07:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#2541974 (atgo) a:atgo>None [22:07:33] Fundraising-Backlog, Recurring-Donations: Send different TY letter to recurring donors - https://phabricator.wikimedia.org/T88574#2541977 (atgo) a:atgo>None [22:07:41] Wikimedia-Fundraising: Fundraiser banner opt out needs an interface - https://phabricator.wikimedia.org/T34471#2541979 (atgo) a:atgo>None [22:15:19] (PS3) Awight: [WIP] Check whether tests are missing CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304116 [22:15:21] (PS13) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [22:15:23] (PS25) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [22:18:23] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2542024 (RLewis) @Eileenmcnaughton i'm just taking a look at this again, there are duplicate rows fo... [22:20:32] Fundraising-Backlog: Set up fr-tech credentials review on 2.5-month cadence - https://phabricator.wikimedia.org/T142647#2542033 (awight) [22:24:04] (PS3) Ejegg: DO NOT MERGE: kill SmashPig pending queue code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) [22:24:45] (CR) Ejegg: "PS3: hairy rebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [22:27:17] (PS4) Ejegg: DO NOT MERGE: kill SmashPig pending queue code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) [22:28:01] Sounds like the zuuljam is clearing out now [22:28:55] fr-tech Am I right in assuming this looks kinda betaclustery-bad? https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeLogs?log=bannercontent [22:29:06] And this too? https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeLogs?log=bannercontent [22:29:26] There are CNBanner messages on the beta cluster [22:29:29] same link? [22:29:39] https://meta.wikimedia.beta.wmflabs.org/wiki/CNBanner:Browser_test_b2-title/en [22:29:54] ejegg: woops, https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log=bannermessages [22:30:12] Ah noo sorry [22:30:25] Aaaarg starting over... one sec [22:30:33] no worries, i inserted the beta.wmflabs [22:30:41] and... hmm [22:31:38] AndyRussG: that does look bad--but is anyone tweaking banner content? [22:32:09] There seems to a hidden date filter, though. Know what that is? [22:34:25] Hmm no idea [22:34:36] awight: my worry is it's a bork related to extension registration [22:35:08] https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeLogs?log=bannercontent [22:35:15] https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeLogs?log=bannermessages [22:35:21] ^ those are the empty ones on beta cluster [22:36:31] https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log=bannercontent [22:36:38] https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log=bannermessages [22:36:43] On real meta they have stuff ^ [22:40:31] Well a new change did appear in the log on labs: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeLogs?log=bannercontent [22:41:42] oh good, I was having a hard time logging in. [22:41:47] lemme check the code... [22:42:11] awight: all I wanted to be sure of was that the namespace hook is fine [22:42:34] https://gerrit.wikimedia.org/r/#/c/186899/ [22:43:00] dang, I really don't see a time restriction in CentralNoticeBannerLogPager.php [22:43:12] Hmmm yeah I never heard of one [22:44:17] lessee, the namespace hook is supposed to add the cn banner namespace so that's a test that it works, and it's not supposed to damage other namespaces, not sure how to check that. [22:44:53] do you think the emptiness of the log is a sign of some other baddness? [22:45:17] It looks like very little has happened in meta-beta CN [22:45:25] maybe that table didn't even exist? [22:47:53] AndyRussG: https://meta.wikimedia.beta.wmflabs.org/wiki/CNBanner:Stewvote-text1/en [22:48:00] So the ns is registered, at least. [22:48:19] awight: yeah [22:50:34] awight: did register my change just now: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeLogs?log=bannermessages [22:51:14] I only have three lines of copy-pasted code to check [22:51:15] if ( $wgNoticeUseTranslateExtension ) { [22:51:17] $wgHooks[ 'TranslatePostInitGroups' ][ ] = 'BannerMessageGroup::registerGroupHook'; [22:51:19] $wgHooks[ 'TranslateEventMessageGroupStateChange' ][] = 'BannerMessageGroup::updateBannerGroupStateHook'; [22:51:21] } [22:51:23] Well, four [22:51:40] Lemme just diff with the copy-paste source [22:51:57] That's the only code path that I haven't seen not fail, AFIK [22:52:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Recurring-Donations, Spike: Spike: Plan unit test coverage and alerts for recurring charges - https://phabricator.wikimedia.org/T142655#2542188 (awight) [22:52:25] Hmm though I guess if there were a syntax error, it'd have trashed the beta cluseter [22:52:58] Since translate extension is installed [22:53:11] ejegg: What IDs were missing when you needed to do the batch refund? [22:53:36] AndyRussG: wat only not-fail? [22:53:45] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2542201 (Eileenmcnaughton) Yes - this is a contribution report https://civicrm.frdev.wikimedia.org/ci... [22:54:09] AndyRussG: That one can be tested by trying to review banner messages through the Special:Translate interface [22:54:19] I see a translate in beta cluster,but the translate extension is installed [22:54:21] Ah K [22:54:36] Sorry I meant to say, I don't see a beta cluster version of translate wiki [22:54:49] Something in here, https://meta.wikimedia.beta.wmflabs.org/wiki/Special:Translate?group=Centralnotice-tgroup [22:55:25] awight: the full merchant reference with .xxxxx [22:55:35] and the effort ids [22:55:51] ejegg: Should that be landing in w*extra.gateway_txn_id? [22:56:12] AndyRussG: oh wait, I think I'm confusing features with the FundraisingTranslateWorkflow extension [22:56:42] awight: there's stuff if you want to go to a non-English language: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:Translate?group=Centralnotice-tgroup&filter=&language=de&action=translate [22:57:05] awight, no, not the merchant id [22:58:24] AndyRussG: ah okey right the first time. So the CN hooks should prevent you from publishing a message translation unless you have the cn admin right [22:59:20] ejegg: the "order_id", then? [23:00:09] awight: hmmm should I smoke test that somehow? I'd need a non-cn adminuser for beta cluster [23:00:25] I just diffed the copypasta'd code and it's identical of course [23:01:52] fr-tech I'm gonna just deploy this! I think we're tested enuf now :) [23:02:13] awight yep [23:02:33] back in a bit [23:04:16] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/304130 [23:05:07] what is the difference between https://phabricator.wikimedia.org/tag/astropay/ and https://phabricator.wikimedia.org/tag/fr-astropay/ ? [23:05:44] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/304130 (owner: AndyRussG) [23:06:06] AndyRussG: works for me! I do have a unpermissioned user if you change yr mind. [23:06:55] Danny_B: good catch--all of the Astropay-tagged tasks also have FR-Astropay, so it would be fine to delete the former tag. [23:06:56] awight: cool thx!!!! [23:08:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Recurring-Donations: Record contribution "order_id" in the CiviCRM database - https://phabricator.wikimedia.org/T142657#2542247 (awight) [23:08:52] awight: tag can't be deleted. and it's archived. i just wonder if i can remove it from open tasks and (if applicable) replace it with fr-astropay [23:09:19] s/open// [23:09:46] Fundraising-Backlog, Recurring-Donations: Give Donor Services kill switch access to various services - https://phabricator.wikimedia.org/T142658#2542259 (awight) [23:12:04] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: [Epic] Provision PSP maintenance scripts to the CRM box - https://phabricator.wikimedia.org/T142659#2542273 (awight) [23:12:25] Danny_B: yes, please. Thanks for noticing! [23:14:12] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2542287 (Eileenmcnaughton) I just deployed this code onto staging. They load! My only annoyance so far is that if you expand the dashlet... [23:14:40] dstrine: try adding a dashlet on staging now - they actually load [23:17:51] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2542291 (Eileenmcnaughton) Also another feature request from me would be a configure the report button option direct from the dashboard w... [23:20:05] eileen: nice! This is a fix for the dashboard SSL issue? [23:20:47] awight: yep [23:21:19] Impressive background project during the dedupe work! [23:22:07] well I didn't do it - Coleman did [23:22:24] I just wrangled the code up onto staging [23:22:42] https://github.com/civicrm/civicrm-core/pull/8851 [23:23:23] even better ;) [23:23:58] Wow, big patch [23:25:17] awight: will do. yw. [23:26:48] awight: big clean up [23:27:22] * awight is chagrined that we still don't pay the CiviCRM membership [23:27:31] I think we must do now [23:27:49] ie the contract discussion included that [23:30:31] good thinking! [23:32:20] fr-tech CN deploy canceled due to SWAT canceled because zuul and train rollback 8p [23:32:34] just fyi [23:32:58] aww [23:33:00] poor zuul [23:33:04] indeed [23:33:09] oh wellz [23:34:09] bummer d00d [23:34:37] I would say we should ask Dana to help out, but, well you know... [23:49:39] awight: cleaned up [23:53:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic: [Epic] Provision PSP maintenance scripts to the CRM box - https://phabricator.wikimedia.org/T142659#2542442 (Danny_B)