[00:01:46] Hmm gerrrit bot is all foo bar [00:03:38] cwd it's really dumb, but if you focus in the url bar ctrl-f isn't intercepted [00:05:03] hehe nice thanks [00:17:15] ejegg: legoktm Reedy Deployed on mw1099, everything looks peachy [00:17:37] awesome [00:19:01] nice, nice [00:39:56] ejegg: legoktm: all deployed1 [00:39:58] ! [00:40:10] nice! [00:40:28] no errors in the logs, huh [00:40:29] ? [00:42:32] none so far! [00:42:50] Later I can try to edit some banner translatable message that's old and defunct or from a test... [00:43:51] cool [00:44:28] ok, i'm outta here for the evening! [00:44:58] ejegg|away: thx seeya [00:45:03] legoktm: thx much! [01:33:45] Fundraising-Backlog, Project-Admins: Please create a #signal-to-noise tag - https://phabricator.wikimedia.org/T140531#2468102 (Danny_B) >>! In T140531#2473055, @DStrine wrote: > This tag helps identify tasks associated with "failmail" and emergency alerts. There are times when real emergency messages fro... [03:34:06] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2546757 (RLewis) @Eileenmcnaughton I tried to change the Pipeline Report so that it was a Constituent... [05:59:18] eileen: hi! Hopefully you haven't been digging into this recent Ingenico currency glitch? [07:28:46] awight: no got caught up in kids things - I took a quick look but realised I was on a backfoot making sense of it [13:47:40] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 4 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#2547843 (AndyRussG) Following deploy, a single... [13:49:10] Fundraising-Backlog, Epic, Technical-Debt: [epic] Migrate fundraising extensions to the new format - https://phabricator.wikimedia.org/T95832#2547849 (AndyRussG) [13:49:20] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 4 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1528581 (AndyRussG) Open>Resolved [14:47:02] * cwd|afk at last creates worldpay spam filter [15:04:32] Fundraising-Backlog, Project-Admins: Please create a #signal-to-noise tag - https://phabricator.wikimedia.org/T140531#2547995 (DStrine) T136169 would get this tag. Fr-tech has multiple projects and code bases. The signal to noise tag would be generalized to all fr-tech work. The term signal to noise is... [15:08:34] * AndyRussG waves [15:36:37] (CR) Ejegg: "Aha, the _2 fields were for shipping info from when we used to send out tshirts: https://github.com/wikimedia/wikimedia-fundraising-Paymen" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/304289 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [15:46:25] (PS2) Ejegg: Remove unused commit of legacy PayPal IPN code [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294636 (owner: Awight) [15:47:05] (CR) Ejegg: [C: 2] Remove unused commit of legacy PayPal IPN code [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294636 (owner: Awight) [15:47:35] (CR) Ejegg: [V: 2] Remove unused commit of legacy PayPal IPN code [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294636 (owner: Awight) [16:48:38] hi awight [16:50:28] halloo! [16:51:01] fr-tech hi!!! any ideas on what specifically to do for this one? https://phabricator.wikimedia.org/T139439 thx in advance! [16:51:12] (sorry, a bit distracted by a kid handoff for the next few mins) [16:51:42] close the airlocks! [16:52:00] AndyRussG: err, i guess looking at error logs? [16:52:17] We'd need client-side JS ones... [16:52:22] We checked to make sure the patch had the intended effect, right? [16:52:30] Ah yes that for sure [16:52:45] ah, do we do any event logging of client side js errors? [16:53:13] Yeah I guess that's the place to start... [16:53:28] As in, ask elsewhere for such [16:53:39] K I'll poke 'n' ping on that... thx!! [16:53:46] kewl [16:54:12] I think we just break js on the rest of the site, when client js errors happen [16:55:20] Yeah... Clearly that didn't happen. I'm worried rather about some edge-case error in something else, from some user script or unusual module that was expecting CN on those pages, but that whoever saw it hasn't figured out yet :) [16:56:08] harrummm [16:56:11] Lemme see what the IRC channel is for editing and collab folks [16:56:23] Not sure what that would be, aside from geoip [16:56:56] awight: mmm GeoIP _is_ still added everywherez [16:57:05] "good" :) [16:57:35] ""good""? [16:58:14] Sorry I meant, "\"good\""? [16:58:37] meaning, glad that's still working but looking forward to the day it becomes not our problem [16:58:53] Ah yeah indeed :) [16:59:35] I can't imagine what else would rely on CN though, since there were no public APIs provided by the legacy code [16:59:53] hmmm yeah [17:00:08] I dunno, something that sprung up recently to check for a banner or not? [17:00:13] Do we still create the div#centralNotice ? [17:01:11] Only when we load ext.centralNotice.startUp, so in effect, that's now gone on edit and special pages [17:02:44] Just by deduction, I bet anything that relies on that div will fail in a non-fatal way, where something won't be displayed [17:03:12] How would the hypothetical edge case code detect a banner, I wonder... [17:03:31] hypothetically using the API we exposed since the refactor? [17:03:49] haha people finding and using an API... doubtful ;-) [17:04:15] A specific extension to check would be the quick surveys thing, though [17:04:51] right! people would sooner start writing a massive encyclopedia collaboratively just for the heck of it [17:05:40] lol, and reimplement existing functionality using a Byzantine mush of curly braces [17:06:18] is the plan to consolidate the 'donations' and 'recurring' queues? [17:06:35] ejegg: I wasn't planning to--what do you think? [17:06:52] My thought is that each queue should only handle one message type [17:06:57] k, sounds good [17:07:21] err, that sounded more ambiguous than I meant it. One message schema [17:07:38] oh hey, any objections to getting rid of a table in prod Civi that we don't have in dev setups? https://phabricator.wikimedia.org/T142747 [17:07:58] AndyRussG: fwiw, resources/ext.quicksurveys.init/init.js disables QuickSurveys on non-article pages. I'm not seeing anything about banners yet, though [17:08:15] ejegg: +1! [17:08:17] hmmm k thx! [17:08:37] kewl [17:08:45] gross. $place = $bodyContent.find( '> div > div' ).eq( 0 ).find( ' > p' ).eq( 0 ); [17:08:56] oh jeez [17:09:12] jquery jenga [17:10:25] man, updating that legacy paypal listener is unpleasant. i almost want to pull the relevant code into smashpig [17:10:29] hmm [17:10:32] AndyRussG: I think we need to hook up with the QuickSurveys maintainers, it looks like there's nothing to prevent QS from appearing at the same time as a banner. [17:10:46] Hmmm K [17:10:46] ejegg: there's a task for it... I'm happy to help [17:11:06] I think those are the guys we've talked to about them actually using CN instead of something else, no? [17:11:42] That would be nice, but what about the stuff they've built already? [17:11:48] Yeah [17:12:11] So, we're doing absolutely nothing with the paypal pending messages when we leave them in the queue after they fail donations... [17:12:19] I mean fail verifications [17:12:51] That script can barely log its own existence [17:13:02] the "inflight" thing is a fiction [17:13:45] p [17:14:02] PP express checkout will require the listener to not suck [17:14:24] or at least, will provide a good excuse to fix it [17:15:55] MBeat: durn, I failed to get that thank you unsubscribe thing deployed in a timely fashion. Mind monitoring it today? [17:16:17] not at all awight [17:16:17] * cwd glares [17:16:36] cwd: wassup [17:16:47] MBeat: cool, let me get that ready [17:16:58] oh just it's friday [17:17:48] Thank you for being our conscience ;) [17:18:09] also, that GC audit jam, would that apply to the batch refunds of the recurring currency bug from last weekend? Leanne’s running into issues sorting realy MG donors versus inadvertent ones, awight [17:18:42] MBeat: The jam should be cleared, I was able to rerun all the other records last night [17:18:48] excellent, ty! [17:18:54] cwd: wanna brainstorm failure modes? [17:19:10] cwd: If the TY letter includes a bad unsubscribe link... [17:19:10] sure, on the horn? [17:19:13] oh sure [17:19:18] i'll be there in 5 [17:19:28] MBeat: wanna join in? [17:19:38] sure thing! [17:32:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add explanatory text and graphics in the dashboard configuration page - https://phabricator.wikimedia.org/T142853#2548485 (DStrine) [17:54:40] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Fold 'donor comment' field into 'note' - https://phabricator.wikimedia.org/T142747#2548520 (CaitVirtue) Sounds ok to me. Just wondering if you can give any exam... [18:27:10] (PS2) Ejegg: Remove unused modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304285 [18:28:26] (CR) jenkins-bot: [V: -1] Remove unused modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304285 (owner: Ejegg) [18:29:08] (CR) Awight: "blank lines at the end make me nervous..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304275 (owner: Ejegg) [18:29:53] (PS3) Ejegg: Centralized list of enabled modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304275 [18:30:42] (CR) Awight: [C: 2] Centralized list of enabled modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304275 (owner: Ejegg) [18:33:48] (Merged) jenkins-bot: Centralized list of enabled modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304275 (owner: Ejegg) [18:34:56] (CR) Awight: [C: 2] Use module list from crm repo [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/304276 (owner: Ejegg) [18:38:58] (Abandoned) Awight: DO NOT MERGE: trip PHPUnit tests [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294202 (owner: Awight) [18:39:30] (Abandoned) Awight: DO NOT MERGE: Dummy commit for validating Zuul config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/295931 (owner: Awight) [18:41:37] k, taking a quick smog and tacos date... back by standup [18:47:31] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ, FR-PayPal-ExpressCheckout, and 2 others: Move legacy PayPal listener to SmashPig - https://phabricator.wikimedia.org/T141654#2548647 (Ejegg) a:Ejegg [18:48:09] (PS1) Ejegg: Legacy PayPal: send pending message. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304495 (https://phabricator.wikimedia.org/T141654) [19:22:36] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2548759 (RLewis) @DStrine and @Eileenmcnaughton - Virtue has looked at the test report and has recom... [19:23:23] (PS1) Ejegg: De-duplicate IncomingMessage action [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/304499 [19:27:53] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 3 others: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and act... - https://phabricator.wikimedia.org/T139439#2548766 [20:12:45] (PS2) Ejegg: globalcollect_audit doesn't need contribution_audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304284 [20:29:58] wait. how do our phpstorm licenses work? I have to request one from yurik? [20:30:05] There used to be a shared license... [20:33:19] nvm I found the link on officewiki [21:00:19] ejegg: cwd: btw, https://scrutinizer-ci.com/profile/notifications/g/wikimedia/mediawiki-extensions-DonationInterface is where to get email notifications for each build [21:01:27] ah, thanks! just signed up [21:02:12] nice. The pstorm license worked itself out nicely, too... Phoned home without even asking me for oauth, I believe. [21:02:30] fixing this atm, https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-DonationInterface/inspections/50d943dc-64c3-4a0e-90be-78f4916e554f/issues/files/extras/session_velocity/session_velocity.body.php?status=new&orderField=path&order=asc&honorSelectedPaths=0 [21:03:10] ejegg: I see I totally overlooked your comments on PS21 [21:03:20] I'll try to be more readingful next time... [21:03:21] so the smashpig-ization of legacy paypal is going to look pretty non-standard. We have to send the whole raw post data in the job to be able to do the validation. And the recurring queue consumer in CRM takes a totally non-normalized paypal IPN message [21:03:35] ehh... [21:03:59] thanks awight! [21:04:18] yes that's correct, I've been hoping to normalize that message. [21:04:46] I wonder if it makes sense--so the donation data all gets normalized, but whither recurring-specific fields? [21:04:47] i guess we should decide on the deployment path for this bit too [21:14:18] Maybe we do this 2.0 style also, and run the new code in parallel. [21:16:40] About the job schema, though... I'm torn about serializing the raw incoming IPN. Parsing seems like a reasonable responsibility to give the listener first stage. [21:20:32] On a tangent, we could doImmediate schedule the verification job runner after the listener finishes enqueuing the IPN packet. [21:28:29] awight: I see it didn't matter that I didn't get my head around that fail mail [21:29:15] ejegg: So I suspect the extras classes actually need access to an IContextSource [21:31:30] awight: can't do that through the static shim? [21:34:15] A second dog was just dropped off. Super cute around here... [22:11:11] Fundraising-Backlog: Is payments_initial missing Ingenico transctions? - https://phabricator.wikimedia.org/T142873#2549542 (MBeat33) [22:31:15] Fundraising-Backlog: Minor cleanup of payments URLs - https://phabricator.wikimedia.org/T142876#2549598 (awight) [22:35:13] Fundraising Sprint Octopus Untangling, Fundraising-Backlog: Create frack vm cluster - https://phabricator.wikimedia.org/T142533#2549635 (cwdent) So far I have the router and the deployment server provisioned but with a lot of errors mostly relating to the sensitive repo being missing. I mocked out enoug... [22:50:19] (PS1) Awight: Fix dangling references to GatewayType::getRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304582 [22:50:29] Fundraising-Backlog: Is payments_initial missing Ingenico transactions? - https://phabricator.wikimedia.org/T142873#2549690 (MBeat33) [23:08:00] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2549804 (awight) a:awight [23:08:10] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617#2549805 (awight) a:AndyRussG [23:10:44] Fundraising-Backlog: Is payments_initial missing Ingenico transactions? - https://phabricator.wikimedia.org/T142873#2549542 (awight) We might have to pull this into the sprint. [23:37:34] Weird, cannot figure out how to reload vim edits from phpstorm. That seems... important [23:45:44] #IDEs [23:47:22] (PS1) Awight: Avoid undefined variable warnings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304589 [23:47:27] It's baffly [23:48:03] It aggressively didn't want to show me the new file contents, although the search results pane turned "invalid" [23:48:33] k gotta go on a flooring acquisition expedition [23:48:54] The concrete pad we live on has like a 3" chasm that I need to fill with foam or something [23:49:24] i was just doing that last night [23:49:27] Landlord poured a little self-leveling compound into the active fault when I complained last... so I need to take care of this vigilante style [23:49:37] the first battle in the war against mice at 49 avenida ponderosa [23:49:51] the civil war scene [23:49:54] ? [23:49:59] indeed [23:50:09] i got a pro tip about great stuff expanding foam [23:50:41] when you are finished, take the straw off and blow it out, then use a few drops off acetone to clean the nozzle and straw [23:50:43] wowza [23:50:46] Wear a respirator, Hanta is no laughing matter [23:50:46] Your chance of surviving is 50% if you *do* make it to the hospital in time [23:50:46] and you don't have to throw away half a can [23:51:12] yeah, and new mexico has the highest incidence in the country [23:51:27] thank you, I've been angry about the single-use can [23:52:19] k gtg for now [23:52:50] have a fun weekend battling the rats of NIMH [23:52:55] thanks! [23:53:02] good luck with the hole [23:53:43] http://news.nationalgeographic.com/content/dam/news/photos/legacy-new/giant-sinkhole-guatemala-city-why_21263_990x742.jpg