[00:01:51] Fundraising-Backlog, Spike: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2552223 (cwdent) I turned off the dedupe jenkins job but they are still happening. The error rate does not seem regular or predictable. The message on... [04:54:29] Fundraising-Backlog, Spike: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2552467 (Eileenmcnaughton) Normally the mysql command SHOW ENGINE INNODB STATUS reveals the query causing the hang - but I know in the past when we l... [06:58:37] (PS3) Awight: Fix 'use' statements and implicit fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303851 (owner: Ejegg) [06:58:43] (CR) Awight: [C: 2] "IDE FTW!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303851 (owner: Ejegg) [06:59:27] (Merged) jenkins-bot: Fix 'use' statements and implicit fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303851 (owner: Ejegg) [06:59:29] (PS2) Awight: Improve phpdoc comments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303852 (owner: Ejegg) [06:59:34] (CR) Awight: [C: 2] Improve phpdoc comments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303852 (owner: Ejegg) [07:00:29] (Merged) jenkins-bot: Improve phpdoc comments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303852 (owner: Ejegg) [07:00:47] (CR) Awight: Fix jslint errors (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [07:00:52] (PS5) Awight: Fix jslint errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [07:00:58] (CR) Awight: [C: 2] Fix jslint errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [07:01:27] (CR) Awight: "Thank you!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [07:02:45] (CR) jenkins-bot: [V: -1] Fix jslint errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [10:11:15] (CR) Paladox: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [10:11:45] (CR) Paladox: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [10:20:19] (CR) Paladox: "@Awright hi it seems this https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/2965/console fails but it has nothing to " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [14:01:39] fundraising-tech-ops: encrypt fundraising kafka collector traffic - https://phabricator.wikimedia.org/T142993#2553314 (Jgreen) [14:02:01] fundraising-tech-ops: encrypt fundraising kafka collector traffic - https://phabricator.wikimedia.org/T142993#2553327 (Jgreen) [14:13:47] fundraising-tech-ops: configure TLS for fundraising syslog collection - https://phabricator.wikimedia.org/T142994#2553340 (Jgreen) [14:14:02] fundraising-tech-ops: configure TLS for fundraising syslog collection - https://phabricator.wikimedia.org/T142994#2553353 (Jgreen) [16:00:07] Fundraising-Backlog, Wikimedia-Fundraising, Analytics: Public dashboards for CentralNotice and Fundraising - https://phabricator.wikimedia.org/T88744#1019258 (Nuria) Removing analytics from ticket as it doesn't have any actionables for team. [16:00:13] Fundraising-Backlog, Wikimedia-Fundraising: Public dashboards for CentralNotice and Fundraising - https://phabricator.wikimedia.org/T88744#2553679 (Nuria) [16:00:48] Fundraising-Backlog, Operations, Ops-Access-Requests: Access request: AWight access to iridium - https://phabricator.wikimedia.org/T142446#2553685 (RobH) Open>declined It appears that this is declined, with the reason being this data is better accessed via hadoop. I'm going to close this tas... [16:02:02] Fundraising-Backlog, Operations, Ops-Access-Requests: Access request: AWight access to iridium - https://phabricator.wikimedia.org/T142446#2535387 (Ottomata) FYI, this is in Hive in the `wmf.webrequest` table in the `webrequest_source='misc'` partition. [16:26:51] (PS8) Ejegg: Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [16:28:15] (CR) jenkins-bot: [V: -1] Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [16:28:18] XenoRyet: and ejegg good morning! I want to ask advancement to start running adyen in enlgish/USD in low levels like ingenico just so we know it's working. I don't see any open bugs that would block that. Would you have any reservations? [16:28:58] hi dstrine [16:29:19] I think that should be fine [16:29:23] Nothing blocking that I can think of. [16:29:41] fr-tech: does this SQL look good? https://gerrit.wikimedia.org/r/304326 Going to get rid of that table [16:30:02] thanks XenoRyet and ejegg [16:32:38] (CR) XenoRyet: [C: 2] Merge 'donor comments' custom field into note [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304326 (https://phabricator.wikimedia.org/T142747) (owner: Ejegg) [16:32:47] ejegg: Yea, looks fine to me. [16:33:13] Fundraising-Backlog, DBA, Labs, MediaWiki-extensions-CentralNotice: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2553792 (DStrine) [16:33:58] (CR) jenkins-bot: [V: -1] Merge 'donor comments' custom field into note [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304326 (https://phabricator.wikimedia.org/T142747) (owner: Ejegg) [16:38:46] AndyRussG: I don't want to distract you from anything else but I was wondering if this is an fr-tech task or another team? https://phabricator.wikimedia.org/T135405 [16:40:21] dstrine: hi! looking... [16:41:30] hmm, missing CiviFixtures? [16:42:09] dstrine: it's in our interest to have it happen, but we're not the ones to do it [16:45:10] Fundraising-Backlog, DBA, Labs, MediaWiki-extensions-CentralNotice: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (AndyRussG) >>! In T135405#2374114, @Base wrote: > The tables in the desc looks like indeed the most useful ones, but I would like all the... [16:45:19] (PS1) Ejegg: Fix enabled modules path [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/304853 [16:45:46] XenoRyet: oops, ^^^ should fix the failures in all the CRM tests [16:46:35] Fundraising-Backlog, DBA, Labs, MediaWiki-extensions-CentralNotice: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2553836 (Jseddon) [16:47:08] Fundraising-Backlog, DBA, Labs, MediaWiki-extensions-CentralNotice: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (Jseddon) [16:51:48] (PS2) Ejegg: Merge 'donor comments' custom field into note [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304326 (https://phabricator.wikimedia.org/T142747) [16:52:42] (CR) XenoRyet: [C: 2] Fix enabled modules path [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/304853 (owner: Ejegg) [16:53:00] (CR) jenkins-bot: [V: -1] Merge 'donor comments' custom field into note [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304326 (https://phabricator.wikimedia.org/T142747) (owner: Ejegg) [16:53:04] XenoRyet: that repo might need manual v+2 / submit [16:53:20] Ah, cool. I'll do that. [16:53:27] (CR) XenoRyet: [V: 2] Fix enabled modules path [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/304853 (owner: Ejegg) [16:55:31] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304326 (https://phabricator.wikimedia.org/T142747) (owner: Ejegg) [17:06:00] fr-tech: anyone want to collaborate on the paypal listener? [17:06:25] or have other ideas for fr-tech-talk? [17:06:26] ejegg: yessir [17:06:34] jumping on... [17:06:37] k, i'll be on the call in one sec [17:07:04] K I'll go too! [17:07:24] i am in the middle of learning about the firewalls, might show up in a bit [17:08:49] XenoRyet: fr-tech-talk? [17:09:00] Sure, one sec. [17:25:40] Fundraising-Backlog: Is payments_initial missing Ingenico transactions? - https://phabricator.wikimedia.org/T142873#2554004 (MBeat33) [17:57:06] Fundraising-Backlog, FR-Adyen, FR-Ingenico: Randomly show adyen or ingenico in form - https://phabricator.wikimedia.org/T143017#2554161 (DStrine) [18:08:25] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617#2554227 (awight) @AndyRussG Hi! I'm wondering if you have in-progress notes we can look at--t... [18:17:13] ejegg: Your patch for review? [18:17:20] s/review/adoption/ [18:19:07] awight: oh sure, one sec [18:19:28] very little actually there so far... [18:20:17] (PS1) Awight: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304866 [18:20:22] perfect, then! [18:22:11] (CR) Awight: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304866 (owner: Awight) [18:22:13] (PS1) Ejegg: WIP PayPal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/304868 [18:22:15] all yours awight^^ [18:22:23] thankye sir [18:23:28] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304866 (owner: Awight) [18:32:42] (PS1) Awight: Update composer libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/304870 [18:32:55] (CR) Awight: [C: 2] Update composer libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/304870 (owner: Awight) [18:33:12] (PS1) Awight: Update composer libs [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304871 [18:33:22] (CR) Awight: [C: 2] Update composer libs [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304871 (owner: Awight) [18:34:16] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/304872 [18:34:26] (CR) Awight: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/304872 (owner: Awight) [18:34:36] (Merged) jenkins-bot: Update composer libs [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304871 (owner: Awight) [18:36:12] Fundraising-Backlog, Continuous-Integration-Config: mediawiki/extensions/DonationInterface/vendor repo needs CI V+2 jobs - https://phabricator.wikimedia.org/T143025#2554390 (awight) [18:37:14] (CR) Awight: [V: 2] Update composer libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/304870 (owner: Awight) [18:48:42] Fundraising Sprint Queen, Fundraising-Backlog, FR-Amazon, Patch-For-Review: Create MW API method to process Amazon payments - https://phabricator.wikimedia.org/T108113#2554449 (DStrine) [18:48:57] Fundraising Sprint Queen, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface, and 2 others: Implement Amazon wallet widget - https://phabricator.wikimedia.org/T108116#2554450 (DStrine) [18:49:07] Fundraising Sprint Queen, Fundraising-Backlog, FR-Amazon, Patch-For-Review: Clear out old Amazon code - https://phabricator.wikimedia.org/T108659#2554451 (DStrine) [18:49:27] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/304872 (owner: Awight) [18:49:38] Fundraising Sprint Queen, Fundraising-Backlog, FR-Amazon, Patch-For-Review: Switch Amazon to use Mustache form, load custom JS and widgets - https://phabricator.wikimedia.org/T108114#2554454 (DStrine) [18:51:15] (CR) Awight: "Oops, looking at this again, we want the same fix in the Express Checkout adapter." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304495 (https://phabricator.wikimedia.org/T141654) (owner: Ejegg) [18:52:08] !log update paymentswiki from 6b1f3c278308f831a149c986d2269342f94e2a16 to 75e4d2509a53910e5630ca3dca5950474b587a17 [18:52:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:55:33] cwd: I'm not sure I need to roll back, but looks like the source_* patch might be messing with the pending queue consumer [18:55:47] shoot [18:55:48] oh? [18:55:55] meh, I'll roll back [18:56:15] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, FR-Astropay, Patch-For-Review: Investigate AstroPay SmashPig FailMail - https://phabricator.wikimedia.org/T108995#2554495 (DStrine) [18:56:25] !log roll back paymentswiki from 75e4d2509a53910e5630ca3dca5950474b587a17 to 6b1f3c278308f831a149c986d2269342f94e2a16 [18:56:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:56:32] weird, what was missing? [18:56:35] thanks... [18:56:49] donno, it could have been a different patch. [18:57:03] whatever it is we should make the tests catch it [18:57:07] The "error" log file has the details [18:57:09] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, FR-Amazon, Patch-For-Review: Remove Amazon from forms (Aug 21) - https://phabricator.wikimedia.org/T107528#2554496 (DStrine) [18:57:16] cwd: +1 [18:57:19] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface: Make Amazon API calls to authorize and capture payment - https://phabricator.wikimedia.org/T108119#2554497 (DStrine) [18:57:33] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, FR-Amazon, Patch-For-Review: Spike: get Amazon authentication working with automatic redirect - https://phabricator.wikimedia.org/T108112#2554502 (DStrine) [18:57:38] email: null [18:58:04] That exception should list the missing fields, also [18:58:07] awight: ohh.. paypal [18:58:28] that might be legitimate [18:59:08] Wait, it must be missing order id too [18:59:19] that validation exception doesn't check for email [19:00:00] cwd: Sorry to point the finger at source_*, now I'm thinking it's my RequestContext craziness [19:00:56] lots of moving pieces [19:01:24] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, FR-Worldpay: worldpay internal test: Write controller logic to handle return from iframe - https://phabricator.wikimedia.org/T110424#2554574 (DStrine) [19:01:25] awight: totally the paypal patch [19:01:34] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, FR-Worldpay: worldpay internal test: Store donor info in a limbo or pending queue - https://phabricator.wikimedia.org/T110425#2554575 (DStrine) [19:01:44] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, FR-Astropay, Patch-For-Review: AstroPay audit parser failing - https://phabricator.wikimedia.org/T112779#2554576 (DStrine) [19:01:45] ejegg: ah 9dd81001e53f5f1447400c60fc6fd625b4756746 [19:01:48] i just need to copy ct_id into order_id before sending [19:01:49] k I'll just revert that for now, then [19:01:54] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, FR-Worldpay: worldpay internal test: Make API requests to get iframe URL - https://phabricator.wikimedia.org/T110422#2554577 (DStrine) [19:01:58] either way [19:02:16] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, FR-Worldpay: worldpay internal test:Display Iframe - https://phabricator.wikimedia.org/T110423#2554579 (DStrine) [19:02:18] that way sounds better ;) [19:02:54] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, FR-Worldpay: worldpay internal test: Add forms to form chooser settings - https://phabricator.wikimedia.org/T110426#2554595 (DStrine) [19:04:00] awight: oops, that patch is sending the message even when we have validation problems. please go ahead and revert, i'll fix it [19:04:53] it should happen every time the PaymentResult->isRedirect [19:05:26] ok perfect [19:06:52] (PS1) Awight: Revert "Legacy PayPal: send pending message." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304876 [19:07:05] (CR) Awight: [C: 2] "self-merge revert" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304876 (owner: Awight) [19:07:26] (PS1) Awight: Revert "Legacy PayPal: send pending message." [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304877 [19:07:34] (CR) Awight: [C: 2] Revert "Legacy PayPal: send pending message." [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304877 (owner: Awight) [19:08:26] Too bad--our thank-you letter unsubscribe URL is no longer parsed by gmail, it seems. [19:08:52] (Merged) jenkins-bot: Revert "Legacy PayPal: send pending message." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304876 (owner: Awight) [19:09:06] Fundraising Sprint Tom Waits, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface, and 2 others: Close Amazon order reference asynchronously - https://phabricator.wikimedia.org/T113809#2554636 (DStrine) [19:09:31] Fundraising Sprint Tom Waits, Fundraising-Backlog, FR-Worldpay, Unplanned-Sprint-Work: Fix Worldpay audit parsing - https://phabricator.wikimedia.org/T113782#2554637 (DStrine) [19:09:38] awight: the one in the header? [19:09:43] Fundraising Sprint Tom Waits, Fundraising-Backlog, FR-Amazon, Unplanned-Sprint-Work: Update WMF logo(s) in Amazon config - https://phabricator.wikimedia.org/T113563#2554638 (DStrine) [19:10:15] (Merged) jenkins-bot: Revert "Legacy PayPal: send pending message." [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/304877 (owner: Awight) [19:11:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Spike: Spike: unsubscribe might have to be a mailto now, rather than an https link - https://phabricator.wikimedia.org/T143035#2554656 (awight) [19:11:06] cwd: exactly [19:14:36] MBeat: This could be serious... T143035 [19:14:36] T143035: Spike: unsubscribe might have to be a mailto now, rather than an https link - https://phabricator.wikimedia.org/T143035 [19:14:56] We suspected this was coming down the pipeline, it seems to have landed now [19:15:01] ty, looking @ [19:15:27] oh man [19:16:02] dang [19:16:07] I wonder if there's a law... [19:16:29] Please do double-check me--does anyone else see an unsub button? [19:16:39] I know google experiments (aka effs with) their UI constantly [19:17:03] looks like outlook.com is only using the mailto now: https://blog.returnpath.com/evolution-of-list-unsubscribe/ [19:18:59] For example the ones that say "Seed (etc.)", from giving@wikpedia.org? Don't see any unsubscribe buttons or options in the action menu on Gmail Web UI [19:19:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Spike: Spike: unsubscribe might have to be a mailto now, rather than an https link - https://phabricator.wikimedia.org/T143035#2554751 (awight) ``` 12:17 < ejegg> looks like outlook.com is only using the mailto now: https://blog.retu... [19:19:43] AndyRussG: ooh funky--that's a separate system, it's suspicious if they have the same problem. [19:20:08] The "unsubscribe instantly" link at the bottom links to a site at www.pages04.net [19:20:30] That doesn't looks especially nut-free, either [19:20:38] also, if you click the dropdown at the top, next to the "to" address, there's an unsubscribe link [19:21:02] List-Unsubscribe: , [19:21:06] they do it modernly [19:21:13] Hmmm [19:21:16] Is that the same? [19:21:28] No, we only send an URL [19:21:32] Hmmm [19:21:34] in the thank-you letters [19:21:37] Ah right [19:23:30] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/304880 [19:23:40] (CR) Awight: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/304880 (owner: Awight) [19:24:20] AndyRussG: ooh I just realized, that unsubscribe is actually for the forwarding from IBM to fr-software-engineers [19:24:55] I need a food for a bit [19:42:02] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/304880 (owner: Awight) [19:47:58] wow, our order id generation makes me sad [19:48:15] :-) [19:54:37] What do you call the listeners in the PaymentsListeners repo? "Legacy listeners"? [19:54:54] "Legacy payments listeners"? [20:01:32] hard of hearing [20:03:59] heh [20:04:13] Also will drush jobs every access the Pending database? Or only SmashPig? [20:05:22] AndyRussG: yep, drush jobs will use it too: https://gerrit.wikimedia.org/r/299816 [20:07:57] Is there a piece of code that "owns" it, such as for upgrades, or any abstraction layer? Or is just a plain DB accessed as such? [20:10:31] AndyRussG: PendingDatabase class in SmashPig [20:10:59] ejegg: ah K! So that's the only code that deals with it directly? [20:11:07] should be [20:11:23] Cool sounds perfect :) [20:28:27] Fundraising-Backlog, Spike: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2554987 (Jgreen) Possibly relevant.... InnoDB: transactions deadlock detected, dumping detailed information. 160814 19:36:37 *** (1) TRANSACTION: TRANS... [20:32:06] Fundraising-Backlog, Spike: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2554995 (Eileenmcnaughton) This query should not happen > INSERT INTO dedupe (id1, id2, weight) SELECT t1.contact_id id1, t2.contact_id id2, 5 weight... [20:46:45] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ: Store damaged and delayed messages in a database not a queue - https://phabricator.wikimedia.org/T142028#2555046 (Ejegg) Open>Resolved [20:49:47] Fundraising-Backlog, Spike: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2555054 (Eileenmcnaughton) OK I've got a handle on what is happening here. Each time the dedupe runs it runs on the next block of contacts - it's curre... [20:52:15] Fundraising-Backlog: Access to lutetium and MySQL - https://phabricator.wikimedia.org/T141945#2555102 (Jgreen) Leanne, sorry for the delay! This fell through the cracks before I left for vacation. I'm requesting a Yubikey from OIT for you, you'll need that to get started. [20:57:08] Fundraising-Backlog: Access to lutetium and MySQL - https://phabricator.wikimedia.org/T141945#2555137 (Jgreen) p:Triage>Unbreak! [21:01:19] Fundraising-Backlog: Access to lutetium and MySQL - https://phabricator.wikimedia.org/T141945#2555147 (LeanneS) @jgreen thanks, I actually already requested a yubikey from OIT and just picked it up them. Hope you had a nice vacation! [21:08:02] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2555169 (Eileenmcnaughton) This code is now on our staging & it seems OK. The code has been merged into 4.7.11. 4.7.11 is due to be relea... [21:09:23] (PS1) Eileen: Fix criteria range selection on dedupe. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) [21:14:14] (PS2) Eileen: Fix criteria range selection on dedupe. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) [21:17:41] !log update paymentswiki from 6b1f3c278308f831a149c986d2269342f94e2a16 to b449f65dba5697905a87261592e934d7f4898a54; update config for FundraisingEmailUnsubscribe [21:17:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:23:14] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Patch-For-Review, Spike: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2555197 (Eileenmcnaughton) a:Eileenmcnaughton [21:23:50] I just pushed up a fix for that hurtful query https://phabricator.wikimedia.org/T142954 [21:31:06] (PS1) Ejegg: Paypal: set order ID = ct_id, email is an optional key [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304930 (https://phabricator.wikimedia.org/T141654) [21:35:39] !log update Thank-you letter to point to the new unsubscribe server [21:35:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:35:56] (PS1) Ejegg: Log and send pending message for all redirects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304931 (https://phabricator.wikimedia.org/T141654) [21:37:13] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 5 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500284 (awight) FWIW, I've deployed this c... [21:37:37] (CR) jenkins-bot: [V: -1] Log and send pending message for all redirects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304931 (https://phabricator.wikimedia.org/T141654) (owner: Ejegg) [21:39:18] Fundraising Sprint Octopus Untangling, Fundraising-Backlog: Epic: Create frack vm cluster - https://phabricator.wikimedia.org/T142533#2555315 (cwdent) [21:46:20] (PS2) Ejegg: Log and send pending message for all redirects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304931 (https://phabricator.wikimedia.org/T141654) [21:48:34] (PS2) Ejegg: Paypal: set order ID = ct_id, email is an optional key [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304930 (https://phabricator.wikimedia.org/T141654) [21:49:58] (PS3) Ejegg: Log and send pending message for all redirects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304931 (https://phabricator.wikimedia.org/T141654) [21:52:26] gotta relocate, back soon! [22:15:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#2555439 (DStrine) [22:19:14] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304285 (owner: Ejegg) [22:21:26] (CR) Ejegg: "should the inner select have an 'order by id asc' ?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) (owner: Eileen) [22:23:34] (PS3) Eileen: Fix criteria range selection on dedupe. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) [22:24:26] (CR) Eileen: "pretty sure it does that anyway - (since its the autoincrement key) but no harm making it explicit - amended" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) (owner: Eileen) [22:27:28] dstrine: re the dashlets - I'm just wondering what to do with the ticket from a phab point of view - we should probably wait to deploy until the 4.7.11 release (which they are part of) is settled - it's due for deploy on 6 Sep [22:28:56] so should I push the phab ticket https://phabricator.wikimedia.org/T142051 through to done & we can open another to deploy 4.7.11 which will be in the sprint that covers the start of Sep? [22:32:08] (CR) Ejegg: "Local smoke tests are looking good! Holding off merge till we want to deploy and watch the recurring job" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [22:34:15] eileen: If 4.7.11 goes out on september 6th, does that mean it will take longer for our prod to be in sync? how much hassle would it take to get it on prod before september 6th? [22:35:08] (CR) Ejegg: [C: 2] Fix criteria range selection on dedupe. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) (owner: Eileen) [22:38:12] (Merged) jenkins-bot: Fix criteria range selection on dedupe. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/304926 (https://phabricator.wikimedia.org/T142954) (owner: Eileen) [22:39:15] dstrine: I can push it out prior to Sep 6th - I'm just not sure about pushing out more than say 7-10 days earlier since the release goes into change freeze around the 24th [22:49:35] fr-tech: for https://collab.wikimedia.org/wiki/Draft:Fundraising_Interaction_and_Activity_Diagrams, I think the components need to be divided into two types: codebases and applications [22:49:53] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/304937 [22:50:21] What interacts for queues and anything else is applications. The codebases, on the other hand, combine in different ways to provide a bunch of different applications [22:50:28] AndyRussG: Huh. Because an application might involve multiple codebases, and vice-versa? [22:51:10] Sure, that makes sense. But code base is sort of the least important category, in some ways [22:51:11] Yeah [22:51:30] But the codebase is where we write stuff and that's how we think of it [22:51:55] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [22:52:29] But we need for every codebase we need to be aware of the different ways it's exposed, the different contexts (server, network, application environment) contexts in which it's run [22:53:12] awight: ejegg are the commits in this ready for deployment https://gerrit.wikimedia.org/r/#/c/304937/ [22:53:22] AndyRussG: cool. These are all problems we have ta'en too little care of. [22:53:33] yep, all good eileen [22:53:34] Take physic, pomp, expose thyself to feel what wretches feel [22:54:59] Yeah it's just a confusion I've come across in trying to describe the components [22:55:33] Yeah, and then "listeners" or "audit processors" actually refers to a steaming mess of multiple components in multiple codebases. [22:55:40] (CR) Eileen: [C: 2] "merge commit - self-approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/304937 (owner: Eileen) [23:06:25] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/304937 (owner: Eileen) [23:12:37] !log upgrading CiviCRM from cad2c59081e53b877f51be4c853f307f3c4d4949 to 1d24161dd3f0f3ad64c0bf77f06022f30a2b3f2f [23:12:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:28:51] Fundraising-Backlog: SSL Cert for Danny Kaufman - https://phabricator.wikimedia.org/T143069#2555798 (CaitVirtue) [23:29:04] Fundraising-Backlog: SSL Cert for Danny Kaufman - https://phabricator.wikimedia.org/T143069#2555810 (CaitVirtue) p:Triage>High [23:39:03] XenoRyet: How's your iframe issue going? I was about to take a look at the PayPal listener rewrite, but it would be great to get more people into that codebase if you're still interested. [23:39:34] There might even be a nice way to divide up the work, like I make changes to the base classes to support the listener workflow that seems right to you. [23:41:14] Almost done, found one little thing that made me change the way I wanted to handle it, but back to testing now. I definitely want to get into the PayPal listener, but I've gotta go pick up the boy from school in like 10 mins. [23:41:21] Talk about it at Tech-talk in the morning? [23:41:27] perfect [23:41:29] Fundraising-Backlog: Is payments_initial missing Ingenico transactions? - https://phabricator.wikimedia.org/T142873#2549542 (Ejegg) I think the orphan rectifier is missing queue settings for payments-initial [23:41:44] Cool, I'll see you then. [23:44:52] ejegg|away: wow, good find! [23:46:06] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Epic: Epic: Create frack vm cluster - https://phabricator.wikimedia.org/T142533#2555832 (Danny_B) [23:49:41] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-ActiveMQ, FR-PayPal-ExpressCheckout, and 4 others: Move legacy PayPal listener to SmashPig - https://phabricator.wikimedia.org/T141654#2555836 (awight) a:Ejegg>None [23:51:57] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Continuous-Integration-Config, and 3 others: Continuous integration: DonationInterface needs composer variant - https://phabricator.wikimedia.org/T141309#2493985 (awight) [23:56:56] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-Paypal, FR-WMF-Audit, Unplanned-Sprint-Work: PayPal audit date format changed? - https://phabricator.wikimedia.org/T142417#2555865 (awight) a:awight