[14:41:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Prevent bad Cyrillic encoding - https://phabricator.wikimedia.org/T140564#2571602 (Aklapper) p:Unbreak!>High No reply to previous message, hence lowering priority. [14:57:26] (Abandoned) BBlack: CN: use cookie exclusively for GeoIP data [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/305423 (https://phabricator.wikimedia.org/T143271) (owner: BBlack) [15:11:36] Fundraising-Backlog, Epic, Tracking: [EPIC] Fix and improve geolocation, and ensure it's working properly for FR campaigns - https://phabricator.wikimedia.org/T121937#2571688 (BBlack) [15:11:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [EPIC] GeoIP lookup for IPv6 connections delays banner loading - https://phabricator.wikimedia.org/T121925#2571689 (BBlack) [15:11:44] Fundraising-Backlog, Operations, Traffic, Patch-For-Review: Switch Varnish's GeoIP code to libmaxminddb/GeoIP2 - https://phabricator.wikimedia.org/T99226#2571684 (BBlack) Open>Resolved a:BBlack [16:51:14] (PS1) Ejegg: Damaged message db shouldn't reject messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306014 (https://phabricator.wikimedia.org/T142028) [17:07:09] (PS2) Ejegg: WIP damaged message table UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305744 (https://phabricator.wikimedia.org/T142058) [17:15:37] (PS2) Ejegg: Damaged message db shouldn't reject messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306014 (https://phabricator.wikimedia.org/T142028) [17:17:25] hi awight ! [17:17:47] and happy Monday fr-tech [17:18:16] * cwd yaaaawns [17:18:42] hehe [17:18:55] * awight mumbles some embarrassment over the arrival time [17:20:12] i am probably going to be doing some starting of the day with techtalk and working a little later [17:20:36] have about 2 million urgent projects with the studio including a badly leaking roof [17:20:48] couple hours in the morning can be a big help [17:21:43] today however i have 1on1 w/ k4 in a few minutes [17:22:00] ah, word [17:23:58] dang, too bad [17:24:07] maybe a late chat after tha? [17:24:09] t [17:24:56] sure will hop on [17:25:29] I'll snag a call room for 20 min from now [17:26:26] I have various Bart excuses ;) you don't want to hear them [17:26:32] it's the worst. [17:30:07] (PS3) Ejegg: WIP damaged message table UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305744 (https://phabricator.wikimedia.org/T142058) [17:46:23] I'm in fr-tech-talk chat if anybody wants to join! [17:50:51] ejegg: hey! K going in a sec [17:50:56] morning all, btw :) [17:51:03] acutally 2 min [17:53:38] Rrrg looking for headphones [17:55:28] ejegg: did the hangout change? [17:55:55] awight: https://hangouts.google.com/hangouts/_/wikimedia.org/cdentinger-fr-t [17:56:15] I'm the first one? [17:56:25] hmm, lemme try again [17:57:06] I've got my 1 on 1 with K4 right now, so don't wait on me. [18:06:24] XenoRyet: ejegg awight cwd AndyRussG I just noticed that the fundraising board is disabled does anyone know if it has been this way for a while? [18:17:38] NM I fixed it [18:31:33] oops, hung up a hair more abruptly than intended [18:32:50] awight: no worries, didn't seem abruprt here [19:12:35] vboxnet0 consistently uses 4-5 watts, even when vms are shut down [19:13:10] between 10 and 100x more than the wireless radio [19:13:21] for a virtual interface [19:13:38] really makes me wonder what's happening inside the computer [19:13:56] whoa, that seems really high [19:14:04] checking on my machine [19:14:29] maybe it's serving itself ad impressions [19:14:52] the ad network singularity looms [19:15:50] I'm seeing 100 mW on vboxnet0 with nothing active [19:17:11] sounds more reasonable [19:17:46] i brought the interface down and back up and it seems better [19:18:29] weird stuff [19:21:04] (PS1) Awight: Update composer libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/306039 [19:21:35] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/306040 [19:24:57] (CR) jenkins-bot: [V: -1] Update composer libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/306039 (owner: Awight) [19:41:30] ejegg: Hey, what did you do to fix the polyfill? [19:41:57] just removed jenkins and forced it [19:42:07] aww man [19:42:45] we'll have to do that forever, then [19:43:08] well, only when those files change [19:45:48] Fundraising-Backlog, Continuous-Integration-Config: symfony-polyfill54 is breaking CI - https://phabricator.wikimedia.org/T143598#2573044 (awight) [19:45:58] Fundraising-Backlog, Continuous-Integration-Config: symfony-polyfill54 is breaking CI - https://phabricator.wikimedia.org/T143598#2573056 (awight) p:Triage>High [19:47:05] (PS4) Ejegg: WIP damaged message table UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305744 (https://phabricator.wikimedia.org/T142058) [19:59:04] (CR) Awight: [C: 2 V: 2] Update composer libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/306039 (owner: Awight) [20:07:16] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/306040 (owner: Awight) [20:07:41] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/306040 (owner: Awight) [20:29:07] !log update CRM from a30fc0aa2c2dc3a7a9a0b09bef19d112bdf5f98e to 43cca607ed0d6d2f91e3f18d9df1473021b40f88 [20:29:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:30:11] (PS5) Ejegg: WIP damaged message table UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305744 (https://phabricator.wikimedia.org/T142058) [20:35:41] dag. The recurring Ingenico job won't call DonationInterfaceFactory unless there are charges ready to go out... [20:41:17] ejegg: I think I might have that spare task slot available... [20:41:22] What were you looking for? [20:42:05] wanted to talk out the 'switch over main donations queue' task [20:42:12] can do [20:42:24] here? or voice call? [20:42:36] but am in 1:1 just now [20:42:39] k [20:43:19] We should also get the experience of migrating any other queue so we learn about things like intermittent Redis failure, etc. [20:44:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lots of database timeouts - https://phabricator.wikimedia.org/T143606#2573257 (awight) [20:49:51] I think I'm ready to try the new orphan rectifier. [20:54:35] nice! [20:59:31] aww okay not ready. 300708 [20:59:39] https://gerrit.wikimedia.org/r/#/c/300708/ [20:59:47] (PS16) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [21:31:13] fr-tech sorry I had to take that call during the meeting!! [21:42:37] adamw_: should the listener push the ipn messages to redis? [21:42:50] the Listener class i mean [21:43:48] for sure. it pushes to the job queue in stage 1, and other queues in stage 2 [21:44:31] that's what i figured but it makes it hard to test unless you also pass it a queue connector or some such [21:44:41] how to tell it to write to the mock queue [21:50:17] exactly [21:50:21] I can do that stuff [21:50:26] 4 u i mean [21:51:29] it should get passed a queue? [21:51:41] The way to do it in those tests is to set up the config*.yaml to have the specific queues point to the mock or sqlite [21:52:51] ah gotcha [21:57:32] adamw_: wait, but the tests require the test configuration [21:57:53] That's set up in the test constructor, I believe [21:58:19] (PS17) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [21:58:33] back in a bit [22:43:33] (PS2) Cdentinger: WIP working on paypal listener, tests pass [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 [22:54:01] (PS3) Eileen: Mirror queue messages from wmf_audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305677 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg) [22:54:03] (PS1) Eileen: [WIP] attempt test for mirror queue change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306069 (https://phabricator.wikimedia.org/T141484) [22:57:06] (CR) jenkins-bot: [V: -1] [WIP] attempt test for mirror queue change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306069 (https://phabricator.wikimedia.org/T141484) (owner: Eileen) [22:59:29] (PS4) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) [23:00:22] ejegg: I was trying to see if I could run through that mirror change in a test - you can see if pushed up here https://gerrit.wikimedia.org/r/#/c/306069/1/sites/all/modules/wmf_audit/tests/WmfAuditTest.php - I think locally I need to add the refund-new to a yaml? [23:00:55] I see [23:00:57] refund: [23:00:57] class: SmashPig\Core\DataStores\MultiQueueWriter [23:00:57] inst-args: [23:00:57] - [23:00:57] - refund-stomp [23:01:09] but it's trying to get refund-new.... [23:01:23] eileen: we've got testing-specific config files for some things [23:01:43] lemme find an example [23:01:47] (by mirror change I mean … https://gerrit.wikimedia.org/r/#/c/305677/2 ) [23:02:37] so, AmazonAuditTest creates its own SmashPig config in setUp [23:03:22] and you can load a different yaml file if you want [23:03:46] yep - but it merges with the default yaml doesn't it? [23:04:09] yeah, it does [23:04:38] where is the class for 'negative' => 'data-store/refund-new', [23:04:39] defined though - [23:04:59] I guess it's not in any yaml yet [23:05:13] ah so that change is dependent on a yaml change? [23:05:42] I should add it to the SmashPig defaults! [23:06:02] & then that would need to be merged first I expect? [23:06:40] well, you'd want to override it with a fake backend like phpQueue\PDO with an in-memory db [23:08:09] So you can follow the example of SmashPig's Tests/data/config_queue.yaml in a yaml file inside the crm repo [23:08:40] then in setUp, $config= new Configuration( 'default', 'path/to/config.yaml' ) [23:09:36] That's all for local setup isn't it? How does it get defined for live? [23:10:20] ohh, I remember why I didn't add it to the defaults -- I wanted to make it possible to have no entry in the /etc file and have it not do the mirroring [23:10:46] on live we'd add that entry to /etc/fundraising/SmashPig.yaml [23:11:24] ok - is that done - or still to do when preparing to deploy? [23:12:53] we'd do it after deploying the code, I think, so we could turn it on and off [23:15:34] OK so if I look at it that way the issue is that nothing should change unless it's configured - yet the exception being thrown is not of the type being caught [23:16:15] however, locally it is [23:16:29] no it's not [23:16:46] yes it is [23:16:54] It's failing on the next line - ie return $q->enqueue(json_encode($body), $headers, $types[$type]); [23:17:41] So, I feel like I can say it's safe (even though I can't get my test to work without solving that second issue) [23:17:55] but, if it were configured what class would refund-new point to? [23:20:09] Ohhh.... that's the old stomp queue. Yeah, that test is going to have to wait till the stomp connection goes away [23:20:53] refund-new would look something like this for testing: https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/5e77ccca8e4d24fddb8bbd06d30afa6b35d9f234/Tests/data/config_queue.yaml [23:21:18] the 'test' datastore