[00:10:49] <grrrit-wm>	 (CR) Eileen: [C: 2] "I looked through this code and attempted to test it through a unit test. I was only partially successful. I learnt a bit about the config " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305677 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[00:14:09] <grrrit-wm>	 (Merged) jenkins-bot: Mirror queue messages from wmf_audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305677 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[00:45:37] <awight>	 fr-tech: I need to deploy some non-trivial config, review would be much appreciated!  It's in the config deployment repo, in branch "awight-orphanage".
[00:47:33] <awight>	 Not a rush though, there's still https://gerrit.wikimedia.org/r/#/c/300708/ before I'm blocked on the new config.
[00:47:36] * AndyRussG doesn't have good enuf knowledge for such review
[00:49:37] <grrrit-wm>	 (PS18) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487)
[00:50:21] <awight>	 AndyRussG:  It's trivial anyway, no worries if it takes a few days.
[00:51:25] <wikibugs>	 Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 7 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2574111 (awight) Have some stuff for...
[00:57:55] <AndyRussG>	 aaaaarg!
[00:58:37] <awight>	 No no!  Recursive ARG
[00:58:42] <awight>	 oh noes
[01:01:00] <AndyRussG>	 graaaaaaarg
[01:02:50] <grrrit-wm>	 (PS9) Awight: Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[01:04:45] <grrrit-wm>	 (CR) Awight: [C: -1] "This needs tests..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[01:09:22] <grrrit-wm>	 (CR) Awight: "Minor and late questions" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305677 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[01:11:07] <cwd|afk>	 awight: taking a look...
[01:11:36] <awight>	 cwd: thanks!  I'm biking to the train in a few, probably offline until later tonight.
[01:11:41] <awight>	 so no rush :)
[01:11:55] <cwd>	 groovy
[01:12:00] <cwd>	 i miss biking
[01:12:14] <awight>	 motorcyle too, I bet
[01:12:33] <cwd>	 yeah these days i am all 0 or 4 wheels
[01:12:55] <AndyRussG>	 Heh I'm gonna miss that toooo
[01:13:01] <awight>	 "two wheels good; zero or four wheels bad."
[01:13:45] <cwd>	 3 wheels?
[01:13:55] <cwd>	 http://i.ebayimg.com/00/s/Mzc1WDUwMA==/z/W8MAAOxyBjBTVhbK/$_3.JPG?set_id=2
[01:13:56] * awight calls the cleanser
[01:13:59] <cwd>	 rollover likely
[01:14:20] <awight>	 Good for kids!
[01:14:47] <awight>	 see ya
[01:14:53] <cwd>	 later!
[01:17:34] <cwd>	 AndyRussG: guessing la bicicleta is peligro in ciudad mexico
[01:23:26] <AndyRussG>	 cwd: yeah... I mean, some people do it, years ago I tried riding 45 min to work every day, but it's not worth the risk, and you end up breathing a lot of exhaust
[01:23:53] <AndyRussG>	 Some parts of town have bike paths...
[01:25:42] <grrrit-wm>	 (CR) Eileen: [C: 1] "Looks fine - I've shied off +2 because awight spotted things I missed on the last one" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305674 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[01:56:41] <grrrit-wm>	 (PS1) Ejegg: SECURITY: Check read permission when loading page content in ApiParse. [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306124 (https://phabricator.wikimedia.org/T115333)
[01:56:45] <grrrit-wm>	 (PS1) Ejegg: Make blocks log users out if $wgBlockDisablesLogin [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306125 (https://phabricator.wikimedia.org/T129738)
[01:56:49] <grrrit-wm>	 (PS1) Ejegg: SECURITY: Make $wgBlockDisablesLogin also restrict logged in permissions [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306126 (https://phabricator.wikimedia.org/T129738)
[01:56:53] <grrrit-wm>	 (PS1) Ejegg: Require login to preview user CSS pages [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306127 (https://phabricator.wikimedia.org/T133147)
[01:56:57] <grrrit-wm>	 (PS1) Ejegg: Escape '<' and ']]>' in inline <style> blocks [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306128 (https://phabricator.wikimedia.org/T133147)
[01:57:01] <grrrit-wm>	 (PS1) Ejegg: SECURITY: XSS in unclosed internal links [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306129 (https://phabricator.wikimedia.org/T137264)
[01:57:05] <grrrit-wm>	 (PS1) Ejegg: SECURITY: API: Generate head items in the context of the given title [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306130 (https://phabricator.wikimedia.org/T139565)
[01:57:09] <grrrit-wm>	 (PS1) Ejegg: Do not allow undeleting a revdel'd file if its top file [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306131 (https://phabricator.wikimedia.org/T132926)
[01:57:13] <grrrit-wm>	 (PS1) Ejegg: SECURITY: Move 'UserGetRights' call before application of Session::getAllowedUserRights() [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306132 (https://phabricator.wikimedia.org/T139670)
[01:59:12] <grrrit-wm>	 (CR) Ejegg: [C: 2] SECURITY: Check read permission when loading page content in ApiParse. [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306124 (https://phabricator.wikimedia.org/T115333) (owner: Ejegg)
[01:59:25] <grrrit-wm>	 (CR) Ejegg: [C: 2] Make blocks log users out if $wgBlockDisablesLogin [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306125 (https://phabricator.wikimedia.org/T129738) (owner: Ejegg)
[01:59:32] <grrrit-wm>	 (CR) Ejegg: [C: 2] SECURITY: Make $wgBlockDisablesLogin also restrict logged in permissions [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306126 (https://phabricator.wikimedia.org/T129738) (owner: Ejegg)
[01:59:42] <grrrit-wm>	 (CR) Ejegg: [C: 2] Require login to preview user CSS pages [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306127 (https://phabricator.wikimedia.org/T133147) (owner: Ejegg)
[01:59:48] <grrrit-wm>	 (CR) Ejegg: [C: 2] Escape '<' and ']]>' in inline <style> blocks [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306128 (https://phabricator.wikimedia.org/T133147) (owner: Ejegg)
[01:59:54] <grrrit-wm>	 (CR) Ejegg: [C: 2] SECURITY: XSS in unclosed internal links [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306129 (https://phabricator.wikimedia.org/T137264) (owner: Ejegg)
[02:00:01] <grrrit-wm>	 (CR) Ejegg: [C: 2] SECURITY: API: Generate head items in the context of the given title [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306130 (https://phabricator.wikimedia.org/T139565) (owner: Ejegg)
[02:00:07] <grrrit-wm>	 (CR) Ejegg: [C: 2] Do not allow undeleting a revdel'd file if its top file [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306131 (https://phabricator.wikimedia.org/T132926) (owner: Ejegg)
[02:00:15] <grrrit-wm>	 (CR) Ejegg: [C: 2] SECURITY: Move 'UserGetRights' call before application of Session::getAllowedUserRights() [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306132 (https://phabricator.wikimedia.org/T139670) (owner: Ejegg)
[02:13:18] <AndyRussG>	 ejegg|afk: that was a quick non-afk stint!
[02:13:44] <AndyRussG>	 Quick question if anyone's around... In DI where is it determined which queue backend is written to?
[02:14:48] <ejegg|afk>	 i think the donationqueue newBackend method
[02:15:02] <ejegg|afk>	 reads from some globals
[02:29:04] <AndyRussG>	 ejegg|afk: ah cool thx! hmm it can do both backends at once?
[02:32:47] <grrrit-wm>	 (Merged) jenkins-bot: SECURITY: Check read permission when loading page content in ApiParse. [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306124 (https://phabricator.wikimedia.org/T115333) (owner: Ejegg)
[02:33:41] <grrrit-wm>	 (Merged) jenkins-bot: Make blocks log users out if $wgBlockDisablesLogin [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306125 (https://phabricator.wikimedia.org/T129738) (owner: Ejegg)
[02:35:15] <grrrit-wm>	 (Merged) jenkins-bot: SECURITY: Make $wgBlockDisablesLogin also restrict logged in permissions [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306126 (https://phabricator.wikimedia.org/T129738) (owner: Ejegg)
[02:38:01] <grrrit-wm>	 (Merged) jenkins-bot: Require login to preview user CSS pages [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306127 (https://phabricator.wikimedia.org/T133147) (owner: Ejegg)
[02:39:03] <ejegg>	 c'mon zuul, you can do it!
[02:39:41] <grrrit-wm>	 (Merged) jenkins-bot: Escape '<' and ']]>' in inline <style> blocks [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306128 (https://phabricator.wikimedia.org/T133147) (owner: Ejegg)
[02:41:45] <grrrit-wm>	 (Merged) jenkins-bot: SECURITY: XSS in unclosed internal links [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306129 (https://phabricator.wikimedia.org/T137264) (owner: Ejegg)
[02:43:16] <grrrit-wm>	 (CR) Ejegg: "sure does need tests awight. Smashpig commit I49b15430c3a2bebec would be handy to write those!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[02:45:24] <grrrit-wm>	 (Merged) jenkins-bot: SECURITY: API: Generate head items in the context of the given title [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306130 (https://phabricator.wikimedia.org/T139565) (owner: Ejegg)
[02:46:59] <grrrit-wm>	 (Merged) jenkins-bot: Do not allow undeleting a revdel'd file if its top file [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306131 (https://phabricator.wikimedia.org/T132926) (owner: Ejegg)
[02:49:17] <grrrit-wm>	 (Merged) jenkins-bot: SECURITY: Move 'UserGetRights' call before application of Session::getAllowedUserRights() [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/306132 (https://phabricator.wikimedia.org/T139670) (owner: Ejegg)
[02:50:45] <grrrit-wm>	 (PS6) Ejegg: WIP damaged message table UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305744 (https://phabricator.wikimedia.org/T142058)
[03:07:43] <ejegg>	 !log updated payments-wiki from 2b027e313ccecc2b93f214a94738b4f94899f347 to a472ff0a8c62f697221d71647f4013e5c2dfcd45
[03:07:48] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[05:49:22] <grrrit-wm>	 (PS1) Krinkle: modules: Remove use of deprecated getModifiedTime() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151
[07:03:10] <wikibugs>	 Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#2574556 (Eile...
[07:55:39] <grrrit-wm>	 (CR) Awight: [C: 2] "Much yummier!" (8 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305568 (owner: Ejegg)
[07:58:06] <grrrit-wm>	 (CR) Awight: [C: 2] Damaged messages: store trace separate from message [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305742 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg)
[08:00:57] <grrrit-wm>	 (CR) Awight: [C: 2] Damaged message db shouldn't reject messages (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306014 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg)
[08:07:38] <grrrit-wm>	 (Merged) jenkins-bot: Base class for dbs, they can create tables [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305568 (owner: Ejegg)
[08:07:40] <grrrit-wm>	 (Merged) jenkins-bot: Damaged messages: store trace separate from message [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305742 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg)
[08:07:42] <grrrit-wm>	 (Merged) jenkins-bot: Damaged message db shouldn't reject messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306014 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg)
[08:12:06] <grrrit-wm>	 (CR) Awight: [C: 2] Check for duplicates before re-queueing MISSING_PREDECESSOR (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305577 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[08:20:18] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] modules: Remove use of deprecated getModifiedTime() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151 (owner: Krinkle)
[08:41:03] <grrrit-wm>	 (CR) Awight: [C: 2] Mirror messages to new queues in GC audit (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305674 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[08:45:22] <grrrit-wm>	 (PS2) Krinkle: modules: Remove use of deprecated getModifiedTime() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151
[08:45:39] <grrrit-wm>	 (CR) Awight: "PS 2: missing brace." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151 (owner: Krinkle)
[08:47:20] <grrrit-wm>	 (CR) Awight: [C: 2] "Thanks for the explanation, and for helping to make our code more courteous!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151 (owner: Krinkle)
[08:47:36] <grrrit-wm>	 (Merged) jenkins-bot: Mirror messages to new queues in GC audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305674 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[08:49:25] <grrrit-wm>	 (Merged) jenkins-bot: modules: Remove use of deprecated getModifiedTime() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151 (owner: Krinkle)
[08:51:28] <grrrit-wm>	 (CR) Awight: "Also, confirmed that mw-core#fundraising/REL1_27 supports enableModuleContentVersion." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306151 (owner: Krinkle)
[08:56:47] <grrrit-wm>	 (CR) Awight: More efficient old custom value lookup (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283513 (owner: Ejegg)
[09:12:49] <wikibugs>	 Fundraising-Backlog, FR-Smashpig, Librarization, MediaWiki-extensions-DonationInterface: Spike: Discuss Packagist auto-update for DI and SP - https://phabricator.wikimedia.org/T143647#2574720 (awight)
[09:23:23] <grrrit-wm>	 (PS1) Awight: Minor cleanup using override() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306166
[10:02:35] <grrrit-wm>	 (PS2) Awight: [WIP] attempt test for mirror queue change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306069 (https://phabricator.wikimedia.org/T141484) (owner: Eileen)
[10:04:13] <grrrit-wm>	 (CR) Awight: "I added the SmashPig config pixie dust, but we're blocked by the untestable legacy Stomp queue now." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306069 (https://phabricator.wikimedia.org/T141484) (owner: Eileen)
[10:05:54] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] [WIP] attempt test for mirror queue change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306069 (https://phabricator.wikimedia.org/T141484) (owner: Eileen)
[15:36:29] <wikibugs>	 Fundraising Sprint Pretending This Isn't Happening, MediaWiki-extensions-CentralNotice, Operations, Traffic, and 2 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2575919 (awight) p:Low>Unbreak!
[15:54:07] <grrrit-wm>	 (CR) Ejegg: Damaged message db shouldn't reject messages (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306014 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg)
[16:01:15] <grrrit-wm>	 (CR) Ejegg: Base class for dbs, they can create tables (4 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305568 (owner: Ejegg)
[16:06:16] <grrrit-wm>	 (CR) Ejegg: Mirror messages to new queues in GC audit (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305674 (https://phabricator.wikimedia.org/T141484) (owner: Ejegg)
[16:07:25] <grrrit-wm>	 (PS5) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273)
[16:09:17] <grrrit-wm>	 (CR) Awight: Base class for dbs, they can create tables (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305568 (owner: Ejegg)
[16:10:27] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg)
[16:27:08] <wikibugs>	 Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2576065 (awight) Adding #fundraising-backlog so t...
[16:30:20] <grrrit-wm>	 (PS10) Ejegg: Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641)
[16:30:22] <grrrit-wm>	 (PS1) Ejegg: Fix bug re-activating utm_campaign entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306239
[16:31:05] <grrrit-wm>	 (Abandoned) Ejegg: WIP tests for combining pending DB info [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300584 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[16:31:53] <ejegg>	 fr-tech not sure, but I might have stumbled on one of the things giving us pain with utm_campaign entries: https://gerrit.wikimedia.org/r/306239
[16:34:18] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[16:35:30] <ejegg>	 broke all the merge tests??
[16:35:51] <ejegg>	 heh, bet it's contact info collisions.  Need random-er test data?
[16:55:45] <ejegg>	 can't run the merge tests locally, need a civi db with less data :)
[17:02:41] <grrrit-wm>	 (PS11) Ejegg: Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641)
[17:03:57] <ejegg>	 snagging a call room in case of fr-tech-talk...
[17:04:21] <wikibugs>	 Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2576231 (Pcoombe) Results from the first test are here: https://www.mediawiki.org/wiki/Extension:Popups/...
[17:04:22] <awight>	 sounds good.  I wouldn't mind chatting
[17:04:35] <cwd>	 i'll hop on shortly
[17:04:49] <cwd>	 would like to hear more about this geoip thing...
[17:05:56] <awight>	 the-wub: Looks like the summary line in "small banners" is backwards--hovercards damaged performance in that case, not improved, right?
[17:13:54] <the-wub>	 awight: it was an improvement in donations/impression. so the net result is that counteracts the impressions decrease
[17:13:57] <the-wub>	 feel free to edit for clarity though!
[17:14:33] <awight>	 the-wub: ah gotcha, thanks
[17:14:59] <awight>	 Great news!
[17:38:34] <grrrit-wm>	 (PS6) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273)
[17:39:59] <grrrit-wm>	 (PS3) Cdentinger: WIP working on paypal listener, tests pass [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654)
[17:41:33] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg)
[17:59:24] <awight>	 LOL, PHP thought leaders
[18:04:06] <cwd>	 https://twitter.com/php_ceo
[18:07:19] * awight anticipates the music video
[18:08:35] <grrrit-wm>	 (PS7) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273)
[18:09:24] <awight>	 Is it me, or did the Gerrit emails somehow become even more inane
[18:13:25] <cwd>	 you mean how it put the repo name at the beginning so the subject line is useless on small screens?
[18:13:36] <awight>	 yah
[18:13:49] <awight>	 Would you like 4 characters of TF is actually happening here?
[18:14:00] <cwd>	 yeah
[18:14:03] <cwd>	 annoying
[18:14:32] <awight>	 I suspect they're issued 36" monitors at g$$gle
[18:16:08] <grrrit-wm>	 (PS8) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273)
[18:22:23] <grrrit-wm>	 (PS12) Ejegg: Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641)
[18:30:01] <grrrit-wm>	 (PS3) Ejegg: Move payments-init queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273)
[18:31:07] <wikibugs>	 Fundraising-Backlog, FR-Adyen: Adyen iframe workflow is unsupported - https://phabricator.wikimedia.org/T143714#2576686 (cwdent)
[18:46:01] <grrrit-wm>	 (CR) Awight: "Looks good--you should go ahead and squash!" (14 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger)
[18:47:00] <grrrit-wm>	 (PS4) Ejegg: Move payments-init queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273)
[18:53:05] <grrrit-wm>	 (PS5) Ejegg: Move payments-init queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273)
[19:00:31] <grrrit-wm>	 (CR) Ejegg: "Looks good, might want to qualify the comment on override() that says to only use it in tests" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306166 (owner: Awight)
[19:09:59] <grrrit-wm>	 (PS2) Awight: Minor cleanup using override() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306166
[19:14:55] <grrrit-wm>	 (CR) Cdentinger: "Thanks for the guidance! Will continue hacking." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger)
[19:18:01] <grrrit-wm>	 (CR) Ejegg: WIP working on paypal listener, tests pass (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger)
[19:22:38] <grrrit-wm>	 (PS4) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654)
[19:23:08] <cwd>	 thanks for the review!  just squashed those 3 ^
[19:24:35] <grrrit-wm>	 (CR) Ejegg: [C: -1] "Let's drop the (unused) gateway argument, since it's in a processor-specific module using a processor-specific class" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[19:27:20] <awight>	 cwd: cool.  I'll try to play with the tests in 30 min or so, and mock out the verification API call so we can test the unhappy path
[19:28:19] <grrrit-wm>	 (Abandoned) Ejegg: WIP PayPal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/304868 (owner: Ejegg)
[19:53:13] <wikibugs>	 Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, Patch-For-Review: Create UI for damaged message DB - https://phabricator.wikimedia.org/T142058#2577200 (Ejegg) a:Ejegg
[20:06:50] <awight>	 cwd: ejegg: The awight-orphanage config branch is ready for rereview, at your leisure...
[20:07:02] <cwd>	 cool, will check
[20:07:04] <ejegg>	 thanks!
[20:07:48] <grrrit-wm>	 (PS1) Awight: Give the orphan gateway its own globals prefix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306277 (https://phabricator.wikimedia.org/T131275)
[20:07:55] <awight>	 thank you!
[20:11:10] <grrrit-wm>	 (Abandoned) Awight: [WIP] Skeletal tests for both stages of the PayPal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305593 (https://phabricator.wikimedia.org/T141654) (owner: Awight)
[20:28:32] <grrrit-wm>	 (CR) Ejegg: [C: -1] "phooey, seems like there are a lot of settings we'd have to duplicate this way (URL, accountInfo, CvvMap, etc). Seems ugly, but maybe it w" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306277 (https://phabricator.wikimedia.org/T131275) (owner: Awight)
[20:29:58] <grrrit-wm>	 (CR) Awight: "Yeah... okay, now I'm thinking a better approach would be to make sure RGC never calls the hooks." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306277 (https://phabricator.wikimedia.org/T131275) (owner: Awight)
[21:31:03] <ejegg>	 going to relocate for standup
[21:46:32] <grrrit-wm>	 (Abandoned) Ejegg: Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) (owner: Ejegg)
[22:33:20] <eileen>	 ejegg: let me know if there are any more gerrits you think I should review… I did shy off merging the second one I looked at
[22:34:30] <ejegg>	 eileen: there are a few other queue consumer patches that could use scrutiny
[22:34:43] <ejegg>	 but we'd want to hold off merging those too
[22:35:47] <ejegg>	 this one is closest to deployable - just waiting till we test awight's orphan switchover : https://gerrit.wikimedia.org/r/299938
[22:36:20] <ejegg>	 then these three would come later: https://gerrit.wikimedia.org/r/301660 , https://gerrit.wikimedia.org/r/303316 , https://gerrit.wikimedia.org/r/303318
[22:38:35] <ejegg>	 maybe you have a good idea where we should be initializing the SmashPig context - in an _init hook?
[22:51:06] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872#2577802 (...
[23:10:03] <ejegg>	 gotta head out, but I'll check in later in case there's stuff to review!
[23:16:49] <dstrine>	 eileen:  do you know how many de-dupes per hour we are running at right now? It's ok if you don't know or if you have to take a wild guess
[23:19:11] <cwd>	 i'm going to get a little work done outside while the sun is shining but i'll be back on later as well
[23:21:25] <eileen>	 dstrine: We are running I think 500 contacts every 5 minutes & deduping any matches with them
[23:21:44] <eileen>	 I may be able to increase the rate a little
[23:22:24] <dstrine>	 so if MG saw like 1,000 dupes per day that wouldn't increase the script runtime that much right?
[23:23:12] <eileen>	 can you rephrase that?
[23:25:44] <spatton>	 Hey all! Quick note that we've got a Japan pre-test going live in 5 minutes.
[23:26:10] <dstrine>	 eileen you mentioned that running the MG script only took 10 minutes. If they get an increase in dupes of 500-1,000 dupes in a day, the script wouldn't take that much longer to run right?
[23:27:23] <eileen>	 dstrine: yeah - the thing I was kind of explaining is it starts from the last contact ID it got to & looks for contacts with a higher id that meet the criteria
[23:28:29] <dstrine>	 ok so it focuses more on the new transactions. That's what you're saying?
[23:29:26] <eileen>	 yes, but only if they meet the critieria - ie. if the new donor gave $400 if wouldn't pick them up - even if they had matches with existing major gifters
[23:30:01] <awight>	 spatton: Thanks!
[23:30:59] <awight>	 cwd|afk: fwiw, I still don't see the phpunit.xml changes--you know what happened with that squash?
[23:46:08] <dstrine>	 eileen:  ok thanks
[23:46:09] <wikibugs>	 Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 7 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2500303 (awight) One more important...
[23:46:27] <wikibugs>	 Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2577950 (JKatzWMF) @Pcoombe  This is perfect.  Thanks! @ovasileva check out above ^^
[23:48:49] <wikibugs>	 Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 7 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2577969 (awight) Let's just set $wgD...