[00:10:49] (CR) AndyRussG: "@Krinkle:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [00:13:28] gotta run! [00:24:32] (PS1) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [00:26:16] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [00:29:47] (CR) AndyRussG: GeoIP: Make background lookup optional and configurable (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [00:45:00] (PS1) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [00:46:46] (CR) jenkins-bot: [V: -1] Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [00:47:35] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 8 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2584763 (awight) Note: I was able to... [03:30:27] (PS4) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [03:31:28] (CR) AndyRussG: GeoIP: Make background lookup optional and configurable (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [03:34:47] (CR) jenkins-bot: [V: -1] GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [03:50:56] (PS5) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [03:52:33] (CR) jenkins-bot: [V: -1] GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [04:00:49] (PS6) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [04:03:23] (CR) jenkins-bot: [V: -1] GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [04:10:06] Hi everyone, for the record: Japan pre-test ended 40 minutes ago, 8:30pm pacific. I'm out, see you later. [04:20:33] (PS7) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [04:21:16] (CR) Krinkle: GeoIP: Make background lookup optional and configurable (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [04:22:06] (CR) Krinkle: [C: -1] "'module', not 'modules'." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [04:22:08] (CR) jenkins-bot: [V: -1] GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [04:23:18] (PS8) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [04:29:03] (CR) AndyRussG: "/me flails about wildly while not bothering to even try running jshint locally..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [04:35:47] (PS9) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [08:13:03] (PS2) Awight: Configuration class can be reused for any search path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306596 [08:16:48] Fundraising-Backlog, DBA, Labs, MediaWiki-extensions-CentralNotice: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (AlexMonk-WMF) I suppose some views just need to be added to maintain-replicas for these [08:45:06] (PS1) Awight: Static interface to Configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306885 [08:45:08] (PS1) Awight: Clean up AdyenTestConfiguration interface [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306886 [12:03:17] Fundraising-Backlog, Wikimedia-Fundraising: Following link to donate fails to return user to previous page upon completion - https://phabricator.wikimedia.org/T60506#2585574 (Pcoombe) [15:23:41] (PS10) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [15:25:43] (CR) jenkins-bot: [V: -1] GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [15:31:09] (PS11) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [15:31:51] (PS12) AndyRussG: GeoIP: Make background lookup optional and configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [15:32:46] (CR) Nemo bis: GeoIP: Make background lookup optional and configurable (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [15:35:00] (CR) Nemo bis: GeoIP: Make background lookup optional and configurable (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [15:38:54] (CR) AndyRussG: "When a Gerrit change has many patch sets, it indicates arduous, careful work..." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [16:39:09] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2586527 (AndyRussG) Should we make a task for tal... [16:40:53] Seddon: hi! I added you on T143271, since there is some community outreach to be done, though I'm not sure if it's your area--it's to 3rd party users of mediawiki, who may need to update their configuration to continue to get geolocation. Thx in advance for any input!! [16:41:21] T143271: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271 [16:46:01] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2586538 (BBlack) Monday morning's fine. IIRC fro... [16:52:05] cwd: hi! is FundraisingEmailUnsubscribe a thing? I see both DonationEmailUnsubscribe and FundraisingEmailUnsubscribe hanging out in mediawiki-fr/extensions in the vagrant role... [16:52:18] XenoRyet: ^ [16:59:01] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2586632 (AndyRussG) >>! In T143271#2586538, @BBla... [17:03:51] hi AndyRussG [17:04:15] FundraisingEmailUnsubscribe is the current name [17:04:20] it's gone back and forth [17:04:53] fr-tech, I'm doing some moving now, but I'd like to have -talk in a bit (maybe an hour) if folks are free [17:05:52] ejegg|away: cool! So DonationEmailUnsubscribe isn't even installed on Payments wiki? [17:06:00] ejegg|away: yeah I'll be here at that time :) [17:08:39] yikes yeah adam was working on that recently [17:14:21] cwd: maybe they're both there then? [17:15:59] only one is the Official Thing and the other must be cruft [17:16:12] i'm spacing which is the desired one...phab should know [17:18:05] hmmm [17:18:11] fun times [17:20:00] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2586731 (BBlack) Relevant: https://wikiapiary.com... [17:21:54] AndyRussG: i think this is the one: https://phabricator.wikimedia.org/T141911 [17:26:01] Ah cool thx! [17:27:19] cwd: awight added a placeholder for FundraisingEmailUnsubscribe here: https://collab.wikimedia.org/wiki/Draft:Fundraising_Interaction_and_Activity_Diagrams [17:29:00] ooh, nice doc [17:30:44] cwd: heh thx! Just improved tentative names of stages at the bottom, a second ago [17:32:05] What are the various ways of arriving at a payments form presented (though not necessarily served) via Payments wiki? One is clicking on a banner, the others are... [17:33:24] fr-tech ^ (last question) [17:33:58] AndyRussG: there's a link on the left hand bar [17:34:06] for "spontaneous" donations [17:34:25] i believe there are also links in the mobile apps [17:35:13] cwd: cool! and... that's it? [17:35:25] hmm, i have heard of traffic from face book posts [17:35:30] Google searches? some other kind of landing pages? [17:35:58] AndyRussG: there are various ways a person could land on this page: https://wikimediafoundation.org/wiki/Ways_to_Give [17:36:08] i think a google search being one of them [17:36:23] but that will be the referrer to paymentswiki [17:38:59] K [17:39:14] The link on the left sidebar is to donate.wikimedia.org [17:39:22] Is that on the FR cluster or main cluster? [17:39:30] that is main cluster [17:39:38] interstitial step to pci scope [17:40:06] yeah the whole page is almost like what you see in a banner [17:40:18] so yeah i can't think of any legit ways to get to payments besides donatewiki and a banner [17:40:22] https://donate.wikimedia.org/wiki/Special:FundraiserRedirector?utm_source=donate&utm_medium=sidebar&utm_campaign=C13_en.wikipedia.org&uselang=en [17:40:25] and potentially the apps...not sure [17:40:33] K hmmm [17:40:46] What manages the SpecialFundraiserRedirector? [17:41:48] Seems it's even the only page you can get to on donate wiki [17:42:37] thx!! [17:42:49] if i browse to just donate it points me to FundraiserLandingPage [17:43:05] https://github.com/wikimedia/mediawiki-extensions-FundraiserLandingPage/blob/master/FundraiserRedirector.body.php [17:55:38] cool :) [18:01:49] fr-tech pls lmk if there's any techtalking... I'm just heating up some leftovers but can join anytime.. [18:03:13] yeah whenever works for ejegg|away works for me, there's a ticket we should probably talk about [18:03:49] i've poking around but guessing it will ring a bell with him right away [18:07:38] hi all [18:07:46] sorry for the delay! [18:07:58] what's the ticket cwd? [18:37:22] cwd: ejegg XenoRyet tell me if I'm crazy but we've never had an italian adyen form right? [18:37:45] I don't believe so, no. [18:37:52] * dstrine thinks that he may still be crazy but the other part of the question is still valid [18:38:00] XenoRyet: yeah cool thanks [18:38:03] Nope, it's not on the list [18:42:36] yeah cool. I wanted to make sure something didn't predate me or something [18:48:46] (PS1) Ejegg: Update SmashPig lib, use config shortcuts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306972 [19:40:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Send an Email feature in Civi sending wrong template - https://phabricator.wikimedia.org/T144049#2587251 (LeanneS) [19:44:52] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Goal: SPRINT O (8-3 to 8/17) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142039#2587264 (DStrine) Open>Resolved [19:49:42] XenoRyet: meeting? [19:49:50] Hangouts issue, brt [20:22:56] (PS2) Ejegg: Update SmashPig lib, use config shortcuts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306972 [20:26:34] (PS3) Ejegg: Use DeletePendingJob in frontend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306840 (https://phabricator.wikimedia.org/T143945) [20:30:02] fr-tech: I'm thinking we should use queue objects from SmashPig's config in DonationInterface to replace all the DonationQueue stuff [20:30:44] that patch starts using it for another thing - does anyone have time to take a look and see if it's the right approach? [20:37:43] ejegg: that seems like probably a good idea [20:37:57] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Delete from the pending database when a transaction is imported into the database - https://phabricator.wikimedia.org/T143942#2587438 (Ejegg) [20:37:59] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, Patch-For-Review: Donation import should merge and delete pending db info - https://phabricator.wikimedia.org/T141477#2587436 (Ejegg) [20:37:59] i have to make a home depot run now but imma work this evening, happy to take a look then [20:38:08] cool, thanks! [20:38:10] actually i'm going to lowe's these days [20:38:26] the home depot in longmont was great but the one here is worthless [20:39:14] not that lowe's is any better but it's more conveniently located [20:40:10] does lowe's have the special shitty editions of popular brand products too? [20:40:36] yeah it's literally teh same store with a different color scheme [20:40:48] weird that market forces allow for that [20:41:05] but all the knock off brands are different [20:41:16] so it's like bizarro home depot [20:41:36] ahh, i heard home depot had special versions made by the big brands just to sell cheaper in their chain [20:41:58] yeah definitely [20:42:06] like the levis at target [20:42:49] my uncle had a tv store in maine, he said walmart did the same and drove him out of business cause nobody could tell the difference till stuff broke a year in [20:43:08] now he works at a home depot :( [20:43:17] aw man [20:43:36] i blame advertising [20:43:46] anyway back in a bit! [20:58:19] Why does WMF wiki run ContribtionTracking? https://wikimediafoundation.org/wiki/Special:Version [20:58:47] Maybe something to do with the options on https://wikimediafoundation.org/wiki/Ways_to_Give ? [21:06:00] AndyRussG: I think that and Donatewiki originally created contribution tracking ids early in the process [21:06:26] but no longer. I'll put up a patch to disable it at least on wmf wiki [21:08:35] oho, maybe something is using wgContributionTrackingFundraiserMaintenance ? [22:03:11] fr-tech hi! anytime anyone would like to talk about this UML stuff, or would like to talk through other things, I'm here... Also later or another time is fine, I'm plugging away... [22:04:47] cool, i'm in https://hangouts.google.com/hangouts/_/wikimedia.org/fr-tech-talk [22:04:51] AndyRussG: ^ [22:05:00] also fr-tech ^ [22:06:22] hangout troubles again, one minute [22:08:27] (PS8) Ejegg: DO NOT MERGE: Quit deleting from pending queue, stop saying limbo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433) [22:09:26] https://collab.wikimedia.org/wiki/Draft:Fundraising_Interaction_and_Activity_Diagrams [22:13:12] (PS9) Ejegg: DO NOT MERGE: Clean up orphan rectifier, stop saying limbo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433) [22:15:07] http://www.uml-diagrams.org/sequence-diagrams-combined-fragment.html#operator-alt [23:02:21] hiya! yous guys still talking? [23:02:35] yep, come on in [23:02:48] we're in the tech talk hangout [23:14:47] (CR) Krinkle: GeoIP: Make background lookup optional and configurable (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG)