[14:41:07] (CR) Cdentinger: Move payments-init queue off ActiveMQ (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [14:54:41] cwd: hey! remember which patches ejegg|away said he was most interested in quick review on? Looking now at https://gerrit.wikimedia.org/r/#/c/306840/ [14:55:50] AndyRussG: hi! i remember this one and its predecessor being mentioned: https://gerrit.wikimedia.org/r/#/c/303318/5 [14:56:07] i gave them both some review but could certainly use your opinion too [14:58:09] hi cwd AndyRussG ! Thanks for looking at that stuff. I'm hoping to get the 'switch XX off ActiveMQ patches deployed today and tomorrow' [15:00:47] ejegg: cwd : cool thx! [15:00:55] Yeah sounds doable, I left some comments on those, pretty minor stuff though [15:01:24] And probably all stuff that is already in prod [15:01:25] cwd I think I'd like to address those in a follow on patch [15:01:46] This time around I'm trying to change as little as possible beyond the queue switch [15:02:00] Makes sense [15:02:18] so basically I'm looking for more help determining if there are any inadvertant changes in behavior [15:03:32] (CR) AndyRussG: Use DeletePendingJob in frontend (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306840 (https://phabricator.wikimedia.org/T143945) (owner: Ejegg) [15:04:05] Ah K good to know that's what to look out for :) [15:05:34] i've got to go take care of some stuff. back in an hour! [15:15:25] cwd: any idea why I'd have unstaged changes in my crm repo? I guess I'll just reset --hard or something [15:15:54] ~/Development/vagrant/srv/org.wikimedia.civicrm$ git status [15:15:55] On branch master [15:15:57] Your branch is behind 'origin/master' by 47 commits, and can be fast-forwarded. [15:16:00] (use "git pull" to update your local branch) [15:16:01] Changes not staged for commit: [15:16:04] (use "git add ..." to update what will be committed) [15:16:05] (use "git checkout -- ..." to discard changes in working directory) [15:16:07] modified: civicrm (new commits) [15:16:09] modified: composer.lock [15:16:11] Untracked files: [15:16:13] (use "git add ..." to include in what will be committed) [15:16:15] extensions/ [15:16:17] sites/default/civicrm-install.php [15:16:19] sites/default/drupal-install.sh [15:16:21] no changes added to commit (use "git add" and/or "git commit -a") [15:16:48] bye grrrit-wm! [15:17:55] hmm, not sure! [15:18:13] if you don't see anything important there you can just reset --hard origin master [15:18:32] i have to drive dani to an appointment, back soo0n! [15:52:39] Fundraising-Analysis, Analytics: FR tech hadoop onboarding {flea} - https://phabricator.wikimedia.org/T118613#2591373 (Milimetric) Open>Resolved a:Milimetric If any more support is needed, please open another task [17:07:21] fr-tech: -talk? [17:07:38] be there in a few [17:07:51] Yea, sure, give me a minute or two as well. [17:07:56] cool [17:37:56] ejegg: you're all silent + still image [17:38:20] sorry, looks like library wifi decided I was hogging too much bandwidth [17:38:28] tethering via phone... [17:38:47] Are we tech talking? [17:38:51] yep! [17:44:07] awight: new link https://hangouts.google.com/hangouts/_/wikimedia.org/fr-tech-talk [17:53:10] (CR) Awight: "Note from ejegg: file modification time needs to be revisited for globs." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306596 (owner: Awight) [18:08:29] (CR) Awight: GeoIP: Make background lookup optional and configurable (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [18:51:49] (CR) BBlack: GeoIP: Make background lookup optional and configurable (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [18:55:00] (CR) Ejegg: Use DeletePendingJob in frontend (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306840 (https://phabricator.wikimedia.org/T143945) (owner: Ejegg) [19:03:45] (CR) Ejegg: "Definitely some good points! I'll take a look at them in a future patch since they were all carried over from the existing code and I'd l" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [19:11:41] https://bosun.org/ [19:12:25] oh cool [19:12:29] know anyone using it? [19:12:55] nope, just heard of it [19:13:03] but it's an area that could use a killer app [19:13:07] yeah [19:13:31] Join us in our Slack room. [19:13:37] :| [19:13:58] i swear i'll set up matrix one of these days! [19:14:53] heh i lurk in our channel but it's crickets [19:15:09] i think yuvi got distracted [19:18:28] ejegg: Just checking: you want pending data to have lower precedence than data in the message having a completion_message_id? [19:19:39] (CR) Awight: Import info from pending DB, not AMQ (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [19:20:03] ejegg: ^ I think that's ready to go, just had the one question. [19:21:49] looking [19:27:28] (CR) Ejegg: [C: 2] Import info from pending DB, not AMQ (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [19:27:51] freaking +2 button next to reply button! [19:28:04] removed myself as reviewer, hope that's enough [19:32:23] (PS13) Ejegg: Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) [19:32:33] added a code comment with the reasoning awight [19:37:18] (PS9) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) [19:37:26] seems like there are 3 queues ready to go live, are we going to try one at a time? [19:38:16] (PS6) Ejegg: Move payments-init queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273) [19:55:02] (PS5) Ejegg: Stop using pending queue in RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) [19:55:04] (PS1) Ejegg: Stop using pending queue in ProcessCaptureRequestJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307359 (https://phabricator.wikimedia.org/T122641) [20:15:26] (CR) Awight: [C: 2] "Looks great!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [20:15:50] dstrine: hey I was going to come online for the civi meet up even though I'm mostly taking today off - but maybe we should fully reschedule if Rosie can't make it? [20:16:40] eileen: ah ok I was trying to figure out if you had today off [20:16:46] I can move this to wednesday [20:17:26] eileen: done! [20:18:39] (Merged) jenkins-bot: Import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [20:19:17] dstrine: cool thanks [20:26:20] Fundraising-Backlog: Civi email merge won't retain new email address - https://phabricator.wikimedia.org/T143236#2592711 (CCogdill_WMF) Kristie has found more cases of this, both with email address (CID 8374493) and mailing address (CID 15792153). For what it's worth, it seems like Civi is not automaticall... [20:32:18] cwd: Yeah that's the plan as I understand it [20:33:23] XenoRyet: quick question on adyen Amex. We resolved the issues and reinstated it for ukraine right? Did it get removed everywhere while working on it? [20:34:15] That sounds right from what I remember. Turned off everywhere while we worked on it, and reenabled afterwards. I think there were phab tasks for both. [20:34:16] I'm looking at all the links in this task: https://phabricator.wikimedia.org/T128812 [20:34:39] I'm looking at france and it looks like that didn't get reinstated [20:35:00] is the france link on that task correct? [20:35:26] Yea, looks like [20:35:38] Let me see if I can find that 'turn it back on' task. [20:35:44] ok cool. This was a fairly light weight change right? [20:35:54] Yea, super easy. [20:35:54] I can make another for france if that helps [20:38:04] We'll need to add that in the next sprint. Online will want to start testing france soon [20:38:16] should reopen that old task or make a new one? [20:38:50] Ok, yea. Looks like we turned off everywhere, but only turned back on for Israel and Ukraine. [20:39:10] So new card for France, and it'll be really easy to slot into the next sprint. [20:39:15] yeah this has more info on IL: https://phabricator.wikimedia.org/T137811 [20:39:20] ok thanks! [20:39:36] No worries [20:42:23] Fundraising-Backlog: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2592740 (DStrine) [20:42:35] Fundraising-Backlog, FR-Adyen: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2592752 (DStrine) [21:17:21] dstrine: did you know the original burning man was in santa fe? https://en.wikipedia.org/wiki/Zozobra [21:20:17] (CR) Ejegg: Check for duplicates before re-queueing MISSING_PREDECESSOR (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305577 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [21:20:32] cwd: people have been burning effigies forever. But the first "burning man" was a party on a beach in San Francisco in 1986 https://en.wikipedia.org/wiki/Burning_Man [21:24:01] heh fair enough [21:24:29] (PS1) Ejegg: Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 [21:24:50] (PS2) Ejegg: Check for duplicates before re-queueing MISSING_PREDECESSOR [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305577 (https://phabricator.wikimedia.org/T122641) [21:25:55] cwd: Nice gloombot! [21:26:09] This historical footnote is fun, too: https://en.wikipedia.org/wiki/The_Wicker_Man_%281973_film%29 [21:26:16] parthenogenesis... [21:26:59] nice movie [21:27:32] Be our guest [21:29:53] (CR) jenkins-bot: [V: -1] Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 (owner: Ejegg) [21:31:02] (PS2) Ejegg: Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 [21:34:53] (CR) jenkins-bot: [V: -1] Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 (owner: Ejegg) [21:38:22] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, FR-WMF-Audit, Unplanned-Sprint-Work: Adyen smashpig job runner failing - https://phabricator.wikimedia.org/T135803#2592942 (DStrine) [21:38:52] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: Setup Ukrainian forms for Adyen - https://phabricator.wikimedia.org/T135417#2592943 (DStrine) [21:39:04] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Setup Japanese form for Adyen - https://phabricator.wikimedia.org/T135418#2592944 (DStrine) [21:40:11] (PS3) Ejegg: Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 [21:40:23] (CR) jenkins-bot: [V: -1] Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 (owner: Ejegg) [21:40:41] (PS4) Ejegg: Refactor common duplicate-checking code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307427 [21:44:11] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 3 others: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#2592969 (DStrine) [21:44:32] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Israel and France 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2592971 (DStrine) [21:45:25] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, and 4 others: Adyen Hebrew UI bugs - https://phabricator.wikimedia.org/T135416#2592974 (DStrine) [21:46:02] Ping regarding https://phabricator.wikimedia.org/T72462 :) [21:51:30] (CR) Ejegg: "We're conditionally trusting the QS results in the pre_process, I think so that we can skip the GET_ORDERSTATUS call if the fraud checks a" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [21:51:54] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2592984 (DStrine) [21:53:33] Fundraising Sprint Muggle Baiting, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: Turn off AmEx for non-US Adyen forms - https://phabricator.wikimedia.org/T139796#2592990 (DStrine) [21:57:03] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307432 [21:57:27] (PS1) XenoRyet: Make Paypal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) [21:57:50] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307432 (owner: Ejegg) [21:58:18] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307432 (owner: Ejegg) [22:00:13] Fundraising-Backlog, FR-Amazon: Review Amazon settlement process & API - https://phabricator.wikimedia.org/T144241#2593024 (MBeat33) [22:00:21] Ah, good to see gerrit's stopped giving you the cold shoulder XenoRyet [22:00:23] Fundraising-Backlog, FR-Amazon: Review Amazon settlement process & API - https://phabricator.wikimedia.org/T144241#2593038 (MBeat33) p:Triage>Normal [22:00:34] Yea, right? [22:05:24] (CR) Ejegg: "Only question is if we're ok using 'donations' as the redis queue key, with no configurability. Maybe add a config.redis.queues and send t" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [22:24:17] (CR) Awight: "Solid start! Would you mind creating a requirements.txt, too? Doesn't have to capture all the other dependencies, just this new one." (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [22:33:52] fr-tech: I can't quite figure it out, on my laptop I get syslogging during DonationInterface unit tests, but not on my other box. Are there settings we tweak to get that? [22:34:36] (PS2) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [22:34:40] Hmmm I think I mighta seen something about that a while ago, don't remember really [22:34:41] seems like it would be a phpunit setting. different versions? [22:35:00] I tried wgDI..UseSyslog to no avail [22:35:13] That would be funky if it were intercepting syslog... [22:35:20] s/it/phpunit [22:35:39] Maybe some user permissions thing? [22:35:56] humm, maybe I just don't have the rsyslogd.conf set right [22:36:12] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:36:19] no, it works from the frontend [22:39:38] it would not shock me if phpunit captured all output [22:39:47] !log disable donations queue consumer [22:39:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:40:07] ok, here goes that CRM pending db update! [22:40:46] !log updated CiviCRM from d040549105151ccb66a464effbbd56a3e4bfbb8b to e1feb34ff688e230cced92c46e5c2a78e2b3cffa [22:40:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:44:51] arrrg yeah ejegg got the geoIP path to global var deprecation working, all good! [22:45:44] !log enabled donations queue consumer [22:45:44] Now just gotta refactor a bit to re-sensemake [22:45:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:45:52] AndyRussG|sortof: awesome! [22:46:02] yeah! thanks for insisting on that ! [22:47:18] perfect is the enemy of the good and all, but that promise chaining looked really... promising [22:47:51] Are we assigning fraud points for nobody@wikimedia.org? huh [22:49:04] awight: oh? [22:49:12] hehehe [22:49:14] I learned a lot [22:49:31] awight: some tests might set wikimedia.org as a 'bad' domain for a lark [22:50:37] It seems that the failing test I'm looking at doesn't provide an email, so the donor gets nobody@wmo and then trips fraud scoring... [22:50:52] I'm just rambling though, will know more soon [22:51:00] oh back in 30 [22:58:15] (PS1) Ejegg: Don't pollute $msg with pending_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307445 (https://phabricator.wikimedia.org/T122641) [22:58:40] just a little bit of hygiene ^^^ [23:10:04] (PS5) Ejegg: Use DeletePendingJob in frontend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306840 (https://phabricator.wikimedia.org/T143945) [23:19:29] (PS12) Ejegg: DO NOT MERGE: Clean up orphan rectifier, stop saying limbo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433) [23:28:20] well, CRM seems happy reading from the pending db. Going to relocate, but will have an eye on the pings. [23:47:11] awesome! [23:50:16] awight|brb: i stripped down that 'use deletePendingJob from frontend' patch in case you still want it for orphans [23:51:10] ejegg|afk: Cool, thanks--I do want that, just been putting off trying to come up with a better idea [23:53:09] ejegg|afk: I preferred your suggestion that we reuse payments-init, though... [23:58:28] (CR) Awight: [C: -1] "I very much preferred the idea that we would do the delete from the payments-init queue consumer. The only place we deleteLimboMessage wi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306840 (https://phabricator.wikimedia.org/T143945) (owner: Ejegg)