[00:02:34] (CR) Awight: [C: 2] Don't pollute $msg with pending_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307445 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [00:03:10] I'll sneak on for a bit, later tonight... [00:03:45] (PS3) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [00:05:13] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [00:08:40] i really hate our pending db race condition [00:09:37] had an evil idea that the pendingDb class could drain the queue for a couple seconds when it got a miss, but that's just screwy [00:11:47] (Merged) jenkins-bot: Don't pollute $msg with pending_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307445 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [00:17:38] (PS14) AndyRussG: GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [00:21:56] (CR) AndyRussG: "As per Hangout discussion, this now resolves the promise with geo data, and CN no longer relies on the global window.Geo :)" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [00:22:28] fr-tech ^ done :) [00:22:54] nice! [00:24:50] (CR) jenkins-bot: [V: -1] GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [00:25:03] awwww, not done.. [00:25:31] * AndyRussG|sortof hopes for some minimal jshint thingy [00:26:13] I should really start running that locally.... [00:29:47] (PS15) AndyRussG: GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [00:32:18] K now it's done! [00:47:42] yay! [00:53:48] yeah! [00:54:54] There's still something that irks me about the then() handler return values. Sometimes they control the promise result, sometimes they're passed on to the done() handler... Or always it can be both? I kinda feel there must be some magic involved but I'm not sure... [00:55:25] * AndyRussG|sortof writes coherent prose [01:32:51] Our new kitten now has his own tongue twister, with a punchline! [01:33:23] Tachy mittens was a kitten. In his kitchen he was wishin' for some fish-in-- [01:33:28] (dramatic pause) [01:33:33] --A BOWL!!! [01:50:03] love it [01:50:46] you said what tachy means but i forgot, what is it? [01:51:54] i have a friend whose dog is named tyche https://en.wikipedia.org/wiki/Tyche (tie-kee) [02:16:14] cwd: thx! my daughter thought up most of it... Tachy comes from tache, which means spot in French [02:17:09] (his original owners were francophone) [02:17:31] tyche is cool [02:17:55] we've been obsessing about finding a rhyme like this for a while actually [03:25:17] (PS8) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [03:26:00] (CR) jenkins-bot: [V: -1] WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [03:58:45] (PS16) AndyRussG: GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [08:31:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice extension should have a calendar - https://phabricator.wikimedia.org/T35650#379096 (Qgil) FYI: {T1035} I'm not sure how related that task & discussion is, but just in case someone didn't know about it... [15:13:33] (PS3) Awight: Configuration class can be reused for any search path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306596 [15:57:02] * awight grogs [16:01:36] (CR) AndyRussG: "I think this is the right way to do it. Still, the then() handler magic makes me dizzy..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [16:05:06] Krinkle: ^ [16:18:55] (PS17) AndyRussG: GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) [16:19:57] (PS4) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [16:20:33] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1001[2] - https://phabricator.wikimedia.org/T143900#2594913 (Cmjohnson) [16:20:46] (PS2) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [16:21:52] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [16:22:54] (CR) jenkins-bot: [V: -1] Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [16:25:48] (PS5) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [16:27:31] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [16:33:07] fundraising-tech-ops: encrypt fundraising kafka collector traffic - https://phabricator.wikimedia.org/T142993#2594929 (Jgreen) It looks to me as though by upgrading librdkafka to 0.9.x we would gain TLS support for kafkatee and the fundraising pipeline, @Ottomata is that right? [16:40:01] (Draft1) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [16:41:11] * awight perks up [16:41:54] (PS2) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [16:42:00] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [16:43:48] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [16:47:29] fundraising-tech-ops: check_mysql icinga alerts on fdb2001 - https://phabricator.wikimedia.org/T143929#2594992 (Jgreen) Open>Invalid This appears to have been a one-time thing, thus cancelling task. [16:48:23] (PS3) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [16:49:20] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [16:49:55] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [16:53:50] (PS4) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [16:53:59] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [16:55:09] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [16:57:02] (PS5) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [16:58:17] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:03:14] fr-tech ^ morning! don't hesitate to peek at the last geoIP if you're yearing for promisory callback fallback funky funny fun [17:04:46] oooh shiny :) [17:05:41] just couldn't look away.... [17:06:19] Hi AndyRusG! looking [17:07:56] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:08:56] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:10:09] (PS6) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:10:26] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:11:49] (PS7) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:12:13] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:12:41] thx! [17:13:24] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:15:36] fundraising-tech-ops: frack jessie integration cleanup - https://phabricator.wikimedia.org/T138222#2595126 (Jgreen) [17:16:37] (PS6) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [17:16:39] (PS1) Awight: [WIP] Clean up TestConfiguration defines and globals; use core test autodiscovery [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307542 [17:18:04] fr-tech: hanging out if u wish to join [17:19:22] ah, i need a few minutes [17:20:11] Fundraising-Backlog: Produce failure signals from the application which indicate bad behavior - https://phabricator.wikimedia.org/T137239#2595139 (Jgreen) a:Jgreen>awight @awight this task needs definition to be "actionable" -- if I'm reading it right it looks like a payments/mediawiki extension feat... [17:23:42] be there in a few too! [17:26:33] (CR) Paladox: "Error in related to this patch I think." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:30:51] (Abandoned) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:31:52] (Restored) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:32:02] (PS8) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:33:37] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:35:23] https://www.viwoinc.com/using-the-telephone-for-conference-calls-and-more-with-google-hangouts/ [17:35:30] "Uberconference plugin"? [17:36:32] (PS9) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:37:54] (CR) jenkins-bot: [V: -1] Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:40:15] (PS10) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:41:49] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:43:06] (PS11) Paladox: Add composer.json with phplint [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:43:40] (PS12) Paladox: Add composer.json with phplint, also fix two files with incorrect paths [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [17:43:45] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [17:51:28] Fundraising-Backlog, FR-Paypal: PayPal audit issue: donation not in Civi - https://phabricator.wikimedia.org/T143903#2595295 (MBeat33) The recurring PayPal donor in ZD 238577 also had an extra donation this month, 2U542882PY9183213, which did not reach Civi. We refunded this at PayPal. [19:37:29] We standing up at 12:45 or Grooming at 1:03, or both? [19:41:44] heh [19:45:23] someone mind calling me? [19:45:28] * cwd is going to build a bot [19:49:19] one sec.... [20:04:02] Fundraising-Backlog, FR-Amazon, Spike: Spike: Review Amazon settlement process & API - https://phabricator.wikimedia.org/T144241#2595748 (DStrine) [20:06:17] Fundraising-Backlog, FR-Adyen: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2595757 (DStrine) p:Triage>High [20:09:54] Fundraising-Backlog, FR-Paypal: PayPal audit issue: donation not in Civi - https://phabricator.wikimedia.org/T143903#2595769 (DStrine) p:Triage>High [20:10:41] Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig, MediaWiki-extensions-DonationInterface, Spike: Spike: Reconcile SmashPig and DonationInterface configuration - https://phabricator.wikimedia.org/T143831#2595784 (DStrine) [20:10:55] Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig, MediaWiki-extensions-DonationInterface, Spike: Spike: Reconcile SmashPig and DonationInterface configuration - https://phabricator.wikimedia.org/T143831#2580512 (DStrine) p:Triage>Normal [20:12:36] Fundraising-Backlog, FR-Paypal: PayPal audit issue: donation not in Civi - https://phabricator.wikimedia.org/T143903#2595809 (awight) @MBeat33 > maybe this is related to the missing Subscription ID issue in TRR-20160614.01.008.CSV ? Wow, good guess! 9FV11564E47399914 was indeed the broken line in the au... [20:13:52] Fundraising-Backlog, FR-Paypal: PayPal audit issue: donation not in Civi - https://phabricator.wikimedia.org/T143903#2595813 (awight) p:High>Normal Lowering priority, we think it's affecting very few people and we're waiting for PayPal to respond. [20:15:32] Fundraising-Backlog, FR-Paypal: PayPal audit issue: donation not in Civi - https://phabricator.wikimedia.org/T143903#2595823 (awight) @Ppena FYI, it turns out the bad audit lines actually involved spurious charges to our recurring donors, maybe that's a reason to escalate with them? [20:16:13] Fundraising-Backlog, FR-Adyen: Adyen doesn't officially support our iframe workflow - https://phabricator.wikimedia.org/T143714#2595827 (awight) [20:18:29] Fundraising-Backlog, FR-Adyen: Adyen doesn't officially support our iframe workflow - https://phabricator.wikimedia.org/T143714#2595851 (awight) @Ppena Can you help us suss out Adyen's potential plans for deprecating the iframe workflow? [20:18:54] Fundraising-Backlog, FR-Adyen: Adyen doesn't officially support our iframe workflow - https://phabricator.wikimedia.org/T143714#2595853 (DStrine) a:DStrine [20:19:58] Fundraising-Backlog, FR-Smashpig, Librarization, MediaWiki-extensions-DonationInterface: Spike: Discuss Packagist auto-update for DI and SP - https://phabricator.wikimedia.org/T143647#2595854 (DStrine) p:Triage>Low [20:20:50] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review: symfony-polyfill54 is breaking CI - https://phabricator.wikimedia.org/T143598#2595857 (DStrine) p:High>Normal [20:21:27] Fundraising-Backlog, FR-Ingenico: Duplicate Ingenico iframe bug - https://phabricator.wikimedia.org/T143430#2595859 (DStrine) [20:24:42] (CR) Paladox: "@Awight would you be able to review and merge please?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [20:24:43] Fundraising-Backlog, Epic: EPIC: Recurring upsell for donors - https://phabricator.wikimedia.org/T143429#2595862 (DStrine) [20:26:08] Fundraising-Backlog, Spike: Spike: Banners on Portal - https://phabricator.wikimedia.org/T143428#2595867 (DStrine) p:Triage>Normal [20:27:54] Fundraising-Backlog, Spike: Spike: Banners on Portal - https://phabricator.wikimedia.org/T143428#2567842 (DStrine) This needs to be a full investigation before we can give an estimate. It turns out the portal is not mediawiki so CN might not be able to post to it in it's current form. [20:30:06] Fundraising-Backlog: Better CC Validation and Error Messages - https://phabricator.wikimedia.org/T143427#2595880 (DStrine) This actually needs to be done on the processor side. @Ppena would have to get all PSPs to do this for us. [20:31:20] Fundraising-Backlog: Skeuomorphic interface for entering CC details - https://phabricator.wikimedia.org/T143426#2595884 (DStrine) This is controlled on the PSP side. @Ppena would have to negotiate this with each processor [20:33:17] Fundraising-Backlog, FR-Smashpig, Epic: [Epic] Move all listener message processing to a second stage - https://phabricator.wikimedia.org/T143342#2595888 (DStrine) p:Triage>Normal [20:33:43] Fundraising-Backlog, FR-OtherProcessors, FR-Smashpig, Epic: [Epic] Move all listener message processing to a second stage - https://phabricator.wikimedia.org/T143342#2565243 (DStrine) [20:40:51] Fundraising-Backlog, FR-Smashpig, Librarization, MediaWiki-extensions-DonationInterface: Spike: Discuss Packagist auto-update for DI and SP - https://phabricator.wikimedia.org/T143647#2574720 (Legoktm) Do you mean packagist.org website? or the composer.json file? [20:42:15] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Unplanned-Sprint-Work: Civi email merge won't retain new email address - https://phabricator.wikimedia.org/T143236#2595901 (DStrine) [20:42:54] Fundraising-Backlog: Fundraising tech needs a process for triaging and planning around UX issues - https://phabricator.wikimedia.org/T144315#2595903 (awight) [20:47:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Ability to target users based on edit count range from within Central Notice interface - https://phabricator.wikimedia.org/T143159#2595918 (DStrine) @Jseddon does someone need this soon? If so, when? We could implement a longer term and more perf... [20:53:32] fr-tech got a LocalSettings change in the repo on the deploy server that could use review. Just adding settings for all the redis queues, not turning on any more mirroring yet [20:54:41] ejegg: "Add DonationQueue configuration for all Redis queues" ? [20:55:23] I would suggest not using the $wg prefix if it's not an actual mediawiki global, but use a local variable name instead [20:55:49] +2 either way... [20:56:10] awight: yeah, ok, I can change it to our hwg silliness [20:57:09] meh. To me that indicates something else... [21:00:13] Fundraising-Backlog, FR-Adyen: Adyen doesn't officially support our iframe workflow - https://phabricator.wikimedia.org/T143714#2595936 (DStrine) @Ppena We actually want to continue using the iframe and they don't really support it. It would be best for us if we could talk them into supporting our setup. [21:02:41] fr-tech: sorry to be a broken record, but I really want to deploy some of the queue stuff in the next few hours [21:03:02] ejegg: ack, CR. Okay, on it. [21:03:16] ah, the two "move" patches? [21:03:17] hit list: pending ( https://gerrit.wikimedia.org/r/307359 , https://gerrit.wikimedia.org/r/301313 ) [21:03:27] antifraud: https://gerrit.wikimedia.org/r/303316 [21:03:43] payments-init ( sorta blocking orphans ) : https://gerrit.wikimedia.org/r/303318 [21:03:47] (CR) Cdentinger: [C: 2] Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [21:03:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Ability to target users based on edit count range from within Central Notice interface - https://phabricator.wikimedia.org/T143159#2595946 (Jseddon) This is simply transferring functionality that is currently already being accomplished at the clien... [21:03:54] (CR) Cdentinger: [C: 2] Move payments-init queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [21:04:14] ejegg: np... if it's any use, everything seemed sane in that patch so far [21:04:21] woohoo! Thanks cwd [21:04:22] A except for some silly formatting, one sec [21:04:29] I'll deploy 'em one at a time [21:04:37] let me get some mirroring started... [21:04:46] Ah +2'd, cool!!! [21:07:29] (Merged) jenkins-bot: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303316 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [21:07:31] (Merged) jenkins-bot: Move payments-init queue off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303318 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [21:08:47] (CR) Awight: [C: 2] Stop using pending queue in RecordCaptureJob (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [21:14:45] (CR) Awight: [C: 2] "A waft of fresh air, seeing queueIgnoreObject go away!" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307359 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [21:15:37] (Merged) jenkins-bot: Stop using pending queue in ProcessCaptureRequestJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307359 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [21:15:39] (Merged) jenkins-bot: Stop using pending queue in RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg) [21:16:55] ejegg: you good for now? I should prep for a meeting... [21:18:41] awight: sure! [21:19:16] thanks so much [21:19:30] I'll start with those SmashPig patches [21:25:18] g'luck [21:32:23] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307623 [21:33:00] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307623 (owner: Ejegg) [21:33:13] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307623 (owner: Ejegg) [21:33:39] hmm, no auto +2 button where i actually want it [21:37:04] fr-tech: got a couple more config repo patches up on the deploy server that could use a second glance. Turning on mirroring for the antifraud queue. [21:38:10] (PS9) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [21:38:55] (CR) jenkins-bot: [V: -1] WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [21:39:43] (PS1) Ejegg: Update libs [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/307625 [21:40:23] (CR) Ejegg: [C: 2 V: 2] Update libs [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/307625 (owner: Ejegg) [21:40:41] (PS1) Ejegg: Update libs [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307626 [21:41:23] (CR) Ejegg: [C: 2] Update libs [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307626 (owner: Ejegg) [21:55:15] man, these gate-and-submit jobs just fall through the cracks sometimes [21:55:24] (CR) Ejegg: [V: 2] Update libs [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307626 (owner: Ejegg) [21:57:43] !log updated SmashPig from 4ba14a10518f80fe7e20fadc493d78c796c15921 to b94325bea6158e80f194689e247b16239053baa1 [21:57:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:57:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: MG Annual report: add new column options - https://phabricator.wikimedia.org/T144320#2596104 (DStrine) [21:58:28] no smoke yet, let's try an Adyen payment [21:59:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: MG Annual report: Add new filter options - https://phabricator.wikimedia.org/T144321#2596120 (DStrine) [22:01:40] (PS1) XenoRyet: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307632 (https://phabricator.wikimedia.org/T130308) [22:04:32] (CR) Ejegg: [C: -1] "So nice to see these TODOs get done and start slimming down the hairiest function in our codebase. Just a reminder that the non-orphans ar" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:08:56] K headed out [22:09:42] (CR) Awight: "note: move fraud checks to postprocess for the frontend as well." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:11:57] (CR) Ejegg: [C: -1] "password arg might be in the wrong place. it would be nice to have a layer of configurability between the hard-coded queue name and the ke" (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307632 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [22:17:41] dang, adyen job runner failures [22:19:25] !log rolled back SmashPig to 4ba14a10518f80fe7e20fadc493d78c796c15921 [22:19:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:23:11] (PS1) Eileen: Add index to contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307640 [22:31:35] i gotta run, back later [22:34:51] (PS1) Eileen: 9d23b47 CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307644 [22:35:28] (CR) Eileen: [C: 2] "submodule update (minor) - self-merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307644 (owner: Eileen) [22:38:35] (Merged) jenkins-bot: 9d23b47 CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307644 (owner: Eileen) [22:41:52] (PS2) XenoRyet: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) [22:43:37] (CR) XenoRyet: "Not sure why that last PS had a different change ID, but moving it back over here. Fixed up the argument issue, and rpush is getting the " [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [22:44:01] (Abandoned) XenoRyet: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307632 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [22:44:57] (PS1) Ejegg: Fix dumb omitted return statement [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307646 [22:45:36] fr-tech: sorry, speed + peer pressure kills. ^^^ fixes my dumb mistake [22:45:58] trying to get a test up, but having config merge type issues [22:47:20] (CR) XenoRyet: [C: 2] Fix dumb omitted return statement [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307646 (owner: Ejegg) [22:47:33] thanks! [22:47:40] No worries [22:50:22] (PS1) Ejegg: Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 [22:50:49] ^^^ test is failing because we're being too strict with config overrides [22:51:16] (CR) jenkins-bot: [V: -1] Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 (owner: Ejegg) [22:53:05] ejegg: are the undeployed things ready to go out? [22:54:27] (Merged) jenkins-bot: Fix dumb omitted return statement [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307646 (owner: Ejegg) [22:54:41] (PS1) Ejegg: Allow overriding with dissimilar types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 [22:54:50] eileen: nope! [22:55:05] need to do some queue mirroring first [22:55:32] fr-tech: do the last couple commits in the settings repo on the deploy box look good? Trying to mirror the antifraud queue [22:55:56] ejegg: ok - I'm just preparing 4.7.11 for deployment for tomorrow [22:56:12] k, I'll see if I can get those two out tonight [22:56:19] will be cherry-picking one at a time [22:56:35] (PS2) Ejegg: Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 [22:56:52] ejegg: well I can deploy by cherry-picking tomorrow if need be [22:57:02] I mostly just need to know where it stands [22:57:17] (CR) jenkins-bot: [V: -1] Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 (owner: Ejegg) [22:57:20] yah, just the two 'switch XXX off activeMQ' need special care [22:57:25] I merged a civicrm submodule update just now - but it's unimportant [23:09:12] (PS1) Ejegg: Fix one more oversight with record capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307651 [23:09:30] (PS2) Ejegg: Allow overriding with dissimilar types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 [23:09:32] (PS3) Ejegg: Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 [23:10:06] (CR) jenkins-bot: [V: -1] Allow overriding with dissimilar types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 (owner: Ejegg) [23:10:08] (CR) jenkins-bot: [V: -1] Fix one more oversight with record capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307651 (owner: Ejegg) [23:10:15] (CR) jenkins-bot: [V: -1] Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 (owner: Ejegg) [23:13:14] (PS2) Ejegg: Fix one more oversight with record capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307651 [23:15:49] fr-tech: sorry, I need one more fix inspected ^^^ [23:16:13] It'll make this next test pass, but the test need some changes to core config too [23:16:21] (PS3) Ejegg: Allow overriding with dissimilar types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 [23:16:23] (PS4) Ejegg: Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 [23:18:41] (CR) XenoRyet: [C: 2] Fix one more oversight with record capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307651 (owner: Ejegg) [23:23:34] (Merged) jenkins-bot: Fix one more oversight with record capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307651 (owner: Ejegg) [23:24:55] ejegg: this one? https://gerrit.wikimedia.org/r/307651 [23:25:04] thanks XenoRyet ! [23:25:17] AndyRussG: yep, but it's all set now. Thanks! [23:25:21] Ahhhh cool yeah I see [23:25:25] No problem [23:25:34] * AndyRussG stares at screen [23:26:11] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307657 [23:26:34] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/307657 (owner: Ejegg) [23:30:52] !log updated SmashPig from 4ba14a10518f80fe7e20fadc493d78c796c15921 to b94325bea6158e80f194689e247b16239053baa1 [23:34:18] damn [23:35:08] !log rolled back SmashPig to 4ba14a10518f80fe7e20fadc493d78c796c15921 [23:35:57] what the heck was still making that null? [23:38:38] d'oh, deploy merge never submitted [23:38:56] gate-and-submit jobs my eye! [23:40:03] !log updated SmashPig from 4ba14a10518f80fe7e20fadc493d78c796c15921 to 7f9eb7475d194c67ff070b5d8bbc9fc6837b462f [23:40:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:47:01] Fundraising-Backlog: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#2596357 (DStrine) [23:47:06] success! [23:49:02] ok, fr-tech whenever you have a change to look at the last few commits in the settings repo we can start mirroring antifraud messages and get that queue flipped too [23:49:22] gotta afk for a bit for moving stuffs [23:53:44] Fundraising-Backlog: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#2596368 (DStrine)