[02:21:27] (PS1) Eileen: CiviCRM 4.7.11 upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/307675 [02:48:34] (PS1) Ejegg: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307679 (https://phabricator.wikimedia.org/T131273) [02:49:00] (CR) Ejegg: [C: 2] Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307679 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [02:49:25] (Merged) jenkins-bot: Move antifraud queue off ActiveMQ [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307679 (https://phabricator.wikimedia.org/T131273) (owner: Ejegg) [02:51:30] !log disabled fredge queue consumer [02:51:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:53:15] !log updated civicrm from e1feb34ff688e230cced92c46e5c2a78e2b3cffa to c0a7f45bd913ebd28e16c0d78b009a7af95209e9 [02:53:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:57:30] !log rolled back civicrm to e1feb34ff688e230cced92c46e5c2a78e2b3cffa [02:57:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:58:13] ejegg: hey, while u burn midnight oil, pls lmk if I can help w/ anything! [02:58:28] thanks AndyRussG ! Might have a fix for that failmail in a sec [02:59:20] K :) I'll be around for another hour or 2 [03:03:11] (PS1) Ejegg: Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307680 [03:03:39] AndyRussG: I think that should fix the immediate problem ^^^ [03:03:47] there may be others lurking underneath... [03:04:24] I'm splitting up the fixes so I can cherry-pick them and still deploy just one queue switch at a time [03:04:44] looking... [03:10:13] (PS1) Ejegg: Fix constructor args for payments-init consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307681 [03:10:31] no need to merge ^^ till we've tested the predecessor [03:10:51] Ah hmmm K [03:11:28] Sure seems reasonable, correct constructor argument order [03:11:38] and type... [03:12:04] Ah yeah boolean vs integer [03:12:19] 0 means no limit? [03:13:14] I suppose here explicitness makes more sense than just taking the default value? [03:13:14] yep [03:13:45] ah, good call, if all we want is time limit, no need for the last arg [03:13:50] i'll abbreviate [03:14:53] (PS2) Ejegg: Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307680 [03:16:23] I mean, it depends on whether the 0 limit is specific to what the caller's doing, or whether it makes sense for the caller to just say, "whatever, I'll take the default flavour limit sauce" [03:16:47] yeah, this caller is just concerned with time [03:17:22] Ah K [03:20:02] ejegg: is understanding that it fixes arg order enuf for me to +2? [03:20:18] i think so, since that's the whole change! [03:20:38] i'll check on the banner history patch for the same issue [03:20:45] (PS2) Ejegg: Fix constructor args for payments-init consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307681 [03:21:54] banner history script is already doing it the right way round [03:23:33] Ah cool! [03:23:59] ejegg: which failmail were you talking about? [03:24:19] oh, guess it didn't failmail, just went to the damaged datastore [03:24:30] let's see... [03:24:51] the world is backwards: http://www.nytimes.com/2016/08/31/us/politics/donald-trump-mexico-enrique-pena-nieto.html?hp&action=click&pgtype=Homepage&clickSource=story-heading&module=first-column-region®ion=top-news&WT.nav=top-news [03:24:57] i just meant the jenkins job failure message [03:25:46] wow [03:25:50] Ah I see [03:25:58] Yeah... A new low for both of them [03:26:35] i'd say it's a pretty high water mark for the yanqui [03:26:43] The man insults the entire country, so, invite him over and help him get elected [03:27:16] right? why dignify the buffoon? [03:27:35] yeah unbelievable... Anyway, two buffoons... [03:28:42] It was recently discovered that Peña Nieto plagiarized 30% of his B.A. thesis... and the whole political class is like... mmm, don't make any waves about this one... [03:29:33] http://aristeguinoticias.com/especiales/2016/especial/8ago/el-plagio/ [03:29:43] (scroll down for side-by-side comparisons :) ) [03:32:45] guess he never suspected he'd be ratted out by text matching algorithms. The current generation of cheats might be a little more clever [03:32:46] maybe now he's trying to stoop even lower [03:33:05] so you think it's worth a +2 ? [03:33:43] (CR) AndyRussG: [C: 2] Fix constructor args for payments-init consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307681 (owner: Ejegg) [03:35:40] (CR) AndyRussG: [C: 2] Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307680 (owner: Ejegg) [03:36:11] Thanks! [03:36:24] ejegg: thank u! [03:36:32] might only get to the antifraud one tonight [03:36:42] see how smoothly this goes... [03:37:41] :) [03:38:29] (Merged) jenkins-bot: Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307680 (owner: Ejegg) [03:38:53] (Merged) jenkins-bot: Fix constructor args for payments-init consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307681 (owner: Ejegg) [03:40:15] (PS1) Ejegg: Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307682 [03:40:28] (CR) Ejegg: [C: 2] Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307682 (owner: Ejegg) [03:40:35] (Merged) jenkins-bot: Fix AntifraudQueueConsumer constructor arguments [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307682 (owner: Ejegg) [03:43:54] !log updated civicrm from e1feb34ff688e230cced92c46e5c2a78e2b3cffa to 8895f0e8ac9ad03cdf11b81542c17c5a39ca5cd8 [03:44:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [03:48:44] !log rolled back civicrm to e1feb34ff688e230cced92c46e5c2a78e2b3cffa [03:48:47] well darn [03:49:01] AndyRussG: I forgot to initialize the smashpig logger :( [03:49:09] another trivial fix, but... oops [03:51:14] Ah K... that's what the most recent Jenkins build failure sez? [03:53:13] (PS16) Ejegg: Move banner history off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301660 (https://phabricator.wikimedia.org/T141555) [03:54:49] yeah, it's a little opaque, but that message means we didn't set up the smashpig environment [03:55:28] (PS1) Ejegg: Initialize SmashPig logger in fredge qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307684 [03:57:55] AndyRussG: we've been using basically the same calls in the donations queue consumer for a while: https://github.com/wikimedia/wikimedia-fundraising-crm/blob/eae39f770cd9ef5fa073f7f1f5ab2184779436fc/sites/all/modules/queue2civicrm/queue2civicrm.module#L181 [03:58:21] it's using SmashPig to access the pending DB, so it needs the config and context set up [03:59:48] whew, actual midnight oil [04:02:33] maybe i should give up, but I really don't want to have to revert before eileen's upgrade tomorrow [04:03:33] ejegg: I'm happy to keep looking at stuff if u like... only 11 pm here... still don't stress it! aren't you moving or something? [04:04:57] taking tomorrow off! [04:04:58] that's why the rush tonight... [04:04:59] it'll feel so good to have this stuff switched over [04:05:21] ah right ;) [04:06:52] so yeah, I think https://gerrit.wikimedia.org/r/307684 is the LAST last thing to fix :) [04:11:54] ejegg: K looking [04:12:10] Same initialization as we've been doing in the main queue consumer since we started comparing pending db entries a couple weeks ago [04:17:01] So 'fredge_batch_process' is the logger name? [04:17:01] And this has to be initialized before we get to getQueue() in BaseQueueConsumer? [04:17:01] ejegg: ^ [04:17:59] I should just +2 [04:18:26] (CR) AndyRussG: [C: 2] Initialize SmashPig logger in fredge qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307684 (owner: Ejegg) [04:19:07] oh, yeah, that's the log tag [04:19:24] sorry, had irc minimized [04:20:39] thanks for sticking with me AndyRussG ! [04:21:23] (Merged) jenkins-bot: Initialize SmashPig logger in fredge qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307684 (owner: Ejegg) [04:21:44] ejegg: np, thank u too :) [04:24:45] (PS1) Ejegg: Initialize SmashPig logger in fredge qc [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307685 [04:25:13] (CR) Ejegg: [C: 2] Initialize SmashPig logger in fredge qc [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307685 (owner: Ejegg) [04:25:53] (Merged) jenkins-bot: Initialize SmashPig logger in fredge qc [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307685 (owner: Ejegg) [04:28:55] !log updated civicrm from e1feb34ff688e230cced92c46e5c2a78e2b3cffa to d067c476da074afa70297c29e3d471743c110e3a [04:29:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [04:29:00] * ejegg crosses fingers [04:31:32] looks like it's doing stuff! [04:31:37] let's check the db [04:32:16] cool! [04:33:43] looks like it all matches up! [04:37:21] amazing! [04:37:27] whew [04:50:36] ejegg: congrats!!!! [04:50:46] K have a fun move! [04:51:16] have a good night! [04:55:36] :) [05:15:55] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Unplanned-Sprint-Work: Civi email merge won't retain new email address - https://phabricator.wikimedia.org/T143236#2596736 (Eileenmcnaughton) a:Eileenmcnaughton [05:16:56] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Unplanned-Sprint-Work: Civi email merge won't retain new email address - https://phabricator.wikimedia.org/T143236#2561596 (Eileenmcnaughton) I successfully replicated this. (which is good even though it sounds bad :-) [05:26:48] (PS1) Eileen: Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307689 (https://phabricator.wikimedia.org/T96410) [14:05:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598179 (Pcoombe) [16:15:41] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598723 (DStrine) p:Triage>Unbreak! [16:18:58] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598734 (DStrine) p:Unbreak!>High [16:19:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598179 (DStrine) [16:37:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598179 (AndyRussG) This doesn't look good. :) My first guess is a DB replication issue. Let's try to look at the campaign settings in the logs, and investigate if there we... [16:56:43] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, and 2 others: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2598872 (DStrine) [17:18:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598931 (AndyRussG) Just spoke to @jcrespo (thanks!!!!) on IRC about possible DB replication lag on the cluster between 13:00 and 13:40 UTC today: 11:51 AndyRuss... [17:19:45] fundraising-tech-ops, WMF-NDA: log grepper tool to help Donor Services debug odd transactions with payment providers - https://phabricator.wikimedia.org/T84664#2598938 (Jgreen) [17:20:18] Fundraising-Backlog: Create tools to retrieve relevant information from logs in a useful format - https://phabricator.wikimedia.org/T113268#2598942 (Jgreen) [17:20:20] fundraising-tech-ops, WMF-NDA: log grepper tool to help Donor Services debug odd transactions with payment providers - https://phabricator.wikimedia.org/T84664#930031 (Jgreen) [17:21:42] fundraising-tech-ops: install OS on frdb1001 - https://phabricator.wikimedia.org/T143245#2598947 (Jgreen) This is done. There may be minor cleanup related to the switch to Debian Jessie, but nothing that matters in terms of this ticket. [17:22:11] fundraising-tech-ops: install OS on frdb1001 - https://phabricator.wikimedia.org/T143245#2598948 (Jgreen) [17:22:14] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2598950 (Jgreen) [17:22:46] fundraising-tech-ops: install OS on frdb1001 - https://phabricator.wikimedia.org/T143245#2561807 (Jgreen) Open>Resolved [17:26:17] fr-tech: sorry for the last minute notice, but can anyone sub for me in scrum of scrums in 10 min? [17:29:08] ah yeah i'll try to make it [17:29:28] in like 1m right? [17:35:36] cwd: if there's not much to talk about, you could mention that CN will stop doing GeoIP background lookups because the lookup service is turning off soon... That other extensions can get Geo data from window.Geo or, ideally, from within a handler for mw.geoIP.getPromise()... Not urgent to bring up if there's other more pressing stuff tho, thx also 4 going to the meeting! [17:36:19] AndyRussG: will definitely mention that [17:36:24] thanks [17:36:34] likewise [17:36:36] :) [17:55:56] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2599097 (dr0ptp4kt) Heads up @Jhernandez, I think... [17:57:37] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2562534 (Mattflaschen-WMF) If this affects window... [18:02:09] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2599113 (BBlack) The cookie itself isn't going aw... [18:24:21] WFMU FTW [18:28:06] work...from...manchester united? [18:31:17] dstrine: https://etherpad.wikimedia.org/p/CentralNotice_banner_sequence [18:31:23] one sec, looking 4 my headphones [18:32:18] fr-tech: ^ also comments welcome on that neither-horrific-nor-wonderful idea... [18:41:52] cwd: bloody good idea, at that! [18:42:02] It's a new joisey radio station [18:42:06] killer beats [18:43:17] AndyRussG: Oh, wonderful! Looking forward to letting the sequence spec soak in a bit [18:50:20] AndyRussG: Random thought: Do you think the banner sequence work could be split up among the team and pursued together, a la the queue overhaul? [18:53:02] i would sure like to dig in to CN [18:56:28] awight: if you have time to take a look at that paypal listener patch that would be excellent, tests are failing but the commit message describes why + a question [18:56:58] we should probably circle the wagons this afternoon and discuss the plan to migrate the other queues [18:57:30] great! Agreed that we need to coordinate steps in ejegg|away's absence ;) [18:59:36] awight: thx! hey also sounds like an option... cwd you'll find your shovel hitting a odd mix of lava and ice :) [18:59:55] AndyRussG: Our conversation in etherpad is pushing me towards a https://jqueryui.com/sortable/#default interface, where adding and deleting a banner from a bucket is the same with or without "sequence" enabled. [19:00:21] err s/where/plus let's also make/ [19:01:52] awight: that sortable is pretty! dunno about moving other stuff about, one thing dstrine and I just talked about is not touching other stuff so that in case it's not finished in time, there's no risk of anything getting into an unusable state [19:04:14] Makes sense, and I agree that we shouldn't have to touch other stuff. [19:05:21] ... but you can always get away with small changes to other stuff in a scenario like that, as long as the dependencies are all from our new campaign feature, towards the new core feature [19:06:50] AndyRussG: While we're edit warring ;) in etherpad, I made some changes to your idea in yeterday's https://etherpad.wikimedia.org/p/fr-tech-talk minutes, please let me know if I muddied anything [19:38:04] I have a pop up saying daily autopsy in 8 mins -but it's not in my calendar -is there one today? or just planning at 10? [19:38:22] I think just planning. [19:38:34] We don't usually do standup on the same day as planning. [19:39:05] +1 [19:40:31] yeah I deleted the wednesday instance of autopsy [19:40:43] cool - wonder why I have an awol popup [19:40:50] I'm not sure why it still popped up for you. [19:40:53] yeah [19:41:25] Google is weird [19:41:29] :-) [19:52:38] (CR) Awight: WIP smashpig paypal listener (20 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:56:36] * cwd puts on reading glasses [19:58:09] * awight hands off 3d spex [19:58:18] cwd: I'm confused by your comment in the commit message... [19:58:40] What normalizations u talking about [19:59:15] awight: everything that happens in the message class [19:59:34] it's a bunch of transforms i copied out of the prod listener [19:59:49] (WFMU has really gone overboard btw) [20:00:25] awight: why do you prefer protected? [20:00:30] ( a muzak version of I wanna be sedated) [20:00:36] heh [20:00:42] sounds awesome [20:00:56] cwd: eh I just don't see the point of private, unless you mean it very intentionally [20:01:32] well i feel like if you're going to subclass something you should have to be deliberate about it [20:01:41] and change the parent class into something that can be subclassed [20:02:05] because i basically think inheritance is the basis of 90% of terrible php [20:02:33] hehe fair enuf [20:03:28] i've never seen the fabled example of class inheritance that is less confusing than an alternative that is composed of parts [20:04:03] IDEs probably make it easy, but then i think you're writing code that only other people with IDEs can understand [20:04:25] when the same concepts can be expressed more simply [20:04:34] (CR) Awight: WIP smashpig paypal listener (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [20:07:02] Don't worry about 50% of my comments btw, just however much cleanup you agree with [20:08:17] no it's great, thanks very much [20:09:13] * awight stumbles back into the ring for another 20 comments :p [20:10:02] You chopped away an impressive number of unproductive limbs in the legacy code, btw! It's almost nothing but the var_map [20:10:58] lately i've been getting this tingly feeling that most things can be reduced to a config file [20:11:58] nice. Want to apply that static to https://gerrit.wikimedia.org/r/#/c/306596/ ? [20:12:40] yeah definitely [20:13:03] awight: srs question, is it worth the risk of pushing through the queue changes without elliott around? [20:13:18] he pretty much had the reins [20:13:51] Oh. I think we could get away with it. But there's plenty to do aside from the switchover... [20:14:08] yeah that's what i was kinda thinking [20:14:20] like i could follow the directions but it would take me forever [20:14:24] and he will knock it out in no time [20:14:40] so i wonder if it's better to continue the things we have momentum on [20:14:53] I might do it just as a way to understand what's going on [20:15:02] The meeting schedule today is uncomfortable tho [20:15:09] sure, if you do i'd like to participate [20:15:23] cool, thank you for the offer [20:15:31] i have only a vague idea of what's going on [20:16:17] Hehe, I feel that way about most of life [20:16:27] amen [20:17:55] If you get fired up after reading the config patch, I'd love to chat about /etc overrides for DI/gateway*/config files [20:18:28] sure thing [20:18:50] is this roles meeting happening? [20:19:14] (PS4) Awight: Configuration class can be reused for any search path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306596 [20:19:38] It's becoming increasingly mislabeled, but yeah I assume so [20:20:54] * awight blinks at the new label [20:20:59] sounds like that pretty much covers the afternoon [20:23:39] aww, Young Frankenstein clips [20:25:03] Fundraising-Backlog: Issues manually merging records - https://phabricator.wikimedia.org/T144440#2599873 (RLewis) [20:26:43] awight: just out of curiosity, why the beef with constructors? [20:27:11] they are an unnecessary feature for sure [20:27:46] It's a really inflexible way to do things [20:28:24] With an empty constructor, you can make an object, do fluent things to it like twiddle settings, and then process or not however u wish [20:28:56] And if you always want to do something while instantiating, it's nicer to have a set of descriptive static factory methods (or helper classes) [20:29:05] like createFromMessage [20:29:21] n.p. if you disagree in this case of course [20:30:40] Fundraising-Backlog: Issues manually merging records - https://phabricator.wikimedia.org/T144440#2599912 (RLewis) Update I just tried to do the merge again and it worked ok but it would be good to keep an eye on this as @LeanneS has had some issues with manual merging also. [20:30:41] you mean because it doesn't restrict things of that class to the operations in the constructor? [20:31:01] or saddle them with [20:31:12] exactly [20:31:22] with obscure arguments [20:31:54] i think OOP is an antipattern so you won't get any flak from me :) [20:32:07] amen to that [20:32:12] much more useful as a mental model than a programming one [20:32:42] Might even be toxic on a mental level [20:32:56] Cos an object so rarely encapsulates a single thing [20:33:42] yeah [20:33:52] if it was done right it might be cool [20:33:56] but there's no reason to do it [20:34:08] It always leads to smart record hell... [20:34:25] * awight glances at GatewayAdapter [20:34:59] at least we don't have that to deal with [20:35:29] argh i might have to miss some of this meeting [20:35:35] roofer is coming to give estimate [20:42:09] requirejs error loading adp [20:44:55] (CR) Awight: [C: 2] "Seems reasonable!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/307675 (owner: Eileen) [20:46:57] cwd: I have that one, too. It's to keep the FLOSS people on tenterhooks [20:51:48] (Merged) jenkins-bot: CiviCRM 4.7.11 upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/307675 (owner: Eileen) [21:12:14] argh - google chucked me off to make me re-authenticate [21:12:55] and … my phone is completely dead to get the text [21:13:15] harr! [21:13:22] The nightmare scenario. [21:13:34] For future use, u should get a blue yubikey for that [21:14:10] ah hmm. I just took the battery out of my phone & put it back in but it still won't charge [22:00:47] Fundraising-Backlog, Goal: SPRINT P (Aug17 to Aug31) Goal: Queue work and bugs - https://phabricator.wikimedia.org/T142040#2600118 (DStrine) Open>Resolved [22:04:00] Fundraising-Backlog: SPRINT Q (8/31 - 9/14) Goal: finish Queues and fix bugs - https://phabricator.wikimedia.org/T144449#2600152 (DStrine) [22:17:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: more precise UI mock-up - https://phabricator.wikimedia.org/T144452#2600221 (AndyRussG) [22:17:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: more precise, new UI mock-up - https://phabricator.wikimedia.org/T144452#2600234 (AndyRussG) [22:20:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: implement MVP - https://phabricator.wikimedia.org/T144453#2600241 (AndyRussG) [22:21:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: fix Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#2600270 (AndyRussG) [22:21:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#2600283 (AndyRussG) [22:24:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: unit tests - https://phabricator.wikimedia.org/T144456#2600291 (AndyRussG) [22:37:41] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2600311 (awight) a:AndyRussG [22:40:11] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, and 3 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2600326 (DStrine) Open>Resolved [22:40:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, FR-ActiveMQ, and 3 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#2600329 (awight) [22:40:39] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, Spike: Spike: Deploy pilot new queue consumer - https://phabricator.wikimedia.org/T130306#2132077 (awight) Open>Resolved [22:44:14] (CR) Awight: [C: -1] "Almost ready to deploy! Could you make the example edits to config.yaml.example though?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [22:46:26] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Handle Conflicts on privacy fields - https://phabricator.wikimedia.org/T143856#2600339 (Eileenmcnaughton) [22:46:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#2600343 (Eileenmcnaughton) [22:46:52] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Handle Conflicts on privacy fields - https://phabricator.wikimedia.org/T143856#2581327 (Eileenmcnaughton) Open>Resolved Actually pulled this in & did it & Elliott reviewed it [22:48:59] Fundraising-Backlog, Spike: Spike: Zendesk migration from Web Portal to Helpdesk - https://phabricator.wikimedia.org/T143142#2558203 (DStrine) [22:49:38] Fundraising-Backlog, Spike: Spike: Zendesk migration from Web Portal to Helpdesk - https://phabricator.wikimedia.org/T143142#2600349 (awight) @MBeat33 I'm a bit lost--like you said, we don't let donors do anything with our web portal. (Still not sure if that's true for the shop?) But wikimedia.zendesk... [23:00:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: more precise, new UI mock-up - https://phabricator.wikimedia.org/T144452#2600373 (DStrine) a:DStrine [23:00:49] Fundraising-Backlog, Spike: Spike: Zendesk migration from Web Portal to Helpdesk - https://phabricator.wikimedia.org/T143142#2600375 (MBeat33) Thanks, @awight https://wikimediashop.zendesk.com/home has no active shopper-facing content that I can see. DS agents have to log in to wikimedia.zendesk.com in... [23:01:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [Epic] CentralNotice banner sequence: implement MVP - https://phabricator.wikimedia.org/T144453#2600376 (awight) [23:03:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: implement MVP - https://phabricator.wikimedia.org/T144453#2600381 (DStrine) [23:08:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: implement feature for MVP - https://phabricator.wikimedia.org/T144453#2600389 (AndyRussG) [23:10:26] Fundraising Sprint Q 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: implement feature for MVP - https://phabricator.wikimedia.org/T144453#2600395 (DStrine) [23:10:29] Fundraising Sprint Q 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: more precise, new UI mock-up - https://phabricator.wikimedia.org/T144452#2600396 (DStrine) [23:10:31] Fundraising Sprint Q 2016, Fundraising-Backlog: SPRINT Q (8/31 - 9/14) Goal: finish Queues and fix bugs - https://phabricator.wikimedia.org/T144449#2600397 (DStrine) [23:10:33] Fundraising Sprint Q 2016, Fundraising-Backlog, FR-Adyen: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2600398 (DStrine) [23:10:36] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Delete from the pending database when a transaction is failed - https://phabricator.wikimedia.org/T143945#2600400 (DStrine) [23:10:38] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Civi email merge won't retain new email address - https://phabricator.wikimedia.org/T143236#2600402 (DStrine) [23:10:40] Fundraising Sprint Q 2016, Fundraising-Backlog, Spike: Spike: Zendesk migration from Web Portal to Helpdesk - https://phabricator.wikimedia.org/T143142#2600403 (DStrine) [23:10:42] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, and 2 others: Spike: Civi Failmail Error: IMPORT_CONTACT Couldn't store email for the contact. - https://phabricator.wikimedia.org/T142954#2600404 (DStrine) [23:10:43] Fundraising Sprint Octopus Untangling, Fundraising Sprint Q 2016, Fundraising-Backlog, Epic: Epic: Create frack vm cluster - https://phabricator.wikimedia.org/T142533#2600406 (DStrine) [23:10:49] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 4 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2600401 (DStrine) [23:10:51] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, and 7 others: Move legacy PayPal listener to SmashPig - https://phabricator.wikimedia.org/T141654#2600408 (DStrine) [23:10:53] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, and 3 others: Store damaged and delayed messages in a database not a queue - https://phabricator.wikimedia.org/T142028#2600410 (DStrine) [23:10:55] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Support CiviCRM dash changes - https://phabricator.wikimedia.org/T142051#2600407 (DStrine) [23:10:56] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, and 2 others: Migrate banner history queue off ActiveMQ - https://phabricator.wikimedia.org/T141555#2600409 (DStrine) [23:11:00] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 8 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2600412 (DStr... [23:11:11] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, and 3 others: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2600416 (DStrine) [23:11:12] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 4 others: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2600417 (DStrine) [23:11:14] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, Fundraising-Backlog, and 2 others: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not... - https://phabricator.wikimedia.org/T96410#2600422 [23:11:16] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 7 others: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#2600421 (DStrine) [23:11:18] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Q 2016, and 4 others: Migrate fredge to new queue - https://phabricator.wikimedia.org/T131273#2600420 (DStrine) [23:11:21] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 14 others: [Epic] All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2600419 (DStrine) [23:23:58] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Spike: Spike: Zendesk migration from Web Portal to Helpdesk - https://phabricator.wikimedia.org/T143142#2600452 (Ppena) Confirmed shop only uses the regular email client [23:25:46] awight: yeah i think your point about constructors is valid and i'm going to stop using them [23:33:54] :D [23:33:59] * awight notches belt [23:34:47] I failed to check if that was a pattern copied from the other provider dirs though [23:35:05] nah i don't think so [23:35:50] as far as my question about normalization, the test you wrote compares the documents but does not account for those transformations. do i have the steps out of order? [23:36:38] Ah I botched the steps, then [23:36:48] wait. [23:36:55] Are you talking about the first stage or second? [23:37:01] hmmm [23:37:04] Cos I noticed that you were parsing in the first stage, which is wrong [23:37:24] ah ok, so we want to store the raw request? [23:37:25] Mostly, because we need the raw message for the PayPal validation API in the second stage. [23:37:29] yeah exactly [23:37:54] the transforms from the current listener, where are those supposed to end up? [23:38:00] everything that the message class i wrote does [23:38:07] That should go into stage 2 [23:38:09] is that for db normalization? [23:38:18] for which table? [23:38:22] parse, validate, send to completed queue [23:38:54] Unfortunately, that legacy listener didn't normalize, it just did a few rando unhelpful transformations. [23:39:06] doesn't the collection of the payment have to happen too? [23:39:08] We can leave that for a later iteration, if you like [23:39:22] nah this is just a courtesy notification. We've received the money when the IPN comes through. [23:39:31] or at least, the transaction is final on the PP side [23:39:44] ok gotcha [23:39:59] in that case, does the message class even need to exist? [23:40:03] vailed validation should probably cause a failmail, but that can also TODO [23:40:17] should the message class do the validation? [23:40:21] um. That's up to you, I personally loathe the multiple layers of unhelpful messages in that lib [23:40:47] donno, I happen to not like the smart message approach [23:40:51] yeah me too [23:41:00] happy to just not make those classes [23:41:17] Totally, please do decouple from all the bad decisions you can [23:41:20] can do the validation in the listener if it's not too crazy [23:41:33] (probably compare against config files :) [23:41:37] I was hoping that the PayPal listener would become the new standard that we move to for other gateways [23:41:47] no, don't validate from the listener [23:41:56] We just want to return status 200 and call it a day. [23:42:10] (assuming by "listener" u meaning stage 1) [23:42:20] ah ok, the completed consumer should do that? [23:42:38] yeah. I think the way to describe it is, the listener should never fail. [23:42:49] just store a request [23:42:50] And it shouldn't wait for any external resources. [23:42:51] i dig [23:42:52] y [23:43:13] ok great that makes sense [23:43:34] Looks like you're all over it, but just FTR the current consensus is that the RestListener is bogus [23:43:53] whoa. A leaf just landed on my keys and a "huge" spider leapt out [23:43:57] yeah another layer of indirection [23:44:10] whew [23:44:32] i got all this stuff from my uncle in albuquerque and it is all full of black widows [23:44:43] i think i killed them all [23:44:49] but man they are everywhere in that city [23:44:56] okay it was like 5mm wide, but it had the element of surprise [23:45:11] yeah here too, I found hundreds of baby black widows in a tarp at our community garden. [23:45:14] RIP [23:46:02] Used to have them in my back yard real bad. I think I waged enough war on them that they've mostly had their niche filled by false widows now. [23:46:30] i was wondering the other day at since people are so disproportionately scared of spiders if there was a time when spiders were especially dangerous [23:46:41] or something that looks like spiders [23:46:57] haha [23:47:21] Maybe when we were competing for the bugs [23:47:27] Must be something, right? By the numbers even black widows aren't really dangerous. Their bite rarely kills and they're totally non-agressive. [23:47:47] You basically have to poke them to get them to bite. [23:49:13] yeah spiders are a super low risk coinhabitant [23:49:43] even the nasty ones [23:50:22] http://www.livescience.com/55631-wealthy-homes-have-more-bugs.html [23:50:27] They can even be a status symbol [23:51:02] heh [23:51:07] makes sense [23:51:24] the biggest rats, too! [23:51:51] rich folk also tend to have large areas of uninhabited space [23:52:17] 2.5 bathrooms per individual [23:52:57] that was the general recommendation in 2007 [23:53:04] hahaha [23:53:59] until tomorrow!