[00:09:35] !log stop Donations q consumer job on jenkins [00:09:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:13:16] !log fr campaigns disabled [00:13:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:16:04] (PS1) Eileen: Submodule commit CiviCRM upgrade to 4.7.11 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307890 [00:16:26] (CR) Eileen: [C: 2] "submodule commit - self-merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307890 (owner: Eileen) [00:19:47] (Merged) jenkins-bot: Submodule commit CiviCRM upgrade to 4.7.11 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307890 (owner: Eileen) [00:22:11] (PS1) Eileen: Submodule commit CiviCRM upgrade to 4.7.11 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307891 [00:23:32] (CR) Eileen: [C: 2] "Submodule commit merge to deploy, self-merging" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307891 (owner: Eileen) [00:25:13] (Merged) jenkins-bot: Submodule commit CiviCRM upgrade to 4.7.11 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/307891 (owner: Eileen) [00:26:03] my dog ran off, gotta go find her [00:28:59] !log CiviCRM upgrade from from d067c476da074afa70297c29e3d471743c110e3a to 0c6bf3813ee0f2e58d5948fc7c000cf20c114841 [00:29:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:31:05] Fundraising-Backlog, FR-Adyen: Adyen doesn't officially support our iframe workflow - https://phabricator.wikimedia.org/T143714#2600553 (Ppena) All, Adyen does not support iframes, and we knew it from the time we first integrated with them. We have tailored their hosted page into looking like an iframe... [00:34:32] Fundraising-Backlog: Skeuomorphic interface for entering CC details - https://phabricator.wikimedia.org/T143426#2600558 (Ppena) AFAK this can be controlled by us if we use a different kind of integration, like Client side encryption (Adyen) or Silent post (WP). I dont remember whats called in Ingenico. That'... [00:35:45] Fundraising-Backlog, FR-Paypal: PayPal audit issue: donation not in Civi - https://phabricator.wikimedia.org/T143903#2600573 (Ppena) @awight On it :) [00:41:50] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 4 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2600579 (AndyRussG) >>!... [01:00:33] !log reboot db1025 for kernel update [03:33:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2600688 (AndyRussG) K, I just inspected the CentralNotice campaign log tables, and I don't see anything out of the ordinary. I guess that eliminates a UI issue as the culpr... [04:14:53] (PS1) Eileen: Fix log messag to count correct variable. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307912 [11:40:49] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint UB40, Fundraising-Backlog, and 2 others: Documentation: overview of new CN code and instructions for CN admins - https://phabricator.wikimedia.org/T111386#2601202 (Jseddon) Open>declined [12:38:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2601272 (Pcoombe) @AndyRussG There was the low priority campaign C1617_enWW_dsk_lw_FR running, and showing in BannerAllocation. [13:24:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2601349 (MBeat33) [13:26:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2601362 (MBeat33) p:Triage>Unbreak! [13:53:18] !log turned off queue for http://localhost:9000/job/GlobalCollect%20Recurring%20Donations/ in jenkins [13:53:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [13:56:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2601349 (Eileenmcnaughton) I turned off queue for http://localhost:9000/job/GlobalCollect%20Recurring%20Donations/ in jenkins [15:36:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2601691 (AndyRussG) @Pcoombe thanks! Also: the mobile campaigns C1617_en6C_mob_FR and C1617_en6C_ipd_FR that were turned on for the same project/language/countries at the... [16:58:48] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-Adyen: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2602005 (XenoRyet) a:XenoRyet [16:59:56] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-ActiveMQ, Patch-For-Review: Python fundraising-tools queue module should be abstracted and support Redis - https://phabricator.wikimedia.org/T130308#2602008 (XenoRyet) [17:12:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2602059 (AndyRussG) Apparently no memcached infrastructure issues coincide with the timing of this bug, at least not as far as ganglia reports: - [[ https://ganglia.wikime... [17:22:43] breaking fast... [17:23:55] Sugar puffs? Or organic-cane-sure-laden flakseed? [17:24:09] s/sure/sugar/ [17:24:50] fr-tech morning! anyone got a sec for pending unbreak CN review? https://gerrit.wikimedia.org/r/#/c/306598 [17:25:30] happy to walk thru if useful..... ;) [17:29:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2602165 (spatton) @AndyRussG correct, C1617_en6C_mob_FR and C1617_en6C_ipd_FR both worked fine from the start. Thanks for investigating this. [17:32:18] (PS1) XenoRyet: Reenable AmEx on Adyen form for France. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307990 (https://phabricator.wikimedia.org/T144236) [17:33:12] AndyRussG: i would love to get the full run down of that, but i have to head back to santa fe now. i'll be available in maybe an hour if that is helpful! [17:33:30] cwd: sure! thx :) [17:35:35] Fundraising-Backlog: Skeuomorphic interface for entering CC details - https://phabricator.wikimedia.org/T143426#2602183 (spatton) Adding Megan and Peter as subscribers. [17:36:19] great! talk to you then [17:50:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2602197 (AndyRussG) @spatton cool, thanks! I'm wondering if maybe the memcached object was purged at one datacenter and not the other... But if that were the case, I think... [18:02:22] (PS3) XenoRyet: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) [18:12:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2602242 (AndyRussG) ...also it could be that the same race condition kept occurring until the last settings change, when the priority was put back to "high"... [18:15:19] fundraising-tech-ops: recycle db1008 for frack virtual test cluster protoyping - https://phabricator.wikimedia.org/T140953#2602244 (Jgreen) db1008 is now out of service, replaced by frdb1001. Note it is still in replication and monitoring, but the fundraising-read service alias has been moved and database du... [18:15:35] fundraising-tech-ops: recycle db1008 for frack virtual test cluster protoyping - https://phabricator.wikimedia.org/T140953#2602245 (Jgreen) p:Triage>Normal [18:18:22] cwd|afk: pinging in case you still want to review https://gerrit.wikimedia.org/r/#/c/306596/ [18:18:48] "I'm swimming in raw sewage... i *love* it" [18:19:10] heh it's not really possible to dig the ditch i was imagining [18:19:23] i think there is a sump pump and a long hose in my future [18:19:58] haha, I've experienced that fix. [18:20:21] gonna have to get the big one [18:20:26] pretty much have to drain a small pond [18:20:42] I lived in the "garden floor" of a 4-story brownstone, and the landlord had replaced all the waste pipes except the ones in the basement. Which burst from the pressure. [18:21:06] cwd: man I'm so sorry to hear about all that :( [18:21:13] It was knee-deep for a month while he burned incense and slowly pumped it into the neighbor's yard. I believe he called that "brooklyn guerilla style" [18:21:33] awight: nyc landlord for sure [18:21:42] not that i've ever had one [18:21:49] but i've seen the state they keep those brownstones in [18:22:03] dstrine: thanks. yeah this house is going to break me [18:23:16] (CR) Awight: "Minor cleanup if u wish" (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [18:23:21] awight: anyway yeah i am in to this config patch [18:23:33] ah cool, thx [18:23:39] what i would really love is if it was broken out into a module both SP and DI implement [18:23:47] It's not blocking anything other than recovering my sanity [18:23:55] cwd: +1 great idea. [18:24:00] SmashPigConfiguration [18:24:35] Do you agree with the inheritance patter we're starting to use everywhere? It kind of doesn't offend me yet [18:24:42] *pattern [18:25:33] can you explain? [18:25:38] will things inherit from Configuration? [18:26:05] Yeah, the gist is that DonationInterface will have a DonationInterfaceConfiguration which extends Configuration, but has the DI search path and any other quirks built in. [18:26:22] We use that in a bunch of tests, too. [18:26:52] IMO we either do that or dependency injection, but I don't see how we could set up meaningful dependency injection *before* loading the config [18:27:09] So the entry point might as well directly declare its preferred configuration. [18:27:20] Hmm. But how would that work when we have a DI and an SP config... [18:27:22] and so far Configuration === yaml files right? [18:27:26] yeah [18:27:45] Although I'm toying with having the config search path in an environment variable [18:27:56] ... or maybe just an extra path [18:28:05] we are definitely going to need magic here and there so the config classes seem to be a good place to stick that [18:28:47] agreed, it's a good enough place to hide the mess for now, so at least we don't spread the virus [18:29:54] this patch should be no-op right, just making some stuff available? [18:30:02] dstrine: Shall I pull in T144489 ? [18:30:02] T144489: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489 [18:30:06] cwd: That's what I'm thinking [18:30:46] hmmm [18:31:10] Now I'm a bit hung up on how to initialize both SP and DI config though. [18:31:29] I really don't like that any entry point will have to set up both libraries. [18:31:46] yeah i'm thinking about that too [18:31:59] (CR) XenoRyet: Make PayPal audit mirror to Redis (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [18:32:10] it would be nice if they all lived side by side [18:32:35] (PS4) XenoRyet: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) [18:32:45] cwd: Rodney King style? [18:32:47] or if the applications were submodules of configuration [18:32:52] hrm [18:33:03] Seems like an extra level of indirection [18:33:36] should the applications install configuration with composer? [18:33:41] I feel pretty comfortable with how the file layout will look [18:33:46] but it's the initialization that stinks [18:33:54] huh. What does composer configuration look like? [18:34:58] how do you mean? [18:37:16] pls explain what you mean by installing config with composer [18:38:37] like DI and SP both have it in vendor [18:38:49] make a new Configuration and point to whatever yaml files they have [18:39:19] Not sure I see the advantage over just leaving the *Configuration class in DI and SP respectively [18:39:36] What's annoying is that the CRM for example will have to create a SmashPig ] [18:39:43] SpConfiguration and a DiConfiguration [18:40:12] crm uses sp for audit stuff? [18:40:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2602340 (AndyRussG) From IRC: seems this is a common ObjectCache issue and there are options we need to pass in to invoke code that deals with it :) [18:40:36] Hmm, I think it might but we're somehow avoiding config [18:40:53] In the case I'm dealing with, it's recurring Ingenico and the orphan rectifier [18:42:16] awight: did I turn off the right q for that? [18:42:33] eileen: Thank you! Yeah that was the one [18:42:36] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2602359 (DStrine) [18:42:54] awight: I thought it already had been in the sprint. I just moved it in [18:43:09] dstrine: cool. I'll investigate that today [18:44:15] cwd: fr-tech: I could [w|t]alk through the CN geoIP patch now or in about 30 min, whichever works better... [18:46:34] AndyRussG: 30m would be great [18:46:42] cwd: K cool! [18:47:05] awight: it seems like having classes that extend classes in another repo is wrong [18:47:14] huh. [18:47:29] doesn't that seem like tentacles? [18:47:30] I've hadn't considered that [18:47:51] I'm always game for finding a way around inheritance. [18:48:04] What about classes which implement an interface from another repo [18:48:26] meh, we wouldn't really need that, other than to suggest a best practice [18:48:40] Yeah Configuration could be used as a helper. [18:48:44] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Handle Conflicts on privacy fields - https://phabricator.wikimedia.org/T143856#2602396 (DStrine) [18:48:57] Oh dang. Another issue with my scheme is that we're doing a singleton thing with Configuration. [18:49:51] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, and 2 others: Pipeline Report - https://phabricator.wikimedia.org/T128818#2602400 (DStrine) [18:50:00] let me look at the patch again [18:50:17] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2602401 (DStrine) [18:50:41] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Delete from the pending database when a transaction is imported into the database - https://phabricator.wikimedia.org/T143942#2602402 (DStrine) [18:51:11] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, FR-Paypal, and 2 others: Queue consumer sometimes fails to parse string date - https://phabricator.wikimedia.org/T142417#2602403 (DStrine) [18:52:06] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Clicking the credit card button multiple times loads duplicate iframes... - https://phabricator.wikimedia.org/T142059#2602405 (DStri... [18:54:13] cwd: So the usage in non-entrypoint modules is currently "Context::get()->getConfiguration()" [18:54:24] That doesn't work at all with my SmashPigConfiguration suggestion. [18:54:30] It would have to be SmashPigContext, which is awful [18:54:56] or getConfiguration(SmashPigConfiguration::CONFIG_LABEL) [18:55:02] barfish [18:55:32] Or, do your top-level namespace thing, which is much less awful [18:56:14] In that case, we would probably want to initialize config from multiple places, which boggles my mind [18:56:44] An entry point like the orphan rectifier would say SmashPigConfiguration::load, DonationInterfaceCOnfiguration::load [18:59:44] https://github.com/hassankhan/config [19:00:19] +1 library [19:01:05] cwd: It doesn't solve any of our singleton woes tho [19:01:44] what's the problem there? [19:02:44] So what does Context::get()->getConfiguration return? [19:02:49] SP config, or DI config? [19:06:31] oh right [19:06:35] does it have to be a singleton? [19:06:40] I don't think a SmashPigConfiguration consumer ever needs to see DI keys, and vice versa... [19:06:46] certainly doesn't have to be [19:07:02] But managing statics is not fun [19:10:18] I'm leaning towards getting rid of Configuration::getDefaultConfig and using Context as the only container for globals. Maybe we do have a DiContext [19:10:47] sorry my internet keeps crapping out [19:11:35] can DI just feed it information rather than extend the class? [19:12:15] Maybe--do you agree that DI should never need to access a SmashPig config variable directly? [19:15:52] yeah definitely [19:16:29] sorry crazy network problems [19:16:31] How would we get DI config out of a shared Context? [19:16:36] no worries, I don't even notice [19:16:54] My brain often shuts off for longer than yr internet, anyway :p [19:17:01] hehe [19:17:11] i'm tethered to my phone now which is weirdly usable [19:17:25] *EFFbomb*. I accidentally typed a Lenny Kravitz song title into Spotify and now it's all over the recommendations [19:18:32] I need to -1 the hell out of all that... [19:19:05] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2602587 (Eileenmcnaughton) the issue appears to be mis-setting of the n... [19:19:13] what about a singleton per configuration? [19:19:24] just a slightly more complicated factory method [19:19:53] I'm like 10% inclined to keep the thing where Context contains all the globals stuff... [19:20:25] does that mean 90% disinclined? [19:20:41] hehe [19:20:45] 90% meh [19:21:32] Darn, we'll lose the Logger::info signature with any of these schemes [19:21:41] How will Logger know if it's in the SP or the DI context [19:22:30] I gotta look at the recurring Ingenico fail for a minute... [19:23:26] Nice to have this sort of problem though, having enough elbow room to invent code utopia rather than just reactive pissing-out of fires [19:24:33] i don't think it should have to? [19:25:03] isn't that what dependency injection/inversion of control is about? [19:25:09] +1. That would be a nice consequence of sharing the context--we could in theory report all the different configs that were loaded [19:25:15] cwd hey sorry taking longer than I thought to get to that cafe.... [19:25:27] yeah [19:25:43] config should be provided with everything it needs by the things that implement it [19:26:07] Ooh, note for later--we have a problem logging from Configuration before it's finished loading, however, we could log the file paths we used *after* loading is completed. [19:26:15] That would be courteous. [19:26:57] AndyRussG: no worries! [19:27:12] if you have any thoughts about global configuration please add them! [19:29:09] (cwd: I'll add our notes from here into the fr-tech-talk etherpad) [19:29:36] thanks! [19:29:47] i was going to get the run down of the geoip thing from AndyRussG [19:30:37] awight: the app could provide configuration a key under which to store its config [19:31:01] it could also provide callbacks for stuff that needs extra treatment [19:31:29] cwd: yeah that's working for me. We'll see about the callbacks--for now I think it's just pulling an app-specific config file search path [19:31:52] cool yeah, as much static config as possible seems good [19:32:13] controllers can mash up the data [19:33:22] cwd: Next week maybe, I'll pick your brain about this Configuration vs. gateway/config [19:33:40] It would be perfect if we could e.g. disable a payment method via /etc/fundraising [19:33:41] i'm a great source of opinions [19:33:48] fr-tech in the tech talk now! [19:33:54] does that mean you also have many... j/k [19:34:01] :) [19:41:09] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2602703 (awight) @MBeat33 Can I help provide lists of affected subscri... [19:46:32] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2602756 (MBeat33) totally! I was just pinging @Eileenmcnaughton about t... [19:48:21] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi upgrade causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2602759 (Eileenmcnaughton) Actually, this started bang on the start of... [20:03:31] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2598179 (DStrine) [20:15:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Hovercards (2016-Q2-Goal): Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2602930 (MBinder_WMF) [20:34:46] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2603089 (Eileenmcnaughton) [21:11:08] awight: i'm imagining this class that just stuffs a query string in to redis [21:11:24] but it keeps disappearing [21:12:31] and if we wanted to test that procedure it seems pretty moot too. can we put some data from a file into a fake db doesn't effectively test if we can parse a request and put it in redis [21:15:18] (PS1) Eileen: Fix the 8 contributions which would still re-try based on date bug. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308027 (https://phabricator.wikimedia.org/T144489) [21:15:52] awight: from what I can tell the only contributions that would still try to re-run too soon are the 8 that failed [21:16:00] the others were re-processed .... [21:25:07] eileen: I think that's right, cos the status is back to Completed [21:25:56] awight: well I put the sql to fix those 8 into gerrit & the comments have some queries [21:26:02] Nice work debugging, btw! I hope we can write a unit test as a bulwark against regression, too [21:26:09] I think if we fix them then we can turn the job back on [21:26:56] I still felt a bit like a flounder yesterday when Jeff first noted the errors [21:26:57] Cool! Want me to do that while I'm in there, or u already have something cued up? [21:27:32] Wish I'd been around... Thanks though, I had a fun time at my wife's final donor appreciation event at her work [21:27:41] & me and Mari went to a park during the daytime :D [21:27:41] awight: ie. while you are on live run the sql - sure - I put it in an upgrade script but you can just run if you want [21:27:55] ok sure [21:27:59] yeah I think it wouldn't have actually made a difference if you had been around [21:28:19] ie. Jeff first noticed the problem quite a while later [21:28:54] wow, nice docstring! [21:28:58] and the numbers in his email were already most of them [21:32:06] (CR) Awight: [C: 2 V: 1] "Confirmed that this will change the correct 8 subscriptions." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308027 (https://phabricator.wikimedia.org/T144489) (owner: Eileen) [21:38:25] (Merged) jenkins-bot: Fix the 8 contributions which would still re-try based on date bug. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308027 (https://phabricator.wikimedia.org/T144489) (owner: Eileen) [21:43:05] (PS1) Awight: Fix the 8 contributions which would still re-try based on date bug. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/308072 (https://phabricator.wikimedia.org/T144489) [21:43:20] (CR) Awight: [C: 2] Fix the 8 contributions which would still re-try based on date bug. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/308072 (https://phabricator.wikimedia.org/T144489) (owner: Awight) [21:46:07] awight: i want to say ejegg told me paypal recurring is 100% on their end? [21:46:50] (Merged) jenkins-bot: Fix the 8 contributions which would still re-try based on date bug. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/308072 (https://phabricator.wikimedia.org/T144489) (owner: Awight) [21:53:21] cwd: yessir, for now at least. Express Checkout shifts it onto us, at least in the integration we want to make [21:54:55] awight: now i feel like there doesn't have to be a listener class at all [21:55:05] if we are just storing the query string in redis [21:55:56] there could be a small consumer class that transforms and writes to redis [21:56:21] redis/completed [21:56:36] That's all we're doing, but in stage 2 [21:56:44] it still needs to call validation [21:56:52] yep [21:56:54] So might as well do that offline [21:56:57] but what is validation? [21:57:01] otherwise we're keeping a socket open, etc [21:57:05] yeah [21:57:09] it's calling the PP api to validate the incoming message [21:57:23] our pp api [21:57:30] hello from downtown Portland! [21:57:32] no the PSP's [21:57:37] sup ejegg [21:57:41] how was the travel? [21:57:48] ejegg: welcome to the land of sunsets [21:58:01] slept through most of it! [21:58:09] nice [21:59:36] !log update fundraising CRM from 0c6bf3813ee0f2e58d5948fc7c000cf20c114841 to 1678e1f52468dae596882a323cfa5365b966d5f0 [21:59:39] awight: ah i see that now, but why do we need to validate what they just sent us? [21:59:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:59:59] cwd: cos we don't have enough guarantees that the information really came from PP [22:00:09] i.e. it's not signed [22:00:36] fair enough [22:00:46] Dear merchant: XHackerX has sent you one million bux. Sincerely, playpal. [22:01:12] whoop I'm rich now [22:01:13] don't we only allow connections from valid ips? [22:01:31] If only we were allowed to counter-hax [22:01:40] send even *more* back atchya [22:01:52] cwd: It's... not nice like that [22:02:40] how come? doens't jeff have most end points on a white list? [22:03:09] !log updating wmf_civicrm schema to 7240 [22:03:10] eileen: ^ [22:03:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:05:55] fr-tech: it's Thursday, i've got an itchy trigger finger, and I'm feeling optomistic. Anyone object to me flipping the payments-init switch? [22:08:01] what. [22:08:04] optomitristic, optimistic, whatever [22:08:11] As long as you're doing it from a zine library [22:08:38] Sorry we didn't get to it, but there were plenty of other piles to clean up :) [22:08:53] hehe, sorry, snooty coffee shop. [22:09:02] it better be [22:09:05] stumptown cold brew on nitro is pretty tasty [22:09:12] O_o [22:09:29] ejegg: I bet my snooty coffee shop is snootier than your snooty coffee shop 8p [22:09:29] I hear you can dumpster beer in P-land [22:09:44] How much is your snooty expresso? [22:09:53] 3 dolla [22:10:01] awight: did you turn the job back on on jenkins? [22:10:02] ooooooooooooh [22:10:05] * AndyRussG goes down in flames [22:10:14] eileen: not yet, I was gonna double-check the rows first [22:10:20] dumpstabeer? I guess with 80 breweries they must overproduce sometimes [22:10:24] Well though taking context into account [22:11:03] eileen: OK they're all fixed, showing Oct 1st next_sched_date [22:11:31] !log reenabling recurring Ingenico job and kicking one-off run [22:11:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:11:50] MBeat: ^ heads-up. Should be harmless, though. [22:12:00] fr-tech hi! it seems I was mistaken about the need to add a promise() call to the geoIP patch. Apparently then() already returns just a Promise, not a Deferred, so the patch is all good and, unless u see something untoward, good for a-merging, I think [22:12:08] ty awight [22:12:23] nice [22:13:45] awight: while you have your head in that space - https://gerrit.wikimedia.org/r/#/c/307912/ is a minor fix I stumbled upon while analysing the messages [22:14:07] Fundraising-Backlog, FR-Paypal: PayPal audit issue: reversals that don't reach Civi - https://phabricator.wikimedia.org/T144555#2603428 (MBeat33) [22:15:09] fr-tech: MBeat: dstrine: The recurring Ingenico job is reenabled and nobody experienced any extra charges during a trial run. Still have to make the refunds, now... [22:15:16] err. /me uses Phabricator [22:15:21] great, thanks for the update [22:15:31] yeah thanks awight [22:16:11] MBeat: I have a list of the refunds to make, but how to get it to you... Can you see my database on the staging server? [22:16:52] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2603454 (awight) @Eileenmcnaughton Do yo... [22:17:06] not sure awight, have a link? or could put it in DS folder on server [22:18:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Write regression test for T144489 - https://phabricator.wikimedia.org/T144557#2603473 (awight) [22:20:48] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2603497 (Eileenmcnaughton) At the moment... [22:21:28] MBeat: this ties in a bit to the discussion we had yesterday - do those manual refunds get into CiviCRM? [22:21:33] (awight ??) [22:21:54] Leanne was saying they were still showing complete, incorrectly [22:22:04] Localsettings change to start -init mirroring is in the repo if anyone wants to eyeball it [22:24:58] eileen, if you mean the refunds from the ‘incorrect currency recurring’ bug, I think they did finally reach Civi. I will test a few [22:25:33] cool [22:25:40] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/308083 [22:26:05] deploying payments-init mirroring settings patch... [22:30:46] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/308083 (owner: Ejegg) [22:31:27] !log updated paymentswiki settings from 393944f179b6823f27dc1a9430b4a3661388ccff to 18451935c65f711e5c50794211a05309fd903a40 [22:31:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:33:38] fr-tech: 30 min before evening SWAT if we'd like to push out GeoIP... [22:34:03] Sorry to pressure on this one!!! [22:34:27] * cwd is scared of that +2 button [22:34:49] eileen: i take it back, Leanne! 5461274261, 4870875408, 6166500688 all manually refunded Aug 8, but not in Civi yet [22:34:55] not because of the code mind you [22:35:00] i just don't know enough about it [22:35:22] cwd: I totally know the feeling.... [22:35:50] Well if you have read it and don't see anything odd, that's certainly a help, whether or not u want to +2 [22:35:58] ok, payments-init is happening in redis [22:36:05] ejegg: wooo! [22:36:06] (writing, that is) [22:36:11] not reading yet [22:36:25] AndyRussG: I need to prioritize the double-charge bug ATM, sorry if the deployment window vanishes in the meantime! [22:36:29] !log disabled fredge queue consumer [22:36:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:36:43] awight: np :) [22:36:58] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/308083 (owner: Ejegg) [22:37:11] cwd: my qualms about +2ing payments stuff is that I don't understand the overall context enuf, so even if the specific code looks sane, I don't know how it interacts with the larger system [22:38:53] !log updated civicrm from 1678e1f52468dae596882a323cfa5365b966d5f0 to 7484c9085209b83850d0802da8beea74dc594749 [22:38:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:40:12] Dunno if your uncertainty in this case is similar.... In any case, I think the overall effect of the change (not doing GeoIP lookup unless configured) is pretty clearly approved [22:41:01] While we're leaning on people for CR: ejegg: Got a second to look at this one-liner for Adyen? https://gerrit.wikimedia.org/r/#/c/307990/ [22:41:08] I wanted to get that out today as well. [22:41:14] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2603573 (awight) ``` create table awight.... [22:41:30] sure, just as soon as i turn -init back on! [22:41:39] Cool, thanks [22:45:27] AndyRussG: sorry more network problems [22:45:30] !log enabled fredge queue consumer [22:45:32] but yeah that's basically how i feel [22:45:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:45:48] but if you feel that it's ready i'll press the button. everything i saw looks sane [22:46:38] cwd: np! K... hmmm I don't know if I feel good about pressuring much!! Also apologies for not checking the promise issue earlier today 8p [22:46:44] (CR) Ejegg: [C: 2] Reenable AmEx on Adyen form for France. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307990 (https://phabricator.wikimedia.org/T144236) (owner: XenoRyet) [22:46:52] Thanks! [22:46:58] no problem! [22:47:09] I'm not stepping on your toes if I deploy that right now, am I? [22:47:09] cwd: maybe if u have time now I might suggest give it another once-over and ping w/ any questions u have? [22:47:39] XenoRyet: nope, no interference at all [22:47:53] Cool, imma do that then. [22:48:04] sure yeah looking at it now. more just intimidated at the comments and questions on here i wouldn't have known to ask [22:48:36] In theory we probably should miss this SWAT deploy window anyway, since we won't really have much significant testing on the beta cluster... Though I suppose we could kick the Jenkins browser tests.... [22:49:37] cwd: ah right... mmm well the suggestions about promises were also new to me [22:50:58] (Merged) jenkins-bot: Reenable AmEx on Adyen form for France. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307990 (https://phabricator.wikimedia.org/T144236) (owner: XenoRyet) [22:51:29] Really I learned a lot doing that one [22:51:52] promises are really neat, but confusing [22:53:41] sweet, -init switchover looks hitch-free! [22:54:23] (PS1) XenoRyet: Reenable AmEx on Adyen form for France. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/308089 (https://phabricator.wikimedia.org/T144236) [22:55:10] (CR) XenoRyet: [C: 2] Reenable AmEx on Adyen form for France. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/308089 (https://phabricator.wikimedia.org/T144236) (owner: XenoRyet) [22:55:46] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2603637 (awight) ``` mysql awight -B -e '... [22:56:34] cwd: for sure! Yeah it took me a while to get used to even the non-chaining usage... [22:57:09] cwd: oops, I was vpnned there. [22:57:21] This is wartly, but ./Core/Actions/IncomingMessage.php [22:57:25] (Merged) jenkins-bot: Reenable AmEx on Adyen form for France. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/308089 (https://phabricator.wikimedia.org/T144236) (owner: XenoRyet) [22:57:34] i.e. parent::execute [22:57:39] Basically they're an event contained in an object you can have right away. The event may have already occurred or may be in the future, you're not supposed to care [22:58:12] yeah [22:58:28] but here's a callback to execute when ready [22:58:49] So you attach handlers that may execute almost immediately (as soon as your presently-running releases control back to the browser) or whenever the event happens, if it hasn't happened yet [22:59:07] Yeah if the promise has already resolved, ready means now, or ASAP [23:00:40] (PS1) XenoRyet: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/308090 [23:02:50] Fundraising-Backlog, FR-Paypal, MediaWiki-extensions-DonationInterface: PayPal's payments-init messages are inaccurate - https://phabricator.wikimedia.org/T144562#2603649 (Ejegg) [23:03:39] k, 10 straight fredge runs without a hiccup [23:05:15] (Merged) jenkins-bot: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/308090 (owner: XenoRyet) [23:07:13] ejegg: Hi five! [23:07:47] i'mma declare victory and get back to exploring pdx [23:08:10] awesome, tag the place up! [23:08:19] u need a shipment of WP stickers? [23:09:18] heh, brought a few with [23:09:34] i bet i know someone in town with a stash [23:10:11] speaking of stash, it was pretty surreal to bike past a recreation mj shop in the US [23:10:43] anyway... see y'all tomorrow, unless stuff blows up! [23:10:48] * cwd misses CO [23:13:48] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface: Store API call log - https://phabricator.wikimedia.org/T144564#2603697 (awight) [23:14:05] Colorado? [23:15:08] !log updated payments-wiki from ef2f2f85461d25a3938c173d0116fa0d2dee58d1 to fafb6b476da3239039780b86d4b8f8d91bb54faa [23:15:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:21:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Batch refund recurring donations in Civi - https://phabricator.wikimedia.org/T91695#1093499 (awight) There's some predecessor work that needs to be done, to pass the country, payment submethod, and merchant reference ID forward... [23:25:12] cwd: https://jsfiddle.net/sgra31rr/1/ [23:27:21] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2603737 (MBeat33) Thanks @awight that loo... [23:27:58] https://jsfiddle.net/sgra31rr [23:28:29] https://jsfiddle.net/sgra31rr/3/ [23:32:36] nice [23:34:29] The difference between Deferred and Promise is that Promise has a more limited interface so it's more appropriate for passing around [23:35:45] If you return a Promise from a public API the calling code can add handlers, but can't control when and how the promise is resolved [23:35:55] That sounds almost like a passage from Paradise Lost [23:36:29] Paradise Promised? vs Paradise Deferred? [23:36:41] man [23:36:50] Paradise Deferred could be the story of js [23:37:05] vs Paradise Imposed, the story of Java [23:37:11] hehe [23:37:30] or Paradise Hallucinated, the story of Python [23:38:01] or Paradise Scrawled Upon by Newbies, the story of PHP [23:38:50] or Paradise Described Using Inscrutable Mathematics, the story of Haskell [23:41:08] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2603764 (XenoRyet) @DStrine This is deployed now, and looking good. [23:44:36] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Reenable Amex on France Adyen form - https://phabricator.wikimedia.org/T144236#2603765 (DStrine) I can confirm that as well. thanks! [23:44:46] well we are going out to dinner, but i will be back on later [23:46:28] cwd|afk: cya!