[00:58:13] (PS1) Awight: Make refund "country" argument optional [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308114 (https://phabricator.wikimedia.org/T144489) [00:58:22] fr-tech: If anyone's still around for fun CR, ^ [00:59:38] awight: I could look in 1 hr about, mebbe less..... [01:01:04] No rush, it turns out things are more borken than I'd thought [01:05:22] (CR) Awight: [C: -1] "Things are weirder than I thought. I don't understand why we supply merchantreference, and it seems we do need attempt_id." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308114 (https://phabricator.wikimedia.org/T144489) (owner: Awight) [01:46:37] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2604052 (awight) ``` # Snip base transact... [02:07:41] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2604057 (awight) ``` # Columns formatted... [02:12:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Make it easy to pull data for bulk refunds - https://phabricator.wikimedia.org/T144570#2604059 (awight) [02:57:41] !log Began bulk refund for T144489 [02:57:42] T144489: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489 [02:57:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [03:01:41] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: Provide a sudo wrapper for running DonationInterface maintenance scripts - https://phabricator.wikimedia.org/T144572#2604090 (awight) [03:06:19] (PS2) Awight: Refund "country" argument is option, omit it [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308114 (https://phabricator.wikimedia.org/T144489) [03:06:34] awight: still need that CR? [03:06:59] ejegg: I'm cheating it out... [03:07:22] I rsynced the production MW dir to my home/... the rest is (undocumented) history ;) [03:07:50] But if you like, yeah https://gerrit.wikimedia.org/r/308114 needs a little holy water and sage [03:07:54] bold [03:08:05] hehe [03:08:27] On the bright side, the script is syslogging like a champ, really looks like the real thing 8) [03:09:01] excellent [03:09:48] I kind of think it's appropriate that we have a small hammer that can break the plexiglas seal over all the ops side of deployment [03:09:52] O_o [03:11:18] (CR) Ejegg: [C: 2] "Huh, "Required for orders that do not exist yet in WebCollect". What else would we be refunding?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308114 (https://phabricator.wikimedia.org/T144489) (owner: Awight) [03:11:47] (CR) Awight: "Quite the fine print!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308114 (https://phabricator.wikimedia.org/T144489) (owner: Awight) [03:12:40] (Merged) jenkins-bot: Refund "country" argument is option, omit it [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308114 (https://phabricator.wikimedia.org/T144489) (owner: Awight) [03:12:49] cwd: I should say though, the real thing I was working around were some /var/* config settings in LocalSettings.php, which gave me MEdiaWiki permission errors [03:13:55] ejegg: And. dude. That refund process is a beest [03:15:59] awight you mean parsing out those references? [03:16:07] ooh, and effort IDs [03:18:10] Gonna let that script coast along... [03:18:37] suppose I'll sign off too. g'night! [03:19:33] see ya! [03:20:00] not talking smack, great to see timely refunds [04:01:19] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, and 2 others: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2604151 (awight) All 1,294 refunds were successful. [04:09:04] (PS1) AndyRussG: Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) [04:09:58] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2604156 (AndyRussG) a:AndyRussG [04:10:58] (CR) jenkins-bot: [V: -1] Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [14:57:10] (CR) AndyRussG: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [15:17:20] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, and 2 others: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2605073 (awight) @MBeat33 Strange. At the end of the... [15:40:18] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, and 2 others: Date bug on Aug 31st causing recurring Ingenico donations to process in error - https://phabricator.wikimedia.org/T144489#2605138 (MBeat33) thanks @awight I refunded these 5 pr... [15:56:32] (PS2) AndyRussG: Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) [16:35:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615#2605284 (AndyRussG) [16:37:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: unit tests - https://phabricator.wikimedia.org/T144456#2605299 (AndyRussG) [16:37:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#2605300 (AndyRussG) [16:37:42] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: implement feature for MVP - https://phabricator.wikimedia.org/T144453#2605301 (AndyRussG) [16:37:45] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: more precise, new UI mock-up - https://phabricator.wikimedia.org/T144452#2605302 (AndyRussG) [16:37:48] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2605303 (AndyRussG) [16:37:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615#2605298 (AndyRussG) [16:39:23] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2297497 (AndyRussG) Here are the notes we have for an MVP. I don't k... [16:44:00] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, and 2 others: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2605321 (DStrine) [16:44:37] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, and 2 others: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2297497 (DStrine) This is fine to resolve. Thanks for working th... [16:44:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615#2605325 (DStrine) [16:44:47] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, and 2 others: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2605324 (DStrine) Open>Resolved [16:49:11] fr-tech relevant: http://xkcd.com/1728/ [16:50:08] Qwerty thwacking! I love it! [16:52:16] one of our finest fer sure :) [16:52:53] ejegg: how did your move go? [16:53:25] the exit was pretty frantic [16:53:50] I spent way too long when I started packing trying to put every last tiny ting somewhere useful [16:54:21] ejegg: welcome back! [16:54:44] by the end I was just tossing stuff into random boxes and accepting that I'd have to stash 'em at my folks' place and triage sometime down the road [16:55:05] ejegg: we all have those Misc. boxes [16:55:31] When I just moved I found the misc. box from my last move... and just moved it again :( [16:55:40] but I did get rid of a huge amount of old computer stuff. An artist that uses circuit boards took my scsi cards, ISA graphics cards, 3-d cards with less oomph than an old smartphone, modem cards, etc [16:55:52] cool! [16:56:28] and the print shop at somerville's version of nimby took my old parallel port printer that uses separate cmyk ribbons - great for tshirt transfers, stickers that don't run, etc [16:57:59] ejegg: cwd MBeat MG see the bad Japanese charges (from a few days ago) in their reports in Civi. Is there a way to mark them as refunded or canceled? [16:59:19] I forget who was helping address that. I'm just asking those online. I can also ask Adam on Monday [16:59:39] dstrine: more bad Japanese charges? [16:59:48] is there a task? [16:59:53] Was this a regression on the yen / cents thing? [17:00:06] no the ones that were incorrectly charged a while back [17:00:08] yeah [17:00:17] yen/cent thing [17:00:34] It seems they look "completed" in civi [17:00:37] so the refunds never got imported? [17:00:48] should be fine to mark them refunded manually [17:02:12] I can show you the report where they are showing up. How many were there? is it a huge process to do it manually? [17:02:37] Weren't there only 3 or 4? Pretty sure it was just testers [17:02:43] should be a simple processess [17:02:47] esssss [17:03:17] lol thanks [17:24:24] (PS1) Ejegg: Set order_id earlier for paypal legacy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308201 (https://phabricator.wikimedia.org/T144562) [17:24:48] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-Paypal, MediaWiki-extensions-DonationInterface, Patch-For-Review: PayPal's payments-init messages are inaccurate - https://phabricator.wikimedia.org/T144562#2605452 (Ejegg) [17:58:52] Fundraising-Backlog, FR-Amazon, Spike: Spike: Review Amazon settlement process & API - https://phabricator.wikimedia.org/T144241#2605498 (MBeat33) Turns out Amazon does send a message to donors whose donations are suspended: // Your donation to Wikimedia Foundation failed as the payment method you s... [18:06:07] (CR) XenoRyet: [C: 2] Set order_id earlier for paypal legacy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308201 (https://phabricator.wikimedia.org/T144562) (owner: Ejegg) [18:07:35] (Merged) jenkins-bot: Set order_id earlier for paypal legacy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308201 (https://phabricator.wikimedia.org/T144562) (owner: Ejegg) [19:05:10] AndyRussG: I'm getting 'require() is not defined' if I try to use the background lookup module [19:05:17] am I setting something up wrong? [19:06:32] (PS10) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [19:08:54] I've pulled down the latest version of core [19:14:41] ejegg: huh [19:14:49] Maybe did you do composer update? [19:15:09] (on core) [19:15:53] Maybe clear browser cache since updating core? Empty LocalStorage module cache? [19:19:42] k, let me try those things [19:24:06] AndyRussG: ooh, it only happens with debug=true :( [19:24:21] do you need to declare some dependency? [19:30:14] ejegg: ah no... debug=true is brokn :p [19:31:12] fr-tech I may be a few late to standup, apologies in advance!! [19:33:21] AndyRussG|brb: I think I found the fix! [19:39:42] (CR) Ejegg: [C: -1] "Loving the promise stuff! See inline for debug=true fix." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [19:48:44] (CR) Ejegg: [C: 1] "woohoo! It works. I notice silverpop_export has its own requirements.txt file though. Maybe this one should be in the queue dir?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [20:09:35] (PS5) XenoRyet: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) [20:15:36] (CR) Ejegg: [C: 2] "Bam!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [20:15:42] (Merged) jenkins-bot: Make PayPal audit mirror to Redis [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/307433 (https://phabricator.wikimedia.org/T130308) (owner: XenoRyet) [21:10:12] (CR) Ejegg: [C: 1] "Looks correct, minor question and comment" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [21:11:01] (PS2) Ejegg: Fix log messag to count correct variable. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307912 (owner: Eileen) [21:11:17] (CR) Ejegg: [C: 2] "Good catch!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307912 (owner: Eileen) [21:14:30] (Merged) jenkins-bot: Fix log messag to count correct variable. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307912 (owner: Eileen) [21:21:18] (CR) Ejegg: "Wow, that's pretty radically different! In this design, what would the web entry point look like? Would each listener have its own?" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [21:24:31] (CR) Ejegg: [C: -2] "done in a different patch, pls abandon" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301398 (owner: Awight) [21:25:30] (PS3) Ejegg: Remove WorldPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300707 (owner: Awight) [21:26:39] (PS7) Ejegg: Don't be nice about missing contribution_tracking_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304116 (owner: Awight) [21:28:12] (CR) jenkins-bot: [V: -1] Don't be nice about missing contribution_tracking_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/304116 (owner: Awight) [21:35:59] (CR) Cdentinger: "Nah I think I should probably hijack execute() to do a bunch of the stuff that's in the test now. Want to figure out the best way to do te" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [21:39:55] gotta run some errands [21:46:04] (CR) Ejegg: [C: 2] Remove WorldPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300707 (owner: Awight) [21:48:52] (Merged) jenkins-bot: Remove WorldPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300707 (owner: Awight) [21:56:21] (CR) BBlack: "@EJegg, re "probably not worth worrying too much about the 3rd party lookup API till we get this out of CN":" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [21:59:30] (CR) Ejegg: "@BBlack Oh definitely, I'm not saying we should hold everything till we can coordinate breaking geoIP out. Just saying my minor quibble w" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [22:20:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: fix 'recurring donations by payment method + date range' search - https://phabricator.wikimedia.org/T131094#2606112 (MBeat33) Not sure if it's related, but I'm wondering if recurring donations aren't as easily findable as they might be in general?... [23:17:40] ejegg|afk: hi! thx for the review :) I don't quite get your comments about the cookie storage in the geoIP patch... maybe a misunderstanding? wanna chat about it? [23:24:02] Fundraising-Backlog: Estimate the proportion of people who send us complaints vs are affected by an issue - https://phabricator.wikimedia.org/T120722#2606269 (MBeat33) Two recent datapoints from recurring donation errors: {T142312} 1243 donors affected, 25 tickets in Zendesk: 2% contact rate {T144489} 1303... [23:56:43] Time to go pick up the boy. Have a good weekend everyone!