[00:57:17] (CR) Ejegg: [C: -1] "Core test autodiscovery doesn't seem to be working for 1.27 tests, in CI or locally. Let's wait till payments is on a branch that supports" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307542 (owner: Awight) [01:03:45] (CR) Ejegg: [C: 2] "Looks legit!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [01:16:10] (CR) Ejegg: [C: 1] "Logic looks sound! Minor stylistic nitpick, and AllTests.php deletion is misplaced." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [01:18:37] (PS3) Ejegg: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [01:19:25] (CR) Ejegg: [C: 1] "Looks good to me! You can delete GatewayPage::getCountries entirely." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [01:26:58] (CR) Ejegg: [C: 2] "Cleanly done!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308898 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [01:30:06] (Merged) jenkins-bot: Delete from pending db once the transaction is completed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308898 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [01:44:42] (CR) Ejegg: [C: 1] "Muah-ha-ha, fredge is being drawn into SmashPig's orbit. Logic looks solid, just a few style quibbles." (6 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [04:05:49] (CR) Cdentinger: Don't store payments record if the transaction is finalized (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [04:27:46] (CR) Ejegg: Don't store payments record if the transaction is finalized (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [04:39:23] (PS4) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [04:44:48] (CR) Awight: Delete from pending db once the transaction is completed (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308898 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [04:51:01] (CR) Awight: Don't store payments record if the transaction is finalized (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [06:22:15] (PS5) Awight: Don't store payments record if the transaction is finalized [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) [06:22:17] (PS1) Awight: Helper class for test configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308937 [06:22:19] (PS1) Awight: Helper to clear *Database singletons [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308938 [06:23:40] (CR) Awight: Don't store payments record if the transaction is finalized (6 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [07:19:07] (CR) Awight: "> We're conditionally trusting the QS results in the pre_process, I think so that we can skip the GET_ORDERSTATUS call if the fraud checks" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [07:27:38] (PS2) Awight: Always call antifraud hooks after get_orderstatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) [07:27:40] (PS5) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [07:27:42] (PS8) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [07:27:44] (PS3) Awight: Clean up TestConfiguration defines and globals; use core test autodiscovery [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307542 [07:27:46] (CR) Awight: Be less magical about unstaging order status things (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [07:39:40] (PS3) Awight: Always call antifraud hooks after get_orderstatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) [07:39:42] (PS6) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [07:39:43] (PS9) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [07:41:16] (CR) jenkins-bot: [V: -1] Always call antifraud hooks after get_orderstatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [07:41:33] (CR) jenkins-bot: [V: -1] Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [07:41:38] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [13:29:50] (PS13) Paladox: Add composer.json with phplint, also fix two files with incorrect paths [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 [13:30:01] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [13:36:30] (CR) BBlack: "ping!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [14:47:44] (CR) BBlack: "See also T100902#2611800" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [15:58:37] fundraising-tech-ops, Operations, ops-eqiad: rack/setup berryllium replacment - https://phabricator.wikimedia.org/T143902#2615247 (Cmjohnson) Named frauth1001 racked in C1. DNS completed [15:59:04] fundraising-tech-ops, Operations, ops-eqiad: rack/setup berryllium replacment - https://phabricator.wikimedia.org/T143902#2615248 (Cmjohnson) [16:12:49] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1001[2] - https://phabricator.wikimedia.org/T143900#2615295 (Cmjohnson) [16:19:32] Fundraising-Backlog: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615300 (spatton) [16:55:21] AndyRussG: looks like we got another example of a banner not showing in fun and interesting ways: https://phabricator.wikimedia.org/T144952 [16:56:08] Let me know if that provides any hints or is a separate issue [17:06:32] dstrine: K looking... [17:06:46] We are just waiting for CR on the patch to fix the suspected issue from the other time... [17:07:36] ok cool. Thanks for looking [17:13:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615518 (Pcoombe) [17:14:53] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615300 (Pcoombe) This banner loads consistently for me now. We had a similar issue with a banner on Japanese Wikipedia yesterday, although it did start working after about... [17:15:33] AndyRussG: the geoip one still? [17:17:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615569 (spatton) Seems to load consistently for me too, now. It was in central notice for approx 1.5 hours before this test went live, so a much longer delay than w/ what we... [17:23:08] cwd: that one still, but this one is another small patch from the same day, adds options for the memached caching of CN choice data [17:23:51] cwd: dstrine: the issue from the other day seems to be unrelated to the one spatton reported today [17:25:58] fr-tech: anyone have news for Scrum of Scrums? [17:26:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615300 (AndyRussG) @spatton thanks! The banner loads fine every time for me with the preview link--the times you said it didn't load, I assume you meant it didn't load norma... [17:26:08] Nope [17:26:18] fr-tech: Jumping into the tech talk if anyone is interested [17:26:28] ejegg: thx, not that I know of... [17:29:41] awight: be there in a sec [17:30:52] AndyRussG: https://gerrit.wikimedia.org/r/#/c/308898/ [17:31:07] https://gerrit.wikimedia.org/r/#/c/308938/ [17:31:43] awight: I'll ping scrum O scrums on your integration/config patches [17:32:09] https://gerrit.wikimedia.org/r/#/c/308788/5 [17:32:29] ejegg: Actually, Paladox has some improved patches waiting for our/integration team review [17:33:20] ah, so ball is in our court now? [17:36:52] AndyRussG: thanks for looking into that. Let's discuss more at standup [17:47:28] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner sequence: more precise, new UI mock-up - https://phabricator.wikimedia.org/T144452#2600221 (DStrine) new ui starting on page 10 https://docs.google.com/document/d/1YlNwpFZ4gPyO1BYxYRE81... [17:47:50] AndyRussG: let me know what you think of the new ui: https://phabricator.wikimedia.org/T144452 [17:48:50] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615887 (Pcoombe) @AndyRussG It seems to be some kind of issue loading the *content* of the banner For the Japan banner mentioned above it didn't work on preview. Just got th... [18:05:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi should suggest records to bulk merge - https://phabricator.wikimedia.org/T144980#2615998 (DStrine) [18:15:41] XenoRyet: want to pick up where we left off yesterday? [18:15:56] Still in tech-talk, but sure. [18:16:15] ah, I'll join that [18:16:21] cool [18:20:50] (CR) Awight: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [18:24:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2616162 (LeanneS) @dstrine and @Eileenmcnaughton Confirming that we are still unable to edit activities. The prompt continues to pop up. [18:49:03] (PS2) Ejegg: WIP Get donation queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) [18:55:04] CI now happy w/ the CN memcache Gerrit pash [18:55:36] whew! Those false positives are frustrating [18:59:20] AndyRussG: Is it still true that CentralNotice doesn't automatically assign users to buckets C+D? [19:05:45] awight: correct. If there are => 2 buckets it only randomly chooses A or B, regardless [19:06:01] k. I'm reading through https://docs.google.com/document/d/1YlNwpFZ4gPyO1BYxYRE81F6n0KHeB0itfwVnLcbB1EA/edit ... [19:06:23] (why is that private?) [19:11:44] (PS3) Ejegg: Move donation queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) [19:12:13] O_o [19:12:30] Anchors aweigh! [19:13:28] http://nightflight.com/wp-content/uploads/CRIMSON-PERMANENT-ASSURANCE-11.jpg [19:15:45] XenoRyet: Want me to deploy T130308 btw? [19:15:46] T130308: Python fundraising-tools queue module should be abstracted and support Redis - https://phabricator.wikimedia.org/T130308 [19:15:58] Yea, that'd be great. [19:16:02] * awight pats stashbot [19:16:04] kk [19:16:07] love stashbot [19:18:37] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/309074 [19:18:46] (CR) Awight: [C: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/309074 (owner: Awight) [19:18:52] (Merged) jenkins-bot: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/309074 (owner: Awight) [19:36:59] (PS1) Awight: Flesh out required modules for all projects in this repo [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309080 [19:42:12] Argh, this WFMU show is great. We should combine it with our standup, somehow... [19:45:40] Fundraising-Backlog, fundraising-tech-ops: Share Fundraising disaster protocol with all of ops - https://phabricator.wikimedia.org/T121941#2616416 (Jgreen) There are only a couple of Tech Ops folks who are willing/interested to dedicate the time for frack credentials and familiarity to be able to functio... [19:48:09] AndyRussG: hi! stealth standup happening now... [19:48:14] AndyRussG: AndyRussG AndyRussG [19:48:35] I'm not sure if that works... chicken bones are oriented correctly? [19:49:15] * dstrine inspects runes [19:51:46] !log update fundraising-tools from b3ed7ab3deac94c4e465d3768109bca05b6f0a0c to b71c504835454572ff70e48297c38b6ca3cbaece [19:51:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:00:55] Fundraising-Backlog, FR-Ingenico: Switching card types causes "No processors available" message on donation form - https://phabricator.wikimedia.org/T144870#2616486 (DStrine) p:Triage>Normal [20:02:32] Fundraising-Backlog, FR-Ingenico: Switching card types causes "No processors available" message on donation form - https://phabricator.wikimedia.org/T144870#2613065 (awight) Yes, there's a limit... if you do it a few times (donno the exact number), you'll go over the maximum number of API calls from your... [20:03:09] Fundraising-Backlog, FR-Ingenico: Duplicate Ingenico iframe bug - https://phabricator.wikimedia.org/T143430#2616499 (DStrine) a:spatton [20:08:32] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Finish Ingenico listener - https://phabricator.wikimedia.org/T143301#2563531 (Ejegg) For starters, let's just make the empty thing log what it hears [20:12:39] Fundraising-Backlog, FR-Adyen, FR-Ingenico, MediaWiki-extensions-DonationInterface: Redirect loop when processor is disabled. - https://phabricator.wikimedia.org/T140314#2616550 (DStrine) p:Triage>Normal [20:23:24] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike: Spike: How can we run the orphan slayer on a box with normal front-end configuration? - https://phabricator.wikimedia.org/T92924#2616598 (Ejegg) Open>declined [20:23:47] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1843133 (DStrine) @MBeat33 fr-tech is thinking that this is on the ingenico side. C... [20:25:17] Fundraising-Backlog, FR-Ingenico, Spike: Spike: do we need to make updates for Ingenico accessibility changes? - https://phabricator.wikimedia.org/T130061#2616608 (awight) [20:25:27] Fundraising-Backlog, FR-Ingenico, Accessibility, Spike: Spike: do we need to make updates for Ingenico accessibility changes? - https://phabricator.wikimedia.org/T130061#2124122 (awight) [20:30:34] Fundraising-Backlog, FR-Ingenico: Multiple gateway transaction IDs with the same merchant ref - https://phabricator.wikimedia.org/T131212#2159511 (awight) Are these for the same amount? All we can come up with is that they double-submitted the iframe? [20:31:40] Fundraising-Backlog, FR-Ingenico: Multiple gateway transaction IDs with the same merchant ref - https://phabricator.wikimedia.org/T131212#2616662 (DStrine) Open>Resolved [20:33:48] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, FR-Ingenico: Refund not matching original amount--GC original may have been imported incorrectly - https://phabricator.wikimedia.org/T123404#2616666 (DStrine) Open>declined [20:34:44] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico orphan slayer incorrectly cancelling pending transactions - https://phabricator.wikimedia.org/T137905#2616667 (awight) Open>Resolved a:awight Meh. This is going through so many changes, the bugs will all b... [20:35:42] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 5 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2616673 (DStrine) Open>Resolved [20:36:22] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Rewrite Ingenico forms without webitects code - https://phabricator.wikimedia.org/T131821#2616677 (DStrine) Open>Resolved [20:37:42] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Most "Clock at" profiling messages are irrelevant - https://phabricator.wikimedia.org/T120917#2616693 (DStrine) Open>Resolved [20:38:04] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Most "Clock at" profiling messages are irrelevant - https://phabricator.wikimedia.org/T120917#1864722 (DStrine) Resolved>Open [20:40:02] Fundraising-Backlog, FR-Ingenico: GlobalCollect error 430339: INVALID_MERCHANT_OR_SERVICE_PROVIDER - https://phabricator.wikimedia.org/T120728#2616717 (awight) This could be a bad payment method / country / currency combination. Worth investigating why it's happening. [20:50:48] !log Reprocessing 20160906 PayPal audit files [20:50:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:58:55] (PS1) Awight: Add null default to the redis property [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309160 [20:59:26] XenoRyet|food: ^ Maybe this was a python version thing? [21:03:35] !log rollback fundraising-tools from b71c504835454572ff70e48297c38b6ca3cbaece to b3ed7ab3deac94c4e465d3768109bca05b6f0a0c [21:03:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:04:59] (PS2) Awight: Add null default to the `redis` static property. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309160 [21:05:22] (PS3) Awight: Add null default to the `redis` static property. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309160 [21:09:17] (CR) XenoRyet: [C: 2] Add null default to the `redis` static property. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309160 (owner: Awight) [21:10:07] ejegg|food: I'll deploy this, by the time you get back from food... T144562 [21:10:08] T144562: PayPal's payments-init messages are inaccurate - https://phabricator.wikimedia.org/T144562 [21:13:22] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#2616876 (MBeat33) Ingenico checked their logs and concluded it was likely //user err... [21:13:25] (PS1) Awight: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/309167 [21:13:37] (CR) Awight: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/309167 (owner: Awight) [21:14:03] (Merged) jenkins-bot: Add null default to the `redis` static property. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309160 (owner: Awight) [21:14:26] XenoRyet|food: thanks! [21:15:39] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/309168 [21:15:47] (CR) Awight: [C: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/309168 (owner: Awight) [21:17:46] fundraising-tech-ops, Operations: Ensure all disaster recover documentation is in one central location - https://phabricator.wikimedia.org/T95841#2616881 (Jgreen) [21:17:48] Fundraising-Backlog, fundraising-tech-ops: Share Fundraising disaster protocol with all of ops - https://phabricator.wikimedia.org/T121941#2616879 (Jgreen) Open>Resolved I linked the disaster protocol from https://wikitech.wikimedia.org/wiki/Fundraising. [21:18:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/309167 (owner: Awight) [21:18:42] (Merged) jenkins-bot: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/309168 (owner: Awight) [21:21:40] !log update fundraising-tools from b3ed7ab3deac94c4e465d3768109bca05b6f0a0c to b0be0f9ca04191c4bab869bb81191c5c77c432ca [21:21:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:24:49] awight: how does a listener message relate to a job? [21:25:15] cwd: Not saying I'm fond of either of these abstractions, but. [21:25:25] There's one job fired by each listener message [21:25:38] a listener message is the stage 1 input event [21:26:11] job is some serialized and runnable callback with parameters [21:26:20] so a listener gets a request and makes a message, what queue does it save to? [21:26:35] That should be regularized, huh? [21:27:08] if it needs to exist for forensic purposes [21:27:20] we could also just schedule the job from the listener no? [21:27:25] uh, the listener being stage 1, so it saves to a "do something at all with this raw listener input" job [21:28:01] I think ^ we're doing the latter, scheduling the job from the listener, yeah. [21:28:16] seems reasonable place to do some minor parsing [21:28:24] I'd like to avoid even parsing the message, so gleaning its type is starting to look out of scope. [21:28:54] could go to damaged queue if unrecognized type? [21:28:55] No reason to even go that far while still in synchronous communication with the PSP [21:29:36] seems like, the original request will be in the web log [21:29:44] so is it even necessary to save that? [21:30:12] Interesting! [21:30:24] That is basically what we're talking about. [21:31:49] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/309172 [21:32:43] (CR) Awight: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/309172 (owner: Awight) [21:35:19] !log reprocessing 20160906 PayPal audit files, take 2 [21:35:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:36:18] XenoRyet|food: /me blinks. We should have PP audit lines in Redis at this point [21:38:02] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/309172 (owner: Awight) [21:39:11] !log update payments wiki from fafb6b476da3239039780b86d4b8f8d91bb54faa to 996ca30076946c6148d9688a905c82e2e346e165 [21:39:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:41:05] XenoRyet|food: lrange refund 0 -1 - ka-ching! [21:41:28] * awight hi-fives into food [21:41:53] * XenoRyet wipes off high-fived food [21:41:55] ;-) [21:47:57] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Delete from the pending database when a transaction is failed - https://phabricator.wikimedia.org/T143945#2617063 (awight) [21:48:00] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-Paypal, MediaWiki-extensions-DonationInterface, and 2 others: PayPal's payments-init messages are inaccurate - https://phabricator.wikimedia.org/T144562#2603649 (awight) Open>Resolved a:awight Hooray, this is fixed as of ct_... [21:48:51] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 2 others: [Epic] Rewrite all queue clients to use a single shim library, improve library - https://phabricator.wikimedia.org/T133108#2617068 (awight) [21:48:53] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-ActiveMQ, Patch-For-Review: Python fundraising-tools queue module should be abstracted and support Redis - https://phabricator.wikimedia.org/T130308#2132120 (awight) Open>Re... [21:50:17] (PS1) Ejegg: Defaults for more queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/309181 [21:50:41] XenoRyet: that patch ^^^ [21:51:04] plus this vagrant one: https://gerrit.wikimedia.org/r/309179 [21:51:23] should get us all set up to test the whole mirrored pipeline in vagrant [21:51:30] (I think) [21:51:38] Cool. I'll pull them down [21:53:01] ejegg: what does <<: *REDIS mean? [21:53:20] looks like haskell or something [21:53:57] cwd: Dirty trick for http://yaml.org/spec/1.2/spec.html#&%20anchor// [21:54:06] * awight stares at punctuation [21:55:20] yikes! [21:57:53] (CR) Awight: Defaults for more queues (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/309181 (owner: Ejegg) [21:58:09] yeah... took a bunch of trial and error to make that reference stuff work [22:01:09] (CR) Ejegg: Defaults for more queues (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/309181 (owner: Ejegg) [22:01:41] awight and AndyRussG, hey! If either of you are there, I am wondering if something funny is going on with our Japanese campaign. Switched banners an hour ago, but results are barely trickling in... it is early there but I'm suspicious [22:02:33] dstrine: sure! when is a good time for you? Specifically tomorrow, either before normal standup time, or after 2:30 Pacific Time, works best... :) thx :) [22:02:45] spatton: oh no! K what is the campaign? [22:03:13] spatton: oh noes [22:03:19] doesn't look enabled right now..... [22:03:25] AndyRussG: C1617_jaJP_dsk_FR [22:03:40] Ah right yeah I was looking at mobile [22:04:07] :) Yeah! The current banners have been up an hour, I am seeing 0 donations, 0 impressions, 2 clicks - on a single entry. [22:04:43] dstrine: appreciate the sympathy [22:06:12] AndyRussG: should this get tacked onto any current task or should spatton make a new one? [22:07:13] dstrine: hmmm dunno, just doing a first quick check... [22:08:49] dstrine: spatton: I'm getting bannerCanceledReason:"waitdate" in mw.centralNotice.data [22:10:13] spatton: dstrine impression diet is enabled, but it says "Maximum impressions any individual will see: 0" in the UI [22:10:27] https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=C1617_jaJP_dsk_FR [22:10:50] ah [22:11:06] So it seems the campaign is being allocated correctly, but the impression diet is causing the banners not to show [22:11:17] Try opening a private browser window and going here: [22:11:37] Then open the developer tools, go to the browser console [22:12:10] Sorry I mean the JS console [22:12:18] There, enter "mw.centralNotice.data" then hit return [22:12:40] And click on the result to see the full info [22:13:15] You'll see one data property is: campaign:"C1617_jaJP_dsk_FR" [22:13:27] So that means the campaign is correctly allocated [22:14:27] AndyRussG: well, that "Max Impressions = 0" would certainly do it, but ... well, I don't remember changing that setting, and it'd not be part of any of our normal workflow to change it after setting when we first enable the campaign. [22:14:34] I just reset to our typical values [22:14:53] Also noticed that there is no identifier set for the impression diet feature, and the Special:RecordImpression sample rate is way down [22:15:06] Or rather, not set to 1, as usual for FR campaigns [22:15:22] I think all our Impression Diet settings for that campaign got wiped, somehow :-/ [22:15:44] (PS1) Awight: Reuse transactionFinalized logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309190 [22:15:50] l [22:16:00] eh not a terminal? [22:16:19] AndyRussG: can we tell if someone else played with the campaign? [22:17:30] (CR) jenkins-bot: [V: -1] Reuse transactionFinalized logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309190 (owner: Awight) [22:17:48] dstrine: looks like it was some UI problem... I see changes to those settings in log entries from spatton: https://meta.wikimedia.org/w/index.php?title=Special:CentralNoticeLogs&offset=&limit=100 [22:18:19] (PS4) Ejegg: Allow overriding with dissimilar types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 [22:18:24] AndyRussG: dstrine: Yeah, the changes definitely get attributed to me in the log. All I can say is, I have no memory and it'd be very odd to make those changes :) [22:18:46] spatton: yeah something bad with the admin UI... .:( [22:19:30] I saw a couple other little oddities today where a feature with sub options (like "Large banner limit and switch") would be checked, but the additional options would not be visible. I took a couple screenshots, worth sending over? [22:19:31] http://a.memegen.com/d58pff.gif [22:19:48] spatton: a good way to check a campaign is to open a private browser window, go to the actual wiki you expect to see it on, and add ?country=XX to the URL (replacing "XX" with the right country code) [22:19:54] spatton: yes please :) [22:19:57] dstrine: haha, exactly. But campaign history logger calling me out! [22:21:18] Also the above ^ mw.centralNotice.data value in the JS console is often helpful! [22:21:58] AndyRussG: definitely, thanks - that is a great debugging tip! [22:22:09] (CR) Ejegg: "silverpop_export has a requirements.txt with some version numbers. Want to roll those in and zap that file?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/309080 (owner: Awight) [22:24:25] spatton: sure! anytime you'd like more explanations on CN stuff, don't hesitate to LMK :) It's not an especially transparent system, I guess... [22:25:08] I love it [22:25:24] (CR) Awight: Defaults for more queues (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/309181 (owner: Ejegg) [22:25:30] O_o :) [22:25:33] AndyRussG: it's powerful and 99% of the time, pain free! :) [22:25:39] * awight chuckles [22:26:00] spatton: You must be a CentralNotice ninja, in that case :D [22:26:01] (CR) Ejegg: [C: -1] "Looks handy! One undefined var" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308937 (owner: Awight) [22:26:17] ^ yea what awight said :) [22:27:14] fr-tech speaking of CN foibles, anyone feelin' sum CR luv? ;p [22:30:44] (PS2) Awight: Helper class for test configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308937 [22:31:08] (CR) Awight: Helper class for test configuration (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308937 (owner: Awight) [22:33:29] any thoughts on widgets for the banner sequence UI? mebbe https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.ComboBoxInputWidget ? [22:34:57] oo, how nice to use a home town staple! [22:35:04] I'm not getting much from the "live preview", though [22:35:18] (CR) Ejegg: [C: 2] "Looks great! I'd change one thing in isTransactionFinalized for future reuse." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [22:35:25] oh, I see [22:35:31] works with a touchscreen, too! [22:35:48] Is it compatible with autocomplete? [22:35:57] (Merged) jenkins-bot: Don't store payments record if the transaction is finalized [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308788 (https://phabricator.wikimedia.org/T143945) (owner: Awight) [22:36:19] huh, it says autocomplete = true, but not working in my browser. [22:37:26] (CR) Ejegg: [C: 2] Helper class for test configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308937 (owner: Awight) [22:37:30] No console logs :( [22:38:20] (Merged) jenkins-bot: Helper class for test configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308937 (owner: Awight) [22:39:13] (CR) Ejegg: [C: 2] "Does the trick, saves some copypasta" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308938 (owner: Awight) [22:39:18] (PS2) Ejegg: Helper to clear *Database singletons [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/308938 (owner: Awight) [22:39:35] awight: hmmmm yeah no autocomplete for me in FF or chromium, in the sample [22:41:37] (PS5) Ejegg: Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [22:42:30] (CR) Ejegg: [C: 1] "Looks good!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [22:43:02] awight: I don't see any extensions actually using ComboBoxInputWidget :( [22:43:35] ejegg: thanks! Deploying that in a flash... [22:43:49] AndyRussG: haha... 1 favorite [22:44:06] ejegg: thx! [22:44:15] you could be the first human to Mars! [22:44:33] Uh oooooooooooooooooooooojs [22:44:40] ;p jk [22:45:03] I'm pretty sure I saw some functionality like that somewhere visualeditorish [22:46:55] (CR) Ejegg: "Just need to remove testGetOrderStatusSkipsIfFail, no longer valid" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:51:46] (CR) Ejegg: [C: 1] "Looks good, though commit message wants an update" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:52:10] oh boy, sunshine outside! relocating... [22:52:20] (PS1) Awight: No longer testGetOrderStatusSkipsIfFail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/309196 (https://phabricator.wikimedia.org/T141487) [22:53:51] spatton: JP campaign looking OK now? [22:53:55] (PS2) Awight: No longer testGetOrderStatusSkipsIfFail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/309196 (https://phabricator.wikimedia.org/T141487) [22:53:57] (PS7) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [22:53:59] (PS10) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [22:54:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Dedupe: resolve Conflicts on capitalisation of names - https://phabricator.wikimedia.org/T145032#2617605 (Eileenmcnaughton) [22:54:13] (CR) Awight: "Fixed the commit message, thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:54:58] AndyRussG: It is! Looking just fine now. [22:55:31] I gotta catch a train but I'll be back on in about an hour [22:55:44] (CR) jenkins-bot: [V: -1] No longer testGetOrderStatusSkipsIfFail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/309196 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [22:55:46] (PS1) Eileen: Resolve conflicts where the name is the same but for lower case vs upper case variation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309198 (https://phabricator.wikimedia.org/T145032) [22:55:49] spatton: I'm glad it's all back! [22:56:13] spatton: cool! \o/ [22:56:17] dstrine-away: have a good trip! [22:56:20] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:05:01] * ejegg|afk is in a giant rose garden [23:06:19] !! [23:06:44] the city is full of em! [23:06:56] guess it's an ideal climate [23:10:18] ... if ye'r out before the big freeze [23:11:22] Fundraising-Backlog, FR-Paypal: PayPal audit issue: reversals that don't reach Civi - https://phabricator.wikimedia.org/T144555#2617680 (MBeat33) @awight the overall volume of reversals initiated by PayPal/the banks is not huge: Spoofs: 221 total from 7/9/15-8/8/16, spot checked 28, 21% not in Civi AFR... [23:11:43] (CR) Awight: [C: -1] "Hmm, looks like a bad interaction with a recent patch?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:12:28] (CR) Ejegg: "the parent patch just needs that obsolete test deleted" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:14:28] (CR) Ejegg: "thanks awight, I put that isMergeable back" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 (owner: Ejegg) [23:15:33] (PS4) Awight: Always call antifraud hooks after get_orderstatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) [23:15:35] (PS8) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [23:15:37] (PS11) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [23:17:15] awight: sorry, i'm about to throw a tiny merge conflict in your path by +2ing paladox's lint patch [23:17:19] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:17:28] (CR) jenkins-bot: [V: -1] Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:18:29] (CR) Awight: [C: 2] "I feel funny that there wasn't a documentation change, too..." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 (owner: Ejegg) [23:18:41] (PS5) Awight: Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 (owner: Ejegg) [23:18:44] ejegg: what calls execute() on a runnable job? [23:18:46] (PS14) Ejegg: Add composer.json with phplint, also fix two files with incorrect paths [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [23:18:50] (PS5) Awight: Allow overriding with dissimilar types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307648 (owner: Ejegg) [23:18:55] (PS6) Awight: Test for RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/307647 (owner: Ejegg) [23:19:11] cwd that's one of the JobRunner maintenance scripts [23:19:37] currently StompJobRunner [23:19:42] but soon QueueJobRunner [23:19:51] so it gets executed when it is pulled off the queue? [23:19:55] (Abandoned) Awight: No longer testGetOrderStatusSkipsIfFail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/309196 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:20:08] or rather the JobQueueConsumer [23:20:23] does that mean the whole execute function gets serialized? [23:20:50] cwd no, just the member vars [23:21:52] There's a 'php-message-class' key in messages we want to reanimate as objects [23:22:14] ejegg: so is it the message that actually gets stored, and the job gets instantiated from the message contents? [23:22:29] We should have a message type table instead. e.g. what if we want to refactor the fully qualified job class name later [23:22:31] yeah, the job is instantiated with KeyedOpaqueStorableObject::fromJsonProxy [23:22:43] awight: I like it [23:22:55] why does a job have to be that storable object thing then? [23:23:03] sounds like it does not get stored? [23:23:42] errr, I guess to pretend that its data + functionality are encapsulated together [23:24:24] Yeah, agreed--if we strip this down to the part that matters, job implements an interface that helps something else serialize it [23:24:33] That seems reasonable, though. [23:25:07] At the end of the day, some class is going to say $job->getStorableData [23:25:21] What if we made that the interface? [23:25:29] but wait, i thought a job didn't store data [23:25:36] it executed based on stored data [23:26:00] And it's also the container used to dump incoming listener messages as runnable jobs [23:26:21] that's not a Message? [23:26:37] Huh, that does seem redundant [23:28:06] RunnableJob extends KeyedOpaqueStorableObject [23:28:49] So, each type of job could be a queue consumer with its own queue. But it's nice to be able to put different types in the same queue for ordering [23:29:00] dstrine-away: awight: regarding the dropdown widget, there's an older version live on-wiki... Try editing a page in visual editor, click on "Insert" then choose "Code block", then type stuff in the Language combo box [23:29:18] I don't see autocomplete happening but otherwise it's pretty smooth [23:29:35] ejegg: what do you mean different types? [23:30:10] like if you had a RecordCapture job that uses pending data, then a DeletePendingJob, you'd want them in that order [23:31:17] hmm, maybe bad example, DeletePendingJob is for failed things where there's not going to be a RecordCapture [23:31:40] it seems like the first one should schedule the 2nd one? [23:31:48] (CR) Awight: "Maybe transactionConfirm_CreditCard regressed? I'll need to pick this up tomorrow..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:34:16] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#2617843 (awight) >>! In T120030#2616876, @MBeat33 wrote: > Given the ungainly screen... [23:35:18] (CR) Ejegg: [C: 2] Add composer.json with phplint, also fix two files with incorrect paths [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [23:35:27] (CR) Ejegg: "Thanks Paladox!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [23:36:49] (Merged) jenkins-bot: Add composer.json with phplint, also fix two files with incorrect paths [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [23:38:24] Gotta family, I'll be back later [23:39:24] (PS5) Ejegg: Always call antifraud hooks after get_orderstatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:40:04] (CR) Ejegg: [C: 2] "Sensible!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:41:21] (Merged) jenkins-bot: Always call antifraud hooks after get_orderstatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/308786 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:47:11] (PS3) Ejegg: Let DI globals come from configuration files. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306575 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:51:32] (PS1) Ejegg: Update .gitignore [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309207 [23:52:14] (CR) Ejegg: [C: 2] "See Ia3827f6c8dd0d for .gitignore update" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306575 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:54:59] ejegg: i notice the queues extend fifodatastore instead of keyedopaquedatastore [23:55:11] and mockdatastore is like the latter [23:55:22] so we don't have much of a test interface for queues right now? [23:55:52] (Merged) jenkins-bot: Let DI globals come from configuration files. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306575 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:57:29] Time to be a schoolbus, catch you folks later. [23:59:21] gotta run for a bit, back soon