[00:09:22] cwd|afk: oh, did we make a fifodatastore? [00:10:25] AndyRussG: do you understand the note about setting the lockTSE to avoid a stampede for 'hot' keys? [00:12:48] in the inline docs for getWithSetCallback [00:14:59] cwd oh right, the phpqueue fifo interface [00:15:35] I like that better, since we can create a 'real' backend for tests with the PDO queue and sqlite memory dbs [00:17:32] ejegg: i guess the only thing writing to queues so far is multiequeuewriter? [00:17:46] writing to redis i mean [00:17:55] ejegg: hey! Mmmm I did semi-notice it in passing, but didn't think about its relevance until awight mentioned the general issue this morning [00:17:58] looking again... [00:18:33] cwd yeah, I figure I'll delete that and push straight to the phpqueue backends once activemq is gone [00:19:05] cool, so for something like i'm making where there is no current implementation in smash pig [00:19:17] can i just write to the phpqueue interface? [00:19:40] cwd I rolled some defaults for recurring in to https://gerrit.wikimedia.org/r/309181 [00:19:51] I assumed we'd want to mirror to both for starters [00:20:17] so we'd be able to roll back [00:20:54] though that does mean you need to push one of those silly storableObject instances instead of a plain array [00:20:56] ejegg: well this is in that listeners repo so it might be hard to mirror... [00:21:41] yeah, i guess we're trusting your code not to drop stuff on the floor, since that's gotta be a hard switchover [00:22:03] the mirroring would be in case the consumer code failed [00:22:19] though those have been pretty smooth cutovers [00:22:53] ah yeah :-\ [00:23:08] luckily these jobs aren't actually charging people money or anything [00:23:15] worst case is some db cleanup [00:23:23] yeah [00:24:06] if you want to write the initial version just pushing to redis, i can take care of the silly storeableObject thing in a follow-on patch [00:25:13] oh hmm, I guess we don't have anything pushing jobs to redis yet [00:26:23] ejegg: if i'm rebuilding the consumer anyway does it even need to be a job? [00:26:36] ejegg: since the patch for adding this level of caching came from our perf colleagues, I've been deferring to them for how to use this layer... I guess I'll ask them about using this, in combination with the other options. [00:26:39] or am i not rebuilding that? [00:27:23] cwd oh, sorry, i was thinking of a different queue [00:27:40] you meant the recurring queue [00:27:47] yeah, those aren't jobs, just messages [00:28:27] I think the rebuild for that will just be wrapping the dequeue_loop callback in a QueueConsumer subclass [00:28:50] *the rebuild for the consumer, that is [00:29:47] i think the queues this will write to are completed, recurring, and refund [00:29:50] does that sound right? [00:31:03] yep [00:40:45] ejegg: what if i removed the stuff from mockdatastore that restricts it to keyedopaqueetc? [00:41:42] you could, but I'd rather wait till the real stuff we're testing doesn't need those instances [00:42:04] that's reasonable [00:42:09] this transition code is a drag, to be sure [00:42:32] it seems like a redis mock is pretty much an array [00:42:44] yeah [00:43:11] oh right, we can get rid of mockdatastore entirely and just use those sqlite pdo backends [00:44:00] oh yeah, neat [00:51:51] (CR) Aaron Schulz: Account for DB lag when refreshing cached ChoiceData (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [00:55:36] ejegg: is there already a 'completed' consumer in SP? [00:56:11] and/or a valid message type description for that consumer? [00:56:54] cwd the 'completed' consumer is in CRM [00:57:01] like the other consumers [00:57:16] oh ok [00:57:17] here's the rebuild: https://gerrit.wikimedia.org/r/308800 [00:58:02] nice. so this just makes donation records in civi and doesn't do anything donor facing right? except maybe an email? [00:58:08] Yep, exactly [00:58:23] righteous [00:58:32] I think it's the 'DonationInterfaceMessage' schema [01:00:43] ah ha! that particular file is not relevant because we are writing to redis right? [01:01:06] but maybe we could tease the schema out [01:02:46] although i see a recurring field in there and was thinking the 3 queues should have different message formats [01:02:52] but maybe not? [01:10:44] cwd oh yeah, the recurring message consumer in CRM basically takes the PayPal message unaltered [01:11:03] and the refund messages generally have no donor info [01:12:57] ejegg: i copied a bunch of normalization from here: https://github.com/wikimedia/wikimedia-fundraising-PaymentsListeners/blob/master/legacy-paypal/PaypalIPNListener.php#L510 [01:13:08] is that changing from the raw paypal message to what crm expects? [01:20:55] (PS21) Ejegg: GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [01:22:57] (PS11) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [01:23:27] (CR) jenkins-bot: [V: -1] WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [01:25:03] (CR) Ejegg: [C: 2] "This is a really elegant cleanup! Thanks for delving into the mysteries of promise chaining. At first I worried that setting window.Geo as" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [01:25:56] cwd yep, that looks like the stuff to copy [01:26:20] though there's a bunch we can prune [01:26:47] ejegg: thx!!! [01:26:53] eg size, _2 fields, premium language [01:27:04] great [01:27:27] AndyRussG: nicely polished! [01:28:06] heh it's been fun! [01:28:47] looks like the fallback service is having its last meal today or tomorrow [01:28:49] (Merged) jenkins-bot: GeoIP: Background lookup optional and configurable, provide data via promise [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [01:29:12] cool! [01:29:35] Let's see how the beta cluster feels about it, then try to deploy tomorrow [01:29:43] sure! [01:29:48] :) [01:30:22] fr-tech got a couple of vagrant patches to help with end-to-end queue cutover tests: https://gerrit.wikimedia.org/r/309179 https://gerrit.wikimedia.org/r/309221 [01:32:54] gotta run but will check it tomorrow [01:33:22] see ya [01:35:25] (CR) Ejegg: [C: -1] "seems like a good idea, just one typo" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307640 (owner: Eileen) [01:39:30] (PS4) Ejegg: Move donation queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) [01:44:47] (PS6) AndyRussG: Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) [01:47:16] (CR) Krinkle: "Suggesting to use CORS where possible in the example module." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/306598 (https://phabricator.wikimedia.org/T143271) (owner: AndyRussG) [01:49:02] ejegg: tl;dr about lockTSE: probably wouldn't hurt but also seems fine without, thanks to Varnish caching. Added an inline comment to that effect [01:49:21] (as per -perf IRC) [01:49:25] AndyRussG: thanks for looking into it! [01:49:32] heh thanks for point it out! [01:49:35] I'll read that backscroll out of curiousity [01:49:45] :) [01:53:20] k, seems safe enough! [01:53:41] (PS7) Ejegg: Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [01:54:02] (CR) Ejegg: [C: 2] "Seems safe, thanks for looking into lockTSE!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [01:54:28] well, i'm going to head out for the evening. have a good one all! [01:55:08] (CR) jenkins-bot: [V: -1] Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [01:55:28] (Merged) jenkins-bot: Account for DB lag when refreshing cached ChoiceData [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/308126 (https://phabricator.wikimedia.org/T144393) (owner: AndyRussG) [02:06:24] ejegg|away: cool! [02:06:32] cya [02:06:40] rrrrg silly qunit CI [02:07:30] (CR) Eileen: Add index to contribution_tracking. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/307640 (owner: Eileen) [14:13:24] Fundraising-Backlog, fundraising-tech-ops, Epic: [Epic] Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2619218 (Jgreen) a:Jgreen>awight @awight I think we're done with this, can you con... [14:14:42] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2619236 (Jgreen) [14:18:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#2619254 (Jgreen) [14:18:46] fundraising-tech-ops, HHVM: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2619252 (Jgreen) Open>stalled if PHP5.5 is good enough, we probably won't get to this [14:20:23] fundraising-tech-ops: payments-payflow* log files can be deprecated - https://phabricator.wikimedia.org/T113309#2619255 (Jgreen) Open>Resolved done [14:21:27] fundraising-tech-ops: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#2619258 (Jgreen) [14:22:18] fundraising-tech-ops: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1088471 (Jgreen) [14:24:10] fundraising-tech-ops: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#2619262 (Jgreen) [14:32:30] (PS12) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [15:33:08] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#2619485 (DStrine) @Ppena considering the last few comments here, is there any way w... [16:23:53] Fundraising-Backlog, FR-Ingenico: Duplicate Ingenico iframe bug - https://phabricator.wikimedia.org/T143430#2567887 (DStrine) @spatton or @MeganHernandez_WMF are you able to reproduce this? [16:41:24] 415 839 6885 x6805 [17:04:45] fr-tech hi! any objections to putting the CN GeoIP and caching patches on this evening's SWAT? 16:00 - 17:00 PDT [17:05:27] None at all. Let's do it! [17:05:35] ejegg: cool thx! [17:06:20] nice [17:06:41] dstrine: I'm not sure at this point if I answered you about meeting sometime today... Maybe I thought I'd answered you but didn't? Anyway maybe grab a time in my calendar? (though maybe not exactly during the deploy :) ) [17:06:46] cwd: yeah! [17:07:04] glad ejegg had the courage to press the button :) [17:07:40] heh, tried to find flaws in it for another hour and couldn't [17:08:08] Mmmm also glad for such persistence & insistence [17:08:23] aka persinsistence [17:08:35] nice portmanteau! [17:09:30] purse-in-cyst-cents [17:32:45] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacment - https://phabricator.wikimedia.org/T143902#2619843 (Jgreen) [17:35:37] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacment - https://phabricator.wikimedia.org/T143902#2619850 (Jgreen) @Cmjohnson I guess for now our only option is to unplug db1008 (which is currently powered off) and install frauth1001 on pfw1 2/0/9. [17:36:59] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacment - https://phabricator.wikimedia.org/T143902#2619852 (Jgreen) [17:37:01] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2619851 (Jgreen) [17:41:26] fr-tech K, CentralNotice deploy set for evening SWAT, 16:00 PDT [17:42:29] nice [17:51:09] fundraising-tech-ops: build two queue servers to replace silicon & aluminium - https://phabricator.wikimedia.org/T137150#2619901 (Jgreen) [17:55:31] fundraising-tech-ops: build two queue servers to replace silicon & aluminium - https://phabricator.wikimedia.org/T137150#2619957 (Jgreen) [17:55:34] fundraising-tech-ops, Operations, ops-eqiad, Patch-For-Review: decommission aluminium, replace it with frqueue1002 - https://phabricator.wikimedia.org/T140676#2619956 (Jgreen) [17:56:24] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2619966 (Jgreen) p:Normal>High [17:56:45] fundraising-tech-ops: build two queue servers to replace silicon & aluminium - https://phabricator.wikimedia.org/T137150#2358871 (Jgreen) [17:56:47] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [18:02:30] fundraising-tech-ops: replace payments1002-1004 with new hardware running debian/jessie - https://phabricator.wikimedia.org/T137299#2620000 (Jgreen) [18:05:58] fundraising-tech-ops: replace silicon & aluminium with new hardware running jessie - https://phabricator.wikimedia.org/T137150#2620023 (Jgreen) [18:07:28] fundraising-tech-ops: replace silicon & aluminium with new hardware running jessie - https://phabricator.wikimedia.org/T137150#2358871 (Jgreen) [18:07:55] fundraising-tech-ops, Operations, ops-eqiad: rack and setup new fundraising queue servers frqueue1001 and frqueue1002 - https://phabricator.wikimedia.org/T136882#2620031 (Jgreen) [18:18:30] fundraising-tech-ops: replace payments1001 with new server running debian/jessie - https://phabricator.wikimedia.org/T137301#2620099 (Jgreen) [18:18:32] fundraising-tech-ops: replace payments1002-1004 with new hardware running debian/jessie - https://phabricator.wikimedia.org/T137299#2620100 (Jgreen) [18:18:34] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2620098 (Jgreen) [18:19:23] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacement - https://phabricator.wikimedia.org/T143902#2620104 (Jgreen) [18:20:51] fundraising-tech-ops: replace beryllium with new hardware running jessie - https://phabricator.wikimedia.org/T145101#2620111 (Jgreen) [18:22:04] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacement frauth1001 - https://phabricator.wikimedia.org/T143902#2620125 (Jgreen) [18:22:57] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacement frauth1001 - https://phabricator.wikimedia.org/T143902#2582606 (Jgreen) [18:22:59] fundraising-tech-ops: replace beryllium with new hardware running jessie - https://phabricator.wikimedia.org/T145101#2620126 (Jgreen) [18:23:13] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacement frauth1001 - https://phabricator.wikimedia.org/T143902#2582606 (Jgreen) [18:23:15] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2620128 (Jgreen) [18:25:07] fundraising-tech-ops: replace pay-lvs1001 & pay-lvs1002 with new hardware running jessie - https://phabricator.wikimedia.org/T145103#2620156 (Jgreen) [18:26:48] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1001 and pay-lvs1002 - https://phabricator.wikimedia.org/T143900#2620174 (Jgreen) [18:28:16] fundraising-tech-ops, Operations, ops-eqiad: rack/setup beryllium replacement frauth1001 - https://phabricator.wikimedia.org/T143902#2620179 (Jgreen) [18:28:19] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1001 and pay-lvs1002 - https://phabricator.wikimedia.org/T143900#2582571 (Jgreen) [18:29:06] fundraising-tech-ops: replace beryllium with new hardware running jessie - https://phabricator.wikimedia.org/T145101#2620184 (Jgreen) [18:29:45] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1001 and pay-lvs1002 - https://phabricator.wikimedia.org/T143900#2620188 (Jgreen) [18:29:47] fundraising-tech-ops: replace pay-lvs1001 & pay-lvs1002 with new hardware running jessie - https://phabricator.wikimedia.org/T145103#2620187 (Jgreen) [18:34:57] (CR) Cdentinger: Move donation queue consumer off ActiveMQ (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) (owner: Ejegg) [18:37:39] fundraising-tech-ops: replace db1008 with new hardware running jessie - https://phabricator.wikimedia.org/T145107#2620249 (Jgreen) [18:40:48] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB frdb1001 - https://phabricator.wikimedia.org/T136200#2620277 (Jgreen) [18:42:43] fundraising-tech-ops: replace db1025 with new hardware running jessie - https://phabricator.wikimedia.org/T145108#2620281 (Jgreen) [18:45:07] fundraising-tech-ops: install OS on frdb1001 - https://phabricator.wikimedia.org/T143245#2620311 (Jgreen) [18:45:10] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB frdb1001 - https://phabricator.wikimedia.org/T136200#2620313 (Jgreen) [18:45:12] fundraising-tech-ops: replace db1025 with new hardware running jessie - https://phabricator.wikimedia.org/T145108#2620308 (Jgreen) [18:46:18] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB frdb1001 - https://phabricator.wikimedia.org/T136200#2326525 (Jgreen) [18:46:20] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2620321 (Jgreen) [18:47:37] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [18:47:39] fundraising-tech-ops: replace db1025 with new hardware running jessie - https://phabricator.wikimedia.org/T145108#2620322 (Jgreen) Open>Resolved frdb1001 up and running, currently as a read-only slave. will promote to master when frdb1002 is installed. [18:48:59] fundraising-tech-ops: replace db1008 with new hardware running jessie - https://phabricator.wikimedia.org/T145107#2620333 (Jgreen) [18:49:26] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2620336 (Jgreen) [18:50:12] fundraising-tech-ops: replace lutetium with new hardware running debian/jessie - https://phabricator.wikimedia.org/T145110#2620339 (Jgreen) [18:50:59] fundraising-tech-ops: replace lutetium with new hardware running debian/jessie - https://phabricator.wikimedia.org/T145110#2620339 (Jgreen) [18:52:21] (CR) Ejegg: "I like the simplification, but we really need to do the verification API call with the raw post values before sending to CiviCRM. Its cons" (13 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:03:17] (CR) Cdentinger: "Gotcha, maybe i'll put validate in front of setmessage and phone home to PP then?" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:12:47] Gonna go sit in that SPARQL workshop for a few. [19:17:12] fundraising-tech-ops: replace db1008 with new hardware running jessie - https://phabricator.wikimedia.org/T145107#2620506 (Jgreen) p:High>Normal [19:17:33] fundraising-tech-ops: replace lutetium with new hardware running debian/jessie - https://phabricator.wikimedia.org/T145110#2620510 (Jgreen) p:High>Normal [19:20:41] fundraising-tech-ops: replace indium (eqiad fundraising logger) with new hardware running jessie - https://phabricator.wikimedia.org/T145116#2620515 (Jgreen) [19:21:05] fundraising-tech-ops: replace indium (eqiad fundraising logger) with new hardware running jessie - https://phabricator.wikimedia.org/T145116#2620515 (Jgreen) [19:21:19] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [19:22:22] fundraising-tech-ops: replace boron (fundraising build server) with new hardware running jessie - https://phabricator.wikimedia.org/T145117#2620535 (Jgreen) [19:22:30] fundraising-tech-ops: replace boron (fundraising build server) with new hardware running jessie - https://phabricator.wikimedia.org/T145117#2620535 (Jgreen) p:High>Normal [19:29:32] (CR) Ejegg: "Good call cwdent" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) (owner: Ejegg) [19:47:29] fr-tech: Hangouts isn't letting me into the standup hangout. That happening to everyone, or just me? [19:47:48] (PS5) Ejegg: Move donation queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) [19:48:16] oops, one sec! [19:50:50] (CR) jenkins-bot: [V: -1] Move donation queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) (owner: Ejegg) [20:11:33] (CR) Ejegg: "Well that CI bug oughtta get noticed fast" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/308800 (https://phabricator.wikimedia.org/T131277) (owner: Ejegg) [21:09:21] (PS1) Ejegg: Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) [21:09:56] fr-tech ^^^ oughtta be simple review, and would help resolve a high priority thing for major gifts [21:10:16] ejegg: ok, taking a look [21:10:17] I'll take a look. [21:10:27] thanks to you both! [21:12:51] (CR) jenkins-bot: [V: -1] Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:13:10] oops, letme just fix that... [21:13:12] (CR) Awight: "> I realized that the stage 1 job wouldn't be capturing anything the web logs don't. Is there another reason to split it into two steps?" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [21:14:41] ejegg: Do we want to do any kind of safety checking that it's the right contribution ID? [21:15:19] nvm, we check the amount in mark_refund... [21:15:24] we can still include amount and currency [21:15:25] yah [21:15:37] I guess we could check that it's the expected gateway [21:15:47] yeah, let me do that [21:15:52] and add tests [21:15:57] Gateway's not a column yet, though... [21:16:09] no, it's a constructor arg [21:16:26] segregated csvs [21:16:35] & I assume they'll want to import refund files of manually entered transactions [21:16:41] I don't see the ctor arg [21:16:54] ah this->processor [21:17:01] yarp [21:17:26] back when i was resisting the native terminology [21:17:33] haha [21:18:18] That lint failure... [21:18:38] ohhh, that's some busted CI [21:19:51] (CR) Awight: [C: 2] Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:22:49] (CR) jenkins-bot: [V: -1] Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:24:10] fr-tech - i may miss the beginning of roles meeting, sorry, well and septic repair people are both here at once [21:26:33] That would be kind of perfect to hold the meeting adrift between fresh and shit water [21:30:27] ugh the problem is down the actual well hole somewhere [21:30:33] * cwd|afk closes eyes, opens wallet [21:31:39] fill it in and harvest dew [21:33:50] (CR) Paladox: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:35:08] (PS2) Ejegg: Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) [21:37:55] (CR) Awight: Import refunds by contribution ID (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:39:49] (CR) Ejegg: "fixing..." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:45:02] (PS3) Ejegg: Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) [21:45:08] relocating for roles... [21:47:24] (CR) Awight: [C: 2] "Nice readability fix in PS3, too!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:49:10] (CR) Paladox: "Your welcome :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [21:50:00] (Merged) jenkins-bot: Import refunds by contribution ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309397 (https://phabricator.wikimedia.org/T142312) (owner: Ejegg) [21:51:22] (PS9) Awight: Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) [21:51:24] (PS12) Awight: Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) [21:52:06] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/307528 (owner: Paladox) [21:53:00] (CR) jenkins-bot: [V: -1] Don't use frontend classes from fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306853 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [21:53:26] (CR) jenkins-bot: [V: -1] Be less magical about unstaging order status things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306852 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [21:53:31] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/309457 [21:53:40] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/309457 (owner: Awight) [21:53:52] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/309457 (owner: Awight) [21:54:40] (PS1) Awight: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/309458 [21:56:20] !log update SmashPig from 7f9eb7475d194c67ff070b5d8bbc9fc6837b462f to e11af5793df9a0e2dbcf9ac138a8f2a3fa1bf574 [21:56:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:41:22] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#2621291 (MBeat33) I emailed Sal to ask them to replace that message with something m... [22:58:51] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 [23:00:45] back in a bit! [23:02:12] cwd|afk: XenoRyet|brb do you have a sec to check something in gerrit? [23:02:37] (CR) jenkins-bot: [V: -1] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 (owner: AndyRussG) [23:02:52] I just need to check that those of us who are not deployers can't see the +2 button on this patch: https://gerrit.wikimedia.org/r/309479 [23:03:17] AndyRussG: Yea looking [23:03:46] Looks like I do have +2 authority for that patch. [23:05:24] Hmm K... XenoRyet you generally don't have deploy rights yet, right? or do you? [23:05:45] Not for CentralNotice as far as I know. [23:05:53] XenoRyet: K thanks! [23:06:17] No worries [23:10:27] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 (owner: AndyRussG) [23:10:48] XenoRyet: CentralNotice deployment is actually MediaWiki deployment, fwiw [23:10:49] (CR) Ejegg: WIP smashpig paypal listener (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [23:11:10] You should be able to deploy there... Can you log into tin? [23:11:18] Lets find out. [23:11:29] https://wikitech.wikimedia.org/wiki/How_to_deploy_code [23:11:39] https://wikitech.wikimedia.org/wiki/Production_shell_access [23:12:53] (CR) Awight: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/309458 (owner: Awight) [23:13:00] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/309458 (owner: Awight) [23:13:52] awight: oh, thanks for deploying CRM! I'll get the refund csv ready, then [23:14:50] ejegg: great! [23:17:37] !log update fundraising crm from cf19366e7f651785276d0071ce2c944d393c0ad5 to 946a3f1338bbaf3b65070b03a5a4c4aff5313a90 [23:17:58] ejegg: deployed [23:18:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:18:13] ty [23:18:23] (CR) AndyRussG: [C: 2 V: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 (owner: AndyRussG) [23:19:15] ejegg: oops, just realized you might not have wanted the card moved to "done"? [23:19:49] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Delete from the pending database when a transaction is failed or completed - https://phabricator.wikimedia.org/T143945#2584307 (awight) [23:19:52] (CR) jenkins-bot: [V: -1] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 (owner: AndyRussG) [23:19:54] heh, let's be optimistic [23:20:07] * awight gnaws cuticles [23:20:40] Heh overriding Jenkins here ^ it's just a change to CI config that isn't live on prod [23:23:32] fr-tech: any thoughts on this one new? looks like we can't merge to the deploy branch because CI changes: https://gerrit.wikimedia.org/r/#/c/309479/ [23:24:53] Ah K looks like it's fixable [23:25:27] :) seems that the force merge took [23:25:37] oops. /me totally spaced the roles meeting [23:25:55] remember, the force has a light side and a dark side [23:25:57] Jeff_Green: didn't miss much this time, we were focusing on the Software Engineer role [23:26:02] awight: ok good [23:26:12] ejegg: you mean the villagers with pitchforks? [23:26:26] Jeff_Green: There's another next Monday if you'd like, though ;) [23:26:38] oh boy oh boy! [23:27:01] is it again at 3PM pacific? [23:27:30] !log rolling back fundraising crm from 946a3f1338bbaf3b65070b03a5a4c4aff5313a90 to cf19366e7f651785276d0071ce2c944d393c0ad5 [23:27:33] ejegg: ^ [23:27:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:28:18] awight: Yea, looks like I don't have access to tin and probably more to AndyRussG's point I'm not in the wmf-deployment gerrit group. [23:28:29] Jeff_Green: oops, Monday after next. I'm adding you to the invite [23:28:35] ok thanks [23:28:39] done [23:28:43] awight: d'oh, namespace? [23:28:48] silly. [23:28:55] XenoRyet: K thanks! Yeah this was a CN-specific Gerrit config issue that roan K was looking into [23:29:21] Cool [23:29:32] * Jeff_Green heading out. have a good night people [23:29:39] seeya [23:30:05] ejegg: yah. eek, that means bad things about tests ;) [23:30:26] And my powers of perception... think i approved that message [23:30:39] (CR) Dereckson: "Test failure source: SQL strict mode. Safe to deploy, with the understanding this is an high priority to fix them for next deployments." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 (owner: AndyRussG) [23:30:41] (PS1) Awight: Add missing "use" statement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309485 [23:31:20] (CR) Ejegg: [C: 2] Add missing "use" statement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309485 (owner: Awight) [23:31:54] (PS2) Awight: Reuse transactionFinalized logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309190 [23:33:49] (CR) jenkins-bot: [V: -1] Reuse transactionFinalized logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309190 (owner: Awight) [23:34:15] (Merged) jenkins-bot: Add missing "use" statement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309485 (owner: Awight) [23:34:16] yargh, i will be out monday after next [23:34:43] (CR) AndyRussG: "Thanks @Dereckson!" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/309479 (owner: AndyRussG) [23:35:06] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/309488 [23:35:13] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/309488 (owner: Awight) [23:35:55] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/309488 (owner: Awight) [23:36:01] * awight growls at false dependencies making CI linear [23:36:28] !log update fundraising crm from cf19366e7f651785276d0071ce2c944d393c0ad5 to 93091637a0a68950efb8955a2cfef031d6ba7883 [23:36:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:36:34] fr-tech dstrine: we need to create a subtask of this task and add it to the sprint: https://phabricator.wikimedia.org/T108255 [23:37:02] strict MariaDB mode soon to be enabled on prod, currently enabled on CI [23:37:33] * AndyRussG whacks CN with a strict flyswatter [23:37:52] discipline! [23:38:41] ejegg: ok the CRM jobs seem stable now. Recurring GC might melt down in the night... but I think you're good to run the refund import now. [23:38:53] thanks, will do! [23:38:55] I'm gonna commute and get back online in 1.5 hr or so [23:43:51] AndyRussG: why do we need to add it to the sprint? [23:49:56] dstrine: it's a change in database config on the main cluster that will throw errorrrrz if we don't clean up stuffzzz [23:50:51] AndyRussG: some questions: 1.) do you have to do it? 2.) when do we have to do it? 3.) how difficult will that be? [23:52:02] dstrine: (1) it probably doesn't require very deep CN knowledge, might be fun for someone else to self-centralnoticize with (2) clean up our DB queries, or something (3) dunno [23:52:41] AndyRussG: was when do we have to do it? [23:52:53] sorry #2 was "when" [23:52:54] Ah when sorry I read what [23:53:21] I think we have a week-ish to merge and deploy? lemme see [23:55:34] just to guestimate... is this a 1 or 2 Story point or a 16? [23:59:32] dstrine: hopefully more 2ish than 4ish