[00:48:06] (PS1) AndyRussG: campaignManager: jquery.throttle-debounce dependency [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311640 (https://phabricator.wikimedia.org/T145447) [00:51:22] (CR) jenkins-bot: [V: -1] campaignManager: jquery.throttle-debounce dependency [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311640 (https://phabricator.wikimedia.org/T145447) (owner: AndyRussG) [01:39:12] (CR) AndyRussG: "> Good call on the truncation! I can do that in a follow-on patch" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [01:40:11] aaarg! [01:40:50] aaarg? [01:47:32] (PS3) Eileen: Further fix on address merging to support form override [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311597 (https://phabricator.wikimedia.org/T144440) [01:51:14] (PS8) Ejegg: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) [01:54:25] aaaarg aaarg! [01:57:22] (CR) Ejegg: MariaDB strict mode (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [02:00:04] ejegg: thx! to continue along in a very aaaargy vein, wouldn't you say (int)$phpBooleanToBeCastToInt is prettier? [02:01:16] ah, good call. just perusing some of the changes aaron made to core when he was initially enabling strict mode, and that's how he's doing it everywhere [02:01:42] I also just noticed some strings used as defaults for int columns in CentralNotice.sql [02:04:25] Ohnoes [02:05:03] K we should alert jynus about that, too... That'd be a schema change [02:05:19] nice catch :) [02:06:12] I wonder if we could just remove the fundraising properties from banner definitions in the test fixtures [02:06:18] almost set fest tixtures [02:06:21] said [02:06:30] * AndyRussG slurrs his tpying [02:06:41] hmm, is it really a schema change, or would non-strict maria have implicitly fixed the defaults when the table was created? [02:06:52] huh [02:07:20] dunno, also I wonder if there is any production context where the tables are created anew [02:07:40] like when creating a new DB slave [02:07:47] or a whole new wiki! [02:07:52] ah right! [02:08:04] what about all those db patches? [02:08:19] ehh, it's only search+replace, no big deal [02:08:20] if we're advertising support for strict we might as well fix the defaults [02:08:35] I think it'd just be a new db patch [02:08:38] maybe [02:09:05] (CR) AndyRussG: "Thx!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [02:11:04] ooh, just found some more fix candidates searching for '1' [02:11:21] heh wow cool [02:11:32] man I love computers! [02:13:31] ejegg: actually one sec, maybe scratch my last comment on Gerrit [02:14:02] retracting your 'thx'? [02:14:43] I think the reason all those fundraising properties are explicit in the text fixtures is that we don't actually munge the values in qunit very much [02:15:01] no, about converting fundraising property to boolean [02:16:47] actualy no don't scratch the comment aaarg aaarg [02:16:49] one sec [02:18:13] (PS1) Eileen: Fix url for batch merge link [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/311645 [02:19:24] If anyone gets time it would be great to get this deployed https://gerrit.wikimedia.org/r/#/c/311597/ [02:19:49] it prevents our batch merge logic from overriding address choices made when merging contacts manually [02:19:59] (& it is very short :-) [02:23:13] ejegg: I think we can just nix the fundraising property in the test fixtures [02:23:30] oho, cool [02:23:47] It's used in the DB but on the php test side it'll be defaulted in [02:24:15] and on the qunit side, we're simulating choice data, which doesn't even contain it, so better off without [02:24:48] (CR) Ejegg: [C: 2] "Looks good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311597 (https://phabricator.wikimedia.org/T144440) (owner: Eileen) [02:24:58] I don't remember why it's even in there in the fixtures... maybe an artifact of historical whimsy [02:26:58] thanks ejegg [02:27:29] hmm, running tests locally gets caught up in the maximum function nesting level in deepMultisort [02:28:28] (Merged) jenkins-bot: Further fix on address merging to support form override [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311597 (https://phabricator.wikimedia.org/T144440) (owner: Eileen) [02:31:28] (PS9) Ejegg: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) [02:31:34] let's see if that still passes [02:32:57] hmm seems like merging to deployment hits a big mess of merge conflicts [02:33:01] (CR) jenkins-bot: [V: -1] MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [02:33:03] also switched over some == to === [02:33:23] eileen: ooh, yeah, can't merge master to deploy right now, sorry [02:33:50] there's a patch switching over the main donations queue consumer to Redis [02:35:30] (PS10) Ejegg: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) [02:35:49] well, I think I need to hang up my spurs for the night. eileen, you want to just cherry-pick that one to master? [02:36:04] I'll deal with the whole merge mess soon [02:36:44] gnight all [02:37:00] (CR) jenkins-bot: [V: -1] MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [02:44:08] (PS1) Eileen: Further fix on address merging to support form override [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311646 (https://phabricator.wikimedia.org/T144440) [02:44:41] (CR) Eileen: [C: 2] Further fix on address merging to support form override [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311646 (https://phabricator.wikimedia.org/T144440) (owner: Eileen) [02:44:48] (Merged) jenkins-bot: Further fix on address merging to support form override [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311646 (https://phabricator.wikimedia.org/T144440) (owner: Eileen) [02:44:57] (CR) Eileen: "Cherry-pick to deployment - self-merging" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311646 (https://phabricator.wikimedia.org/T144440) (owner: Eileen) [02:47:27] !log CiviCRM update from c9157ba6aac3ad3c2fd61c7bb0475851fb8ec421 to de1df9ec4fe58487eeb61cc69160f228e009f2cf [02:47:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:54:42] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Issues manually merging records - https://phabricator.wikimedia.org/T144440#2599873 (Eileenmcnaughton) @LeanneS @RLewis I've deployed another fix - do you want to try merging some of th... [03:43:46] (CR) AndyRussG: "Great catches!!" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [04:20:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2651334 (Eileenmcnaughton) OK I tracked this down https://issues.civicrm.org/jira/browse/CRM-19391 https://github.com/civicrm/civicrm-core/pull/9078 We can apply the above pat... [04:20:56] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2651336 (Eileenmcnaughton) [04:21:23] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2377255 (Eileenmcnaughton) a:Eileenmcnaughton I pulled this in since it is not too hard [05:25:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search issues related to dedupe? - https://phabricator.wikimedia.org/T145873#2651360 (Eileenmcnaughton) OK so I looked into this & found 1) contact_id 8864893 has been merged into 1709491 - that seems correct and I would not expect you to be able... [05:29:55] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search issues related to dedupe? - https://phabricator.wikimedia.org/T145873#2651362 (Eileenmcnaughton) [05:30:09] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search issues related to dedupe? - https://phabricator.wikimedia.org/T145873#2643683 (Eileenmcnaughton) Open>Resolved a:Eileenmcnaughton [05:30:20] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search issues related to dedupe? - https://phabricator.wikimedia.org/T145873#2643683 (Eileenmcnaughton) Resolved>Open [08:14:23] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Browser-Tests-Infrastructure, MediaWiki-extensions-CentralNotice, User-zeljkofilipin: CentralNotice: Intermittent unexplained browser test failures - https://phabricator.wikimedia.org/T145718#2651498 (zeljkofilipin) Only three faile... [08:47:48] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Browser-Tests-Infrastructure, MediaWiki-extensions-CentralNotice, User-zeljkofilipin: CentralNotice: Intermittent unexplained browser test failures - https://phabricator.wikimedia.org/T145718#2651635 (zeljkofilipin) [09:02:03] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Browser-Tests-Infrastructure, MediaWiki-extensions-CentralNotice, User-zeljkofilipin: CentralNotice: Intermittent unexplained browser test failures - https://phabricator.wikimedia.org/T145718#2651654 (zeljkofilipin) All three failur... [09:02:40] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Tests, User-zeljkofilipin: CentralNotice: Intermittent unexplained browser test failures - https://phabricator.wikimedia.org/T145718#2651657 (zeljkofilipin) a:zeljkofilipin>None [15:09:41] Fundraising-Backlog, fundraising-tech-ops: Give CPS members access to civi - https://phabricator.wikimedia.org/T146051#2652315 (Jgreen) [15:09:58] Fundraising-Backlog, fundraising-tech-ops: Give CPS members access to civi - https://phabricator.wikimedia.org/T146051#2648955 (Jgreen) [15:10:30] Fundraising-Backlog, fundraising-tech-ops: Give CPS members access to civi - https://phabricator.wikimedia.org/T146051#2648955 (Jgreen) [15:11:01] Fundraising-Backlog, fundraising-tech-ops: Give CPS members access to civi - https://phabricator.wikimedia.org/T146051#2648955 (Jgreen) Open>Resolved civi credentials and SSL certs have been set up for each user [15:26:46] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi search issues related to dedupe? - https://phabricator.wikimedia.org/T145873#2652381 (CCogdill_WMF) This sounds like a big deal to me, though I'm not sure I understand I the effect. Wouldn't we want only... [17:43:34] cwd: Definitely no big deal about the Adyen job--but one thing is that it's always good to be in the practice of !log'ing to https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:43:44] I remember about 50% of the time... [17:44:10] ah yes perfect [17:44:33] i was trying to think of a good place to leave a note [17:44:52] my uncle has a magnet in his truck that says BIKE ON TOP [17:45:11] there was an incident with the garage [17:47:47] awight: if you are in the meeting, want to dial me in? [17:50:11] amazing... [17:50:20] sure, one second [18:01:48] fr-tech: chatting if u want [18:02:29] I'm nose to the grindstone right now, think I'm gonna keep at it. [18:02:35] carry on then! [18:21:47] (CR) Awight: WIP smashpig paypal listener (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [18:22:21] (PS29) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [18:22:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Epic: [epic] SPOF: Use Redis as backend store for contribution_tracking - https://phabricator.wikimedia.org/T119556#2653056 (awight) [18:24:50] (PS30) Cdentinger: smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [18:26:36] (PS31) Cdentinger: smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) [18:26:38] (CR) Ejegg: [C: 2] Remove APC Configuration caching [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311472 (owner: Awight) [18:28:19] (Merged) jenkins-bot: Remove APC Configuration caching [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311472 (owner: Awight) [18:29:36] (CR) Awight: [C: 2] "@ejegg talked me into deploying with the same bugs as the legacy code, but please come back to my comments on PS10" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309603 (https://phabricator.wikimedia.org/T145234) (owner: XenoRyet) [18:30:05] (PS11) Awight: Move refund queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309603 (https://phabricator.wikimedia.org/T145234) (owner: XenoRyet) [18:30:08] (CR) Awight: Move refund queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309603 (https://phabricator.wikimedia.org/T145234) (owner: XenoRyet) [18:30:10] (CR) jenkins-bot: [V: -1] Move recurring queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309618 (https://phabricator.wikimedia.org/T145233) (owner: Ejegg) [18:30:12] (CR) Awight: [C: 2] Move refund queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309603 (https://phabricator.wikimedia.org/T145234) (owner: XenoRyet) [18:30:16] (PS4) Awight: Move recurring queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309618 (https://phabricator.wikimedia.org/T145233) (owner: Ejegg) [18:30:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: is it possible to correct obvious email address typos before deduping exact matches? - https://phabricator.wikimedia.org/T135042#2653105 (CCogdill_WMF) Thanks for doing all this work, @MBeat33! I actually checked in with legal about this and confi... [18:32:00] (CR) XenoRyet: "@awight, yea the plan was to do a minimum version now and a clean up pass after. I'll definitely address those comments when we get there" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309603 (https://phabricator.wikimedia.org/T145234) (owner: XenoRyet) [18:33:50] (CR) Awight: smashpig paypal listener (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [18:34:00] ejegg: and awight wanna join this meeting? [18:34:08] (Merged) jenkins-bot: Move refund queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309603 (https://phabricator.wikimedia.org/T145234) (owner: XenoRyet) [18:34:24] (Merged) jenkins-bot: Move recurring queue consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/309618 (https://phabricator.wikimedia.org/T145233) (owner: Ejegg) [18:43:17] (PS9) Cdentinger: [WIP] Payments API for PayPal [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 (owner: Awight) [18:55:20] (PS3) Cdentinger: WIP Test failure path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 [19:06:20] (PS10) Cdentinger: Payments API for PayPal [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 (owner: Awight) [19:07:06] (PS4) Cdentinger: WIP Test failure path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 [19:07:46] (PS5) Cdentinger: Test failure path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 [19:22:57] (CR) Ejegg: Test failure path (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 (owner: Cdentinger) [19:29:39] (PS32) Awight: smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:40:13] (CR) Awight: [C: -1] "My usual complaints." (7 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:41:36] (CR) Awight: Payments API for PayPal (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 (owner: Awight) [19:43:06] (CR) Awight: [C: 2] "OK the validation happens in a later patch..." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:43:22] (Abandoned) Awight: [WIP] Test unhappy validation path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306603 (https://phabricator.wikimedia.org/T141654) (owner: Awight) [19:43:35] (PS11) Awight: Payments API for PayPal [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 [19:44:00] (Merged) jenkins-bot: smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305761 (https://phabricator.wikimedia.org/T141654) (owner: Cdentinger) [19:45:42] (PS12) Awight: Payments API for PayPal [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 [19:45:48] (CR) Awight: [C: 2] Payments API for PayPal (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 (owner: Awight) [19:46:40] (Merged) jenkins-bot: Payments API for PayPal [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306601 (owner: Awight) [19:47:08] (PS6) Awight: Test failure path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 (owner: Cdentinger) [20:00:35] (PS1) Anomie: Remove pre-1.25 API compatibility code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 [20:00:43] (PS1) Anomie: Remove pre-1.25 API compatibility code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/311780 [20:05:30] (CR) jenkins-bot: [V: -1] Remove pre-1.25 API compatibility code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 (owner: Anomie) [20:51:49] (CR) Awight: Test failure path (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 (owner: Cdentinger) [20:52:12] (CR) Awight: [C: 2] Test failure path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/310942 (owner: Cdentinger) [21:01:17] queries show scope of is_primary email problem = shy of 10000 contacts [21:02:08] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311835 [21:04:46] Fundraising-Backlog: Document fundraising deployment operations - https://phabricator.wikimedia.org/T146217#2653961 (cwdent) [21:05:13] Fundraising-Backlog: Document fundraising deployment operations - https://phabricator.wikimedia.org/T146217#2653961 (awight) This is all we have so far: https://collab.wikimedia.org/wiki/Fundraising/Engineering#Deploy_Fundraising_Code [21:07:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 4 others: [Epic] Consolidate "pending" queue usages - https://phabricator.wikimedia.org/T130897#2653988 (awight) [21:07:18] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 7 others: [Epic] Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2653987 (awight) Open>Resolved [21:08:04] !log update SmashPig from db68be988194c960aebca691d0fd8e6a6d24246a to 285d8ce25f22d8538c693c1b3c3e7ce9e688f22c [21:08:07] cwd: ^ [21:08:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:08:10] Now for the config... [21:08:22] awight: and a specially crafted request [21:08:47] awight: should i just do that with browser tools? [21:09:01] probably can't make it pass anything arbitrary [21:09:09] cwd: Can you produce the live payment we were talking about? Probably much easier. [21:09:13] I can do that if you want [21:09:26] with the verify_url? [21:09:35] notify_url yeah [21:09:45] yeah sorry, dont' we have to hack the form to do that? [21:09:49] notify_url=//payments-listener.wikimedia.org/paypal2 [21:09:56] hold on, lemme make the patch. [21:10:15] oh that's probably what you were talking about [21:11:18] cwd: https://phabricator.wikimedia.org/P4076 [21:11:30] Then u make a payment locally [21:11:51] ah, great thx [21:12:07] will do that in one sec, just fixing those tests [21:15:08] fr-tech: running a synthetic adyen audit report, heads up for audit parser failmail [21:15:43] kk [21:16:33] cwd: Something like this for the end of SmashPig.yaml, right? https://phabricator.wikimedia.org/P4077 [21:19:49] awight: isn't that in the defaults? [21:25:40] cwd: sure but that would refer to the wrong &REDIS [21:25:50] i.e. we'd get the default localhost creds [21:27:01] oh right sorry [21:27:31] i thought that's what that yaml magic was for? [21:27:34] I had the same brain fart, no reason to spoilagize [21:27:44] nah it can only reference a var in the same file. [21:28:59] it would sure be handy to be able to override [21:29:17] yeah. actually, we should just have a default queue server. [21:33:23] ejegg: are you free for a meeting? [21:35:42] Fundraising-Backlog: Document fundraising deployment operations - https://phabricator.wikimedia.org/T146217#2654026 (ggellerman) p:Triage>Normal [21:36:54] Fundraising-Backlog: Customized Communications Preference field is not working correctly in Civi - https://phabricator.wikimedia.org/T146096#2654033 (ggellerman) p:Triage>Normal [21:39:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-Logging: Some wmf_civicrm exceptions should be logged at info and not error - https://phabricator.wikimedia.org/T146063#2654036 (ggellerman) p:Triage>Normal [21:39:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-Logging: Some wmf_civicrm exceptions should be logged at info and not error - https://phabricator.wikimedia.org/T146063#2649382 (ggellerman) per @awight this can wait until code freeze [21:41:07] dstrine: ack, be right there! [21:48:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Technical-Debt: CentralNotice should not call WikiPage::doEdit() - https://phabricator.wikimedia.org/T145738#2654069 (ggellerman) p:Triage>Normal [22:01:20] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708#2654142 (ggellerman) p:Triage>High [22:05:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix soft credit to not require an email - https://phabricator.wikimedia.org/T145470#2654164 (DStrine) p:Triage>Normal [22:06:37] Fundraising-Backlog, FR-Amazon: Allow Amazon users who have selected to stay logged in to bypass login on a second donation - https://phabricator.wikimedia.org/T145251#2654170 (DStrine) p:Triage>Normal [22:07:42] Fundraising-Backlog, FR-Smashpig, Spike: [SPIKE] SmashPig config should be more namespaced - https://phabricator.wikimedia.org/T145205#2654176 (DStrine) [22:13:44] Gonna relocate, back in an hour [22:15:50] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708#2638776 (Ejegg) Aargh, I just remembered why we don't have this. The IPN notifications are the only way we can get AVS and CVV results - their API is missing s... [22:17:43] ejegg: D: [22:17:48] re: that bug ^ [22:18:02] does that mean it's basically impossible to have a reliable adyen workflow? [22:18:22] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708#2654230 (awight) Huh. Maybe the listener can drop the IPN response into the pending queue directly, before the auth step. [22:18:29] hahaha [22:18:36] back soon. [22:19:24] cwd we're making things hard for ourselves because we want to run our own fraud filters instead of relying on theirs [22:20:06] isn't it kind of a requirement for us to have good visibility into fraud breakdowns? [22:21:03] yeah [22:22:12] guessing we can't get the detailed info from their api? [22:24:06] the api is really bare - it's basically just modification requests, no status lookups [22:24:35] This was the question on giving event permission https://phabricator.wikimedia.org/T137740#2651334 [22:25:07] drag [22:28:13] i also need to relocate [22:32:04] (PS1) Eileen: Update for primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311850 (https://phabricator.wikimedia.org/T143062) [22:52:04] dstrine: do we have a ticket for the idea of creating a dashlet or similar for stats? I'll note some things there if we do [22:52:23] eileen: I can make one now [22:52:42] cool [22:55:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: create a dashlet for dedupe script stats - https://phabricator.wikimedia.org/T146229#2654431 (DStrine) [22:55:12] there ya go^^ [23:03:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: create a dashlet for dedupe script stats - https://phabricator.wikimedia.org/T146229#2654431 (Eileenmcnaughton) I ran some ad hoc queries just now - here is the merge pattern over the last 2 months - you can see when the dedupe job was turned on & off.... [23:05:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: create a dashlet for dedupe script stats - https://phabricator.wikimedia.org/T146229#2654487 (Eileenmcnaughton) This shows total contacts in our database - the deleted ones are pretty much merged ones SELECT count(*) as number_of_contacts, is_deleted F... [23:06:07] eileen: does your table show that we have only done 228K merges? I thought we had way more than that already [23:07:50] eileen: sorry I just saw your other comment. in the second column, is 0 or 1 "deleted"? [23:08:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: create a dashlet for dedupe script stats - https://phabricator.wikimedia.org/T146229#2654506 (Eileenmcnaughton) The way the jobs work is they iterate through a range of IDs, finding any matches from anywhere else in the DB for those ids. The first job i... [23:09:00] dstrine: not 228k - check the number of digits! [23:09:10] 1 = is deleted [23:09:48] LOL sorry .. It's been a day [23:09:53] * dstrine is a bit tired [23:09:58] :-) [23:10:35] thanks for the info [23:15:42] dstrine: no worries - I thought giving it over time might be useful [23:19:04] ejegg: what do you think about adding a table for name matches - ie Steven, Steve for resolving conflicts - then we can make that editable by (selected) users and the data in it can be managed by them over time (we'd obviously add a few obvious ones) [23:19:15] & if they get a datasource for it then can upload that [23:19:56] I feel like about 20% -40% of the near-name conflicts could be knocked out with a smallish intuitive list of English names [23:20:06] which is a reasonable win [23:21:00] that could be a win! [23:22:37] and indicate which is the more formal [23:23:53] yeah - what we do with that? [23:24:11] I mean we could have 'preferred' [23:24:23] & use that if set, otherwise use latest donor [23:24:41] or stuff one in nickname [23:24:59] Oh, nickname field, nice [23:25:48] ejegg: also thinking we should do a clean up of those primaries before I fix the bug & then after - just to keep the data nice - https://gerrit.wikimedia.org/r/#/c/311850/ [23:26:30] yep! Just reviewing now, was wondering if we needed to worry about on_hold or not [23:26:48] I don't think so for this [23:27:00] it ensures that if there is an email for a contact at least one is primary [23:27:17] I think even if it is on hold it should be primary if it is the only one [23:27:33] oh right [23:27:47] yeah, and we'd want to make sure that got onto the suppression list [23:28:13] (CR) Ejegg: [C: 2] Update for primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311850 (https://phabricator.wikimedia.org/T143062) (owner: Eileen) [23:28:16] that makes sense [23:28:35] I think it will take a few mins to run - I'll stop dedupes to avoid failmail [23:28:41] thanks! [23:28:42] probably main donation queue too? [23:28:46] is that all [23:29:25] eileen: could do thank you send as well [23:29:34] ok sure [23:29:43] so http://localhost:9000/job/Donations%20queue%20consume/ [23:29:56] & http://localhost:9000/job/Thank%20you%20mail%20send/ [23:30:08] hmm - that was actually works I pasted not urls [23:30:14] but it converted [23:31:05] ejegg: looks like I'm cherry-picking again - that's fine though [23:31:26] yeah, hopefully not for long! [23:31:30] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708#2638776 (cwdent) @awight that still leaves the listener as a SPOF doesn't it? [23:32:10] (Merged) jenkins-bot: Update for primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311850 (https://phabricator.wikimedia.org/T143062) (owner: Eileen) [23:32:14] ejegg: I'm just happy I don't have to work through those conflicts :-) [23:32:29] heh, it'll be a puzzle alright [23:32:43] (PS1) Eileen: Update for primaries not set. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311871 (https://phabricator.wikimedia.org/T143062) [23:38:10] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Orphan rectifier for Adyen - https://phabricator.wikimedia.org/T145708#2654535 (Ejegg) Not sure exactly what you mean - the auth happens in the Adyen iframe. One possibility is that we can ask them to auto-capture authorizations... [23:40:24] (CR) Eileen: [C: 2] Update for primaries not set. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311871 (https://phabricator.wikimedia.org/T143062) (owner: Eileen) [23:40:32] (Merged) jenkins-bot: Update for primaries not set. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/311871 (https://phabricator.wikimedia.org/T143062) (owner: Eileen) [23:43:05] (CR) Ejegg: "Agreed, booleans should be booleans right up till we dump them in the db." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [23:44:59] !log CiviCRM update from de1df9ec4fe58487eeb61cc69160f228e009f2cf to 5393a13727e8dbad05ffef9ddd44e965eb9282d1 [23:45:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:46:37] !log disabled Donations queue consume [23:46:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:46:56] !log disabled Thank you mail send [23:47:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:47:13] (PS1) Cdentinger: Test PayPal verified message transform [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311874 [23:47:14] !log disabled CiviCRM contacts (high numbers) [23:47:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:47:32] !log disabled Project Dedupe Major gifts contacts [23:47:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:49:44] !log disabled Dedupe CiviCRM contacts [23:49:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:57:16] (PS11) Ejegg: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591)