[00:01:19] (CR) Ejegg: "Removed the SQL changes for ya AndyRussG." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [00:19:15] cwd: I was trying to figure something out yesterday. Can we specify the source_* fields from configuration? Jobs would override source_type and _name, using a configuration view I suppose. [00:19:26] The whole thing smacks of a lack of determinism, as you were saying. [00:24:34] cwd: So were we gonna enfire this new listener? [00:27:59] cwd: oops, I was off with that patch. The normal api is _donations, not _xclick. [00:38:24] I've got a message to PP, but it is "retrying" the IPN message. [00:38:28] Don't see logging anywhere. [00:44:48] awight: hey sorry i was eating [00:45:03] but yeah i was going to try that shortly [00:45:45] !log jobs enabled again - update failed to run due to trigger - which didn't affect staging maybe not on - will edit & try again [00:45:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:57:03] (PS1) Awight: [WIP] SourceFields experiment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311884 [00:57:05] (PS1) Eileen: Revise update to primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311885 (https://phabricator.wikimedia.org/T143062) [00:57:13] (CR) jenkins-bot: [V: -1] [WIP] SourceFields experiment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311884 (owner: Awight) [00:59:06] awight: we could shut the fail mail up by just deploying a return 200 [01:04:07] I like the test message [01:04:12] How about [01:04:24] we point the failmail address at just us? [01:04:38] ah nuts--that's in /etc/**SmashPig.yaml [01:04:55] k let's go with your plan! [01:06:55] awight: it sure looks like Configuration combines the yaml rather than overwriting [01:10:49] (PS1) Awight: Test Configuration merge edge case [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311886 [01:11:02] cwd: ^ yah I just proved that to myself, too [01:11:48] cwd: It looks like the problem is just SP/SmashPig.yaml [01:12:17] cwd: oh. it's the old code [01:12:20] something wrong with the class definition there? [01:12:45] the deployment didn't happen? [01:13:11] awight: i did not do any deploying [01:13:15] boron:/srv/www/org/wikimedia/listeners/SmashPig/SmashPig.yaml looks good [01:13:25] mebbe I didn't rsync_blast correctly? [01:13:27] Comaring barium [01:13:58] not deployed anywhere. [01:14:04] hehehe [01:14:05] X| [01:14:06] sorry about that [01:14:15] that is the very command i was wondering about [01:14:20] SmashPig:all ? [01:14:40] * awight looks forward to writing deployment guide, in hopes of finally understanding it [01:14:51] rsync_blaster ALL:SmashPig [01:15:18] awight: but wait, isn't the crm one in vendor and so needs composer update? [01:15:21] !log updated SmashPig to 285d8ce25f22d8538c693c1b3c3e7ce9e688f22c [01:15:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:15:37] cwd: that's right, but we don't need it in CRM, do we? [01:16:30] awight: i guess i'm not sure where the jobs consumer runs [01:16:43] not on crm? [01:17:13] uh [01:21:23] nuts. my test IPN message is the only one I'm not allowed to resend, presumably cos it's not pointed at the "profile" url [01:21:51] did it stop sending? [01:22:53] no, still retrying, but the last attempt was two minutes before my deployment [01:24:10] I'm gonna just netcat this over. [01:25:13] awight: what is the redis host? [01:25:46] PHPQueue\Exception\BackendException@/srv/www/org/wikimedia/listeners/SmashPig/vendor/coderkungfu/php-queue/src/PHPQueue/Backend/Predis.php:99 (No queue specified.) [01:25:57] see the latest failmail, we have a new hurdle :D [01:26:12] seems like config again [01:26:38] that's good, though! [01:27:12] * awight waves bushy tail [01:29:57] (PS2) Eileen: Revise update to primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311885 (https://phabricator.wikimedia.org/T143062) [01:32:44] awight: think phpqueue might need an update? [01:32:56] cwd: Uh, on second look I don't see where we add the queue name. [01:33:05] Maybe we were thinking of DonationQueue? [01:33:18] awight: it was def working in dev [01:33:36] Still, other queues don't give a "queue" either [01:33:37] i notice my local Predis.php is different from the one in the error [01:34:41] 14198ba1f7d4868933649a85621a3955965e83cd is deployed [01:34:55] what's your local? [01:35:12] That actually looks like master [01:37:31] huh weird [01:37:35] the error is a different line [01:37:38] how *do* we find queue? [01:38:05] where are you queueee queueeee? [01:38:48] * awight whistles for willy [01:40:45] awight: good question [01:40:46] We pass the queue when using the MultiQueueWriter, but why not for pending? [01:44:40] cwd: Core/QueueConsumers/BaseQueueConsumer::getQueue [01:44:41] awight: looks like MultiQueueWriter intuits the queues [01:45:01] So it was dependent on how the queue gets used. There's a FIXME. [01:45:27] ooh cripes [01:45:34] i was wondering why that interface exists [01:46:25] (PS1) Awight: Explicitly configure queue name cos silly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311887 [01:47:31] and by "there's a fixme" I by no means meant there was already a fixme :p [01:50:28] awight: i'll have a fix momentarily [01:50:34] Looks like they have exponential backoff [01:50:41] cwd: U saw //gerrit.wikimedia.org/r/311887 ? [01:51:11] or mebbe you were going for the real fix... [01:52:09] awight: i was gonna make the test use config&object() [01:52:21] isn't that how the listener gets it? [01:52:28] doesn't seem to fail how i hoped though [01:52:56] that's interesting... want me to deploy this config fix while you're hakking though? [01:53:25] (CR) Cdentinger: [C: 2] Explicitly configure queue name cos silly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311887 (owner: Awight) [01:53:33] yes pls & ty [01:54:02] O_O [01:54:06] (Merged) jenkins-bot: Explicitly configure queue name cos silly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311887 (owner: Awight) [01:54:43] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311888 [01:55:04] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311888 (owner: Awight) [01:58:22] * awight kisses the sky and self-submits [01:58:26] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311888 (owner: Awight) [01:58:57] !log update SmashPig from 285d8ce25f22d8538c693c1b3c3e7ce9e688f22c to f1f55096ac20899fa9700aa0f80dece5b47a7fd3 [01:59:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:59:42] cwd: btw, once you have the payload: [01:59:44] wget --post-file n https://payments-listener.wikimedia.org/paypal2 [01:59:55] 200 OK! [02:01:54] * awight looks for a bulge in the plumbing [02:01:59] nice! [02:02:57] feature request: let's have the PP listener log the gateway_txn_id in stage 1, you agree? [02:03:56] awight: is that paypal's ID [02:03:58] ? [02:04:04] yah [02:04:21] or yeah we could also log the order_id [02:04:33] ... whatever field that's coming back in through [02:04:38] yeah either or both is probably good [02:04:49] And maybe a completed successfully line [02:04:51] sorry i'm still learning which fields are which [02:04:57] me too [02:05:08] I failed to document them, last time I tried [02:06:46] btw the emergency part is over, I'd say. Next IPN delivery attempt should receive the 200 OK. [02:06:49] seems like a lot of moving targets [02:06:56] I'm just working late today to catch up w/ some time missed [02:07:27] should i be able to log in to the redis server and check the queue? [02:07:47] There it is: lrange jobs-paypal 0 -1 [02:07:58] Wanna enfire the job runner? [02:08:06] Did ejegg|afk make a Jenkins job already? [02:08:25] ah good question [02:08:32] it's just the same job job with a queue param right? [02:09:05] uh [02:09:09] I think it's a new runner [02:09:20] Which one were you gonna clone? [02:10:12] Adyen SmashPig job runner is using the StompJobRunner :-/ [02:10:42] sorry, you're way ahead of me, lemme just wait for u to explain! [02:11:27] haha never [02:11:52] i guess i thought there was a generic Job processor already [02:12:05] I learned last week that there's a new RedisJobRunner [02:12:12] we get to pilot it like right now [02:12:22] in jenkins? [02:12:30] ooh i see [02:12:33] not in jenkins yet [02:12:46] yes, that [02:12:56] Have u made a new job yet? [02:13:32] nope just looking at that now [02:13:37] New Job -> Copy existing job [02:13:45] Prolly fine to start with the Adyen runner [02:14:02] err start *cloning from [02:15:07] awight: QueueJobRunner? [02:16:39] cwd: That must be the one! [02:16:53] * awight find self reading BaseQueueConsumer::getQueue again [02:17:22] We should have a class to.. encapsulate queues. It would be just this function. [02:19:11] awight: something beyond config->object? [02:20:22] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Orphan rectifier is breaking fredge consumer - https://phabricator.wikimedia.org/T146244#2654795 (awight) [02:21:05] getQueue is just config->object preceded by some nasty to set 'queue' [02:21:52] not that i mind it being implicit but i don't like that it's easy to screw up [02:22:30] i'm still confused that it didn't blow up when i changed it to queue->object [02:23:37] wat [02:28:22] i changed the tests and expected the same class not found error [02:31:42] I would have to see it to know quite whatchu mean... [02:33:22] How are you running the job locally, if not via jobrunner? [02:33:41] I guess that's what the tests are for [02:36:49] i thought that "no class specified" error was from using basequeueconsumer::getQueue in the test instead of config->object [02:37:53] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: Orphan rectifier not sending to payments-initial nor payments-fraud queues - https://phabricator.wikimedia.org/T145848#2654810 (awight) Sends to the fredge (and breaks it), and paymen... [02:37:55] sort of moot since specifying the queues fixed it but i'd like to understand [02:38:30] cwd: oh interesting point, that would be a problem [02:39:24] ah no, in the tests we use BaseQueueConsumer, which "correctly" adds "queue". [02:39:34] But the *producing* code uses a bare config->object [02:40:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, FR-ActiveMQ, and 3 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#2654814 (awight) [02:40:32] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 2 others: [Epic] Rewrite all queue clients to use a single shim library, improve library - https://phabricator.wikimedia.org/T133108#2654813 (awight) Open>Resolved [02:40:52] awight: yeah but i changed the tests to use config->object but don't get an error [02:40:56] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 7 others: [Epic] Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2654816 (awight) [02:40:59] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 8 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2654815 (awig... [02:41:35] cwd: Can I see? [02:41:45] sure one sec [02:41:48] thanks for hanging out [02:42:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Write CiviCRM extension to view pending db records - https://phabricator.wikimedia.org/T134191#2654825 (awight) [02:42:44] Fundraising-Backlog, FR-ActiveMQ: Remove KeyValueStore from PHP-Queue - https://phabricator.wikimedia.org/T133190#2654826 (awight) [02:42:46] Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 2 others: [Epic] Rewrite all queue clients to use a single shim library, improve library - https://phabricator.wikimedia.org/T133108#2654827 (awight) [02:42:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 4 others: [Epic] Consolidate "pending" queue usages - https://phabricator.wikimedia.org/T130897#2654824 (awight) Open>Resolved [02:43:19] (PS1) Cdentinger: Use config for test queue instantiation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311892 [02:44:21] (CR) jenkins-bot: [V: -1] Use config for test queue instantiation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311892 (owner: Cdentinger) [02:44:36] cwd: It succeeds cos we added the 'queue' key to SmashPig.yaml, I believe [02:45:29] I'm realizing, in the future where we only use one queue server, the per-queue configuration should be optional, and only when we're overriding something. Right? [02:45:36] awight: well i was on an old checkout...now there's something else [02:46:08] awight: yeah sounds right to me, just the names? [02:46:08] Or maybe we should be explicit about which queues we expect to use [02:46:18] yeah maybe that's a sane middle ground. [02:46:32] btw, I'm not feeling particularly useful--want me to write the new Jenkins job? [02:46:49] ejegg: hehe, we've enfired the new SmashPig listener [02:46:54] sorry I missed all the action! [02:46:58] it's on /paypal2 for now, happily [02:47:14] how's its hearing? [02:48:37] I smacked it with a wget and it eventually made a nice sound, about 200Hz... [02:49:07] Still waiting for the official IPN retry to land [02:49:08] hehe, well tuned [02:49:40] My donation made it thru stage 1, but now we're firing up the QueueJobRunner [02:49:43] why the change of heart on verifying in the frontend? [02:50:04] man i am so confused right now [02:50:11] ejegg: eh? In backscroll? [02:50:21] otherchan backscroll [02:50:29] ah yeah I was gonna reply there [02:50:31] git show shows changes that are not applied [02:50:49] hrm [02:50:50] where [02:51:04] i want to make a gif of my screen [02:51:14] i've seen tyler do it and it would explain this [02:51:35] https://giphy.com/gifs/pong-video-games-7izvpUrQVlUVG [02:51:37] but git show shows some changes [02:51:50] but when i open the file the changes are not applied [02:53:13] sounds like something in the staged, uncommitted "index" [02:53:26] I'll go ahead and make the job... [02:54:03] augh thanks [02:54:14] ejegg: the JobQueueConsumer looks recent and ready, yeah? [02:56:43] (Abandoned) Cdentinger: Use config for test queue instantiation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311892 (owner: Cdentinger) [02:57:43] (PS1) Cdentinger: Make PayPal tests get queues directly from config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311893 [02:58:39] cwd: You've got mail :) [02:58:51] I thought we fixed that. [02:58:59] sigh [02:59:10] awight: tangential but that's the one i thought should fail ^ [02:59:51] cwd: Yr new job is ready: "WIP PayPal SmashPig job runner" [03:00:04] It's set to only "build now" and not cron [03:00:27] thanks! output looks interesting [03:00:53] cwd: I think your test success is still explained by hardcoding the "queue" key. Why would it fail, now? [03:01:05] ah crap you are right [03:01:21] i was working on an old checkout and forgot i fast forwarded [03:02:30] But on other news, what happened to the RunnableJob interface patch? [03:02:54] wat. [03:03:10] oops, I misread the error [03:03:43] awight: that does seem to be a problem though [03:03:58] Huh? RunnableJob implements Runnable, right? [03:04:24] totally. I'm baffled [03:04:51] i'm guessing the message parsing is the root error? [03:04:59] mm? [03:05:09] it's got the right class name in the error message... [03:05:19] so it's not a rehydration problem [03:05:24] My only guess is that $jobObj is still a string [03:05:34] nope. [03:05:36] get_class [03:05:45] isn't that the top level exception router that is trying to send to damaged? [03:06:22] aha, missing using statement in jobQueueRunner. one sec [03:06:30] yeah but the source of the exception is JobQueueRunner line 33 [03:06:35] oh? [03:06:40] ah ha! [03:06:42] nice one [03:06:49] PHP. [03:07:03] Did I mask a top-level namespace Runnable? [03:07:08] not an instance of this class i don't know about anyway... [03:07:11] s/mask/shadow/ [03:07:12] ooh, maybe? [03:07:24] or something in a library [03:07:30] no. [03:07:36] well that's an amazing PHP behavior. [03:08:09] (PS1) Ejegg: Missing use statement [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311895 [03:08:11] Thanks for finding that before I ouroboroused. [03:08:19] hehe [03:08:31] (CR) Awight: [C: 2] "Good find!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311895 (owner: Ejegg) [03:08:36] I can deploy... [03:08:53] thanks! [03:09:25] (Merged) jenkins-bot: Missing use statement [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311895 (owner: Ejegg) [03:09:31] thanks ejegg [03:09:44] stuff like that is why languages should be compiled [03:10:30] +1 [03:11:38] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311896 [03:11:48] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311896 (owner: Awight) [03:11:58] did that get merged before the email bot saw it?? [03:12:03] cause i didn't get an email [03:12:25] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311896 (owner: Awight) [03:12:46] The zuul gate-and-submit seems to be broken [03:12:53] someone from releng is gonna find us here... [03:13:36] !log update SmashPig from f1f55096ac20899fa9700aa0f80dece5b47a7fd3 to 4530dc9113a83bc5492a7da6f8e9ee3a6c789cda [03:13:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [03:13:52] firing job... [03:14:01] now would be a nice time to have that damaged message store UI... [03:14:26] meh lrange damaged 0 -1 [03:14:30] Oh, we could give 'em requeue dates and run that job [03:14:37] no longer a queue! [03:14:39] ooh I guess we're consuming into the db! [03:14:54] hehe I'll just illegally wget again [03:15:53] oh I suck--same failure to rsync_blast [03:16:25] lemme test the requeue job... [03:16:58] That's fancy... the job is hanging. It must be attempting to dial PayPal :) [03:17:03] outbound fw? [03:24:13] (CR) Ejegg: "oops, now addTemplate signature doesn't match addCampaign" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [03:24:37] well, I guess we'll pick this up tomorrow morning? [03:25:02] we just have to change the setting in the yaml? [03:25:17] (PS1) Awight: Correct IPN verification URL [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311897 [03:25:55] (CR) Ejegg: [C: 2] Correct IPN verification URL [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311897 (owner: Awight) [03:26:51] (Merged) jenkins-bot: Correct IPN verification URL [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311897 (owner: Awight) [03:27:11] (PS1) Awight: Move postback-url key [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311898 [03:27:20] cwd: ejegg: ^ Too street? [03:27:47] nah, it was in a funny spot anyway [03:28:29] (CR) Ejegg: [C: 2] Move postback-url key [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311898 (owner: Awight) [03:29:12] (Merged) jenkins-bot: Move postback-url key [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311898 (owner: Awight) [03:29:18] (PS1) Awight: Be strict about PayPal IPN postback response. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311899 [03:30:13] (CR) jenkins-bot: [V: -1] Be strict about PayPal IPN postback response. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311899 (owner: Awight) [03:30:15] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311900 [03:30:39] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311900 (owner: Awight) [03:30:41] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311900 (owner: Awight) [03:31:20] !log update SmashPig from 4530dc9113a83bc5492a7da6f8e9ee3a6c789cda to 6651835c816ce62112cbfea96863e4244f133c17 [03:31:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [03:31:37] uh oh, family inbound [03:31:48] sent fake IPN... [03:32:00] running job... [03:32:11] it's #5, good luck [03:32:12] gtg [03:32:23] thanks! see ya [03:33:45] so long! [03:34:01] actually, i'mma take off too. gnight cwd [03:34:58] gnight! [03:36:16] New Bug :) [03:36:20] RuntimeException@/srv/www/org/wikimedia/listeners/SmashPig/Core/QueueConsumers/JobQueueConsumer.php:35 (Job tells us that it did not successfully execute. Sending to damaged message store.) [03:43:15] (PS1) Eileen: Fix to prevent duplicate Home addresses resulting in no primary on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311908 (https://phabricator.wikimedia.org/T145873) [03:46:35] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2377255 (Eileenmcnaughton) put in review - because I still need to finish conversation with @awight regarding giving permission as fi... [03:51:20] (PS5) Eileen: Add Index to contact.preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310192 (https://phabricator.wikimedia.org/T96410) [03:51:22] (PS4) Eileen: Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) [03:51:31] (CR) jenkins-bot: [V: -1] Add Index to contact.preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310192 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [03:51:40] (CR) jenkins-bot: [V: -1] Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [03:58:54] cwd: Apparently, Job::execute is supposed to return true [04:01:30] awight|afk i was looking at that [04:02:04] but yeah good call [04:02:16] i was down the wrong path [04:03:54] (PS6) Eileen: Add Index to contact.preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310192 (https://phabricator.wikimedia.org/T96410) [04:03:56] (PS5) Eileen: Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) [04:05:27] This experience is definitely pointing towards integration being the more practical type of test [04:15:06] i should have made sure this was more production ready [04:15:57] (PS1) Cdentinger: Return true from job&execute() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311910 [04:31:36] hasta mañana [05:56:41] (CR) Awight: [C: 2] Make PayPal tests get queues directly from config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311893 (owner: Cdentinger) [05:57:19] (CR) Awight: [C: 2] Return true from job&execute() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311910 (owner: Cdentinger) [05:57:35] (Merged) jenkins-bot: Make PayPal tests get queues directly from config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311893 (owner: Cdentinger) [05:58:06] (Merged) jenkins-bot: Return true from job&execute() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311910 (owner: Cdentinger) [05:59:30] If it's close enough that the deployer can straighten things out, then good show! [06:02:26] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311920 [06:02:38] (CR) Awight: [C: 2 V: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/311920 (owner: Awight) [06:03:05] !log update SmashPig from 6651835c816ce62112cbfea96863e4244f133c17 to f308ba490635c75b6fe735e7dc1c558250202365 [06:03:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [06:03:19] (PS6) Eileen: Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) [06:04:25] cwd|afk: 2016-09-21T06:04:08+00:00 [INFO ] {SmashPig-QueueJobRunner::SPCID-1174752483} Processed 1 (1 successful) jobs in 1 seconds. [06:06:48] sad trombone: Error: CIVI_REQ_FIELD Required Field 'currency' not found in message. Required Field 'gateway_txn_id' not found in message. Positive amount required. [06:08:46] wat. type=web_accept but "gateway_refund_id" [06:32:48] (PS1) Awight: Tweak normalized field names [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311923 [06:44:44] (PS1) Awight: more field tweaks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311925 [06:48:19] cwd|afk: Inexplicable... Why is QueueJobRunner talking about 2016-09-21T06:04:08+00:00 [DEBUG ] {SmashPig-QueueJobRunner::SPCID-1174752483} STOMP server connection success. [13:57:37] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reintegrate Ingenico rtbt_enets payment method - https://phabricator.wikimedia.org/T141989#2655947 (MBeat33) Donors are still seeing this error message after selecting enets @ https://donate.wikimedia.org/wiki/Special:FundraiserLandingPage?usel... [14:31:23] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2656021 (AndyRussG) Confirmed that this is a server-side error and is happening. Bad HTML content coming in with the banner URL. F... [14:31:38] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2656022 (AndyRussG) p:Triage>Unbreak! [14:35:32] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2656028 (Pcoombe) It seems to vary by site e.g. works on Meta desktop (https://meta.wikimedia.org/w/index.php?title=Special:Banner... [14:37:05] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2656046 (AndyRussG) [14:51:19] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2656057 (AndyRussG) Here's the call that's failing: https://github.com/wikimedia/mediawiki-extensions-CentralNoti... [15:09:24] (CR) Anomie: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311515 (owner: L10n-bot) [15:47:31] (PS2) Anomie: Remove pre-1.25 API compatibility code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 [15:49:25] (CR) jenkins-bot: [V: -1] Remove pre-1.25 API compatibility code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 (owner: Anomie) [16:00:56] (PS3) Anomie: Remove pre-1.25 API compatibility code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 [16:33:32] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Issues manually merging records - https://phabricator.wikimedia.org/T144440#2656430 (RLewis) @Eileenmcnaughton I did 3 merges and they appeared to work correctly for me. [16:41:45] (CR) Cdentinger: [C: 2] Tweak normalized field names (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311923 (owner: Awight) [16:42:30] (Merged) jenkins-bot: Tweak normalized field names [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311923 (owner: Awight) [16:42:32] (CR) Cdentinger: [C: 2] "Thanks!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311925 (owner: Awight) [16:43:32] (Merged) jenkins-bot: more field tweaks [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311925 (owner: Awight) [17:03:39] AndyRussG: what's your opinion on changing the addX function signatures to take booleans instead of ints? [17:03:59] Good idea / bad idea / good-but-not-in-the-same-patch? [17:09:31] morning ejegg [17:09:36] hi cwd [17:09:51] anything I can help with on the paypal listener? [17:10:07] are we ready to start mirroring the donations queue? [17:10:13] well i'm just looking at the job adam made here [17:10:25] and the output says "Attempting connection to STOMP server" [17:10:26] ?? [17:10:38] and then the name of the STOMP server [17:10:42] ok, sounds right [17:10:51] so it's actually queueing up donations [17:11:06] ooh, right [17:11:06] the consumer would just drop them as duplicates [17:11:14] ok i see now [17:11:17] i need to add logging [17:11:47] always helpful! [17:12:05] i guess i expected more default logging? i used (mostly) the normal procedures [17:12:14] minus a few pieces [17:13:11] but i don't see anything in the output before that [17:18:49] yeah, there's not a lot by default [17:24:15] hmmm anyone else notice that phabricator emails are failing spf all of a sudden? does ops know about this? [17:24:22] dstrine wondering if you think I should raise an alarm [17:28:00] are you on the devtools IRC chat? [17:28:07] nope [17:28:14] I can be… [17:28:30] is that what you’d suggest? [17:28:48] you can post there: #wikimedia-devtools [17:29:16] or make a task for mukunda in the phabricator project [17:31:58] fr-tech any scrum of scrums news? [17:32:18] None here [17:32:46] all good here [17:35:59] thanks dstrine, made a task [17:39:58] ok cool. That channel may be useful to you in general [17:46:49] ejegg|meet: hey... yeah exactly, good idea but yeah a different patch is better ;) [17:50:59] Back later!!! [17:51:01] :) [17:51:12] thx!!!!! [17:56:20] cwd|afk: Holler if I can help more with the SmashPig PayPal listener [18:01:56] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Issues manually merging records - https://phabricator.wikimedia.org/T144440#2656808 (RLewis) @Eileenmcnaughton - one thing Leanne and I thought would be helpful to assist in manual mergin... [18:03:52] Awight, thanks, running errands, will finish that up in a bit [18:11:06] (PS4) Anomie: Remove pre-1.25 API compatibility code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 [18:18:13] (PS12) Ejegg: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) [18:36:52] fundraising-tech-ops: replace boron (fundraising build server) with new hardware running jessie - https://phabricator.wikimedia.org/T145117#2620535 (RobH) My understanding is we do not need these systems in place urgently, but only by end of Q2. [18:38:45] (PS1) Ejegg: Use booleans in function signatures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312063 [18:39:20] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2615300 (awight) a:awight [18:47:24] Fundraising-Backlog, FR-Paypal, FR-Smashpig, Recurring-Donations: Should import new email address when PayPal recurring donor changes their PP profile contact - https://phabricator.wikimedia.org/T146309#2657013 (awight) [18:47:29] MBeat: fyi ^ [18:47:48] cool, ty! [18:48:06] (PS1) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [18:51:34] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1003 and pay-lvs1004 - https://phabricator.wikimedia.org/T143900#2657030 (Jgreen) [19:03:19] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1003 and pay-lvs1004 - https://phabricator.wikimedia.org/T143900#2657079 (Jgreen) @Cmjohnson could you take a look at BIOS/ILOM settings for pay-lvs1004? I tried to pxeboot-image it and the process kept croaking immediately after fetching... [19:03:32] fundraising-tech-ops, Operations, ops-eqiad: Rack/Setup pay-lvs1003 and pay-lvs1004 - https://phabricator.wikimedia.org/T143900#2657080 (Jgreen) p:Triage>Normal [19:05:25] (PS1) Ejegg: Use IDatabase in function signatures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312073 [19:09:02] (PS1) Awight: Detect fancy new curved angle brackets. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312074 (https://phabricator.wikimedia.org/T144952) [19:09:38] fr-tech: ^ A hair of CN review, whoever gets to it... [19:10:58] oho [19:11:33] recent core change? [19:12:17] yep [19:12:33] I still haven't found the actual change, but can prove to myself that it's real with mwrepl metawiki [19:12:53] print_r(RequestContext::getMain()->msg( 'notamessage' )->inLanguage( 'en' )->text()); [19:12:53] mwrepl? [19:13:07] Underdocumented tool to get an interactive shell in MediaWiki context (on tin) [19:13:23] cool! [19:13:32] wicked useful. [19:13:42] (PS1) Ejegg: Fix paren nesting bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312075 [19:14:14] (CR) Awight: [C: 2] "Good find!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312075 (owner: Ejegg) [19:16:33] (CR) Awight: [C: 2] Fix typos and PHPdoc hints (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 (owner: Ejegg) [19:17:05] (CR) Awight: [C: 2] Use IDatabase in function signatures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312073 (owner: Ejegg) [19:17:55] (CR) Ejegg: "oops, I was just fixing this locally to be style-only! grandparent patch is still unmerged though" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 (owner: Ejegg) [19:19:44] awight: weird, grepping log -p for latest mw core doesn't turn up those char codes anywhere [19:20:10] (CR) Awight: [C: 2] "Nice cleanup :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312063 (owner: Ejegg) [19:20:42] ejegg: right? I'm imagining they used a bytewise encoding, see all the ways to spell it http://www.fileformat.info/info/unicode/char/29fc/index.htm [19:23:30] oh hey, there's every single codepoint in some old UTF-8 test files [19:23:50] hehe [19:24:12] so weirded out. I guess I'll have to just read the code. [19:24:20] It's outside of MessageCache, and inside of Message [19:24:25] but if it's empirically demonstrable... [19:25:12] the hell, man. Message.php line 810 [19:25:13] oh, it's just the utf-8 char in the source code! [19:25:16] maybe I have an old checkout [19:25:17] right?? [19:25:20] oh wait [19:25:27] * awight pulls new code [19:25:30] hehe [19:25:59] ok I'm on board. Message::toString [19:26:00] DI will need something for that too, I think [19:27:27] (CR) Ejegg: [C: 2] "Good catch! Hmm, did they turn off strict mode for CI?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312074 (https://phabricator.wikimedia.org/T144952) (owner: Awight) [19:28:26] ejegg: Hmm, looks like there's nothing in DI or crm that checks for angle brackets [19:28:45] oh cool, guess we switch over to messageExists [19:28:49] *switched [19:29:08] yah and Language::getMessageFor [19:29:19] (CR) Jforrester: [C: 1] "Changes LGTM. Does someone from Fundraising Tech want to double-check and C+2?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/311780 (owner: Anomie) [19:29:23] scary. Maybe we can use that in CN though [19:30:14] (CR) Jforrester: [C: 1] "Changes LGTM. Does someone from Fundraising Tech want to double-check and C+2?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/311776 (owner: Anomie) [19:31:30] (CR) Awight: "@anomie Are we supposed to migrate this documentation somewhere else? It's just that one line in extension.json -> APIModules?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/311780 (owner: Anomie) [19:32:45] (PS2) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [19:33:53] (Merged) jenkins-bot: Detect fancy new curved angle brackets. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312074 (https://phabricator.wikimedia.org/T144952) (owner: Awight) [19:36:56] (CR) Ejegg: [C: 2] Revise update to primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311885 (https://phabricator.wikimedia.org/T143062) (owner: Eileen) [19:40:23] (Merged) jenkins-bot: Revise update to primaries not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311885 (https://phabricator.wikimedia.org/T143062) (owner: Eileen) [19:41:39] (PS1) XenoRyet: Move Unsubscribe Queue Consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/312084 (https://phabricator.wikimedia.org/T145419) [19:44:45] ejegg: thanks for that [19:45:04] eileen: thank you! [19:45:19] I owe you another look at the big scary patches too... [19:49:06] (CR) Anomie: "The documentation was migrated almost two years ago, in I67395aff4." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/311780 (owner: Anomie) [19:50:15] (CR) Ejegg: "looking good so far, just a couple suggestions" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/312084 (https://phabricator.wikimedia.org/T145419) (owner: XenoRyet) [19:50:29] (CR) Anomie: "> The documentation was migrated almost two years ago, in I67395aff4." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/311780 (owner: Anomie) [20:19:40] (PS7) Eileen: Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) [20:20:18] (CR) jenkins-bot: [V: -1] Update preferred language based on contribution_tracking. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [20:29:32] Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog: SPRINT Q (8/31 - 9/14) Goal: finish Queues and fix bugs - https://phabricator.wikimedia.org/T144449#2657363 (DStrine) Open>Resolved [20:34:26] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Unplanned-Sprint-Work: Dedupe: resolve Conflicts on capitalisation of names - https://phabricator.wikimedia.org/T145032#2657409 (DStrine) [20:36:47] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: CN: Stop using the geoiplookup HTTPS service (always use the Cookie) - https://phabricator.wikimedia.org/T143271#2657416 (DStrine) [20:37:18] Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog, FR-Paypal, MediaWiki-extensions-DonationInterface, and 3 others: PayPal's payments-init messages are inaccurate - https://phabricator.wikimedia.org/T144562#2657431 (DStrine) [20:40:48] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising-Backlog: Civi email merge won't retain new email address - https://phabricator.wikimedia.org/T143236#2657442 (DStrine) [20:42:27] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 3 others: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2657446 (DStrine) [21:06:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097#1896635 (BBlack) This has been idle a while, but it's still probably a good idea. Does anyone have thoughts on an appropriate lifetime? My initial thought is we should... [21:42:51] (PS1) Cdentinger: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/312118 [21:46:44] (PS2) Ejegg: Test Configuration merge edge case [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311886 (owner: Awight) [21:46:52] (CR) Ejegg: [C: 2] Test Configuration merge edge case [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311886 (owner: Awight) [21:48:44] (Merged) jenkins-bot: Test Configuration merge edge case [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311886 (owner: Awight) [21:52:01] (CR) Ejegg: [C: 2] "Looks legit!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/311645 (owner: Eileen) [21:53:20] ejegg: no +2 button on SP/deployment cause no CI? [21:53:45] err, really? [21:53:56] you mean just the shortcut button? [21:53:59] am i crazy? https://gerrit.wikimedia.org/r/#/c/312118/ [21:54:02] yeah [21:54:06] That seems to disappear on me randomly [21:54:19] oh, maybe it's there when v+2? [21:54:45] must be [21:54:53] so we just manually do both for this deployment branch? [21:56:06] (Merged) jenkins-bot: Fix url for batch merge link [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/311645 (owner: Eileen) [21:56:31] cwd yeah I guess we do [21:56:51] i haven't deployed smash pig in a coon's age [21:58:15] ejegg: that merge look normal to you? [21:59:14] cwd yep! [21:59:18] (CR) Cdentinger: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/312118 (owner: Cdentinger) [22:02:14] huh weird i don't see that in zuul [22:04:48] ooh, might have to manually submit too [22:05:10] that repo had no deployment branch for a long time [22:05:18] I guess we just never set up CI [22:05:33] oh, funny that it still gets that comment [22:05:35] (CR) XenoRyet: Move Unsubscribe Queue Consumer off ActiveMQ (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/312084 (https://phabricator.wikimedia.org/T145419) (owner: XenoRyet) [22:05:46] (PS2) XenoRyet: Move Unsubscribe Queue Consumer off ActiveMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/312084 (https://phabricator.wikimedia.org/T145419) [22:08:28] !log updated SmashPig from f308ba490635c75b6fe735e7dc1c558250202365 to 8ac116037440746eaf64b9e99e1ee962d5d33475 [22:08:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:10:35] ejegg: now i see why you wanted that damaged message UI [22:10:56] yeah... i got distracted from that stuff :( [22:11:04] (PS1) Awight: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/312121 [22:11:17] db ui is always awful [22:11:25] but i would love to have a big green "reschedule" button [22:11:31] cwd: Yeah I was noticing the broken SP deployment CI yesterday... [22:11:52] I hate not knowing if it's broken or not, since clicking "Submit" when it's *not* broken will hang zuul for unfathomable reasons [22:12:02] yeah [22:12:07] CI is complicated [22:12:29] (CR) Awight: [C: 2] Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/312121 (owner: Awight) [22:13:28] awight: i took all day deploying those simple changes but i wanted to get up to speed on how to look at the db/queue action [22:13:44] did you do any rescheduling of the damaged jobs? [22:13:52] most of the stuff in there is jobs-paypal [22:14:11] (Merged) jenkins-bot: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/312121 (owner: Awight) [22:14:20] cwd nope, not yet. want me to toss a couple back on the pile? [22:14:23] also i feel like it is good that we do not alter the incoming message [22:14:33] now that i see the use case, rescheduling should start from zero [22:14:41] ejegg: if you don't mind that would be great [22:16:55] ejegg: what is the job that will move damaged stuff back to the original queue? [22:17:47] cwd 'Requeue delayed messages' [22:18:03] lemme run that now, don't think it's actually been tested [22:18:17] fun times [22:18:24] heh, fail [22:18:46] fwiw, I have a wget packet I can throw at the new IPN endpoint all day, if it's useful. [22:19:02] d'oh, missing data-store/jobs-paypal/class key? Hmm [22:19:10] shouldn't be... [22:19:25] it's in SmashPig.yaml [22:19:45] i feel like that error catches some unrelated stuff [22:19:48] cwd ooh, it's under the paypal key [22:19:49] i have definitely seen it a lot [22:20:04] That job is running with the default config node [22:20:15] Pretty sure there's no way to get that error unless it's actually true. [22:20:18] I can do a one-off run with the paypal config node [22:20:29] ah hmm [22:20:32] what is the real fix for that? [22:20:41] but I think we need to move the data-store to the main section [22:21:10] i guess since the queue is namespaced it doesn't matter [22:21:25] awight: i'm sure you're right and i just don't understand how config gets merged [22:22:40] ejegg: I would have thought that we're running the queuejobrunner with --config-view=paypal ? [22:23:06] awight this is the requeue delayed messages job [22:23:16] ooh k [22:23:43] btw I'm about to deploy the CentralNotice fix, just trimming the rudder now [22:25:26] cwd ok, requeued one of those jobs [22:25:47] nice, i see it [22:27:50] well it got consumed [22:28:42] with no fail mail [22:29:16] woohoo! [22:29:19] so now i guess there should be something on the jobs active mq? [22:30:41] cwd donations activemq? [22:31:05] err wait, is verified right? [22:33:25] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310219 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [22:37:24] (PS7) Eileen: Add Index to contact.preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310192 (https://phabricator.wikimedia.org/T96410) [22:40:37] (CR) Ejegg: [C: 2] "Adding this with the understanding that we will remove it after language maintenance is completed." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310192 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [22:42:52] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Patch-For-Review: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2657832 (awight) From now on, when this condition happens we should see a logline in `fluori... [22:44:06] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2657834 (Eileenmcnaughton) OK spoke with ejegg & we thought the permission was OK - added @LeanneS - should work now [22:44:17] (Merged) jenkins-bot: Add Index to contact.preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310192 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [22:46:10] cwd: Where do we go from here? Are you satisfied with the imported data quality or want some review on that? [22:46:45] If it looks good, we can set up the cron jobs and plan to flip the IPN redirect over to the new code tomorrow. (or Jeff_Green is still around?) [22:47:36] cwd: I'd like to feed a recurring charge through the new endpoint, too. Want me to send one out from my local? [22:47:50] awight: if you already have that set up then heck yeah [22:48:12] cool, doing now [22:49:28] cwd: aww nuts, check the source_* fields on my contribution. [22:49:40] source_type = parse_nightly [22:49:57] K i'll send another one-time donation as well [22:51:01] awight: what should that one say? [22:51:13] It means we didn't get it through the listener [22:51:29] oh hrm [22:51:37] bummer [22:51:44] why was it on the damaged queue i wonder? [22:51:53] source_type on the message we're looking for might be wrong btw, but it would say "payments" if anything [22:51:58] hrm [22:52:06] That's mysterious. You sure about that part? [22:52:24] I was thinking the contribution was rejected as a duplicate. Can you check job logs on the stage 2? [22:54:40] Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Patch-For-Review, Spike: Spike: Zendesk migration from Web Portal to Helpdesk - https://phabricator.wikimedia.org/T143142#2657854 (MBeat33) I migrated the Hub today, with no effects on the donor... [22:54:56] derp yeah [22:54:58] DUPLICATE_CONTRIBUTION [22:55:09] well that's expected behavior anyway [22:58:42] awight: you gonna try that recur? i can start setting that up if not [22:59:09] one moment... [23:01:22] cwd: Okay there goes a $1.02 one-time donation... [23:01:37] 66M69751C1238122L [23:02:40] i see it in jobs-paypal [23:02:40] Here comes a $1.03 recurring subscription [23:03:01] running the consumer [23:03:42] subscription created. charge ID (i believe) is 71D27890NV8577213 [23:04:06] k, waiting on the listener... [23:07:28] still don't see the recurring one [23:07:48] maybe the msg takes a while? [23:09:37] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2657884 (LeanneS) @Eileenmcnaughton thanks - it seems to be working! [23:10:29] I see that it's been sent, actually [23:18:46] cwd: oh bad. Looks like we only got one paypal message through the new endpoint, which means the notify_url param doesn't work for recurring charges? [23:19:05] did it hit the old one? i don't see nothing in civi [23:19:26] wat. It specifies the new URL even. [23:19:28] (PS3) Eileen: Only store the full country code if it is on our valid list. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310732 (https://phabricator.wikimedia.org/T96410) [23:19:33] OK I'm gonna wget this [23:20:16] oops [23:20:18] no I see. [23:20:19] It did send to the old endpoint. [23:21:29] Well, I'll wget anyway, to let the new endpoint have a crack at it. [23:22:00] cool...it should fail as dupe? [23:22:13] yah, unfortunately [23:22:22] There it is [23:22:24] (still don't see it in civi) [23:22:30] (PS3) Ejegg: Update English languages to only keep a small number of recognised variants [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311503 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:22:35] yep [23:22:41] want me to consume? [23:22:55] be my guest! [23:23:38] Undefined property: SmashPig\PaymentProviders\PayPal\Message::$date @ [23:23:42] not fatal tho [23:23:44] Now we're talking ;) [23:24:05] maybe greek that message and jam it into a test fixture [23:24:13] good call [23:26:26] awight: this should have pushed to the recurring queue? [23:26:47] cwd: Intriguing, https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNSimulator/ [23:26:50] cwd: yeah [23:27:00] oh nice [23:27:13] awight: cool if i build that now? it's on a slow cycle [23:28:28] anything you want man [23:28:33] just lmk what I can do to help [23:29:38] looks like it processed [23:29:46] then it will schedule a donation? [23:30:00] (CR) Eileen: [V: -1] "Note there is a gap here around it only getting 2 letter languages from Civi at the moment" (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/311491 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:30:23] cwd: yeah that should happen pretty quickly [23:31:17] (PS1) Awight: Fix bad ternary [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312139 [23:32:02] cwd: So the charge went through, but it hit the old endpoint. [23:32:18] here, I'll wget it to the new code [23:32:42] ooh, the recurring code initiated a charge that went to the old endpoint? [23:32:43] sent. [23:32:57] it's just a flaw in the "notify_url" param, I believe. [23:33:06] doesn't seem to work for recurring. [23:33:08] gotcha [23:35:14] I sent that subscr_payment... gonna run the queuejobrunner again [23:35:36] huh, empty. Maybe it was in the last run? [23:35:49] i ran it [23:35:57] cool. Same $date error as the subscr_signup [23:35:59] that one should have gone to donations and not recurring? [23:36:06] uh. yeah I think so. [23:36:16] not seeing it [23:36:18] or in civi [23:36:31] Needs logging [23:36:41] Also, what is the STOMP about? [23:37:04] jobs queue is still stomp [23:37:09] err donations i mean [23:37:22] job consumer writes to there [23:37:26] nuts. ok [23:38:44] awight: just ran recurring and had a new one [23:38:54] does every recurring charge get a recurring job? [23:39:03] eh? [23:39:20] it's in civi now too [23:39:23] the recurring queue consumer is like the others, it runs on a preset schedule [23:39:33] Yah but probably through the old listener, no? [23:40:17] uh i'm not sure [23:41:01] no, that's the new one! [23:41:11] nice [23:41:14] source_host [23:41:15] barium [23:41:18] ah yeah [23:41:22] also, SmashPig\PaymentProviders\PayPal\Message [23:41:27] excellent [23:41:42] not sure why it didn't make it from the old one... [23:41:49] you win! :) [23:42:15] You agree we should switch over the endpoint tomorrow, or would you rather tinker? [23:42:35] i'm going to do some light fiddling tonight but yeah i say we do it tomorrow [23:42:37] uh. that failmail will have to go [23:42:41] nice [23:42:42] i'll fix that date error [23:42:44] yeah [23:42:48] and write the recurring test [23:43:04] ok cool well this coffee shop is closing so i gotta bounce, back later! [23:43:05] It sure looks better than the new orphan rectifier [23:43:21] hehe [23:43:38] (PS3) Eileen: Rely on CiviCRM address rather than contribution tracking language. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/311491 (https://phabricator.wikimedia.org/T96410) [23:45:38] (CR) Ejegg: [C: 2] "Seems sane and safe enough. I'm paranoid about accumulating civi api calls 'cause they seemed to take a lot of time when I profiled." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310732 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:48:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Periodically run Civi contact import performance tests, note trends - https://phabricator.wikimedia.org/T146338#2657931 (Ejegg) [23:50:21] (CR) Ejegg: [C: 2] "Nice incremental improvement." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311503 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:50:45] (Merged) jenkins-bot: Only store the full country code if it is on our valid list. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310732 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:53:16] (CR) Ejegg: "AndyRussG, I split out the function signature change. Ready for another round of review!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [23:54:15] (Merged) jenkins-bot: Update English languages to only keep a small number of recognised variants [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/311503 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:55:21] (CR) Ejegg: "Besides updating existing data, have we tracked down all the code paths that were creating these _xx preferred languages?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/310724 (https://phabricator.wikimedia.org/T96410) (owner: Eileen) [23:59:54] (PS4) Eileen: Rely on CiviCRM address rather than contribution tracking language. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/311491 (https://phabricator.wikimedia.org/T96410)