[00:40:07] (PS1) Ejegg: WIP local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [01:15:04] (PS2) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [01:23:03] (PS1) Ejegg: Add timezone column to export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/316730 (https://phabricator.wikimedia.org/T148578) [01:24:05] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2727497 (Ejegg) a:Ejegg [01:27:59] (PS3) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [02:11:49] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 5 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2727543 (AndyRussG) @aaron thanks for the explanation! Just to check,... [02:22:56] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 5 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2727545 (aaron) When lag is > 7 seconds, the TTL cap is TTL_LAGGED, w... [04:21:18] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 5 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2727598 (AndyRussG) Ah K thanks... Mmmm just to follow up, to check t... [13:16:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: BUG: Campaign date fields cannot be edited as text - https://phabricator.wikimedia.org/T97159#2728591 (amritsreekumar) @awight I am running on Mediawiki 1.28 (alpha) in my system and I have edited the end time as said in the instructions... [16:11:57] fr-tech missing tech talk today 4 appointment, apologies... [16:12:01] cya sooon! [17:00:56] fr-tech: You'll always be, [17:00:56] What you always were, [17:00:56] Which has nothing to do with, [17:00:56] All to do, with her. [17:00:56] -- Company [17:00:57] -- discuss. [17:02:08] (PS1) Cdentinger: adds 'rejects' to smashpig paypal config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 [17:11:49] (CR) Ejegg: [C: -1] "just needs a bool inverted" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 (owner: Cdentinger) [17:16:06] ejegg: hmmm, doesn't returning true to drop the message seem weird semantically? [17:16:58] not really - true just means 'we finished without problems' [17:17:20] as far as the job runner is concerned [17:17:42] though I guess all problems could be conveyed via exceptions [17:18:20] hmmm, RejectedException? [17:18:59] it's not really an exception for these types though, right? [17:19:15] Dropping the message when we're done processing is the normal behavior [17:19:18] yeah [17:19:26] that's true [17:19:34] it's just that processing these types is a no-op [17:19:43] yeah, that sounds good to me [17:25:32] scrum of scrums is coming up [17:25:43] fr-tech got any news or requests? [17:26:03] not here, thanks [17:27:50] (PS2) Cdentinger: adds 'rejects' to smashpig paypal config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 [17:32:09] (PS1) Ejegg: Show reference # for inline errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316824 [17:32:31] (PS3) Cdentinger: adds 'rejects' to smashpig paypal config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 [17:33:51] (CR) jenkins-bot: [V: -1] Show reference # for inline errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316824 (owner: Ejegg) [17:37:32] ejegg: is there junk data around with which to populate the damaged db to test the interface? [17:38:35] cwd hmm, I had two entries from earlier tests and just kept inserting into damaged (select from damaged) to double & redouble them [17:39:02] so mine are actually not very random [17:39:55] i wonder if it'd be worth having something in the repo [17:40:07] test data is always nice! [17:40:11] some of the tests should produce damaged records, though they just go in temporary storage [17:40:36] I bet that mockaroo thing would help here [17:41:21] something i think about is having a switch to flip and make the tests use real data stores [17:41:58] hmm, just change the testing yaml files? [17:42:03] and a way to say "don't clean up after yourself" [17:42:17] run all the tests and have a populated db after [17:42:41] that might be useful for QA type of testing [17:42:51] clicking around civi frex [17:44:22] there's a bunch of test data for successful donations in the dash repo [17:55:56] cwd ok, SoS is done, I can fabricate some damaged message queue entries [17:56:22] ejegg: is there a test that does that already? [17:56:43] p.s. damaged should be under smashpig right? i just did drush updatedb but still don't see that table [17:57:02] cwd oh yeah, it's not covered under drush [17:57:12] just has its own scripts in SmashPig/schema [17:57:21] oh yeah that makes sense [17:57:33] it's separate from drupal [17:58:13] is there a maintenance script to run the migrations? [18:06:42] cwd not yet, but I started one: https://gerrit.wikimedia.org/r/312577 [18:07:13] actually, that might work [18:07:33] back soon [18:07:44] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Show contribution tracking ID in error messages as 'Reference #' - https://phabricator.wikimedia.org/T147679#2700637 (MBeat33) @Ejegg he Adyen... [18:30:05] fundraising-tech-ops: frack jessie integration cleanup - https://phabricator.wikimedia.org/T138222#2729530 (Jgreen) >>! In T138222#2442711, @Jgreen wrote: > Some of our older Dell boxes have broadcom bnx2 nics that require proprietary firmware which is not included with the debian install kernel as it was wi... [18:30:47] fundraising-tech-ops: frack jessie integration cleanup - https://phabricator.wikimedia.org/T138222#2729531 (Jgreen) [18:52:46] ejegg: i still have a few loose ends to tie up in boulder and time is running low. how inconvenient would it be if i took the afternoon off? i'm out tomorrow driving back too. [18:54:12] if there is particular CR that would be helpful let me know. i've been looking at the damaged interface stuff [18:56:09] eh you know i can do a few things tomorrow morning, i'll just bail a little early [19:00:14] cwd sorry, just saw this. there are a couple minor things [19:00:45] https://gerrit.wikimedia.org/r/316716 is probably most trivial [19:01:37] and the pdo queue options thing: https://gerrit.wikimedia.org/r/316499 [19:21:14] cwd I put a bunch of example damaged messages up on deployserver:/tmp/ [19:21:40] I think they're scrubbed well enough - pls let me know if you see anything that shouldn't be there [19:21:45] oh cool thanks! [19:22:23] the 'message' columns themselves are tiny and don't reflect the gateway in the actual gateway column, but I think that shouldn't matter much [19:24:19] ejegg: wait, what happens to integer keys when you array merge? [19:28:02] cwd they get renumbered to start at zero [19:28:30] but + preserves the integer keys and the result has the superset of the input keys [19:28:47] aaaah terrible [19:28:51] nice type system php [19:29:09] AndyRussG: you might want to weigh in on this cookie / localstorage survey - https://www.mediawiki.org/wiki/Requests_for_comment/Survey_Cookies/Local_Storage_on_Wikimedia [19:29:34] What? cookies??? ;p [19:30:01] legal wants to make sure the stated policy reflects reality [19:30:19] I'm guessing CN usage is pretty well vetted [19:30:39] but i think they'd appreciate a list of key prefixes [19:30:54] ejegg: interesting... yeah makes sense, thx! [19:32:01] (PS2) Ejegg: Show reference # for inline errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316824 [19:32:15] (CR) Cdentinger: [C: 2] "Good old PHP "arrays"" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/316499 (owner: Ejegg) [19:33:01] (Merged) jenkins-bot: Fix bad pdo_options merge [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/316499 (owner: Ejegg) [19:35:56] Fundraising-Backlog, FR-Paypal, FR-Smashpig: Validate paypal messages in frontend rather than job runner - https://phabricator.wikimedia.org/T148678#2729778 (Ejegg) [19:36:53] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 5 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2729791 (AndyRussG) Quoting @aaron's response on IRC about the [[ htt... [19:39:33] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 4 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2729797 (AndyRussG) [19:39:46] (PS2) Ejegg: WIP test queue stuff with PDO/sqlite [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316500 [19:40:46] cwd want me to assign you that paypal validation switch ticket? [19:41:02] yes thanks [19:41:08] should be simple [19:42:43] 1 point or 2? [19:43:13] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Paypal, FR-Smashpig, Unplanned-Sprint-Work: Validate paypal messages in frontend rather than job runner - https://phabricator.wikimedia.org/T148678#2729813 (Ejegg) a:cwdent [19:43:48] 1 point is fine [19:44:04] ty! [19:59:16] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Spike: SPIKE: investigate level of completeness of civi deduped DB - https://phabricator.wikimedia.org/T146384#2729853 (DStrine) Open>Resolved [20:00:33] !log enabled CiviCRM major gifts dedupe [20:00:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:04:38] !log disabled CiviCRM generic dedupe job [20:04:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:06:15] (CR) Ejegg: [C: -1] "Logic looks good! That exception-catching in the test freaks me out though." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 (owner: Cdentinger) [20:13:26] btw - love the sprint name! [20:14:57] hehe, it's a good one [20:15:04] (PS1) Cdentinger: API validate messages on front-end [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) [20:18:47] ejegg: little confused about the "conflicts with" here https://gerrit.wikimedia.org/r/#/c/316716/ [20:19:19] doesn't need rebase as far as i can tell [20:19:26] oh huh [20:19:38] ooh, I should really review awights test stuff [20:20:22] I was just having trouble running flake8 locally [20:20:27] but I should be able to run the nose tests [20:21:15] awight just added a comment to the update statement I change there [20:22:27] does it always show when patches conflict? [20:22:30] guess i never noticed that [20:25:12] looks like it does [20:29:59] ejegg: I think we can leave on the main dedupe contacts rather than major gifts for now - it should pick up mg & I don't think we've been gettin gthat failmail since cwd turned off the other 2 jobs [20:31:23] eileen1: ok, I'll swap it back [20:31:37] ejegg: I can - I'm in [20:32:01] For the december fundraiser though, I think maybe we should limit to just the MG one [20:32:12] That should be lower impact, right? [20:32:26] yeah - I'm torn because I think ds want new contacts deduped too [20:32:47] ie having most recent deduped = useful [20:33:32] (CR) Cdentinger: adds 'rejects' to smashpig paypal config (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 (owner: Cdentinger) [20:33:45] i wish the big +2 button would go away [20:33:53] i'm definitely going to press it by accident at some point [20:38:38] cwd isn't the exception you're catching from trying to create an object for the null type? [20:40:26] i think it's just saying the queue was empty [20:47:34] (CR) Ejegg: adds 'rejects' to smashpig paypal config (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 (owner: Cdentinger) [20:58:31] ejegg: ah you are right, sorry [21:03:26] ah dang, there are some recurring donations from 10/12 in the stomp queue that haven't made it into civi via redis [21:04:46] ah nuts [21:04:51] that's a long time. no audit? [21:05:18] phooey, i guess not [21:08:08] paypal? [21:08:40] yeah [21:10:27] howdy poppa adam [21:10:49] * awight pops the champagne [21:10:50] Thanks! [21:11:02] I'm in the cabin fever stretch of this marathon now :) [21:11:10] awight: zea? [21:11:21] Managed to get VisualEditor working on my dev wiki last night! [21:11:34] whoa, nice [21:11:44] yeah, I'm also curious about the name! [21:12:07] Zea (EP), a 1993 alternative EP from dEUS. [21:12:10] must be that [21:12:24] * cwd shows self out [21:12:40] HMM [21:12:48] * awight checks to see if I should say "yes" [21:12:59] It's a... corny choice I'm afraid [21:13:42] i thought of: https://en.wikipedia.org/wiki/Solar_symbol#/media/File:Flag_of_New_Mexico.svg [21:13:44] Zea mays (Lin.) [21:14:04] zea *wat* [21:14:30] cwd: cool--what's the connection there? [21:14:52] awight: https://en.wikipedia.org/wiki/Zia_people [21:15:07] oh cool! [21:15:13] awight: corny choice...nice [21:17:27] cwd: ah, rad! I also noticed https://en.wikipedia.org/wiki/Mari_people [21:17:51] a preliminary internet search is mos def required before any modern naming [21:18:09] nice! [21:19:19] Finno-Ugric. unique! [21:19:44] how does mari like having a sibling? [21:19:54] /o\ [21:20:02] It's been a roller coaster [21:21:02] heh yeah i have a sister that is like 4 years old and my parents said it was a little rough [21:21:14] *older? [21:21:17] they quote her saying "i'm not so sure we should have had this [21:21:21] baahaha [21:21:23] baby" [21:21:28] and yeah sorry older [21:22:02] I just heard a good one, the dad took a walk with older brother and he said: I figured out what we should do with N---: cut it up into little pieces and roll them down the hill [21:22:13] So it's not like that [21:22:25] But we're doing lots of talking about feelings [21:22:38] & I'm her dedicated attention source [21:23:39] that seems well within normal [21:23:42] How's the failmail immersion bath? Sorry I didn't leave any functional bailing buckets or lifeboats [21:24:23] i've got a patch for a couple of the paypal ones up now [21:24:32] but i have seen a few other new ones crop up [21:25:07] It'll be like christmas came early once those are just smoldering hulks smelling of urine [21:25:39] Not bothering me or anything, I just feel bad I can't help :) -- swore off any actual day job work even when on a computer [21:25:45] only goofing! [21:26:29] Is it true that ActiveMQ is dead? [21:27:37] awight: not getting anything new, but I did just discover a couple more stranded ones in the stomp recurring queue that didn't make it to Civi [21:27:52] That's amazing though [21:27:58] maybe just a matter of dumping and requeueing to Redis [21:28:00] Impressive hustle! [21:28:01] yay! [21:28:29] yes! [21:28:54] k, I need to do food stuff [21:29:41] i have to take off shortly, last night in boulder and still have 2 new babies to meet [21:30:20] Fundraising-Analysis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unnecessary queries on api calls - https://phabricator.wikimedia.org/T148688#2730061 (Eileenmcnaughton) [21:32:35] fun! [21:32:50] Sounds very productive [21:34:13] (PS4) Cdentinger: adds 'rejects' to smashpig paypal config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 [21:34:46] we packed too much in to a couple days [21:34:57] but i will be back on later tonight [21:35:34] that last PS there is a little smelly, but i feel like a garbage queue adapter lets us test a little more of the code path [21:51:16] ok well i've gotta get going, later! [22:00:07] awight: hey!!! many congrats!!!!!!!! [22:00:12] * AndyRussG just read backscroll... [22:00:22] I like "Zea" :) [22:00:43] How's the sleeplessness? [22:01:04] It's fun! [22:01:29] The mom is bearing the brunt of the sleeplessness, of course... [22:19:21] awww [22:19:28] yeah that happens.... [22:20:27] healthwise all good= [22:20:29] ? [22:21:06] The pic u sent is great! [22:21:14] You can send more if u like :) [22:21:40] yes! Things are going great, just relaxing ATM with a blubberlump on me [22:21:50] I'll make sure to include Zea in future fr-tech calls ;) [22:22:10] heheheh yeah that'd be great! [22:22:37] born in the remote-working era! [22:24:19] interestingly the kids just found in an old box we left here a pic of Sofía meeting Cecilia for the first time, and put it here on my desk [22:24:34] special times :) [22:30:33] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Spike: SPIKE: investigate level of completeness of civi deduped DB - https://phabricator.wikimedia.org/T146384#2730165 (Eileenmcnaughton) Hi, We can get the list... [22:34:39] AndyRussG: oh boy do I ever have pictures to send--this kid is really getting familiar with the backs of everyone's phones :-/ [22:43:41] (CR) Ejegg: [C: 2] adds 'rejects' to smashpig paypal config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 (owner: Cdentinger) [22:44:55] (Merged) jenkins-bot: adds 'rejects' to smashpig paypal config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316822 (owner: Cdentinger) [22:56:35] (CR) Ejegg: [C: 2] "Nice!" (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/314509 (https://phabricator.wikimedia.org/T143903) (owner: Awight) [22:56:41] (Merged) jenkins-bot: Regression test for T143903 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/314509 (https://phabricator.wikimedia.org/T143903) (owner: Awight) [23:13:30] (CR) Ejegg: [C: -1] "Test needs a fix" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) (owner: Cdentinger) [23:13:58] (CR) Ejegg: "also needs manual rebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) (owner: Cdentinger) [23:24:19] (CR) Ejegg: [C: 2 V: 2] "Woohoo! Thanks for all this work" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/315638 (https://phabricator.wikimedia.org/T131770) (owner: Awight) [23:24:26] (Merged) jenkins-bot: Tests for the bulk export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/315638 (https://phabricator.wikimedia.org/T131770) (owner: Awight) [23:28:00] (CR) Ejegg: [C: 2] "love how deep the mocks can get!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/315741 (https://phabricator.wikimedia.org/T145012) (owner: Awight) [23:28:07] (Merged) jenkins-bot: Fix python tests [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/315741 (https://phabricator.wikimedia.org/T145012) (owner: Awight) [23:34:23] (PS4) Ejegg: Add inline help to the campaign editor [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/314196 (https://phabricator.wikimedia.org/T134958) (owner: Awight) [23:37:58] (PS2) Ejegg: Cleanup: simplify in-memory cache invalidation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312933 (owner: Awight) [23:38:31] (CR) Ejegg: [C: 2] "Looks legit!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312933 (owner: Awight) [23:38:40] (PS2) Ejegg: Cleanup: Use helper functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312949 (owner: Awight) [23:40:08] (Merged) jenkins-bot: Cleanup: simplify in-memory cache invalidation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312933 (owner: Awight) [23:42:03] (PS2) Ejegg: Be strict about PayPal IPN postback response. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311899 (owner: Awight) [23:51:27] (CR) Ejegg: [C: 2] Be strict about PayPal IPN postback response. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311899 (owner: Awight) [23:52:38] (Merged) jenkins-bot: Be strict about PayPal IPN postback response. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/311899 (owner: Awight)