[00:11:52] (PS2) Ejegg: Filter refunds out of donation history [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/316716 (https://phabricator.wikimedia.org/T148062) [00:12:35] now with a unit test! ^^^ [00:17:23] (PS2) Ejegg: Add timezone column to export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/316730 (https://phabricator.wikimedia.org/T148578) [00:43:55] (PS4) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [00:57:58] (PS5) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [01:00:58] (CR) jenkins-bot: [V: -1] Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [01:05:56] (PS6) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [01:09:20] (CR) jenkins-bot: [V: -1] Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [01:12:07] (CR) Ejegg: "*grumble*... Works locally - why is CI Civi API call not retrieving those fields?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [01:23:49] (PS7) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [01:26:41] (CR) jenkins-bot: [V: -1] Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [01:27:10] boooo [01:44:36] hooo [01:47:40] (PS8) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [01:49:23] (CR) Eileen: "I don't know how much difference it makes to performance, but when I've done this sort of thing on other DBs I've used DB triggers. CiviCR" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [01:50:17] (CR) jenkins-bot: [V: -1] Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [02:01:24] (CR) Ejegg: "db trigger might be just the thing! Now that I know those fields are actually null in the db I can try fixing the actual issue." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [02:04:16] (CR) Eileen: "Not sure if it is helpful but this is an example of doing a similar sort of thing by a trigger" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [02:08:45] (PS9) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [02:15:08] (CR) Ejegg: "Whew, glad that worked! Back to using an API call to get the address in the test, and fixed the way I check for US addresses. I think I'd " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [02:15:30] OK, done for the night! [05:30:57] (PS2) Cdentinger: API validate messages on front-end [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) [05:31:06] (CR) jenkins-bot: [V: -1] API validate messages on front-end [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) (owner: Cdentinger) [05:34:54] (PS3) Cdentinger: API validate messages on front-end [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) [05:46:16] (PS1) Eileen: CRM-19547 rationalise expensive use of exactMatch search on quicksearch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/316930 (https://phabricator.wikimedia.org/T147344) [05:48:12] (CR) Cdentinger: API validate messages on front-end (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) (owner: Cdentinger) [15:39:34] Fundraising-Backlog: Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2731692 (MBeat33) [15:39:46] Fundraising-Backlog: Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2731704 (MBeat33) p:Triage>Unbreak! [15:54:47] Fundraising-Backlog, Spike: Spike: Central Notice: Consider options for monitoring versions of banners shown - https://phabricator.wikimedia.org/T148593#2731792 (AndyRussG) [15:56:26] Fundraising Sprint Testing on Production, Fundraising-Backlog, Spike: Spike: Central Notice: Consider options for monitoring versions of banners shown - https://phabricator.wikimedia.org/T148593#2727179 (AndyRussG) [16:00:12] (PS1) Ejegg: Expand list of tlds for mailcheck [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316979 (https://phabricator.wikimedia.org/T148748) [16:02:04] (CR) jenkins-bot: [V: -1] Expand list of tlds for mailcheck [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316979 (https://phabricator.wikimedia.org/T148748) (owner: Ejegg) [16:40:59] (PS2) Ejegg: Expand list of domains for mailcheck [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316979 (https://phabricator.wikimedia.org/T148748) [16:41:49] fr-tech ^^^ fixes a new unbreak-now [16:42:09] wee! [16:42:28] I've got to head out for a couple hours, but if anyone has a chance to review and even deploy it I'd be very grateful! [16:53:11] should be pretty simple, just adding values to an array [16:53:59] Yea, I'll take a look. [16:54:12] (PS3) Ejegg: Expand list of domains for mailcheck [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316979 (https://phabricator.wikimedia.org/T148748) [16:54:12] thanks! [16:59:35] looks good. Just going to smoke test it real fast. [17:00:56] fr-tech: THE LESSER-KNOWN PROGRAMMING LANGUAGES #8: LAIDBACK [17:00:56] This language was developed at the Marin County Center for T'ai Chi, [17:00:56] Mellowness and Computer Programming (now defunct), as an alternative to [17:00:56] the more intense atmosphere in nearby Silicon Valley. [17:00:56] The center was ideal for programmers who liked to soak in hot tubs [17:00:57] while they worked. Unfortunately few programmers could survive there [17:00:57] because the center outlawed Pizza and Coca-Cola in favor of Tofu and [17:00:58] Perrier. [17:00:58] Many mourn the demise of LAIDBACK because of its reputation as a gentle [17:00:59] and non-threatening language since all error messages are in lower [17:00:59] case. For example, LAIDBACK responded to syntax errors with the [17:01:00] message: [17:01:00] "i hate to bother you, but i just can't relate to that. can [17:01:01] you find the time to try it again?" [17:02:22] ejegg: and XenoRyet we got an unbreak now from MBeat that sounds pretty legit: https://phabricator.wikimedia.org/T148748 [17:03:04] dstrine: ejegg has a patch for that, I'm revewing it right now. Should be ready to go out pretty quick here. [17:03:32] thanks again XenoRyet . you ok deploying that? [17:04:02] Yea, I think I should be fine to push it up. Looks pretty low risk, yea? [17:04:12] ahhh ok that's what you were referring to. I just realized that the phab task is in the gerrit url. gerrit links usually don't mean anything to me :P [17:04:24] sorry to micromanage [17:04:31] No worries [17:08:16] (CR) XenoRyet: [C: 2] Expand list of domains for mailcheck [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316979 (https://phabricator.wikimedia.org/T148748) (owner: Ejegg) [17:09:42] (Merged) jenkins-bot: Expand list of domains for mailcheck [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316979 (https://phabricator.wikimedia.org/T148748) (owner: Ejegg) [17:41:13] (PS1) XenoRyet: Merge branch 'master' into HEAD [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/316993 [17:41:34] (CR) XenoRyet: [C: 2] Merge branch 'master' into HEAD [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/316993 (owner: XenoRyet) [17:41:53] fr-tech thinking of signing up for a SWAT deploy to production of the core change for the long-running bug + a minor CN UI fix that we have pending to deploy, for this evening 4 pm Pacific time... sound good? [17:42:07] Sounds fine to me. [17:42:24] (Merged) jenkins-bot: Merge branch 'master' into HEAD [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/316993 (owner: XenoRyet) [17:45:15] (PS1) XenoRyet: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/316994 [17:45:44] (CR) XenoRyet: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/316994 (owner: XenoRyet) [17:49:24] :) [17:54:16] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/316994 (owner: XenoRyet) [18:12:49] !log updated payments wiki from 27b464fd4383647fc2e7f0a613f290d6edccd22f to 1e8f6a22b71710163fc4e4d90ea03a9729ab33d6 [18:12:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:15:28] Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2731692 (XenoRyet) Fix has been deployed. [18:16:15] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2732392 (XenoRyet) [18:17:05] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2731692 (XenoRyet) [18:17:48] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2732397 (MBeat33) Awesome, //merci//... [18:23:05] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2732411 (TerraCodes) Open>Reso... [18:23:55] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2732414 (TerraCodes) a:TerraCodes... [19:14:07] thanks for deploying that XenoRyet ! [19:14:23] Anything I can help with, fr-tech? [19:16:57] No worries [19:19:05] XenoRyet: so, awight succeeded in making that tools repo testable! Different approach from that broken stuff I was trying with the paypal audit. [19:19:25] Good times [19:19:51] I'll have to take a peek later [19:19:51] He even set up tests for the Silverpop export [19:19:57] nice [19:20:33] Yeah, I was able to add a test for getting refunds out of the donation history: https://gerrit.wikimedia.org/r/316716 [19:24:04] Fundraising Sprint Testing on Production, Fundraising-Backlog, Spike: Spike: Central Notice: Consider options for monitoring versions of banners shown - https://phabricator.wikimedia.org/T148593#2727179 (Ejegg) What about this: a client-side hash of loaded content gets sent to event log, and some bot... [19:29:24] (CR) Ejegg: [C: 2] Cleanup: Use helper functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312949 (owner: Awight) [19:31:55] (Merged) jenkins-bot: Cleanup: Use helper functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312949 (owner: Awight) [20:14:55] (CR) Ejegg: [C: 2] API validate messages on front-end (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316842 (https://phabricator.wikimedia.org/T148678) (owner: Cdentinger) [20:15:29] OK, I'm going to deploy that smashpig patch as soon as it merges. Should speed up paypal donations getting into Civi [20:20:15] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317017 [20:20:27] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317017 (owner: Ejegg) [20:21:05] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317017 (owner: Ejegg) [20:24:02] well that needed a rollback... checking out why [20:24:34] d'oh, using an object as an array. [20:24:52] Testing on Production - guilty! [20:25:36] :p [20:25:45] such a great sprint name [20:31:44] (PS1) Ejegg: Fix validation, minor cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317020 (https://phabricator.wikimedia.org/T148678) [20:32:25] fr-tech except awight :) - want to take a look at that one ^^^ [20:33:10] haha I would never [20:33:32] I thought we were NOT going to test on production :P [20:34:03] #workedonmymachine #itshouldjustwork [20:34:23] oops that created another channel? [20:34:41] your IRC client is becoming sentient [20:34:42] * dstrine needs to learn more about irc [21:02:32] (CR) XenoRyet: [C: 2] Fix validation, minor cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317020 (https://phabricator.wikimedia.org/T148678) (owner: Ejegg) [21:07:40] (Merged) jenkins-bot: Fix validation, minor cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317020 (https://phabricator.wikimedia.org/T148678) (owner: Ejegg) [21:14:22] thanks XenoRyet ! Let's try that deploy again... [21:15:28] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317030 [21:15:38] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317030 (owner: Ejegg) [21:16:37] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317030 (owner: Ejegg) [21:17:58] !log updated SmashPig from 961fc4c14f94181a0e364615a0a05dd8f4646912 to d1ca0632d00dfb608f70ca4b70251a5ba49f4411 [21:18:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:27:05] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Paypal, FR-Smashpig, and 2 others: Validate paypal messages in frontend rather than job runner - https://phabricator.wikimedia.org/T148678#2729778 (Ejegg) Open>Resolved [21:39:09] (CR) XenoRyet: [C: 2] Filter refunds out of donation history [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/316716 (https://phabricator.wikimedia.org/T148062) (owner: Ejegg) [21:39:15] (Merged) jenkins-bot: Filter refunds out of donation history [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/316716 (https://phabricator.wikimedia.org/T148062) (owner: Ejegg) [21:44:33] woot [21:46:27] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/317044 [21:50:37] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/317044 (owner: Ejegg) [21:52:01] !log updated fundraising tools from f6d200dc76520298171196c5419b382fe86d9dcd to 09ae6e24d8ca8350dc099d63a6ca0d9ec9fdef2b [21:52:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:52:31] k, going to kick off a silverpop export and check back in a couple hrs [22:33:32] verizon is working pretty good at 75mph in rural nm [22:33:42] looks like something i did blew up pretty good [23:03:13] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/317077 [23:06:24] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/317077 (owner: AndyRussG) [23:08:34] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/317077 (owner: AndyRussG) [23:48:52] fr-tech CN and MW core updates going out now \o/ [23:48:59] woot [23:49:10] * AndyRussG bids farewell to his friend, the long-lived bug [23:49:32] (anticipating it'll be a drawn-out goodbye to that one...) [23:50:13] XenoRyet: :) [23:58:04] dstrine: fr-tech deploy seems all good