[00:03:28] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 5 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2657757 (AndyRussG) The changes to core MessageCache were just deploy... [00:05:10] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 2 others: CN Campaign Setting oddities - https://phabricator.wikimedia.org/T145447#2733547 (AndyRussG) @spatton Hi! We just deployed a fix for this... Is... [00:13:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808#2733554 (Dereckson) [00:14:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808#2733571 (Dereckson) [00:15:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808#2733554 (Dereckson) [00:35:06] Whew in truth it sure feels good to think that old bug may really be gone! [13:56:55] Fundraising-Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2734342 (Aklapper) >>! In T141326#2579157, @DStrine wrote: > @Aklapper > > It looks like you are using other accounts to verify a user's identity. @DStrine: As I used "other... [14:01:29] (PS1) Ejegg: sftp client needs to get_config before connect [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/317151 [16:16:29] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2734656 (CCogdill_WMF) Hey all, I think we can do without the time zone data. We have sta... [16:17:22] Fundraising-Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2734657 (DStrine) HR can tell you if a person is a full time employee or a contractor. They have all the official paperwork. The profiles you reference today are clearly incons... [16:28:16] (CR) XenoRyet: [C: 2] sftp client needs to get_config before connect [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/317151 (owner: Ejegg) [16:28:22] (Merged) jenkins-bot: sftp client needs to get_config before connect [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/317151 (owner: Ejegg) [16:41:58] thanks XenoRyet ! [16:42:32] No worries, saw it in the backscroll and thought I'd take a look. [16:42:51] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/317169 [16:42:58] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/317169 (owner: Ejegg) [16:43:04] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/317169 (owner: Ejegg) [16:43:26] right on. needed that to fix the silverpop export upload [16:45:10] !log updated fundraising tools from 09ae6e24d8ca8350dc099d63a6ca0d9ec9fdef2b to f83e39291adc55677fc4b49307dc4807eba18019 [16:52:14] ejegg: and XenoRyet I'm seeing a lot of fail mail [16:52:32] ah crud, investigating [16:52:44] it started about 7 minutes ago [16:52:49] Yep. I see it too. I can't imagine what about that change would've caused it. [16:52:52] oh boy, no response from paypal [16:53:06] total coincidence, I think [16:53:14] Heh [16:53:44] I deployed something yesterday that made us more picky about what to accept from their verification endpoint [16:53:55] i.e. it has to be either VERIFIED or INVALID [16:54:02] and now we're getting a blank [16:54:16] so... we should ask pp what's up with that [16:54:46] Agreed. I don't think we want to make assumptions about what a blank means unless we really really have to. [16:56:00] i bet we could get more logging in there on failure though [16:58:10] Anyway, I've got to run an errand, be back in a bit. [16:58:57] Fundraising-Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2734782 (Aklapper) @DStrine: >>! In T141326#2734657, @DStrine wrote: > HR can tell you if a person is a full time employee or a contractor. [[ https://wikimediafoundation.org/... [16:59:05] I could tt in 15 or so.. mmm looks like tuff is flying? [16:59:06] stuf [16:59:08] stuff [17:00:56] fr-tech: All the taxes paid over a lifetime by the average American are spent by [17:00:56] the government in less than a second. [17:00:56] -- Jim Fiebig [17:00:56] -- discuss. [17:02:14] "this fortune brought to yo uby the heritage foundation" [17:02:45] haha [17:02:53] be at TT shortly [17:08:12] (PS1) Ejegg: Log more on unexpected PP verify response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317175 [17:15:27] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2734865 (Ejegg) Hi @CCogdill_WMF , sorry, the failure last night was only tangentially re... [17:16:48] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2734867 (CCogdill_WMF) Oh, okay! Thanks for confirming @Ejegg. If we can get the data, th... [17:21:12] fr-tech this new smashpig logging: https://gerrit.wikimedia.org/r/317175 is basically cribbed from the same thing in DI: https://gerrit.wikimedia.org/r/298549 [17:21:41] hoping to put that up and turn PP listener back on [17:25:18] wow that curl logging sure is weird [17:25:30] vestiges of an earlier php [17:25:45] heh, yep [17:26:01] basically redirecting stderr [17:26:43] all that setopt stuff is like a DSL you have to learn [17:40:31] (CR) Cdentinger: [C: 2] Log more on unexpected PP verify response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317175 (owner: Ejegg) [17:40:56] (CR) jenkins-bot: [V: -1] Log more on unexpected PP verify response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317175 (owner: Ejegg) [18:14:26] (CR) Ejegg: [V: 2] Log more on unexpected PP verify response [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317175 (owner: Ejegg) [18:16:43] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317178 [18:16:54] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317178 (owner: Ejegg) [18:19:39] (CR) Ejegg: [V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317178 (owner: Ejegg) [18:22:20] !log updated SmashPig from d1ca0632d00dfb608f70ca4b70251a5ba49f4411 to e28b2cd9f0c1429acdd2a08c68f95884dbffb594 [18:22:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:46:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#2735001 (Ejegg) [18:46:07] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Resolve conflicts on preferred language - https://phabricator.wikimedia.org/T146344#2735000 (Ejegg) Open>Resolved [19:01:25] ah dang, we're deleting donor details for stuff we leave able to push through [19:04:35] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Don't delete pending details for Adyen donations left for review - https://phabricator.wikimedia.org/T148859#2735027 (Ejegg) [19:06:43] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 2 others: CN Campaign Setting oddities - https://phabricator.wikimedia.org/T145447#2735040 (spatton) Hey @AndyRussG, awesome! It just occurred to me yest... [19:18:18] Fundraising Tech Backlog, Fundraising-Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah Hernandez - https://phabricator.wikimedia.org/T138100#2735056 (Jgreen) Open>Resolved this was completed in August! [19:21:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#2735060 (Jgreen) [19:21:03] fundraising-tech-ops, HHVM: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2735058 (Jgreen) stalled>declined Doesn't appear to be a need for this at present. We can reopen if that changes. [19:26:03] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2735072 (Jgreen) [19:26:05] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Adjustable load balancer to direct small samples of donors to staging payments - https://phabricator.wikimedia.org/T97745#2735070 (Jgreen) stalled>Invalid We should already be able to do this at LVS--pooled... [19:26:36] (PS1) Ejegg: Don't delete pending data for failed:review [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317189 (https://phabricator.wikimedia.org/T148859) [19:27:30] (PS1) Ejegg: Don't delete pending data for failed:review [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317190 (https://phabricator.wikimedia.org/T148859) [19:28:47] (CR) jenkins-bot: [V: -1] Don't delete pending data for failed:review [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317190 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [19:31:43] fundraising-tech-ops: pre-decommission beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T147934#2735098 (Cmjohnson) p:High>Low Berryllium is unplugged and powered on...lowering priority until ready to decom. [19:32:42] (PS2) Ejegg: Don't delete pending data for failed:review [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317190 (https://phabricator.wikimedia.org/T148859) [19:33:12] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2735110 (Cmjohnson) [19:33:26] fundraising-tech-ops, Operations, ops-eqiad, Patch-For-Review: pay-lvs1003/pay-lvs1004 hardware swap for pay-lvs1001/pay-lvs1002 - https://phabricator.wikimedia.org/T147932#2735108 (Cmjohnson) Open>Resolved Resolving this...work has been completed. [19:34:01] fr-tech: couple of fixes for a situation where manually-reviewed Adyen transactions cause failmail due to missing donor details [19:34:27] https://gerrit.wikimedia.org/r/317189 [19:34:32] https://gerrit.wikimedia.org/r/317190 [19:35:05] there's a matching settings change to review on deployserver settings repo [19:39:15] ejegg: i'm just supposed to run SP maintenance with "php scriptname" or is there a fancier way? [19:40:16] cwd yep, php scriptname options [19:44:39] ejegg: huh, i get "Cannot declare class SmashPig\Maintenance\MaintenanceBase, because the name is already in use in /srv/vagrant/srv/org.wikimedia.civicrm/vendor/wikimedia/smash-pig/Maintenance/MaintenanceBase.php on line 35" [19:44:53] but that's the only place i see that class declared [19:47:02] AndyRussG: meat? [19:47:45] cwd ooh, odd [19:50:36] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 3 others: Move misplaced messages from ActiveMQ to Redis - https://phabricator.wikimedia.org/T147982#2735133 (Ejegg) a:Ejegg [19:54:07] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, and 6 others: Delete from the pending database when a transaction is failed or comp... - https://phabricator.wikimedia.org/T143945#2735148 [19:58:39] fundraising-tech-ops: fix freeradius vs libpam-yubico too many open files bug - https://phabricator.wikimedia.org/T148863#2735153 (Jgreen) [20:03:32] (PS1) Cdentinger: Don't complain about AtomicReadBuffer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317194 [20:03:52] ejegg: does this make sense to you? ^ i really should have looked into this before [20:04:19] Predis totally should be one... that's how we're reading everything off the queue [20:04:42] weird [20:04:49] yeah, QueueConsumer needs PopAtomic, which is what AtomicReadBuffer provides [20:05:53] $ git submodule status [20:05:56] 8d230e27845ad76f30376fe3ea54c63b65252a20 vendor (8d230e2) [20:06:06] ejegg: does that match yours?? [20:06:43] class Predis [20:06:46] extends Base [20:06:48] implements FifoQueueStore, KeyValueStore [20:06:58] weird, it's been one since we started the queue work [20:07:51] ohhh, that's the submodule that shouldn't exist on master [20:07:57] let's zap that... [20:08:01] doh! [20:08:07] yeah i see it's correct on deployment [20:10:02] Fundraising-Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2735190 (K4-713) @Aklapper @DStrine I can verify that this is indeed Eileen. Additionally: There may be some unusual confusion around her accounts as she was a vendor contract... [20:10:19] (PS1) Ejegg: IF MERGED TO DEPLOYMENT, REVERT: delete vendor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317196 [20:10:48] (CR) Ejegg: [C: 2] IF MERGED TO DEPLOYMENT, REVERT: delete vendor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317196 (owner: Ejegg) [20:11:48] looks like they're setting up an event here, relocating [20:11:49] ty [20:11:58] (Merged) jenkins-bot: IF MERGED TO DEPLOYMENT, REVERT: delete vendor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317196 (owner: Ejegg) [20:27:09] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317199 [20:27:31] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317199 (owner: Ejegg) [20:29:13] oh, here's another clean up patch: https://gerrit.wikimedia.org/r/316022 - composer.lock on DI master got behind deployment somehow [20:29:33] ehh, guess I can self-merge that [20:29:47] (PS2) Ejegg: Fix composer.lock mismatch with deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316022 [20:30:37] (CR) Ejegg: [C: 2] Fix composer.lock mismatch with deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316022 (owner: Ejegg) [20:30:56] ah, crm rather [20:32:43] (PS2) Cdentinger: WIP maint script to create all db tables [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 (owner: Ejegg) [20:33:52] (Merged) jenkins-bot: Fix composer.lock mismatch with deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316022 (owner: Ejegg) [20:37:18] fundraising-tech-ops: fix freeradius vs libpam-yubico too many open files bug - https://phabricator.wikimedia.org/T148863#2735251 (Jgreen) Note we're using freeradius 2.2.5, and 3.x now includes a yubico module but there's no backport for jessie. [20:37:45] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: Don't delete pending details for Adyen donations left for review - https://phabricator.wikimedia.org/T148859#2735253 (Ejegg) Besides these two patches, there is a payments-wiki/Lo... [20:43:03] (PS1) Ejegg: Fix DamagedDb::storeMessage return value [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317273 [21:12:33] (CR) Cdentinger: [C: -1] "Needs a classname fix" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 (owner: Ejegg) [21:14:40] ejegg: sorry to take forever with the damaged UI CR, i got stuck on that ^ [21:14:49] cwd oho, nice catch [21:15:05] i couldn't figure out why it was trying to consume! [21:15:25] will fix that in a sec, just puzzling over the db-mixup bug [21:33:42] (CR) Cdentinger: WIP maint script to create all db tables (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 (owner: Ejegg) [21:34:11] (PS1) Ejegg: Fix all db subclasses sharing a PDO [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317277 [21:35:05] hey fr-tech, here's another reason to hate PHP ^^^ [21:35:52] (CR) Cdentinger: WIP maint script to create all db tables (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 (owner: Ejegg) [21:37:33] (PS3) Ejegg: Maintenance script to create all db tables [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 [21:38:10] (PS4) Ejegg: Maintenance script to create all db tables [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 [21:38:26] thanks cwd ! [21:38:57] ejegg: sure thing, i'm still not seeing the tables for some reason [21:39:06] it is finding the schema files now [21:39:14] cwd maybe has to do with that PDO overlap bug (see above) [21:39:23] btw i had to hack the vagrant creds into smashpig.yaml [21:39:36] mysql vagrant creds that is [21:40:13] cwd oh, I guess we need to add those to vagrant's /etc/fundraising/SmashPig.yaml [21:40:26] I think it's got pending creds, but I haven't touched that in a while [21:40:39] so it's probably missing damaged and fredge [21:43:33] aaah right right [21:54:00] ejegg|brb: hrm so /etc/fundraising/SmashPig.yaml is fine. seems like the one in the repo is overriding... [22:02:45] cwd whaaa? [22:02:50] that shouldn't be possible [22:02:57] production would be all kinds of broken [22:04:09] yeah i'm confus [22:06:12] maybe it's not reading /etc/fundraising? [22:08:42] dunno how that could be [22:08:52] sure looks hardcoded [22:08:55] does the code look like the right version? [22:09:13] maybe it has to do with the maintenance script? [22:09:19] is /etc/f/sp.yaml messed up with spacing or something? [22:09:45] you can specify an override file with --config-file [22:09:45] hmm, not that i can see... [22:10:39] still nothing [22:10:43] how fiddly [22:16:41] (PS2) Ejegg: Remove bogus 'inflight' store [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/313622 [22:18:23] jeez [22:18:33] k, lemme take a look [22:21:17] it's definitely reading the file [22:21:35] cwd oh man, every time i leave vagrant alone for a few weeks it's broken when I try to provision again [22:21:46] vagrant rot [22:22:33] ejegg: are you getting the nodejs error? [22:22:57] bd808: he he not yet! [22:23:04] there is a puppet patch that fixes that. you'll need to git pull the mw-vagrant repo itself to fix it [22:23:10] ejegg: i think i see the problem [22:23:46] bd808: nah, just the usual cache/apt/partial missing, and for some reason no site.pp the first time [22:23:53] muddling through, though [22:23:58] thanks for the suggestion! [22:24:13] cwd do tell [22:24:48] i believe it's because in getDefaultSearchPath the last one is $searchPath[] = __DIR__ . "/../SmashPig.yaml"; which if you are in the Maintenance dir will resolve to the repo config [22:27:05] isn't __DIR__ always relative to the file it's in? [22:27:21] and doesn't the last search path have the lowest priority? [22:27:48] ah i thought dir was cwd [22:28:05] nah, it's file-relative [22:28:47] derp [22:36:57] this config loading is pretty complicated [22:37:37] yeah :P [22:51:47] does this merge strategy really have to be so in-depth? [22:52:03] is it tightly coupled with the design of the program by now? [22:53:56] custom recursive array merge...does seem a likely source of unreasonable overrides [23:15:24] (PS1) Ejegg: Refund QC: fix missing 'use', better logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317289 [23:27:46] cwd ok, i'm getting the same problem creating tables in vagrant [23:28:11] oh phew! [23:28:36] cwd lemme try applying the PDO overlap fix [23:29:13] ok weird the config does look right [23:30:20] cwd yeah, it's totally the db overlap thing [23:30:36] check this out: https://gerrit.wikimedia.org/r/317277 [23:30:44] and you can create the tables no problem [23:32:41] what makes the singleton misbehave? if they have different dbs selected? [23:33:24] oh i see, the singleton is shared between subclasses [23:33:36] why isn't this blowing up everywhere? [23:34:59] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 3 others: Move misplaced messages from ActiveMQ to Redis - https://phabricator.wikimedia.org/T147982#2735561 (Ejegg) After re-parsing a lot of paypal audit files, we seem to have gotten... [23:35:18] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 3 others: Move misplaced messages from ActiveMQ to Redis - https://phabricator.wikimedia.org/T147982#2710934 (Ejegg) Open>Resolved [23:35:49] cwd it was blowing up on prod when we tried to use more than one db [23:36:18] see the commit message on the fix - we've got something reverted in deployment (only) that tries to look at fredge [23:36:39] i guess i'm just surprised this is the first time we've looked at more than one db in a thread? [23:37:12] till now we were only using pending and damaged, and both had the same PDO connection [23:37:28] (TODO: consolidate config) [23:39:17] ejegg: what is the 3rd? i only see those two when i dump this config [23:39:34] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Refund QC not catching exceptions, uninformative logging - https://phabricator.wikimedia.org/T148880#2735567 (Ejegg) [23:39:35] ooh, fredge? [23:39:44] yah [23:39:58] so you need to set the config for that too [23:40:18] but shouldn't everything in the create tables script be using the same pdo? [23:40:29] (PS2) Ejegg: Refund QC: fix missing 'use', better logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317289 (https://phabricator.wikimedia.org/T148880) [23:40:29] why would that blow up? [23:40:49] cwd nah, each should use its own [23:41:21] but if the first one it instantiates is one whose config is default, all the rest will have the same [23:41:40] and the default was no password, which isn't allowed in vagrant's mysql setup [23:42:48] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Refund QC not catching exceptions, uninformative logging - https://phabricator.wikimedia.org/T148880#2735567 (Ejegg) p:Triage>Normal [23:50:41] ejegg: could you use self instead of static? [23:51:25] cwd pretty sure self:: always refers to that class that the code's in [23:51:38] and static:: is /supposed/ to mean the called class [23:52:02] but apparently neither of 'em work if you declare a staticvar in a parent class [23:52:11] argh [23:52:16] yah [23:53:15] http://stackoverflow.com/questions/11417681/static-properties-on-base-class-and-inheritance#11418607 [23:53:22] so terrible [23:53:55] yeh [23:54:05] even with an abstract base class :( [23:56:46] welll [23:56:53] starting to feel like miller time [23:58:06] hehe yeah, i gotta go get dinner with the parents [23:58:20] i will probably poke at this a little over the weekend, it is frustrating to me [23:58:28] there's got to be a better way! [23:58:36] k, good luck with that! [23:58:40] have a good weekend [23:58:45] you too! [23:58:49] thanks!