[14:33:23] Fundraising-Backlog: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738074 (MBeat33) [14:33:40] Fundraising-Backlog: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738089 (MBeat33) p:Triage>Unbreak! [16:01:42] (PS1) Ejegg: Set CURLOPT_VERBOSE for pp validation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317531 [16:04:45] (CR) Cdentinger: [C: 2] Set CURLOPT_VERBOSE for pp validation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317531 (owner: Ejegg) [16:06:23] (Merged) jenkins-bot: Set CURLOPT_VERBOSE for pp validation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317531 (owner: Ejegg) [16:07:14] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317532 [16:07:22] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317532 (owner: Ejegg) [16:09:03] ejegg: interesting thing is this is only a small number of paypal messages that fail verification [16:09:10] i see tons of successful ones [16:09:17] yeah, it can't be a bad cert... [16:09:25] maybe we ARE getting some spoofs? [16:09:38] no idea why someone would [16:09:49] anyway, I'll put that verbose logging up in a sec [16:09:53] groovy [16:10:03] and yeah i spaced that, we are not using the cert in the listener [16:15:42] Fundraising-Backlog: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738594 (Ejegg) Maybe we can make it more clear that this is just a suggestion? I could change the color to black instead of red, and add a prominent 'X' button to dismis... [16:18:26] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Show contribution tracking ID in error messages as 'Reference #' - https://phabricator.wikimedia.org/T147679#2738625 (MBeat33) This works reall... [16:19:30] hmm, smashpig deployment CI needs some jiggling. Is this were we want a no-op? [16:19:43] (CR) Ejegg: [V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317532 (owner: Ejegg) [16:20:13] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Longterm fix + regression test for T144489 - https://phabricator.wikimedia.org/T144557#2738635 (DStrine) p:Normal>U... [16:21:40] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Longterm fix + regression test for T144489 - https://phabricator.wikimedia.org/T144557#2603473 (DStrine) @Ejegg and @Eile... [16:22:21] !log updated SmashPig from e28b2cd9f0c1429acdd2a08c68f95884dbffb594 to f9e185b7b14749ae24155c69bc1927dc6222e5f7 [16:22:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:28:49] ejegg: yeah i think that's right...no auto merge? [16:30:06] yah [16:42:02] Fundraising-Backlog: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738744 (Ejegg) Anyway, let's decide on a good cutoff for the list of suggested domains. If I look at the top 50 donor domains (yahoo.ca is around #40), that gets us down... [16:45:05] Fundraising-Backlog: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738767 (Ejegg) Side note: we missed some '.con' domains in our last typo cleanup: | num | domain | | 1009 | gmail.con | | 250 | hotmail.con | | 271 | yahoo.con... [16:49:55] Fundraising-Backlog: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738792 (Ejegg) Fr-tech, want to proofread? ``` UPDATE civicm_email SET email = REPLACE( email, 'gmail.con', 'gmail.com' ) WHERE email LIKE '%gmail.con'; UPDATE civicm_... [16:50:47] lol tld .con [16:50:54] that *should* be a thing [16:52:48] please register your ponzi schemes here thx [16:54:50] ejegg: strangely, I'm unable to get CN tests to fail on the master branch with strict mode enabled... Were you able to check that? [16:54:55] also, hi! [16:55:08] AndyRussG: hi! [16:55:39] Let me see if the test fail for me - I forget if I was just looking for warnings in the mysql log or what [16:55:50] also, awight hi and don't work! ;p [16:56:04] ejegg: ah hmmm K [16:57:12] system-wide /var/log/mysql/error.log ? [17:00:10] fr-tech: A boy gets to be a man when a man is needed. [17:00:10] -- John Steinbeck [17:00:10] -- discuss. [17:00:59] AndyRussG: still digging [17:03:22] AndyRussG: never fear :D, I'm strictly lurking re: volunteer projects [17:05:43] (CR) Cdentinger: [C: 2] Don't delete pending data for failed:review [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317189 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [17:05:58] (CR) Cdentinger: [C: 2] Don't delete pending data for failed:review [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317190 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [17:09:07] (Merged) jenkins-bot: Don't delete pending data for failed:review [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317189 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [17:09:09] (Merged) jenkins-bot: Don't delete pending data for failed:review [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317190 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [17:12:00] MariaDB [(none)]> SHOW VARIABLES LIKE "sql_mode"; [17:12:02] +---------------+-------------------+ [17:12:04] | Variable_name | Value | [17:12:06] +---------------+-------------------+ [17:12:08] | sql_mode | STRICT_ALL_TABLES | [17:12:10] +---------------+-------------------+ [17:16:52] T112637 [17:16:52] T112637: RFC: Increase the strictness of mediawiki SQL code and leverage database code blockers for scalability - https://phabricator.wikimedia.org/T112637 [17:33:55] git checkout remotes/origin/wmf/1.28.0-wmf.10 [17:48:04] git difftool remotes/origin/wmf/1.28.0-wmf.10:includes/db/Database.php master:includes/libs/rdbms/database/Database.php [17:58:10] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Longterm fix + regression test for T144489 - https://phabricator.wikimedia.org/T144557#2739029 (Eileenmcnaughton) There is... [18:00:03] (PS1) Ejegg: Remove unused MinfraudActionRanges global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/317549 [18:04:10] Fundraising Sprint Testing on Production, Fundraising-Backlog, Unplanned-Sprint-Work: Exceptions logged for TY unsubscribe - https://phabricator.wikimedia.org/T148996#2739052 (Ejegg) [18:05:33] Fundraising Sprint Testing on Production, Fundraising-Backlog, Unplanned-Sprint-Work: Exceptions logged for TY unsubscribe - https://phabricator.wikimedia.org/T148996#2739069 (Ejegg) looks like missing queue settings. fixing... [18:06:14] !log updated payments-wiki settings to f4b79f02c2897349a96b023aaef4cbf24e7708f0 [18:06:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:12:43] cwd did you think of any more elegant solution to the SmashPigDatabase static mess over the weekend? [18:13:44] ah no i did not [18:13:50] there was no computer time this weekend [18:13:59] heh, sounds like a good one ! [18:14:30] heh well, more frantic home repair and stuff moving [18:14:32] XenoRyet: can you think of any better way around PHP's dumbness here? https://gerrit.wikimedia.org/r/317277 [18:14:53] heh, still better than more staring at glowing rectangles [18:15:41] that's for sure [18:16:23] yeah i have no more ideas about this. maybe we could just explain better in the comment, in case there is ever a workaround? [18:17:19] cwd sure, I'll add more verbiage [18:18:07] class inheritance has too many edge cases [18:22:03] (PS2) Ejegg: Fix all db subclasses sharing a PDO [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317277 [18:22:15] Taking a look [18:23:03] Also, getting some thunder and lighning here, my internet connection doesn't have a great track record in this kind of weather, so if I disappear in a hail of electrons, that's what happened. [18:23:41] i am ready to +2 unless you think of something less weird [18:23:59] I was trying to merge that payments-init thing to deployment and got conflicts b/c of the thing that's reverted only in deployment. If we can get that PDO fix in too, we can bring deployment back in line with master [18:24:33] the only thing i can think of would be not using singletons at all [18:24:44] but i assume it would kill performance. has that actually been tested? [18:24:57] nah, only issue with that I can see is testing [18:25:29] we're sharing a single mysql memory PDO per database now by using singletons [18:25:54] ah right and if that doesn't happen it disappears between variables? [18:25:58] there's that other way to do it, but it would mean only one in-memory database across all connections [18:26:09] ATTR_PERSISTENT [18:26:52] what was the downside there? [18:27:24] imo the non persistent one is weird. what advantage does it have over a variable? sql syntax check? [18:27:30] just slightly less realistic tests, no teardown [18:28:18] ah because it persists between all the tests? [18:28:26] less realistic meaning all tables in the same db, so we might miss something really dumb like looking in the wrong db for a table [18:28:40] mm yes [18:28:45] cwd yeah, we'd have to remember to truncate everything [18:29:03] does teardown not run per test? [18:29:19] it does, and right now we use reflection to clear statics [18:29:47] which makes the in-mem PDOs go away [18:30:09] but I'm not sure if there's a way to tell the ATTR_PERSISTENT databases to die [18:30:39] hmmm, drop database? [18:31:45] eeh, sounds like more trouble than it's worth, current way is fine [18:31:55] is that a thing in sqlite? [18:33:10] guess not [18:33:38] http://stackoverflow.com/questions/525512/drop-all-tables-command [18:33:41] this is silly [18:33:49] (PS3) Cdentinger: Fix all db subclasses sharing a PDO [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317277 (owner: Ejegg) [18:36:26] Yea, I'm not seeing any better ways jump out at me. [18:38:50] (CR) Cdentinger: [C: 2] Fix all db subclasses sharing a PDO [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317277 (owner: Ejegg) [18:39:04] that'll fix the smashpig db creator thing too [18:45:03] thanks cwd! [18:45:34] you bet, i should be able to get that damaged stuff tested now [18:47:21] (Merged) jenkins-bot: Fix all db subclasses sharing a PDO [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317277 (owner: Ejegg) [19:06:10] (PS5) Cdentinger: Maintenance script to create all db tables [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 (owner: Ejegg) [19:24:01] (PS1) Ejegg: Revert "Revert "Check payments_init for 'failed' in pending QC"" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317560 [19:24:10] (CR) Ejegg: [C: 2] Revert "Revert "Check payments_init for 'failed' in pending QC"" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317560 (owner: Ejegg) [19:25:47] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317561 [19:26:05] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317561 (owner: Ejegg) [19:28:56] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/317561 (owner: Ejegg) [19:29:28] ejegg: i still get the same error when running the db migrations after the separate PDOs patch [19:29:44] would you give that a try when you have a chance and see if you do too? [19:32:57] cwd did you add vagrant credentials for the fredge db? [19:33:06] I need to update our vagrant config [19:34:52] !log updated SmashPig from f9e185b7b14749ae24155c69bc1927dc6222e5f7 to 31c0757ca17499deac6a8f49eb7ed17924630419 [19:34:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:35:18] ejegg: well wasn't /etc/fundraising correct already? [19:35:48] cwd no, I hadn't updated the vagrant settings since we added the fredge db [19:36:08] aah i see now [19:36:17] want me to add that to the puppet stuff? [19:38:37] sure! [19:47:28] ah dang... I just realized we want to delete ingenico pending messages even when they're in failed:process [19:48:39] (CR) AndyRussG: MariaDB strict mode (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [20:03:06] (PS14) Ejegg: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) [20:03:55] (CR) Ejegg: "OK AndyRussG, now only skipping the column when $summary === null" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [20:07:51] http://noticias.starmedia.com/mexico/feria-internacional-libro-en-zocalo-cumple-xv-anos.html [20:10:13] https://www.google.com.mx/search?q=fil+zocalo+2016&source=lnms&tbm=isch&sa=X [20:19:26] Ah heh that's from last year ^ [20:25:41] (PS1) Ejegg: Make mailcheck suggestions more subtle [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/317581 (https://phabricator.wikimedia.org/T148970) [20:26:18] (PS2) Ejegg: Make mailcheck suggestions more subtle [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/317581 (https://phabricator.wikimedia.org/T148970) [20:52:21] (PS2) Ejegg: Default errors links to donate@ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316709 (https://phabricator.wikimedia.org/T117872) [21:01:42] (PS1) Ejegg: Only leave details for 'failed:review' status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317648 (https://phabricator.wikimedia.org/T148859) [21:04:52] (PS1) Ejegg: Only leave details for 'failed:review' status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317649 (https://phabricator.wikimedia.org/T148859) [21:05:09] cwd slight tweaks to those two adyen-failmail fixes ^^^ [21:07:18] cool i'll check it out in a minute [21:11:40] ejegg: how hard would it be to combine what SP and CRM are doing there so the change didn't have to happen in two places? [21:14:18] * cwd is very hand-wavy about this sort of thing [21:15:06] cwd yeah, I should do that TODO... will update the CRM patch [21:19:50] it'll just need a SmashPig lib update, so it'll look broken till the sp patch merges [21:20:54] ah ok i'll merge that one now [21:21:01] (CR) Cdentinger: [C: 2] Only leave details for 'failed:review' status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317649 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [21:21:20] Fundraising-Backlog, Patch-For-Review: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2738074 (DStrine) @Ejegg and I talked about this and the first step we can take is changing the font to grey and matching the size of text in the fi... [21:21:30] Fundraising-Backlog, Patch-For-Review: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2739940 (DStrine) p:Unbreak!>High [21:23:40] (PS1) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 [21:25:29] (Merged) jenkins-bot: Only leave details for 'failed:review' status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317649 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [21:29:19] d'oh, isMessageFailed should have been static [21:30:48] (PS1) Ejegg: isMessageFailed should be static [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317655 [21:31:07] cwd sorry, I didn't notice ^^^ till I actually tried using it as a lib [21:31:47] np makes sense [21:34:01] (CR) Cdentinger: [C: 2] isMessageFailed should be static [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317655 (owner: Ejegg) [21:35:20] (Merged) jenkins-bot: isMessageFailed should be static [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317655 (owner: Ejegg) [21:36:33] (PS2) Ejegg: Only leave details for 'failed:review' status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317648 (https://phabricator.wikimedia.org/T148859) [21:37:09] (CR) jenkins-bot: [V: -1] Only leave details for 'failed:review' status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317648 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [21:37:21] yikes, where went package-dev [21:37:45] oops [21:37:48] my bad [21:39:19] (PS3) Ejegg: Only leave details for 'failed:review' status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317648 (https://phabricator.wikimedia.org/T148859) [21:42:40] (PS2) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 [21:44:13] ok, jenkins liked ps3: https://gerrit.wikimedia.org/r/317648 [21:46:21] nice [21:46:27] (CR) Cdentinger: [C: 2] Only leave details for 'failed:review' status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317648 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [21:49:17] (Merged) jenkins-bot: Only leave details for 'failed:review' status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317648 (https://phabricator.wikimedia.org/T148859) (owner: Ejegg) [21:49:26] (PS6) Ejegg: Use ct_id to find completed, avoid race [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312563 (https://phabricator.wikimedia.org/T143945) [21:54:02] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/317659 [21:55:07] ah shoot, one more little thing that would be nice for the library update - https://gerrit.wikimedia.org/r/317273 [21:55:29] ^^^ would fix the failmail damaged datastore links to point to the specific message [21:55:50] (CR) Ejegg: [C: -2] Don't complain about AtomicReadBuffer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317194 (owner: Cdentinger) [21:56:40] (Abandoned) Cdentinger: Don't complain about AtomicReadBuffer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317194 (owner: Cdentinger) [21:56:58] (CR) jenkins-bot: [V: -1] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/317659 (owner: Ejegg) [22:01:48] ehh, guess that link one can wait. The not-deleting-messages is more important [22:02:22] (CR) Ejegg: [C: 2 V: 2] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/317659 (owner: Ejegg) [22:02:55] ejegg: not sure what you mean, is the db just called fredge? [22:02:59] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/317662 [22:03:12] cwd uhh, let me check [22:04:48] cwd yeah, db name is just 'fredge' [22:05:08] (CR) jenkins-bot: [V: -1] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/317659 (owner: Ejegg) [22:05:10] oh ok thanks [22:05:51] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/317662 (owner: Ejegg) [22:05:58] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/317662 (owner: Ejegg) [22:06:53] cwd look at puppet/modules/crm/templates/settings.php.erb for the credentials [22:10:21] !log updated civicrm from 3b76de564aef4dad7807be2d3e570dec38696227 to 9e288691de2e918d00928c9164e0f2389563888d [22:10:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:12:33] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: Don't delete pending details for Adyen donations left for review - https://phabricator.wikimedia.org/T148859#2735027 (Ejegg) deletion fix deployed, but we may get some failmail ov... [22:23:07] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, FR-Smashpig, and 2 others: Adyen audits not downloading - https://phabricator.wikimedia.org/T148216#2740385 (Ejegg) Open>Resolved [22:25:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#2740392 (Ejegg) [22:25:25] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Merge conflict on source - https://phabricator.wikimedia.org/T146946#2675687 (Ejegg) Open>Resolved [22:26:02] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Remove refunds from Silverpop donation history - https://phabricator.wikimedia.org/T148062#2740393 (Ejegg) Open>Resolved [22:27:49] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Bugs, Patch-For-Review: Generic Individuals Import Error - https://phabricator.wikimedia.org/T147521#2740395 (Ejegg) @LeanneS OK, I deployed a bit of code that will make the import work... [22:28:00] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Bugs, Patch-For-Review: Generic Individuals Import Error - https://phabricator.wikimedia.org/T147521#2740396 (Ejegg) Open>Resolved [22:31:16] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Remove refunds from Silverpop donation history - https://phabricator.wikimedia.org/T148062#2740410 (CCogdill_WMF) Confirmed this looked good on my contact record! Thanks so much, @Ejegg! [22:47:33] ejegg: judging by common.yaml the creds are the same for smashpig and fredge, am i reading that right? [22:48:02] "%{hiera('mysql::root_password')}" will be the same as "<%= scope.lookupvar('mysql::root_password') %>" [22:48:06] is that right? [22:48:48] cwd ah... shoot, I forget how that works [22:48:56] but yeah, I think that's true [22:49:10] cool [22:49:26] there are a lot of layers going on [23:24:30] Fundraising-Backlog, Patch-For-Review: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2740595 (Ejegg) I think it'll make a big difference to tailor the list to our donors. But including the list of our top 100 email domains in the so... [23:43:11] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Show contribution tracking ID in error messages as 'Reference #' - https://phabricator.wikimedia.org/T147679#2740604 (Ejegg) hmm, maybe it shou... [23:50:51] (PS1) Ejegg: Make mailcheck more conservative [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/317726 (https://phabricator.wikimedia.org/T148970) [23:51:54] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2740651 (Ejegg) a:Ejegg [23:53:06] Fundraising Sprint Testing on Production, Fundraising-Backlog, Unplanned-Sprint-Work: Exceptions logged for TY unsubscribe - https://phabricator.wikimedia.org/T148996#2739052 (Ejegg) fix is deployed, but we should pull the addresses out of the logs and make sure to unsubscribe them