[00:13:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Insert missing subscription records for PayPal recurring donors - https://phabricator.wikimedia.org/T149146#2743571 (Ejegg) p:High>Normal [01:05:12] (PS3) Eileen: Address a second way in which contacts are winding up without primaries. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/313933 (https://phabricator.wikimedia.org/T145873) [01:18:57] (CR) AndyRussG: [C: 2] MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [01:19:45] María, María, I just met a (strict) DB named María! [01:20:52] (Merged) jenkins-bot: MariaDB strict mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/310457 (https://phabricator.wikimedia.org/T145591) (owner: Ejegg) [04:00:09] (PS2) Eileen: Add decile field to prospect. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317994 (https://phabricator.wikimedia.org/T147965) [04:00:11] (PS1) Eileen: Add new prospect custom fields to custom fields declaration. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318038 (https://phabricator.wikimedia.org/T147985) [05:05:39] (PS1) Eileen: Update trigger mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318041 (https://phabricator.wikimedia.org/T147985) [05:13:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Added new Custom Field on Production - https://phabricator.wikimedia.org/T142624#2743820 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/#/c/318041/ covers the triggers part of reflecting this change [05:52:18] (PS2) Ejegg: Use booleans in function signatures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312063 [05:53:12] (PS3) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [05:55:36] (PS2) Ejegg: Use IDatabase in function signatures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312073 [07:02:14] (PS1) Eileen: Add benefactor fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) [07:02:57] (CR) jenkins-bot: [V: -1] Add benefactor fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [07:05:08] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [07:55:51] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [14:38:59] Fundraising-Backlog, fundraising-tech-ops: Access for new contractor, Allen - https://phabricator.wikimedia.org/T148105#2744980 (Jgreen) Open>Resolved >>! In T148105#2742785, @LeanneS wrote: > @Jgreen I don't believe so. Was GR set up with a civi account? Nope, they weren't. Closing this ticket... [16:39:52] (PS1) Cdentinger: Increase paypal log mail to 8192 bytes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/318125 [16:46:34] ah, thanks cwd! [16:46:44] sure! think that's enough? [16:46:50] (CR) Ejegg: [C: 2] Increase paypal log mail to 8192 bytes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/318125 (owner: Cdentinger) [16:46:57] probably [16:46:58] guess we'll see [16:47:04] i couldn't get filesize of that temp file [16:47:50] oh hey, would you mind CRing one other tiny smashpig patch? https://gerrit.wikimedia.org/r/317273 will fix some links in failmail [16:47:52] (Merged) jenkins-bot: Increase paypal log mail to 8192 bytes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/318125 (owner: Cdentinger) [16:49:10] sure thing [16:50:47] (CR) Cdentinger: [C: 2] "Nice, I think we should return the affected ID whenever possible" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317273 (owner: Ejegg) [16:52:08] (Merged) jenkins-bot: Fix DamagedDb::storeMessage return value [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317273 (owner: Ejegg) [16:54:12] ty cwd [16:54:27] i'll deploy that log change [16:56:44] errr... silly library network is making gerrit access annoying. someone else want to deploy smashpig? [16:58:21] sure thing [16:58:26] uno momento [17:00:10] fr-tech: Teeth for meat are in the mouth -- [17:00:10] Teeth for humans are in the soul. [17:00:10] A strong body defeats one, [17:00:10] A strong soul conquers many. [17:00:10] -- Chinggis (Genghis) Khan [17:00:11] -- discuss. [17:03:29] (PS1) Cdentinger: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/318127 [17:04:49] Fundraising Sprint Testing on Production, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 3 others: Don't show donors error messages when error occurs after successful payment - https://phabricator.wikimedia.org/T120228#2745466 (Ejegg) a:Ejegg [17:06:11] (CR) Ejegg: "Grumble.. a whole new table for these two? Maybe we can get them folded into WMF_donor to keep the joins down." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [17:06:15] ejegg: https://gerrit.wikimedia.org/r/#/c/318127/ -- since i deleted the test here, it shows the delete even though that file didn't exist on deployment. did i screw something up or is this a gerrit ui thing? [17:07:55] the commit doesn't show that so it must just be gerrit [17:08:56] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/318127 (owner: Cdentinger) [17:09:09] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/318127 (owner: Cdentinger) [17:09:11] cwd I think it just shows that since it's a merge conflict resolution [17:10:14] i wonder where it even gets that information [17:10:30] AndyRussG: anything specifc I can ask for in Scrum of Scrums re: banners? [17:11:01] fr-tech: I'm getting some requests to look at T148196, anyone able to grab that? [17:11:01] T148196: Feature flag donation link - https://phabricator.wikimedia.org/T148196 [17:11:04] cwd well, it's like you merged in all the changed files from master, but then you deleted one of them. [17:11:17] adamwight: yep, talking with raynor right now! [17:11:58] I think mhernandez or pcoombe might want to weigh in on that one [17:12:00] onice! [17:12:49] ejegg: thanks! I'd say don't worry about it... Though the bug is important I think it's less urgent, and I imagine people would just suggest we talk to the experts in that code corner, as before... [17:13:30] OK, gotcha [17:13:39] ejegg: if you think it's worth mentioning please don't hesitate to, also, though, of course [17:13:45] any other Scrum of Scrums news or asks from fr-tech? [17:13:48] at least it's part of what we're working on [17:13:56] adamwight: thanks! [17:15:04] adamwight: Onyx in Italian? https://it.wikipedia.org/wiki/Onice [17:15:10] yolo? [17:15:21] sorry I'm not in fr-tech-talk btw, I did want to get input on changing DI behavior on session timeout: https://gerrit.wikimedia.org/r/318015 [17:16:25] i am not either, my dad is here working on some plumbing so ihave to answer a few questions [17:16:33] but i will take a look and that after i deploy this [17:16:47] ejegg: np...! I've not much got... any other time is also fine if u think I could help (probably not much to say on that particular topic, unless u feel like explaining a lot.......) [17:16:56] * AndyRussG makes excuses [17:17:18] I should have the record banner loader errors thingy done in a bit [17:17:59] oh cool! [17:22:46] ejegg: cwd XenoRyet AndyRussG I feel like I'm going to ask something really simple and silly but the reading team wants to get rid of SkinMinervaBeta and remove the donation link. see https://phabricator.wikimedia.org/T148196 Do you know what SkinMinervaBeta is? [17:23:00] !log updated smashpig from daba8c07108246261ca7ec557e3f1e5da430826e to f5f49d79fac0887df78ddcc68a2f5ced0670c387 [17:23:06] I was directed to this task and I don't have enough context to respond [17:23:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:24:36] dstrine: I pinged megan and peter on that one - they might want to try a donation link on mobile someday [17:25:47] ejegg: is this in an app or is this a mobile web page thing? [17:26:04] mobile web [17:27:32] man just a lot of new failmails popping up [17:28:58] ejegg: how can I find the link that they are proposing to remove? [17:31:12] dstrine: i think it's in the mobile beta skin, and it's not actually configured on production [17:32:05] umm ok [17:35:27] dstrine: the mobile skin is the thing that makes the mobile site mobile. Mobile beta skin is the beta version [17:36:22] no one has ever seen this donate link on wikipedia [17:37:06] dstrine: e.g. https://en.m.wikipedia.org/wiki/Main_Page [17:37:21] dstrine: https://www.mediawiki.org/wiki/Extension:MobileFrontend [17:37:22] AndyRussG: yeah I get that much at this point. The skin name didn't give me much of a hint though. [17:37:54] Yes... It's not very explanational. Also, in Mediawiki a skin is much more than you'd expect [17:41:28] cwd: yeah I was already there. I don't actually see a donation link anywhere. [17:41:50] dstrine: yep, it's never been turned on [17:42:05] so they are just asking if we were ever planning to turn it on [17:46:30] ok I will have to email this. We won't get a response from stakeholders on phab :( [17:51:15] thanks dstrine [17:54:34] dstrine: ^ what cwd said :) [19:01:10] (PS1) Ejegg: Don't explode on pendingDb delete call missing oid [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/318146 (https://phabricator.wikimedia.org/T149123) [19:02:01] fr-tech: ^^^ fixes the issue that made us drop the recent large donation from Civi [19:02:49] We could instead wrap the pendingDb call in a try/catch [19:27:27] (PS1) Ejegg: Fill missing order_id while normalizing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318150 (https://phabricator.wikimedia.org/T149123) [19:28:24] (PS2) Ejegg: Fill missing order_id while normalizing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318150 (https://phabricator.wikimedia.org/T149123) [19:28:26] ejegg: Ha! I was just looking at that other patch and wondering what was goign to happen to the stuff that didn't have order_id [19:30:14] belt and suspenders! [19:30:35] Yep [19:31:18] (CR) jenkins-bot: [V: -1] Fill missing order_id while normalizing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318150 (https://phabricator.wikimedia.org/T149123) (owner: Ejegg) [19:31:30] I do think the way you did it is better than a try/catch. [19:32:46] (CR) XenoRyet: [C: 2] Don't explode on pendingDb delete call missing oid [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/318146 (https://phabricator.wikimedia.org/T149123) (owner: Ejegg) [19:33:14] (CR) Eileen: "Actually I think only 1 is new. The other just wasn't in our dev builds. So from 1 table for 1 field to 1 table for 2 I think" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [19:35:09] (Merged) jenkins-bot: Don't explode on pendingDb delete call missing oid [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/318146 (https://phabricator.wikimedia.org/T149123) (owner: Ejegg) [19:36:52] (PS3) Ejegg: Fill missing order_id while normalizing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318150 (https://phabricator.wikimedia.org/T149123) [19:40:04] (PS2) Eileen: Add new prospect custom fields to custom fields declaration. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318038 (https://phabricator.wikimedia.org/T147985) [19:40:22] (PS1) Ejegg: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318155 [19:40:53] (CR) Ejegg: [C: 2] Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318155 (owner: Ejegg) [19:41:38] (CR) Eileen: "I fixed the 2 comment ones" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317994 (https://phabricator.wikimedia.org/T147965) (owner: Eileen) [19:44:06] (PS2) Eileen: Update trigger mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318041 (https://phabricator.wikimedia.org/T147985) [19:44:08] (PS2) Eileen: Add benefactor fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) [19:46:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Added new Custom Field on Production - https://phabricator.wikimedia.org/T142624#2746119 (Eileenmcnaughton) a:Eileenmcnaughton I pushed up a patch for this to review since I was adding other custom fields & it made more sense... [19:47:43] Fundraising Sprint Testing on Production, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Central Notice: Consider options for monitoring versions of banners shown - https://phabricator.wikimedia.org/T148593#2727179 (DStrine) [19:47:58] fr-tech this one will restore the logging we used to have in queue consumers, and really help debugging things like that missing large donation: https://gerrit.wikimedia.org/r/314056 [19:49:14] (Merged) jenkins-bot: Update SmashPig lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318155 (owner: Ejegg) [19:51:00] (PS2) Ejegg: Log raw messages in queue consumers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/314056 [19:51:06] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2746147 (DStrine) [19:51:15] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Spike: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2746159 (DStrine) [19:51:47] (PS3) Ejegg: Log raw messages in queue consumers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/314056 [19:52:19] (PS3) Ejegg: Add decile field to prospect. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317994 (https://phabricator.wikimedia.org/T147965) (owner: Eileen) [19:52:29] (CR) Ejegg: [C: 2] Add decile field to prospect. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317994 (https://phabricator.wikimedia.org/T147965) (owner: Eileen) [19:53:04] (PS3) Ejegg: Add new prospect custom fields to custom fields declaration. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318038 (https://phabricator.wikimedia.org/T147985) (owner: Eileen) [19:53:46] Fundraising-Backlog, FR-Ingenico: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2746164 (DStrine) [19:53:54] (CR) Ejegg: [C: 2] Add new prospect custom fields to custom fields declaration. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318038 (https://phabricator.wikimedia.org/T147985) (owner: Eileen) [19:55:50] (Merged) jenkins-bot: Add decile field to prospect. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/317994 (https://phabricator.wikimedia.org/T147965) (owner: Eileen) [19:56:26] (Merged) jenkins-bot: Add new prospect custom fields to custom fields declaration. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318038 (https://phabricator.wikimedia.org/T147985) (owner: Eileen) [19:57:10] (PS3) Ejegg: Update trigger mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318041 (https://phabricator.wikimedia.org/T147985) (owner: Eileen) [19:57:24] (CR) Ejegg: [C: 2] Update trigger mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318041 (https://phabricator.wikimedia.org/T147985) (owner: Eileen) [19:57:52] (PS3) Ejegg: Add benefactor fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [19:58:57] (CR) Ejegg: [C: 2] "TODO: see if MG would be cool with folding this group into WMF_donor" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [19:59:59] (Merged) jenkins-bot: Update trigger mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318041 (https://phabricator.wikimedia.org/T147985) (owner: Eileen) [20:01:24] (PS1) AndyRussG: Handle banner loader errors on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318159 (https://phabricator.wikimedia.org/T149107) [20:02:08] ^ bwahahahah [20:02:14] (Merged) jenkins-bot: Add benefactor fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318049 (https://phabricator.wikimedia.org/T142624) (owner: Eileen) [20:02:59] (CR) jenkins-bot: [V: -1] Handle banner loader errors on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318159 (https://phabricator.wikimedia.org/T149107) (owner: AndyRussG) [20:03:46] picky jscs... [20:04:29] ejegg: thanks [20:05:11] eileen1: I should look at that merge one too - those patches just take a non-trivial amount of mental effort to understand :) [20:05:31] ejegg: yeah :-( [20:05:42] I think I got it with the tests [20:05:55] this is probably higher priority [20:05:55] https://gerrit.wikimedia.org/r/#/c/313933/ [20:06:15] ah yeah, that's what I meant. [20:06:17] sprry this https://gerrit.wikimedia.org/r/#/c/316930/ [20:06:34] ohhh yeah, ok [20:06:44] I'll want to compare some before & after SQL I guess [20:07:34] basically it is the order by that changes [20:07:48] hmm, upstream PR has a failing test - is that harmless? [20:07:49] - there are unit tests for it in core - [20:07:54] https://test.civicrm.org/job/CiviCRM-Core-PR/12397/testReport/junit/(root)/api_v3_ContactTest/testGetQuickID/ [20:08:03] let me check - after this meeting [20:08:33] I think it's just because I altered the source data to be more nuanced & didn't update that test [20:08:42] meeting? is this a civi thing that awight was attending? [20:09:18] if i'd be any use in the meeting feel free to add me [20:13:14] (PS4) Eileen: Address a second way in which contacts are winding up without primaries. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/313933 (https://phabricator.wikimedia.org/T145873) [20:33:10] (CR) Cdentinger: [C: 2] Log raw messages in queue consumers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/314056 (owner: Ejegg) [20:36:40] ejegg|food: I'll check with dstrine later on that [20:38:19] ejegg|food: re the merge one - perhaps I should add a patch on the preferred language before you look - might be more worth putting your head there for one than 2 [20:42:14] (Merged) jenkins-bot: Log raw messages in queue consumers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/314056 (owner: Ejegg) [20:57:58] ejegg: I just checked that quicksearch test - it was a test data issue - I'm happy to talk the patch through over chat if that is easier that trying to make sense of it - with you or one of the other guys [21:06:53] https://github.com/avleen/bashttpd [21:07:14] sorry, back in a few eileen1 [21:13:02] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Resolve conflicts on preferred language where the languages differ - to most recent - https://phabricator.wikimedia.org/T149242#2746395 (Eileenmcnaughton) [21:25:06] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Resolve conflicts on preferred language where the languages differ - to most recent - https://phabricator.wikimedia.org/T149242#2746467 (Eileenmcnaughton) O... [21:33:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Donation form extends off the right side of the page in some mobile browsers - https://phabricator.wikimedia.org/T149247#2746521 (Ejegg) [21:36:05] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2746547 (DStrine) [21:36:13] Fundraising-Backlog: Remove na@na.com email from DB - https://phabricator.wikimedia.org/T149248#2746561 (Krenair) civicrm_email... something to do with fundraising I guess [21:44:33] Fundraising-Backlog: Remove na@na.com email from DB - https://phabricator.wikimedia.org/T149248#2746604 (Eileenmcnaughton) opps yes [21:47:24] Fundraising-Backlog: Remove na@na.com email from DB - https://phabricator.wikimedia.org/T149248#2746610 (Krenair) Okay. Is the email address supposed to be in this public ticket? [21:50:33] Fundraising-Backlog: Remove na@na.com email from DB - https://phabricator.wikimedia.org/T149248#2746631 (Eileenmcnaughton) Yeah - our belief is that it is never valid - it's just rubbish people write into fill i the field so it's not PI as such [21:53:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-log-errors: Don't serve an exception on Special:CentralNoticeBanners when the banner doesn't exist - https://phabricator.wikimedia.org/T149240#2746641 (DStrine) [21:56:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove na@na.com email from DB - https://phabricator.wikimedia.org/T149248#2746643 (DStrine) [22:08:46] eileen1: congrats! [22:09:32] (CR) Ejegg: "Some of these comments are unrelated to this patch. Maybe some live code review later?" (5 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/316930 (https://phabricator.wikimedia.org/T147344) (owner: Eileen) [22:13:13] cwd thanks [22:23:41] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 3 others: [Tracking] Stop producing to ActiveMQ - https://phabricator.wikimedia.org/T145660#2746712 (Ejegg) Open>Resolved [22:26:11] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Missing "gross" and "currency"; positive amount; failmails from donations queue consumer - https://phabricator.wikimedia.org/T147491#2746726 (DStrine) ... [22:27:45] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 2 others: Receipt/Thank you letters from Civi - Fix template? - https://phabricator.wikimedia.org/T137496#2746730 (DStrine) Open>Resolved [22:28:30] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Refund QC not catching exceptions, uninformative logging - https://phabricator.wikimedia.org/T148880#2746733 (Ejegg) Open>Resolved [22:28:43] Fundraising-Backlog: Fix unicode issue in backoffice receipts (follow up from T137496) - https://phabricator.wikimedia.org/T149255#2746734 (Eileenmcnaughton) [22:28:48] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 3 others: Create UI for damaged message DB - https://phabricator.wikimedia.org/T142058#2746747 (Ejegg) Open>Resolved [22:29:11] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: Don't delete pending details for Adyen donations left for review - https://phabricator.wikimedia.org/T148859#2746748 (Ejegg) Open>Resolved [22:29:14] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, and 2 others: CN Campaign Setting oddities - https://phabricator.wikimedia.org/T145447#2746749 (DStrine) Open>Resolved [22:32:49] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Show contribution tracking ID in error messages as 'Reference #' - https://phabricator.wikimedia.org/T147679#2700637 (Ejegg) Open>Resolv... [22:42:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal, Recurring-Donations: Create Civi records for legacy PayPal subscriptions - https://phabricator.wikimedia.org/T119899#2746788 (Ejegg) [22:42:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Insert missing subscription records for PayPal recurring donors - https://phabricator.wikimedia.org/T149146#2746790 (Ejegg) [22:49:46] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, and 2 others: Resolve conflicts on preferred language where the languages differ - to most recent - https://phabricator.wikimedia.org/T149242#2746813 (DStrine) [22:49:48] Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove na@na.com email from DB - https://phabricator.wikimedia.org/T149248#2746812 (DStrine) [22:49:50] Fundraising Sprint U 2016, Fundraising-Backlog: Show contribution tracking ID in Ingenico error messages as full 'External Reference #' - https://phabricator.wikimedia.org/T149137#2746814 (DStrine) [22:49:52] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Exceptions logged for TY unsubscribe - https://phabricator.wikimedia.org/T148996#2746817 (DStrine) [22:49:54] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice: Relay banner loading issues in beacon/impression - https://phabricator.wikimedia.org/T149107#2746816 (DStrine) [22:49:56] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Central Notice: Consider options for monitoring versions of banners shown - https://phabricator.wikimedia.org/T148593#2746818 (DStrine) [22:49:58] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2746819 (DStrine) [22:50:01] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Patch-For-Review, and 2 others: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2746820 (DStrine) [22:50:02] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changed Disc Income Decile Labels on Prospect Tab in Civi - https://phabricator.wikimedia.org/T147965#2746823 (DStrine) [22:50:04] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New fields added to the Prospect Tab in Civi - https://phabricator.wikimedia.org/T147985#2746821 (DStrine) [22:50:06] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, FR-Amazon, and 3 others: Amazon donation order ids are useless when generated by processor - https://phabricator.wikimedia.org/T147973#2746822 (DStrine) [22:50:08] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Missing ct_id on fredge messages from orphan rectifier - https://phabricator.wikimedia.org/T147873#2746824 (DStrine) [22:50:11] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: restore the 'unsubscribe from spam' option to Main menu - https://phabricator.wikimedia.org/T147571#2746825 (DStrine) [22:50:13] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, and 5 others: New failmail from recurring queue consumer - https://phabricator.wikimedia.org/T147487#2746826 (DStrine) [22:50:15] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, and 3 others: Adyen GB form not loading correctly - https://phabricator.wikimedia.org/T147475#2746827 (DStrine) [22:50:17] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, and 3 others: Orphan rectifier not sending to payments-initial nor payments-fraud queues - https://phabricator.wikimedia.org/T145848#2746831 (DStrine) [22:50:20] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, and 3 others: CentralNotice: Support MariaDB Strict Mode - https://phabricator.wikimedia.org/T145591#2746832 (DStrine) [22:50:23] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, and 2 others: Impressions slow to update on jaJP dsk campaign - https://phabricator.wikimedia.org/T145446#2746834 (DStrine) [22:50:26] Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, and 5 others: Investigate the discrepancy between pageview counts and banner impressions for ... - https://phabricator.wikimedia.org/T145565#2746833 [22:50:29] Fundraising Sprint U 2016, Fundraising-Backlog, FR-Amazon, FR-2016-17-Q2-Campaign-Support: Allow Amazon users who have selected to stay logged in to bypass login on a second donation - https://phabricator.wikimedia.org/T145251#2746835 (DStrine) [22:50:31] Fundraising Sprint Pretending This Isn't Happening, Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, and 7 others: Delete from the pending database when a transaction is failed or comp... - https://phabricator.wikimedia.org/T143945#2746839 [22:50:34] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, and 2 others: Longterm fix + regression test for T144489 - https://phabricator.wikimedia.org/T144557#2746837 (DStrine) [22:50:36] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, and 6 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2746836 (DStrine) [22:50:39] Fundraising Sprint Octopus Untangling, Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, and 4 others: Epic: Create frack vm cluster - https://phabricator.wikimedia.org/T142533#2746843 (DStrine) [22:50:41] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, FR-Ingenico, FR-2016-17-Q2-Bugs: Duplicate Ingenico iframe bug - https://phabricator.wikimedia.org/T143430#2746841 (DStrine) [22:50:43] Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Added new Custom Field on Production - https://phabricator.wikimedia.org/T142624#2746842 (DStrine) [22:50:45] Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Campaign-Support: Not all online donations getting tagged to Restrictions and Gift Source Fields - https://phabricator.wikimedia.org/T138361#2746844 (DStrine) [22:50:47] Fundraising Sprint U 2016, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support: Add field to Silverpop export: highest_native_amount - https://phabricator.wikimedia.org/T135407#2746845 (DStrine) [22:50:49] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Testing on Production, Fundraising Sprint U 2016, and 8 others: [Epic] Do not show donation form error message: "No processors available". Fix UI and ... - https://phabricator.wikimedia.org/T117872#2746846 [23:01:59] https://commons.wikimedia.org/wiki/Category:Adhesives [23:02:09] cwd ^^ [23:02:27] nice [23:03:53] https://upload.wikimedia.org/wikipedia/commons/thumb/d/d8/Flaming_computer_-_%22don%27t_panic%22_%284549185468%29.jpg/640px-Flaming_computer_-_%22don%27t_panic%22_%284549185468%29.jpg [23:12:15] ejegg|meet: wondering about this one: https://phabricator.wikimedia.org/T147378 -- i see you moved it to done on the last sprint but there isn't much to see on this ticket. [23:12:21] do you remember what the deal is? [23:15:39] cwd the issue was we were deleting too many pending details [23:16:19] we mostly fixed that, but mbeat had a bunch of trxns to check in a comment a couple days ago [23:16:47] ejegg: do you want to do a quick 10 minute chat on that exactmatch patch - make in about 15 mins [23:17:05] eileen1: sure, just video call me when you're ready [23:17:10] ok [23:33:02] (PS5) Eileen: Address a second way in which contacts are winding up without primaries. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/313933 (https://phabricator.wikimedia.org/T145873) [23:33:04] (PS1) Eileen: Adjust preferred_language dedupe conflict resolution to prefer later donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318224 (https://phabricator.wikimedia.org/T149242) [23:35:42] ejegg: thanks, shall i check into those? [23:36:08] cwd that would be great! [23:36:28] Guessing some are like these session timeout ppl who were able to donate on the 2nd attempt [23:36:39] (PS1) Eileen: Remove placeholder emails (na@na.com). [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318225 (https://phabricator.wikimedia.org/T149248) [23:36:39] but adyen still associated it with the 1st [23:37:07] ah so they were stopped at adyen for fraud? not by us [23:41:45] ejegg: trying you on chat now [23:42:04] eileen1: sorry, browser crashed, reopening [23:48:03] (CR) Ejegg: [C: 2] "Eileen explained that taking away the sort on exactFirst limits the number of contacts the IF clause is actually executed on, so this is a" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/316930 (https://phabricator.wikimedia.org/T147344) (owner: Eileen) [23:50:48] (Merged) jenkins-bot: CRM-19547 rationalise expensive use of exactMatch search on quicksearch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/316930 (https://phabricator.wikimedia.org/T147344) (owner: Eileen) [23:57:47] (CR) Ejegg: [C: 2] "Well tested!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/313933 (https://phabricator.wikimedia.org/T145873) (owner: Eileen)