[14:50:23] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising-Backlog, Patch-For-Review, and 2 others: Fix email address validation on donation form to allow yahoo.ca addresses - https://phabricator.wikimedia.org/T148970#2756758 (MBeat33) The donor comment from #253366... [16:10:26] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2757159 (Ppena) @Nirzar thanks so much for this detailed work- it's great! I agree with all of it, although we cannot change anything within the iframe. Was thinking on the card buttons... they do look better, but do... [16:26:09] (Abandoned) Ejegg: DO NOT MERGE: try to make paypal audit testable [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/305672 (owner: Ejegg) [16:40:27] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2757302 (Nirzar) @Ppena >although we cannot change anything within the iframe. Do you mean we can't change any css in the iframe? >Couldn't we just add a bigger version of the card icon, and make them blue to show... [17:00:16] fr-tech: To be trusted is a greater compliment than to be loved. [17:00:16] -- discuss. [17:07:15] I'm over in fr-tech-talk, if anyone has anything to discuss [17:07:29] oh wait, are folks in the matrix chat? [17:07:40] just me :( [17:07:47] heh, I'll join! [18:23:54] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2757786 (Ppena) @Nirzar Correct, AFAK we have very little input on iframe apart from removing fields, but that would be a @Ejegg question. Gotcha on the buttons, thanks for the intel. [18:27:00] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2757802 (Nirzar) @Ejegg mentioned we can have css for iframe. not sure about the caveat in that. the small touch areas for credit card form are concerning. call to action alone can improve confidence in action. so I... [18:48:51] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2757906 (Ejegg) @Nirzar and @PPena, both Ingenico and Adyen let us load our own stylesheet in their frame. Adyen also lets us customize header and footer elements. [19:16:53] (CR) Ejegg: [C: 2] "All looks good, works as intended in local testing of both the .fail() handler and caught exceptions." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318159 (https://phabricator.wikimedia.org/T149107) (owner: AndyRussG) [19:24:32] (Merged) jenkins-bot: Handle banner loader errors on client [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318159 (https://phabricator.wikimedia.org/T149107) (owner: AndyRussG) [19:30:55] ejegg: thx! [19:31:36] blemish-free code! [19:34:36] (PS5) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [19:39:12] ejegg: heheh mebbe there's stealth surprise blemishes secretly encoded using a spy decoder ring [19:42:40] * ejegg adds cracker jacks to shopping list [19:42:57] Pretty sure I threw in at least a little blemish sayce [19:42:59] sauce [19:44:35] We standing up on hangouts, or the new thing? [19:46:34] I'm confused too [19:46:41] I am in the hangout but feeling alone [19:55:13] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Campaign-Support: Not all online donations getting tagged to Restrictions and Gift Source Fields - https://phabricator.wikimedia.org/T138361#2758134 (E... [20:01:05] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Amazon, FR-2016-17-Q2-Campaign-Support: Allow Amazon users who have selected to stay logged in to bypass login on a second donation - https://phabricator.wikimedia.org/T145251#2758144 (cwdent) a:cwdent [20:06:55] Fundraising-Backlog, Easy, FR-2016-17-Q2-Campaign-Support: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#964325 (DStrine) We may want to do this with Adyen in the relatively near future. [20:07:07] Fundraising-Backlog, FR-Adyen, Easy, FR-2016-17-Q2-Campaign-Support: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2758188 (DStrine) [20:19:50] sorry fr-tech, connection is really spotty right here [20:55:05] (PS6) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [20:57:39] (PS7) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [20:57:41] (PS1) Ejegg: Prune unused log parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318987 [21:13:18] (CR) Eileen: [C: -1] "I hit 2 things on testing this" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [21:14:51] thanks eileen1, I'll fix those up! [21:17:44] ejegg: otherwise it's good [21:32:17] (PS1) Eileen: Trim whitespace when comparing names for conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/318993 [21:47:58] ejegg: sorry i am having trouble finding this amazon parameter to let people stay logged in. looking through our js and here: https://payments.amazon.com/developer/documentation/express/201737770 [21:49:50] cwd ah, let me see [21:52:11] (PS14) Ejegg: Local geocoding for US addresses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) [21:54:30] cwd shoot, I guess the default is to use the cached authorization :( [21:54:43] https://developer.amazon.com/public/apis/engage/login-with-amazon/docs/javascript_sdk_reference.html#authorize [21:55:05] so... not sure what else we need to do [21:55:37] huh [21:55:45] wow their code even handles the redirect? [22:01:54] eileen1: maybe I should be using a hook that lets me see old and new values, to avoid clobbering geo data we got from someplace else [22:02:33] ejegg: I'm not sure civi really respects that anyway [22:02:45] (CR) Eileen: Local geocoding for US addresses (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/316728 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [22:03:14] I found that even if I hand enter geocodes on the form it is gone by the time it hits the hook [22:03:32] geocoding provider, huh? I should look into that [22:03:40] If you enable geocoding (e.g google) you get a checkbox offering you to override the geocoding [22:03:45] ohhh [22:03:54] but it doesn't do that when no geocoding is enabled [22:04:40] (administer/system settings/ mapping & geocoding) [22:05:10] ejegg: heh yeah so i confirmed that is working [22:05:18] if you click "keep me logged in" it does [22:13:47] cwd so... there's nothing to do on the ticket? [22:14:25] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Amazon, FR-2016-17-Q2-Campaign-Support: Allow Amazon users who have selected to stay logged in to bypass login on a second donation - https://phabricator.wikimedia.org/T145251#2758579 (cwdent) Open>Invalid We are already set up to... [22:14:45] ejegg: far as i can tell [22:16:38] dstrine: fyi ^ [22:19:13] weird, I could have sworn we forced interactive mode, but I don't see it in the history. Maybe folks convinced me to drop it while it was still in review [22:19:40] cwd: ejegg sooo it's already done?! [22:20:29] dstrine: that's the good news AND the bad news [22:20:56] what he said [22:22:00] cwd: 's comment says it's working as spec'd. I can't remember the last time I tried the flow... it might have been like in May. What's the bad news? [22:22:13] that it's always been like that [22:22:32] so if folks aren't seeing it work, i have no idea what's going wrong in those cases [22:22:36] yeah, i didn't change anything [22:24:23] PPena: and ppena_ as far as we can tell. It looks like this is already implemented: https://phabricator.wikimedia.org/T145251 [22:25:12] cwd: ejegg It's possible this has been on our lists for so long that no one has looked at this exact case on prod for a while to notice [22:25:49] huh [22:27:32] looking at the oldest version of that file in the repo, that function call is the same [22:38:32] hmm wow yeah I just tested it and it worked fine. There is one difference in our production version that is not in the slides. If you look at slide 2, when I went for the page in screen shot 1 I got another page from us for a very brief period of time, then I went to screen shot 2. There had been a task about removing that extra page but I think we closed it [22:38:32] for other reasons. [22:41:45] dstrine: yeah, the alternative to that interstitial screen would be making the login window always be a popup [22:43:09] We've already had this conversation^^ I think that's been laid to rest. I'm tracking down pats... [22:45:09] (PS1) Ejegg: Use order id as error reference when possible [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319002 (https://phabricator.wikimedia.org/T149137) [22:56:22] cwd: ejegg ok I got an update. It's been a while since I saw these slides. So on slide 2 PPena actually wants screen shot 2 removed. Apparently there are settings for that. [22:57:16] Next time I'm going to make sure there is more context on these slides [22:59:09] dstrine: any clue as to where that setting would be? [23:00:54] asking PPena and looking in the docs I have [23:01:48] cwd dstrine hey. elliott mentioned that over an email [23:02:17] I'm not sure about documentation but can search for the email [23:03:13] cwd dstrine "I set the widget login options to always show the login screen, but I think I can tell it to skip that when you're already logged in. I guess I wanted to avoid any possibility of freaking out donors with an invisible login to their credit card. I'll test locally to see what that looks like" [23:03:23] I'm looking in the PSP master file but nothing is jumping out at me [23:03:38] does that rign a bell? [23:06:38] dstrine cwd what documentation are you looking at? website SDK reference? [23:07:05] The quote you have is from ejegg I'm wondering if this rings a bell for him [23:07:17] (PS1) Ejegg: Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) [23:07:46] PPena: yeah, I could have sworn I used that setting [23:08:02] but when I look at the code, it's always been set to remember existing logins [23:08:23] should we email Amzon to ask how to remove it? [23:08:25] I must have changed that in an early draft [23:08:30] may be faster [23:09:29] PPena: I'm not sure it's possible - the documentation says it's either a redirect or a popup [23:09:29] ejegg: just to recap... PPena is asking to remove screen 2 from slide 3 in the presentation https://docs.google.com/presentation/d/1yvu8kwLsvwGAq54onDO-Ah7CwvtaYQpfFcG4Xj6fQ2s/edit#slide=id.g16a08b4ee9_0_0 [23:09:42] ejegg: i think PPena is talking about a different thing, the "continue" page [23:10:06] sorry screen 2 on slide 2 [23:10:09] dstrine cw ejegg screen #2 from Slide #2 [23:10:16] dstrine: yeah, I'm looking in the Amazon docs and it looks like they always show some kind of Amazon authorization page [23:10:56] either a redirect or a popup [23:11:31] ejegg hmm ok so no way to go around it? [23:11:48] PPena: I'm afraid not [23:12:03] ejegg ARRGHHHHHHHHHHHHH :( ok :) [23:12:07] was nice to dream [23:12:13] yeah :( [23:12:20] (should we still ask them, though?) [23:13:04] it strikes me as probably a privacy policy type of thing [23:13:21] i'd bet the session only lasts as long as it does on Amazon's site - they ask for your pw before they let you spend money, at least once per day [23:14:00] ejegg the second screen doesnt ask for password, its justa continue button [23:14:30] which turns out is just slightly better than adding login/passw [23:14:46] ah, even that has a dropoff, huh? [23:15:20] We can ask 'em, but yeah, I'd bet it's a consent / notification requirement [23:16:31] strange like Paypal doesnt need it [23:17:41] sounds like amazon has its own internal quality bars/styles [23:20:59] I guess ppl expect to see their paypal details when we send them to paypal's site [23:21:32] but since the widget is on our site, Amazon wants to give people a choice whether to send us that info [23:26:28] !log increased payments-wiki session timeout [23:26:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:30:50] ok, that's still working [23:30:59] going to relocate [23:33:35] dstrine ejegg|afk Paypal is waiting for your reply on that 'Settlement File not showing "Recovered to PayPal' ticket. They may close the ticket soon. Just FYI [23:44:09] fundraising-tech-ops, Operations, ops-codfw: payments2002 disk failure - https://phabricator.wikimedia.org/T149646#2758792 (Jgreen) [23:50:37] PPena: thanks for the heads up!