[00:03:03] (PS5) XenoRyet: Adyen US form without city/state fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) [00:05:48] (CR) jenkins-bot: [V: -1] Adyen US form without city/state fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) (owner: XenoRyet) [13:03:31] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Remove County field from UK addresses? - https://phabricator.wikimedia.org/T122348#2771357 (Pcoombe) Open>Resolved a:Pcoombe Not sure when it happened, but it looks like this was removed from the forms. [16:06:54] ejegg|away you free for a meeting? [16:12:59] (PS1) WMDE-leszek: Fix a typo in a comment in impressionDiet.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319885 [16:23:20] Fundraising-Backlog: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2772086 (Nirzar) [17:00:16] fr-tech: After living in New York, you trust nobody, [17:00:16] but you believe everything. Just in case. [17:00:16] -- discuss. [17:10:00] dstrine: I'm so sorry I flaked out. joining now! [17:34:05] Fundraising-Backlog, FR-Paypal: PayPal server error 11/3 - https://phabricator.wikimedia.org/T149902#2772357 (MBeat33) The latest from Paypal: I am unable to see any internal errors in the transaction logs or the deeper transaction logs. However the one error I continue to see is duplicate transactions... [18:24:00] fundraising-tech-ops, Operations, ops-eqiad: lutetium RAID disk failed - https://phabricator.wikimedia.org/T149904#2768426 (Cmjohnson) disk swapped. [18:33:46] Fundraising-Backlog, FR-Paypal: PayPal server error 11/3 - https://phabricator.wikimedia.org/T149902#2768303 (Ejegg) In the Paypal console I see 'Yes, block multiple payments per invoice ID' selected, which I think applies to both mobile and desktop. Guessing we want to keep this to prevent duplicate don... [18:41:52] Fundraising-Backlog, FR-Paypal: PayPal server error 11/3 - https://phabricator.wikimedia.org/T149902#2772572 (MBeat33) Thanks, @Ejegg The volume of this error is still really high, like 35+ more today including very recent ones. I would bet this is more on PayPal's end, as why would this error show up in... [19:10:56] (PS3) Ejegg: Kill any configured fraud checks before making recurring charges [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [19:11:32] (CR) Ejegg: [C: 2] "Sorry I let this one get so stale!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [19:14:13] (PS1) Ejegg: Use more specific error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319905 (https://phabricator.wikimedia.org/T117872) [19:14:15] (PS1) Ejegg: Add more 'try again' errors for globalcollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319906 (https://phabricator.wikimedia.org/T117872) [19:15:25] (Merged) jenkins-bot: Kill any configured fraud checks before making recurring charges [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [19:15:37] (CR) Ejegg: [C: 2] Fix a typo in a comment in impressionDiet.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319885 (owner: WMDE-leszek) [19:17:51] (Merged) jenkins-bot: Fix a typo in a comment in impressionDiet.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319885 (owner: WMDE-leszek) [19:19:44] (CR) Ejegg: "Cool! Definitely the way to go. Suggestion for the 'undefined index' errors inline." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) (owner: XenoRyet) [19:26:49] (PS6) XenoRyet: Adyen US form without city/state fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) [19:28:59] (CR) jenkins-bot: [V: -1] Adyen US form without city/state fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) (owner: XenoRyet) [19:29:42] Right, gotta fix the tests to expect the new values too. [19:33:29] (PS7) XenoRyet: Adyen US form without city/state fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) [19:40:29] aaarg! [19:45:51] where are we meeting? [19:46:06] Just discussing that. No commitments yet. [20:33:41] Fundraising-Backlog: Bring back data previously held in contribution tracking table - https://phabricator.wikimedia.org/T150055#2772820 (DStrine) [20:52:08] (CR) Ejegg: [C: -1] "Humane! I do see a few more uses of that third parameter which will need changing: recurring_globalcollect.module L255, 318, 351; recurrin" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319757 (https://phabricator.wikimedia.org/T88460) (owner: Eileen) [21:01:08] Seddon: Any chance you could take a look at https://meta.wikimedia.org/wiki/CentralNotice/Request#2016_Community_Wishlist_Survey ? We're hoping to get this approved and running by sometime next week if possible. [21:13:09] Fundraising-Backlog: Bring back data previously held in contribution tracking table - https://phabricator.wikimedia.org/T150055#2772820 (Ejegg) More details on missing funnel stage added at https://collab.wikimedia.org/wiki/Fundraising/Engineering/Donation_Pipeline/Contribution_Tracking_Table#Data_that_isn.2... [21:18:03] (CR) Ejegg: [C: 2] "Code looks good, seems to work locally!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) (owner: XenoRyet) [21:20:13] (Merged) jenkins-bot: Adyen US form without city/state fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319414 (https://phabricator.wikimedia.org/T86239) (owner: XenoRyet) [21:29:52] (PS1) Ejegg: Put something in contribution_tracking.payments_form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319923 (https://phabricator.wikimedia.org/T150055) [21:30:41] XenoRyet: ^^^ should restore a little bit of the contribution_tracking data we lost in the switch off RapidHTML [21:32:39] also, want to take a look at the companion patch to your city/state removal? https://gerrit.wikimedia.org/r/319480 [21:38:29] Sure, looking [22:02:50] (PS1) Ejegg: More logging around fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319957 (https://phabricator.wikimedia.org/T145848) [22:03:35] fr-tech little logging patch I'd like to deploy Monday if possible ^^^ [22:17:09] (CR) Ejegg: "This will be really handy! That uri handling seems a little brittle though. Is it assuming ChecksFile will always be constructed with a 't" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319758 (https://phabricator.wikimedia.org/T88460) (owner: Eileen) [22:26:32] (CR) XenoRyet: [C: 2] Put something in contribution_tracking.payments_form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319923 (https://phabricator.wikimedia.org/T150055) (owner: Ejegg) [22:27:17] thanks XenoRyet ! [22:27:27] No worries. Looking at the other one now. [22:27:30] TODO: tests for contribution tracking row [22:27:42] k, going to relocate [22:28:37] (Merged) jenkins-bot: Put something in contribution_tracking.payments_form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319923 (https://phabricator.wikimedia.org/T150055) (owner: Ejegg) [22:32:39] (CR) XenoRyet: [C: 2] Fill in missing city and state from US zip code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319480 (https://phabricator.wikimedia.org/T86239) (owner: Ejegg) [22:36:38] (Merged) jenkins-bot: Fill in missing city and state from US zip code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319480 (https://phabricator.wikimedia.org/T86239) (owner: Ejegg) [22:42:15] (CR) XenoRyet: [C: 2] More logging around fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319957 (https://phabricator.wikimedia.org/T145848) (owner: Ejegg) [22:44:04] (Merged) jenkins-bot: More logging around fraud filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/319957 (https://phabricator.wikimedia.org/T145848) (owner: Ejegg) [22:53:34] (PS2) Ejegg: WIP capture Adyen payments missing pending messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/319489 (https://phabricator.wikimedia.org/T149861) [23:10:12] ejegg: and MBeat do we need to discuss: https://phabricator.wikimedia.org/T143736 [23:11:06] dstrine: It was a problem with the ingenico orphan rectifier setting I changed last night - I've rolled that back [23:11:45] is that before or after MBeat's comment ~12 minutes ago? [23:12:34] I rolled it back about an hour ago, so we're not getting any more false positives. [23:12:40] oh ok [23:12:52] ty ejegg [23:12:54] We did get a whole bunch earlier in the day, though, and MBeat is still cleaning those up [23:13:12] thanks. I have not been watching too closely. sorry to micro-manage [23:13:24] sorry for the mess! We definitely should reconsider the Minfraud failure mode [23:14:23] for sure. lots of minfraud scores block legit contribs, I can share the spreadsheets if you want to see. and ty for poking, dstrine [23:15:07] MBeat: np! [23:16:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#2773280 (Ejegg) [23:16:31] lappy dying... [23:38:21] ejegg|afk: well that's a sign ;) [23:38:32] I'm off too. Have a good weekend all.