[09:20:08] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#2775603 (hashar) Open>Resolved a:awight Done! flake8 runs on each patch proposal and pass :-} [17:00:16] fr-tech: Remember, if it's being done correctly, here or abroad, it's [17:00:16] *not* the U.S. Army doing it! [17:00:16] -- "Good Morning, Vietnam" [17:00:16] -- discuss. [17:00:37] Hi slander, can we adjust you for DST? [17:01:08] Hello AndyRussG [17:01:19] ejegg: hey! Are you no longer DST? [17:01:32] That'd be swell [17:01:56] Ah looks like it :) [17:02:46] Mmm yeah Google Calendar put everything back to where it used to be [17:03:47] AndyRussG: yep, I'm all switched over [17:03:58] got my bonus hour of sleep yesterday and today [17:05:01] ejegg: yeah that's always nice [17:05:07] We switched a week ago [17:06:03] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2776943 (Ejegg) This is ready to go out. @Pcoombe , @Ppena , @MeganHernandez_WMF , @Jseddon : want me to hold off deploying?... [17:08:07] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2776955 (Ejegg) There's a matching Civi patch that should automatically get the states and cities backfilled - the data we fou... [17:09:41] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2776965 (Ppena) Thanks @Ejegg . Can you confirm that the fields being removed are city and state? And if so, are we passing a... [17:11:39] haha [17:11:47] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2776971 (Ejegg) @Ppena , correct, we're removing city and state. We'll be stuffing those fields with 'NA' to avoid Adyen compl... [17:11:56] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2776972 (CCogdill_WMF) We got the time zone data,... [17:13:54] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2776973 (CCogdill_WMF) I'm a little worried the time zone data we got was incomplete, so just want to flag that Legal requests... [17:15:13] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2776975 (Ejegg) Oh darn, I hoped we had backfilled... [17:18:06] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add time zone data back into Silverpop export file - https://phabricator.wikimedia.org/T148578#2777007 (Ejegg) I see 4.4 million addresses in the... [17:33:29] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2777058 (Ppena) @CCogdill_WMF good thought. @Ejegg pls send the link around for internal testing first. [17:44:57] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2777099 (Ejegg) @CCogdill_WMF : the timezone data looks pretty good. Of US addresses with 5 characters in the postal code fiel... [17:47:13] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2777107 (CCogdill_WMF) Oh, cool, so just an issue with the silverpop file, then? That link looks like it still has city/state... [17:47:22] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2777111 (Ppena) @Ejegg yes pls push that through and let us know. Thank you! [17:50:56] (PS1) Ejegg: Fix missing timezone / postal code bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320233 (https://phabricator.wikimedia.org/T148578) [17:58:36] Fundraising-Backlog: Are we using 3DS APi call for Ingenico? - https://phabricator.wikimedia.org/T150192#2777156 (Krenair) [18:06:03] (PS2) Ejegg: WIP Fix missing timezone / postal code bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320233 (https://phabricator.wikimedia.org/T148578) [18:06:52] (CR) jenkins-bot: [V: -1] WIP Fix missing timezone / postal code bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320233 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [18:37:42] Fundraising-Backlog, FR-Paypal: PayPal server error 11/3 - https://phabricator.wikimedia.org/T149902#2777296 (Ejegg) It's been years since we changed the way we send order IDs to PayPal. Also, when I intentionally use the same order ID for two payments, I get a well formatted page that says "We can’t sen... [19:11:00] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Show contribution tracking ID in error messages as 'Reference #' - https://phabricator.wikimedia.org/T147679#2777432 (DStrine) [19:12:02] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Missing "gross" and "currency"; positive amount; failmails from donations queue consumer - https://phabricator.wikimedia.org/T147491#2777438 (DStrine) [19:15:47] Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Refund QC not catching exceptions, uninformative logging - https://phabricator.wikimedia.org/T148880#2777467 (DStrine) [19:15:49] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Don't delete pending details for Adyen donations left for review - https://phabricator.wikimedia.org/T148859#2777468 (DStrine) [19:15:55] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-10-25_(1.28.0-wmf.23): Fix email address validation on donation form to allow .fr addresses - https://phabricator.wikimedia.org/T148748#2777471 (DStrine) [19:15:57] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Paypal, FR-Smashpig, Patch-For-Review: Validate paypal messages in frontend rather than job runner - https://phabricator.wikimedia.org/T148678#2777473 (DStrine) [19:16:00] Fundraising Sprint Testing on Production, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Patch-For-Review: Adyen audits not downloading - https://phabricator.wikimedia.org/T148216#2777477 (DStrine) [19:16:04] Fundraising Sprint Testing on Production, Fundraising-Backlog, Patch-For-Review: Remove refunds from Silverpop donation history - https://phabricator.wikimedia.org/T148062#2777478 (DStrine) [19:30:35] (PS1) Ejegg: Update DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/320248 [19:30:51] (CR) Ejegg: [C: 2] Update DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/320248 (owner: Ejegg) [19:33:49] (PS1) Ejegg: Update DonationInterface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/320250 [19:35:04] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/320250 (owner: Ejegg) [19:36:31] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/320251 [19:36:42] (Merged) jenkins-bot: Update DonationInterface library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/320248 (owner: Ejegg) [19:36:56] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/320251 (owner: Ejegg) [19:38:18] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/320252 [19:38:29] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/320252 (owner: Ejegg) [19:39:26] (CR) Ejegg: [V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/320251 (owner: Ejegg) [19:40:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/320252 (owner: Ejegg) [19:42:20] !log updated civicrm from bdc2786ddaf09e9f412f97406e3cffb13fcc96ab to 45a1b9a0e1665b1fc71165e1bc4bcfdca2a9adf7 [19:42:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:49:03] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/320254 [19:49:46] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/320254 (owner: Ejegg) [19:57:02] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/320254 (owner: Ejegg) [19:58:38] !log updated payments-wiki from ed98772ead6365d58356294ddd46bc4312204b1d to c1fa73c649986be89a6a038b9e19f6b3ea19e537 [19:58:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:09:18] (PS1) Ejegg: Fix US 'Postal Code' label [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320262 [20:09:56] ejegg: is riot.im working for you today? [20:13:14] cwd i [20:13:19] 'm getting notifications [20:13:28] lemme see about the site [20:14:21] cwd yep, site seems to be working too [20:14:39] Fundraising-Backlog, fundraising-tech-ops: recurring contribution queue monitoring is broken since overhaul - https://phabricator.wikimedia.org/T149802#2777771 (Jgreen) Open>Resolved This is fixed. [20:14:42] where do we want to do standup today? [20:15:03] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Adyen, Easy, and 4 others: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#2777790 (Ejegg) OK, both halves of this are deployed now. As a bonus, the city/state lookup works from the Civi UI as well, s... [20:15:37] nuts [20:15:53] i made my own "homeserver" so it must be something to do with that [20:16:12] shoot [20:16:36] cwd still need a hangouts dial-in for standup then? [20:17:05] that would be great [20:17:13] there are developments about the internet situation here [20:17:16] both good and bad [20:18:43] Fundraising-Backlog, fundraising-tech-ops: Payments-wiki sessions timing out quickly? - https://phabricator.wikimedia.org/T149139#2777799 (Jgreen) I don't think we're hitting memcache LRU, judging from the stats we collect in ganglia we generally don't come close to the memory limit. However since we hav... [20:22:55] cwd: good, it works, bad, it's expensive? ;/ [20:23:29] Instead of the nature u should've opted for a city of 30 million ;p [20:23:37] verizon is scamming people [20:23:41] arrrrgg that sucks [20:23:42] which should surprise no one [20:23:58] but i have been collecting thorough network statistics and they are reporting our data usage far in excess of what it really is [20:24:01] damn [20:24:06] Fundraising-Backlog, fundraising-tech-ops: Figure out why we can't get information about the causes of deadlocks - https://phabricator.wikimedia.org/T149275#2777811 (Jgreen) a:Jgreen>Eileenmcnaughton >>! In T149275#2766204, @Eileenmcnaughton wrote: > OK - let's wait for the next evidence of a dea... [20:24:13] glad ur on top of it! [20:24:44] well there's nothing i can do about it unfortunately [20:25:00] call the BBB or something [20:25:06] but they are not interested [20:25:14] they meaning verizon [20:25:28] the BBB...i'm guessing they have a large file on verizon [20:25:36] huh [20:25:49] No consumer protection office or something? [20:26:11] Just installed apc locally, mw sure seems faster! [20:27:35] (PS1) Ejegg: WIP rename 'zip' to 'postal' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320267 [20:29:52] fundraising-tech-ops: fix freeradius vs libpam-yubico too many open files bug - https://phabricator.wikimedia.org/T148863#2777836 (Jgreen) p:Triage>Normal [20:29:52] (CR) jenkins-bot: [V: -1] WIP rename 'zip' to 'postal' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320267 (owner: Ejegg) [20:36:12] ejegg: man did this give me a momentary scare https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/offline2civicrm/test_data/engage.csv [20:36:44] and then I remembered adam telling me to put TEST in the name so this data wouldn't scare someone [20:36:51] (CR) Eileen: "I thought I had done it in a way which was compatible with existing variations - but I agree - it is better to clean them up" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319757 (https://phabricator.wikimedia.org/T88460) (owner: Eileen) [20:39:10] sadly it doesn't import anymore [20:42:04] (CR) Eileen: "Right - it does assume the directory would always be temporary::/ - I wanted to keep that fairly locked down as per my commit comment it d" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319758 (https://phabricator.wikimedia.org/T88460) (owner: Eileen) [20:42:48] fundraising-tech-ops: Yubikey for Thea Skaff, fundraising consultant - https://phabricator.wikimedia.org/T149839#2777855 (Jgreen) a:Jgreen [20:43:51] fundraising-tech-ops: Yubikey for Thea Skaff, fundraising consultant - https://phabricator.wikimedia.org/T149839#2764823 (Jgreen) @MeganHernandez_WMF can you approve this access request on this ticket? Thanks! [20:44:01] Fundraising Sprint Unbreaking Now, Fundraising-Analysis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: Contribution report: add column for preferred language - https://phabricator.wikimedia.org/T146942#2675606 (Eileenmcnaughton) a:Eileenmcnaughton [20:44:41] fundraising-tech-ops: Yubikey for Thea Skaff, fundraising consultant - https://phabricator.wikimedia.org/T149839#2777868 (Jgreen) p:Triage>High [20:44:46] cwd heh, whew [20:44:56] how does the import fail? [20:45:19] i think it's a custom group that has changed [20:45:41] hmm, have you run drush updb since updating CRM code? [20:45:43] '\'Unresctricted - General\' is not a valid option for field custom_26 [20:45:50] ah let me try that [20:46:20] cwd: ejegg XenoRyet[m] AndyRussG eileen1 are we on hangouts? [20:46:44] dstrine: i broke my matrix :[ [20:49:51] (PS3) Ejegg: Fix missing timezone / postal code bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320233 (https://phabricator.wikimedia.org/T148578) [20:49:59] dstrine: oops, brt! [20:51:48] (CR) jenkins-bot: [V: -1] Fix missing timezone / postal code bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320233 (https://phabricator.wikimedia.org/T148578) (owner: Ejegg) [20:53:26] (PS4) Ejegg: Fix missing timezone / postal code bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320233 (https://phabricator.wikimedia.org/T148578) [21:06:27] cwd if you fix those errors in the sample data I might need to co-ordinate with you as I need to write a test covering what happens when we get a test import error [21:07:13] eileen1: ah definitely, like the "10 errors and bail" behavior? [21:09:01] cwd - yeah the ticket is about being to download the errors [21:09:04] as a csv [21:09:13] & I should write a unit test for what I have done [21:09:50] ah to get the full error text? yeah i could see that being helpful [21:12:59] Fundraising-Backlog, FR-Paypal: PayPal server error 11/3 - https://phabricator.wikimedia.org/T149902#2778006 (MBeat33) Thanks, @Ejegg I passed this on to Paypal [21:18:22] Fundraising-Backlog: Ingenico audit: donation from 11/1 not in Civi - https://phabricator.wikimedia.org/T150212#2778028 (MBeat33) [21:29:12] ejegg: I think the reason I tried to make the exceptions backward compatible rather than fix all instances was I couldn't decide re throw new WmfException( 'INVALID_RECURRING', $ex->getMessage(), $contribution_recur ); [21:29:47] passing out contribution_recur feels a bit PI-y - but at the same time there isn't much directly associable data in it [21:30:41] I guess the easier thing is to pass that in as a string - ie [21:30:45] k, I guess it just seemed odd to have an argument for the user-readable error message that sometimes held the extra debugging information [21:31:10] Well it could be more like [21:31:19] chatting with nirzar about CSS for a bit - back soon! [21:31:49] 'INVALID_RECURRING', $ex->getMessage(), '', array('recur_contrib' => $contribution_recur)) [21:32:25] yeah, that makes sense [21:34:24] cwd: https://phabricator.wikimedia.org/T149873 [22:05:25] (PS2) Ejegg: WIP rename 'zip' to 'postal' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320267 [22:41:15] Fundraising-Backlog, FR-Paypal: PayPal server error 11/3 - https://phabricator.wikimedia.org/T149902#2778247 (Ejegg) I just checked the logs and made sure we haven't repeated a single order ID all day. In more disturbing news, I seem to get that "We can't send your payment right now" error after signing... [22:53:07] (PS2) Eileen: Alter WMFException to permit us to present a simpler error for users. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/319757 (https://phabricator.wikimedia.org/T88460) [22:58:22] (CR) Eileen: "I figured if I was going to go & fix all the instances where more than 2 parameters were in use I would change the signature to simplify i" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/318360 (https://phabricator.wikimedia.org/T135407) (owner: Ejegg) [23:27:52] Fundraising-Backlog, fundraising-tech-ops: fundraising-drupal log repeats itself - https://phabricator.wikimedia.org/T150221#2778337 (Ejegg) [23:30:15] fr-tech for tonite's CN deploy, I'm just going to cherry-pick the handle banner loader error patch to the deploy branch [23:30:39] sounds good [23:30:45] Then I'd merge all of master into deploy, and put that on the train for this week [23:32:20] respecting the small swat deploy thing, huh? [23:32:22] That way the rest of the stuff (mostly minor, except for strict DB) would go out to prod gradually [23:32:26] yeah also [23:37:04] i'm going to run a quick errand, i'll be back to watch the deploy [23:42:47] little break in the cloudburst, going to bike home [23:52:21] (PS1) AndyRussG: Handle banner loader errors on client [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/320317 (https://phabricator.wikimedia.org/T149107) [23:56:58] (CR) AndyRussG: "recheck" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/320317 (https://phabricator.wikimedia.org/T149107) (owner: AndyRussG) [23:57:59] (CR) AndyRussG: [C: 2] Handle banner loader errors on client [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/320317 (https://phabricator.wikimedia.org/T149107) (owner: AndyRussG)