[00:10:17] fr-tech: update about CN deploy... It turns out that it _did_ go out on the train, I had just checked too early... ;p. Only out to "group 0" wikis today ( MediaWiki.org; test.wikipedia.org; test2.wikipedia.org; test.wikidata.org; zero.wikimedia.org) [00:10:46] cool! [00:10:49] Biggest piece there was the MariaDB strictmode stuff, also a few other cleanup items [00:10:55] yeah! [00:15:21] Having trouble finding any ChoiceData on mediawiki.org [00:15:35] I forget, is that expected when we're not targeting a project? [01:07:24] ejegg|away: ah no, choicedata only comes in if project and language combo are targeted :) [01:09:30] however, we were targeting mw.org at least until recently, IIRC [01:09:32] checking... [01:16:18] ejegg|away: mediawiki.org is all good :) [01:16:41] mw.centralNotice.choiceData haz choiceData [01:17:03] The notice you see at the top about the dev summit is actually not a CN banner tho [01:18:50] To see one, make sure you're logged in... [01:21:29] Then go to https://www.mediawiki.org/wiki/MediaWiki?uselang=en&randomcampaign=0.2 [01:21:46] That should make the banner "display", but in fact in stays hidden unless u have enuf edits [01:22:07] You can see it by saying $( '#wishlist-banner' ).show(); in the console [01:22:29] Yaaay strictmode here we come! [03:24:43] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Square Cash import not working - https://phabricator.wikimedia.org/T150810#2797943 (Eileenmcnaughton) a:Eileenmcnaughton [03:25:12] Fundraising Sprint Value Subtracting, Patch-For-Review, Unplanned-Sprint-Work: Direct Mail Appeal not being reflected correctly in Civi - https://phabricator.wikimedia.org/T150697#2797945 (Eileenmcnaughton) a:Eileenmcnaughton [03:25:51] (PS1) Eileen: Fix regression on Square import due to change in exception. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321836 [03:26:31] (PS1) Eileen: Cache result of query to get custom data extends. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/321837 (https://phabricator.wikimedia.org/T148688) [04:44:53] (PS1) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 [05:06:56] (PS2) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [15:40:44] (PS3) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [15:43:54] (PS4) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [16:23:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edit Civi Grant Deadline reminder email message - https://phabricator.wikimedia.org/T150862#2799464 (CaitVirtue) [16:23:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edit Civi Grant Deadline reminder email message - https://phabricator.wikimedia.org/T150862#2799488 (CaitVirtue) p:Triage>Normal [16:26:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug in link in Civi Reminder emails - https://phabricator.wikimedia.org/T150864#2799497 (CaitVirtue) [16:27:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug in link in Civi Reminder emails - https://phabricator.wikimedia.org/T150864#2799509 (CaitVirtue) p:Triage>Normal [16:47:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug in link in Civi Reminder emails - https://phabricator.wikimedia.org/T150864#2799590 (DStrine) note: I have seen gmail mess up email links like this before. We may want to test this in other email clients. If it is gmail specific, we should change th... [17:50:11] (PS2) Ejegg: Fix regression on Square import due to change in exception. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321836 (owner: Eileen) [17:50:21] (CR) Ejegg: [C: 2] Fix regression on Square import due to change in exception. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321836 (owner: Eileen) [17:53:47] cwd is that retry patch ready for review? [17:54:45] sure! [17:55:26] if it fixes most of them maybe we should go back to throwing an exception when it fails [17:55:35] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/321904 [17:55:39] (Merged) jenkins-bot: Fix regression on Square import due to change in exception. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321836 (owner: Eileen) [17:56:00] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/321904 (owner: Ejegg) [17:57:31] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/321904 (owner: Ejegg) [17:57:34] (CR) Ejegg: [C: -1] "Let's only retry on unexpected responses, not on 'INVALID'" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) (owner: Cdentinger) [18:00:38] fr-tech: He who laughs last is probably your boss. [18:00:38] -- discuss. [18:01:00] !log updated fundraising tool from d14d47a83bd822d28da0f2d03afbd74008e215a1 to 4f54cd815cf9627265c4d004f51c8caffa97be49 [18:01:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:07:26] (PS5) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [18:07:50] fr-tech I'm in the hangout if anyone wants to -talk [18:08:39] sure, be there ina couple minutes [18:09:37] ejegg: coming! [18:21:35] no sooner do i log in to google than it logs me out again [18:21:51] happened 3 times in a row so far [18:28:22] scrum of scrums is coming up in a few minutes - any news? [18:51:36] paypal's tech support emails get flagged as phishing by gmail [18:57:56] cwd haha, oh man [18:57:56] oooh that doesn't sound good [18:58:43] I'm going to deploy some CRM updates [19:04:10] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/321914 [19:04:13] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/321914 (owner: Ejegg) [19:04:49] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/321914 (owner: Ejegg) [19:07:09] !log updated CiviCRM from df50d2d7b6a8494fb3e049df6b1e101611270528 to 5bdf00b55fdc6197ea1898054e3832d89989d261 [19:07:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:13:48] (PS6) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [19:14:29] ejegg: ^ apologies for the yak shaving, i just can't bear to say "catch { // do nothing }" [19:14:40] i refactored a but to avoid it [19:14:47] *bit [19:14:47] heh, ok [19:15:45] ah, pushed the loop into the API wrapper. Makes sense, dealing with bustedness should be encapsulated too [19:16:43] yeah i hope it's more sensible this way [19:26:25] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Zero at the beginning of zip code not being reflected upon import - https://phabricator.wikimedia.org/T148056#2713567 (Ejegg) @LeanneS : @Eileenmcnaughton also fixed this one. She discovere... [19:30:52] (CR) Ejegg: "I wholeheartedly approve of encapsulating the busted-server handling in the PaymentsAPI class. The recursive implementation of the retry l" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) (owner: Cdentinger) [19:32:22] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 4 others: CentralNotice: Relay banner loading issues in beacon/impression - https://phabricator.wikimedia.org/T149107#2800331 (AndyRussG) Sadly, this isn't w... [19:33:11] ejegg: I'll close the MariaDB strictmode task, eh? [19:33:20] yay! [19:33:29] \o/ [19:33:58] And... I put T149107 back in "Doing" (see comment there...) [19:33:59] T149107: CentralNotice: Relay banner loading issues in beacon/impression - https://phabricator.wikimedia.org/T149107 [19:56:46] (PS7) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [19:59:03] ejegg: used the for loop instead of the recursion ^ [19:59:25] thanks! [20:03:15] (CR) Ejegg: "Thanks for the loop! Just got an undefined instance variable in the exception message." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) (owner: Cdentinger) [20:13:57] (CR) Ejegg: [C: 2] "Looks good, works locally with a bunch of different merge conditions." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/321533 (https://phabricator.wikimedia.org/T146941) (owner: Eileen) [20:14:34] (CR) Ejegg: [C: 2] "Thanks! Looking forward to re-running those import tests." (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/321837 (https://phabricator.wikimedia.org/T148688) (owner: Eileen) [20:18:32] (PS8) Cdentinger: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) [20:18:38] (Merged) jenkins-bot: Allow selection of primary when merging. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/321533 (https://phabricator.wikimedia.org/T146941) (owner: Eileen) [20:18:58] (PS3) Ejegg: Comment to explain salt-wierdness [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321571 (https://phabricator.wikimedia.org/T15038) (owner: Eileen) [20:19:04] (CR) Ejegg: [C: 2] Comment to explain salt-wierdness [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321571 (https://phabricator.wikimedia.org/T15038) (owner: Eileen) [20:19:08] (Merged) jenkins-bot: Cache result of query to get custom data extends. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/321837 (https://phabricator.wikimedia.org/T148688) (owner: Eileen) [20:22:14] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321928 [20:23:05] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321928 (owner: Ejegg) [20:23:13] (Merged) jenkins-bot: Comment to explain salt-wierdness [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321571 (https://phabricator.wikimedia.org/T15038) (owner: Eileen) [20:26:18] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321931 [20:26:46] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321928 (owner: Ejegg) [20:32:49] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) (owner: Cdentinger) [20:34:25] (Merged) jenkins-bot: Try to validate IPN message 7 times. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/321839 (https://phabricator.wikimedia.org/T150780) (owner: Cdentinger) [20:48:06] AndyRussG: meeting? [21:14:25] off to find an outlet [21:27:48] Fundraising-Backlog, FR-2016-17-Q2-Bugs: Ingenico audit: donation from 11/1 not in Civi - https://phabricator.wikimedia.org/T150212#2800644 (MBeat33) Possibly related? Transaction 5258980243 has an email address associated at the Ingenico console, but the donation in Civi does not have an email address c... [21:30:19] (CR) TheDJ: "i think you might have had the wrong bug number on that commit..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321571 (https://phabricator.wikimedia.org/T15038) (owner: Eileen) [21:40:29] (PS1) Cdentinger: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/321954 [21:42:05] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/321954 (owner: Cdentinger) [21:43:25] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/321954 (owner: Cdentinger) [21:45:50] !log updated payments listeners from a0ae95edd001d51d0cff5c080d0372c14efcf9a9 to cac1a196b0e4805ff38671364228a89f8d053c5c [21:46:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:26:21] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321996 [22:26:24] (PS1) Ejegg: DRY up some message date code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321997 [22:26:55] (CR) Ejegg: [C: 2] Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321996 (owner: Ejegg) [22:27:51] (Abandoned) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321931 (owner: Ejegg) [22:30:02] (Merged) jenkins-bot: Update SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321996 (owner: Ejegg) [22:30:12] Fundraising Sprint Value Subtracting, Patch-For-Review, Unplanned-Sprint-Work: Direct Mail Appeal not being reflected correctly in Civi - https://phabricator.wikimedia.org/T150697#2793769 (Ejegg) Hi @RLewis . @Eileenmcnaughton's fix to stop creating extra option values is up in production now. Want t... [22:36:01] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/322002 [22:36:11] (CR) Ejegg: [C: 2] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/322002 (owner: Ejegg) [22:40:13] (CR) jenkins-bot: [V: -1] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/322002 (owner: Ejegg) [22:40:57] (CR) Ejegg: [V: 2] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/322002 (owner: Ejegg) [22:41:15] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/322003 [22:42:02] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/322003 (owner: Ejegg) [22:42:09] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/322003 (owner: Ejegg) [22:47:41] !log updated CiviCRM from 5bdf00b55fdc6197ea1898054e3832d89989d261 to 27a9a2d0c2b081dac82cfea76ce579e6d66c0876 [22:48:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:51:45] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Option to specify primary address on merge - https://phabricator.wikimedia.org/T146941#2675580 (Ejegg) Open>Resolved [23:07:10] I'm going t relocate but I'll be online shortly [23:10:06] (PS2) Ejegg: WIP Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) [23:24:14] (PS3) Ejegg: WIP Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) [23:24:16] (PS1) Ejegg: Get rid of some unused CSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322011 [23:35:35] (PS4) Ejegg: WIP Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) [23:42:27] Fundraising Sprint Value Subtracting, Fundraising-Backlog, FR-Paypal, Patch-For-Review, Unplanned-Sprint-Work: Make PayPal IPN verification retry a few times - https://phabricator.wikimedia.org/T150780#2801076 (cwdent) Open>Resolved Well the errors conveniently stopped happening but i... [23:47:33] (PS5) Ejegg: WIP Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249)