[00:46:57] (PS1) Ejegg: closeOrderReference errors don't blow up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322027 (https://phabricator.wikimedia.org/T150770) [00:48:35] (PS4) Ejegg: DRY finding OrderReferenceId, get_class() -> instanceOf [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/320833 (https://phabricator.wikimedia.org/T147973) [00:49:06] (PS2) Ejegg: closeOrderReference errors don't blow up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322027 (https://phabricator.wikimedia.org/T150770) [17:07:51] !log increased paypal job runner message limit to 5000 [17:08:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:15:27] (PS1) Ejegg: Drop bad banner history entries w/o failmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/322130 (https://phabricator.wikimedia.org/T146063) [17:36:39] XenoRyet: have you had a chance to look at the Amazon order ID reconstruction patch? [17:36:53] I see we got another failmail about Amazon IDs this morning [17:38:06] our deployment runway is getting short [17:41:30] A bit, yea. I'll finish up CRing that in a minute here. [17:43:40] thanks! [17:50:56] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage creating a trxn_id based on row id - which is unreliable - improve salt - https://phabricator.wikimedia.org/T150389#2784316 (Ejegg) Eileen's decided this doesn't actually need to change now, and added a c... [17:51:11] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage creating a trxn_id based on row id - which is unreliable - improve salt - https://phabricator.wikimedia.org/T150389#2803069 (Ejegg) Open>declined [18:00:38] fr-tech: The test of a first-rate intelligence is the ability to hold two opposed [18:00:38] ideas in the mind at the same time and still retain the ability to function. [18:00:39] -- F. Scott Fitzgerald [18:00:39] -- discuss. [18:12:48] (PS1) Ejegg: More unused CSS cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322135 (https://phabricator.wikimedia.org/T149249) [18:42:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Campaign-Support: Periodically run Civi contact import performance tests, note trends - https://phabricator.wikimedia.org/T146338#2803313 (Ejegg) We just had another informal test due to an artificially low paypal job runner limit. Wh... [19:01:02] thank you though! [19:12:06] (PS5) Ejegg: Fix Amazon order IDs for manual captures [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/320710 (https://phabricator.wikimedia.org/T147973) [19:24:02] (CR) XenoRyet: [C: 2] DRY finding OrderReferenceId, get_class() -> instanceOf [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/320833 (https://phabricator.wikimedia.org/T147973) (owner: Ejegg) [19:24:34] (CR) XenoRyet: [C: 2] Fix Amazon order IDs for manual captures [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/320710 (https://phabricator.wikimedia.org/T147973) (owner: Ejegg) [19:24:45] (CR) XenoRyet: [C: 2] closeOrderReference errors don't blow up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322027 (https://phabricator.wikimedia.org/T150770) (owner: Ejegg) [19:25:02] (Merged) jenkins-bot: DRY finding OrderReferenceId, get_class() -> instanceOf [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/320833 (https://phabricator.wikimedia.org/T147973) (owner: Ejegg) [19:26:12] (Merged) jenkins-bot: Fix Amazon order IDs for manual captures [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/320710 (https://phabricator.wikimedia.org/T147973) (owner: Ejegg) [19:26:18] cool, thanks for the CR! [19:26:25] I'll deploy that stuff in a sec [19:26:32] No worries [19:26:54] Plenty more patches if you're up for more! [19:27:20] (Merged) jenkins-bot: closeOrderReference errors don't blow up [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322027 (https://phabricator.wikimedia.org/T150770) (owner: Ejegg) [19:27:20] Sure, point me in the right direction. [19:27:42] Where'd you and cwd end up on the Adyen ones? I saw you guys were going back and forth on that. [19:28:09] I guess he's still hoping to find a way to prevent those things in the first place [19:28:48] but we're confused because we never see multiple log entries saying 'redirecting for transaction X' [19:29:11] even when Adyen says they definitely got multiple posts with the same order ID [19:29:35] Hmm... that's really weird. [19:29:38] here's some simple CSS cleanup to prep for the mobile fixes: https://gerrit.wikimedia.org/r/322011 [19:29:59] -211 lines. Nice. [19:30:22] and here's a thing to stop sending failmail on bad banner history entries: https://gerrit.wikimedia.org/r/322130 [19:30:27] Looking. Stack up any more little ones if you got 'em and I'll look at those too. [19:30:39] Another pretty trivial code reduction: https://gerrit.wikimedia.org/r/321997 [19:31:17] Getting rid of an unused global: https://gerrit.wikimedia.org/r/317549 [19:33:44] (CR) XenoRyet: [C: 2] Get rid of some unused CSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322011 (owner: Ejegg) [19:34:23] Here's a change to the default error message in DonationInterface: https://gerrit.wikimedia.org/r/316709 . But I think we need to deploy that along with the patches to show more specific error messages on errors where you can try again [19:34:49] To mitigate the flood of email to DS [19:35:17] Yea, that'd be nice for them. [19:37:59] (CR) XenoRyet: [C: 2] Drop bad banner history entries w/o failmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/322130 (https://phabricator.wikimedia.org/T146063) (owner: Ejegg) [19:41:47] (Merged) jenkins-bot: Get rid of some unused CSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322011 (owner: Ejegg) [19:41:49] (Merged) jenkins-bot: Drop bad banner history entries w/o failmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/322130 (https://phabricator.wikimedia.org/T146063) (owner: Ejegg) [19:55:11] (CR) XenoRyet: [C: 2] DRY up some message date code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321997 (owner: Ejegg) [19:58:37] !log extended session timeouts on payments-wiki [19:58:39] (Merged) jenkins-bot: DRY up some message date code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/321997 (owner: Ejegg) [19:58:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:08:39] XenoRyet: there's also this paypal audit patch: https://gerrit.wikimedia.org/r/320938 [20:08:50] 10-4 [20:48:33] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 8 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2803827 (Ejeg... [20:55:08] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 3 others: Missing ct_id on fredge messages from orphan rectifier - https://phabricator.wikimedia.org/T147873#2803844 (Ejegg) This hasn't recurred for weeks.... [20:55:32] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 3 others: Missing ct_id on fredge messages from orphan rectifier - https://phabricator.wikimedia.org/T147873#2706582 (Ejegg) Open>Resolved [20:55:50] Fundraising Sprint Value Subtracting, Fundraising-Analysis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Unnecessary queries on api calls - https://phabricator.wikimedia.org/T148688#2803848 (Ejegg) Open>Resolved [21:31:04] ejegg|food: 0/ got a min? [21:43:33] hi nzr! [21:44:17] ejegg|food: how do i test the css? any url? [21:44:29] i dont have a mediawiki instance running [21:46:31] nzr you can just swap in the new gateway.css and forms.css files in that demo you were using, right? [21:46:46] ejegg|food: okay i can do that [21:46:53] cool! [21:47:05] i will reply with screenshots so everyone can see [21:56:51] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322196 [21:57:02] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322196 (owner: Ejegg) [21:57:44] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322196 (owner: Ejegg) [22:02:31] !log updated SmashPig from cac1a196b0e4805ff38671364228a89f8d053c5c to 1e895ba4468ac5a2e0812dd5719fd42eb2ec6515 [22:02:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:10:40] (PS1) Ejegg: Fix check for Amazon-generated IDs [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322203 (https://phabricator.wikimedia.org/T147973) [22:10:50] XenoRyet: mind reviewing that one? ^^^ [22:11:04] Not at all. [22:11:09] We're unnecessarily burning API calls due to a botched equality check in the parent patch [22:13:19] The not out front isn't just taking the negation of that whole deal? [22:13:43] Is it trying to do a not of the substring call or something? [22:15:21] (CR) XenoRyet: [C: 2] Fix check for Amazon-generated IDs [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322203 (https://phabricator.wikimedia.org/T147973) (owner: Ejegg) [22:16:42] (Merged) jenkins-bot: Fix check for Amazon-generated IDs [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/322203 (https://phabricator.wikimedia.org/T147973) (owner: Ejegg) [22:21:21] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322205 [22:21:40] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322205 (owner: Ejegg) [22:22:12] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322205 (owner: Ejegg) [22:24:28] !log updated SmashPig from 1e895ba4468ac5a2e0812dd5719fd42eb2ec6515 to 3cbb42fb7138e780bd76a2f17c48983f8f882c57 [22:24:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:24:50] XenoRyet: yeah, I think it was just negating the string [22:25:12] which would always yield false [22:25:22] Yea. [22:25:43] cool, that seemed to fix it though [22:25:51] Good times. [22:26:37] Fundraising Sprint Value Subtracting, Fundraising-Backlog, FR-Amazon, FR-Smashpig, and 2 others: Amazon: SSL errors on closeOrderReference API call - https://phabricator.wikimedia.org/T150770#2795925 (Ejegg) Open>Resolved [22:28:47] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 3 others: Amazon donation order ids are useless when generated by processor - https://phabricator.wikimedia.org/T147973#2804189 (Ejegg) Open>Resolved [22:29:28] XenoRyet: did you have any questions on the paypal audit refund check? [22:30:16] Haven't quite started on that one yet, got distracted by some other stuff. [22:30:22] I'll dig in and let you know. [22:30:47] cool. i'd like to re-run a bunch of old paypal audit files [22:33:20] Fundraising Sprint Value Subtracting, Fundraising-Backlog, FR-Paypal, Unplanned-Sprint-Work: Paypal audit parser sends duplicate messages - https://phabricator.wikimedia.org/T150998#2804200 (Ejegg) [22:34:11] (PS4) Ejegg: Paypal audit: fix checking for refunds in CiviCRM [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320938 (https://phabricator.wikimedia.org/T150998) [22:34:38] (CR) jenkins-bot: [V: -1] Paypal audit: fix checking for refunds in CiviCRM [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320938 (https://phabricator.wikimedia.org/T150998) (owner: Ejegg) [22:35:30] hmm? [22:35:41] I only changed the commit message... [22:36:18] huh, python lint got more strict [22:37:40] (PS1) Ejegg: Fix spacing [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322210 [22:38:42] (PS5) Ejegg: Paypal audit: fix checking for refunds in CiviCRM [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320938 (https://phabricator.wikimedia.org/T150998) [22:39:04] (CR) Ejegg: [C: 2] "Self-merging WS-only commit" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322210 (owner: Ejegg) [22:39:36] (Merged) jenkins-bot: Fix spacing [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322210 (owner: Ejegg) [22:40:22] k, that's better [22:45:57] (CR) XenoRyet: [C: 2] Paypal audit: fix checking for refunds in CiviCRM [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320938 (https://phabricator.wikimedia.org/T150998) (owner: Ejegg) [22:46:25] (Merged) jenkins-bot: Paypal audit: fix checking for refunds in CiviCRM [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/320938 (https://phabricator.wikimedia.org/T150998) (owner: Ejegg) [22:46:32] thanks XenoRyet [22:46:40] No worries [22:47:26] If you want to take over that error messaging thing, please go ahead. I can offer some orientation [22:48:40] Still had a few of those little patches from earlier to CR, but after that yea, I'll probably dig in there. [22:49:53] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-Logging, and 2 others: Some wmf_civicrm exceptions should be logged at info and not error - https://phabricator.wikimedia.org/T146063#2649382 (Ejegg) DUPLICATE_CONTRIBUTION seems to be sinking bene... [22:50:00] rockin! [23:00:30] Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add field to Silverpop export: highest_native_amount - https://phabricator.wikimedia.org/T135407#2804269 (Ejegg) This added 12 minutes to the total e... [23:04:36] (PS1) Ejegg: Fix query snippet logging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322215 [23:05:45] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/322216 [23:05:54] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/322216 (owner: Ejegg) [23:07:56] here's another little one that could use CR - just a logging fix: https://gerrit.wikimedia.org/r/322215 [23:08:47] (CR) jenkins-bot: [V: -1] Fix query snippet logging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322215 (owner: Ejegg) [23:10:22] (PS2) Ejegg: Fix query snippet logging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322215 [23:10:37] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/322216 (owner: Ejegg) [23:13:39] (PS1) Ejegg: Fix width of timezone column [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/322218 [23:25:00] gotta relocate to an outlet [23:43:45] XenoRyet: and ejegg I just noticed some funky failmail over the last 20 minutes. looks like smashpig and queue stuff? [23:44:16] dstrine: oh, I just re-ran a whole bunch of paypal audit files, let me see if that caused it [23:46:28] was just making sure there were no other missing trxns in the same category as that one missing large donation [23:47:16] ok [23:50:06] (CR) XenoRyet: [C: 2] Remove unused MinfraudActionRanges global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/317549 (owner: Ejegg) [23:51:27] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 9 others: [Epic] Do not show donation form error message: "No processors available". Fix... - https://phabricator.wikimedia.org/T117872#2804512 [23:51:55] (Merged) jenkins-bot: Remove unused MinfraudActionRanges global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/317549 (owner: Ejegg)