[00:00:54] I don't think my patch did anything [00:03:26] ejegg: I see that the Amazon listener sends some kind of completion message, which is discarded as a duplicate contribution. [00:03:37] Is that supposed to fill in a gap if the frontend message never arrives? [00:03:48] awight: right [00:03:59] it's a bit redundant [00:04:06] I ask cos it's got no contact information, so I'm wondering what good it does [00:04:28] yeah, it uses the pending db entry if that still exists [00:04:41] aah right completion_message_id then? [00:04:49] yeah, that silly thing [00:04:56] awesome, thanks for explaining [00:05:11] heh, guess i need more comments somewhere! [00:05:58] naw I just needed a refresher [00:14:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit, MediaWiki-extensions-DonationInterface, Epic: [Epic] Report gateway status when available - https://phabricator.wikimedia.org/T151274#2812842 (awight) [00:14:53] awight: do you think ^ is a way to track donor status? [00:15:38] cwd: It would be helpful to donor services, at least. What u mean by donor status? [00:16:44] well ejegg has had this idea about having a general way to record where someone is at in the process [00:17:01] it seems like it would provide tooling to solve a lot of bugs [00:17:02] I think it was awight's idea first [00:17:10] the payment state log table [00:17:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit, MediaWiki-extensions-DonationInterface, Epic: [Epic] Report gateway status when available - https://phabricator.wikimedia.org/T151274#2812867 (awight) Turns out we don't do this well at the moment. Also, the "response" field c... [00:17:22] as opposed to a single row in payments_init [00:17:31] ah ok, well seems like a useful thing for sure [00:17:52] maybe starting off just parsing a string is ok until we see what the use cases are an if further abstraction is necessary [00:20:09] another table with multiple rows per donation attempt might get _huge_ [00:21:35] cwd awight's current patch is just about the status code that we get back from a processor api call [00:22:33] it seems to be woefully incomplete [00:22:44] cos we don't send that status from nearly anywhere [00:24:44] Hey - looks like dedupe jobs are off - do we need them off at this stage? I feel like we can keep them going until the campaign really starts? [00:25:06] fr-tech: ^ good question! [00:25:26] I think there were some concerns about performance: https://hangouts.google.com/hangouts/_/wikimedia.org/fr-tech-talk [00:25:50] but I believe the consensus was, we'd try fiddling with microoptimizations and leave the dedupe running [00:26:09] ok - I've turned them back on for now [00:26:16] today we were getting donations/sec pretty comparable to big english [00:26:18] thanks! [00:26:19] ~2/sec [00:26:19] ooh [00:26:22] I agree the main one will need to be off for a period [00:26:39] we should... add that to the launch day plan somehow [00:26:59] eileen1: what if civi's read db was a copy and we only ran dedupe on that? [00:27:00] (PS1) Ejegg: Set viewport meta tag on forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322803 (https://phabricator.wikimedia.org/T149249) [00:27:25] (and decoupled the dedupe finder from the merger) [00:28:45] if we did that i suppose we wouldn't have to change how civi works [00:28:54] hmm not sure I'm following [00:29:00] just have a totally separate db that the finder runs on, and a job on the main db that is the merger [00:29:06] if those things can be decoupled [00:29:20] if the read db was separate then the db major gifts edits would not be deduped [00:29:22] There's no harm putting that viewport tag on desktop sites, is there? It looks fine in ff & chromium [00:30:03] eileen1: wouldn't their edits go to the write db? [00:30:11] The finder part of the dedupe does not seem to be causing problems - it seems to be the merger part but I can dig further into why [00:30:34] cwd yeah - but they want to be working with & editing deduped contacts so I'm not getting how it helps [00:31:03] eileen1: oh, it's the merge part giving us db problems? [00:31:14] I'd been assuming it was the searches [00:31:21] eileen1: ah good point [00:31:30] no - from what I can tell it's not the searches [00:31:31] i guess it makes more sense that the write would cause the lock problems [00:32:19] yeah trying to write to the same table [00:32:30] one big area I have seen is inserting into the civicrm_cache table [00:32:40] * awight facepalms [00:32:44] eileen1: sorry, major gifts dedupe == people manually deduping? [00:32:47] my theory on that is that if we removed the autoincrement id field those locks would ease up [00:33:08] cwd so we do automated deduping for mg & they do manual [00:33:40] one thing we can do is schedule a regular clearing of the caches - there is a scheduled job for that [00:35:12] i know nothing about civicrm_cache but i bet it's complicated [00:35:36] what does it cache? [00:36:22] all sorts! [00:36:47] (PS8) Ejegg: Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) [00:36:47] but regarding the id [00:36:53] my thinking is [00:37:19] 1) a lot of the locks seem to be on insert - based on locking the autoincrement key [00:37:39] what that means is that the ids above the last id need to be locked until the insert is completed [00:37:44] (CR) Ejegg: "Note: seems to need the 'viewport' meta tag added. See I8d77df6fa28." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [00:38:00] but, if the key was based on other fields instead it would not need to lock an unknown space [00:38:20] & hence 2 inserts could happen at once if the indexes did not conflict [00:39:18] eileen1: that makes sense. i imagine cache gets are not based on primary key anyway? [00:39:26] (PS9) Ejegg: Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) [00:39:58] no - well they shouldn't be - I trialled that idea on the group contact cache on a test site & it only hurt one code place that I could observe [00:43:15] (CR) Ejegg: "Drat, I just realized we can't deploy this without a settings change. We're pointing that connection string at a read-only db" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/313042 (owner: Ejegg) [00:44:07] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/322805 [00:44:12] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/322805 (owner: Ejegg) [00:44:17] ejegg: nuts, my bad for merging that :( [00:44:45] no worries, I should have flagged it [00:45:14] is that a jgreen settings change? [00:45:19] yep [00:46:18] * awight rattles cage [00:50:52] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/322805 (owner: Ejegg) [00:54:47] !log updated fundraising tools from 4f54cd815cf9627265c4d004f51c8caffa97be49 to da8092927b1eb3af0cc98c797411bdd857ece3f1 [00:55:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:57:54] wat.

The requested URL /changes/ was not found on this server.

[00:58:24] I see no changes. All I see is racist faces. [01:00:08] hrm? [01:01:16] git review -d gave up on me... [01:01:23] I was gonna try your css cleanup locally [01:02:09] git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/DonationInterface refs/changes/35/322135/1 && git checkout FETCH_HEAD [01:02:12] bah [01:02:29] d'oh! [01:02:54] battery dying, gotta skedaddle. I'll be back later! [01:06:50] awight: gotta be ssh [01:07:26] (CR) Awight: [C: 2] "Looks right and works. One question inline about td.label, though." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322135 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [01:11:15] cwd: I have gerrit ssh://user@gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface.git (push) [01:14:59] look right to me, as long as user=awight [01:15:19] yah. hrm maybe I won't be able to use git-review :D [01:34:01] (PS2) Ejegg: More unused CSS cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322135 (https://phabricator.wikimedia.org/T149249) [02:00:25] (PS1) Ejegg: Merge commit 'fdd8342' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322810 [02:00:41] (CR) Ejegg: [C: 2] Merge commit 'fdd8342' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322810 (owner: Ejegg) [02:01:38] (Merged) jenkins-bot: Merge commit 'fdd8342' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/322810 (owner: Ejegg) [02:05:49] !log updated SmashPig from 3cbb42fb7138e780bd76a2f17c48983f8f882c57 to 36be698face889cef0be54d9388259e5617e0987 [02:06:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:25:27] (PS1) Eileen: Upgrade to Drupal 7.52 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/322822 [04:25:29] (PS1) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/322823 [04:27:30] (CR) jenkins-bot: [V: -1] Upgrade to Drupal 7.52 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/322822 (owner: Eileen) [14:54:40] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Ingenico, Patch-For-Review, WMF-deploy-2016-11-08_(1.29.0-wmf.2): Show contribution tracking ID in Ingenico error messages as full 'External Reference #' - https://phabricator.wikimedia.org/T149137#2814338 (MBeat33) @ejegg, this looks... [15:43:45] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Patch-For-Review: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2814594 (Pcoombe) Is there a particular reason to only apply these changes below a certain screen width? I think most of them would make sense on deskto... [16:28:53] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Ingenico, Patch-For-Review, WMF-deploy-2016-11-08_(1.29.0-wmf.2): Show contribution tracking ID in Ingenico error messages as full 'External Reference #' - https://phabricator.wikimedia.org/T149137#2814727 (Ejegg) These two were ones... [17:05:34] kaldari: fyi a "defender of spiders" is currently being interviewed on KALX [17:05:37] unusual [17:06:42] wha? I wanna hear [17:06:59] http://icecast.media.berkeley.edu:8000/kalx-128.mp3.m3u [17:12:14] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Patch-For-Review: Mobile web form style fixes - https://phabricator.wikimedia.org/T149249#2746547 (cwdent) @Pcoombe - I agree that it's generally a better look, my only concerns are: - some header data appears to be missing on the mobile in... [17:53:58] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 2 others: Spike: Central Notice: Consider options for monitoring versions of banners shown - https://phabricator.wikimedia.org/T148593#2727179 (awight) Speci... [17:57:31] fr-tech: something we should be aware of, https://phabricator.wikimedia.org/T150545 [17:58:40] awight: u think it could affect us? [18:00:02] fr-tech: Your boss climbed the corporate ladder, wrong by wrong. [18:00:03] -- discuss. [18:01:06] AndyRussG: we might want to add our use cases [18:05:32] awight: isn't this about different web logs than ours? [18:06:01] cwd: We've used the webrequest table a few times... [18:06:34] but yeah the proposal oddly suggests that we hash the webrequest IPs yet continue sending raw IPs in the kafka streams [18:26:28] cwd: back [18:52:22] (CR) Cdentinger: [C: 2] "Looks really nice!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [18:54:16] (Merged) jenkins-bot: Nirzar's mobile css fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320941 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [18:54:23] (Merged) jenkins-bot: More unused CSS cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322135 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [18:59:43] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Ingenico, Patch-For-Review, WMF-deploy-2016-11-08_(1.29.0-wmf.2): Show contribution tracking ID in Ingenico error messages as full 'External Reference #' - https://phabricator.wikimedia.org/T149137#2815348 (DStrine) Resolved>Op... [18:59:56] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322945 [19:03:19] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Unplanned-Sprint-Work: Donation form email address validation: enable @y7mail.com domain - https://phabricator.wikimedia.org/T151157#2809181 (awight) @MBeat33 That domain seems to be vanishingly rare, at < 300 users per month: http://au.urlm... [19:10:17] cwd: I think we need the 'viewport' patch too [19:10:44] https://gerrit.wikimedia.org/r/322803 [19:11:44] without that, the css changes made things worse in the one actual mobile test I was able to make work [19:14:13] ooh, what does that change? [19:14:19] sorry i'm css challenged [19:14:32] (CR) Awight: [C: 2] Set viewport meta tag on forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322803 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [19:15:31] thanks awight ! [19:15:59] cwd I'm not sure of all the details, but it's recommended for mobile in all sorts of places [19:16:19] good enough for me! [19:16:49] (Merged) jenkins-bot: Set viewport meta tag on forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322803 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [19:16:56] without it the fonts were inconsistent and there was a horizontal scrollbar, but copying the values from minerva made it all hunky dory [19:18:14] woohoo! want to go ahead with the deploy? I could, otherwise [19:23:37] (Abandoned) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322945 (owner: Cdentinger) [19:30:12] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322949 [19:32:44] (PS1) Cdentinger: Update donationinterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322951 [19:33:22] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Unplanned-Sprint-Work: Donation form email address validation: enable @y7mail.com domain - https://phabricator.wikimedia.org/T151157#2815591 (MBeat33) @awight At first test, this prevented going further with the form, but the new X button to... [19:41:05] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322949 (owner: Cdentinger) [19:43:09] (CR) Cdentinger: [C: 2] Update donationinterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322951 (owner: Cdentinger) [19:43:51] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322949 (owner: Cdentinger) [19:46:39] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Bugs: Engage import failing to import certain significant fields - https://phabricator.wikimedia.org/T146295#2815642 (CCogdill_WMF) Hey @awight... sure, adding utm fields to matching gifts woul... [19:51:20] (Merged) jenkins-bot: Update donationinterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322951 (owner: Cdentinger) [19:58:24] !log updated payments wiki from ac14126ab3a4913f987e47190e636da9fe664d9f to 84b035ed72b9e3deb0089023777c400f514a6de5 [19:58:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:25:56] (PS1) Cdentinger: s/max-device-width/max-width/ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322957 [20:27:33] fr-tech: anyone for a semi urgent css fix? ^ [20:27:36] y [20:27:55] If we use max-width in the iframe CSS, that always applies it [20:27:57] because the iframe viewport is narrow [20:27:59] (CR) Awight: [C: 2] s/max-device-width/max-width/ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322957 (owner: Cdentinger) [20:28:05] maybe both max-device-width? [20:28:54] is that even an attribute? [20:29:08] I've seen that the -device- thing is deprecated, but it seemed to be the only way I could get the desktop css in the iframe [20:29:16] http://stackoverflow.com/questions/6747242/what-is-the-difference-between-max-device-width-and-max-width-for-mobile-web#6747471 [20:29:25] >5 years ago [20:29:27] nm [20:29:50] (Merged) jenkins-bot: s/max-device-width/max-width/ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322957 (owner: Cdentinger) [20:29:54] oops yeah it does exist [20:30:54] SO makes it sound like this would only affect browsers that were not maximized [20:31:03] i don't really get what that means on mobile [20:31:17] oh but i see how that would cause it to not target my half width desktop browser [20:33:19] so, if we do want it consistent, I guess we need to use -device- for both to keep the same width in a narrow desktop window? [20:36:21] For the iframe, max-width is always gonna be < 981px, innit? That does seem like a problem. [20:36:26] Sorry for the hasty review! [20:37:17] well, it seems like this block would never target desktops with horizontal resolution > 981px [20:37:19] oic, private channel [20:37:34] cwd: I think max-width would refer to the display area of the *iframe* though [20:38:39] fwiw http://www.javascriptkit.com/dhtmltutors/cssmediaqueries2.shtml [20:38:52] width:95% works to fix the images [20:39:29] awight: wouldn't that mean the targeting was all wrong? [20:39:35] it seems to work [20:40:13] no i think the targeting was correct with max-device-width [20:40:31] and max-width will cause the css to be applied to desktop [20:40:31] oh gotcha [20:40:37] yeah [20:42:18] i see another reference to it in the mustache stylesheet [20:43:33] ejegg: #cards li label img { width:60%; } [20:43:53] nzr 90% or even 95% looked pretty good [20:44:03] still a bit of WS on both sides, but big and clear [20:44:12] at least in the chromium mobile simulator [20:44:34] i checked on phone. i think we shouldn't go above 70% [20:44:54] need enough padding around. plus smaller phones, it's safe to have that padding [20:45:25] (PS1) Cdentinger: s/max-width/max-device-width/g [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322962 [20:45:52] sorry for flail [20:46:06] cwd: What do you think about the non-iframe stuff, though? [20:46:23] Maybe we do want to respond to the viewport size rather than device type? [20:46:52] damn, I'm still seeing some old CSS on prod. [20:47:12] hmmm, awight yeah you are probably right [20:47:21] not sure where it's coming from, but there's some #cards img selector that doesn't exist in the code any more [20:47:41] ejegg: What URL? [20:47:54] cwd / awight the problem with that mismatch between iframe and outer is the background color [20:48:02] awight: https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&payment_method=cc&recurring=&uselang=en&language=en¤cy_code=USD&amount=10&country=US [20:48:31] ejegg: we do have #cards in aa6dc17d340e381a7e1fd9a721df9034c7fffee6 [20:48:50] css url: https://payments.wikimedia.org/load.php?debug=false&lang=en&modules=site&only=styles&skin=vector [20:48:52] like you said, just a selector in the CSS though [20:48:57] but no #cards img [20:49:08] argh now i'm confused again [20:49:25] won't max-device-width make it *not* target my desktop? [20:49:28] ejegg: wait we totally have #cards img in modules/css/gateway.css [20:49:38] cwd: yes [20:50:03] isn't that the problem now, that it's not targeting desktop? [20:50:07] cwd: my unsubstantiated thought was, we might want max-device-width on the iframe css, but max-width on other css [20:50:44] cwd: the problem with what I merged earlier is that it will (probably) always show mobile css on desktop in the iframe [20:50:47] awight: that's unfortunately the case now, and is making the iframe fields nearly invisible on narrow desktop [20:51:04] the-wub showed this: https://www.dropbox.com/s/e1viqanktd3se74/Screenshot%202016-11-22%2020.03.19.png?dl=0 [20:51:36] looks... gross [20:51:39] so we need outer and inner CSS to either both be desktop or both be mobile [20:51:49] if that's the mobile css then why does it look good on mobile?? [20:52:09] i see... [20:52:12] that's the mobile css for the outer (narrow desktop) and the desktop css for the iframe [20:52:26] due to the -device- media query in the iframe [20:53:14] goootcha [20:53:27] ejegg: ok so you're suggesting we merge https://gerrit.wikimedia.org/r/#/c/322962/1 then [20:53:27] awight: i'm pretty sure that #cards img went away in aa6dc17d340e381a7e1fd9a721df9034c7fffee6 [20:53:33] awight: yah [20:53:45] ejegg: it did, but that isn't deployed yet [20:54:04] wait, what are we seeing on prod now? [20:54:18] is it just the preliminary cleanup patches? [20:54:49] I support https://gerrit.wikimedia.org/r/#/c/322962/1. using device-width isn't best practice, but it will be an improvement on what we have now (and previously) [20:55:15] (CR) Awight: [C: 2] "Somewhat contentious because we might want to switch to responsive styles for narrow desktop windows. But for now, we've agreed that we n" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322962 (owner: Cdentinger) [20:55:50] the-wub: yeah I'd like to revisit that later. We should be responsive on narrow desktop windows [20:57:00] (Merged) jenkins-bot: s/max-width/max-device-width/g [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322962 (owner: Cdentinger) [20:57:29] awight: I think we might be able to fix it by adding a viewport tag in the iframe. but guessing that would need back and forth with ingenico [20:58:06] yeah, they've only let us put in that CSS link so far [21:00:43] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322965 [21:00:52] sorry about the no-op commit [21:01:03] * cwd pads github stats [21:01:25] there's definitely some caching issue here [21:01:48] there's no '#cards img' in DonationInterface on the deploy server [21:02:05] but i'm getting it from a couple different payments servers in a couple different browsers [21:02:28] * awight reads deployment log [21:03:05] it was in the same commit as the other changes - looks like we're getting new forms.css but old gateway.css or something [21:03:22] ooh, unless this is a site css file [21:03:47] site...? [21:04:34] common.css [21:04:56] (PS1) Cdentinger: Update donationinterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322968 [21:05:22] where does that come from? [21:05:35] ejegg: yeah, I see it. https://payments.wikimedia.org/index.php/MediaWiki:Common.css Should we just wipe that? [21:05:37] it's a page, i think in the mediawiki namespace [21:06:02] aha, yep, that's making it hard to develop! [21:06:03] ejegg: K i'm on the same page now. deployed code shouldn't have had that CSS [21:06:37] so... let's make sure the bits we want are in the deployed code, then wipe that page [21:06:46] thanks for the link the-wub [21:06:54] i don't get it, that page is implanting some css? [21:07:09] yeah, it's another one of those freaky mediawiki features [21:07:18] like user-editable javascript [21:07:21] https://www.mediawiki.org/wiki/Manual:Interface/JavaScript [21:07:26] ah ha! [21:07:37] someone will need to unlock the database to edit it though. jeff usually does that, I don't know if anyone else can? [21:08:00] d'oh. [21:08:01] no [21:08:07] mm [21:08:08] ah yes the payments mw db [21:08:10] lemme see [21:08:13] what a strange thing for there to be [21:08:53] should i hold off on this deploy? [21:09:48] the-wub: OK, i checked - we've got all the important stuff from that page copied into gateway.css [21:10:03] feel free to wipe it [21:10:43] cwd: naw it should be safe to go ahead, afaict [21:10:56] thanks ejegg. I think all that dates from when we were testing some changes a long time ago, and never got removed when we incorporated them into the real css. sorry for the added confusion! [21:11:09] cool [21:11:26] fwiw I tried removing that css in chrome devtools and it didn't change anything [21:12:21] (CR) Cdentinger: [C: 2] Update donationinterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322968 (owner: Cdentinger) [21:12:21] the-wub: oh, huh, k. [21:12:24] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322965 (owner: Cdentinger) [21:20:50] huh, til there's a .blackfriday TLD: https://icannwiki.com/.blackfriday [21:20:57] new frontiers in capitalism! [21:21:58] (Merged) jenkins-bot: Update donationinterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322968 (owner: Cdentinger) [21:22:01] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322965 (owner: Cdentinger) [21:28:36] (PS1) Ejegg: More CSS fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) [21:28:45] fr-tech couple more fixes ^^^ [21:31:28] !log updated payments from 84b035ed72b9e3deb0089023777c400f514a6de5 to 6412a22f5ff1bd342736a6f3536818bd2c00549a [21:31:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:32:30] looks good on desktop [21:33:37] and mobile [21:33:53] still got those overflowing card logos on ff mobile [21:34:09] but this should fix 'em: https://gerrit.wikimedia.org/r/322971 [21:34:39] yep, looks good to me on desktop and mobile, apart from the card images [21:35:03] hmm, no 'Please enter your zip code' when I try to submit with that empty [21:35:11] ok, i gotta take the dog for a walk before the next meeting she's going berserk [21:35:43] the-wub: do you have a sec to CR that card image fix? https://gerrit.wikimedia.org/r/322971 [21:38:58] (CR) Nirzar: More CSS fixes (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [21:45:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: EPIC: civi dedupe, resolve conflicts round 2 - https://phabricator.wikimedia.org/T151406#2816224 (DStrine) [21:46:19] (PS2) Ejegg: More CSS fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) [21:47:05] thanks ejegg [21:47:30] :) [21:48:25] (CR) Pcoombe: More CSS fixes (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [21:48:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: investigate civi data cleanup tools - https://phabricator.wikimedia.org/T151407#2816244 (DStrine) [21:49:57] (PS3) Ejegg: More CSS fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) [21:51:40] (CR) Ejegg: More CSS fixes (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [21:52:24] (PS4) Ejegg: More CSS fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) [21:53:16] it's way too long since I used gerrit and they moved all the buttons :( [21:53:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: EPIC: civi dedupe, resolve conflicts round 2 - https://phabricator.wikimedia.org/T151406#2816282 (DStrine) [21:53:52] the new ui is totally unusable on even slightly narrow screens [21:58:31] (CR) Pcoombe: [C: 2] More CSS fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [21:58:55] thanks the-wub ! [21:59:02] np, thank you! [22:00:36] (PS1) AndyRussG: WIP SpecialBannerLoader: disable caching on error status [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 [22:05:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi: report filter for total USD within a time period - https://phabricator.wikimedia.org/T151271#2812787 (DStrine) p:Triage>Normal [22:08:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit, MediaWiki-extensions-DonationInterface, Epic: [Epic] Report gateway status when available - https://phabricator.wikimedia.org/T151274#2816351 (ggellerman) p:Triage>Normal [22:11:19] (Merged) jenkins-bot: More CSS fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/322971 (https://phabricator.wikimedia.org/T149249) (owner: Ejegg) [22:11:30] Fundraising Sprint Unbreaking Now, Fundraising-Backlog, FR-Ingenico, Patch-For-Review, WMF-deploy-2016-11-08_(1.29.0-wmf.2): Show contribution tracking ID in Ingenico error messages as full 'External Reference #' - https://phabricator.wikimedia.org/T149137#2816378 (ggellerman) Open>Res... [22:12:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi dedupe: offer dedupe option in a regular search - https://phabricator.wikimedia.org/T151270#2816383 (ggellerman) p:Triage>Normal [22:13:10] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2816401 (Ejegg) [22:15:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2816418 (ggellerman) p:Triage>Normal [22:16:31] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322981 [22:16:38] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322981 (owner: Ejegg) [22:17:13] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/322981 (owner: Ejegg) [22:23:11] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322995 [22:23:19] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322995 (owner: Ejegg) [22:27:13] Fundraising-Backlog, FR-Ingenico: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2746164 (awight) Order ID collisions turned out to not be an issue. [22:29:12] ejegg: did we deploy? I'm still seeing the cc images overflowing [22:29:30] waiting for that core patch to merge ^^ [22:29:55] ok thanks. I've never fully understood the mysteries of deployment [22:34:06] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Spike: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2746147 (awight) Known remaining work: put the polish on the recurring workflow. Distinguish legacy vs EC in our database. C... [22:36:05] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/322995 (owner: Ejegg) [22:37:37] !log updated payments-wiki from 6412a22f5ff1bd342736a6f3536818bd2c00549a to f8ca94201a3f69ee8176f4984f1caa410ac90c49 [22:37:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:39:05] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Empty zip code error message missing - https://phabricator.wikimedia.org/T151416#2816541 (Ejegg) [22:39:58] okay the-wub , spatton : latest css fixes are up [22:40:17] thanks ejegg, just checking them now [22:42:25] okay the cc images look good now. still not seeing the zip code error, I see you made a task for that [22:43:34] (PS1) Krinkle: Remove use of deprecated "json" module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/323060 [22:47:33] right, I'm going to head off now and leave the banner testing in the capable hands of spatton. thanks ejegg and all for your help getting this out! [22:47:56] thanks, the-wub, have a good night! [22:48:04] cya the-wub [22:48:33] and thanks ejegg! Tests just went live. [23:03:10] ejegg: Thanks everyone.. this is looking good now!! [23:03:34] awesome! [23:03:53] thank you nzr, this design feels so much better [23:04:25] :D yay! [23:13:51] eileen1: do you see the gchat from leanne? [23:20:26] systemd-journal is literally making my computer burn up [23:22:13] augh i accidentally booted the RT kernel [23:26:25] i was wondering why battery life had been so bad lately [23:26:40] * cwd pats computer on the head [23:27:49] computer purrs several seconds later [23:33:57] https://en.wikipedia.org/wiki/Real-time_operating_system [23:34:46] AndyRussG: yup, i keep the RT one around for audio processing [23:34:58] but there is a bug where it spams syslog as hard as possible [23:36:05] and i'm glad i checked cause syslog is 10G [23:36:11] i hate systemd [23:36:16] cwd - I updated the goals doc - but my feeling is our first goal should be to get better performance measures [23:36:23] & benchmarking [23:36:37] (CR) Jforrester: [C: 2] Remove use of deprecated "json" module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/323060 (owner: Krinkle) [23:36:41] & then follow on from there with any dedupe change investigation [23:39:25] eileen1: ah yes absolutely your call, i am a newbie with dedupe [23:41:44] cwd yeah I guess my thinking is that if we have a performance prob then how will we know if we have improved it [23:43:25] yeah i'm all about due diligence researching the actual problem [23:44:29] yeah - good to know what you are ignoring :-) [23:45:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: CentralNotice: Can we reduce Varnish cacjhe time for SpecialBannerLoader errors, and if so, by how much - https://phabricator.wikimedia.org/T151418#2816626 (AndyRussG) [23:47:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: CentralNotice: Is a Varnish banner/campaign quick flush switch feasible? - https://phabricator.wikimedia.org/T151419#2816648 (AndyRussG) [23:50:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: CentralNotice: Can we reduce Varnish cache time for SpecialBannerLoader errors, and if so, by how much - https://phabricator.wikimedia.org/T151418#2816662 (AndyRussG) [23:51:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Traffic: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2816664 (AndyRussG) Related: T151418 and T151419 [23:53:46] fr-tech Here are the new tasks mentioned in the meating... Gonna try to get feedback on #wikimedia-operations T151419 T149873 [23:53:47] T151419: Spike: CentralNotice: Is a Varnish banner/campaign quick flush switch feasible? - https://phabricator.wikimedia.org/T151419 [23:53:47] T149873: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873 [23:54:04] thanks AndyRussG [23:54:23] ejegg: ;) [23:54:28] Also, my cat has no understanding of why he shouldn't stand on the keyboard [23:54:54] And I have no understanding of why he should bite my nose, or, in case of reduced nose access, my ear