[00:01:10] AndyRussG: perhaps he could be a yubi-cat [00:01:46] you mean, I could use a bit of his fur for 2-factor identification? [00:02:01] kinda like a fur-gerprint? [00:02:15] * awight hangs on edge of couch to hear the end of this [00:02:45] * AndyRussG donates cat fur to awight's couch [00:02:57] * awight bats at curtain strings over a lit candle [00:03:39] * AndyRussG bats candle off table and under couch [00:04:46] Hmm traffic engineers are afk [00:05:23] * AndyRussG gladly expects a million times more responsiveness from others than provides himself [00:05:30] two catfur auth amirite [00:05:33] (^ it's a parenting skill) [00:06:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit, MediaWiki-extensions-DonationInterface, Epic: [Epic] Report gateway status when available - https://phabricator.wikimedia.org/T151274#2816701 (awight) Should we also track, timestamp at which the gateway status was determined,... [00:06:05] heh [00:06:24] indeed [00:07:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit, MediaWiki-extensions-DonationInterface, Epic: [Epic] Record transaction gateway status as it's available - https://phabricator.wikimedia.org/T151274#2816704 (awight) [00:19:35] (CR) Awight: [C: -1] WIP SpecialBannerLoader: disable caching on error status (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (owner: AndyRussG) [00:30:59] oops I posted one of the wrong new task numbers above ^ should have been T151419 and T151418 [00:31:00] T151419: Spike: CentralNotice: Is a Varnish banner/campaign quick flush switch feasible? - https://phabricator.wikimedia.org/T151419 [00:31:00] T151418: Spike: CentralNotice: Can we reduce Varnish cache time for SpecialBannerLoader errors, and if so, by how much - https://phabricator.wikimedia.org/T151418 [00:31:21] (PS2) AndyRussG: SpecialBannerLoader: reduce s-maxage on caught exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) [00:39:10] (CR) Ejegg: "Forgot to git add the code change?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [00:39:23] (CR) AndyRussG: SpecialBannerLoader: reduce s-maxage on caught exception (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [00:40:50] (PS3) AndyRussG: SpecialBannerLoader: reduce s-maxage on caught exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) [00:42:22] (CR) AndyRussG: "> Forgot to git add the code change?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [00:42:52] Also oops on the formating of the ooops [00:47:47] AndyRussG: Thanks! Trying that code locally... [00:55:51] awight: thanks to u also :) [00:58:57] AndyRussG: I did notice one thing... [00:59:05] not sure how to reassure myself that it's okay [01:00:07] awight: mmm? [01:00:40] (CR) Awight: SpecialBannerLoader: reduce s-maxage on caught exception (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [01:01:46] The near-blocker i'm muttering about is how getOutput()->disable() gets moved [01:02:20] Cos, what if there were conditions in which we were actually emitting things to output but didn't realize thanks to the placement of that line [01:21:04] awight|distracto: you mean, if an exception happens, that might end up being output? [01:28:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2816837 (Ejegg) The users encountering this have mainly been coming in via email campaigns (makes sense, as banners only target the peopl... [01:39:10] AndyRussG: Is that the only thing that might be outputting? [01:39:46] I guess we do own all the code that executes during that render function [01:41:04] awight|distracto: mmm yeah I think it's OK, just checked out the doc... One sec, will post :) [01:56:36] (PS4) AndyRussG: SpecialBannerLoader: reduce s-maxage on caught exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) [01:59:22] (PS1) Ejegg: Crappy workaround for zip / postal_code mismatch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323110 (https://phabricator.wikimedia.org/T151416) [02:00:35] Fundraising Sprint Value Subtracting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Empty zip code error message missing - https://phabricator.wikimedia.org/T151416#2816886 (Ejegg) p:Triage>Normal a:Ejegg [02:01:39] (CR) jenkins-bot: [V: -1] Crappy workaround for zip / postal_code mismatch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323110 (https://phabricator.wikimedia.org/T151416) (owner: Ejegg) [02:02:00] (CR) AndyRussG: "Thanks!!!!" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [02:02:27] awight|distracto: ^ [02:02:44] (PS2) Ejegg: Crappy workaround for zip / postal_code mismatch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323110 (https://phabricator.wikimedia.org/T151416) [02:13:25] (CR) Ejegg: [C: 1] "Code and comments look good, works correctly locally with artificially induced exceptions." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [02:17:18] (CR) Awight: SpecialBannerLoader: reduce s-maxage on caught exception (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [02:23:35] (CR) AndyRussG: "I think this will be pretty safe to deploy, since the reduced cache time can be adjusted via a config change, which (AFIK) would have effe" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [02:23:39] (Merged) jenkins-bot: Remove use of deprecated "json" module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/323060 (owner: Krinkle) [02:24:04] Are exclamation points allowed for a statement that ends in parentheses? [02:25:47] (CR) Awight: [C: 2] SpecialBannerLoader: reduce s-maxage on caught exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [02:25:52] wat! [02:29:30] (Merged) jenkins-bot: SpecialBannerLoader: reduce s-maxage on caught exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/322976 (https://phabricator.wikimedia.org/T151418) (owner: AndyRussG) [02:29:32] Strunk and wat(?)! [02:30:32] * awight|distracto is inspired to look for the parentheses [02:39:25] also thanks! [02:39:39] (awight|distracto: they were in the inline comment) [02:40:38] ah sure, i see! [02:40:55] distracted >.< [02:41:32] Mari learned the importance and popular method of requesting dessert [02:41:43] You have no idea the power of the dark side... [02:46:52] we tried to divert her onslaught with a cookie-baking exercise but it's not holding the tide back [02:50:20] heheheh it's the beginning of a long road [02:51:35] lose the battle... lose the war... [02:51:57] lose the philosophical conflicts of the epoch.... [02:52:09] lose the worldview of the millenium... [02:52:23] On the bright side, glad to see that merg'd!!! Do you think we should try to have it deploy'd tomorow? [02:52:39] I have to housework for a bit but will be backquitesoon! [02:52:43] Sounds good to me [02:52:48] tonight even, as you wish [02:52:48] :) [02:52:54] Hmmmm [02:53:08] Nah let's let it betacluster for a few, whatdya think? [02:55:03] wholesome! [03:14:58] Besides aaron's pending core patch, the other mystery we have before us, if you're looking for fun, is why this patch apparently didn't work: https://gerrit.wikimedia.org/r/#/c/318159/ [03:15:47] It was deployed a while ago, and we've gotten banner message errors since, but all the beacon/impression logs I pulled from Hive with the new error status have other error messages [03:16:35] My only possible theory so far is that the banner message errors in logstash were due to banner previews, hence no record impression [03:17:12] T149107 [03:17:12] T149107: CentralNotice: Relay banner loading issues in beacon/impression - https://phabricator.wikimedia.org/T149107 [03:17:39] awight|distracto: ^ [03:21:06] ooh that one does look fun [03:22:56] Could it be cos ajax.fail is not fired? [03:23:06] Does it work locally? [03:23:41] oh right, if we don't .fail then we run the handleBannerError in returned jsonp [03:23:43] yeah works great locally, triggering the self-same 'ception [03:24:17] yeah [03:24:42] gotta... slather myself in a new coat of zinc oxide [03:25:01] I was gonna try to associate the logstash debug errors with real beacon/impression webrequests from the same pageview [03:25:20] and also look at banner loader response sizes from the same pageviews [03:25:42] hmmm u think that'll help? [03:30:01] it's holding the oozing at bay until I can get myself some oral steroids, at least [03:30:57] ok, I'll have a little fun beating on the fail later [03:37:15] aaah good luck with the arm!!! [05:22:52] cyaz [18:00:02] fr-tech: The system was down for backups from 5am to 10am last Saturday. [18:00:03] -- discuss. [18:06:23] (CR) XenoRyet: [C: 2] "Works, and isn't too scary. I also like the variable names, should keep us from tolerating this band-aid for too long after BE." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323110 (https://phabricator.wikimedia.org/T151416) (owner: Ejegg) [18:09:00] (Merged) jenkins-bot: Crappy workaround for zip / postal_code mismatch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323110 (https://phabricator.wikimedia.org/T151416) (owner: Ejegg) [18:12:52] I'm in the hangout, should anyone wish to MessageCache confer [18:15:43] joining [18:31:41] ejegg: I guess in SOS mebbe just emphasize that BE is starting and so avoid deploying major changes that could affect that? [18:32:12] Lemme look for the e-mail that wuz sent, maybe you'd like to remind folks via a link thereto? [18:32:19] yep, I'll repeat my plea [18:32:23] K thx!!! [18:36:08] ejegg: it was an e-mail from greg-g on November 3 to Ops and Engineering mailing lists [18:36:24] thanks AndyRussG [18:37:12] ejegg: Just a few important things we should avoid rewriting just now: GeoIP, ResourceLoader, MessageCache [18:37:22] EventLogging [18:37:38] Hive webrequest tables [18:37:43] https://lists.wikimedia.org/pipermail/engineering/2016-November/000331.html [18:38:38] Ah cool! Yeah I didn't realize that list was public.... [18:44:29] AndyRussG: XenoRyet cwd ejegg did you all discuss CN in tech talk? [18:45:18] dstrine: ejegg XenoRyet and I talked some... ( ejegg had to run to scrum-of-scrums) [18:45:35] were there any conclusions? [18:46:05] In summary, so far, the change proposed in core is pretty hard to understand, and not very certain to work like a charm [18:46:18] It might, I guess [18:46:31] Too scary for right now though. [18:46:47] was that the one on it's way out? Do we need to stop people from +1-ing it? [18:46:47] dstrine: do you know if fr-online is aware of the (experimental) mobile content services announcements feed? https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps#....2Ffeed.2Fannouncements [18:47:15] The android and iOS apps have just released some kind of support for them [18:47:36] dstrine: this is the one. Yeah it's in review still: https://gerrit.wikimedia.org/r/#/c/318489 [18:48:35] Maybe we should put a -1 on there saying we want to hold off for now. [18:48:44] ejegg: I'm not sure. They were going to test a single banner in the feeds for both apps. I saw mobile PMs talking with fr-online about this but nothing on a full service [18:49:09] ah cool [18:49:18] I have a bunch of questions about the patch, thought they may be easily answerable by folks who know details of the MessageCache system [18:50:08] AndyRussG: I'll ask if anyone has time for a quick video chat [18:50:10] So far the consensus was, let's suggest it not be deployed until the main initial part of the FR campaign is done. Maybe mid-December or whenever the lull is [18:50:32] ejegg: ah cool! Yeah maybe Aaron or Gilles (who also commented on it) [18:51:25] For now I'm gonna concentrate on getting feedback on our caching stuff [18:51:28] ejegg: AndyRussG XenoRyet cwd if you discuss the CN stuff I would like to join. but if you have already made the call to hold on this change, I think we should inform others asap [18:52:54] dstrine: I'm leaning towards that call but I'm not sure I'm 100% there. For example, if the authors say they're completely sure it's safe and beneficial and should go out soon (like maybe with the train in the middle of next week) I'd be willing to listen [18:54:33] Rather than making a hard demand at this point I'd maybe start with talking over concerns [18:54:34] AndyRussG: ejegg cwd XenoRyet regarding andy's last comment... it's up to you all if you want to agree to a mid-week update. Please consider that we might be mid-crisis on other things and you may not have the headspace to monitor or respond to the CN change. [18:55:28] (dstrine: just to clarify, note it's a change in core code, not CN per se) [18:56:26] It'd be nice if there were unit tests, but I'm not sure how to do that on this particular code [18:56:46] AndyRussG: Gilles says he'll schedule a quick meeting with you and Aaron [18:56:59] ejegg: ah fantasmic! thx much! :) [18:57:05] yw! [18:57:18] ejegg: anyone from Traffic at the meating (bblack or ema)? [18:57:39] It seems scary to me, but I'm a total outsider in that codebase. I suppose if the authors are super-confident of the patch and the ability to detect if it breaks anything, and they're willing to be on the hook if it breaks, it could be ok. [18:57:40] Ah, I didn't request their presence [18:57:51] ejegg: I meant, at the SOS meeting [18:58:15] I'd like to talk to them, though separately, from their POV it's a totally different issue (Varnish caching) [18:58:22] Or one of them [18:58:26] IRC is also fine in that case [18:58:36] I'll just ping 'em... [18:58:55] Ah yeah, meeting just ended [18:59:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: If possible, reduce Varnish cache time for SpecialBannerLoader errors - https://phabricator.wikimedia.org/T151418#2818583 (AndyRussG) [19:00:44] going to push out that trivial zip code error message fix [19:18:38] (CR) Ejegg: [C: -1] "Little issue with that merge resolution" (1 comment) [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/322823 (owner: Eileen) [19:23:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Traffic: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2818653 (AndyRussG) >>! In T149873#2767345, @aaron wrote: > Another idea is to add a cache-busting pa... [19:35:06] Fundraising-Backlog, fundraising-tech-ops: remove 'stomp' project from fundraising code deployment tools - https://phabricator.wikimedia.org/T149695#2818669 (Jgreen) Open>Resolved this is done [19:45:10] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Unplanned-Sprint-Work: Donation form email address validation: enable @y7mail.com domain - https://phabricator.wikimedia.org/T151157#2818677 (MBeat33) Open>Resolved a:MBeat33 The new X button makes this Resolvable. [19:52:27] are we still waiting on anything here? https://phabricator.wikimedia.org/T117872 [19:53:02] cwd: That one is a crazy hemiepic [19:53:59] I came around to a new pov, that we need to change the generic error message from "no processors available" to "sorry we can't take your money right now" [19:54:07] there's absolutely no reason to be technical about that [19:54:28] plus there is ejegg CR, lemme see... [19:55:02] yeah definitely less roboty language [19:55:16] and a reference number seems useful [19:55:26] awight: oh, we did just push out a change to that [19:55:41] it now invites them to bombard DS with questions [19:55:56] brave souls [19:56:10] so... it would be nice to be able to tell them 'try again' or 'fix your CVV' when that's all they need to do [19:57:24] does the processor tells us that info in sync? [20:00:55] Fundraising-Backlog, FR-Ingenico, FR-2016-17-Q2-Bugs: Add type hint prefixes to the IDs displayed on payments error forms - https://phabricator.wikimedia.org/T151478#2818697 (awight) [20:01:12] ejegg: Should I do that deploy, or should we wait and see if anything more shakes out of T117872? [20:01:12] T117872: [Epic] Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872 [20:05:33] XenoRyet: might as well do it now [20:05:39] 10-4 [20:06:55] (CR) Awight: Handle banner loader errors on client (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318159 (https://phabricator.wikimedia.org/T149107) (owner: AndyRussG) [20:09:36] Oh good, it's easy to trigger a handleBannerLoaderError with an empty "banner" param [20:09:39] https://en.wikipedia.org/w/index.php?title=Special:BannerLoader&banner=&uselang=en&debug=false [20:11:44] (PS1) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/323235 [20:17:20] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/323235 (owner: XenoRyet) [20:21:27] I love it! My radio net caught schools of fish while I was away [20:23:38] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/323235 (owner: XenoRyet) [20:23:58] awight: fish? [20:24:50] a delicious soup of the DJs I intended to capture [20:25:00] oh nice! [20:25:08] bottom feeders, crustaceans [20:25:13] boulla-baise [20:25:38] (PS1) XenoRyet: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/323237 [20:25:41] sounds like NOLA music [20:26:03] There are glitches, though. It's like the recording version of the walkman taped to a pirate transmitter u might dump in a trashcan for the week [20:26:09] hehe, WWOZ has a great show for that 11-1 [20:26:15] ooh [20:26:18] (CR) XenoRyet: [C: 2] Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/323237 (owner: XenoRyet) [20:26:24] * awight UTCs [20:26:30] central time, that is [20:26:48] I'm learning to go here first, http://www.wwoz.org/listen/archive/ [20:27:02] oh hey! [20:27:12] this scraping tool should have a pluggable framework to snag those [20:28:51] hmm, file names have an overly precise timestamp, so it'll require parsing that page [20:29:29] I'm gonna... file some puzzle pieces so these wonderful *ROIDS course to the old extremeties [20:29:34] back in 30 [20:36:13] (Merged) jenkins-bot: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/323237 (owner: XenoRyet) [20:42:29] !log Updated payments-wiki from f8ca94201a3f69ee8176f4984f1caa410ac90c49 to d7ed14407aa7be9a790778cae644c2b320bb7aa4 [20:42:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:45:31] (PS1) Ejegg: WIP better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) [20:48:01] (CR) jenkins-bot: [V: -1] WIP better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) (owner: Ejegg) [20:54:42] (PS2) Ejegg: WIP better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) [20:56:34] (CR) jenkins-bot: [V: -1] WIP better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) (owner: Ejegg) [21:02:26] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#2818939 (MBeat33) Open>Resolved a:MBeat33 The final word from Ingenico:... [21:11:52] (PS2) Cdentinger: Make sure tests fail on missing response file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/310684 (owner: Ejegg) [21:14:29] (CR) Cdentinger: [C: 2] Make sure tests fail on missing response file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/310684 (owner: Ejegg) [21:16:22] (Merged) jenkins-bot: Make sure tests fail on missing response file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/310684 (owner: Ejegg) [21:18:28] (PS3) Ejegg: Better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) [21:18:30] (PS1) Ejegg: Allow getRequiredFields before unstagedData is set [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323254 (https://phabricator.wikimedia.org/T151411) [21:20:24] (CR) jenkins-bot: [V: -1] Better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) (owner: Ejegg) [21:25:29] (CR) Cdentinger: "Why change this? The current version actually seems more correct to me, using an explicit argument instead of relying on a side effect" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287942 (owner: Ejegg) [21:28:01] (PS4) Ejegg: Better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) [21:29:51] (CR) Ejegg: "The only table it ever tries to read from is $this->db_table, so it seems strange to have the create function take any arbitrary table nam" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287942 (owner: Ejegg) [21:29:59] (CR) Eileen: "thanks - fixed - will update staging with it" (1 comment) [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/322823 (owner: Eileen) [21:37:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2819123 (Pcoombe) Great idea @Ejegg. Added a basic link when the country code is garbage: https://donate.wikimedia.... [21:45:55] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2819134 (MBeat33) Sure, that looks fine, thanks @Pcoombe [21:48:52] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2819141 (Ejegg) Thank you @Pcoombe ! Looks good on desktop. On mobile it's behind the WMF logo. [21:49:34] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 4 others: CentralNotice: Relay banner loading issues in beacon/impression - https://phabricator.wikimedia.org/T149107#2742432 (awight) To force an error on p... [21:58:33] (PS1) Eileen: Add extension with screen to do data entry on unsubscribing emails. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323321 (https://phabricator.wikimedia.org/T147571) [22:00:01] awight: what is your take on this one? https://phabricator.wikimedia.org/T146295 [22:00:50] should we be forcing the importers to add data - or just add by default ? [22:02:12] eileen1: Ah thanks for the ping--I think CCogdill is on quite the right track [22:02:19] (in a meeting btw, back in 30) [22:03:33] (PS2) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/322823 [22:03:38] AndyRussG|bassoo: meeting? [22:03:38] ok sure [22:18:53] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2819210 (Pcoombe) Good catch @Ejegg, should be fixed now. [22:26:19] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2816401 (Platonides) Is the country code really required in that API call? [22:28:48] https://security-tracker.debian.org/tracker/CVE-2016-1248 [22:37:02] eileen1: k back again [22:37:54] awight: ok cool - was just trying to understand what needs doing there & if I should do it [22:38:13] we have a fairly healthly looking sprint [22:39:08] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Bugs: Engage import failing to import certain significant fields - https://phabricator.wikimedia.org/T146295#2819317 (awight) @CCogdill_WMF Yes! Thanks for the general fix, we should take that... [22:40:11] Hmm. [22:40:36] eileen1: I think we should, but would need to ask Major Gifts whether there's a spike in new matching gifts in Dec, or if we can hold off until after BE [22:41:25] awight: so they use our custom import which neither requires a campaign or adds a default? [22:41:37] mmm [22:41:43] Yes [22:41:46] but it's even worse, right-- [22:41:51] & we should do one of those things - possibly import dependent? [22:41:55] matching gifts are created as soft credits, right? [22:42:10] I think so [22:42:25] I wasn't able to finish investigating the ones in the task, but did notice that the contacts were all MG foundations [22:42:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411#2819334 (Ejegg) @Platonides Yep, Ingenico lists that as one of the required parameters to INSERT_ORDERWITHPAYMENT [22:42:58] lemme see... [22:44:24] Ok I don't see a matching gifts import on the screen with engage - which is what I was assuming [22:44:50] not sure which screen that would be. Edit Contribution? [22:45:02] or the import_checks page? [22:45:26] Hmm. Yeah wait [22:45:37] I need to ask MG [22:45:40] unless you know [22:46:04] Engage enters checks, which I believe come in as a spreadsheet and MG checks the data then imports [22:46:30] But Engage keys matching gifts and similar instruments by hand via the Civi UI? [22:46:42] maybe they also send over a spreadsheet explaining what they did. [22:46:56] This is a tenuous memory tho [22:48:09] I guess the source_ fields will tell me something. [22:48:38] hmm let's as mg [22:50:32] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Bugs: Engage import failing to import certain significant fields - https://phabricator.wikimedia.org/T146295#2819356 (Eileenmcnaughton) @LeanneS how do you guys enter matching gifts? can talk o... [22:51:08] eileen1: wow even without the typo that last comment only barely made sense [22:51:55] u must be cribbing off of my flounderings [22:52:26] :-) [22:52:49] awight: and eileen1 leanne doesn't use irc but I started a gchat [22:53:08] eileen1: I must be wrong about the soft crediting--no hits on civicrm_contribution_soft.contact_id [22:53:37] Wish I could remember which direction matching gifts are entered in, vs DAF etc [22:53:59] oh ok [22:54:43] ops. [22:54:47] no there are soft credits. [22:54:58] select * from civicrm_contribution c left join civicrm_contribution_soft s on c.id=s.contribution_id join wmf_contribution_extra e on e.entity_id=c.id where c.contact_id= [22:56:25] and no data in wmf_contribution_extra.source_* [22:56:43] I thought I'd added that data via hook when entering contributions manually... [22:57:05] (wmf_civicrm.module = too long) [22:57:17] yep [22:57:33] & got longer lately with dedupe :-( [22:58:36] nope. okay it looks like just what ccogdill said, that we don't add source_* or utm_* when contributions are entered manually. [22:59:06] so they are all just UI-entered? [22:59:10] adding the utm_* fields to the generic import script is important too but a slightly different issue, I believe [22:59:14] I think so [22:59:30] I can try to check the dedupe log... [22:59:35] might need a little guidance to do that [22:59:40] but sprint planning looms [22:59:45] dedupe log? audit logs? [23:00:16] W - [23:40:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Add unit tests that look at output queue messages - https://phabricator.wikimedia.org/T151504#2819503 (Ejegg) [23:46:13] Fundraising Sprint Value Subtracting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-Logging, and 2 others: Some wmf_civicrm exceptions should be logged at info and not error - https://phabricator.wikimedia.org/T146063#2819525 (DStrine) Open>Resolved [23:59:19] Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising-Backlog, FR-2016-17-Q2-Campaign-Support, Patch-For-Review: Add field to Silverpop export: highest_native_amount - https://phabricator.wikimedia.org/T135407#2819585 (Ejegg) Open>Resolved [23:59:36] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 4 others: CentralNotice: Support MariaDB Strict Mode - https://phabricator.wikimedia.org/T145591#2819586 (Ejegg) Open>Resolved