[03:13:10] (PS1) Eileen: Alternate fix for reconciliation report doubling some rows. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/325250 (https://phabricator.wikimedia.org/T152238) [03:33:29] Fundraising-Backlog, FR-Email: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2846002 (CCogdill_WMF) Would be great! I can move back the time of the Silverpop nightly import if it makes sense to give this time to rerun. [13:26:39] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2839139 (mark) >>! In T152122#2842636, @Catrope wrote: >>>! In T152122#2841... [15:54:53] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2839139 (jcrespo) Related T146840 ? [16:52:26] Fundraising-Backlog: Investigate implementing android and apple pay close together - https://phabricator.wikimedia.org/T152419#2847499 (DStrine) [16:54:45] Fundraising-Backlog: Investigate implementing android and apple pay close together - https://phabricator.wikimedia.org/T152419#2847531 (DStrine) [17:23:16] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2847699 (Catrope) Once again, no outage today. [17:23:48] Fundraising Dash, Fundraising-Backlog: Top days / top hours widget - https://phabricator.wikimedia.org/T152028#2847704 (DStrine) [17:41:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage unable to edit contacts due to "location type" - https://phabricator.wikimedia.org/T152426#2847785 (LeanneS) [18:00:02] fr-tech: The cost of living is going up, and the chance of living is going down. [18:00:02] -- discuss. [18:02:15] Fundraising-Backlog: Caption on Facebook links should be something better - https://phabricator.wikimedia.org/T152250#2847871 (DStrine) a:Pcoombe [18:02:47] Fundraising-Backlog: Caption on Facebook links should be something better - https://phabricator.wikimedia.org/T152250#2843126 (DStrine) Peter is discussing this with Jeff and comms [18:05:12] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Engage unable to edit contacts due to "location type" - https://phabricator.wikimedia.org/T152426#2847888 (DStrine) a:awight [18:07:06] Fundraising-Backlog: Caption on Facebook links should be something better - https://phabricator.wikimedia.org/T152250#2847905 (Pcoombe) [18:07:08] Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Improve text scraped by Facebook from donatewiki - https://phabricator.wikimedia.org/T152026#2847908 (Pcoombe) [18:08:03] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Engage unable to edit contacts due to "location type" - https://phabricator.wikimedia.org/T152426#2847911 (awight) @LeanneS Would you send along any contact IDs? [18:15:50] Hey so uh. What Debian release are kids recommending? "Unusable"? [18:16:33] ejegg: you can't hear me? [18:19:09] Fundraising-Backlog, FR-Adyen: Adyen doesn't officially support our iframe workflow - https://phabricator.wikimedia.org/T143714#2847973 (DStrine) a:DStrine>None [18:23:28] we may have to steal Khan Academy's recurring selector [18:23:34] https://usercontent.irccloud-cdn.com/file/E0hMcPcV/khan_academy.gif [18:29:20] the-wub: That makes my day [18:29:58] the-wub: ?!?!?!?!!! amazing [18:48:31] Fundraising-Backlog: Page is horizontally scrolled when the Banner is shown - https://phabricator.wikimedia.org/T152436#2848092 (bmansurov) [18:53:55] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Email, Unplanned-Sprint-Work: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2848116 (Ejegg) a:awight [18:56:35] Or we could make a WMF-fundraising version of "Clippy" [18:59:43] Wikimedia-Fundraising: Page is horizontally scrolled when the Banner is shown - https://phabricator.wikimedia.org/T152436#2848160 (Pcoombe) a:Pcoombe [19:00:05] fyi I'm looking into the above [19:02:51] ;) [19:06:27] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2848204 (Ejegg) @AndyRussG here's the bash script I use to run the phantomj... [19:11:34] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Email, Unplanned-Sprint-Work: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2848220 (awight) I've emailed Sisolak about bzipping the files before we send. The upload size would decrease from... [19:16:19] Wikimedia-Fundraising: Page is horizontally scrolled when the Banner is shown - https://phabricator.wikimedia.org/T152436#2848250 (Pcoombe) p:Triage>Unbreak! Can reproduce in Safari on macOS and iOS, but not any other browsers. Looking into a fix now. [19:17:15] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Email, Unplanned-Sprint-Work: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2845492 (Eileenmcnaughton) Does it make sense to have a separate upload job? ie. if the upload succeeds it could ou... [19:21:24] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Email, Unplanned-Sprint-Work: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2848303 (awight) @Eileenmcnaughton Great idea, I'll do that! [19:54:05] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Engage unable to edit contacts due to "location type" - https://phabricator.wikimedia.org/T152426#2848444 (Eileenmcnaughton) I took a look & found 1030 contacts with no location type f... [19:54:54] (PS1) Awight: Split silverpop export from upload [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/325360 (https://phabricator.wikimedia.org/T152352) [19:55:40] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2848450 (Ejegg) @jcrespo It's more than just an EventLogging issue - we're... [19:56:41] fr-tech: Some review if anyone is interested ^ [20:07:34] can anyone tell me how to simulate this? https://gerrit.wikimedia.org/r/#/c/324343/ - the code looks 100% fine but I feel like I should figure out how to run it [20:08:40] eileen2: I would hope it can be triggered from a unit test... looking. [20:09:09] perhaps QueueConsumerTest [20:09:30] If you want to *really run it though, it can be done from vagrant [20:10:22] php /vagrant/srv/SmashPig/Maintenance/ConsumePendingQueue.php [20:10:46] yah that worked for me [20:12:01] ejegg|meet: Not sure what you mean in that last email [20:12:11] If brian is right, then we don't have to re-upload [20:12:25] only problem is that we can't prove to ourselves that the upload worked [20:12:51] Hrm? I think he means the data job succeeded, though it would have been acting on the previous day's data [20:13:30] I'll ask for clarification--I read it differently, that the current day's files successfully uploaded. [20:15:08] in any case, we're crashing on the first upload and never trying the second [20:16:43] awight: do you want me to look at the engage edit one - I see you have assigned it to you [20:17:33] eileen2: sure, please go ahead and take that! [20:17:35] ty! [20:20:56] cool - you looked deep in uploads [20:21:12] hehe it's pretty feisty [20:28:19] Fundraising-Backlog, FR-Email: Spike: Investigate Silverpop invalid rows - https://phabricator.wikimedia.org/T152448#2848596 (awight) [20:46:38] AndyRussG: meeting? [20:56:00] Wikimedia-Fundraising: Page is horizontally scrolled when the Banner is shown - https://phabricator.wikimedia.org/T152436#2848682 (Pcoombe) Open>Resolved We were accidentally applying a `width` to one of the hidden radio buttons, which Safari didn't like. Have now fixed this in the template and all b... [21:02:22] Wikimedia-Fundraising: Page is horizontally scrolled when the Banner is shown - https://phabricator.wikimedia.org/T152436#2848713 (bmansurov) Thanks for the quick fix - looks great. [21:12:46] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2848782 (DStrine) a:awight [21:13:07] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2848784 (DStrine) a:Ejegg [21:13:28] Fundraising-Backlog: Investigate implementing android and apple pay close together - https://phabricator.wikimedia.org/T152419#2848786 (XenoRyet) a:XenoRyet [21:14:10] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: Investigate implementing android and apple pay close together - https://phabricator.wikimedia.org/T152419#2848788 (DStrine) [21:18:25] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: Investigate implementing android and apple pay close together - https://phabricator.wikimedia.org/T152419#2847499 (Ppena) Stuff for Android Pay Some nuggets from a few merchants about native app (in-app) product impact... [21:39:27] !log Silverpop job pushed back to 0600 UTC [21:39:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:42:13] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Email, Patch-For-Review, Unplanned-Sprint-Work: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2848905 (awight) One thing that got creepy is, the IBM import job was running only 3 hours af... [21:44:50] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Email, Patch-For-Review, Unplanned-Sprint-Work: Silverpop export: retry FTP upload on failure - https://phabricator.wikimedia.org/T152352#2848926 (Ejegg) Oof, good catch! [21:48:29] awight: if you have changed the silverpop export timing I probably need to adjust dedupe schedules? They don't run while silverpop is running [21:53:10] eileen2: aha, yes please [21:54:16] awight: ok - you moved it forward 2 hours didn't you? [21:55:02] I moved it from 0800 to 0600 UTC [21:55:09] so ah yes [21:57:10] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: Investigate implementing android and apple pay close together - https://phabricator.wikimedia.org/T152419#2848984 (DStrine) a related doc: https://docs.google.com/spreadsheets/d/1HnmHu8iJBqGrAj2yM3ThkOx2uxp3CfmhaJHpqxDf... [21:59:29] !log all dedupe jobs updated to have no-run window 2 hours earlier to reflect silverpop [21:59:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:03:53] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2849004 (awight) [22:04:34] eileen2: and fyi, the export takes about 4 hours [22:04:56] (nothing has changed, just wanted to mention that fact) [22:09:29] awight: cool - I just changed start & finish times [22:18:00] grr, hive can't do update with join, and the self-join is dying for some reason... [22:18:16] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Make PayPal listener understand Express Checkout - https://phabricator.wikimedia.org/T130851#2849107 (awight) [22:19:25] sorry, total homeowner catastrophe here, i have to run to the hardware store but will be working this evening [22:21:25] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2849120 (awight) [22:22:20] Fundraising-Backlog, FR-PayPal-ExpressCheckout, Epic: Epic: Distinguish PayPal legacy vs. Express Checkout transactions - https://phabricator.wikimedia.org/T138013#2849123 (awight) [22:22:32] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2746147 (awight) [22:22:38] dstrine: ^ I think that might be it. [22:23:02] Please send feedback about the level of detail we should provide here... [22:29:45] ejegg|food: lmk if you won't be able to review the silverpop thang today... [22:31:22] it looks fine, just a tiny chance that failing on the little file would make us re-do a successful big file upload, but nbd [22:32:09] interesting--yeah probably cheap enough that we don't have to care. The upload currently stands at 5m21s for the big file [22:32:35] cwd: Can you link me to docs on setting up the fr dash? [22:32:49] I meant to add those to https://www.mediawiki.org/wiki/Fundraising_tech/Components [22:48:22] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/325360 (https://phabricator.wikimedia.org/T152352) (owner: Awight) [22:50:37] ejegg: tanks! [22:50:46] jabelkom [22:51:03] (Merged) jenkins-bot: Split silverpop export from upload [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/325360 (https://phabricator.wikimedia.org/T152352) (owner: Awight) [23:11:07] Oooh Hive QL has a built-in standard deviation function! [23:11:28] https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF [23:23:29] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/325440 [23:23:45] (CR) Awight: [C: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/325440 (owner: Awight) [23:23:52] (Merged) jenkins-bot: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/325440 (owner: Awight) [23:24:42] !log update fundraising-tools from da8092927b1eb3af0cc98c797411bdd857ece3f1 to 43982478d248cfe99511328dec08dccd6105d4b6 [23:24:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:38:31] awight: I think the README in the dash repo is OK... [23:40:25] ejegg: ah. thanks [23:41:05] heh, thank you, I think you wrote it! [23:41:28] <_< [23:41:31] awkward. [23:41:54] well I pity the fool who's telling those lies [23:57:55] (PS1) Eileen: Do not give validation error on address with no location_type. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/325444 (https://phabricator.wikimedia.org/T152426) [23:59:12] dstrine I might have over-estimated that issue - the contacts should not have duplicate home addresses etc - but I think the error is only on a more limited circumstance [23:59:26] & we might get away with just commenting out the validation line for now [23:59:34] per https://gerrit.wikimedia.org/r/325444