[00:03:52] <AndyRussG>	 ejegg: yea the same happened tome
[00:04:08] <AndyRussG>	 I'm also perturbed by the fact that the-wub's fix didn't work
[00:04:55] <AndyRussG>	 fr-tech I just got off a short call with Adam Basso and Jon Katz about this. They asked me to add them to the e-mail thread and they'll loop in a contact of theirs at Google
[00:05:40] <AndyRussG>	 I have to afk for about 2.5 hours in 2 minutes, but I think a reasonable conclusion is that we should indeed try to pursue the Varnish route as relatively certain immediate fix
[00:05:51] <AndyRussG>	 Especially in light of the fact that the in-banner JS didn't work
[00:05:52] <ejegg>	 yep, Varnish for sure
[00:05:57] <AndyRussG>	 K! thx :)
[00:08:16] <AndyRussG>	 K just pingged bblack again about that, I'll send the e-mail then gotta dash
[00:12:22] <AndyRussG>	 cya soon, thx!!!
[00:21:14] <wikibugs_>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2871395 (Ejegg) Confirmed that the userAgent seen by JS is the same as that sent...
[00:50:16] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Thanks for the angular tips!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/326883 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[00:50:21] <grrrit-wm>	 (CR) jenkins-bot: [] Fix unsubscribe screen to hide results when data changes. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/326883 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[00:53:49] <grrrit-wm>	 (Merged) jenkins-bot: Fix unsubscribe screen to hide results when data changes. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/326883 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[00:54:16] <grrrit-wm>	 (CR) Ejegg: [C: 1] "Works great! Var name nitpick: is_opt_out vs is_opted_out confused me at first glance." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327115 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[00:54:20] <grrrit-wm>	 (CR) Eileen: [] "Still definitely working out angular myself - but I can see the appeal & it is the MVC Civi chose. Of course angular 2 muddies the waters " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/326883 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[00:54:36] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update unsubscribe so that email is required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327116 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[00:59:01] <grrrit-wm>	 (PS2) Eileen: Update unsubscribe extension to differentiate between opted out & already opted out [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327115 (https://phabricator.wikimedia.org/T147571)
[00:59:03] <grrrit-wm>	 (PS2) Eileen: Update unsubscribe so that email is required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327116 (https://phabricator.wikimedia.org/T147571)
[01:00:06] <grrrit-wm>	 (CR) Eileen: [] "Good point ejegg. I've changed it to 'opt_out_actioned'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327115 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[01:00:51] <grrrit-wm>	 (CR) Ejegg: [C: 2] "thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327115 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[01:00:57] <grrrit-wm>	 (CR) jenkins-bot: [] Update unsubscribe extension to differentiate between opted out & already opted out [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327115 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[01:00:59] <grrrit-wm>	 (CR) jenkins-bot: [] Update unsubscribe so that email is required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327116 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[01:06:53] <grrrit-wm>	 (Merged) jenkins-bot: Update unsubscribe extension to differentiate between opted out & already opted out [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327115 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[01:07:01] <grrrit-wm>	 (Merged) jenkins-bot: Update unsubscribe so that email is required [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/327116 (https://phabricator.wikimedia.org/T147571) (owner: Eileen)
[02:05:43] <RoanKattouw>	 ejegg: AndyRussG: I've +2ed the RL change blacklisting googleweblight, do you need that deployed urgently?
[02:08:01] <ejegg>	 Thanks RoanKattouw
[02:08:28] <ejegg>	 I'm inclined to wait for tomorrow's SWAT
[02:08:36] <RoanKattouw>	 OK
[02:08:43] <ejegg>	 I'll snag a slot
[02:09:06] <RoanKattouw>	 Since you're on the east coast you could probably grab an early one
[02:14:49] <ejegg>	 in CST just now, but yep! I hopped on the morning SWAT
[02:15:25] <ejegg>	 k, gotta run!
[02:15:29] <ejegg>	 thanks again RoanKattouw
[03:21:21] <wikibugs_>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi unresponsive for Engage in evenings - https://phabricator.wikimedia.org/T152786#2871628 (Eileenmcnaughton) I'm pretty certain the issue on 8 Dec was caused by the silverpop export being run at an odd time - see the highlighted row below. These rows...
[04:03:23] <AndyRussG|mostly>	 ejegg: so, I guess now the JS route, rather than Varnish? Or still both? I could maybe make my VPS phone home to tell me the exact UA string as visible on the client...
[04:08:44] <awight|err_n_>	 ^ I was thinking that would be useful.  It could also just put the UA into a div
[04:10:42] <awight|err_n_>	 IMO we should take both approaches if it doesn't burn too much good will
[04:11:27] <awight|err_n_>	 seems fair as long as we're open with everyone about how we're passionate about both solutions :p
[04:11:42] <awight|err_n_>	 sooo many people affected...
[04:16:18] <AndyRussG|mostly>	 awight|err_n_: mmm makes sense
[04:17:20] <AndyRussG|mostly>	 Sorry I had to be afk... mebbe we could have gotten it out sooner...
[04:17:42] <AndyRussG|mostly>	 Why was ejegg[m] preferring tomorrow morning? I guess for backup in case of badness?
[04:17:44] <awight|err_n_>	 meh either way, I'm just voicing my mild support for all of the above :)
[04:17:49] <AndyRussG|mostly>	 :)
[04:17:54] <awight|err_n_>	 hmm I think he wanted to use a SWAT window
[04:18:00] <awight|err_n_>	 for enhanced WMF support
[04:18:02] <AndyRussG|mostly>	 Mmm
[04:18:05] <awight|err_n_>	 not sure though
[04:18:33] <AndyRussG|mostly>	 I could do the European Mid-Day SWAT, especially if it were deployed at 6:20 PST rather than 6:00
[04:18:59] <awight|err_n_>	 I'm sure you're welcome to push it out however you want, with the usual caveats about owning any clean-up...
[04:19:37] <AndyRussG|mostly>	 heheh
[04:19:43] * AndyRussG|mostly checks bank account for cleanup pesos
[04:19:44] <awight|err_n_>	 what is the euro mid-day swat, 0600 Pacific?
[04:19:47] <AndyRussG|mostly>	 yeah
[04:20:08] <awight|err_n_>	 I think that's what ejegg|away signed up for, lemme see
[04:20:16] <awight|err_n_>	 sorry, I feel like a rubber duck
[04:20:41] <AndyRussG|mostly>	 Mmm I dunno what other places are affected, other than India. Anyway, by 6 am pst  it's 7 pm there, so I guess not much difference
[04:20:55] <awight|err_n_>	 oh that's strange yeah he's signed up for the brunch one
[04:21:09] <AndyRussG|mostly>	 Mmm ejegg[m] put it on the PST-ish morning SWAT
[04:21:09] <awight|err_n_>	 going early sounds good if you're up for it
[04:21:22] <awight|err_n_>	 lol programmer morning
[04:21:32] <awight|err_n_>	 woke up quick / at about noon
[04:21:32] <AndyRussG|mostly>	 Mmm I'd just dash to the famcy café in front of the kids' school
[04:21:37] <awight|err_n_>	 :)
[04:22:10] * awight|err_n_ smacks foamy milk from upper lip
[04:23:32] <AndyRussG|mostly>	 eh I'm inclined to leave it where ejegg[m] put it unless we get a sign-off from him...
[04:23:54] <awight|err_n_>	 kk that sounds polite as well
[04:24:22] <AndyRussG|mostly>	 awight|err_n_: ooooh fixed! https://googleweblight.com/?lite_url=https://en.wikipedia.org
[04:24:58] <awight|err_n_>	 holy cow--wait what
[04:25:00] <awight|err_n_>	 banner js?
[04:25:04] <awight|err_n_>	 varnish?
[04:25:22] <AndyRussG|mostly>	 the-wub's in-banner doozie must have finally wiggled its way through the Google straws
[04:25:51] <AndyRussG|mostly>	 He did add some in-banner JS to fix it, but it didn't have an immediate effect
[04:26:24] <AndyRussG|mostly>	 I assume because Google does some heavy specific munging of our pages and doesn't check the actual result of BannerLoader that often
[04:26:44] <AndyRussG|mostly>	 Or maybe the Google contact on the e-mail thread purged a cache or something
[04:27:22] <AndyRussG|mostly>	 Oh funny! What they fixed is geolocation!
[04:27:40] <AndyRussG|mostly>	 https://googleweblight.com/?lite_url=https://en.wikipedia.org?country=US
[04:28:14] <AndyRussG|mostly>	 Though also the banner now looks fine
[04:29:13] <AndyRussG|mostly>	 Do u see a banner if you load thru we blight without the country param?
[04:29:43] <AndyRussG|mostly>	 Maybe Google threw 20 engineers in a time machine, gave them a week to study CN, and they came up with this
[04:33:39] <AndyRussG|mostly>	 Huh https://googleweblight.com/?lite_url=https://en.wikipedia.org/wiki/Barack_Obama is still bad
[04:34:02] <AndyRussG|mostly>	 Sez "Optimized 4 hours ago"
[04:34:22] <AndyRussG|mostly>	 But when I click on "Refresh" it becomes all good
[04:35:14] <awight|err_n_>	 (family distractoided)
[04:35:57] <awight|err_n_>	 huh
[04:35:59] <AndyRussG|mostly>	 np :) I'll keep babbling a bit
[04:36:02] <AndyRussG|mostly>	 https://googleweblight.com/?lite_url=https://en.wikipedia.org/wiki/Ike_Altgens
[04:36:07] <AndyRussG|mostly>	 A page that I viewed earlier
[04:36:14] <AndyRussG|mostly>	 Says Optimized 6 hours ago
[04:36:22] <AndyRussG|mostly>	 Looks awful
[04:36:26] <awight|err_n_>	 mega-strange cos as you say, the banner still appears
[04:36:32] <awight|err_n_>	 so it's not just the-wub's fix
[04:36:35] <AndyRussG|mostly>	 Now clicking refresh
[04:36:44] <AndyRussG|mostly>	 Now looks all god
[04:36:46] <AndyRussG|mostly>	 good
[04:36:59] <awight|err_n_>	 It's like having an infinite number of engineers affords the fixing of things
[04:37:29] <AndyRussG|mostly>	 And https://googleweblight.com/?lite_url=https://en.wikipedia.org/wiki/Ike_Altgens?country=US also is bannerless
[04:37:42] <awight|err_n_>	 That form is totally borken though
[04:37:52] <awight|err_n_>	 we still need it to go away
[04:38:07] <AndyRussG|mostly>	 I think it was the-wub's fix + google cache turnover
[04:38:36] <awight|err_n_>	 but... not fixed
[04:38:37] <AndyRussG|mostly>	 Hmmm no maybe not
[04:38:45] <awight|err_n_>	 The Amazon overlay went away but that's it
[04:38:49] <AndyRussG|mostly>	 If you go to https://googleweblight.com/?lite_url=https://en.wikipedia.org do you see a banner?
[04:39:05] <awight|err_n_>	 I don't--so not sure about geolocation fixing
[04:39:15] <AndyRussG|mostly>	 From here in smogopolis I don't
[04:39:26] <awight|err_n_>	 hehe
[04:39:28] <AndyRussG|mostly>	 However if I go to https://googleweblight.com/?lite_url=https://en.wikipedia.org?country=US I do
[04:39:35] * AndyRussG|mostly coughs
[04:39:49] <awight|err_n_>	 I wonder... didn't you say the crawler was US-based?
[04:39:54] <AndyRussG|mostly>	 Yep
[04:40:00] <awight|err_n_>	 I don't understand what's happening, then
[04:40:11] <awight|err_n_>	 other than, the country= parameter forces something that wasn't working
[04:40:26] <awight|err_n_>	 was it previously showing a banner without a country param?
[04:40:30] <awight|err_n_>	 musta been...
[04:40:33] <AndyRussG|mostly>	 Shouldn't force the banner
[04:40:44] <AndyRussG|mostly>	 Yeah it used to always say banner, though when I said country=MX, no banner
[04:40:52] <awight|err_n_>	 harumph
[04:41:08] <awight|err_n_>	 I don't trust a mystery fix ;)
[04:41:12] <AndyRussG|mostly>	 Yep
[04:41:27] <AndyRussG|mostly>	 Maybe it doesn't bother to re-run the JS each time? That'd be damn complex, tho
[04:41:40] <AndyRussG|mostly>	 Only re-runs JS when there's a URL param?
[04:41:44] <awight|err_n_>	 but... then country=us ouldn't work either?
[04:41:47] <awight|err_n_>	 araaargh
[04:42:02] <AndyRussG|mostly>	 I guess it has layers of intricate caching and optimization
[04:42:26] <AndyRussG|mostly>	 So yeah let's go to Varnish to be sure, no?
[04:42:57] <AndyRussG|mostly>	 https://googleweblight.com/?lite_url=https://en.wikipedia.org?country=CA gives me a banner
[04:43:03] <AndyRussG|mostly>	 BTW it's not the same one as earlier
[04:44:09] <awight|err_n_>	 +1!
[04:44:42] <awight|err_n_>	 hehe just telling the kid some night night stories about various times I pooped in my pants
[04:44:48] <awight|err_n_>	 solidarity...
[04:45:27] <awight|err_n_>	 gotta go for a bit
[04:45:54] <AndyRussG|mostly>	 awight|err_n_: cya!
[06:38:57] <grrrit-wm>	 (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/327146
[06:40:54] <grrrit-wm>	 (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/327146 (owner: Eileen)
[06:40:59] <grrrit-wm>	 (CR) jenkins-bot: [] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/327146 (owner: Eileen)
[06:41:01] <grrrit-wm>	 (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/327146 (owner: Eileen)
[06:43:35] <eileen1>	 !log from 76bc6ba8f005c15410b8785c1d5543154187a17f to 454679d201ed59c76a3905cf3ad5ee2d14fef93f
[06:43:45] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[07:07:19] <wikibugs>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Spike: investigate slow queries - https://phabricator.wikimedia.org/T153134#2871779 (Eileenmcnaughton) Not sure I found every slow query but certainly a bunch of them!  https://docs.go...
[07:14:59] <wikibugs_>	 Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 3 others: Civi: restore the 'unsubscribe from spam' option to Main menu - https://phabricator.wikimedia.org/T147571#2696936 (Eileenmcnaughton...
[11:44:23] <wikibugs>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 2 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2872247 (Pcoombe) Good news, I'm no longer seeing a banner at http...
[16:46:33] <mafk>	 Hello. I need help with a central notice
[17:12:48] <dstrine>	 mafk:  I just saw your email. I can't give advice but I can find someone how can help.
[17:13:04] <mafk>	 dstrine: joseph just replied to me :)
[17:13:08] <dstrine>	 ah
[17:13:25] <mafk>	 I'll see if I can fix that later since I'm going out to have my hair cut
[17:13:28] <dstrine>	 ah yeah I just saw that
[17:14:12] <dstrine>	 mafk:  most of the engineers on this chat are just starting their work day. We'll be around if you need help.
[17:14:58] <mafk>	 dstrine: many thanks, I'll check by later here and on the mailing list if I need further help
[17:15:07] <dstrine>	 cool
[17:15:15] <mafk>	 and good morning to the other side of the Atlantic :)
[17:20:27] <grrrit-wm>	 (PS1) Ejegg: Restore year selector [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327234
[17:24:43] <ejegg>	 cwd finally got multi-year campaigns back ^^^
[17:26:25] <cwd>	 cool, will check out
[17:28:50] <cwd>	 last version of the vagrant patch actually gets the service running
[17:29:17] <cwd>	 however the nodejs process in the VM makes my laptop overheat
[17:46:41] <wikibugs>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 2 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2873141 (Ejegg) Thanks! We're rolling out the patch to treat webli...
[18:00:03] <slander>	 fr-tech: A hacker does for love what others would not do for money.
[18:00:03] <slander>	  -- discuss.
[18:57:15] <cwd>	 ejegg: how did you go about getting to vagrant:8880 for the dash?
[18:58:14] <ejegg>	 cwd I just specified the port forwarding in  puppet/modules/role/settings/fundraising.yaml
[18:58:26] <ejegg>	 then browse to localhost:8880
[18:59:30] <cwd>	 ah groovy, ty
[19:02:23] <cwd>	 ejegg: what does that config look like? general puppet thing or fr specific?
[19:03:16] <awight>	 ejegg: heads up that Eran is trying to schedule an early EST meeting with you
[19:03:20] <awight>	 resist :)
[19:03:37] <ejegg>	 awight: heh, sounds like 10:30 EST, think I can handle that
[19:03:55] <ejegg>	 cwd
[19:04:01] <ejegg>	 forward_ports:
[19:04:12] <ejegg>	     8880: 8080
[19:04:17] <ejegg>	 oops, no
[19:04:22] <ejegg>	     8080: 8880
[19:04:32] <ejegg>	 vagrantport: hostport
[19:04:49] <cwd>	 is that a setting that gets slurped up by virtualbox?
[19:05:48] <ejegg>	 not sure exactly what's responsible for applying those
[19:05:59] <ejegg>	 but it's across all the roles
[19:06:24] <cwd>	 oh so you still run dash on 8080 ?
[19:07:19] <awight>	 I think vagrant applies that stuff
[19:07:34] <awight>	 I couldn't run dash on 8080 cos that's where apache is listening
[19:07:54] <cwd>	 if i run it on 8880 shouldn't i be able to get at that with one of the wmftest urls?
[19:08:16] <awight>	 not without poking a hole in the network
[19:08:53] <cwd>	 aah
[19:25:37] <wikibugs>	 Fundraising Dash: Dash not rendering for Megan or I - probably date format related - https://phabricator.wikimedia.org/T153229#2873546 (MarcoAurelio)
[19:27:28] <cwd>	 http://fakeupdate.net/windows98/index.html
[19:29:44] <cwd>	 ejegg: after provision i still get crm on localhost:8080
[19:30:14] <ejegg>	 cwd what about localhost:8880 ?
[19:30:49] <cwd>	 connection refused
[19:30:58] <cwd>	 maybe i have them backwards
[19:31:03] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Special:RecordImpression shouldn't be a blank page - https://phabricator.wikimedia.org/T153228#2873557 (DStrine)
[19:31:14] <ejegg>	 hmm
[19:31:15] <cwd>	 cause dash is running on 8880
[19:31:28] <ejegg>	 oh, you added that to settings?
[19:31:33] <cwd>	 awight: you are a vim user right? this has been rocking my world: https://github.com/vimwiki/vimwiki
[19:31:44] <cwd>	 it's like org mode lite, for vim
[19:31:49] <cwd>	 ejegg: yeap
[19:32:14] <ejegg>	 ooh, cool
[19:32:19] <cwd>	 i'll try without that
[19:32:41] <cwd>	 yeah it's the best to-do list thing i've ever used
[19:32:56] <ejegg>	 cwd if you telnet in inside vagrant, does it connect to the expected port?
[19:33:23] <cwd>	 telnet to localhost?
[19:33:48] <cwd>	 yeah it connects
[19:36:27] <cwd>	 guessing something in the role module sets those forwarded ports
[19:37:14] <awight>	 cwd: wat IS that
[19:37:49] <wikibugs_>	 Fundraising-Backlog, fundraising-tech-ops, Mail, Office-IT: Create email alias for benefactors@ - https://phabricator.wikimedia.org/T152641#2855852 (demon) Just a few meta notes about the interactions I saw here because I was asked to weigh in... * I think some people were being overly condescend...
[19:40:07] <ejegg>	 cwd and vagrant said it was setting up the expected forwarding when you provisioned?
[19:41:12] <cwd>	 trying some things
[20:06:48] <Krinkle>	 Just got a banner on en.wikipedia.org where 'close' didn't work. it triggered an error for "Method 'hide' undefined.". Came from an element with "fundraisingBanner.hide()" called from onclick. Evaluating fundraisingBanner on that page reveals an object with countryNames: Object, paymentMethod: '', paymentSubMethod: '', .. ), but no hide method.
[20:06:56] <Krinkle>	 It came from "B1617 121413 en6C dsk p2 sm txt ign" which has a "close" button in the middle below the banner
[20:07:03] * awight hides in sand
[20:07:07] <Krinkle>	 Looks like that may be old copy-paste code that no longer works.
[20:08:12] <ejegg>	 the-wub: ^^
[20:08:37] <awight>	 Krinkle: Thanks, I've filed it as T153240 for now
[20:08:37] <stashbot>	 T153240: Banner close button throws javascript error - https://phabricator.wikimedia.org/T153240
[20:10:29] <ejegg>	 Krinkle: interesting, I got the js error, but the banner did hide. Did it remain visible for you? Which browser?
[20:15:10] <Krinkle>	 ejegg: It did hide indeed, for me as well.
[20:15:26] <Krinkle>	 presumably because there is another on(click) handler attached in addition to the onclick="...hide(); retrn false" code
[20:15:32] <ejegg>	 k, I'll note that on the ticket
[20:16:34] <wikibugs>	 Wikimedia-Fundraising: Banner close button throws javascript error - https://phabricator.wikimedia.org/T153240#2873790 (Ejegg) 15:10 < ejegg> Krinkle: interesting, I got the js error, but the banner did hide. Did it remain visible for you? Which browser? 15:15 < Krinkle> ejegg: It did hide indeed, for me as...
[20:26:13] <grrrit-wm>	 (PS1) Ejegg: Change major donation cutoff to $1,000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327284 (https://phabricator.wikimedia.org/T152031)
[20:26:45] <wikibugs_>	 Fundraising Dash, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Patch-For-Review: Dash: change the "Totals Earned " widget cutoff to default to $999 - https://phabricator.wikimedia.org/T152031#2873911 (Ejegg) a:Ejegg
[20:39:47] <AndyRussG>	 ejegg: thanks for doing the deploy and beta cluster testing!! rrrg I spaced out, it overlapped with the Front-end standards meeting (which turned out to be a fun discussion about the December outages...)
[20:41:00] <ejegg>	 AndyRussG: no worries
[20:41:20] <ejegg>	 still waiting for it to trickle through the various cache stages, as of 10 minutes ago
[20:42:14] <AndyRussG>	 Mmm I imagine.... just pulling some data from yesterday and today (to see also how much of an effect the banner edits had)
[20:43:04] <wikibugs_>	 Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Banner close button throws javascript error - https://phabricator.wikimedia.org/T153240#2873940 (AndyRussG)
[20:52:31] <ejegg>	 sorry fr-tech, switching over to tethered network
[20:59:56] <wikibugs>	 Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Banner close button throws javascript error - https://phabricator.wikimedia.org/T153240#2874050 (Pcoombe) Open>Resolved Thanks, yeah that was copy-pasted from the wrong banner. Fixed now in the live banners and our template.
[21:01:07] <wikibugs_>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Update audit parser for PayPal Express Checkout - https://phabricator.wikimedia.org/T134605#2874055 (awight) a:awight
[21:01:22] <wikibugs>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Make PayPal listener understand Express Checkout - https://phabricator.wikimedia.org/T130851#2874056 (awight) a:awight
[21:01:39] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Avoid the increasing lenght of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2874060 (DStrine)
[21:01:48] <wikibugs_>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Avoid the increasing lenght of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2873532 (DStrine) p:Triage>Normal
[21:02:33] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Avoid the increasing length of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2874063 (Reedy)
[21:02:43] <wikibugs_>	 Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Fail mail on 'city is too long' - https://phabricator.wikimedia.org/T152022#2874068 (awight) a:Eileenmcnaughton
[21:24:28] <cwd>	 gotta go get a PO box!
[21:29:48] <awight>	 Are you sure you bought a house?
[22:06:33] <cwd>	 awight: there is no mail service here. i was thinking about that, isn't it like my right as an american to get mail delivery?
[22:13:01] <awight>	 I really enjoyed having "general delivery" in Cape Cod
[22:13:09] <wikibugs_>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Spike: Spike: Turning on geocoding for proximity searches - https://phabricator.wikimedia.org/T136901#2874454 (Ejegg) Open>Resolved a:Ejegg Oh hey, we did this as part of T86239!
[22:13:26] <awight>	 The post office staff was great, and gave me lots of help sending out my crazy pamphlets
[22:13:43] <awight>	 like: never ever put the address in portrait orientation
[22:13:47] <cwd>	 the post office here is adorable, it's the old train station
[22:13:49] <awight>	 it costs extra.
[22:13:56] <awight>	 do Gen Deliv!
[22:14:12] <awight>	 I guess PO is the same thing but without the line and the quaint dialogue
[22:14:24] <cwd>	 plus you dont have to give out your address
[22:15:10] <awight>	 you 'noid
[22:15:15] <ejegg|food>	 poste restant
[22:15:19] <cwd>	 https://upload.wikimedia.org/wikipedia/en/1/1f/US_Post_Office,_Glorieta,_New_Mexico,_USA.jpg
[22:15:24] <awight>	 XenoRyet: want to chat about PP EC?
[22:15:37] <cwd>	 that wikipedia site has got it all
[22:15:47] <awight>	 cwd: that's rad
[22:18:09] <XenoRyet>	 awight: Sure
[22:18:46] <awight>	 cool, I'm in https://hangouts.google.com/hangouts/_/wikimedia.org/fr-tech-talk
[22:19:03] <XenoRyet>	 k, let me find my headphones and I'll be right in.
[22:22:59] <wikibugs_>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2874499 (awight)
[22:23:43] <cwd>	 bedbugs at the office D:
[22:24:02] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Debug gateway account name handling - https://phabricator.wikimedia.org/T130852#2874503 (awight)
[22:24:05] <wikibugs_>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2127476 (awight)
[22:24:06] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#2874505 (awight)
[22:24:08] <wikibugs_>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2874502 (awight)
[22:24:19] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2874507 (awight)
[22:24:22] <wikibugs_>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2127476 (awight)
[22:27:11] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 6 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2874527 (awight) We still need to feed a...
[22:31:50] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#2874551 (awight)
[22:31:52] <wikibugs_>	 Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#2874550 (awight) Open>Resolved
[22:37:52] <wikibugs_>	 Fundraising-Backlog, FR-Worldpay: Duplicate charge detection in audit parsers - https://phabricator.wikimedia.org/T117639#2874583 (Ejegg) Open>declined Closing because of processor
[22:47:30] <wikibugs_>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#2874616 (awight)
[22:47:32] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#2874615 (awight) Resolved>Open
[22:47:39] <wikibugs_>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#2179357 (awight)
[22:47:41] <wikibugs>	 Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#1493671 (awight)
[22:48:59] <Seddon>	 cwd: I reckon the previous inspector introduced them to the office as a scam :P
[22:49:38] <cwd>	 devious
[22:49:52] <cwd>	 RICO case
[22:49:56] <Seddon>	 cwd: its what I would do :P
[22:51:20] <awight>	 here's your "magic backpack"
[22:51:22] <awight>	 for emergencies
[22:52:00] <awight>	 inbox < 10  !
[23:01:13] <eileen2>	 ejegg: I've been working Mondays for WMF in order to cover your Sundays - am expecting to next week but you are down for on-call. I can cover that
[23:04:34] <ejegg>	 eileen2: yeah? It's no trouble for me!
[23:04:54] <ejegg>	 I can take the earlier part, at least
[23:05:39] <eileen2>	 ejegg: ok yeah it's been a kind of late-in-the day coverage I've been doing
[23:06:04] <ejegg>	 cool, thank you!
[23:06:35] <ejegg>	 I'll update the collab page
[23:34:57] <grrrit-wm>	 (Abandoned) Paladox: Add package modern-syslog [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280665 (owner: Paladox)
[23:35:04] <grrrit-wm>	 (Abandoned) Paladox: Update the packages [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280688 (owner: Paladox)
[23:43:49] <wikibugs_>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Special:RecordImpression shouldn't be a blank page - https://phabricator.wikimedia.org/T153228#2873497 (AndyRussG) @MarcoAurelio Thanks for flagging this! Special:RecordImpression used to be the endpoint that CentralNotice called to record banner i...