[00:00:55] (PS1) Ejegg: WIP clean up subscriptions and timers [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327397 (https://phabricator.wikimedia.org/T152722) [00:33:40] (PS1) Ejegg: WIP top 10 days / hours [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [00:35:26] Fundraising Dash, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Patch-For-Review: Top days / top hours widget - https://phabricator.wikimedia.org/T152028#2874982 (Ejegg) a:Ejegg [00:50:43] (PS2) Ejegg: WIP top 10 days / hours [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [04:33:33] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2875320 (AndyRussG) Just checking the impression data in Hive... I... [05:00:20] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2875510 (AndyRussG) >>! In T152602#2875320, @AndyRussG wrote: > It... [14:45:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make CRM version stamp thing robust on dev boxes - https://phabricator.wikimedia.org/T88376#2876470 (Aklapper) @Awight: Removing #easy tag. Feel free to re-add once a task description is provided that allows a new contributor to understand how and what... [15:01:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM quicksearch has annoying key behavior - https://phabricator.wikimedia.org/T111128#2876502 (Aklapper) [15:07:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove "getInfo" methods from CRM test classes - https://phabricator.wikimedia.org/T105769#2876525 (Aklapper) @awight: Removing #easy tag. Feel free to re-add once a task description is provided that allows a new contributor to understand where to find... [15:08:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deprecate wmf_unsubscribe module - https://phabricator.wikimedia.org/T115066#2876527 (Aklapper) @awight: Removing #easy tag. Feel free to re-add once a task description is provided that allows a new contributor to understand where to find that code. (Ze... [15:13:45] Fundraising-Backlog: Do not log CC exp date - https://phabricator.wikimedia.org/T86234#2876555 (Aklapper) >>! In T86234#1726481, @awight wrote: > The code in question is in DonationInterface/worldpay_gateway That got removed in https://phabricator.wikimedia.org/rEDOI34ceb2910c3a0ef4a36e49f41ac18a19db5757aa... [15:19:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: BUG: Campaign date fields cannot be edited as text - https://phabricator.wikimedia.org/T97159#2876581 (Aklapper) @awight: Can you please answer @amritsreekumar's question? [17:50:08] ejegg: and XenoRyet|afk you down to talk to adyen in ~10 minutes? [17:50:31] Oh, forgot to turn off my afk. Yea, I'm here and down to talk. [17:51:12] Is the link in the meeting invite the one we're using? [17:52:17] yep! [17:53:32] XenoRyet: yeah it's a hangout [17:55:27] Good times [19:16:03] meganhernandez: do any of the widgets work for you, or is the dash broken on every board? [19:27:18] sorry, didn't realize you were about to preset! [19:27:55] Thank you for the stabilization shout-out [19:44:21] XenoRyet: dow e have the Adyen CA form for testing? [19:44:34] Sorry I dont think I've seen this sent aorund [19:45:09] ppena: Yes, it was deployed on Monday. [19:45:30] XenoRyet: yes i've heard :) can I have the link pls?? [19:45:49] Oh, misunderstood the question. Yea, let me dig up a link. [19:48:02] ppena: https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&language=en&country=CA&payment_method=cc&gateway=&amountGiven=¤cy_code=USD&amount=3 [19:48:06] That should get you there. [19:55:33] thanks [20:17:52] (PS3) Ejegg: WIP top 10 days / hours [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [20:18:52] (PS2) Ejegg: Change major donation cutoff to $1,000 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327284 (https://phabricator.wikimedia.org/T152031) [20:31:14] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878065 (AndyRussG) Hmmm, the numbers are down substantially (abou... [20:32:51] XenoRyet|brb dstrine-lunch just got a friend t test the Adyen CA form, but looks like its processing in USD? [20:33:10] see 45172422.0 [20:36:06] (PS4) Ejegg: WIP top 10 days / hours [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [20:38:34] hi ejegg big english is not working [20:38:44] i just did a search by month in the dash and that did work [20:38:56] and thank you for the stabilization [20:43:50] meganhernandez: so the x-by-y widget is working OK? [20:44:20] ppena: Ah, looks like that link had USD in it [20:44:41] :( [20:44:44] that’s what you see when you first open the dash without clicking anything on the left? [20:45:39] ejegg: has anyone tested CAD? I'm not sure my tester will want to test again... [20:48:13] AndyRussG: got any friends in canada who might want to help out [20:48:19] meganhernandez: depends what you've put on your default dashboard - maybe we can do a screenshare some time later today and figure this out? [20:48:32] I'm just starting tech standup [20:48:44] ah oops I'm late! [20:48:50] dstrine: I have a VPS in Toronto [20:48:51] ok thanks ejegg [20:48:54] ppena: I haven't yet [20:49:10] ah, nice AndyRussG [20:49:45] awight: standup? [20:49:56] * awight bangs top of TV set [20:50:14] ejegg: dstrine XenoRyet ok... Is it just changing from USD to CAD on the form? Is everything else ready in the back end to test CA CAD? Pls confirm so I can try again... [20:50:40] I think we just need to change that URL XenoRyet pasted above [20:51:03] ppena: Yea, I just flubbed the link, sorry about that. [20:51:15] ok will re-try [20:52:59] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2828393 (Pcoombe) I guess it needs similar styles to T149249. Screenshots for reference. Adyen: {F5062850} Ingenico: {F5062852} [20:54:37] hey ppena, sorry but there's an issue with adyen on mobile - https://phabricator.wikimedia.org/T151795. probably a blocker there, as it will affect results. I think we can go ahead with desktop though [20:56:31] the-wub: I see... yeah lets do just Desktop today then and see when David can get that phab in ... thanks the-wub [20:56:58] dstrine: anyways we can re-prioritize this? https://phabricator.wikimedia.org/T151795#2828393 [21:08:24] dstrine: XenoRyet ejegg my CAD trnxs was sent for settle, so it went through. My friend's Canadian card (although processed in USD) also made though. I think we should be good to go for donor test? [21:09:01] Yea, should be good to go. [21:10:17] so 1 hr CAD Adyen is a go? when will it start? [21:11:03] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878164 (AndyRussG) BTW, I'm not seeing any banners on pages I vis... [21:17:03] the-wub: Can we add a Canada test as well the wub, or would we need more prep? [21:19:17] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2878180 (DStrine) a:cwdent [21:19:28] ppena: no, that needs more prep [21:19:56] the-wub: ok thanks. Maybe for early next week then? MBeat today just USD :) [21:20:07] cool, ty [21:28:18] ppena: cwd is going to look at T151795 [21:28:19] T151795: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795 [21:29:18] ejegg: is this a stylesheet that we host or do we have to upload it? [21:30:54] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878224 (Ejegg) The JS blacklist is working! Till this morning, r... [21:31:04] cwd we have to upload it [21:31:27] ok ppena MBeat, about to put adyen banners up. will be gathering results here: https://docs.google.com/spreadsheets/d/17arGLTPupnrCmo7O0He38js-gmOoF3OY53sOwiAbAp0/edit#gid=2078717913 [21:31:37] ty the-wub [21:31:48] nuts [21:31:49] the-wub: awesome-thanks much! [21:32:17] cwd we keep a copy in git in sync with the uploaded version [21:32:41] And you can upload a beta version that you request with an alternate skin code [21:32:50] we're up [21:33:22] ah yeah i remember that [21:33:50] the-wub: I see that the Adyen and GC forms also dont match on desktop. Should we just enable mbile as well in that case? [21:34:50] ppena: they don't match. but on mobile it's worse because of the grey background and grey fields [21:35:22] hmmmm [21:35:37] ok [21:37:52] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 3 others: Civi: restore the 'unsubscribe from spam' option to Main menu - https://phabricator.wikimedia.org/T147571#2878235 (MBeat33) Thank... [21:38:16] also lol "just" enable mobile. I wish it was so easy :( [21:43:09] the adyen iframe on mobile is also brutally slow to load [21:43:18] needs a spinner or something [21:43:51] it's weird how it renders with a blind-down type effect [21:46:37] if we had next level PCI compliance we could really improve the donor experience here [21:56:13] the-wub: do you know of a way to force the adyen iframe to go mobile on desktop? [21:56:23] i notice it uses device-width [21:57:45] cwd: https://developers.google.com/web/tools/chrome-devtools/device-mode/ is what I use [21:58:25] aah groovy, thanks! [22:17:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi unresponsive for Engage in evenings - https://phabricator.wikimedia.org/T152786#2878484 (DStrine) p:Triage>High [22:21:13] Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 3 others: Civi: restore the 'unsubscribe from spam' option to Main menu - https://phabricator.wikimedia.org/T147571#2878530 (Eileenmcnaughton... [22:27:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi unresponsive for Engage in evenings - https://phabricator.wikimedia.org/T152786#2878565 (LeanneS) Please see the latest update from Engage today: I am writing regarding a few errors we are encountering when processing in Civi. The movie and image... [22:35:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi unresponsive for Engage in evenings - https://phabricator.wikimedia.org/T152786#2878601 (Jgreen) Could somebody text me the next time this happens? My cell is on the collab wiki fundraising contacts page. Looking at database activity while it's h... [23:02:11] (PS1) Cdentinger: Adyen iframe form fields should be white on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/327661 (https://phabricator.wikimedia.org/T151795) [23:03:50] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878773 (Pcoombe) Thanks for all the help everyone! The random con... [23:11:14] cwd: Should I try to reinstall the vagrant box from scratch yet, or are there still known blockers? [23:12:02] awight: i think ejegg saw the problem, i've been screwing with css but i'll fix that shortly [23:12:18] awight: single char fix [23:12:25] s/8080/8880 [23:13:02] i swear i tried that but i'll make sure [23:15:05] haha [23:19:49] eileen1: I still can't reproduce the dash failure, despite setting browser and desktop locale to en_NZ. mhernandez said it only broke the big english board for her, not the x-by-y widget that has the code in your phab comment. Can you try it in chrom(e|ium) with 'break on exceptions' and pretty-printing the minified thing? [23:25:11] ejegg: I'll give it a go later on [23:25:59] thanks! I've been scouring the code for date assumptions, but there's not much that cares about month anywhere but server-side [23:44:07] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Make PayPal listener understand Express Checkout - https://phabricator.wikimedia.org/T130851#2878919 (awight) Note: the first charge is actually done explicitly on our end, so looks exac... [23:45:02] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 6 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2878922 (awight) We're never reaching th... [23:48:14] wow this time provision pegged my cpus and froze my computer [23:49:51] niiice [23:49:58] the entire chromebook? :p [23:50:32] :| [23:59:54] Fundraising-Backlog, FR-Paypal, FR-WMF-Audit: Re-import PayPal audit files for Dec 9-12 when they're available - https://phabricator.wikimedia.org/T153382#2878959 (awight)