[00:00:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Blank address data being collected & stored as an address - https://phabricator.wikimedia.org/T153804#2891633 (Eileenmcnaughton) [00:03:22] ejegg: does the idea that we might be saving blank addresses for paypal ring any bells. Our dedupe rule was that a more recent address is always more valid - but we didn't consider that we might save entirely blank addresses [00:03:38] d'oh! [00:03:53] I hadn't come across that before [00:04:19] yep bit sucky! [00:05:03] & probably not a totally old regression based on the numbers https://phabricator.wikimedia.org/T153804 [00:19:32] (CR) Ejegg: "Looking good so far, and I bet we can re-use this code for T146309." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:24:17] Fundraising-Backlog, FR-Paypal, FR-Smashpig, Recurring-Donations: When PayPal recurring donor changes their PP profile contact, update the email address in CRM - https://phabricator.wikimedia.org/T146309#2657013 (Eileenmcnaughton) Can you describe the process here? ie. is this a case of someone l... [00:25:07] (CR) Ejegg: [C: 1] "Looks really good! Only nitpick is the PHPdoc" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:26:19] Fundraising-Backlog, FR-Paypal, FR-Smashpig, Recurring-Donations: When PayPal recurring donor changes their PP profile contact, update the email address in CRM - https://phabricator.wikimedia.org/T146309#2891668 (Ejegg) I think PayPal will just include the updated donor details in the next subscr... [00:27:22] (CR) Eileen: Create & use location update function in the scenarios where we are updating. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:29:23] (PS2) Eileen: Create & use location update function in the scenarios where we are updating. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) [00:29:32] I made those comment changes [00:31:06] (CR) Ejegg: [C: 2] Create & use location update function in the scenarios where we are updating. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:31:57] (CR) Ejegg: [C: 2] Rename location_update functions to indicate they are insert. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328119 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:32:29] (CR) Ejegg: [C: 2] Extend test to ensure double addresses not created. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328118 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:35:57] (CR) jerkins-bot: [V: -1] Extend test to ensure double addresses not created. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328118 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:35:59] (CR) jerkins-bot: [V: -1] Rename location_update functions to indicate they are insert. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328119 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:36:01] (CR) jerkins-bot: [V: -1] Create & use location update function in the scenarios where we are updating. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [00:40:05] eileen1: you may need to squash those together [00:48:39] sigh, when using the adyen test site this css affects a full size non-mobile browser window: https://gerrit.wikimedia.org/r/#/c/327661/1/adyen_gateway/forms/iframe/css/screen.css@315 [00:48:58] i could have sworn when testing locally it differentiated properly [00:52:38] ejegg: but I LIKE multiple small commits :-) [00:53:00] - normally if the one at the end of the dependency chain passes it goes through but.... [00:55:19] (PS3) Eileen: Create & use location update function in the scenarios where we are updating. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) [00:56:31] (PS4) Eileen: Create & use location update function in the scenarios where we are updating. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328120 (https://phabricator.wikimedia.org/T152475) [00:57:30] eileen1: really? I'd never been able to make that work in gerrit [00:59:06] I didn't imagine it I promist [01:11:30] cwd oh man, so all of that max-width section could just go in the normal css, and just the bit you're changing could go in a max-device-width section [01:15:06] ah ok, let me try that [01:21:42] ejegg: brilliant, thanks [01:23:09] (PS2) Cdentinger: Adyen iframe form fields should be white on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/327661 (https://phabricator.wikimedia.org/T151795) [01:26:18] (PS4) Ejegg: Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 [01:30:52] (PS5) Ejegg: Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 [01:33:03] Fundraising-Backlog, FR-Paypal, FR-Smashpig, Recurring-Donations: When PayPal recurring donor changes their PP profile contact, update the email address in CRM - https://phabricator.wikimedia.org/T146309#2891741 (Eileenmcnaughton) I think the code maybe does that. It was probably creating a dupli... [01:35:39] k, i'm outtaMeanwhile many of us keep looking for some gleam of … something to brighten the insomniac nights. Perhaps the ascendancy of liars and truth-deniers will inspire Americans to become more vigilant, more alert to the malignantly proliferating lies of euphemistic language, lies of omission, lies that normalize the rise of a president with no regard for, or knowledge of, the US constitution, that most precious and beautiful of document [01:36:03] blah, sorry for the copyright infringment Guardian [01:36:15] amen [01:36:22] and for the politics on social? media Jeff Elder [01:36:32] middleclick [01:36:44] anyhoo [01:36:50] I'm taking off for the evening! [01:37:02] have a good one! [01:37:16] thanks [02:15:13] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2891797 (AndyRussG) Hi! It looks like this is mobile network issues causing CN to not display banners and/or not rep... [10:21:27] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: en6C_dsk_FR campaign: Bucket D behind in impressions - https://phabricator.wikimedia.org/T152662#2892819 (Pcoombe) Open>Resolved Seems like this mystery is solved. Thanks for the Hive digging! [10:31:21] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Paypal, Spike: PayPal recurring flow is not mobile optimised - https://phabricator.wikimedia.org/T153596#2892845 (Pcoombe) :( The good news is that Express Checkout appears to have a more mobile-friendly recurring flow e.g. https://d... [16:36:48] (CR) Cdentinger: [C: 2] Fix client-side $/sec calculation. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328291 (owner: Ejegg) [16:38:27] (Merged) jenkins-bot: Fix client-side $/sec calculation. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328291 (owner: Ejegg) [16:41:54] (CR) Cdentinger: "Needs manual rebase. Since this isn't a MW project we probably aren't beholden to all the extraneous whitespace, though tbh it doesn't bot" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328235 (owner: Ejegg) [16:42:12] (PS6) Ejegg: Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 [16:42:24] cwd rebased ^^ [16:42:44] yeah, I just wanted to pick some standard and go with it [16:42:59] cool [16:43:01] thanks [16:43:36] huh, I thought we had jshint running in CI [16:43:46] is that what would complain about the missing ;'s? [16:43:53] oh hah, npm test: Error: no test specified [16:44:13] this one looks good now: https://gerrit.wikimedia.org/r/#/c/327661/ - however i think we have to deploy code since the signature will change? [16:44:19] yep, that would have found it [16:45:09] cwd we should be able to update the current production skin, right? [16:45:27] we're already using the newer HMAC algorithm, I'm pretty sure [16:46:26] oh ok, i was thinking it would change with each revision [16:46:49] (CR) Ejegg: [C: 2] "Looks good to me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/327661 (https://phabricator.wikimedia.org/T151795) (owner: Cdentinger) [16:46:58] thanks! should i publish? [16:47:13] please do! [16:48:21] love how the live changes are performed from the test console [16:48:47] (Merged) jenkins-bot: Adyen iframe form fields should be white on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/327661 (https://phabricator.wikimedia.org/T151795) (owner: Cdentinger) [16:51:06] ok it's live! looks quite a bit better [16:52:47] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2828393 (cwdent) This is deployed and looks better to me, but I'll... [16:53:41] the-wub: want to take a look at the mobile adyen iframe? should look more like ingenico now, but would like your opinion [17:02:07] (Abandoned) Ejegg: Fix WS and method name typo [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328235 (owner: Ejegg) [17:02:17] (CR) Cdentinger: "It seems like there should be a way to do this with table structure, like a unique index on name+description?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327792 (owner: Ejegg) [17:05:11] (CR) Ejegg: "Hmm, only one board per user with the same name? Seems reasonable, but we really need to spec out what we want with sharing." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327792 (owner: Ejegg) [17:25:52] (PS7) Ejegg: Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 [18:00:08] fr-tech: It's lucky you're going so slowly, because [18:00:09] you're going in the wrong direction. [18:00:09] -- discuss. [18:14:16] oh man, jscs compliance is a rabbit hole [18:23:26] awww [18:23:44] looks nasty [18:54:18] (PS1) Ejegg: Fix npm test, add jscs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328558 [18:58:05] (PS2) Ejegg: Fix npm test, add jscs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328558 [18:58:29] so... anyone up for some superfun code style review? [18:59:29] fr-tech ^^ [18:59:56] do you promise it'll be superfun? [19:00:13] incredibly thrilling! [19:00:37] more like superfund amirite [19:00:41] haha [19:01:03] ;p [19:01:06] heh [19:13:47] fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2894223 (Jgreen) This is fixed as specified. Regarding heretical URLs if people want to change that please poke in a separate ticket. [19:13:55] fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2894225 (Jgreen) Open>Resolved [19:21:08] fundraising-tech-ops: upgrade all frack servers to debian/jessie - https://phabricator.wikimedia.org/T146479#2894246 (Jgreen) [19:21:10] fundraising-tech-ops: frack jessie integration cleanup - https://phabricator.wikimedia.org/T138222#2894244 (Jgreen) Open>Resolved this is for the most part done [19:44:24] fr-tech actually, will anyone mind if I self-merge those dash code style & typo fixes? [19:44:56] seeing as how it's our lowest-risk component, and they'll go stale really fast [19:45:40] Seems ok to me. Really low risk. [19:46:57] pretty hard to effectively review anyway, but test pass, which is a good indicator [19:47:30] yep, widgets still seem to work [19:47:37] think I smoke tested all of em [19:48:41] yeah, loaded 'em all [19:49:42] k, breaching protocol [19:49:59] (CR) Ejegg: [C: 2] Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 (owner: Ejegg) [19:50:07] (CR) Ejegg: [C: 2] Fix npm test, add jscs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328558 (owner: Ejegg) [19:55:07] (CR) Ejegg: [C: 2] Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 (owner: Ejegg) [19:56:17] (Merged) jenkins-bot: Clean up some ununsed stuff, fix WS [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327843 (owner: Ejegg) [19:58:03] (Merged) jenkins-bot: Fix npm test, add jscs [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328558 (owner: Ejegg) [20:08:38] (PS10) Ejegg: Top 10 days / hours widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [20:09:22] (CR) Ejegg: "PS10: rebase around WS cleanup" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) (owner: Ejegg) [20:10:13] (CR) jerkins-bot: [V: -1] Top 10 days / hours widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) (owner: Ejegg) [20:11:35] (PS11) Ejegg: Top 10 days / hours widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [20:13:25] (Abandoned) Ejegg: Patch for bartik font change [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/297638 (owner: Ejegg) [20:13:54] (Abandoned) Ejegg: Remove some unused and redundant i18n keys [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg) [20:15:58] (Abandoned) Ejegg: WIP convert form settings for PaymentMethodFilter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215085 (owner: Ejegg) [20:35:03] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2894489 (cwdent) Open>Resolved [20:35:42] fr-tech: I'm getting the kind of weather here that has historically had a pretty high chance of power loss and I'm getting some flickering. If I up and dissapear, that's what happened. [20:35:54] stay safe [20:36:33] It's just a moderate amount of rain really, but we have to deal with it so infrequently that infrastructure is more vulnerable to it than in should be. [20:37:04] big winds too? [20:37:28] Yea, some. Though again nothing that would phase anyone from a place where they get real weather. [20:37:50] heh [20:37:58] (PS2) Ejegg: WIP clean up subscriptions and timers [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327397 (https://phabricator.wikimedia.org/T152722) [20:39:30] it has been cold and windy here for quite awhile [20:39:48] week old snow on the ground, i keep thinking it's going to melt but then it just stays cold out [20:40:34] (CR) jerkins-bot: [V: -1] WIP clean up subscriptions and timers [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327397 (https://phabricator.wikimedia.org/T152722) (owner: Ejegg) [20:41:35] (PS3) Ejegg: WIP clean up subscriptions and timers [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327397 (https://phabricator.wikimedia.org/T152722) [20:50:24] (PS4) Ejegg: Clean up subscriptions and timers [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327397 (https://phabricator.wikimedia.org/T152722) [20:52:02] * ejegg 's dash spaghetti code is coming back to haunt him [21:06:53] (PS1) Ejegg: Delete a few more useless things [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328573 [21:14:21] (CR) Ejegg: "billing address-level2 is actually the autocomplete code for the 'city' field, which is 64 chars in Civi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324550 (https://phabricator.wikimedia.org/T152022) (owner: Ejegg) [21:14:29] (PS2) Ejegg: Add 'maxlength' attributes to personal info fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324550 (https://phabricator.wikimedia.org/T152022) [21:14:44] cwd is that one OK ^^ [21:15:59] ah yeah, looks fine [21:16:18] i'll C once it has V [21:23:41] (CR) Cdentinger: [C: 2] Add 'maxlength' attributes to personal info fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324550 (https://phabricator.wikimedia.org/T152022) (owner: Ejegg) [21:25:07] (Merged) jenkins-bot: Add 'maxlength' attributes to personal info fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324550 (https://phabricator.wikimedia.org/T152022) (owner: Ejegg) [21:50:07] whew, this tokenized payment stuff is hard to wrap my head around [22:05:29] XenoRyet|fud: I rebased that top10 widget around the cleanup: https://gerrit.wikimedia.org/r/327401 [22:05:38] ready for review [22:16:03] oh hey, i need to eat [22:16:32] 10-4 [22:46:46] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2894854 (AndyRussG) I tried to get data by region about network quality, but so far it doesn't correlate with impres... [22:59:09] Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, and 7 others: Investigate the discrepancy between pageview counts and banner impressions for ... - https://phabricator.wikimedia.org/T145565#2894872 [22:59:11] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 7 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2894870 (AndyRussG) [23:01:45] Fundraising Sprint Qwerty Thwacking, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, and 7 others: Investigate the discrepancy between pageview counts and banner impressions for ... - https://phabricator.wikimedia.org/T145565#2894881 [23:09:01] Fundraising Sprint Waiting for Godot, Fundraising-Backlog: Items from 2016-12-07 retrospective - https://phabricator.wikimedia.org/T152796#2894888 (ggellerman) [23:29:29] Fundraising Dash, Fundraising-Backlog: de-spaghettify component interaction - https://phabricator.wikimedia.org/T153916#2894946 (Ejegg) [23:32:14] Fundraising Dash, Fundraising-Backlog: de-spaghettify component interaction - https://phabricator.wikimedia.org/T153916#2894968 (ggellerman) p:Triage>Normal [23:33:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: What should we do to fix data where blank addresses have overwritten valid addresses - https://phabricator.wikimedia.org/T153917#2894976 (Eileenmcnaughton) [23:35:14] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 4 others: Impressions slow to update on jaJP dsk campaign - https://phabricator.wikimedia.org/T145446#2895010 (AndyRussG) [23:35:19] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 7 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2895008 (AndyRussG) [23:40:35] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Blank address data being collected & stored as an address - https://phabricator.wikimedia.org/T153804#2895023 (ggellerman) [23:41:13] Fundraising Dash, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-Vagrant, Patch-For-Review: Vagrant: insert test donation data - https://phabricator.wikimedia.org/T153802#2895027 (ggellerman) p:Triage>Low [23:43:03] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Temporarily turn off required "postmark date" until Jan 1 - https://phabricator.wikimedia.org/T152512#2895029 (Ejegg) Open>Resolved [23:43:44] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Spike: investigate current status of paypal express checkout - https://phabricator.wikimedia.org/T149237#2895031 (ggellerman) Open>Resolved [23:45:13] (Abandoned) Eileen: Rename location_update functions to indicate they are insert. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328119 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [23:45:26] (Abandoned) Eileen: Extend test to ensure double addresses not created. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328118 (https://phabricator.wikimedia.org/T152475) (owner: Eileen) [23:49:34] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2895111 (Ejegg) fr-tech want to weigh in on those options ^^^ ? [23:52:59] Fundraising Sprint Value Subtracting, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-2016-17-Q2-Campaign-Support, Spike: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2895135 (ggellerman)