[01:04:46] cwd: trivial vagrant thing to review https://gerrit.wikimedia.org/r/328605 [01:05:16] awight had consolidated the tools requirements.txt when he added tests [01:06:17] Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 4 others: Impressions slow to update on jaJP dsk campaign - https://phabricator.wikimedia.org/T145446#2895339 (AndyRussG) I guess we've bee... [01:06:38] cool, checking it out [01:09:08] yep, reasonable [01:10:58] thanks! [01:24:58] Fundraising Sprint Value Subtracting, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-2016-17-Q2-Campaign-Support, Spike: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2895370 (AndyRussG) Here's an eth... [01:25:51] later, folks! [01:26:20] Fundraising Sprint Value Subtracting, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-2016-17-Q2-Campaign-Support, Spike: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2895371 (AndyRussG) ...and here's... [01:32:52] Fundraising-Backlog, FR-Paypal, FR-Smashpig, Recurring-Donations: When PayPal recurring donor changes their PP profile contact, update the email address in CRM - https://phabricator.wikimedia.org/T146309#2895374 (Eileenmcnaughton) Note that the relevant code is the IF clause here - without this i... [01:43:49] (PS1) Eileen: Do not write address to the database if all data is empty. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/328607 (https://phabricator.wikimedia.org/T153804) [14:19:52] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, and 2 others: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#2896126 (Aklapper) [14:21:07] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, and 2 others: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#406919 (Aklapper) [14:21:27] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, and 2 others: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#406919 (Aklapper) [14:21:51] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n, RTL: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#406919 (Aklapper) @awight: Blocked by T38794 hence not an #easy task. [15:55:13] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2896271 (Pcoombe) Looks good to me. Thanks! [18:00:08] fr-tech: Well, I'm disenchanted too. We're all disenchanted. [18:00:09] -- James Thurber [18:00:09] -- discuss. [18:02:19] When were we ever enchanted? [18:03:09] For tt, if anyone is interested in brainstorming, I'm back to hypothesis-less status with the banners in Ireland ticket [18:03:13] disenchant me too, please! [18:03:15] oooh? [18:04:07] * awight reporting for rubber duckhood [18:04:30] Whle the "Unknown" region did have slow network, it's a total outlier...No other regions with comparable speeds have similar impressions rates, and there's no evidence of correlation netspeed-impressionsrate anywhere else [18:05:06] awight: maybe tt in 5? in case anyone else is around, and also so I can toast some toast ;p [18:05:13] kk [18:06:46] You already sorted through the unknowns to look for correlation with UA, IIRC, so that makes it unlikely that one or two bots are causing the outlying, eh? [18:08:26] awight: wrt UA there's nothing severe, just a gradual dropoff as browser version decreases, for several browsers [18:08:31] The csv is in the task [18:08:45] T152650 [18:08:46] T152650: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650 [18:09:09] https://phab.wmfusercontent.org/file/data/as7kzstuopntcpyhm6dj/PHID-FILE-3zkxyvo6h5gke4jdy6a3/T152650_2016-12-07_mobile_pv-impressions_in_IE_by_platform.csv [18:09:41] I should upload the most recent csv, with netspeed as measured by responseStart (from NavigationTimings) by region throughout the campaign [18:10:18] How do you have ratios > 1? [18:10:44] What's the first column? [18:12:55] ratios > 1 are maybe bots (that were removed from the pageview stats) sending back impressions, or something like that [18:14:25] Ah the first column is just ignore, it was a sequential index added by the python tool that then got out of order [18:15:27] fr-tech tt for more brainstorming about Ireland ticket, if anyone's interested... [18:16:03] This might be tricky to calculate... but if we could check whether the per-UA dropoffs are the same as for other "known" regions in Ireland... [18:16:36] AndyRussG: cwd and I are in the hangout if you wish [18:17:03] if the dropoffs are the same, but UA versions simply lower on average in the "sticks" [18:19:08] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2896629 (AndyRussG) Here's the rough data for the above... See the second sheet and the ugly chart there... {F5134641} [18:31:19] https://en.wikipedia.org/wiki/Ireland#Languages [18:34:27] https://en.wikipedia.org/wiki/Provinces_of_Ireland [19:24:45] XenoRyet: any luck with dash in vagrant? It took me a little while last night to destroy/rebuild/import test data on my backup laptop, but it was showing data for the top 10 widget after that [19:59:48] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Spike: ContributionTracking sometimes fails to insert rows - https://phabricator.wikimedia.org/T153730#2888867 (Ejegg) > If the previous statement retu... [20:13:23] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Spike: ContributionTracking sometimes fails to insert rows - https://phabricator.wikimedia.org/T153730#2896996 (Ejegg) Huh, turns out DonationInterface... [20:19:00] ejegg: i'm thinking through this double charge thing, how exactly does the timeout work? i can see how they might never see the thank you page if it was super slow, but wouldn't the php thread still finish? [20:19:58] cwd yep, the thread would finish, so we'd get the message in civi. But if they reload the page, we don't do any checking to see what state the donation's in. [20:20:15] err, wait, no, we wouldn't necessarily get the message in Civi [20:20:19] but i thought that donation got picked up by the orphan rectifier? [20:20:26] shouldn't it finish in sync? [20:20:27] right, sorry [20:21:01] So, there are two requests, the first just gets a JS frame-busting page [20:21:14] and the second is where we actually push the stuff through [20:21:40] ah ha, and that is two separate requests from the client? [20:21:41] we could move the processing to the first, and do the framebusting and redirect as a single operation [20:21:49] ooh, yeah, we should definitely do that! [20:22:16] yeah that seems like it would plug the leak [20:23:56] making a ticket [20:24:04] groovy [20:24:27] want me to assign it to you? [20:25:43] sure [20:29:29] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2897022 (Ejegg) [20:32:55] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2897040 (Ejegg) a:cwdent Should be fine to do the spinner in a different patch - seems like i... [20:39:35] ejegg: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/globalcollect_gateway/globalcollect_resultswitcher.body.php#L154 interesting comment [20:42:35] cwd hah, K4 thought of everything! [20:46:14] sorry fr-tech, i'll be 3 minutes late to standup [20:55:48] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2897022 (ggellerman) p:Triage>High [20:56:31] (PS1) Cdentinger: WIP: Process payment before popping out of iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328725 (https://phabricator.wikimedia.org/T153972) [21:29:53] (PS12) Ejegg: Top 10 days / hours widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) [21:30:21] XenoRyet: OK, now the filter hides when empty ^^ [21:31:19] Also I changed the dollar amount formatting 'cause it looked like we had enough space we didn't need to abbreviate with M / k suffixes [21:53:43] (CR) XenoRyet: [C: 2] Top 10 days / hours widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) (owner: Ejegg) [21:56:31] (Merged) jenkins-bot: Top 10 days / hours widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/327401 (https://phabricator.wikimedia.org/T152028) (owner: Ejegg) [22:43:18] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/328843 [22:43:29] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/328843 (owner: Ejegg) [22:44:00] nice, commit sha c2cccc0 [22:45:24] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/328843 (owner: Ejegg) [22:46:31] !log updated fundraising dashboard from ea4305bc9b2c919d3f828ba542eb32b91b207af7 to c2cccc058e3e7f929dca5c733c29a3054bca6712 [22:46:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:47:03] ejegg: trying to think up a good way to test the result switcher, can i get a fake iframe from ingenico? [22:47:35] they have a test endpoint [22:47:43] I think you just replace .com with .nl [22:47:56] might need the same vpn tunnel though [22:50:14] wheeeee [23:06:03] (PS1) Ejegg: Add top10 to minifier config [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328846 [23:06:17] (CR) Ejegg: [C: 2] Add top10 to minifier config [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328846 (owner: Ejegg) [23:08:56] (Merged) jenkins-bot: Add top10 to minifier config [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/328846 (owner: Ejegg) [23:11:05] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/328849 [23:11:15] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/328849 (owner: Ejegg) [23:14:07] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/328849 (owner: Ejegg) [23:16:11] !log updated fundraising dashboard from c2cccc058e3e7f929dca5c733c29a3054bca6712 to bec0077599737c774cc716851171365b38a8b02a [23:16:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:19:29] nice, 6 of our top 10 days and 8 of our top 10 hours have been during this year's Big English [23:46:12] XenoRyet: want to help me puzzle through the ContributionTracking stuff? [23:50:00] ejegg: Sure, what've you got so far? [23:50:20] just what's on the ticket [23:50:33] https://phabricator.wikimedia.org/T153730 [23:50:37] Cool, let me read up again [23:52:10] ah, there's some background in a google doc [23:52:41] https://docs.google.com/document/d/125jK7tztPxnglIazHy0V4JAbw46S0A2ZGB0jonzzwyM/edit [23:53:11] well, not much background [23:53:21] just mentions a ct_id found in logs but not in db [23:57:14] Wow, so there are kind of a lot of these. [23:57:31] XenoRyet: err, wait, I just checked the one in the google doc [23:57:34] and it's totally there [23:57:42] this may be a false alarm [23:57:49] fingers crossed [23:58:14] so... how do we check for more? [23:59:12] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Spike: ContributionTracking sometimes fails to insert rows - https://phabricator.wikimedia.org/T153730#2897595 (Ejegg) This may be a false alarm - I ju...