[00:13:34] cwd|afk: good luck! Also, I see your wood-chopping, and I raise you 2.5 heads-of-hair-de-lousings! [00:17:30] AndyRussG: D: [06:19:36] (PS1) Cdentinger: WIP deprecate globalcollect resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330635 [10:22:28] (CR) TTO: [C: -1] Update Maintenance scripts to use $this->requireExtension() (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/330465 (https://phabricator.wikimedia.org/T152139) (owner: Georggi199) [14:38:43] (PS2) Ejegg: Remove code tagging of contacts for Review. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330177 (https://phabricator.wikimedia.org/T118904) (owner: Eileen) [14:39:43] (CR) Ejegg: [C: 2] Remove code tagging of contacts for Review. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330177 (https://phabricator.wikimedia.org/T118904) (owner: Eileen) [14:40:26] (PS2) Ejegg: Remove entity tags for 'Review'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330179 (https://phabricator.wikimedia.org/T118904) (owner: Eileen) [14:40:38] (CR) Ejegg: [C: 2] Remove entity tags for 'Review'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330179 (https://phabricator.wikimedia.org/T118904) (owner: Eileen) [14:43:25] (Merged) jenkins-bot: Remove code tagging of contacts for Review. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330177 (https://phabricator.wikimedia.org/T118904) (owner: Eileen) [14:50:41] (Merged) jenkins-bot: Remove entity tags for 'Review'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330179 (https://phabricator.wikimedia.org/T118904) (owner: Eileen) [15:15:53] (PS3) Ejegg: Add small extension to mark dead contacts as opted out. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330096 (https://phabricator.wikimedia.org/T153110) (owner: Eileen) [15:20:42] (CR) Ejegg: [C: 2] Add small extension to mark dead contacts as opted out. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330096 (https://phabricator.wikimedia.org/T153110) (owner: Eileen) [15:22:43] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/329722 (https://phabricator.wikimedia.org/T152044) (owner: Eileen) [15:28:13] (Merged) jenkins-bot: Add small extension to mark dead contacts as opted out. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/330096 (https://phabricator.wikimedia.org/T153110) (owner: Eileen) [16:15:00] mornin cwd [16:15:10] how's the snow? [16:15:21] Fundraising-Backlog, fundraising-tech-ops: Make it possible for fr-tech to acknowledge icinga alerts - https://phabricator.wikimedia.org/T152725#2919706 (Jgreen) p:Triage>Normal [16:16:40] ejegg: still hasn't showed up [16:16:44] https://www.wunderground.com/US/NM/512.html#WIN [16:16:49] but it looks like a big one [16:17:17] still expecting up to 10 inches, huh? [16:17:18] we are at just about 7500' so between 5 and 20 inches [16:17:27] oh wow, that's some elevation! [16:17:53] yep up in the mtns [16:18:07] you back in MA now right? [16:22:32] yep, till tomorrow [16:22:42] spending a few weeks in CA [16:23:10] nice time of year for that [16:23:25] for sure [16:28:19] been staring this this trying to get an idea bout the dedupe fail mail: https://ganglia.wikimedia.org/latest/?c=Fundraising%20eqiad&h=db1025.frack.eqiad.wmnet&m=cpu_report&r=hour&s=by%20name&hc=4&mc=2 [16:28:39] but have drawn few conclusion beyond "mysql is thrashing" [16:29:38] those network spikes are interesting [16:29:56] something's pulling down lots and lots of rows semi-regularly [16:30:34] yeah, sounds about right [16:30:40] sorting in php i'm guessing [16:36:18] hmm, so it's like every 2 minutes [16:36:27] maybe that's just the queue consumer [16:38:56] the dedupe queries must ride the line of runnability on that box so whenever it gets overloaded they start to time out [16:50:11] cwd any resultswitcher stuff you want to talk through? [16:51:50] ejegg: yeah... hard to know where to stop the refactor train [16:51:57] i made a bunch of comments here: https://gerrit.wikimedia.org/r/#/c/330635/ [16:52:34] OK, I think we can drop that dumb 'fake' / 'fail' stuff [16:52:51] I don't think we need a way to test fail page redirection on prod like that [16:53:47] yeah agreed [16:54:05] That 'displayResultsForDebug' bit is also bogus [16:54:57] cool yeah [16:55:06] looks like this can get pared down quite a bit [16:55:39] hi all! [16:55:55] wb dstrine [16:56:04] are you on dry land? [16:56:17] yeah, I think the only thing that actually needs to go in the processDonorReturn is the do_transaction( 'Confirm_CreditCard' ) and the part that checks we're not re-processing the same OID [16:56:45] cwd: yup and my internet is decent and doesn't cost an arm and a leg [16:57:06] cwd: 5 to 20 inches of snow??!? where is that? are you at your new place or colorado? [16:57:10] How's it going Davic? [16:57:15] *David [16:57:33] dstrine: new place, same storm that just slammed colorado is coming our way [16:58:06] ejegg: cool. thanks for the info on the security question the other day! [16:58:21] yw. It was mostly cwd working to fix it [16:58:23] I do have a bit of a cold. Cruise ships are basically germ factories [16:58:48] escaped the norovirus at least, though, right? [16:58:58] yeah just a head cold [16:59:09] dstrine: floating petri dishes really ;) [16:59:23] yeah :( [17:00:22] cwd so, looks like GatewayPage::handleResultRequest needs some minor updates [17:00:55] at least one I see: FinalStatus::PENDING_POKE should also go to the thank you page afaict [17:03:37] is that one where the rectifier will push it through? [17:04:59] I think so... or the listener job, in the case of Adyen [17:29:48] (CR) Ejegg: [C: 2] "Not seeing any problems locally" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/329722 (https://phabricator.wikimedia.org/T152044) (owner: Eileen) [17:36:26] (Merged) jenkins-bot: 4.7.15 upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/329722 (https://phabricator.wikimedia.org/T152044) (owner: Eileen) [17:58:43] bd808: heheh :) [17:58:46] dstrine: hi! [17:59:00] AndyRussG: hey! [17:59:04] o/ [17:59:31] welcome back! [18:00:30] fr-tech: Go to a movie tonight. [18:00:30] Darkness becomes you. [18:00:30] -- discuss. [18:27:48] fr-tech sorry for the delay, just joining -talk now [19:16:34] (PS8) Ejegg: Rename 'zip' to 'postal_code' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320267 [19:17:18] cwd that didn't turn out to be so bad ^^^ [19:19:59] Check this out! https://pivot.wikimedia.org [19:26:14] AndyRussG: dang, that's cool! [19:32:57] yeah eh? [19:33:05] We should do something like that for CN, no? [19:33:29] Also check out this new "report card" tool that Flow's using: https://flow-reportcard.wmflabs.org/ [19:33:48] * AndyRussG catching up on mailing lists [19:36:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Page-Previews (2016-17-Q3-Goal): Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2920619 (MBinder_WMF) [19:55:36] (PS2) Georggi199: Update Maintenance scripts to use $this->requireExtension() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/330465 (https://phabricator.wikimedia.org/T152139) [19:56:20] (CR) Cdentinger: [C: 2] Rename 'zip' to 'postal_code' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320267 (owner: Ejegg) [19:58:05] (Merged) jenkins-bot: Rename 'zip' to 'postal_code' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/320267 (owner: Ejegg) [20:23:40] thanks for the CR cwd [20:24:17] I'll try deploying that shortly [20:38:53] (CR) Eileen: [C: 2] "Yep, that is a little clean up :-)" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/330457 (owner: Ejegg) [20:39:00] (Merged) jenkins-bot: Little cleanups to large donation notifier [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/330457 (owner: Ejegg) [21:17:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#2833278 (MBeat33) Hi @Eileenmcnaughton I have 2 questions related to this workflow: 1. Does the TY email work for check donations? 2. If so would we expect... [21:39:48] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/330733 [21:40:05] ejegg: could be an exciting one! [21:40:10] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/330733 (owner: Ejegg) [21:41:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/330733 (owner: Ejegg) [21:43:11] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/330734 [21:43:15] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/330734 (owner: Ejegg) [21:52:03] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/330734 (owner: Ejegg) [21:53:48] !log updated payments wiki from 21ea9bc4a46c96f84685b33ef06fd1b4c40e797e to 1f9ea809b3c32060222f4f6a70e725c433fe15b7 [21:53:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:59:43] (PS3) Ejegg: Check contribution_id before rectifying orphans [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328855 (https://phabricator.wikimedia.org/T153992) [22:22:25] (PS1) Ejegg: Get rid of the rest of the !important modifiers in forms.css [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330742 [22:26:25] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Inconsistent zip/postal prompts and missing error message - https://phabricator.wikimedia.org/T140330#2921287 (Ejegg) a:Ejegg [22:27:57] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Inconsistent zip/postal prompts and missing error message - https://phabricator.wikimedia.org/T140330#2460681 (Ejegg) Commit: aa270db981fc [22:28:15] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Inconsistent zip/postal prompts and missing error message - https://phabricator.wikimedia.org/T140330#2460681 (Ejegg) Open>Resolved [22:38:48] (PS5) Ejegg: Less overloaded processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330580 [22:51:18] (CR) Cdentinger: Erase Stomp (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/330591 (owner: Ejegg) [23:03:45] (CR) Ejegg: "It's to fix that EmotyQueueToDump maintenance script which only worked for Stomp before" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/330591 (owner: Ejegg) [23:43:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#1713380 (Ejegg) Can you put a sample of the Benevity file (e.g. last year's) up on the file share? [23:47:22] Fundraising Sprint A 2017, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 2 others: Move creation of contribution tracking create for offline to within the transaction loop - https://phabricator.wikimedia.org/T154528#2921756 (DStrine) [23:47:27] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2921758 (DStrine) [23:47:29] Fundraising Sprint A 2017, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 3 others: Fix Coinbase file to support importing UTM fields - https://phabricator.wikimedia.org/T153791#2921761 (DStrine) [23:47:31] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Blank address data being collected & stored as an address - https://phabricator.wikimedia.org/T153804#2921760 (DStrine) [23:47:34] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog: Items from 2016-12-07 retrospective - https://phabricator.wikimedia.org/T152796#2921763 (DStrine) [23:47:36] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-Email: Investigate reported banners/emails after donation - https://phabricator.wikimedia.org/T152744#2921764 (DStrine) [23:47:38] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2921765 (DStrine) [23:47:40] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2921767 (DStrine) [23:47:43] Fundraising Sprint A 2017, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Figure out why new recurring entries are creating duplicate emails of the same location type, ditto address - https://phabricator.wikimedia.org/T152475#2921766 (DStrin... [23:47:45] Fundraising Sprint A 2017, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 2 others: [Spike] investigate contribution tracking data (was Engage import failing to import certain significant fields) - https://phabricator.wikimedia.org/T146295#2921768... [23:47:47] Fundraising Sprint A 2017, Fundraising Sprint Value Subtracting, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2921772 (DStrine) [23:47:49] Fundraising Sprint A 2017, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, and 8 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2921770 (DStrine) [23:47:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2921774 (Ejegg) @LeanneS last comment was for you. Also, is it possible to use the gift amounts and dates to he... [23:50:23] Fundraising-Backlog, Security-General: Run composer.lock version vulnerability checker daily - https://phabricator.wikimedia.org/T154720#2921781 (Ejegg) [23:53:22] Fundraising-Backlog: Canada donation form: Specify CAD at some point - https://phabricator.wikimedia.org/T154721#2921788 (MBeat33)