[00:01:52] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Method to bypass/purge CentralNotice cache when forcing banner - https://phabricator.wikimedia.org/T154954#2951096 (DStrine) [00:01:54] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 3 others: Move creation of contribution tracking create for offline to within the trans... - https://phabricator.wikimedia.org/T154528#2951097 [00:01:57] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 2 others: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2951100 (DStrine) [00:01:59] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Blank address data being collected & stored as an address - https://phabricator.wikimedia.org/T153804#2951101 (DStrine) [00:02:01] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 4 others: Fix Coinbase file to support importing UTM fields - https://phabricator.wikimedia.org/T153791#2951102 (DStrine) [00:02:04] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 2 others: Investigate reported banners/emails after donation - https://phabricator.wikimedia.org/T152744#2951105 (DStrine) [00:02:06] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: DjangoBannerStats: Handle banner loader error - https://phabricator.wikimedia.org/T152723#2951106 (DStrine) [00:02:09] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog: Items from 2016-12-07 retrospective - https://phabricator.wikimedia.org/T152796#2951104 (DStrine) [00:02:12] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 3 others: Figure out why new recurring entries are creating duplicate emails of the same location type, ... - https://phabricator.wikimedia.org/T152475#2951107 [00:02:13] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, and 2 others: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2951109 (DStrine) [00:02:15] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: If possible, reduce Varnish cache time for SpecialBannerLoader errors - https://phabricator.wikimedia.org/T151418#2951108 (DStrine) [00:02:18] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 3 others: [Spike] investigate contribution tracking data (was Engage import failing to ... - https://phabricator.wikimedia.org/T146295#2951110 [00:02:20] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 3 others: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2951113 (DStrine) [00:02:23] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, and 2 others: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2951115 (DStrine) [00:02:25] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2951116 (DStrine) [00:02:27] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, and 9 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2951112 (DStrine) [00:04:21] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Epic: Epic: hire fr-tech software engineer - https://phabricator.wikimedia.org/T155686#2951119 (cwdent) [00:05:27] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Waiting for Godot, Fundraising-Backlog: Items from 2016-12-07 retrospective - https://phabricator.wikimedia.org/T152796#2951132 (DStrine) Open>Resolved [00:05:37] Fundraising Sprint Autotune Earphones, Fundraising Sprint Waiting for Godot, Fundraising-Backlog: Items from 2016-12-07 retrospective - https://phabricator.wikimedia.org/T152796#2860367 (DStrine) [00:45:27] fr-tech anyone up for reviewing https://gerrit.wikimedia.org/r/328855 ? [00:46:11] Fundraising Sprint Autotune Earphones, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-Email: Investigate reported banners/emails after donation - https://phabricator.wikimedia.org/T152744#2951188 (Ejegg) Open>Resolved [00:47:05] ejegg: ah yes i remember this one [00:47:45] (PS4) Cdentinger: Check contribution_id before rectifying orphans [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328855 (https://phabricator.wikimedia.org/T153992) (owner: Ejegg) [02:11:48] (Abandoned) Ejegg: Update composer dependencies [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/330599 (owner: Ejegg) [02:12:49] (CR) Cdentinger: [C: 2] Check contribution_id before rectifying orphans [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328855 (https://phabricator.wikimedia.org/T153992) (owner: Ejegg) [02:14:48] (Merged) jenkins-bot: Check contribution_id before rectifying orphans [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328855 (https://phabricator.wikimedia.org/T153992) (owner: Ejegg) [02:15:04] ty cwd! [02:16:05] I'm going to change that default queue backend to mysql so ppl need to actually configure it [02:17:23] hard fail if not available? [02:22:13] yeah [02:26:17] (PS2) Ejegg: Update default queue backend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) [02:29:01] (PS3) Ejegg: Update default queue backend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) [02:29:03] (PS2) Ejegg: Remove Stomp requirement, update Composer libraries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332716 (https://phabricator.wikimedia.org/T131274) [02:29:47] k, I moved the composer.json change into the patch with the lib update so I didn't have to update composer.lock twice [02:30:10] ought to pass tests [02:31:07] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: Migrate pending consumers to new queue and finish cleanup - https://phabricator.wikimedia.org/T131274#2951357 (Ejegg) [07:49:12] (PS1) Ejegg: ProcessResponse no longer needs to be public [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332962 [07:50:44] (PS1) Ejegg: Remove unused noScript form function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332963 [08:10:23] (PS2) Ejegg: Remove unused form functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332963 [08:15:39] (PS3) Ejegg: Remove unused form functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332963 [09:01:02] (PS1) Ejegg: Delete unused CyclicalArray [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332968 [09:01:04] (PS1) Ejegg: Remove unused base adapter code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332969 [09:01:06] (PS1) Ejegg: Fold getRetryData into mustache error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332970 [09:01:09] (PS1) Ejegg: Remove unused api_request stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332971 [09:02:08] if anyone else on fr-tech can't sleep, please take a look at those ^^^ [14:01:35] fundraising-tech-ops: pre-decommission beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T147934#2952695 (Jgreen) ok, we're ready to fully decom beryllium, thanks! [14:01:51] fundraising-tech-ops: pre-decommission beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T147934#2952696 (Jgreen) Open>Resolved p:Low>Normal [14:01:53] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2952698 (Jgreen) [14:02:08] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [14:02:10] fundraising-tech-ops: decommission beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T147934#2708978 (Jgreen) Resolved>Open [14:14:59] fundraising-tech-ops: replace boron (fundraising build server) with new hardware running jessie - https://phabricator.wikimedia.org/T145117#2952727 (Jgreen) the new box will be named frpm1001, and will take the spot where beryllium was in the rack/switch/power. [16:56:34] Fundraising-Backlog, fundraising-tech-ops: database access to additional CPS analyst - https://phabricator.wikimedia.org/T155746#2953215 (DStrine) [17:24:07] Fundraising-Backlog, Analytics, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2953308 (Nuria) * Oozie work to source data from webrequest into a banner impressions table, indexing job in druid loads data into druid * Add step to wor... [17:24:37] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2953309 (Nuria) [18:00:31] fr-tech: Oh, give me a locus where the gravitons focus [18:00:32] Where the three-body problem is solved, [18:00:32] Where the microwaves play down at three degrees K, [18:00:32] And the cold virus never evolved. (chorus) [18:00:32] We eat algae pie, our vacuum is high, [18:00:32] Our ball bearings are perfectly round. [18:00:32] Our horizon is curved, our warheads are MIRVed, [18:00:33] And a kilogram weighs half a pound. (chorus) [18:00:33] If we run out of space for our burgeoning race [18:00:34] No more Lebensraum left for the Mensch [18:00:34] When we're ready to start, we can take Mars apart, [18:00:35] If we just find a big enough wrench. (chorus) [18:00:35] I'm sick of this place, it's just McDonald's in space, [18:00:36] And living up here is a bore. [18:07:21] fr-tech hi! if anyone feels tech-talky, there are a couple non-urgent CN phab tasks that I could ask for feedback about... :) [18:07:42] Specifically T141918 and T148808 [18:07:42] T141918: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918 [18:07:42] T148808: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808 [18:08:33] AndyRussG: i'll be on in 10 min or so [18:08:59] ejegg|away: cool! maybe shout out a ping whenever ur ready? thx! [18:09:20] will no [18:09:24] do! [18:09:29] k :) [18:09:32] thx :) [18:35:15] (PS1) Ejegg: Move exception trace into log data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333041 (https://phabricator.wikimedia.org/T155757) [18:35:26] cwd|afk: ^^^^ [18:38:13] (CR) Awight: [C: 2] "/me takes a pot shot from grassy knoll" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332968 (owner: Ejegg) [18:40:28] ejegg: hmmm, so where does this->data go? just into a log but not into an email? [18:44:01] (CR) jerkins-bot: [V: -1] Move exception trace into log data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333041 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg) [18:54:15] (PS2) Ejegg: Move exception trace into log data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333041 (https://phabricator.wikimedia.org/T155757) [18:54:43] fr-tech ^^^ oops, getExceptionBlob needed to return an array [18:54:50] where did all this->data go? [18:55:32] AndyRussG: it gets recorded in syslog and the file log stream, but not in FailMail [18:56:05] ejegg: sorry I was just being silly... http://dancemoms.wikia.com/wiki/Where_Have_All_The_Children_Gone [18:56:17] ...long time passing [18:56:32] yeah! [18:56:40] (into syslog) [18:56:55] http://www.lyricsfreak.com/p/peter+paul+mary/where+have+all+the+flowers+gone_20107752.html [18:56:58] oh when will the failmails ever stop? [18:57:04] when we will ever learn? [18:57:17] Ah yeah it was flowers, not children I was thinking [18:57:28] or maybe that's also part of the lyrics [18:59:20] AndyRussG: belated tech-talk? [19:00:55] I'm in there, but can't see or hear you [19:01:11] also, got notice that they're shutting down the Effects plugin. [19:01:14] Noooooooo! [19:01:39] AndyRussG: back to matrix? [19:02:05] https://riot.im/app/#/room/#wm-fr:matrix.org [19:02:06] ejegg: :) one sec [19:16:05] (PS3) Ejegg: Move exception trace into log data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333041 (https://phabricator.wikimedia.org/T155757) [19:26:57] (CR) AndyRussG: [C: 2] "Cool!!! :D" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333041 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg) [19:27:58] T141918 and T148808 [19:27:58] T141918: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918 [19:27:59] T148808: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808 [19:28:14] (Merged) jenkins-bot: Move exception trace into log data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333041 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg) [19:37:28] OK, that doesn't break things, but there are still places we're appending data to the exception message that should go in the data part of the log event [19:39:32] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333061 [19:39:38] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333061 (owner: Ejegg) [19:40:30] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333061 (owner: Ejegg) [19:44:23] !log updated SmashPig from 48675c3370629d6cd4820f4d8902e016c51011d2 to f05c9a30449c12ba1809089509a66ee0c72906b2 [19:44:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:58:02] (PS1) Ejegg: Fix insecure uncaught exception logging [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333082 (https://phabricator.wikimedia.org/T155757) [19:59:01] fr-tech that last patch only fixed logging caught exceptions. ^^^ should fix logging the uncaught ones. [20:00:33] AndyRussG: mind taking a look at that when you've eaten? [20:29:53] ejegg: sure, u mean the last one, 155757? [20:30:06] yes please! [20:30:41] K u bet :) [20:33:35] ejegg: remember ye olde 'replace smashpig logging' epic? [20:33:48] cwd yep [20:33:55] I definitely still want to do that [20:33:59] what do you think of the scale at this point? [20:34:24] not TOO terrible... [20:34:42] as long as we're OK with the logs not being identical [20:34:56] since we're running into practical problems with it i was wondering if it might be a good time to revisit [20:36:07] cwd it's definitly an order of magnitude bigger than those last two fixes [20:36:48] actually, I was suggesting the monolog replacement as a topic for belated tech-talk [20:36:59] i'm free any time you're feeling up to it [20:37:37] not bigger than queue reform, right? [20:37:47] nah, definitely not [20:39:07] yeah maybe we could take a look at it after standup [20:39:39] Mmm cool [20:41:29] after standup I have to go domestic for a bit, tho pls feel free to dig in w/out me ;p [20:42:46] in any case, I think we still need https://gerrit.wikimedia.org/r/333082 to plug the failmail stack trace hole [20:44:34] yea looking now [20:54:27] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 3 others: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2954265 (DStrine... [20:58:40] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, and 2 others: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2954295 (ggellerman) a:Ejegg [21:09:28] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog: fill out PCI SAQ-A form for 2017 - https://phabricator.wikimedia.org/T155779#2954361 (DStrine) [22:04:44] (PS1) Ejegg: WIP use Monolog for logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333130 [22:33:04] ejegg: is the exit(1) in the patch worth looking at? This is called via command line? Might there be some cleanup other stuff would want to do, that we might be skipping? Also, would the program otherwise exit with (0) if we didn't call that? [22:33:31] AndyRussG: if you look at the previous logic, you can see it was doing exit(1) before [22:33:43] because we called $this->error with $fatal = true [22:34:03] I'm leaving that behavior untouched [22:34:13] Oh right [22:34:14] Huh [22:35:29] So the previous line 610 Logger::alert was dead code? [22:37:33] yep, afaict [22:37:36] Also, is MaintenanceBase::error ever called elsewhere with fatal=1 = [22:37:38] ? [22:37:47] I mean, fatal=true [22:37:49] ? [22:38:38] yep, for example populateQueueFromDump says it's a fatal error if it can't read the supposed input file [22:44:17] Ah K [22:47:25] Trying to follow what happens to $ex in the call to Logger::alert()... Eventually gets a toString called or something? [22:47:34] ejegg: ^ [22:48:07] AndyRussG: Logger::alert creates a LogEvent [22:48:14] Yeah got that far... [22:48:20] * AndyRussG hasn't set up IDE yet... [22:49:21] So the LogEvent provides basic details about the exception and any exceptions up the causal chain [22:49:30] to consumers that call getExceptionBlob [22:49:46] Mmm [22:49:51] that's the function that used to also provide a stringified stack trace [22:50:16] Ah that's what we were looking at in the previous patch? [22:50:19] the stack trace is now in the $data parameter [22:50:40] which is ignored by loggers that send data off the box [22:51:10] K gotcha [22:57:56] ejegg: K I think I've reviewed enuf to +2 if you're good with this :) [22:58:12] Yep, thanks! [22:58:18] K here goes! [22:59:11] (CR) AndyRussG: [C: 2] "Fun!!" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333082 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg) [23:00:16] (Merged) jenkins-bot: Fix insecure uncaught exception logging [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333082 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg) [23:07:43] d'oh! I had that merging to deployment. Will put it on master [23:08:40] (PS1) Ejegg: Fix insecure uncaught exception logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333140 (https://phabricator.wikimedia.org/T155757) [23:09:29] (CR) Ejegg: [C: 2] "Oops, I put the original version of this up against the deployment branch. It was C+2ed by AndyRussG there, this is just making the master" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333140 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg) [23:10:45] !log updated SmashPig from f05c9a30449c12ba1809089509a66ee0c72906b2 to 03880ce28f5d3215a47fc0574be3224f2fea552a [23:10:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:11:43] (Merged) jenkins-bot: Fix insecure uncaught exception logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333140 (https://phabricator.wikimedia.org/T155757) (owner: Ejegg)