[00:32:16] ejegg: awesome about amazon sdk [00:32:20] :) [00:33:50] ^^yeah me too!! [00:34:18] Yeah, will be great to get that done! Looks like a new-ish person in charge of the repo, so hopefully they're still excited to make changes [00:34:39] ha yeah [00:34:49] i was a little surprised at how receptive [00:35:17] The Amazon tech contacts have been superb overall [00:36:13] just the last time I tried to get stuff merged the PHP SDK was stuck in some limbo where it was maybe-about-to-be-refactored [00:36:34] ah ha [00:36:38] well that sure is nice [00:46:23] (PS4) Ejegg: Parse Express Checkout charge [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/326829 (https://phabricator.wikimedia.org/T130851) (owner: Awight) [00:46:31] (CR) Ejegg: [C: 2] Parse Express Checkout charge [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/326829 (https://phabricator.wikimedia.org/T130851) (owner: Awight) [00:47:05] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Make PayPal listener understand Express Checkout - https://phabricator.wikimedia.org/T130851#2954901 (Ejegg) [00:48:19] (Merged) jenkins-bot: Parse Express Checkout charge [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/326829 (https://phabricator.wikimedia.org/T130851) (owner: Awight) [01:21:57] (PS3) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 [01:21:59] (PS1) Ejegg: Push PaymentResult down into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333152 [01:22:01] (PS1) Ejegg: WIP add PaymentParameters and BasePaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333153 [01:22:03] (PS1) Ejegg: WIP base class for Ingenico payments using SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 [01:22:05] (PS1) Ejegg: WIP add Ingenico bank payment provider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333155 (https://phabricator.wikimedia.org/T128692) [01:22:34] fr-tech ^^^ are sort of a sketch for moving adapter functions into SmashPig [01:22:44] please let me know what you think! [01:27:48] back later... [01:28:11] oh, AndyRussG, thanks for that lunch suggestion. beautiful restaurant! [01:29:00] (CR) jerkins-bot: [V: -1] WIP base class for Ingenico payments using SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (owner: Ejegg) [01:31:22] (CR) jerkins-bot: [V: -1] WIP add Ingenico bank payment provider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333155 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [15:33:13] (PS1) Fomafix: Use chmod 644 instead of chmod 755 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/333266 [15:59:32] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2956119 (mforns) a:mforns [18:00:31] fr-tech: When your life is a leaf that the seasons tear off and condemn [18:00:31] They will bind you with love that is graceful and green as a stem. [18:00:32] -- Leonard Cohen, "Sisters of Mercy" [18:00:32] -- discuss. [18:50:24] fr-tech sorry I missed most of -talk, was in another meeting [18:50:30] anyone up for it now? [18:50:37] cwd feeling any better? [18:54:11] yeah a bit better today [18:54:26] i have got my head down in donation interface atm [18:54:51] k, let me know if you want to talk anything through [18:55:05] glad to hear you're feeling better! [18:56:15] thanks! yeah it is a nasty cold [19:01:29] !log disabled fundraising jenkins jobs [19:01:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:12:30] !log re-enabled fundraising Jenkins jobs [19:12:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:25:56] ejegg: hey I missed it too, forgot to mention I had an errand [19:28:32] AndyRussG: Any particular feedback you want on those tickets you had mentioned? [19:29:29] ejegg: yeah! lemmesee [19:30:08] This one basically we should give an opinion on the proposal in general: T148808 [19:30:09] T148808: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808 [19:30:13] I'm happy to give it a try! [19:31:39] We can also do our own deploys but it seems fun to hand off to someone who does that regularly and is up-to-date w/ the latest ops gossip [19:31:42] AndyRussG: the once-a-week availability won't be an issue? [19:32:27] ejegg: well yes, but sometimes it'll be useful [19:32:52] Basically they're not into us swat deploying gallons of accumulated patches from our master [19:33:00] quite understandable [19:33:10] aha, so this would be for normal features [19:33:15] So this is like an extra thing that would be offered to lend us a hadn [19:33:17] hand [19:33:19] Yeah [19:33:26] Small fixes could still be SWATted [19:33:27] yeah, so that sounds like a good idea [19:34:17] If we ever have a big deploy that we really need to do on a different day, we could work it out. Also we can still put things on the train manually [19:34:36] (just update the deploy branch early enough in the week) [19:34:43] The other one is T141918 [19:34:43] T141918: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918 [19:35:23] I was just thinking of asking about to see if there's anything else to add, while our memory is fresh [19:35:46] Here is what there is so far: https://etherpad.wikimedia.org/p/fr-tech_2016_checklist_notes and https://collab.wikimedia.org/wiki/Fundraising/Big_English_checklist [19:36:12] As mentioned in standup, I should consolidate notes (I think in mediawiki.org, since I don't see any sekrets) [19:46:03] sure, sounds good to me. [19:46:23] I forget why I put it on collab in the first place, guess I'd seen some other checklisty FR things there [19:47:20] K :) [20:36:02] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising-Backlog, and 3 others: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2956741 (AndyRuss... [20:40:39] Fundraising-Backlog: Design specific pre-campaign verification procedures - https://phabricator.wikimedia.org/T155849#2956765 (AndyRussG) [20:47:27] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, Spike: Investigate Redis connection issues in GC audit parser - https://phabricator.wikimedia.org/T155150#2956789 (Ejegg) a:Ejegg [20:52:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808#2956798 (AndyRussG) Thanks so much for making this proposal!!!! Sounds great!! So, as far as I can tell, for de... [21:05:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808#2733554 (demon) I'm not a fan of this idea, as I think it further enshrines one of the special snowflakes (CN is... [21:25:27] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2934689 (DStrine) Hi all, Just joining this work here. I've seen this tool in action and it looks pretty cool!! I love dev summit meetings and hac... [21:26:31] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2956901 (Nuria) @Dstrine: actually we are going to go ahead and productionize it ourselves, just try to see what is going on for further modificati... [21:28:55] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2956916 (DStrine) @Nuria ok, that's cool. Thanks for the help! [21:33:18] dstrine: also, any thoughts on where the clear-banner-in-cache button might go? [21:33:50] * dstrine looks at CN ui and dies a little inside [21:33:55] AndyRussG: please hold [21:33:56] awww [21:34:00] We'll fix it! [21:35:15] Just some thoughts: Maybe one next to each entry in the banner list, like next to the preview buttons? https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners [21:35:50] and/or at the bottom of the edit banner details form? https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/inspire_knowledge [21:37:26] I forgot my password and got locked out. Give me a few minutes [21:37:31] like 5 :) [21:42:36] K! [21:55:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Weekly "misc MediaWiki extensions" deployment window proposal - https://phabricator.wikimedia.org/T148808#2957009 (greg) Open>declined A bit of history... When I joined I (obviously) took ownership of the [[wi... [22:02:20] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Method to bypass/purge CentralNotice cache when forcing banner - https://phabricator.wikimedia.org/T154954#2957026 (DStrine) @AndyRussG and I talked. He will put the clear cache button near the preview... [22:08:34] venueTransition: smooth; (hopefully) [22:17:41] ejegg: am i crazy or did phpunit disappear from DI? [22:18:03] oops, did it? [22:18:05] lemme see [22:18:24] oh hey, it's not in require-dev [22:18:31] let's put it there [22:18:58] doesn't look like it ever was [22:19:12] interesting...where is phpunit.xml? [22:19:26] it's been awhile since i tried to run tests here [22:19:37] urph... mediawiki extension testing can be annoying [22:19:39] lemme see [22:20:03] ooh yeah i remember something about --wiki=payments [22:20:12] right, you have to run them from mediawiki/tests/phpunit [22:20:26] php phpunit.php --group=DonationInterface [22:20:32] and probably that wiki param too [22:21:27] Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 25 [22:21:31] that looks familiar too [22:21:35] blarg [22:21:44] try setting $IP to the fundraising wiki? [22:22:02] or rather MW_INSTALL_PATH [22:22:50] ah yeah i'm getting farther [22:27:01] (PS2) Cdentinger: WIP deprecate globalcollect resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330635 [22:27:37] kind of scary that this extreme WIP passes tests...should probably expand tests so it doesn't [22:30:45] hehe [22:32:09] yeah, I think the only tests that use the GatewayPage classes are the ones looking at form rendering [22:33:09] hard to test http stuff i suppose [22:36:17] kinda [22:38:30] ejegg: you've got some recent patches for the new ingenico stuff, are they associated with the spike in the sprint or are there other tickets for the buildout? [22:39:01] The SmashPig ones? [22:39:09] or the DonationInterface cleanup stuff? [22:39:50] The SmashPig ones are exploring a way to do the iDEAL lookup via Connect in SmashPig. So... related to a few things [22:40:01] ah yes that [22:40:39] The DonationInterface cleanup is partly just for the thrill of deleting dead code, but also looking to get the adapters less intertwined with e.g. forms [22:40:51] need to put that adapter interface on a crash diet [22:43:51] cool yeah, so basically just make sure there are no regressions in that chain? [22:46:07] the cleanup chain? [22:46:22] yep [22:46:38] Most of it was dead code [22:47:33] getRetryData just didn't need to be on the interface, since it was only called from one place that already had the full data set [22:49:07] (CR) Cdentinger: [C: 2] ProcessResponse no longer needs to be public [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332962 (owner: Ejegg) [22:51:22] (Merged) jenkins-bot: ProcessResponse no longer needs to be public [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332962 (owner: Ejegg) [22:54:57] (CR) Cdentinger: [C: 2] Remove unused form functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332963 (owner: Ejegg) [22:56:51] (Merged) jenkins-bot: Remove unused form functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332963 (owner: Ejegg) [22:58:21] (Merged) jenkins-bot: Delete unused CyclicalArray [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332968 (owner: Ejegg) [23:00:21] (PS1) Ejegg: Always reconnect before sending queue messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/333308 (https://phabricator.wikimedia.org/T155150) [23:00:41] cwd really simple, dumb fix for those redis idle timeouts ^^^ [23:01:00] just changed the object persistence flag from true to false [23:01:09] so we always get a fresh connection to the queue [23:02:12] how often will that be reconnecting? [23:02:25] every time the audit finds another donation [23:02:25] every message? [23:02:31] so, just like DonationInterface [23:03:11] server seems to be fine with that kind of connection volume [23:03:22] it will essentially double our connection traffic? [23:04:04] We get most of the donations before they hit the audit, so it's not so huge. Let's see how many it usually finds [23:04:47] cool, yeah i agree that it probably doesn't matter but would be good to make sure [23:05:06] we definitely have cases where nighttime jobs are causing chaos with other stuff [23:06:40] also some things that are inconsequential now might not be under december load [23:08:38] but yeah this seems like a nice simple fix to me [23:10:22] cwd k, it's like 30 transactions over 45 minutes, so a barely noticable bump in connections [23:11:49] nice [23:11:59] (CR) Cdentinger: [C: 2] Always reconnect before sending queue messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/333308 (https://phabricator.wikimedia.org/T155150) (owner: Ejegg) [23:13:35] the snow has started [23:13:43] not supposed to stop till tomorrow night [23:14:12] making it to town for the walk might be a challenge [23:15:50] (CR) Cdentinger: [C: 2] Remove unused base adapter code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332969 (owner: Ejegg) [23:15:51] thanks for the CR [23:16:09] it's raining and sunny in SF right now [23:16:49] nice [23:20:35] (Merged) jenkins-bot: Always reconnect before sending queue messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/333308 (https://phabricator.wikimedia.org/T155150) (owner: Ejegg) [23:30:34] (Merged) jenkins-bot: Remove unused base adapter code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332969 (owner: Ejegg) [23:36:21] (CR) Cdentinger: [C: 2] Fold getRetryData into mustache error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332970 (owner: Ejegg) [23:48:27] (Merged) jenkins-bot: Fold getRetryData into mustache error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332970 (owner: Ejegg) [23:49:34] cwd did you want to talk out some redirect stuff? [23:49:57] I might be heading out early today, like in 1/2 hour [23:51:01] ah that's cool, i was getting traction earlier, just taking a break for some CR [23:51:22] cool! [23:52:24] I'm going to turn on a few of the dedupe jobs and see if they play nice over the weekend [23:52:36] ah how long have they been off? [23:54:25] almost two weeks [23:54:44] guess I shoulda had them on for all-hands, probably not many reports being run then [23:57:50] we should do the thing where dedupe runs on a db copy [23:57:58] i think i can imagine how it would work [23:59:14] schedule jobs to merge some records on the main db [23:59:19] the civicrm_*_cache tables would all have to be marked as not for replication [23:59:32] since it writes to those while it's doing the searches [23:59:53] while it searches? i thought those were for edits