[00:10:00] (CR) Cdentinger: [C: 2] Update default queue backend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:10:18] (PS3) Cdentinger: Remove Stomp requirement, update Composer libraries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332716 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:12:05] (CR) jerkins-bot: [V: -1] Update default queue backend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:12:19] hrm? [00:13:18] ugh, one of the form load tests has mismatching tags [00:14:07] wtf, that exact same test passed 13 minutes ago [00:14:13] ejegg: i think i made a ticket for this [00:14:16] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:15:29] ejegg: https://phabricator.wikimedia.org/T154825 [00:15:56] thanks! [00:16:07] no idea what's going on there :-\ [00:16:11] wonder if that's our problem or releng's [00:22:04] now it's not getting merged for some reason [00:26:02] (CR) Ejegg: [C: 2] Update default queue backend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:26:29] oh right [00:26:31] sheesh [00:26:44] my least favorite dance [00:27:17] heh [00:27:33] (Merged) jenkins-bot: Update default queue backend [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332715 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:48:44] (CR) Ejegg: [C: 2] "Self-merging lib update" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332716 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:50:37] (Merged) jenkins-bot: Remove Stomp requirement, update Composer libraries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332716 (https://phabricator.wikimedia.org/T131274) (owner: Ejegg) [00:55:33] (PS1) Ejegg: Remove Stomp, update other libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/333818 [00:56:51] (CR) Ejegg: [V: 2 C: 2] Remove Stomp, update other libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/333818 (owner: Ejegg) [00:57:33] hi, anyone around who knows about updating site-notice on MediaWiki and could help me? [00:57:34] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/333819 [00:58:20] srishakatux: I'm more familiar with the CentralNotice extension (does cross-wiki banners) but I might be able to help [00:58:59] ohh great! thank you. [00:59:19] you probably already looked at https://www.mediawiki.org/wiki/Manual:Interface/Sitenotice [01:00:03] fr-tech folks I'm going to deploy those cleanup patches [01:00:39] ejegg: no I haven't looked at it yet, but will and then ping you for questions! thanks for sharing! [01:00:54] sure thing! I should be around for another hour [01:01:07] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/333819 (owner: Ejegg) [01:01:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/333819 (owner: Ejegg) [01:06:55] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/333820 [01:06:57] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/333820 (owner: Ejegg) [01:09:54] ejegg: hey, so I am looking at it, but seems overly complicated. To update site notice on mediawiki, I go here: https://www.mediawiki.org/wiki/MediaWiki:Sitenotice, do I need to request additional rights from someone? [01:12:24] srishakatux: If you're trying to show the notice to everyone that visits the mediawiki.org site, then yes, I believe you need to be an admin there. If you're trying to change it on a wiki you host, you'd go to the same page but on your own wiki [01:12:51] that is, http(s):///wiki/MediaWiki:Sitenotice [01:13:18] yeah I am trying to change the site notice on mediawiki. [01:13:50] do you know any admins who I could reach out to for help? [01:14:40] srishakatux: I'm not sure exactly who has admin there, but you can probably find them in #mediawiki [01:15:20] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/333820 (owner: Ejegg) [01:15:39] ahha, good advice! okay thank you so much! [01:15:51] you're welcome, and good luck! [01:16:56] !log updated payments-wiki from c22353b6a90e7c9e7be4922e191bbdb0def28e50 to dd8a16dc1cade69419f9c7b8f4703f23bb24d5fb [01:16:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:32:40] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333823 [01:32:49] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333823 (owner: Ejegg) [01:33:48] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333823 (owner: Ejegg) [01:37:42] !log updated SmashPig from 03880ce28f5d3215a47fc0574be3224f2fea552a to ab52dbe6628af2ebc717603259b584031807f6fe [01:37:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:53:59] (PS1) Ejegg: Update libraries (no more Stomp!) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/333827 [01:58:45] (PS1) Ejegg: Remove Stomp, update other libraries [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/333829 [02:02:51] (CR) jerkins-bot: [V: -1] Remove Stomp, update other libraries [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/333829 (owner: Ejegg) [17:33:05] (PS3) Cdentinger: WIP deprecate globalcollect resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330635 [17:33:31] ejegg: hi! you got any ideas for test coverage of the processDonorReturn function? [17:35:46] (CR) Cdentinger: "Is this a fix for the same thing as Ie0c6d33b2585c511f7db0e5040f822b4ca42d1fd ?" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/333793 (https://phabricator.wikimedia.org/T155150) (owner: Ejegg) [17:58:43] hi cwd! [18:00:33] fr-tech: I used to think romantic love was a neurosis shared by two, a supreme [18:00:34] foolishness. I no longer thought that. There's nothing foolish in [18:00:34] loving anyone. Thinking you'll be loved in return is what's foolish. [18:00:34] -- Rita Mae Brown [18:00:34] -- discuss. [18:01:25] I'm around for tech-talk if it's useful to anyone... [18:01:37] Finaly got my microphone working on Hangots, btw [18:03:00] Sure, I'll pop into a call booth. one sec! [18:03:59] i'm learning a thing from jeff atm but if we wrap up i'll pop in [18:04:14] about safe schema changes [18:04:20] also have a meeting with the recruiter in a bit... [18:04:28] cool [18:05:44] (CR) Ejegg: "Yep, it's just a more general fix (with slightly less re-connection overhead). I proposed the same sort of thing to the Predis driver main" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/333793 (https://phabricator.wikimedia.org/T155150) (owner: Ejegg) [18:23:19] (PS8) Ejegg: Fix typos and PHPdoc hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/312069 [18:23:37] (PS2) Ejegg: Prune unused log parameters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/318987 [18:24:08] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/333955 [18:24:31] (PS2) Ejegg: Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) [18:24:41] (PS2) Ejegg: Undo 'require' debug mode hack [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319259 [18:24:43] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/333955 (owner: AndyRussG) [18:27:20] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/333955 (owner: AndyRussG) [18:43:37] AndyRussG: I'm going to say so long to office folks [18:43:46] I'll be back online from the airport for a bit [18:43:49] ejegg: K! [18:43:54] P.S. Where are u flying to? [18:44:02] Have a great flight! [18:44:09] back to Boston for a little bit [18:44:19] thanks! [18:44:28] likewise thx!! [18:55:18] (CR) Chad: "This is being fixed in I7c14596db4ddd91339b2d2af463d851123a00ae7. If it's still needed, feel free to backport that change to any relevant " [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301905 (owner: Ejegg) [18:55:23] (Abandoned) Chad: Failure to add mainpage is not fatal [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301905 (owner: Ejegg) [20:04:17] fundraising-tech-ops: configure TLS for fundraising syslog collection - https://phabricator.wikimedia.org/T142994#2966421 (Jgreen) note that firewall access is added with this commit: commit 75a8183fa45b36339660cbde6deaa67f7de3112f Author: The Root Date: Tue Jan 24 19:58:15... [20:05:15] (Abandoned) Cdentinger: use composer-merge-plugin [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/300471 (owner: Cdentinger) [20:06:42] (Abandoned) Cdentinger: [WIP] remove queueMessageToNormalized [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301865 (owner: Cdentinger) [20:07:06] (Abandoned) Cdentinger: update php-queue to 7834573f5dc2ab8935684259661b4a1fa83978cf [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/313124 (owner: Cdentinger) [20:23:09] (CR) Cdentinger: "What do you think about trying to get it upstreamed first via github, and then we can pull the change down? From an ops perspective it wo" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/333793 (https://phabricator.wikimedia.org/T155150) (owner: Ejegg) [21:11:46] (CR) Ejegg: "Sure, the other patch should be enough to fix out issue (once it's deployed). I'll start making pull requests to the upstream phpqueue rep" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/333793 (https://phabricator.wikimedia.org/T155150) (owner: Ejegg) [21:45:10] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#2966828 (mforns) @AndyRussG What are your thoughts about @JAllemandou 's comments on the patch? Would a minutely resolution be interesting for you?... [21:54:28] Cool, free wi-fi on the plane! [21:54:57] sadly outbound ssh seems to not work [21:55:50] eileen: I'm taking a stab at civi-extension-ify-ing the large donation notifications [21:56:46] and I'd like to try using angular for the UI [21:57:31] but submission is not going to be a standard API call, so I need to add a new ajax endpoint or new api operation [21:58:10] do you know of any examples of the right way to add that? [21:58:50] ejegg: you can add a new api just by putting a correctly named file in the right place [22:00:08] this is an api called by civicrm_api3('PaymentProcessor', 'pay' $params); [22:00:09] https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/blob/master/api/v3/PaymentProcessor/Pay.php [22:00:26] Ah, thanks! Will take a look [22:01:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing contact records from individual records to organization records - https://phabricator.wikimedia.org/T156193#2966913 (LeanneS) [22:07:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ensuring converted organization records are consistent - https://phabricator.wikimedia.org/T156194#2966935 (LeanneS) [22:18:02] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Value Subtracting, Fundraising Sprint Waiting for Godot, and 4 others: Fix Coinbase file to support importing UTM fields - https://phabricator.wikimedia.org/T153791#2967027 (Eileenmcnaughton) @CCo... [22:26:39] hmm, I guess the contribution alerts ought to be a civicrm entity instead of just a random table [22:28:37] :-) [22:29:55] you know sched reminders could probably have an amount criteria added & be used to send the notifications [22:33:10] Oho, really? I'll look into that [23:05:48] MediaWiki-extensions-FundraisingChart, Security-Reviews: Security review for mediawiki/extensions/FundraisingChart - https://phabricator.wikimedia.org/T68805#2967166 (demon) Open>Invalid Not needed/wanted anymore, best I can tell. [23:07:25] MediaWiki-extensions-FundraisingChart, Technical-Debt: Unused code in FundraisingChart - https://phabricator.wikimedia.org/T70510#2967183 (demon) Open>declined Nobody cares [23:31:45] huh, git-review doesn't want to submit via https [23:36:00] :-( [23:36:47] re the whole sched reminders idea - not sure this can be used but Allan (who did some stuff for MG) has just logged this https://issues.civicrm.org/jira/browse/CRM-19923 to help send sched reminders