[00:00:19] woohoo! [00:01:55] ugh google is messing with me [00:02:00] be to meeting shortly [00:03:33] cwd: do you want us to call you in? [00:03:54] no sorry it's just a sign in thing [00:04:02] ah ok [00:06:10] Fundraising-Backlog: Sync email behavior data with Civi contact records - https://phabricator.wikimedia.org/T156422#2974752 (ggellerman) p:High>Normal [00:10:45] Fundraising-Backlog, fundraising-tech-ops: nginx apt proxy cache sometimes fails - https://phabricator.wikimedia.org/T156053#2974771 (ggellerman) p:Triage>Normal [00:11:53] Fundraising-Backlog: Sync email behavior data with Civi contact records - https://phabricator.wikimedia.org/T156422#2974778 (Ejegg) [00:18:07] AndyRussG|a-whey: can you hear us on the call? [01:18:14] (PS3) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [01:18:50] (PS4) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [01:36:09] (PS5) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [01:36:11] (PS1) Ejegg: WIP PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [01:38:58] (CR) jerkins-bot: [V: -1] WIP PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [02:01:06] Fundraising-Backlog: Sync email behavior data with Civi contact records - https://phabricator.wikimedia.org/T156422#2974150 (CaitVirtue) +1. Along with de-dupe, this project would give us more of the longitudinal data that will help us understand donors' full experience with us. I think its essential infor... [02:05:46] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow log in - looks like it's drupal cron - https://phabricator.wikimedia.org/T155084#2975113 (CaitVirtue) I had closed all my Civi tabs about 5 min ago, and then just tried to open up a new one (6:04pm loc... [05:08:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Avoid the increasing length of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2975287 (Jseddon) p:Normal>Lowest [17:15:54] Fundraising-Backlog: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#2976979 (DStrine) When we need to scale down, we can cut the text for super small icon spaces. [17:36:19] hi fr-tech! [17:36:58] mornin! [17:37:27] hey! [17:45:20] anybody have an opinion on this PSR-7 thing that defines a standard interface for dealing with HTTP requests? [17:45:41] http://www.php-fig.org/psr/psr-7/ [17:46:34] Maybe we should conform to that with whatever we write to make API calls [17:49:21] hmmmmmm [17:49:23] reading [17:50:04] this criticism seems relevant: https://evertpot.com/psr-7-issues/ [17:50:35] basically, the requests are supposed to be immutable, but can't actually be when streams are concerned [17:50:45] for our use case, that should never matter [17:50:58] gonna be pretty small requests [17:51:40] guess the immutability does lend itself to your favorite coding style cwd [17:51:46] $request = $request ->withMethod('POST') ->withUrl(new Url('http://example.org/') ->withHeader('Content-Type', 'text/plain'); [17:52:28] and supposedly all those clones don't hurt performance noticably [17:53:38] yep, everything being immutable is a functional approach [17:54:24] which is in some way what i try to do with php there :P [17:56:05] i think these are good recommendations but i also think our current code is pretty far afield from it [17:56:41] k, this is seeming sensible to me. I had written a cURL wrapper for SmashPig, but I'mma toss that and pull in ringcentral/psr7 (which supports php5.3) [17:56:56] fancy [17:57:07] Then when we go to 5.4, we can switch to guzzle with just a config change, I think [17:57:30] guessing we can go straight to 5.6 [17:57:40] word [17:58:20] it's what's in jessie [18:00:17] oh hey, this will be useful for mocking any of those things without having to write a mock implementation: https://gerrit.wikimedia.org/r/333801 [18:00:25] mind taking a look cwd / XenoRyet ^^^ [18:00:31] fr-tech: It is much easier to be critical than to be correct. [18:00:31] -- Benjamin Disraeli [18:00:32] -- discuss. [18:00:46] just lets us build a mock in setUp() and inject the instance directly into the config object cache [18:01:44] Yea, was just looking at one more thing on that DI cleanup one, then this was next on my CR list. [18:09:48] (CR) XenoRyet: [C: 2] Remove unused api_request stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332971 (https://phabricator.wikimedia.org/T87043) (owner: Ejegg) [18:12:10] (Merged) jenkins-bot: Remove unused api_request stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/332971 (https://phabricator.wikimedia.org/T87043) (owner: Ejegg) [18:19:38] (CR) XenoRyet: [C: 2] Override configuration with specific instances [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333801 (owner: Ejegg) [18:21:17] (Merged) jenkins-bot: Override configuration with specific instances [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333801 (owner: Ejegg) [18:23:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: "remove all projects from a campaign" doesn't work - https://phabricator.wikimedia.org/T156065#2962966 (AndyRussG) Aaaarg I think the same thing can also happens with languages... Not sure if it's a back-end issue or something platform-specific and... [18:31:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Move WMF-specific project list to mediawiki-config, from global var default - https://phabricator.wikimedia.org/T156221#2977273 (AndyRussG) Ooops, wrong bug number... [18:39:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Move WMF-specific project list to mediawiki-config, from global var default - https://phabricator.wikimedia.org/T156221#2977316 (AndyRussG) [18:41:17] fr-tech d'oh, Psr7 has nothing about executing the requests, just building them! [18:44:23] greenhouse page load is 8mb [18:46:22] blarg! [18:47:44] and basically no images [18:47:46] it's all js [19:03:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, I18n, RTL: Punctuation incorrectly placed for English text in banners on right-to-left written wikis - https://phabricator.wikimedia.org/T47941#2977383 (AndyRussG) [19:15:58] bah, psr-7 isn't getting me much [19:34:02] (PS6) Ejegg: WIP: Add cURL wrapper and PSR-7 request builder [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [19:34:52] So... gonna just rearrange the non-PSR-7 version [20:01:15] (PS7) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [20:05:35] (PS4) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 [20:05:36] (PS2) Ejegg: Push PaymentResult down into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333152 [20:05:38] (PS8) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [20:24:52] (PS2) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [20:26:18] (CR) jerkins-bot: [V: -1] PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [20:26:36] (PS1) Ejegg: WIP add PaymentParameters and BasePaymentProvider (noSDK branch) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334709 [20:45:41] (PS9) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [20:45:43] (PS3) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [20:46:18] (PS4) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [21:01:15] Check it out ^^^ proof of concept for the cURL wrapper! [21:03:00] going to get some food, back in a bit [21:27:42] (PS2) Ejegg: WIP add PaymentParameters and BasePaymentProvider (noSDK branch) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334709 [21:27:44] (PS2) Ejegg: WIP base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 [23:36:00] (PS10) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [23:36:02] (PS3) Ejegg: WIP add PaymentParameters and BasePaymentProvider (noSDK branch) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334709 [23:36:04] (PS3) Ejegg: WIP base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [23:50:42] (PS4) Ejegg: WIP base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692)