[16:39:27] (PS6) Ejegg: WIP base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [16:41:23] (PS7) Ejegg: WIP base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [16:41:43] (PS5) Ejegg: WIP Look up iDEAL banks without Ingenico SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334733 (https://phabricator.wikimedia.org/T128692) [16:45:50] (CR) jerkins-bot: [V: -1] WIP Look up iDEAL banks without Ingenico SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334733 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [17:54:39] century link sent me a bill for over $400 for the internet they never installed [17:56:55] cwd: ?!?!?!?!?!?! [17:57:10] ugh that's terrible [17:57:45] the mind searing incompetence [18:00:11] That's fantastic [18:00:31] fr-tech: I recognize terror as the finest emotion and so I will try to terrorize the [18:00:31] reader. But if I find that I cannot terrify, I will try to horrify, and if [18:00:31] I find that I cannot horrify, I'll go for the gross-out. [18:00:31] -- Stephen King [18:00:31] -- discuss. [18:01:36] (PS11) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [18:01:38] (PS8) Ejegg: Base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [18:20:02] Fundraising-Backlog, FR-Ingenico: remove 3DS for an India test - https://phabricator.wikimedia.org/T156654#2982695 (DStrine) [18:26:16] (PS6) Ejegg: Look up iDEAL banks without Ingenico SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334733 (https://phabricator.wikimedia.org/T128692) [18:26:59] fr-tech anyone for -talk? [18:27:39] (CR) jerkins-bot: [V: -1] Look up iDEAL banks without Ingenico SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334733 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [18:27:48] ejegg: what's the topic today? [18:27:53] ejegg: hey! I'm about if it's useful for me to be talked to [18:27:59] cwd: ^ [18:28:02] also, hi! [18:28:27] cwd I'm still hoping to get some more input on the SmashPig functionality migration [18:28:36] also, hi all! [18:32:49] (PS7) Ejegg: Look up iDEAL banks without Ingenico SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334733 (https://phabricator.wikimedia.org/T128692) [18:34:18] like sdk vs. no sdk? [18:34:31] did you land somewhere on that? [18:34:49] I got the iDEAL request working without the SDK [18:35:19] so I feel like it's not too onerous to go that way [18:35:41] and it saves us a bunch of time adapting to their own logging conventions etc [18:36:13] though I certainly don't have as much error handling and polish as I could [18:37:02] the non-SDK version also has the advantage of being able to pass tests under PHP 5.3 [18:37:41] although hopefully we slay 5.3 soon [18:38:02] what's the link to the sdk? [18:39:28] https://developer.globalcollect.com/documentation/sdk/server/php/ [18:39:31] cwd ^^ [18:40:42] code is here: https://github.com/Ingenico-ePayments/connect-sdk-php [18:42:35] so the first thing we'd use it for would be the ideal bank switcher, but would it also be useful for the big reintegration? [18:42:38] this cURL wrapper code i made for the non-sdk implementation felt a little like reinventing the wheel: https://gerrit.wikimedia.org/r/334453 [18:43:15] cwd yeah, the thought would be to use the same base request generation and signing code for all the Ingenico API calls [18:43:30] hi XenoRyet [18:43:38] hi [18:44:30] Got anything on your mind for tech talk? I'm still soliciting advice on moving adapter functionality into SmashPig [18:45:06] Nothing especially just at the moment. I'm still moderately undercafinated for a Monday morning [18:46:00] feel like doing a settings deployment? [18:46:34] They want to turn off 3DS for an IN/INR test [18:47:20] Na, I'm halfway through updating the laptop. Apparently the boot partition is full yet again. Better finish up with that before I do anything else I think. [18:48:10] k. yeah, mine came set up with an undersized /boot as well, pretty annoying to only have space for 2 kernels [18:48:21] Right? [18:50:56] ejegg: did you do a test version using the SDK? [18:51:26] yep [18:51:49] https://gerrit.wikimedia.org/r/333155 [18:51:52] cwd ^^ [18:51:56] ty [18:52:26] only fails tests b/c of SDK's 5.4 requirement [19:14:07] fr-tech I just pushed a change to the settings repo that could use a lookover before deploying [19:14:17] I'mma grab some food just now [19:50:17] fr-tec did anyone get a chance to review that settings repo change? [19:50:42] *fr-tech, that is [19:52:12] i'll check it out now [19:54:09] ejegg: i'm confused, was it not shut off before? [19:54:56] the comment is confusing i guess [19:56:42] ejegg: I just added an outage to fundraiising calendar & to Casey & Jeff's for the outage - I wasn't sure whether to add you as you don't need to be available but might like to have it on your radar [19:57:27] cwd it was shut off in 2013, and stayed off till we deployed the 1.27 upgrade [19:57:58] with the old way extension setting worked, an empty array totally wiped out any existing defaults [19:58:25] but with extension.json, you specify a merge strategy for array settings [19:58:31] and we specified array_plus [19:58:40] ejegg: i guess i mean, it was commented out before but the comment is the same now [19:58:49] and it's uncommented [19:58:53] was the comment wrong before? [19:58:59] so the empty array in LocalSettings.php ceased to mean anything [20:01:10] oddly, there doesn't seem to be a merge strategy for the old behavior [20:02:33] The comment was correct when it was written [20:02:50] just the underlying behavior change broke it [20:04:01] ok, the comment did not refer to the act of commenting the code out [20:04:14] but in fact the action of the commented out code [20:04:53] ah, right [20:05:13] cool then looks fine to me [20:05:22] eileen1: thanks for the heads up! [20:05:28] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Resolve dedupe conflicts on latitude and longitude - https://phabricator.wikimedia.org/T155677#2983174 (Eileenmcnaughton) Open>Resolved I'm closing t... [20:05:39] Fundraising Sprint Baudelaire Bowdlerizer: CiviCRM dedupe jobs fail noisly if there is nothing to dedupe - https://phabricator.wikimedia.org/T156306#2983176 (Eileenmcnaughton) Open>Resolved [20:05:57] cwd k, I'll deploy that [20:07:29] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: remove 3DS for an India test - https://phabricator.wikimedia.org/T156654#2983188 (Ejegg) a:Ejegg [20:09:52] !log updated payments-wiki config to d98b30bac746cee2619f69799ffc8bcc67362e7a [20:09:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:13:33] Here's a question…. I think we should disable the Update module on prod - since it is behind a firewall & can't check for updates - but I think we should keep it on locally. If I put it in an upgrade script then it will happen on local installs to. I could just disable it on prod. [20:24:46] eileen1: sounds fine to me! [20:25:03] OK - doing it now [20:25:58] !log disable drupal update module on prod. T155084, this should still be on on dev sites so not using update script [20:26:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:26:02] T155084: Slow log in - looks like it's drupal cron - https://phabricator.wikimedia.org/T155084 [20:28:53] ejegg: I also removed the poor man's cron from settings.php - the change is sitting on boron now - I get someone to check it there don't I? [20:29:10] sure, I'll take a look. [20:30:05] eileen1: so we're running the cron job via drupal now? [20:30:20] yes - I added it to jenkins [20:30:50] I'm not sure that setting is strictly required as cron should not run if it already has - but it seems better to add it [20:31:21] cool [20:31:37] did you push the settings change to the git repo? I'm not seeing anything new there [20:32:06] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow log in - looks like it's drupal cron - https://phabricator.wikimedia.org/T155084#2983357 (Eileenmcnaughton) OK I tried logging in just now & it was quick but as soon as I went to a page with 'admin' in... [20:32:43] ejegg: just pushed [20:34:03] eileen1: looks fine to me! [20:34:12] cool [20:42:12] (PS1) Eileen: Add missing module message fixer module. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335084 [20:47:15] !log updated localsettings to a346207afa927e8f2e5d78f14e078ac47e77053 [20:47:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:48:23] (CR) Cdentinger: [C: 1] "I think the code looks pretty good, and definitely attracted to the idea of using a supported library for these interactions." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333155 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [20:57:14] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/335088 [20:58:34] (CR) Eileen: [C: 2] "self-merging, merge commit only" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/335088 (owner: Eileen) [20:59:13] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/335088 (owner: Eileen) [21:14:52] eileen1: shoot i closed the hangout, can you re-paste that civi link? [21:22:45] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface: PayPal EC response processor needs to act on "recurring" flag - https://phabricator.wikimedia.org/T153720#2983566 (XenoRyet) a:awight>XenoRyet [21:24:38] !log updated civicrm from 6b6f5d68e20f268e1502b14c366cea78ff22dc96 to e17622be4b8f077ba23d7de00bb132419723963d [21:24:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:26:03] (CR) Ejegg: "The issues I have with using the SDK are that we'll need to write Ingenico-specific code to handle logging and things like cURL options." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333155 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [21:33:24] (CR) Ejegg: [C: 2] "This does the trick for me locally (though I had to run the drush command a second time to get one straggler). No need to put it in the en" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335084 (owner: Eileen) [21:37:48] (Merged) jenkins-bot: Add missing module message fixer module. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335084 (owner: Eileen) [21:41:37] (CR) Ejegg: "I think this looks OK. Would there be any use for an unknown region code?" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/334410 (https://phabricator.wikimedia.org/T156399) (owner: AndyRussG) [21:43:14] those failmails are from a dedupe query Rosie is running - I'm inclined to let it go a little longer & see if it finishes [21:43:26] k [21:44:54] I have emailed her to check if she has actually given up on the query or is still waiting on it... [21:45:20] hmm spilling into donations now... [21:49:11] ok - that's another 5 mins - I think I will kill it [21:49:47] !log killed long running user-initiated dedupe query [21:49:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:52:48] (PS1) Eileen: Update drupal to 7.5.2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335154 [21:53:18] I'm going to deploy the drupal 7.52 update - it has actually been waiting to deploy for a long time [21:54:45] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog: Upgrade to drupal 7.5 - https://phabricator.wikimedia.org/T143268#2983654 (Eileenmcnaughton) [21:55:31] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog: Upgrade to drupal 7.5 - https://phabricator.wikimedia.org/T143268#2562488 (Eileenmcnaughton) This has just been waiting deployment for a long time. I'm tidying up deployment & uncommitted patches & that Big English thing is over so pushing i... [21:55:57] (CR) Eileen: [C: 2] "https://phabricator.wikimedia.org/T143268" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335154 (owner: Eileen) [21:58:39] ejegg: how are the curl/logging things annoying with the ingenico sdk? what non-standard stuff do we have to pass to curl? sorry if you already addressed this somewhere [21:58:57] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/335159 (https://phabricator.wikimedia.org/T143268) [21:59:29] cwd it's nice to be able to use our own settings for stuff like cURL timeouts [21:59:36] and retry counts [21:59:46] useragent headers [21:59:49] etc [22:01:17] Hmm I just realised a flaw with pushing out the drupal update now. If I run drush updb I'll pick up that update to add an index to nick_name. It only took 3 mins on staging but it could take longer on live & cause replication delay & hence alerts to go to ops [22:01:32] which is bad manners [22:01:33] in order to do that with the SDK, we need to supply an instance of something that implements their Connection interface [22:02:08] Jeff_Green: ^^^ eileen wants to add an index to nick_name. [22:02:31] not a widely used field, but it's on the contact table [22:02:41] can we do it on Weds? [22:02:59] i gotta run at the moment, daughter has violin lesson! [22:03:05] see ya! [22:04:03] ejegg: like this but different? https://github.com/Ingenico-ePayments/connect-sdk-php/blob/1455cb14b3f33ab5cd5b4207bfd189549bccc6d8/lib/Ingenico/Connect/Sdk/DefaultConnection.php [22:04:23] cwd yep! [22:04:46] Jeff_Green: yep it can wait [22:05:12] I'm not even sure it will cause any delay / replication but don't want to create hassle if it does [22:05:34] so, it's actually not too bad for Ingenico, but I'm thinking if we want to have tons of gateways we might be better off not having to do that for everything [22:06:18] cwd for instance, there's no way to do that with the Amazon SDK if we wanted to [22:06:55] override their curl handling? [22:07:10] right [22:07:23] or get some interesting logging from within the SDK methods [22:08:02] there's some useful stuff in the whole do_transaction mess [22:08:06] i guess i would hope they'd be implemented in such a way that you shouldn't have to do those things? [22:08:17] like getting average timings on API calls [22:08:29] like, in small enough components that the calling code should have sufficient granularity [22:09:35] you mean the SDKs? [22:09:52] yeah [22:11:51] generally their usage is like sdk->initiatePayment( $params ) and that does the whole API call and decodes the result [22:14:47] for the ingenico one anyway, it seems like they want you to implement this connection but make your own [22:14:52] and do whatever you want with curl etc [22:16:16] cwd yeah, I'm just thinking we should be independent of the SDKs if we want to be a library [22:16:37] to standardize usage across different payment providers [22:17:45] it seems like this is already a purpose built open source library [22:18:19] do we really want to duplicate it? [22:18:44] (PS2) Eileen: Add datachecks extension. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/329654 (https://phabricator.wikimedia.org/T152474) [22:19:13] cwd still on the fence about that [22:19:56] i think if there's no good lib out there let's make one, but if there is a good one we should use it and contribute [22:20:15] feels like better floss citizenship to me [22:21:06] hmm, i guess i should try writing an adapter for that cURL wrapper to make it speak Ingenico-ese [22:21:12] (CR) Eileen: "I've responded to your comments in the code. WRT whether it will always be a one to one - I had intended that although the duplicate locat" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/329654 (https://phabricator.wikimedia.org/T152474) (owner: Eileen) [22:22:18] (PS12) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [22:25:13] ejegg: i would be most interested in seeing what the simplest implementation of the ingenico sdk looked like [22:25:23] without e.g. smashpig [22:27:07] cwd we could use the SDK directly in DonationInterface and just use our own code to look up the credentials [22:27:20] actually, the SmashPig patch is pretty bare bones as it stands [22:27:31] with no logging or http overrides [22:31:50] (PS1) Ejegg: Fix paypal EC transformer list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/335162 (https://phabricator.wikimedia.org/T134445) [22:32:07] XenoRyet|eats: ^^^ should fix the amount validation [22:37:33] (CR) XenoRyet: [C: 2] Fix paypal EC transformer list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/335162 (https://phabricator.wikimedia.org/T134445) (owner: Ejegg) [22:39:43] Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface: Paypal Express Checkout form does nothing when you press 'Continue' - https://phabricator.wikimedia.org/T156692#2983796 (Ejegg) [22:41:21] XenoRyet: seems like that's ^^^ a blocker for any test, as well as the bad thank you page URLs: https://phabricator.wikimedia.org/T152626 [22:41:28] want to each claim one? [22:42:06] Sure, you got an eye on one or the other? [22:42:18] i'm good with either [22:42:49] Alright, I'll take the thank you one I suppose. [22:43:10] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: PayPal EC thank you is using full locale rather than language code - https://phabricator.wikimedia.org/T152626#2983810 (XenoRyet) a:XenoRyet [22:50:35] i'm gonna get a little yard work done while it's light out, back later! [22:51:58] (PS1) Ejegg: Fix dead 'Continue' button on paypal EC form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/335166 (https://phabricator.wikimedia.org/T156692) [22:52:20] XenoRyet: looks like I got the easy one! ^^ [22:52:30] we just weren't loading the form scripts at all [22:53:15] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: Paypal Express Checkout form does nothing when you press 'Continue' - https://phabricator.wikimedia.org/T156692#2983870 (Ejegg) a:Ejegg [22:53:27] Heh, nice [22:54:08] If you want to take a crack at the thank you on as well, I'm not posessive. I could go back to the recurring business. [22:58:14] i'm in a Civi meeting in a couple minutes, but I might look at that after [22:58:29] cool [22:59:24] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: PayPal EC thank you is using full locale rather than language code - https://phabricator.wikimedia.org/T152626#2983913 (XenoRyet) a:XenoRyet>None [23:05:31] (CR) XenoRyet: [C: 2] Fix dead 'Continue' button on paypal EC form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/335166 (https://phabricator.wikimedia.org/T156692) (owner: Ejegg)