[01:38:47] AndyRussG, I think foks, you, and I had a misunderstanding. [01:39:15] About the impression recording %? [01:39:16] He is fine with having "Legacy hiding" completely disabled (making "Special:RecordImpression sample rate" disabled/moot as well) [01:39:19] Yes [01:39:25] K [01:39:30] cool [01:39:35] I imagine it needs more documentation [01:40:01] There is still impression data w/ out the special setting [01:40:16] AndyRussG, so assuming that's off, are you okay with "Limit traffic" being unchecked? [01:40:35] AndyRussG, or set to very high. The "Limit traffic" does affect who sees it AFAICT. [01:40:39] All the setting gives you is higher analytics granularity, at the cost of many millions more background webrequests [01:40:50] He thought you were talking about "Limit traffic" [01:41:18] matt_flaschen: That does affect who sees it, yes. BTW I'm quite happy to explain more and apologies for not realizing what the misunderstanding was [01:41:37] About the limit traffic bit, technically it's not my department... [01:41:52] AndyRussG, I wasn't aware CentralNotice had sub-departments. :) [01:41:57] Heh [01:42:29] Well, it's more a community-driven thing [01:42:29] AndyRussG, but I think we're on the same page, right? "Limit traffic" is a community issue, you don't have strong views on it? [01:42:37] Yeah [01:43:01] AndyRussG, cool, thanks again. [01:43:32] There's community process around banners going out which I'm not intimately familiar with... One staff person to talk to is Seddon. There are also community members who are quite involved [01:44:34] AndyRussG, foks is also on the community-facing side, so he can help. [01:45:15] matt_flaschen: right! I just mean, Seddon is a community outreach staff member who's familiar with this corner of the community [01:45:20] and related customs [01:45:22] Alsoo check out: https://meta.wikimedia.org/wiki/CentralNotice [01:49:08] matt_flaschen: also see https://meta.wikimedia.org/wiki/Special:BannerAllocation [01:49:39] (there you can see what other campaigns may be competing with yours in any given segment of users [01:49:41] ) [01:50:22] matt_flaschen: BTW did u test the banner on mobile? [01:50:35] https://meta.wikimedia.org/wiki/Special:BannerAllocation?project=mediawiki&language=en&country=US [01:51:19] Germany you're at 50% because another campaign: https://meta.wikimedia.org/wiki/Special:BannerAllocation?project=mediawiki&language=en&country=DE [02:47:38] AndyRussG|brb, no, I'll ask foks about it. [03:33:36] matt_flaschen: FYI something weird is infact happening in mobile on mediawiki.org. Banners not loaded correctly, apparently some config weirdness in the settings for banner loader on mobile on mediawiki.org. Not your fault or anything. Also a bug in CN apparently is making it not register the banner loading error. I'll investigate more and file a bug tomorrow.... ;p [05:24:58] matt_flaschen: hey bud [12:16:33] Fundraising Dash, Fundraising Sprint Yo La Tengo, Patch-For-Review, Unplanned-Sprint-Work: Add date picker to Totals Earned widget - https://phabricator.wikimedia.org/T94110#2989501 (Aklapper) This patch was merged more than a year ago. What is left to do in this task? [17:28:42] Fundraising-Backlog, Spike: Spike: list of tools which need a UI/UX designer's advice - https://phabricator.wikimedia.org/T156935#2990401 (DStrine) [18:00:31] fr-tech: Nostalgia just isn't what it used to be. [18:00:31] -- discuss. [18:04:55] (CR) XenoRyet: [C: 2] Fix paypal result routing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/335371 (https://phabricator.wikimedia.org/T152626) (owner: Ejegg) [18:07:09] (Merged) jenkins-bot: Fix paypal result routing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/335371 (https://phabricator.wikimedia.org/T152626) (owner: Ejegg) [18:21:31] fr-tech anyone got news for scrum of scrums? [18:21:44] Negative [18:24:12] all good here, thanks! [18:24:34] ejegg: i added a comment from yesterday here: https://www.mediawiki.org/wiki/Talk:Fundraising_tech/Chat/Ingenico_Connect [18:24:49] about maybe splitting out the fraud checker from smashpig? [18:25:00] cwd thanks! [18:26:45] i really like the idea of smashpig being a collection of tools [18:27:14] bunch of different composer packages, all in the SmashPig namespace [18:27:45] omnipay is actually split out well too - you just install the payment providers you want to use [18:33:42] interesting [18:33:55] i should look closer at omnipay [18:34:40] I ought to look at more of the payments stuff in Civi too [19:21:18] Thanks for looking into the mobile issue, AndyRussG. Let me know if I can help. [19:21:33] Hey Seddon, how's it going? [19:37:41] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2990958 (Ejegg) [19:38:13] Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal Express Checkout has problems when using a security key - https://phabricator.wikimedia.org/T149525#2755117 (Ejegg) Per @awight 's email, this seems to be all set with the "new layout". [19:39:11] fundraising-tech-ops: configure TLS for fundraising syslog collection - https://phabricator.wikimedia.org/T142994#2990970 (Jgreen) also this requires a new internal use CA and certs, and we'll need to monitor for cert expiration [19:42:26] Fundraising-Backlog, FR-Amazon, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#2990991 (Ejegg) @Ppena / @MeganHernandez_WMF : Do we need to change these settings? It's currently converting and... [19:47:24] XenoRyet: want to talk through the tasks for EC recurring? [19:49:37] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/335485 [19:49:43] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/335485 (owner: Ejegg) [19:50:53] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/335485 (owner: Ejegg) [19:53:40] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/335486 [19:53:42] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/335486 (owner: Ejegg) [19:57:44] ejegg: I think the next thing I need there is access to the paypal console so I can see if I can figure out why they're not sending the recurring flag back to us. [19:57:57] Last email I saw had you asking for access too, did you ever figure out how to get it? [19:58:32] XenoRyet: yeah, I've got access to the console. [19:58:48] Can you set me up too, or is there someone else I need to ask? [19:59:46] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/335486 (owner: Ejegg) [20:01:58] !log updated payments-wiki from dd8a16dc1cade69419f9c7b8f4703f23bb24d5fb to 4466b9deffcab144cdcddd511a3032513370a44d [20:02:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:03:01] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, and 2 others: Investigate Redis connection issues in GC audit parser - https://phabricator.wikimedia.org/T155150#2991065 (Ejegg) Open>Resolved Seems to be working, no recurrence sin... [20:09:27] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 3 others: Paypal Express Checkout form does nothing when you press 'Continue' - https://phabricator.wikimedia.org/T156692#2991087 (Ejegg) Open>Resolved No... [20:10:45] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2991106 (Ejegg) [20:10:47] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: PayPal EC thank you is using full locale rather than language code - https://phabricator.wikimedia.org/T152626#2991104 (Ejegg) Open>Resolved Routes me to the correct URL now! [20:17:17] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Make PayPal listener understand Express Checkout - https://phabricator.wikimedia.org/T130851#2991137 (Ejegg) Express checkout payment is now recorded as gateway paypal_ec in Civi. m... [20:23:30] gotta relocate [20:38:37] hi cwd [20:38:54] sup ejegg [20:39:58] cwd or XenoRyet I'd be really grateful if we could get one of the versions of iDEAL lookup merged in SmashPig [20:41:23] hmm ok, how do you want to approach it wrt yesterday's conversation? [20:42:13] I stil like the thought of starting with no SDK then adding that if we need to [20:42:16] i think at this point the non-sdk implementation is cleaner, but if we go down that road i highly doubt it'll get rethought [20:42:41] i feel like we wouldn't want to add the sdk as much as build the application around it [20:43:38] well, we can revisit before we move anything more that the lookup into SmashPig [20:43:45] *than the lookup [20:43:56] fair enough [20:44:00] Also has the advantage of not needing to ditch 5.3 just yet [20:44:15] yeah that's true [20:45:26] (PS9) Ejegg: Base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [20:45:28] (PS8) Ejegg: Look up iDEAL banks without Ingenico SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334733 (https://phabricator.wikimedia.org/T128692) [20:46:01] I'll maybe flesh out that test while you look at the CurlWrapper bit [20:46:13] ejegg: is the curl wrapper thing necessary? [20:46:27] isn't there already machinery for that in SP? [20:46:35] (PS5) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [20:46:54] cwd nope, that's why you had to create it for the PayPal verification [20:47:16] ^^^ demonstrates that verification using the common code [20:51:47] Fundraising Dash, Fundraising Sprint Yo La Tengo, Patch-For-Review, Unplanned-Sprint-Work: Add date picker to Totals Earned widget - https://phabricator.wikimedia.org/T94110#2991287 (Ejegg) Open>Resolved Ah, I guess we can close this now. The mentioned patch isn't the full solution, but w... [20:55:41] ejegg: was the paypal listener really the first thing to do http requests from smashpig? [20:56:48] hmm, no, actually Amazon and Adyen do https requests too [20:57:02] Amazon via a totally opaque SDK [20:57:16] and Adyen via a similarly opaque SOAP library [20:57:29] would be really nice to get rid of that thing too! [20:57:36] heh [20:57:36] They have a REST endpoint as well [20:58:35] general REST stuff might be another opportunity for common helper classes [21:44:44] (PS10) Ejegg: Base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [21:47:23] (PS11) Ejegg: Base class for Ingenico payments without SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333154 (https://phabricator.wikimedia.org/T128692) [21:48:57] couple of tests for the Ingenico signature code ^^ [21:49:18] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Add date picker to Totals Earned widget - https://phabricator.wikimedia.org/T94110#2991444 (Pppery) [21:49:49] (PS1) Eileen: CRM-19953 only get (potentially slow) entity data if return not set [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/335543 [21:51:00] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: remove 3DS for an India test - https://phabricator.wikimedia.org/T156654#2991449 (Ejegg) Open>Resolved This is turned back off [21:51:35] Can someone review that gerrit just above - it needs to be done before we can run the CiviCRM upgrade [21:51:48] sure thing eileen1 ! [21:52:08] it's an easy one - I did a hard version upstream [21:52:13] eileen1: great! there is some sql needs run right? [21:55:54] eileen1: just curious, where are we calling the PriceSet code? [21:55:58] cwd yeah - I'm going to work on writing up what needs to be done now [21:56:13] ejegg: the price set code is called from contribution view screen [21:56:30] There is a core change that causes it to call that api to get a small piece of info [21:56:39] gotcha [21:56:48] but, it turns out the api was always ridiculously inefficient in some cases [21:58:03] eileen1: great, lmk when you've got it? [21:58:11] think i'm gonna do the stuff tonight, w/ jeff's supervision [21:58:48] eileen1: so when 'return' IS set, we're saying we only want specific fields from the price_set table, and there's no reason to grab entire entities [21:59:24] yep [21:59:41] it's non an ideal fix - but it gets us past this [21:59:48] & upstream I did some refactoring [22:00:01] so I did the 'get this to work and do some code improvement' [22:00:19] but I could have spent a week on that code! [22:00:35] whew... [22:01:12] well, seeing as how we don't actually give out premiums I'm not too concerned about doing the quick fix [22:01:18] :-) [22:01:24] I put the quick fix upstream too [22:01:53] (CR) Ejegg: [C: 2] "This version looks fine for our purposes!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/335543 (owner: Eileen) [22:03:34] cwd I have added an outage log to the bottom of this page https://collab.wikimedia.org/wiki/Checklists_for_maintenance_%26_Recovery - so far it is a copy & paste but now I'll clean it up for this time. I don't think we need to take banners down since it will be shortish & traffic is low so there won't be a long catch up - agree? [22:04:10] lessee... [22:04:41] looks like I already missed sending an email 1 day before & checking emails aren't going out. [22:05:08] eileen1: as long as we turn the consumers off i can't see it being a problem [22:05:15] this is the upgrade log https://etherpad.wikimedia.org/p/2017-01-01CiviCRM-upgrade - [22:05:19] and if something explodes we can shut everything down [22:05:21] (just copy of last time) [22:05:28] (Merged) jenkins-bot: CRM-19953 only get (potentially slow) entity data if return not set [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/335543 (owner: Eileen) [22:18:01] (PS1) Eileen: Commit updated CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335553 [22:23:50] (CR) Eileen: [C: 2] Commit updated CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335553 (owner: Eileen) [22:25:14] fr-tech or Jeff_Green can anyone think of a reason that DonationInterface should use its own Memcache access instead of the mediawiki BagOStuff? [22:26:15] my only thing would be getting even more married to mediawiki [22:26:32] I want to cache the iDEAL lookups, but the stuff we're using for the velocity filter is unmockable [22:27:42] cwd yeah, I was thinking that the fraud filter library should be cache-agnostic, and just recieve callbacks for storing and retrieving data [22:27:48] (Merged) jenkins-bot: Commit updated CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335553 (owner: Eileen) [22:28:09] dig it [22:29:36] so I figured caching as part of the frontend app makes sense, and the BagOStuff part of mediawiki's code is well tested and easy to mock [22:35:33] (CR) Cdentinger: Add cURL wrapper (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 (owner: Ejegg) [22:35:48] (PS1) Eileen: Add index to activity_date_time column. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335556 [22:36:22] ejegg: yeah makes sense to me, if we sufficiently abstract the forms running the frontend on mediawiki doesn't feel so bad [22:36:35] if DI becomes a light weight extension [22:41:51] thanks for the CR cwd! [22:43:12] sure thing! looks good in general, once i realized that this code does not already exist in SP [22:46:41] OK I think the outage list looks OK now - I've added in some optional tasks that can happen or wait depending on how we are going - including https://gerrit.wikimedia.org/r/#/c/335556/ [22:47:20] that last one needs someone to bless it but not +2 it - so I can +2 if we decide we have time to deploy [22:47:33] outage is here https://etherpad.wikimedia.org/p/2017-01-01CiviCRM-upgrade [22:53:47] (CR) Ejegg: [C: 1] "Seems fine to me. Only worry is that this will slow down mailing activity insertion by another tiny fraction." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335556 (owner: Eileen) [22:55:18] (CR) Ejegg: "Thanks for the CR! I'll think about ways to abstract the retry logic" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 (owner: Ejegg) [22:56:20] (CR) Eileen: "When I did tests on adding the logging tables I didn't find any performance difference when I added indexes to them - which was a positive" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335556 (owner: Eileen) [23:01:00] (CR) Ejegg: "Oh, http_parse_headers is part of PECL http. I'd prefer not to depend on that for something so simple." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 (owner: Ejegg) [23:24:16] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Rocket Surgery 2016, Fundraising Sprint Stirring The Pot, and 11 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2991756 (AndyRussG) Looking forward to the deploy... [23:35:54] Fundraising-Backlog, FR-PayPal-ExpressCheckout, Epic: Epic: Distinguish PayPal legacy vs. Express Checkout transactions - https://phabricator.wikimedia.org/T138013#2991779 (DStrine) [23:35:57] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Make PayPal listener understand Express Checkout - https://phabricator.wikimedia.org/T130851#2991778 (DStrine) Open>Resolved [23:43:14] Fundraising-Backlog, Spike: Spike: list of tools which need a UI/UX designer's advice - https://phabricator.wikimedia.org/T156935#2990401 (Ejegg) Civi donation imports, including error handling Internal dashboard [23:46:00] Fundraising Sprint C 2017, Fundraising-Backlog, Spike: Spike: list of tools which need a UI/UX designer's advice - https://phabricator.wikimedia.org/T156935#2991805 (DStrine) [23:46:02] Fundraising Sprint C 2017, Fundraising-Backlog, FR-Smashpig, Spike: Spike: investigate smashpig next steps - https://phabricator.wikimedia.org/T156863#2991806 (DStrine) [23:46:04] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising-Backlog: fill out PCI SAQ-A form for 2017 - https://phabricator.wikimedia.org/T155779#2991807 (DStrine) [23:46:07] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Value Subtracting, and 3 others: Move creation of contribution tracking create for offline to within the transaction loop - https://phabricator.wikimedia.org/T154528#2991810... [23:46:09] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Method to bypass/purge CentralNotice cache when forcing banner - https://phabricator.wikimedia.org/T154954#2991809 (DStrine) [23:46:11] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Waiting for Godot, and 3 others: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2991812 (DStrine) [23:46:13] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Waiting for Godot, and 2 others: Blank address data being collected & stored as an address - https://phabricator.wikimedia.org/T153804#2991813 (DStrine) [23:46:15] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Value Subtracting, and 4 others: Fix Coinbase file to support importing UTM fields - https://phabricator.wikimedia.org/T153791#2991814 (DStrine) [23:46:17] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: DjangoBannerStats: Handle banner loader error - https://phabricator.wikimedia.org/T152723#2991816 (DStrine) [23:46:20] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Waiting for Godot, and 3 others: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#2991818 (DStrine) [23:46:22] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Waiting for Godot, and 4 others: Figure out why new recurring entries are creating duplicate emails of the same location ... - https://phabricator.wikimedia.org/T152475#2991817 [23:46:24] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Value Subtracting, and 3 others: [Spike] investigate contribution tracking data (was Engage import failing to import cert... - https://phabricator.wikimedia.org/T146295#2991820 [23:46:26] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising-Backlog, and 3 others: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2991823 (DStrine) [23:46:28] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, and 4 others: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2991821 (DStrine) [23:46:31] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint C 2017, Fundraising Sprint Rocket Surgery 2016, and 12 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2991822 (DStrine)