[00:10:38] dinner with the fam tonight, gotta roll a little early but i'll be back on later [00:47:50] fundraising-tech-ops, Operations: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#3007896 (Dzahn) [00:50:35] (PS16) Eileen: Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) [00:54:34] (CR) jerkins-bot: [V: -1] Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [01:07:52] (PS2) Ejegg: Shake up message normalization in PayPal job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) [01:08:03] cwd very curious what you think of that ^^^ [01:08:28] OK, think I'm going to sign off - it's late here! [01:26:14] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Spike: investigate slow queries - https://phabricator.wikimedia.org/T153134#3007982 (Eileenmcnaughton) [01:26:17] Fundraising Sprint Costlier Alternative, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Slow query: core civicrm affecting one of the scheduled jobs - https://phabricator.wikimedia.org/T153128#2870636 (Eileenmcnaughton) Open>... [01:28:27] fundraising-tech-ops, Operations, Patch-For-Review: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#2987822 (Dzahn) check added to Icinga, and it became CRIT right away because the cert expires in 22 days https://icinga.wikimedia.org/cgi-bin/icinga/ex... [01:31:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't add more info to the prospect tab - https://phabricator.wikimedia.org/T157382#3007989 (CaitVirtue) Yup, i can add more data now. thank you! @LeanneS @RLewis Can you both make a note of how to make these changes in case we need to do something si... [01:32:05] fundraising-tech-ops, Operations, procurement: benefactorevents.wikimedia.org SSL cert expires 2017-03-02 - https://phabricator.wikimedia.org/T157520#3007991 (Dzahn) [01:33:42] fundraising-tech-ops, Operations: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#2987822 (Dzahn) [01:41:34] (PS17) Eileen: Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) [01:45:02] (CR) jerkins-bot: [V: -1] Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [01:55:33] (PS18) Eileen: Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) [01:58:51] (CR) jerkins-bot: [V: -1] Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [02:10:18] (PS19) Eileen: Matching gifts import. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) [04:40:55] (PS2) AndyRussG: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) [06:15:07] (CR) Cdentinger: "Seems like a good approach and the code looks sane, will revisit in the morning when I'm more with it" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) (owner: Ejegg) [06:46:20] Fundraising-Analysis, MediaWiki-extensions-DonationInterface: Accept GNU Taler for donations - https://phabricator.wikimedia.org/T157529#3008266 (Koavf) [17:43:13] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, FR-Smashpig, Spike: Spike: investigate smashpig next steps - https://phabricator.wikimedia.org/T156863#3009930 (DStrine) [18:00:31] fr-tech: You shouldn't have to pay for your love with your bones and your flesh. [18:00:31] -- Pat Benatar, "Hell is for Children" [18:00:31] -- discuss. [18:11:04] hi fr-tech! Does anyone have any news for Scrum of Scrums? [18:11:15] None here. [18:12:31] nope! [18:14:35] ejegg: no thanks, all good here! [18:24:31] k, thanks [18:24:40] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising-Backlog, FR-PayPal-ExpressCheckout, and 2 others: PayPal EC response processor needs to act on "recurring" flag - https://phabricator.wikimedia.org/T153720#3010158 (XenoRyet) [19:22:01] Fundraising Tech Backlog: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3010439 (Jgreen) [19:45:24] (PS1) XenoRyet: Add recurring flag to PayPal Return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336666 (https://phabricator.wikimedia.org/T153720) [19:50:05] ejegg: as far as pushing the pp message logic into message classes, seems like a good way to do it to me [19:54:55] cwd ok, how about that static inheritance? [19:55:17] if it's not giving anyone fits, I'm happy to go that way! [19:56:35] i mean i guess i don't love call_user_func but i don't know that it's worse than any alternatives [19:58:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Write some integrity check scripts - https://phabricator.wikimedia.org/T150388#3010644 (Eileenmcnaughton) Note we should schedule the check from https://phabricator.wikimedia.org/T145873 when we hit this [20:00:17] ejegg: one thing that confused me, i have never seen the array arg for call_user_func, and the docs are meh, but i guess it calls ['class', 'method'] ? [20:05:09] cwd oh yeah, you can use a bunch of things [20:05:18] including a function assigned to a variable [20:05:33] but yeah, the 'class', 'method' thing works [20:17:13] (CR) Ejegg: [C: 2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336666 (https://phabricator.wikimedia.org/T153720) (owner: XenoRyet) [20:18:28] XenoRyet: nice quads [20:18:38] dubs and quads [20:18:47] quite a change id [20:19:01] Heh, didn't even notice. [20:19:03] Cool [20:19:25] (Merged) jenkins-bot: Add recurring flag to PayPal Return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336666 (https://phabricator.wikimedia.org/T153720) (owner: XenoRyet) [20:23:44] ejegg: i'm happy with that matching gifts stuff now [20:24:30] & also - that gitignore one doesn't show your +2 - but I'm sure you did [20:24:42] https://gerrit.wikimedia.org/r/#/c/335272/ [20:24:51] Oh weird, I'll re-apply [20:25:02] and check out the matching gifts patch [20:25:21] (PS3) Ejegg: Git Ignore cache directory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335272 (owner: Eileen) [20:25:37] (CR) Ejegg: [C: 2] Git Ignore cache directory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335272 (owner: Eileen) [20:25:46] thx [20:33:58] (Merged) jenkins-bot: Git Ignore cache directory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/335272 (owner: Eileen) [20:38:22] Fundraising Sprint Costlier Alternative, Fundraising-Backlog: Paypal EC missing payment method - https://phabricator.wikimedia.org/T157618#3010931 (XenoRyet) [20:39:12] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Paypal EC missing payment method - https://phabricator.wikimedia.org/T157618#3010931 (XenoRyet) [20:39:25] Fundraising Tech Backlog: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3010951 (Jgreen) INSERT INTO silverpop_excluded (email) SELECT email FROM civicrm.log_civicrm_email ON DUPLICATE KEY UPDATE email = silverpop_excluded.email;... [20:42:34] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Rocket Surgery 2016, and 12 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#3010957 (AndyRussG) From looking at [[ https:... [20:53:41] (CR) Ejegg: Shake up message normalization in PayPal job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) (owner: Ejegg) [21:00:35] (PS1) XenoRyet: Add argument to setGatewayDefaults base function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336683 (https://phabricator.wikimedia.org/T157618) [21:02:33] (CR) jerkins-bot: [V: -1] Add argument to setGatewayDefaults base function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336683 (https://phabricator.wikimedia.org/T157618) (owner: XenoRyet) [21:15:32] (PS2) XenoRyet: Add argument to setGatewayDefaults base function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336683 (https://phabricator.wikimedia.org/T157618) [21:17:44] (CR) jerkins-bot: [V: -1] Add argument to setGatewayDefaults base function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336683 (https://phabricator.wikimedia.org/T157618) (owner: XenoRyet) [21:39:18] Andrew Hunt from AGH Strategies has started doing 'proper' civi release notes - https://github.com/civicrm/civicrm-core/blob/4.7.16-rc/release-notes/4.7.16.md is today's release [21:39:31] (CR) Ejegg: "Ah, I guess all the stubs need the argument added too. Maybe move the stubs into gateway.adapter?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336683 (https://phabricator.wikimedia.org/T157618) (owner: XenoRyet) [21:39:40] note - I think when we deploy that we can do it without outage but I will test on staging first [21:41:35] dstrine-brb: any reason the current sprint has no 'pending deployment' column? [21:51:27] I was wondering when someone would notice that :-) [21:51:47] I think what happened is David didn't do something when creating the sprint that made the columns [21:51:53] & I tinkered & created some [21:51:59] for the things I needed.... [21:52:08] & lost interest before the Pending Deployment column [21:52:52] ahh, got it! [21:53:33] I think the first time you load the sprint tag as a workboard, it gives you the opportunity to copy columns from another board. [21:53:42] so maybe someone else hit it first and didn't choose that [21:54:07] created it [22:11:19] ejegg: is right about the columns. It's possible someone clicked through while we were in sprint planning and setup the default columns. I'm not sure how I missed that step. [22:11:45] I usually do all that before the meeting [22:41:35] fr-tech do we need to do a whole bunch of code review for the vulnerability meeting tomorrow? [22:42:14] fr-tech seems like knowing if we were vulnerable depends on looking at all the places we mail things [22:58:05] ejegg: good thinking [22:58:32] we basically need to see if we were ever setting an arbitrary sender? sounds super unlikely but you never know... [22:59:29] (CR) Ejegg: [C: -1] "Smoke tests well! Need to scrub junk location data." (6 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/334235 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [22:59:56] cwd right, if we ever set the sender to user input [23:02:48] AndyRussG: you free for another chat? [23:08:34] ejegg: another aspect to that problem is trusting the assumptions about the nature of a zero day [23:08:45] vs. shutting things off "just in case" [23:09:07] cwd right, if we ever set the sender to user input [23:09:40] ejegg: but i mean, trusting the early assumptions that that was the only attack vector [23:10:03] Fundraising Tech Backlog: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3011426 (Jgreen) The second query is the one that joins civicrm.civicrm.contact and civicrm.wmf_donor tables and populates silverpop.silverpop_export_staging... [23:42:27] sorry, was in another meeting [23:47:16] so fr-tech, it's a bit late to split up all our codebases [23:47:37] sorry I didn't consider this earlier. I totally forgot we were having that meeting tomorrow :( [23:49:58] i should have thought of that too, didn't really consider [23:50:02] Part of the meeting can probably be just making the plan for checking our vulnerability. [23:57:01] Fundraising Tech Backlog: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3010439 (Ejegg) Hmm, sounds like that would mean a bunch of rewriting the base code. Currently the python script just takes a big SQL file, splits on semicol...