[00:02:35] ejegg: Back. What'd you have in mind? [00:02:55] I've got about an hour before I have to go pick up the boy [00:05:49] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337521 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [00:06:21] XenoRyet: just continuing along these lines: https://gerrit.wikimedia.org/r/335742 [00:08:20] (PS1) Eileen: Add tests for relationship creation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337523 (https://phabricator.wikimedia.org/T115044) [00:08:31] ejegg: I think the other thing I wanted to fix up might be fine actually - I tried checking for relationships in the tests & they seem to be there in all scenarios [00:09:39] oh, nice [00:09:48] (Merged) jenkins-bot: Fix Benevity import to only soft credit one way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337521 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [00:10:59] (CR) Ejegg: [C: 2] "Nice confidence-raising measure!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337523 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [00:11:32] (PS1) Eileen: Revert comment change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337524 [00:11:56] (CR) Ejegg: [C: 2] ":)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337524 (owner: Eileen) [00:12:18] eileen1: so, the upstream civicrm-buildkit was failing because the build servers were missing the mcrypt extension (or at least it thought they were) [00:12:53] e.g. https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/3915/console [00:13:49] XenoRyet: does that patch look good as a first step? [00:14:37] (Merged) jenkins-bot: Add tests for relationship creation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337523 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [00:14:51] Yea, looks like a fine approach to me. [00:15:42] (Merged) jenkins-bot: Revert comment change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337524 (owner: Eileen) [00:21:14] XenoRyet: so I think we can merge and deploy that one with no change to the queue consumers [00:21:44] It smoke test ok for you? [00:22:42] ah right, that :) [00:23:55] I mean, looks like it should, but better safe than sorry. [00:25:02] anyway, the step after that would be to move the normalizations from here: https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/queue2civicrm/recurring/RecurringQueueConsumer.php#L118 into the new Recurring message class [00:25:44] Yea, makes sense [00:26:20] but we'll need to update the recurring queue consumer's logic a bit, since we'll still want to reconstruct the contribution_tracking_id, but we won't want to try to double-normalize the messages [00:26:39] Mind helping me smoke test that first change? [00:26:51] I guess we'll want to try both a recurring and a standard message [00:28:11] Sure. [00:28:49] Want to pick one? [00:29:29] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/337527 [00:29:53] I think I have some recurring in my local queue already [00:30:09] (CR) Eileen: [C: 2] "self-approving, merge to deployment" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/337527 (owner: Eileen) [00:30:24] XenoRyet: in the paypal-jobs queue? [00:30:36] Yea, from some earlier testing [00:30:41] cool, I'll do the standard payment [00:30:54] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/337527 (owner: Eileen) [00:31:13] err wait, I'm thinking of the donations queue, but I'll take recurring anyway. [00:32:05] ok, I see that my jobs-paypal queue has a few types in it too [00:39:03] !log update civicrm from 7b36996e87387bb4982cc6937dc8bcbc7952eaf2 to 8d04e75939c5300f0a18e03fdb044c6673b3a74e [00:39:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:41:34] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising-Backlog, and 3 others: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#3023809 (Eileenmcnaughton) @L... [00:42:04] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Engage import error when comma present in amount - https://phabricator.wikimedia.org/T158005#3023211 (Eileenmcnaughton) @LeanneS I also just deployed this [00:46:31] XenoRyet: oops, totally mangling the recurring ones! [00:46:49] How'd that happen? [00:47:23] ejegg: I'm wondering about whether to kill this one now https://phabricator.wikimedia.org/T154528 [00:47:49] i think it would only have applied to the import & I resolved that in the Benevity fixes [00:48:11] anything coming in through the queues is already wrapped in a transaction I believe [00:50:14] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Value Subtracting, and 3 others: Move creation of contribution tracking create for offline to within the tr... - https://phabricator.wikimedia.org/T154528#3023860 [00:52:16] cafe is closing, one minute! [00:53:50] I'm off to get the boy. Catch everybody later [00:57:54] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Value Subtracting, and 3 others: Move creation of contribution tracking create for offline to within the tr... - https://phabricator.wikimedia.org/T154528#3023902 [01:01:02] eileen1: that /looks/ right [01:01:48] ok cool - one more q - do we use CiviMail for retrieving bounces ? [01:02:10] yep, we should be [01:02:53] ok - there are related errors in the log - I am just trying to make sense of them [01:03:02] but we are putting the VERP headers on our thank you mails with some non-api-using code [01:04:06] so I'd suspect the code synthesizing the civimail record has gone stale [01:04:23] it's innwmf_communication [01:04:38] the issue is occurring when a record has no email id [01:04:40] *in wmf_communicaton [01:05:16] I'm not sure if it is due to incorrect code (should handle) or incorrect data (not valid to not have email_id on a civicrm_mailing_event_queue record [01:05:33] dang, that's pretty fundamental [01:06:13] not one where the email has been merged and deleted? [01:07:34] figuring it out now…. [01:08:10] are the mailings actual civimail, or thank you batches? [01:10:05] not sure - but actually NULL is valid in the schema for the table [01:10:24] e.g. if you delete an email it will update to NULL by the ON CASCADE [01:10:47] SET NULL [01:10:57] so, the issue is it should handle null [01:11:16] but impact might be that the processBounce job has been silently failing [01:14:31] (CR) Cdentinger: "The idea is that DonationInterface and SmashPig will both conform to PSR-6, but use separate cache backends? What will be the backend here" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337419 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [01:15:08] anyway I know what the path is to fix - but not how to check how many bounces may not have been processed as a result (i.e the impact.) but it seems to be the donate@wikimedia inbox - someone clears that / accesses it don't they? [01:18:03] (CR) Ejegg: "Cwd the backend on payments will be MediaWiki's main cache. DonationInterface will provide a PSR 6 compliant wrapper around BagOStuff. See" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337419 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [01:20:14] hmm, so the bounces aren't going to te special reply-path addresses? pretty sure donate@ goes into a ticketing system for donor services [01:21:55] https://issues.civicrm.org/jira/browse/CRM-20016 [01:22:29] the address it is checking is here civicrm/admin/mailSettings?reset=1 [01:22:49] let me check how the job is configured [01:24:51] drush civicrm-api job.fetch_bounces [01:25:10] huh [01:26:57] I'm seeing Trying to get property of non-object EmailProcessor.php:276 [01:27:09] but not so much a few rounds ago [01:29:04] sorry,gotta relocate again... [02:02:10] (PS1) Eileen: Let's create some noise! [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/337536 [02:53:43] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM log is showing errors relating to importing bounces - https://phabricator.wikimedia.org/T157397#3024007 (Eileenmcnaughton) a:Eileenmcnaughton [02:54:16] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM log is showing errors relating to importing bounces - https://phabricator.wikimedia.org/T157397#3003686 (Eileenmcnaughton) I think it only processes them when the headers ar... [02:56:26] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Value Subtracting, and 4 others: Fix Coinbase file to support importing UTM fields - https://phabricator.wikimedia.org/T153791#3024012 (Eileenmcnaughton) [02:56:30] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Value Subtracting, and 3 others: Move creation of contribution tracking create for offline to within the tr... - https://phabricator.wikimedia.org/T154528#2914791 [03:01:19] (PS4) Ejegg: Shake up message normalization in PayPal job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) [03:09:00] (CR) Ejegg: [C: 2] "Looks like it'll be pretty verbose!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/337536 (owner: Eileen) [03:11:43] gnight all [03:13:03] (Merged) jenkins-bot: Let's create some noise! [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/337536 (owner: Eileen) [05:07:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: banners not showing on mobile versions of mediawiki.org, Wikidata and Wikisource - https://phabricator.wikimedia.org/T158030#3024123 (AndyRussG) [05:15:28] (CR) AndyRussG: "Thanks much!!! :D" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [10:12:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: banners not showing on mobile versions of mediawiki.org, Wikidata and Wikisource - https://phabricator.wikimedia.org/T158030#3024123 (MarcoAurelio) I guess this is particularly problematic with the increased use of mobile devices to... [13:22:44] fundraising-tech-ops, Operations: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3024945 (Jgreen) [13:28:09] fundraising-tech-ops, Operations: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3024989 (Jgreen) fundraising mysql privs, yubikey, and ssh public key have been revoked [14:12:40] fundraising-tech-ops, Operations, Patch-For-Review: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3024945 (MoritzMuehlenhoff) His cluster access has been removed and he didn't have access to the "nda" LDAP group. [15:21:45] (PS1) Ejegg: Message normalization tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337595 (https://phabricator.wikimedia.org/T107372) [15:23:23] (PS5) Ejegg: Shake up message normalization in PayPal job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) [16:54:56] fundraising-tech-ops: configure TLS for fundraising syslog collection - https://phabricator.wikimedia.org/T142994#3025764 (Jgreen) this is done [16:55:06] fundraising-tech-ops: configure TLS for fundraising syslog collection - https://phabricator.wikimedia.org/T142994#3025765 (Jgreen) Open>Resolved [17:10:11] Fundraising-Backlog, fundraising-tech-ops: database access to additional CPS analyst - https://phabricator.wikimedia.org/T155746#3025836 (Jgreen) p:Normal>High [17:10:29] fundraising-tech-ops, Operations, Patch-For-Review: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3025837 (Jgreen) p:Triage>High [17:11:51] fundraising-tech-ops: replace boron (fundraising build server) with new hardware running jessie - https://phabricator.wikimedia.org/T145117#3025847 (Jgreen) [18:00:21] fr-tech: A life lived in fear is a life half lived. [18:00:21] -- discuss. [18:02:53] fr-tech: sorry I wasn't very interactive at the CT-SPOF meet yesterday... I added some notes at the end, basically an initial attempt at an overview, also added some links about UUIDs [18:03:06] (on the ethepad: https://etherpad.wikimedia.org/p/ct-spof) [18:11:47] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Central Notice banners slow to save - https://phabricator.wikimedia.org/T158084#3026116 (spatton) [18:11:58] fundraising-tech-ops, Operations, Patch-For-Review: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3026133 (Jgreen) fundraising shell access revoked civi client cert revoked [18:14:43] Fundraising-Backlog, Patch-For-Review: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3026140 (Jgreen) Does Brent have civi access? If so please disable his login. [18:14:52] Fundraising-Backlog, Patch-For-Review: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3026156 (Jgreen) a:Jgreen>None [18:28:06] Thanks AndyRussG|bassoo ! [18:35:48] (PS2) Ejegg: WIP look up iDEAL banks, cache in Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336333 (https://phabricator.wikimedia.org/T128692) [18:36:23] (CR) Ejegg: [C: -1] "Please check out I457fb093c3777 and I9013355c7cc57d6 instead!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336333 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [18:38:07] ejegg: yw! I just added a few more tidbits, infact ;p [18:38:13] (CR) jerkins-bot: [V: -1] WIP look up iDEAL banks, cache in Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/336333 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [18:38:44] (CR) Ejegg: [C: -1] "Please review I4996945c83e31a60f6 instead" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333155 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [18:40:20] (CR) Ejegg: [C: -1] "Please review I4996945c83e31a60 instead" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335269 (owner: Ejegg) [18:42:49] (PS2) Ejegg: Allow getRequiredFields before unstagedData is set [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323254 (https://phabricator.wikimedia.org/T151411) [18:47:43] (PS5) Ejegg: Better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) [19:05:47] Fundraising-Backlog: Update on call protocols - https://phabricator.wikimedia.org/T157731#3026511 (ggellerman) I updated https://office.wikimedia.org/wiki/Fundraising/Engineering/On_call with new communications protocols discussed in the meeting between FR-tech & Ops. [19:22:18] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising-Backlog, and 3 others: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#3026605 (RLewis) Thanks @Eile... [19:29:37] XenoRyet: I fixed that normalization and added some pretty comprehensive unit tests [19:30:23] Yea, saw your email. Was just in the middle of looking at the tests patch. [19:34:14] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Patch-For-Review: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3026669 (cwdent) [19:34:35] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Patch-For-Review: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3010439 (cwdent) Open>Resolved a:cwdent This is back on lutetium now, will run ther... [19:38:49] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Patch-For-Review: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3026692 (cwdent) Resolved>Open Actually I'm going to leave this open until it runs succ... [19:40:51] (CR) XenoRyet: [C: 2] Message normalization tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337595 (https://phabricator.wikimedia.org/T107372) (owner: Ejegg) [19:43:00] (Merged) jenkins-bot: Message normalization tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337595 (https://phabricator.wikimedia.org/T107372) (owner: Ejegg) [19:54:55] (PS16) Ejegg: Add cURL wrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334453 [19:54:57] (PS8) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [19:55:44] gotta run for a bit, back before grooming [20:15:01] (PS3) Ejegg: Cache bank lookups via PSR-6 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337419 (https://phabricator.wikimedia.org/T128692) [20:15:28] XenoRyet: anything still look alarming about the next patch? [20:16:29] Nope, was just poking one or two bits of the code to be sure, and was about to hit the shiney +2 button. [20:17:27] (CR) Ejegg: "cwd OK, the basic cache is actually doing deferred stuff deferred now." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337419 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [20:17:39] yay! [20:17:58] (PS1) Eileen: Submodule update - (CiviCRM debug noise). [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337635 [20:20:40] (CR) XenoRyet: [C: 2] Shake up message normalization in PayPal job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) (owner: Ejegg) [20:21:04] (CR) Eileen: [C: 2] Submodule update - (CiviCRM debug noise). [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337635 (owner: Eileen) [20:22:31] (Merged) jenkins-bot: Shake up message normalization in PayPal job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/335742 (https://phabricator.wikimedia.org/T107372) (owner: Ejegg) [20:24:51] (Merged) jenkins-bot: Submodule update - (CiviCRM debug noise). [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337635 (owner: Eileen) [20:25:20] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Patch-For-Review: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600#3026896 (Jgreen) Let's keep the task until open for fixing queries that lock civicrm tables fo... [20:30:18] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/337637 [20:30:40] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/337637 (owner: Eileen) [20:30:46] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/337637 (owner: Eileen) [20:38:43] !log update civicrm from 8d04e75939c5300f0a18e03fdb044c6673b3a74e to 0fb289fd385f9f3a71df0c1dedbba8d1b5555730 [20:38:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:43:48] XenoRyet: want to work together on the next steps? [20:44:52] I was gonna try to get some food before backlog grooming, but after that, sure. [20:45:40] k [20:48:11] (CR) Ejegg: [C: -1] "Please review the no-SDK branch version of this patch: I707c960139835" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333153 (owner: Ejegg) [20:49:29] (PS5) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 [20:49:56] ejegg: I got some data on the wierd emails but I'm trying to decide what to make of it… [20:50:02] the bounces thing [20:50:23] 3 bounces with no email http://localhost:9000/job/Fetch%20CiviMail%20Bounces/47317/console [20:50:54] these are all one contact. We sent an email to them & it bounced because in the meantime the contact had been merged [20:51:52] the things is the contact made 3 donations in short-succession so as soon as a thank you went out the contact was merged & deleted [20:52:22] I pointed out the thing to Michael & he said 'thanks, that fits with the PayPal fraudster profile for sure' [20:56:50] oh weird, really? [20:57:11] so merges do confuse the bounce processor! [20:57:34] OK, it kindof doesn't make sense to identify the emails by ID anyway [20:58:16] if a message to that address bounces, we should mark all the copies of that address as 'on hold' [20:58:24] I guess they don't want to block a different email with the same contact [20:58:39] you could make a case to record the email address rather than id [20:58:53] I don't fancy changing it though - altering that table takes hours… [20:58:56] yeah, that's what I was thinking [20:59:24] so, let's see [20:59:40] ejegg, is that what an email address on hold in civi aleays means, that it bounced? [20:59:42] should the merge update any records in the mailing event table? [20:59:46] *always [21:00:04] MBeat: That's the main way they get put 'on hold' [21:00:17] ty, i was wondering about that [21:02:22] I think I could make a case to do 'something' with the merge to update that email_id field - either in core or in our custom code [21:04:01] MBeat: this info seems to be finding fraudsters - how useful would it be to find a way to report on them? You said they pretty much jump out so maybe low return? [21:04:39] i’d be interested in seeing for sure [21:13:18] (PS1) Ejegg: Add missing method visibility [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337658 [21:29:49] (PS1) Ejegg: Fix a couple comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337687 [21:33:18] (PS1) Ejegg: Update exchange rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337694 [21:33:44] dead simple reviews ^^^ [21:33:47] fr-tech [21:35:11] (CR) Eileen: [C: 2] "This seems find since it is auto-generated from code" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337694 (owner: Ejegg) [21:35:52] (PS1) Ejegg: Fix command in CurrencyRates template header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337701 [21:40:44] (CR) Eileen: [C: 2] Fix command in CurrencyRates template header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337701 (owner: Ejegg) [21:45:42] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM log is showing errors relating to importing bounces - https://phabricator.wikimedia.org/T157397#3027283 (Eileenmcnaughton) I've managed to find out when this is happening.... [21:45:53] (Merged) jenkins-bot: Update exchange rates [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337694 (owner: Ejegg) [21:45:55] (Merged) jenkins-bot: Fix command in CurrencyRates template header [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/337701 (owner: Ejegg) [21:46:19] (PS2) Cdentinger: Fix a couple comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337687 (owner: Ejegg) [21:46:39] ejegg: I've posted my analysis here https://phabricator.wikimedia.org/T157397#3027283 - let me know if you think it's worth worrying more about the possible follow up actions I mentioned [21:48:47] (CR) Cdentinger: [C: 2] Fix a couple comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337687 (owner: Ejegg) [21:50:11] looking eileen1 [21:50:47] (Merged) jenkins-bot: Fix a couple comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337687 (owner: Ejegg) [21:51:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: for BannerLoader call, handle 301 and other responses on client - https://phabricator.wikimedia.org/T158124#3027327 (AndyRussG) [21:52:19] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM log is showing errors relating to importing bounces - https://phabricator.wikimedia.org/T157397#3027343 (Ejegg) Seems fine to just shut up the error. Somewhere down the line... [21:55:39] Fundraising-Backlog: Update 'Amazon Payments' branding - https://phabricator.wikimedia.org/T158016#3027357 (DStrine) p:Triage>Normal [22:08:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: for BannerLoader call, handle 301 and other responses on client - https://phabricator.wikimedia.org/T158124#3027443 (ggellerman) p:Triage>Normal [22:09:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Central Notice banners slow to save - https://phabricator.wikimedia.org/T158084#3027449 (DStrine) a:AndyRussG>None [22:10:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Central Notice banners slow to save - https://phabricator.wikimedia.org/T158084#3027451 (ggellerman) p:Triage>Normal [22:14:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Move contribution_tracking out of drupal db - https://phabricator.wikimedia.org/T158010#3027465 (ggellerman) p:Triage>Normal [22:15:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Spike: Spike: Investigate using Redis INCR ids as a drop-in replacement for ct_id - https://phabricator.wikimedia.org/T158007#3027471 (ggellerman) p:Triage>Normal [22:17:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing created_date for contacts between 2015-10-28 and 2016-05-03 - https://phabricator.wikimedia.org/T157825#3027497 (DStrine) [22:21:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Missing created_date for contacts between 2015-10-28 and 2016-05-03 - https://phabricator.wikimedia.org/T157825#3027522 (ggellerman) p:Triage>Normal [22:21:45] (CR) XenoRyet: [C: 2] Add missing method visibility [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337658 (owner: Ejegg) [22:22:29] Fundraising-Backlog: Update on call protocols - https://phabricator.wikimedia.org/T157731#3027530 (ggellerman) Open>Resolved p:Triage>Normal [22:24:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: What fundraising dbs and tables to we not need to replicate? - https://phabricator.wikimedia.org/T157717#3027532 (ggellerman) Open>Invalid [22:24:22] (Merged) jenkins-bot: Add missing method visibility [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/337658 (owner: Ejegg) [22:25:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: What fundraising dbs and tables to we not need to replicate? - https://phabricator.wikimedia.org/T157717#3027536 (cwdent) At this point I don't think we can choose to replicate one table and not another. [22:40:30] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM log is showing errors relating to importing bounces - https://phabricator.wikimedia.org/T157397#3027568 (MBeat33) Many thanks, @Eileenmcnaughton that's a neat query. We'd ha... [23:59:05] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Value Subtracting, and 3 others: [Spike] investigate contribution tracking data (was Engage import failing ... - https://phabricator.wikimedia.org/T146295#3027779