[00:21:10] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [EPIC] new round of common dedupe conflicts - https://phabricator.wikimedia.org/T153019#3031726 (DStrine) [00:21:21] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] new round of common dedupe conflicts - https://phabricator.wikimedia.org/T153019#2866661 (DStrine) [00:37:46] (PS1) Eileen: Further Benevity report fix on handling on formatted '0'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/338031 (https://phabricator.wikimedia.org/T115044) [00:38:06] XenoRyet: I wonder if you can review that v small change above - then I can get Leanne to retest [00:38:28] Sure, let me take a quick look. [00:39:51] (CR) XenoRyet: [C: 2] Further Benevity report fix on handling on formatted '0'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/338031 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [00:40:00] Yea, straightforward enough. [00:40:31] thanks [00:40:36] No worries [00:45:35] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/338033 [00:45:47] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/338033 (owner: Eileen) [00:47:23] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/338033 (owner: Eileen) [00:49:17] !log Update CiviCRM from 1ffc090b7a3d04883afb17ee0f6965cb0eeca14b to 20660c427552771d7006485840a22b92da60692e [00:49:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:03:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Currency conversion for non-USD matching gift wires - https://phabricator.wikimedia.org/T158267#3031832 (LeanneS) [01:21:47] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Stop creating addresses N0NE Provided & delete them where we have them - https://phabricator.wikimedia.org/T158268#3031850 (Eileenmcnaughton) [01:35:36] fundraising-tech-ops, Operations: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#3031904 (Dzahn) a:Dzahn [01:35:41] fundraising-tech-ops, Operations: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#2987822 (Dzahn) Open>Resolved [01:39:08] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising-Backlog, and 2 others: Purge Varnish cache when a banner is saved - https://phabricator.wikimedia.org/T154954#3031931 (AndyRussG) [01:41:54] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: We still have contacts whose merge is blocked on mis-rounded geocodes - https://phabricator.wikimedia.org/T158271#3031937 (Eileenmcnaughton) [01:44:04] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] new round of common dedupe conflicts - https://phabricator.wikimedia.org/T153019#3031954 (Eileenmcnaughton) [01:44:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What should we do to fix data where blank addresses have overwritten valid addresses - https://phabricator.wikimedia.org/T153917#3031955 (Eileenmcnaughton) [01:44:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What should we do to fix data where blank addresses have overwritten valid addresses - https://phabricator.wikimedia.org/T153917#2894976 (Eileenmcnaughton) We need to resolve this from a dedupe perspective as they are blocking dupes & we should f... [01:45:37] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Tests, User-zeljkofilipin: CentralNotice: Intermittent unexplained browser test failures - https://phabricator.wikimedia.org/T145718#3031963 (AndyRussG) Browser tests are [[ https://integr... [01:45:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: [Tracking] CentralNotice: Unexplained banner display failures - https://phabricator.wikimedia.org/T145719#3031966 (AndyRussG) [01:45:52] Fundraising Sprint Rocket Surgery 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Tests, User-zeljkofilipin: CentralNotice: Intermittent unexplained browser test failures - https://phabricator.wikimedia.org/T145718#3031965 (AndyRussG) Open>Resolved [01:47:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: [Tracking] CentralNotice: Unexplained banner display failures - https://phabricator.wikimedia.org/T145719#3031971 (AndyRussG) Closing because subtasks :P [01:48:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: [Tracking] CentralNotice: Unexplained banner display failures - https://phabricator.wikimedia.org/T145719#3031974 (AndyRussG) Open>Resolved [11:54:34] fundraising-tech-ops: rename backup4001 to frbackup4001 and jessie reimage - https://phabricator.wikimedia.org/T158220#3032704 (mark) [13:52:08] fundraising-tech-ops: rename backup4001 to frbackup4001 and jessie reimage - https://phabricator.wikimedia.org/T158220#3032944 (Jgreen) Sounds good. This box only does offsite backups, so we need at most 6-8GB for the OS partition. [16:40:42] hi XenoRyet [16:40:52] Hey there [16:40:58] how's it going? [16:41:03] Was just getting ready to do that DI deploy [16:41:09] nice! [16:47:42] On the non-work front, it's a pretty tough day. Cat's uncle has been fighting cancer for a while now, and he made the decision today to stop treatment. Could be he has days left, but could be just hours. [16:48:08] fundraising-tech-ops: rename backup4001 to frbackup4001 and jessie reimage - https://phabricator.wikimedia.org/T158220#3033548 (RobH) Do the offsite backups go into /srv or elsewhere? If they go elsewhere, perhaps this should break convention and just have a large / partition, or have that data backup direc... [16:48:13] oh man, I'm sorry to hear that [16:48:34] sending virtual hugs [16:48:40] Thanks. It's not something totally unexpected, but she's still having a pretty tough time with it. [16:48:44] i bet [16:49:06] They're a pretty close family. [16:49:43] My attendance might get spotty later in the day, but for now there's really nothing to do so I'll just work. [16:50:15] fundraising-tech-ops: rename backup4001 to frbackup4001 and jessie reimage - https://phabricator.wikimedia.org/T158220#3033551 (Jgreen) It's configurable so I'll just set it for /srv/archive. [16:53:08] (PS3) Ejegg: Look up iDEAL banks, provide PSR6 to SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/337420 (https://phabricator.wikimedia.org/T128692) [16:55:40] fundraising-tech-ops: rename backup4001 to frbackup4001 and jessie reimage - https://phabricator.wikimedia.org/T158220#3033579 (RobH) Awesome, thanks! Is there anything that needs to be done before we shut this down and do the reimage? [17:00:37] fundraising-tech-ops: rename backup4001 to frbackup4001 and jessie reimage - https://phabricator.wikimedia.org/T158220#3033602 (Jgreen) Nope. I already disabled monitoring. [17:08:35] OK fr-tech, I think the DonationInterface part of the iDEAL bank lookup is finally ready for showtime: https://gerrit.wikimedia.org/r/337420 [17:18:54] ejegg: Looks like your mediawiki cache for IP velocity patch is going to go out with this deploy, in case you want to keep an eye on that. [17:19:43] XenoRyet: oh, thanks for the reminder. I'll definitely be watching the logs [17:33:24] (PS1) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338144 [17:33:50] (Abandoned) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338144 (owner: XenoRyet) [17:37:43] (PS1) Ejegg: Normalized subscr_ messages for tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/338145 (https://phabricator.wikimedia.org/T107372) [17:43:45] Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising-Backlog, FR-Smashpig, Spike: Spike: investigate smashpig next steps - https://phabricator.wikimedia.org/T156863#3033799 (K4-713) @Ejegg Yes, I was envisioning Phase 1 being not SmashPig as it is now... [17:50:23] (PS1) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/338147 [17:51:23] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/338147 (owner: XenoRyet) [18:00:21] fr-tech: If you already know what recursion is, just remember the answer. [18:00:21] Otherwise, find someone who is standing closer to Douglas Hofstadter [18:00:21] than you are; then ask him or her what recursion is. [18:00:21] -- Andrew Plotkin [18:00:21] -- discuss. [18:03:37] fr-tech anyone up for -talk? [18:04:25] i am there [19:19:45] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/338147 (owner: XenoRyet) [19:23:57] (PS1) XenoRyet: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/338155 [19:24:17] (CR) XenoRyet: [C: 2] Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/338155 (owner: XenoRyet) [19:30:51] (CR) Umherirrender: [C: 2] "Resubmit" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/336085 (owner: Umherirrender) [19:54:48] (Merged) jenkins-bot: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/338155 (owner: XenoRyet) [19:54:54] (Merged) jenkins-bot: Add file for special page aliases [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/336085 (owner: Umherirrender) [20:06:01] (PS1) AndyRussG: Add $wgCentralSelectedMobileBannerDispatcher global for mobile [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/338160 (https://phabricator.wikimedia.org/T154954) [20:22:13] (CR) jerkins-bot: [V: -1] Add $wgCentralSelectedMobileBannerDispatcher global for mobile [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/338160 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [20:38:03] (PS3) AndyRussG: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) [20:40:19] (CR) jerkins-bot: [V: -1] Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [20:51:45] fr-tech so sorry I got carrird away with Spanish practice [20:52:01] de nada! [20:52:26] i will email my update [22:11:11] ejegg: Zuul finished mulling over that merge patch. I was going to finish up that deploy now if that's cool with you. [22:11:23] please do! [22:17:22] !log updated paymentswiki from 4466b9deffcab144cdcddd511a3032513370a44d to 2a0c3b2148805fe258f124a700e7f3c34f306783 [22:17:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:20:26] Alright, that's out. Stuff is still up, watching the logs. [22:20:43] cool! [22:36:47] Fundraising-Backlog, FR-Ingenico: turn on 3DS for Sweden, Norway and Denmark - https://phabricator.wikimedia.org/T158357#3034779 (DStrine) [22:56:06] (PS1) Ejegg: Use dependency injection to get BankPaymentProvider [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338277 (https://phabricator.wikimedia.org/T128692) [22:57:01] fr-tech this follow-on patch lets us mock the highest-level smashpig object instead of the cURL response ^^^ [22:57:12] but I'm still not totally happy with it [23:36:17] i was juat reading the rfc for dependency injection in mediawiki core [23:37:50] it reminded me that a good way to get objects out of the smashpig config is to use factories [23:40:12] "enterprise" [23:41:18] ejegg: where is that rfc? [23:42:29] https://www.mediawiki.org/wiki/Requests_for_comment/Dependency_injection [23:44:00] ty [23:44:16] heh, i think it is actually the way to go here. put the map in smashpig config and have a payment provider factory method to retrieve them [23:45:18] hmm, though it also recommends only calling the static stuff from entry points. seems right. [23:46:13] but it feels like most of donationinterface is going to be the 'entry point' once enough gets pushed down to SmashPig. [23:47:24] these are higher level "rules" than i've ever considered with DI/IoC [23:47:56] they are probably good advice, i'm just not that familiar with mediawiki [23:53:04] made sense to me as a way to avoid too much interdependency [23:56:43] yeah definitely a good practice, just some stuff on that page seems pretty MW specific [23:59:31] specific entry points, sure