[01:21:59] (Abandoned) Ejegg: WIP add PaymentParameters and BasePaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333153 (owner: Ejegg) [01:23:25] (Abandoned) Ejegg: WIP add Ingenico bank payment provider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333155 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [02:03:43] (PS1) Ejegg: Fixes for iDEAL/PSR-6 caching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/339107 (https://phabricator.wikimedia.org/T128692) [02:15:03] (CR) jerkins-bot: [V: -1] Fixes for iDEAL/PSR-6 caching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/339107 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [04:28:52] (PS2) Ejegg: Fixes for iDEAL/PSR-6 caching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/339107 (https://phabricator.wikimedia.org/T128692) [07:46:02] fundraising-tech-ops, DBA: fundraising database tuning - https://phabricator.wikimedia.org/T158446#3045687 (Marostegui) >>! In T158446#3044038, @Jgreen wrote: > innodb_buffer_pool_size yep, I've increased that to 75-80% of system RAM. > > The tables are all innodb but the config dates back before we wer... [12:30:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Localizable messages with spaces in the name cause fatal exception - should fail gracefully - https://phabricator.wikimedia.org/T58105#3046317 (Aklapper) [15:54:45] fundraising-tech-ops, DBA: fundraising database tuning - https://phabricator.wikimedia.org/T158446#3046880 (Jgreen) >>! In T158446#3045687, @Marostegui wrote: >>>! In T158446#3044038, @Jgreen wrote: >> innodb_buffer_pool_size yep, I've increased that to 75-80% of system RAM. >> >> The tables are all inn... [15:54:59] fundraising-tech-ops, DBA: fundraising database tuning - https://phabricator.wikimedia.org/T158446#3046881 (Jgreen) p:Triage>Normal [15:58:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration, Wikimedia-log-errors: "Internal error" on testwiki's Special:LanguageStats due to non-existing CentralNotice banner - https://phabricator.wikimedia.org/T157997#3046889 (DStrine) [17:18:16] fundraising-tech-ops, Operations, Traffic, HTTPS: update SSL certificate for benefactorevents.wikimedia.org by 2017-03-02 - https://phabricator.wikimedia.org/T158684#3043892 (CaitVirtue) Added Danny as a subscriber, as he's the event lead. [17:19:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can we make the nickname field searchable? - https://phabricator.wikimedia.org/T158784#3047164 (RLewis) [18:00:12] PSP mega-conversation is going long - I'mma relocate before fr-tech-talk. [18:00:21] fr-tech: Some people live life in the fast lane. [18:00:21] You're in oncoming traffic. [18:00:21] -- discuss. [18:01:00] Clam Jam just got interesting, I might do that instead, at least for the next 30 min or so [18:01:33] hehe [18:01:38] I'm sad this isn't being broadcast [18:01:52] Lightning talks about what different departments are planning to do for the year [18:02:00] Hopefully there's a recap at Metrics [18:02:08] oho [18:02:13] oh--"on air" light is in full effect. [18:08:36] my chainsaw is on the fritz and the temp is about to drop sharply and stay down, gotta do a little wood scavenging [18:09:02] Burn those books [18:29:48] fr-tech any words for Scrum of Scrums? [18:30:46] AndyRussG: Were you still thinking of another round of collaboration around the cache purge? [18:30:57] Seemed like you have a good handle on that, though. [18:46:02] awight: hey! Mmmm I think it does need work as you indicated... Would you like to group-pounce on IRC -operations sometime? [18:47:46] k [18:49:29] fr-tech also, for instrumenting a prod logging thing for banner save slowness checks, I guess maybe we don't need to deploy and revert right away? Probably it's low-volume enuf to log for a little while, no? [18:49:50] Oh here's an idea! We could make it log based on a URL param... [18:50:06] Hmmm Dunno actually, since it's a post from a form, that'd be more complex than it's worth [18:50:09] ok, i'll give ops the heads up you might ask about a copule things [18:50:59] ejegg|meet: ah yeah! it'll be just some varnish cache purge details... Actually, could you ask who is the current guru on PHP-side cache purge code? I've talked to bblack, but he mainly concentrates on Varnish itself [18:52:55] Sure! [18:52:55] I think your permutation engine will work as-is, though, and probably won't hurt site performance [18:53:29] we can ask hive if all browsers are ordering the parameters the same way, right? [18:53:45] Hey, our channel logging went down 3 days ago: http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-fundraising/ [18:53:50] wm-bot: wassup? [18:53:50] o no! [18:54:07] the gerrit assignment bot has been on the fritz too [18:54:10] ejegg: yeah we can ask Hive that [18:54:21] i pinged the maintainer, let's see... [18:54:37] ejegg: I do like awight's regex idea, if it's feasible [18:54:48] Maybe if there's no core access it'd be easy to add [18:54:55] AndyRussG: Good thing to check, but since the jobs are deferred, I don't expect there will be a UI delay [18:55:01] yeah, 'ban' is odd terminology, but it looks like the right functionality [18:56:10] AndyRussG: ack, sorry, I missed your request to ask for a guru [18:56:35] mobbing -operations should do the trick [18:56:43] awight: though also regexy would simplify the code a lot, and cover us for randomordered params [18:56:57] ejegg: no worries, sorry I just thought of it at the last minute! [18:59:18] fr-tech tiny fixes for the iDEAL lookup patch: https://gerrit.wikimedia.org/r/339107 [18:59:31] ejegg: k I can CR that [18:59:35] ty! [19:00:18] cwd: can you help with a deploy? Just need a couple lines added to SmashPig.yaml [19:00:23] (CR) Awight: [C: 2] Fixes for iDEAL/PSR-6 caching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/339107 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [19:00:44] * awight smiles at proliferation of fr-opsen [19:00:55] ejegg: awight: so I'll ping folks on Ops now, K? [19:00:56] :):):) [19:01:00] sure lemme see [19:03:04] (Merged) jenkins-bot: Fixes for iDEAL/PSR-6 caching [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/339107 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [19:03:09] AndyRussG: rad, I'm there [19:04:23] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint Dirt Farming, and 6 others: Store and update list of currenly working iDEAL banks - https://phabricator.wikimedia.org/T128692#3047622 (awight) [19:05:36] awight: ejegg: one sec, just lemme see who's worked on that PHP code most recently.... [19:11:56] K done [19:19:51] fundraising-tech-ops, Operations, Traffic, HTTPS: update SSL certificate for benefactorevents.wikimedia.org by 2017-03-02 - https://phabricator.wikimedia.org/T158684#3047685 (EWilfong_WMF) @Jgreen @RobH - Checking in on our next steps here. I would love to get the new cert in place this week so w... [19:21:20] cwd 'deprecate globalcollect resultswitcher' will go out along with the iDEAL lookup [19:21:51] oh yikes [19:22:37] fundraising-tech-ops, Operations, Traffic, HTTPS: update SSL certificate for benefactorevents.wikimedia.org by 2017-03-02 - https://phabricator.wikimedia.org/T158684#3047689 (RobH) @EWilfong_WMF: Just wanted to check, we'll be generating the private key, csr, and ordering the certificate. In t... [19:24:41] fundraising-tech-ops, Operations, Traffic, HTTPS: update SSL certificate for benefactorevents.wikimedia.org by 2017-03-02 - https://phabricator.wikimedia.org/T158684#3047695 (EWilfong_WMF) Perfect. ewilfong@trilogyinteractive.com [19:35:34] Fundraising-Backlog, fundraising-tech-ops: database access to additional CPS analyst - https://phabricator.wikimedia.org/T155746#3047709 (Jgreen) Access request was approved by Lisa in email on 2/21/2017 [19:58:37] fundraising-tech-ops, Operations, Traffic, HTTPS: update SSL certificate for benefactorevents.wikimedia.org by 2017-03-02 - https://phabricator.wikimedia.org/T158684#3047812 (RobH) a:Jgreen>RobH I'll handle key/csr generation and cert ordering. Then I'll pgp encrypt and email the key ove... [20:23:03] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, and 4 others: [Spike] investigate contribution tracking data (was Engage import fail... - https://phabricator.wikimedia.org/T146295#3047905 [20:25:45] AndyRussG: gawd, sorry I got whisked away by IRL just as you mobbed -operations. Reading backscroll now. [20:26:22] awight: not much news there... [20:28:04] I was just reading CdnCacheUpdate::HTCPPurge() [20:28:10] (which is where I think we go) [20:29:16] Darn. I see. [20:31:03] My guess was that the next block was what actually did the purge, SquidPurgeClient... lemme check config variables. [20:32:08] $wgHTCPRouting is set, so you're right that HTCPPurge gets run [20:32:18] fr-tech so... I really should add more error handling in the SmashPig side of things before deploying that iDEAL lookup [20:32:23] awight: I think we could change the JS to construct URLs with deterministic param order [20:32:45] but I've got a few patches up that will mergeconflict all over the place with any error handling [20:32:47] looks like $wgSquidServers is not set, so it's *only* the HTCPPurge [20:32:55] yep [20:33:05] ejegg: i am still trying to get vpn working so i can test the result switcher thing which i am nervous about [20:33:07] Then we'd just have to make sure our massive purge doesn't overwhelm poor little Varnish [20:33:36] Any idea what the cdn-url-purges event relayer is doing? [20:33:43] if anyone has a chance to look at these, I'd be grateful: https://gerrit.wikimedia.org/r/338303 , https://gerrit.wikimedia.org/r/338306 , https://gerrit.wikimedia.org/r/338300 [20:34:11] cwd I've theoretically got the new VPN working, but requests all seem to time out [20:35:13] ejegg: looking... [20:35:43] ty [20:36:20] Ingenico\Api is begging for tests... [20:36:27] yeah... [20:36:34] ok, I'll add some [20:36:35] ! [20:36:38] ty for the prod [20:36:43] Smoke tested at least? [20:36:54] barely [20:37:04] I'll add em - no hurry to deploy this right now [20:37:04] meh I don't need to be picky [20:37:06] kk [20:37:22] relocating to higher bandwidth [20:38:00] I've been spoiled by writing pytests lately, where you can mock absolutely anything [20:38:38] ejegg: looks hellof annoying to test, nvm me [20:39:17] oh and sorry, this is just moving existing code. [20:39:29] * awight goes O_o at new Ingenico API [20:40:12] (CR) Awight: [C: 1] "I think it's fine w/o tests." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [20:40:40] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, and 4 others: [Spike] investigate contribution tracking data (was Engage import fail... - https://phabricator.wikimedia.org/T146295#3047969 [20:45:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration, Wikimedia-log-errors: "Internal error" on testwiki's Special:LanguageStats due to non-existing CentralNotice banner - https://phabricator.wikimedia.org/T157997#3048004 (Samuele2002) This problem is mo... [20:45:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration, Wikimedia-log-errors: "Internal error" on testwiki's Special:LanguageStats due to non-existing CentralNotice banner - https://phabricator.wikimedia.org/T157997#3048005 (Samuele2002) This problem is mo... [20:46:20] (CR) Awight: [C: 2] Reduce Configuration use in BankPaymentProvider (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338306 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [20:47:25] Fundraising Sprint Deferential Equations, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Central Notice banners slow to save - https://phabricator.wikimedia.org/T158084#3048010 (AndyRussG) Thanks @Jseddon! Some notes so far: - This is not happening on the beta cluster. - On production, it... [20:47:43] guys am I in the right place - trying to be on standup but only a noiseless ejegg[m] is here [20:47:48] (CR) Awight: [C: 2] Get some static Config access out of Authenticator [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338300 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [20:47:49] awight: ? [20:48:48] eileen1: oops! dstrine and I are lunching, amidst a day-long meeting [20:49:08] is it a good lunch [20:49:41] (Merged) jenkins-bot: Reduce Configuration use in BankPaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338306 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [20:49:43] (Merged) jenkins-bot: Get some static Config access out of Authenticator [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338300 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [20:51:05] hehe well there is one vegetarian dish [20:51:24] * awight can now confirm that this one dish is tasty [20:51:58] My standup is: distracted by meeting, and I'm doing some low-intensity review [21:01:17] AndyRussG: Maybe we could get ops attention by filing a task to implement ban or regex purging? [21:01:43] Or shall we forge ahead with the megamultipermutor? [21:06:45] Anyone have a task to give me? [21:23:02] awight: highest priority right now is probably the remaining PayPal EC stuff [21:23:44] Oh, but here's XenoRyet to pick that back up [21:24:35] (was just mentioning the PayPal EC stuff to awight) [21:25:04] o/ [21:26:56] (PS1) Ejegg: Throw a descendent of SmashPig exception on cURL fail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/339273 [21:28:51] Hey. I'm afraid I'm kind of useless today, but I am physically back at my desk. [21:28:55] What did I miss? [21:32:39] Well, awight is back in action! [21:33:03] Yea, I noticed that. Welcome back! [21:34:50] (PS2) Ejegg: Move Ingenico base API wrapper functions to own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) [21:35:18] (CR) Ejegg: "PS2: rebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [21:39:36] hi! [22:17:49] ejegg: i am trying to brainstorm a way to test the iframe redirect without the vpn [22:18:33] cwd uff [22:18:42] if we could override to just set some stuff in the session and forward to the returnurl [22:18:53] is it hard because of curl? [22:19:15] fortunately it's easy to override cURL in DonationInterface [22:19:32] you could even change the class mapping wgDonationInterfaceGateways (i think) [22:19:36] to point to the test classes [22:20:02] and the cURL function will read responses out of the test folders [22:20:11] so... that might work [22:20:42] that sounds interesting [22:20:58] hehe, actually, if you manipulate one of those so the 'globalcollect' URL it returns points to something on localhost [22:21:19] you could just make a page that redirects to the returnURL [22:21:33] that's true [22:22:41] we could build our own globalcollect test endpoint appliance [22:25:50] (PS3) Ejegg: Move Ingenico base API wrapper functions to own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) [22:26:39] i feel like we've been talking about mock payment providers for a while [22:27:27] (CR) Ejegg: "awight Added a test anyway, if only to learn about PHPUnit mocks." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [22:28:21] (CR) Awight: [C: 2] "Right on! Confidence boosted." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [22:28:48] ejegg: see the email about deleting contributions from Rosie - do you have any further thoughts on it? [22:29:01] looking [22:30:00] (Merged) jenkins-bot: Move Ingenico base API wrapper functions to own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/338303 (https://phabricator.wikimedia.org/T158374) (owner: Ejegg) [22:31:57] eileen1: heh, I didn't know about the batch delete function in the UI! [22:32:13] If there is one, I'd be inclined to trust it [22:32:23] :-) [22:32:36] hmm, I guess except it wouldn't know to clear out the contribution id in contribution_tracking [22:53:05] i'm gonna shove off early for dinner with the rents, back later! [22:58:12] (CR) Ejegg: [C: 2] "Nice magic string consolidation, and hooray for more overridable behavior!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/338634 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [23:04:10] (Merged) jenkins-bot: Further Benevity fix, resolve error in 'None Provided By Donor fix' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/338634 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [23:17:40] brrrr - frigid in this cafe [23:17:53] back on soon from someplace warmer [23:46:37] !log turned off 3DS requirement for Denmark on payments-wiki [23:46:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log