[00:00:06] isn't the second bug the same - ie. name data is not present [00:00:13] because it wasn't in civi? [00:00:25] For sure [00:00:42] Thanks, now this is resolved after all! [00:00:45] awight: yeah, if we legitimately don't have a fname/lname, email seems like the next best representative [00:00:54] let's ask MBeat [00:02:08] (catching up) so, is it as simple as if there’s no name available Civi will plug in email address? [00:02:20] yep! [00:02:26] ha! [00:03:20] some will still have no name at all, or is that a resolved error? [00:04:52] I’ll update Collab documentation about the ‘email as name’ being intended so all DS knows - and ty all [00:06:26] MBeat: I think we were able to backfill all the names [00:06:28] MBeat: I'm hoping the data is fixed for those who do have names - which will be most of them [00:06:36] awesome, yay [00:16:06] I've done my checks on this one https://gerrit.wikimedia.org/r/#/c/340686/ & I think it gets rid of half a million blank addresses safely [00:16:25] ooh, nice! [00:16:28] looking [00:21:12] ejegg: btw I'm restoring the address tables on staging atm because I didn't do a count(*) FROM civicrm_address before running it - but I have now & feel the numbers work [00:23:40] ok, cool. [00:23:59] this does feel like a safe first step [00:24:13] just poking at it locally [00:24:45] :-) [00:24:55] it terms of scale it gets rid of 50% [00:26:40] (PS1) Awight: More verbose test titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341468 [00:26:42] (PS1) Awight: Comments and whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341469 [00:26:44] (PS1) Awight: Check for maintenance mode before anything [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341470 [00:33:41] TBH it's a bit depressing there are so many of these blank address records - it was going on a long time :-( [00:34:50] eileen: That reminds me, I forgot to take note of an important followup task to write tests that would have caught this. [00:35:39] gotta pop off for a bit, back later! [00:38:34] awight: so, I *think* on the address blanks I did, obviously not on the blanking of first_name etc [01:06:39] eileen: Sorry, I missed something there. You saying the patch should fix all of the blank addresses? [01:07:18] no [01:07:23] well [01:07:34] so, there was a patch so stop creatning new ones [01:07:37] more than a month ago [01:07:47] but, getting rid of old ones takes some unravelling [01:09:25] I'm surprised there was appetite for backfilling the old addresses, IIRC we don't do much with physical location [01:09:51] guess this is the downside of not being in crisis mode ;-) [01:49:35] awight: well I think there is an appetite for doing some of it - maybe not as it gets really tricky [01:49:54] I expect there will be diminishing returns on it until we give up [01:53:00] (PS1) Eileen: Remove obsolete blank address from tracking table. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341476 (https://phabricator.wikimedia.org/T159402) [01:58:48] (PS1) Awight: Comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341477 [01:58:50] (PS1) Awight: Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 [01:59:42] (PS2) Eileen: Remove obsolete blank address from tracking table. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341476 (https://phabricator.wikimedia.org/T159402) [02:00:45] (CR) jerkins-bot: [V: -1] Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 (owner: Awight) [02:04:14] (PS2) Awight: Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 [02:06:42] (PS3) Awight: Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 [02:18:54] (PS3) Eileen: Remove obsolete blank address from tracking table. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341476 (https://phabricator.wikimedia.org/T159396) [03:31:39] (PS4) Eileen: Remove obsolete blank address from tracking table. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341476 (https://phabricator.wikimedia.org/T159396) [03:31:42] (PS1) Eileen: Remove geocoding blank addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 [04:21:05] (PS2) Eileen: Remove bulk update blank addresses from being treated as 'updates'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 [04:25:35] (PS3) Eileen: Remove bulk update blank addresses from being treated as 'updates'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 (https://phabricator.wikimedia.org/T159396) [04:26:13] (PS4) Eileen: Remove bulk update blank addresses from being treated as 'updates'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 (https://phabricator.wikimedia.org/T159396) [04:32:22] (PS5) Eileen: Remove bulk update blank addresses from being treated as 'updates'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 (https://phabricator.wikimedia.org/T159396) [09:14:24] (CR) Hashar: "check experimental" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/340120 (https://phabricator.wikimedia.org/T158074) (owner: Zfilipin) [09:34:32] (CR) Hashar: [C: 2] Update tests to Selenium 3 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/340120 (https://phabricator.wikimedia.org/T158074) (owner: Zfilipin) [09:44:05] (Merged) jenkins-bot: Update tests to Selenium 3 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/340120 (https://phabricator.wikimedia.org/T158074) (owner: Zfilipin) [12:56:11] Wikimedia-Fundraising: Sidebar appears over fundraising "nag" banner on German Wikipedia - https://phabricator.wikimedia.org/T158865#3079839 (Pcoombe) Open>Resolved @spatton fixed this in the banner template to override the .mw-body z-index. Thanks! [12:56:13] Wikimedia-Fundraising-Campaigns (FY Q3 Jan-Mar 2017), Wikimedia-CentralNotice-Administration (Q1-2017): WMF Fundraising - 2016-17 - Austria (Mar 7 - Apr 4) - https://phabricator.wikimedia.org/T157119#3079841 (Pcoombe) [16:15:04] (CR) Ejegg: [C: 2] "A very sensible start" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/340686 (https://phabricator.wikimedia.org/T159402) (owner: Eileen) [16:19:14] (Merged) jenkins-bot: Remove unchanged insertions of blank addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/340686 (https://phabricator.wikimedia.org/T159402) (owner: Eileen) [16:29:20] (CR) Ejegg: [C: 2] Remove obsolete blank address from tracking table. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341476 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [16:33:23] (Merged) jenkins-bot: Remove obsolete blank address from tracking table. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341476 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [16:34:14] (CR) Ejegg: [C: 2] "Looks fine. Seems odd that any blanks would be affected by the geocoding updates since we limited those to the US country_id." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [16:38:56] (Merged) jenkins-bot: Remove bulk update blank addresses from being treated as 'updates'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [16:39:33] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#995314 (MBeat33) Matt @ PayPal removed the e-check option on 3/6/2017. We should make sure to re-enable this method once EC is integrated. [17:00:37] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#3080699 (Ppena) ... only allowing these in when they actually settle (BPay/IDEAL style) :) [18:00:21] fr-tech: Fortune finishes the great quotations, #6 [18:00:21] "But, soft! What light through yonder window breaks?" [18:00:21] It's nothing, honey. Go back to sleep. [18:00:21] -- discuss. [18:11:39] hi fr-tech, anything happening in -talk? [18:11:53] hi! [18:12:13] I went deep down the rabbithole yesterday [18:12:43] Started making sequence diagrams of handleRequest cos I needed to refresh my memory of all that anyway. [18:13:01] fun! [18:13:23] now unified, thanks to work by cwd [18:13:50] yes, now it's like half a plate of spaghetti code and half a plate of cold beans :p [18:14:04] haha [18:19:24] (noted in etherpad) The motivation was to understand what could be going wrong with PayPal currency fallback. [18:20:00] This might be one of the "subtleties" cwd was rightfully concerned for. [18:20:24] PayPal legacy is silently redirecting regardless of the interstitial notification global [18:20:35] although unit tests pass, and errors are correctly registered! [18:20:55] PayPal EC is always stopping on the interstitial, with incorrect fallback currency :) [18:21:20] ah, right [18:21:55] i think the 'only one supported currency' rule wins over the fallback [18:23:07] that should be a configuration error [18:42:33] that sounds odd. but I've added more currencies locally, so that's probably not it. [18:52:16] Fundraising Sprint English Cuisine, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: Clean up confusing and repeated code in the PayPal express adapter - https://phabricator.wikimedia.org/T134445#3081296 (DStrine) [19:25:54] Fundraising-Backlog: error opening Annual Report in Safari Version 9.1.1 (10601.6.17) - https://phabricator.wikimedia.org/T159389#3066148 (DStrine) a:MBeat33 [19:26:09] Fundraising-Backlog: error opening Annual Report in Safari Version 9.1.1 (10601.6.17) - https://phabricator.wikimedia.org/T159389#3066148 (DStrine) This is not fr-tech. I'm not sure who would own this. [19:26:49] dstrine: ^ comms [19:27:19] yeah they don't have a phab area or engineers so I reassigned it to MBeat [19:27:41] maybe an email w/ link to the task [19:27:51] n e way, thanks for fielding the foul ball [19:28:31] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration, User-JSeddon: CentralNotice Product Roadmap - https://phabricator.wikimedia.org/T159305#3063611 (DStrine) This is a bit information light. @Jseddon you and I are currently doing some work around this... [19:29:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Spike: investigate getting silverpop data into civi - https://phabricator.wikimedia.org/T159767#3077997 (DStrine) [19:30:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Import unsubscribe data from Silverpop - https://phabricator.wikimedia.org/T112674#3081455 (DStrine) [19:31:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: More communication between Silverpop and Civi - https://phabricator.wikimedia.org/T114671#3081467 (DStrine) [19:43:32] Fundraising-Backlog, FR-Email: Add field to Silverpop export: first donation date - https://phabricator.wikimedia.org/T150467#3081583 (DStrine) [19:55:55] (PS1) Awight: [WIP] Form did not validate if manual errors are present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341592 (https://phabricator.wikimedia.org/T98447) [19:56:09] cwd: subtleties? ^ :D [19:57:40] heh... does indeed look subtle [20:10:24] (PS1) XenoRyet: PayPal subscription message normalization [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/341595 (https://phabricator.wikimedia.org/T107372) [20:57:25] (CR) Eileen: "Yeah, I thought that about blanks + country, but didn't dig too much" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341486 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [21:07:55] (CR) XenoRyet: [C: 1] "Looks good and tests pass locally. Not sure why Jenkins hates it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341429 (https://phabricator.wikimedia.org/T159755) (owner: Awight) [21:19:11] (CR) XenoRyet: [C: 2] More verbose test titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341468 (owner: Awight) [21:20:26] (CR) XenoRyet: [C: 2] Comments and whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341469 (owner: Awight) [21:21:32] (CR) XenoRyet: [C: 2] Check for maintenance mode before anything [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341470 (owner: Awight) [21:21:38] XenoRyet|food: thanks! [21:22:09] No worries, some light CR was just the ticket just now. [21:22:39] XenoRyet: I'd love yr opinion on this WIP at some point, https://gerrit.wikimedia.org/r/341592 [21:22:51] Yea, I'll take a look sometime soon. [21:51:55] fr-tech: Anyone understand why we have a distinction between "validation" and "manual" errors? [21:52:23] I.. should know this after 4.5 years but some things still don't make sense to me. [21:52:27] awight: notreally [21:52:35] Not off the top of my head, no. [21:52:38] The comments suggest that validation errors are set by the gateway (though they are not) and manual by other things [21:52:41] kk [21:52:44] That makes me feel much better. [21:52:57] I might just wipe that out until we discover we actually needed it. [21:53:01] I think this might be the first I've heard of manual errors in that context [22:08:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Donation form extends off the right side of the page in some mobile browsers - https://phabricator.wikimedia.org/T149247#3082066 (ggellerman) a:Pcoombe [22:08:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy import with foreign checks not working - https://phabricator.wikimedia.org/T159882#3082067 (Eileenmcnaughton) [22:11:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy import with foreign checks not working - https://phabricator.wikimedia.org/T159882#3082130 (ggellerman) p:Triage>Normal [22:11:53] Fundraising Sprint English Cuisine, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Trilogy import with foreign checks not working - https://phabricator.wikimedia.org/T159882#3082067 (ggellerman) [22:13:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Donation form extends off the right side of the page in some mobile browsers - https://phabricator.wikimedia.org/T149247#3082137 (Ejegg) Hi Peter! This is looking good on payments.wm.o now, but still extends off the side on donate.wm.o {F6305126} [22:16:25] Fundraising-Backlog: Improve documentation for emergency & on-call procedures - https://phabricator.wikimedia.org/T143266#3082159 (ggellerman) p:Triage>Normal [22:18:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: CiviCRM triggers should be the same on staging as on production - https://phabricator.wikimedia.org/T159507#3082179 (awight) p:Triage>Normal [22:18:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow query on live triggered by user dedupe - https://phabricator.wikimedia.org/T159752#3082180 (ggellerman) p:Triage>Normal [22:19:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow query on live triggered by user dedupe - https://phabricator.wikimedia.org/T159752#3082181 (Eileenmcnaughton) @MBeat33 said that this was caused when she did a merge & then cancelled (after doing another merge) [22:26:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM drush error message should never be HTML-formatted. And should prominently contain useful debugging info. - https://phabricator.wikimedia.org/T159506#3082203 (ggellerman) p:Triage>Normal [22:26:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM drush error message should never be HTML-formatted. And should prominently contain useful debugging info. - https://phabricator.wikimedia.org/T159506#3069802 (Eileenmcnaughton) JIRA is https://issues.civicrm.org/jira/browse/CRM-20185 [22:27:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Ensure that CiviCRM triggers are always the same on staging as on production - https://phabricator.wikimedia.org/T159507#3082211 (awight) [22:33:34] fundraising-tech-ops, Operations, ops-eqiad: rack and cable frdev1001 - https://phabricator.wikimedia.org/T159887#3082237 (Jgreen) [22:36:46] Fundraising-Backlog, fundraising-tech-ops, Spike: Spike: decide what to do with shoot_banners script - https://phabricator.wikimedia.org/T142064#3082259 (awight) K so... * The script is in source control, so we can revive any time. * @Jgreen @cwdent Please do save the screenshots produced by this too... [22:36:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#3082262 (awight) [22:37:00] Fundraising-Backlog, fundraising-tech-ops, Spike: Spike: decide what to do with shoot_banners script - https://phabricator.wikimedia.org/T142064#3082261 (awight) Open>Resolved [22:37:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Fix Feb 28 recurring glitch - https://phabricator.wikimedia.org/T159363#3082263 (ggellerman) Open>Resolved [22:37:07] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Ingenico recurring schedule glitch found in the wild - https://phabricator.wikimedia.org/T159298#3082264 (ggellerman) [22:40:40] (PS1) Eileen: Add trilogy payment_method to foreign checks import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341703 (https://phabricator.wikimedia.org/T159882) [22:55:35] (PS1) Eileen: Add & use Benevity financial type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341704 (https://phabricator.wikimedia.org/T115044) [22:59:03] relocating.. [23:00:03] small patches for review  https://gerrit.wikimedia.org/r/341704 & https://gerrit.wikimedia.org/r/#/c/341703/ [23:00:12] (CR) jerkins-bot: [V: -1] Add & use Benevity financial type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341704 (https://phabricator.wikimedia.org/T115044) (owner: Eileen) [23:00:14] should be non-onerous [23:00:39] opps one has test issue [23:03:39] Gonna walk some furniture between neighbors... [23:06:55] (PS2) Eileen: Add & use Benevity financial type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341704 (https://phabricator.wikimedia.org/T115044) [23:07:02] x-fingers this time [23:54:04] this cia leak is filled with great tips https://wikileaks.org/ciav7p1/cms/page_1179773.html [23:54:57] https://wikileaks.org/ciav7p1/cms/page_4849889.html [23:55:01] i owe the cia a beer [23:58:39] yeah! [23:59:05] I worry there will be a whole lot of security holes exposed in it that will cause us work [23:59:19] ya, entirely possible