[12:44:39] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, and 5 others: Purge Varnish cache when a banner is saved - https://phabricator.wikimedia.org/T154954#3095397 (ema) >>! In T154954#30921... [17:32:43] (Abandoned) Awight: [WIP] Play with stringification [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342176 (owner: Awight) [17:34:08] (PS2) Awight: Form should not validate if manual errors are present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341592 (https://phabricator.wikimedia.org/T98447) [17:34:10] (PS2) Awight: Remove deprecated function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341721 [17:34:12] (PS2) Awight: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 [17:34:14] (PS8) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 [17:36:49] (CR) jerkins-bot: [V: -1] [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (owner: Awight) [17:40:21] (PS2) Awight: More verbose test titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341468 [17:40:23] (PS2) Awight: Comments and whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341469 [17:40:25] (PS2) Awight: Check for maintenance mode before anything [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341470 [17:40:28] (PS2) Awight: Comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341477 [17:40:29] (PS4) Awight: Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 [17:40:31] (PS3) Awight: Form should not validate if manual errors are present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341592 (https://phabricator.wikimedia.org/T98447) [17:40:33] (PS3) Awight: Remove deprecated function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341721 [17:40:35] (PS3) Awight: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 [17:40:37] (PS9) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 [17:43:52] (CR) jerkins-bot: [V: -1] Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [17:44:16] (CR) jerkins-bot: [V: -1] [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (owner: Awight) [17:48:58] (CR) jerkins-bot: [V: -1] Remove deprecated function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341721 (owner: Awight) [18:00:21] fr-tech: Q: What regular expression do you often see around Christmas? [18:00:21] A: [^L] [18:00:21] -- discuss. [18:43:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: [Data Retention] Be more careful logging user IP to long-term logs. - https://phabricator.wikimedia.org/T160366#3096460 (awight) [19:30:26] (PS4) Awight: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 [19:31:15] (PS10) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 [19:34:15] (CR) jerkins-bot: [V: -1] [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (owner: Awight) [19:54:13] hey I was a bit late to standup - but no-one there [19:55:41] eileen: oops! Today is a WMF bribe holiday [19:55:46] ... not sure how else to describe that ;) [19:56:22] I hope your contracting arrangement includes holidays? [19:57:40] ah right, well not paid holidays, but that's standard for contracting [20:02:13] * awight ruffles feathers [20:03:01] * awight wonders how this works for int'l req number contractors [20:10:11] Sorry to rub it in... I'm working too, cos I followed my conscience earlier in the week. [20:33:37] (PS11) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 [20:37:00] (CR) jerkins-bot: [V: -1] [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (owner: Awight) [20:42:30] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface, Technical-Debt: [Tech Debt] Unit tests are sensitive to local SmashPig.yaml settings - https://phabricator.wikimedia.org/T160376#3096702 (awight) [20:56:17] (PS12) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 [20:59:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface CI tests are failing for MediaWiki 1.28 branch - https://phabricator.wikimedia.org/T160379#3096754 (awight) [22:29:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Spike: Better design for currency fallback stage - https://phabricator.wikimedia.org/T160384#3096885 (awight) [22:29:50] (CR) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (owner: Awight) [22:32:33] (CR) Awight: "> Random thought: maybe there should be a distinction between errors and informational messages." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (owner: Awight) [23:00:25] cwd|afk: ^ net negative lines [23:04:11] (PS13) Awight: [WIP] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 [23:04:13] (PS1) Awight: Comments and todos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342547 [23:04:15] (PS1) Awight: Correct parameters to wfMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342548 [23:11:07] Fundraising Sprint English Cuisine, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: [Tech Debt] Consolidate DonationInterface validation - https://phabricator.wikimedia.org/T160385#3096909 (awight) [23:11:15] (PS14) Awight: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) [23:13:12] Fundraising Sprint English Cuisine, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Technical-Debt: [Tech Debt] Consolidate DonationInterface validation - https://phabricator.wikimedia.org/T160385#3096909 (awight) [23:37:42] Fundraising Sprint English Cuisine, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Technical-Debt: [Tech Debt] Consolidate DonationInterface validation - https://phabricator.wikimedia.org/T160385#3096947 (awight) The form is prematurely validating, and T159910...